Hello!
> If you think I should reconsider the patch, you should resubmit it.
I understand this, of course. But, before doing this i'd like to
clarify your concern, why exactly you think that loopback test will
break. Because the (simplified) algorithm is:
do {
result = loopback_test()
On Tue, 2015-11-10 at 21:41 -0800, Tom Herbert wrote:
> Tolga, are you still planning to respin this patch (when tree opens?)
I was planning to add an union on skc_tx_queue_mapping and
sk_max_ack_backlog, so that adding a check on sk_max_ack_backlog in
listener lookup would not add an additional c
Hi
When both server and client are on the same machine and each their
socket option is set to SO_BINDTODEVICE, sometimes a packet doesn't
reach to the server.
The reproducible test program is attached. (modify "IF_ADDR=, IP_ADDR=,
PORT=" lines appropriately). Please try 'taskset -c 1 python test
Tolga, are you still planning to respin this patch (when tree opens?)
Thanks,
Tom
On Sat, Sep 26, 2015 at 7:24 PM, Eric Dumazet wrote:
> On Sat, 2015-09-26 at 19:02 -0700, Tolga Ceylan wrote:
>> By keeping hiscore/matches as is, I'm trying to keep the hashing consistent.
>> Otherwise, this woul
On 11/11/2015 06:03 AM, Daniel Borkmann wrote:
> We concluded that the skb_probe_transport_header() should better be
> called unconditionally. Avoiding the call into the flow dissector has
> also not really much to do with the direct xmit mode.
>
> While it seems that only virtio_net code makes u
On 11/11/2015 06:03 AM, Daniel Borkmann wrote:
> In tpacket_fill_skb() commit c1aad275b029 ("packet: set transport
> header before doing xmit") and later on 40893fd0fd4e ("net: switch
> to use skb_probe_transport_header()") was probing for a transport
> header on the skb from a ring buffer slot,
On Mon, Nov 02, 2015 at 07:31:34PM +0200, Madalin Bucur wrote:
> diff --git a/drivers/net/ethernet/freescale/dpaa/Makefile
> b/drivers/net/ethernet/freescale/dpaa/Makefile
> new file mode 100644
> index 000..3847ec7
> --- /dev/null
> +++ b/drivers/net/ethernet/freescale/dpaa/Makefile
> @@ -0,0
This happens during boot, (and then there's a flood of traces that happen so
fast
afterwards it completely overwhelms serial console; not sure if they're the
same/related or not).
==
BUG: KASAN: use-after-free in rtl8169_poll+0x4b6/
On Tue, Nov 10, 2015 at 11:46 AM, Shi, Yang wrote:
> On 11/9/2015 12:00 PM, Z Lim wrote:
>>
>> How about splitting this into two patches? One for the BPF-related
>> bug, and another for A64 FP-handling.
>
> I'm not sure if this is a good approach or not. IMHO, they are kind of
> atomic. Without A6
Yang,
On Tue, Nov 10, 2015 at 4:42 PM, Alexei Starovoitov
wrote:
> On Tue, Nov 10, 2015 at 04:26:02PM -0800, Shi, Yang wrote:
>> On 11/10/2015 4:08 PM, Eric Dumazet wrote:
>> >On Tue, 2015-11-10 at 14:41 -0800, Yang Shi wrote:
>> >>aarch64 doesn't have native support for XADD instruction, impleme
On Tue, Nov 10, 2015 at 2:41 PM, Yang Shi wrote:
> aarch64 doesn't have native store immediate instruction, such operation
Actually, aarch64 does have "STR (immediate)". For arm64 JIT, we can
consider using it as an optimization.
You may also want to consider adding a note about the correspondin
From: Måns Rullgård
Date: Wed, 11 Nov 2015 00:40:09 +
> When the DMA complete interrupt arrives, the next chain should be
> kicked off as quickly as possible, and I don't see why that would
> benefit from being done in napi context.
NAPI isn't about low latency, it's about fairness and inter
Andy Shevchenko writes:
> On Wed, Nov 11, 2015 at 1:07 AM, Måns Rullgård wrote:
>> Andy Shevchenko writes:
>
>> + nb8800_writel(priv, NB8800_TX_DESC_ADDR, txb->dma_desc);
>> + wmb(); /* ensure desc addr is written before starting
>> DMA */
>
> Hm… Have
On Tue, Nov 10, 2015 at 04:26:02PM -0800, Shi, Yang wrote:
> On 11/10/2015 4:08 PM, Eric Dumazet wrote:
> >On Tue, 2015-11-10 at 14:41 -0800, Yang Shi wrote:
> >>aarch64 doesn't have native support for XADD instruction, implement it by
> >>the below instruction sequence:
> >>
> >>Load (dst + off) t
Francois Romieu writes:
> Mans Rullgard :
>> diff --git a/drivers/net/ethernet/aurora/nb8800.c
>> b/drivers/net/ethernet/aurora/nb8800.c
>> new file mode 100644
>> index 000..11cd389
>> --- /dev/null
>> +++ b/drivers/net/ethernet/aurora/nb8800.c
> [...]
>> +static int nb8800_xmit(struct sk_
On Wed, Nov 11, 2015 at 1:07 AM, Måns Rullgård wrote:
> Andy Shevchenko writes:
> + nb8800_writel(priv, NB8800_TX_DESC_ADDR, txb->dma_desc);
> + wmb(); /* ensure desc addr is written before starting
> DMA */
Hm… Have I missed corresponding rmb() ? If i
On 11/10/2015 4:08 PM, Eric Dumazet wrote:
On Tue, 2015-11-10 at 14:41 -0800, Yang Shi wrote:
aarch64 doesn't have native support for XADD instruction, implement it by
the below instruction sequence:
Load (dst + off) to a register
Add src to it
Store it back to (dst + off)
Not really what is
Ido Barkan wrote:
Hi all,
We have this very disturbing issue on a few of our production servers,
which disconnects VMs
from their network.
* The Vms are part of an oVirt host so each vm is attached to a l2
bridge with a tap device.
* The bridge has an IP on it and is connected via a bond
Issue:
On Tue, 2015-11-10 at 14:41 -0800, Yang Shi wrote:
> aarch64 doesn't have native support for XADD instruction, implement it by
> the below instruction sequence:
>
> Load (dst + off) to a register
> Add src to it
> Store it back to (dst + off)
Not really what is needed ?
See this BPF_XADD as an a
On Tue, Nov 10, 2015 at 05:59:26PM -0600, Josh Hunt wrote:
> On Thu, Oct 29, 2015 at 5:00 AM, Sabrina Dubroca wrote:
> > 2015-10-15, 14:25:03 +0200, Sabrina Dubroca wrote:
> >> Without this length argument, we can read past the end of the iovec in
> >> memcpy_toiovec because we have no way of know
On Thu, Oct 29, 2015 at 5:00 AM, Sabrina Dubroca wrote:
> 2015-10-15, 14:25:03 +0200, Sabrina Dubroca wrote:
>> Without this length argument, we can read past the end of the iovec in
>> memcpy_toiovec because we have no way of knowing the total length of the
>> iovec's buffers.
>>
>> This is neede
On 11/11/2015 12:24 AM, Willem de Bruijn wrote:
On Tue, Nov 10, 2015 at 6:12 PM, Daniel Borkmann wrote:
On 11/10/2015 11:52 PM, Willem de Bruijn wrote:
if (sock->type == SOCK_DGRAM) {
- err = dev_hard_header(skb, dev, ntohs(proto), addr,
-
Mans Rullgard :
> diff --git a/drivers/net/ethernet/aurora/nb8800.c
> b/drivers/net/ethernet/aurora/nb8800.c
> new file mode 100644
> index 000..11cd389
> --- /dev/null
> +++ b/drivers/net/ethernet/aurora/nb8800.c
[...]
> +static int nb8800_xmit(struct sk_buff *skb, struct net_device *dev)
>
On Tue, Nov 10, 2015 at 6:12 PM, Daniel Borkmann wrote:
> On 11/10/2015 11:52 PM, Willem de Bruijn wrote:
>>>
>>> if (sock->type == SOCK_DGRAM) {
>>> - err = dev_hard_header(skb, dev, ntohs(proto), addr,
>>> - NULL, tp_len);
>>> +
On 11/10/2015 11:52 PM, Willem de Bruijn wrote:
if (sock->type == SOCK_DGRAM) {
- err = dev_hard_header(skb, dev, ntohs(proto), addr,
- NULL, tp_len);
+ /* In DGRAM sockets, we expect struct sockaddr_ll was filled
+
Andy Shevchenko writes:
> On Wed, Nov 11, 2015 at 12:34 AM, Måns Rullgård wrote:
>> Andy Shevchenko writes:
>>
+static inline void nb8800_maskb(struct nb8800_priv *priv, int reg,
+ u32 mask, u32 val)
+{
+ u32 old = nb8800_readb(priv, reg);
aarch64 doesn't have native store immediate instruction, such operation
has to be implemented by the below instruction sequence:
Load immediate to register
Store register
Signed-off-by: Yang Shi
CC: Zi Shen Lim
CC: Xi Wang
---
arch/arm64/net/bpf_jit_comp.c | 20 +++-
1 file ch
aarch64 doesn't have native support for XADD instruction, implement it by
the below instruction sequence:
Load (dst + off) to a register
Add src to it
Store it back to (dst + off)
Signed-off-by: Yang Shi
CC: Zi Shen Lim
CC: Xi Wang
---
arch/arm64/net/bpf_jit_comp.c | 19 +++
1
Current ARM64 BPF JIT doesn't have store immediate and XADD instructions
support, and aarch64 doesn't have native instructions for them. Implement
them in instruction sequence. For detail, please refer to the commit log.
The implementation is tested by test_bpf kernel module.
The patches are app
> if (sock->type == SOCK_DGRAM) {
> - err = dev_hard_header(skb, dev, ntohs(proto), addr,
> - NULL, tp_len);
> + /* In DGRAM sockets, we expect struct sockaddr_ll was filled
> +* via struct msghdr, so we have dest mac
On Wed, Nov 11, 2015 at 12:34 AM, Måns Rullgård wrote:
> Andy Shevchenko writes:
>
>>> +static inline void nb8800_maskb(struct nb8800_priv *priv, int reg,
>>> + u32 mask, u32 val)
>>> +{
>>> + u32 old = nb8800_readb(priv, reg);
>>> + u32 new = (old & ~mas
Andy Shevchenko writes:
>> +static inline void nb8800_maskb(struct nb8800_priv *priv, int reg,
>> + u32 mask, u32 val)
>> +{
>> + u32 old = nb8800_readb(priv, reg);
>> + u32 new = (old & ~mask) | val;
>
> Shoudn't be "… | (val & mask);" ?
No, it's meant
On Tue, Nov 10, 2015 at 6:14 PM, Mans Rullgard wrote:
> This adds a driver for the Aurora VLSI NB8800 Ethernet controller.
> It is an almost complete rewrite of a driver originally found in
> a Sigma Designs 2.6.22 tree.
Few nitpicks below.
>
> Signed-off-by: Mans Rullgard
> ---
> Changes:
> -
1) Fix null deref in xt_TEE netfilter module, from Eric Dumazet.
2) Several spots need to get to the original listner for SYN-ACK
packets, most spots got this ok but some were not. Whilst covering
the remaining cases, create a helper to do this. From Eric Dumazet.
3) Missiing check of re
In tpacket_fill_skb() commit c1aad275b029 ("packet: set transport
header before doing xmit") and later on 40893fd0fd4e ("net: switch
to use skb_probe_transport_header()") was probing for a transport
header on the skb from a ring buffer slot, but at a time, where
the skb has _not even_ been filled w
There seem to be a couple of issues in tpacket_snd() path. Since it's
introduction in commit 69e3c75f4d54 ("net: TX_RING and packet mmap"),
TX_RING could be used from SOCK_DGRAM and SOCK_RAW side. When used
with SOCK_DGRAM only, the size_max > dev->mtu + reserve check should
have reserve as 0, but
We concluded that the skb_probe_transport_header() should better be
called unconditionally. Avoiding the call into the flow dissector has
also not really much to do with the direct xmit mode.
While it seems that only virtio_net code makes use of GSO from non
RX/TX ring packet socket paths, we shou
Fixes a couple of issues in packet sockets, i.e. on TX ring side. See
individual patches for details.
v1 -> v2:
- Added patch 2 as suggested by Dave
- Rest is unchanged from previous submission
Daniel Borkmann (3):
packet: do skb_probe_transport_header when we actually have data
packet: alw
An AF_UNIX datagram socket being the client in an n:1 association with
some server socket is only allowed to send messages to the server if the
receive queue of this socket contains at most sk_max_ack_backlog
datagrams. This implies that prospective writers might be forced to go
to sleep despite no
On Tue, 2015-11-10 at 21:21 +, Måns Rullgård wrote:
> Even ixgbe uses napi_complete() while netdevice.h says one should
> "consider using napi_complete_done() instead." Did the author consider
> it and decide not to, or has the driver simply not been updated?
napi_complete_done() is quite ne
David Miller writes:
> From: Måns Rullgård
> Date: Tue, 10 Nov 2015 20:53:19 +
>
>> David Miller writes:
>>
>>> From: Måns Rullgård
>>> Date: Tue, 10 Nov 2015 18:05:15 +
>>>
Because I haven't been following the netdev list closely for the last
five years, and no documentatio
From: Måns Rullgård
Date: Tue, 10 Nov 2015 20:53:19 +
> David Miller writes:
>
>> From: Måns Rullgård
>> Date: Tue, 10 Nov 2015 18:05:15 +
>>
>>> Because I haven't been following the netdev list closely for the last
>>> five years, and no documentation I read mentioned this function.
> On Nov 9, 2015, at 5:26 AM, Patrick McHardy wrote:
>
> On 06.11, Jarno Rajahalme wrote:
>> There is no need to help connections that are not confirmed, so we can
>> delay helping new connections to the time when they are confirmed.
>> This change is needed for NAT support, and having this as a
David Miller writes:
> From: Måns Rullgård
> Date: Tue, 10 Nov 2015 18:05:15 +
>
>> Because I haven't been following the netdev list closely for the last
>> five years, and no documentation I read mentioned this function. I can
>> certainly change it.
>
> It is always advisable to mimick wh
On Tue, 10 Nov 2015 15:40:35 -0500 (EST)
David Miller wrote:
> I'll apply this, thanks Steven et al.
Thanks David.
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
From: Vladislav Yasevich
Date: Tue, 10 Nov 2015 06:15:32 -0500
> This reverts commit 34c2d9fb0498c066afbe610b15e18995fd8be792.
>
> There are 2 reasons for this revert:
> 1) The commit in question doesn't do what it says it does. The
> description reads: "Allow bridge forward delay to be
On Tuesday 10 November 2015 15:28:17 Steven Rostedt wrote:
> Arnd Bergmann reported:
>
> In my ARM randconfig tests, I'm getting a build error for
> newly added code in bpf_perf_event_read and bpf_perf_event_output
> whenever CONFIG_PERF_EVENTS is disabled:
>
> kernel/trace/bpf_trace.c: I
From: Steven Rostedt
Date: Tue, 10 Nov 2015 15:28:17 -0500
>
> Arnd Bergmann reported:
>
> In my ARM randconfig tests, I'm getting a build error for
> newly added code in bpf_perf_event_read and bpf_perf_event_output
> whenever CONFIG_PERF_EVENTS is disabled:
>
> kernel/trace/bpf_trace
From: Arnd Bergmann
Date: Tue, 10 Nov 2015 11:28:15 +0100
> The newly added qlogic qed driver uses the zlib library, but
> misses the dependency:
>
> drivers/built-in.o: In function `qed_alloc_stream_mem':
> drivers/net/ethernet/qlogic/qed/qed_main.c:707: undefined reference to
> `zlib_inflate_
On 10/26/2015 07:11 AM, Kedareswara rao Appana wrote:
> Instead of enabling/disabling clocks at several locations in the driver,
> Use the runtime_pm framework. This consolidates the actions for runtime PM
> In the appropriate callbacks and makes the driver more readable and
> mantainable.
>
> Si
Arnd Bergmann reported:
In my ARM randconfig tests, I'm getting a build error for
newly added code in bpf_perf_event_read and bpf_perf_event_output
whenever CONFIG_PERF_EVENTS is disabled:
kernel/trace/bpf_trace.c: In function 'bpf_perf_event_read':
kernel/trace/bpf_trace.c:203:11: err
From: Pablo Neira Ayuso
Date: Tue, 10 Nov 2015 17:36:28 +0100
> nf_tables may create percpu counters from the packet path through its
> dynamic set instantiation infrastructure, so we need a way to allocate
> this through GFP_ATOMIC.
>
> Signed-off-by: Pablo Neira Ayuso
Acked-by: David S. Mill
From: "Charles (Chas) Williams" <3ch...@gmail.com>
Date: Tue, 10 Nov 2015 13:26:05 -0500
> Dave, could you please add
>
> commit 48900cb6af4282fa0fb6ff4d72a81aa3dadb5c39
> virtio-net: drop NETIF_F_FRAGLIST
>
> to your stable queues for 3.14.y and 4.1.y?
Ok, queued up.
--
To unsubscribe from thi
From: Måns Rullgård
Date: Tue, 10 Nov 2015 18:05:15 +
> Because I haven't been following the netdev list closely for the last
> five years, and no documentation I read mentioned this function. I can
> certainly change it.
It is always advisable to mimick what other drivers do and use them a
On 11/9/2015 12:00 PM, Z Lim wrote:
On Mon, Nov 9, 2015 at 10:08 AM, Shi, Yang wrote:
I added it to stay align with ARMv8 AAPCS to maintain the correct FP during
function call. It makes us get correct stack backtrace.
I think we'd better to keep compliant with ARMv8 AAPCS in BPF JIT prologue
t
Mason writes:
> On 10/11/2015 17:14, Mans Rullgard wrote:
>
>> This adds a driver for the Aurora VLSI NB8800 Ethernet controller.
>> It is an almost complete rewrite of a driver originally found in
>> a Sigma Designs 2.6.22 tree.
>>
>> Signed-off-by: Mans Rullgard
>> ---
>> Changes:
>> - Refact
On 10/11/2015 17:14, Mans Rullgard wrote:
> This adds a driver for the Aurora VLSI NB8800 Ethernet controller.
> It is an almost complete rewrite of a driver originally found in
> a Sigma Designs 2.6.22 tree.
>
> Signed-off-by: Mans Rullgard
> ---
> Changes:
> - Refactored mdio access functions
On 10.11, Pablo Neira Ayuso wrote:
> On Tue, Nov 10, 2015 at 06:58:05PM +, Patrick McHardy wrote:
> > On 10.11, Pablo Neira Ayuso wrote:
> > > On Tue, Nov 10, 2015 at 06:30:34PM +, Patrick McHardy wrote:
> > > > > __module_get(src->ops->type->owner);
> > > > > - memcpy(dst, src, s
On Tue, Nov 10, 2015 at 06:58:05PM +, Patrick McHardy wrote:
> On 10.11, Pablo Neira Ayuso wrote:
> > On Tue, Nov 10, 2015 at 06:30:34PM +, Patrick McHardy wrote:
> > > > __module_get(src->ops->type->owner);
> > > > - memcpy(dst, src, src->ops->size);
> > > > + if (src->
On 10.11, Pablo Neira Ayuso wrote:
> On Tue, Nov 10, 2015 at 06:30:34PM +, Patrick McHardy wrote:
> > > __module_get(src->ops->type->owner);
> > > - memcpy(dst, src, src->ops->size);
> > > + if (src->ops->clone) {
> > > + memcpy(dst, src, sizeof(*src));
> >
> > Why copy if we clone?
On Tue, Nov 10, 2015 at 06:30:34PM +, Patrick McHardy wrote:
> On 10.11, Pablo Neira Ayuso wrote:
> > With the conversion of the counter expressions to make it percpu, we
> > need to clone the percpu memory area, otherwise we crash when using
> > counters from flow tables.
> >
> > Signed-off-b
On 10.11, Pablo Neira Ayuso wrote:
> With the conversion of the counter expressions to make it percpu, we
> need to clone the percpu memory area, otherwise we crash when using
> counters from flow tables.
>
> Signed-off-by: Pablo Neira Ayuso
> ---
> include/net/netfilter/nf_tables.h | 16 +++
Dave, could you please add
commit 48900cb6af4282fa0fb6ff4d72a81aa3dadb5c39
virtio-net: drop NETIF_F_FRAGLIST
to your stable queues for 3.14.y and 4.1.y?
This fixes CVE-2015-5156,
https://security-tracker.debian.org/tracker/CVE-2015-5156
--
To unsubscribe from this list: send the line "unsubs
Eric Dumazet writes:
> On Tue, 2015-11-10 at 16:14 +, Mans Rullgard wrote:
>> This adds a driver for the Aurora VLSI NB8800 Ethernet controller.
>> It is an almost complete rewrite of a driver originally found in
>> a Sigma Designs 2.6.22 tree.
>
> ...
>
>> +
>> +static int nb8800_xmit(struct
Eric Dumazet writes:
> On Tue, 2015-11-10 at 16:14 +, Mans Rullgard wrote:
>> This adds a driver for the Aurora VLSI NB8800 Ethernet controller.
>> It is an almost complete rewrite of a driver originally found in
>> a Sigma Designs 2.6.22 tree.
>
> ...
>
>> +
>> +static void nb8800_receive(st
On Tue, 2015-11-10 at 16:14 +, Mans Rullgard wrote:
> This adds a driver for the Aurora VLSI NB8800 Ethernet controller.
> It is an almost complete rewrite of a driver originally found in
> a Sigma Designs 2.6.22 tree.
...
> +
> +static int nb8800_xmit(struct sk_buff *skb, struct net_device *
On Tue, 2015-11-10 at 16:14 +, Mans Rullgard wrote:
> This adds a driver for the Aurora VLSI NB8800 Ethernet controller.
> It is an almost complete rewrite of a driver originally found in
> a Sigma Designs 2.6.22 tree.
...
> +
> +static void nb8800_receive(struct net_device *dev, int i, int l
Jason Baron writes:
> On 11/09/2015 09:40 AM, Rainer Weikusat wrote:
[...]
>> -if (unix_peer(other) != sk && unix_recvq_full(other)) {
>> +if (!unix_dgram_peer_recv_ready(sk, other)) {
>> if (!timeo) {
>> -err = -EAGAIN;
>> -goto out_u
On 11/10/2015 06:14 PM, Alexei Starovoitov wrote:
On Tue, Nov 10, 2015 at 09:25:01AM -0500, Steven Rostedt wrote:
On Tue, 10 Nov 2015 14:31:38 +0100
Daniel Borkmann wrote:
On 11/10/2015 01:55 PM, Arnd Bergmann wrote:
In my ARM randconfig tests, I'm getting a build error for
newly added code
David Miller writes:
> From: Rainer Weikusat
> Date: Mon, 09 Nov 2015 14:40:48 +
>
>> +__remove_wait_queue(&unix_sk(u->peer_wake.private)->peer_wait,
>> +&u->peer_wake);
>
> This is more simply:
>
> __remove_wait_queue(&unix_sk(u->peer_wake.private)->peer_wai
On Tue, Nov 10, 2015 at 09:25:01AM -0500, Steven Rostedt wrote:
> On Tue, 10 Nov 2015 14:31:38 +0100
> Daniel Borkmann wrote:
>
> > On 11/10/2015 01:55 PM, Arnd Bergmann wrote:
> > > In my ARM randconfig tests, I'm getting a build error for
> > > newly added code in bpf_perf_event_read and bpf_pe
From: Thierry Reding
The beacon_loss_count field was removed from the structure in commit
976bd9efdae6 ("mac80211: move beacon_loss_count into ifmgd"). This
updates the kerneldoc comment to match the structure definition.
Signed-off-by: Thierry Reding
---
Applies on top of next-20151
From: Pavel Fedin
Date: Tue, 10 Nov 2015 09:36:24 +0300
> Hello! So, what should we do with this?
If you think I should reconsider the patch, you should resubmit it.
The ball is always in your court.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message t
On Tue, Nov 10, 2015 at 05:36:29PM +0100, Pablo Neira Ayuso wrote:
> From: Anthony Lineham
>
> The uninitialized tuple structure caused incorrect hash calculation
> and the lookup failed.
Please, ignore this.
This patch is already in the nf tree, it just slipped through in my
last git send-emai
With the conversion of the counter expressions to make it percpu, we
need to clone the percpu memory area, otherwise we crash when using
counters from flow tables.
Signed-off-by: Pablo Neira Ayuso
---
include/net/netfilter/nf_tables.h | 16 +++--
net/netfilter/nft_counter.c | 49 ++
nf_tables may create percpu counters from the packet path through its
dynamic set instantiation infrastructure, so we need a way to allocate
this through GFP_ATOMIC.
Signed-off-by: Pablo Neira Ayuso
---
include/linux/netdevice.h | 27 +++
1 file changed, 15 insertions(+),
From: Anthony Lineham
The uninitialized tuple structure caused incorrect hash calculation
and the lookup failed.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=106441
Signed-off-by: Anthony Lineham
---
Original patch posted on kernel bugzilla.
net/ipv4/netfilter/nf_nat_pptp.c | 2 +-
1 fil
On Wednesday, November 04, 2015 at 04:45:20 PM, Aleksander Morgado wrote:
> On Wed, Nov 4, 2015 at 4:33 PM, Marek Vasut wrote:
> > On Wednesday, November 04, 2015 at 04:19:45 PM, Aleksander Morgado wrote:
> >> On Wed, Nov 4, 2015 at 4:18 PM, Vostrikov Andrey
> >>
> >> wrote:
> >> >>> > About the
This adds a driver for the Aurora VLSI NB8800 Ethernet controller.
It is an almost complete rewrite of a driver originally found in
a Sigma Designs 2.6.22 tree.
Signed-off-by: Mans Rullgard
---
Changes:
- Refactored mdio access functions
- Refactored register access helpers
- Improved error handl
On Tue, Nov 10, 2015 at 04:51:09PM +0100, Neil Armstrong wrote:
> This patchset introduces some fixes and a registers addressing cleanup for
> the mv88e6060 DSA driver.
Hi Neil
It is normal for netdev to put into the email subject of patches which
tree these patches are for. "net" would be the la
On Nov. Tuesday 10 (46) 04:51 PM, Neil Armstrong wrote:
> According to the mv88e6060 datasheet, the InitReady bit position
> is 11 and the polarity is inverted.
> Use the bit correctly to detect the end of initialization.
>
> Acked-by: Andrew Lunn
> Signed-off-by: Neil Armstrong
Acked-by: Vivie
On Nov. Tuesday 10 (46) 04:51 PM, Neil Armstrong wrote:
> To align with the mv88e6xxx code, add a similar header file
> with all the register defines.
> The file is based on the mv88e6xxx header for coherency.
>
> Acked-by: Andrew Lunn
> Signed-off-by: Neil Armstrong
Acked-by: Vivien Didelot
-
This patchset introduces some fixes and a registers addressing cleanup for
the mv88e6060 DSA driver.
The first patch removes the poll_link as mv88e6xxx.
The 3 following patches fixes the setup in regards of the datasheet.
The 2 last patches introduces a clean header and replaces all magic values.
According to the mv88e6060 datasheet, the InitReady bit position
is 11 and the polarity is inverted.
Use the bit correctly to detect the end of initialization.
Acked-by: Andrew Lunn
Signed-off-by: Neil Armstrong
---
drivers/net/dsa/mv88e6060.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
As of mv88e6xxx remove the poll_link callback since the link
state change polling is now handled by the phylib.
Tested on a mv88e6060 B0 device with a TI DM816X SoC.
Suggested-by: Andrew Lunn
Acked-by: Andrew Lunn
Signed-off-by: Neil Armstrong
---
drivers/net/dsa/mv88e6060.c | 49
According to the mv88e6060 datasheet, the MaxFrameSize bit position
is 10 instead of 11 which is reserved.
Use the bit correctly to setup max frame size to 1536.
Acked-by: Andrew Lunn
Signed-off-by: Neil Armstrong
---
drivers/net/dsa/mv88e6060.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
To align with the mv88e6xxx code, use the register defines to
access all the register addresses and bit fields.
Acked-by: Andrew Lunn
Signed-off-by: Neil Armstrong
---
drivers/net/dsa/mv88e6060.c | 64 ++---
1 file changed, 37 insertions(+), 27 deletions(
To align with the mv88e6xxx code, add a similar header file
with all the register defines.
The file is based on the mv88e6xxx header for coherency.
Acked-by: Andrew Lunn
Signed-off-by: Neil Armstrong
---
drivers/net/dsa/mv88e6060.h | 111
1 file chan
According to the mv88e6060 datasheet, the first mac byte must
be at position 9 instead of 8 since the bit 8 is used to select
if the mac address must differ for each port for Pause frames.
Use the correct shift and set the same mac address for all port.
Acked-by: Andrew Lunn
Signed-off-by: Neil A
On Tue, 2015-11-10 at 15:47 +0100, Hannes Frederic Sowa wrote:
> During splicing an af-unix socket to a pipe we have to drop all
> af-unix socket locks. While doing so we allow another reader to enter
> unix_stream_read_generic which can read, copy and finally free another
> skb. If exactly this sk
On Tue, Nov 10, 2015, at 16:18, Eric Dumazet wrote:
> Please Hannes include the Fixes: tag.
Yep, sorry, is done in v3.
> As you might already know, patchwork does not catch it later
>
> Fixes: 2b514574f7e8 ("net: af_unix: implement splice for stream af_unix
> sockets")
> Acked-by: Eric Dumazet
During splicing an af-unix socket to a pipe we have to drop all
af-unix socket locks. While doing so we allow another reader to enter
unix_stream_read_generic which can read, copy and finally free another
skb. If exactly this skb is just in process of being spliced we get a
use-after-free report by
> Is something like this OK ?
> /*
> * drivers/net/dsa/mv88e6060.h - Marvell 88e6060 switch chip support
> * Copyright (c) 2015 Neil Armstrong
> *
> * Based on mv88e6xxx.h
> * Copyright (c) 2008 Marvell Semiconductor
> *
> * This program is free software; you can redistribute it and/or modif
On Nov. Tuesday 10 (46) 03:42 PM, Neil Armstrong wrote:
> On 11/10/2015 03:25 PM, Vivien Didelot wrote:
> > Hi Neil,
> >
> > On Nov. Tuesday 10 (46) 02:25 PM, Neil Armstrong wrote:
> >> To align with the mv88e6xxx code, add a similar header file
> >> with all the register defines.
> >> The file is
During splicing an af-unix socket to a pipe we have to drop all
af-unix socket locks. While doing so we allow another reader to enter
unix_stream_read_generic which can read, copy and finally free another
skb. If exactly this skb is just in process of being spliced we get a
use-after-free report by
On 11/10/2015 03:25 PM, Vivien Didelot wrote:
> Hi Neil,
>
> On Nov. Tuesday 10 (46) 02:25 PM, Neil Armstrong wrote:
>> To align with the mv88e6xxx code, add a similar header file
>> with all the register defines.
>> The file is based on the mv88e6xxx header for coherency.
>>
>> Signed-off-by: Nei
On Nov. Tuesday 10 (46) 03:30 PM, Andrew Lunn wrote:
> On Tue, Nov 10, 2015 at 09:25:51AM -0500, Vivien Didelot wrote:
> > Hi Neil,
> >
> > On Nov. Tuesday 10 (46) 02:25 PM, Neil Armstrong wrote:
> > > To align with the mv88e6xxx code, add a similar header file
> > > with all the register defines.
On Tue, Nov 10, 2015, at 15:26, Hannes Frederic Sowa wrote:
> net/unix/af_unix.c | 18 +-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
> index aaa0b58..b2c4131 100644
> --- a/net/unix/af_unix.c
> +++ b/net/unix/af_unix.
On Tue, Nov 10, 2015 at 09:25:51AM -0500, Vivien Didelot wrote:
> Hi Neil,
>
> On Nov. Tuesday 10 (46) 02:25 PM, Neil Armstrong wrote:
> > To align with the mv88e6xxx code, add a similar header file
> > with all the register defines.
> > The file is based on the mv88e6xxx header for coherency.
> >
During splicing an af-unix socket to a pipe we have to drop all
af-unix socket locks. While doing so we allow another reader to enter
unix_stream_read_generic which can read, copy and finally free another
skb. If exactly this skb is just in process of being spliced we get a
use-after-free report by
1 - 100 of 125 matches
Mail list logo
