The recently added mlxsw driver produces warnings in ARM
allmodconfig:
drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cmd_exec':
drivers/net/ethernet/mellanox/mlxsw/pci.c:1585:59: warning: right shift count
>= width of type [-Wshift-count-overflow]
linux/byteorder/big_endian.h:
Wed, Oct 07, 2015 at 08:53:02AM CEST, j...@perches.com wrote:
>On Tue, 2015-10-06 at 23:47 +0200, Arnd Bergmann wrote:
>> The recently added mlxsw driver produces warnings in ARM
>> allmodconfig:
>>
>> drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cmd_exec':
>> drivers/net/ethe
On Tue, 2015-10-06 at 23:47 +0200, Arnd Bergmann wrote:
> The recently added mlxsw driver produces warnings in ARM
> allmodconfig:
>
> drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cmd_exec':
> drivers/net/ethernet/mellanox/mlxsw/pci.c:1585:59: warning: right shift count
> >=
Tue, Oct 06, 2015 at 11:47:44PM CEST, a...@arndb.de wrote:
>The recently added mlxsw driver produces warnings in ARM
>allmodconfig:
>
>drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cmd_exec':
>drivers/net/ethernet/mellanox/mlxsw/pci.c:1585:59: warning: right shift count
>>= wid
Wed, Oct 07, 2015 at 03:50:08AM CEST, sfel...@gmail.com wrote:
>
>> Also I wonder how this works when a pkt ingresses a port in mode A and
>> egresses a port in mode B? What fib/fdb tables does it cross when this
>> happens? It seems easier to just have two switch devices not a
>> hybrid. If thi
* Andy Lutomirski wrote:
> On Tue, Oct 6, 2015 at 10:56 AM, Eric Dumazet wrote:
> > On Tue, 2015-10-06 at 10:50 -0700, Alexei Starovoitov wrote:
> >
> >> was also thinking that we can do it only in paths that actually
> >> have multiple protocol layers, since today bpf is mainly used with
> >>
Tue, Oct 06, 2015 at 07:14:39PM CEST, sfel...@gmail.com wrote:
>On Tue, Oct 6, 2015 at 12:30 AM, Jiri Pirko wrote:
>> Tue, Oct 06, 2015 at 05:56:12AM CEST, sfel...@gmail.com wrote:
>>>On Mon, Oct 5, 2015 at 10:43 AM, Jiri Pirko wrote:
From: Jiri Pirko
This patchset allows new rock
From: David Ahern
Eric's net namespace changes in 1b75097dd7a26 leaves net unreferenced if
CONFIG_IP_VS_IPV6 is not enabled:
../net/netfilter/ipvs/ip_vs_core.c: In function ‘ip_vs_out’:
../net/netfilter/ipvs/ip_vs_core.c:1177:14: warning: unused variable ‘net’
[-Wunused-variable]
After the net
Hi Pablo,
please consider these build warning cleanups from David Ahern and myself.
They resolve some minor side effects of Eric Biederman' heroic work to
cleanup IPVS which you recently pulled: its queued up for v4.4 so no need
to worry about earlier kernel versions.
The following changes since
If CONFIG_PROC_FS is undefined then the arguments of proc_create()
and remove_proc_entry() are unused. As a result the net variables of
ip_vs_conn_net_{init,cleanup} are unused.
net/netfilter/ipvs//ip_vs_conn.c: In function ‘ip_vs_conn_net_init’:
net/netfilter/ipvs//ip_vs_conn.c:1350:14: warning:
On Fri, Oct 2, 2015 at 6:10 AM, Neil Horman wrote:
> On Thu, Oct 01, 2015 at 08:25:46PM -0700, Vinson Lee wrote:
>> Hi.
>>
>> I am seeing a netpoll_send_skb_on_dev warning with bnx2. It happens on
>> Linux 4.1 and I am able to reproduce the warning with Linux 4.3-rc3.
>>
>> [ cut here
t4_check_fw_version() can return several error codes (-EINVAL, -EBUSY,
-EAGAIN). The present code sets the adapter state to UNINIT only if its
an EFAULT. In all the error cases set the adapter to uninitialized state.
In t4_check_fw_version() if call to t4_read_flash() fails, repeat the
operation a
On Tue, 2015-10-06 at 22:26 -0500, Eric W. Biederman wrote:
> So what I am really reading it for is ip_local_out which I change to
> take a struct net a few patches later in the series. The patches that
> changes everything is noticably cleaner and easier to review with these
> couple of patches
Similar to commit c29390c6dfee ("xps: must clear sender_cpu before forwarding")
the skb->sender_cpu needs to be cleared before xmit.
Fixes: 3896d655f4d4 ("bpf: introduce bpf_clone_redirect() helper")
Signed-off-by: Alexei Starovoitov
---
That is similar to pending patches for xps:
http://patchwor
roopa writes:
> On 10/6/15, 12:44 PM, Eric W. Biederman wrote:
>> Roopa Prabhu writes:
>>
>>> From: Roopa Prabhu
>>>
>>> This patch adds support for MPLS multipath routes.
>>>
>>> Includes following changes to support multipath:
>>> - splits struct mpls_route into 'struct mpls_route + struct mp
Eric Dumazet writes:
> On Tue, 2015-10-06 at 13:53 -0500, Eric W. Biederman wrote:
>> Compute net and store it in a variable in the functions
>> ip_build_and_send_pkt and ip_queue_xmit so that it does not need to be
>> recomputed next time it is needed.
>>
>> Signed-off-by: "Eric W. Biederman"
On 10/6/15 7:02 PM, Simon Horman wrote:
lvs-devel would be better yet.
I submitted an identical patch there yesterday.
I'll pick up David's version and send it to Pablo ASAP.
Thanks, Simon. I need to remember to consult the MAINTAINERS file.
--
To unsubscribe from this list: send the line "uns
eBPF socket filter programs may see junk in 'u32 cb[5]' area,
since it could have been used by protocol layers earlier.
On the receive path the af_packet sees clean skb->cb.
On the xmit the dev_queue_xmit_nit() delivers cloned skb, so we can
conditionally clean 20 bytes of skb->cb that could be us
On Tue, Oct 6, 2015 at 2:25 PM, John Fastabend wrote:
> [...]
>
Using void * in these ops is unacceptable, I can't agree to this patch.
There is a much cleaner way to architect this. If you look at the ops
defined, they're mostly duplicates of the already defined
swi
On Tue, 2015-10-06 at 17:23 -0700, Cong Wang wrote:
> Similar to commit c29390c6dfee ("xps: must clear sender_cpu before
> forwarding")
> the skb->sender_cpu needs to be cleared when moving from Rx
> Tx, otherwise kernel could crash.
>
> Cc: Eric Dumazet
> Cc: Jamal Hadi Salim
> Signed-off-by:
On Tue, Oct 6, 2015 at 6:19 PM, Mahesh Bandewar wrote:
> On Tue, Oct 6, 2015 at 11:53 AM, Eric W. Biederman
> wrote:
>> Compute net once in ipvlan_process_v4_outbound and ipvlan_process_v6_outbound
>> and store it in a variable so that net does not need to be recomputed next
>> time
>> it is use
On Tue, Oct 6, 2015 at 11:53 AM, Eric W. Biederman
wrote:
> Compute net once in ipvlan_process_v4_outbound and ipvlan_process_v6_outbound
> and store it in a variable so that net does not need to be recomputed next
> time
> it is used.
>
It's used exactly once at this moment so don't know what "n
On Tue, Oct 06, 2015 at 04:27:35PM -0700, Cong Wang wrote:
> On Tue, Oct 6, 2015 at 11:24 AM, Julian Anastasov wrote:
> >
> > Hello,
> >
> > On Tue, 6 Oct 2015, Simon Horman wrote:
> >
> >> Since 6f2bcea9917d ("ipvs: Pass ipvs into ip_vs_in_icmp and
> >> ip_vs_in_icmp_v6") the net variable
On Mon, Oct 05, 2015 at 11:35:37PM -0700, David Miller wrote:
> From: Cong Wang
> Date: Mon, 5 Oct 2015 10:53:57 -0700
>
> > On Thu, Oct 1, 2015 at 8:49 AM, David Ahern
> > wrote:
> >> Eric's net namespace changes in 1b75097dd7a26 leaves net unreferenced if
> >> CONFIG_IP_VS_IPV6 is not enabled
On Mon, Oct 5, 2015 at 1:25 PM, Alexander Duyck
wrote:
> On 10/05/2015 06:59 AM, Vlastimil Babka wrote:
>>
>> On 10/02/2015 12:18 PM, Konstantin Khlebnikov wrote:
>>>
>>> When openvswitch tries allocate memory from offline numa node 0:
>>> stats = kmem_cache_alloc_node(flow_stats_cache, GFP_KERNEL
On 06/10/15 14:54, Vivien Didelot wrote:
> In order to push switchdev objects down to DSA drivers, I need to include
> switchdev.h in dsa.h. But compilation fails because of a circular dependency
> issue, since dsa.h is also included in linux/netdevice.h.
Just for the record, what does this circul
Similar to commit c29390c6dfee ("xps: must clear sender_cpu before forwarding")
the skb->sender_cpu needs to be cleared when moving from Rx
Tx, otherwise kernel could crash.
Cc: Eric Dumazet
Cc: Jamal Hadi Salim
Signed-off-by: Cong Wang
Signed-off-by: Cong Wang
---
net/sched/act_mirred.c | 1
On Tue, Oct 6, 2015 at 11:24 AM, Julian Anastasov wrote:
>
> Hello,
>
> On Tue, 6 Oct 2015, Simon Horman wrote:
>
>> Since 6f2bcea9917d ("ipvs: Pass ipvs into ip_vs_in_icmp and
>> ip_vs_in_icmp_v6") the net variable in ip_vs_out() appears to be unused
>> unless CONFIG_IP_VS_IPV6 is set. To
On Tue, Oct 06, 2015 at 05:19:10PM +0300, Sergei Shtylyov wrote:
>Hello.
>
>On 10/6/2015 6:09 AM, Gavin Shan wrote:
>
>>This enables IP/UDP/TCP offload checksum according to information
>>passed on from bootloader through device-tree. The offload doesn't
>>working properly when the interface works
On Tue, Oct 06, 2015 at 02:09:42PM +1100, Gavin Shan wrote:
>This patchset is prototype requesting for comments.
>
>This series of patches intends to support NCSI stack, which is specified by
>DSP0222. One NCSI enabled interface potentially connects to multiple packages
>and channels, but there is
On 10/06/2015 02:52 PM, Jarod Wilson wrote:
Some pci changes upcoming in 4.3 seem to cause additional disconnects,
which can happen at unfortuitous times for igb, leading to issues such as
this:
[ 414.440115] igb :15:00.0: enabling device ( -> 0002)
[ 414.474934] pps pps0: new PPS sour
Hello.
Note the typo in the subject: s/nhs/hns/.
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
dsa_priv.h uses dsa specific structures, as well as the files using it,
so include dsa.h here.
Signed-off-by: Vivien Didelot
---
net/dsa/dsa_priv.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/dsa/dsa_priv.h b/net/dsa/dsa_priv.h
index 311796c8..4522f47 100644
--- a/net/dsa/dsa_priv.h
Forward declare struct dsa_switch_tree in netdevice.h instead of
including the dsa.h header.
Signed-off-by: Vivien Didelot
---
include/linux/netdevice.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 1986a22..4618
Instead of checking that the dsa_switch_tree rcv pointer is not NULL,
add a uses_hw_tag boolean to net_device to explicit whether it uses
hardware inserted tag or not.
Signed-off-by: Vivien Didelot
---
include/linux/netdevice.h | 6 --
include/net/dsa.h | 5 -
net/dsa/dsa.c
In order to push switchdev objects down to DSA drivers, I need to include
switchdev.h in dsa.h. But compilation fails because of a circular dependency
issue, since dsa.h is also included in linux/netdevice.h.
dsa.h is included for two purposes: to have the definition of struct
dsa_switch_tree; and
Hi Jarod,
[auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore]
config: i386-randconfig-x009-201540 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All error/warnings (new ones prefixed by >>):
driver
The recently added hns driver causes a build warning in ARM
allmodconfig builds:
drivers/net/ethernet/hisilicon/hns/hnae.c: In function 'handles_show':
drivers/net/ethernet/hisilicon/hns/hnae.c:452:13: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
j, (u
Some pci changes upcoming in 4.3 seem to cause additional disconnects,
which can happen at unfortuitous times for igb, leading to issues such as
this:
[ 414.440115] igb :15:00.0: enabling device ( -> 0002)
[ 414.474934] pps pps0: new PPS source ptp1
[ 414.474937] igb :15:00.0: added
Alexander Duyck wrote:
On 09/21/2015 09:14 PM, Jarod Wilson wrote:
Alexander Duyck wrote:
On 09/21/2015 10:11 AM, Jarod Wilson wrote:
Some pci changes upcoming in 4.3 seem to cause additional disconnects,
which can happen at unfortuitous times for igb, leading to issues
such as
this, where the
From: Eric Dumazet
Some applications use a listen() backlog of 1.
Prior kernels were silently enforcing a qlen_log of 4, so that we were
sending up to /proc/sys/net/ipv4/tcp_synack_retries SYNACK messages.
Fixes: ef547f2ac16b ("tcp: remove max_qlen_log")
Signed-off-by: Eric Dumazet
---
net/ip
The recently added mlxsw driver produces warnings in ARM
allmodconfig:
drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cmd_exec':
drivers/net/ethernet/mellanox/mlxsw/pci.c:1585:59: warning: right shift count
>= width of type [-Wshift-count-overflow]
linux/byteorder/big_endian.h:
On 10/6/2015 4:39 PM, Or Gerlitz wrote:
On Wed, Oct 7, 2015 at 12:27 AM, wrote:
From: Carol L Soto
If we get MAX_MSIX interrupts would like to have each receive ring
with his own msix interrupt line.
so 9293267a3e2a was only partially correct? and/or not fully optimal?
please elaborate m
On Tue, 2015-10-06 at 13:53 -0500, Eric W. Biederman wrote:
> Compute net and store it in a variable in the functions
> ip_build_and_send_pkt and ip_queue_xmit so that it does not need to be
> recomputed next time it is needed.
>
> Signed-off-by: "Eric W. Biederman"
> ---
> net/ipv4/ip_output.c
On Wed, Oct 7, 2015 at 12:27 AM, wrote:
> From: Carol L Soto
>
> If we get MAX_MSIX interrupts would like to have each receive ring
> with his own msix interrupt line.
so 9293267a3e2a was only partially correct? and/or not fully optimal?
please elaborate more on that in your change log.
>
> F
From: Carol L Soto
If we get MAX_MSIX interrupts would like to have each receive ring
with his own msix interrupt line.
Fixes: 9293267a3e2a ('net/mlx4_core: Capping number of requested MSIXs to
MAX_MSIX')
Signed-off-by: Carol L Soto
---
drivers/net/ethernet/mellanox/mlx4/main.c | 4 +---
1 f
From: Carol L Soto
Test interrupts fails if not all completion vectors called
request_irq. This case can happen if only mlx4_en loads and
we have more completion vectors than rx rings.
Fixes: c66fa19c405a ('net/mlx4: Add EQ pool')
Acked-by: Matan Barak
Signed-off-by: Carol L Soto
---
driver
[...]
>>>
>>> Using void * in these ops is unacceptable, I can't agree to this patch.
>>>
>>> There is a much cleaner way to architect this. If you look at the ops
>>> defined, they're mostly duplicates of the already defined
>>> switchdev_ops. It would be much cleaner to:
>>>
>>> 0) set port mo
From: Satish Ashok
This patch documents bridge and ip -timestamp option
Signed-off-by: Satish Ashok
---
man/man8/bridge.8 | 3 +++
man/man8/ip.8 | 4
2 files changed, 7 insertions(+)
diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
index 5347a56..9f1051c 100644
--- a/man/man8/bridg
On Tue, Oct 6, 2015 at 12:32 PM, Jiri Benc wrote:
> On Tue, 6 Oct 2015 12:21:24 -0700, Pravin Shelar wrote:
>> It should report the flag when device parameters are requested by
>> userspace if there is support for lwtunnel. So check for the flag
>> should be good enough test for lwtunnel support.
On Tue, 2015-10-06 at 11:46 +0200, Guillaume Nault wrote:
> On Tue, Oct 06, 2015 at 04:46:04AM +, Matt Bennett wrote:
> > > > The second one seems to be trickier. It looks like a race wrt. PADT
> > > > message reception. Reproducing the bug will probably require to
> > > > generate some PADT fl
On 10/06/2015 09:39 PM, Arnd Bergmann wrote:
> On Tuesday 06 October 2015 21:28:29 Nikolay Aleksandrov wrote:
>> I posted a fix for this a couple of days ago, but I like your approach
>> better.
>> Since mine is not yet applied (I sent it to netfilter-devel only, wasn't
>> sure which
>> jurisdict
Commit 124613012db1 ("af_unix: Convert the unix_sk macro to an inline
function for type safety") was recently added to catch incorrect
uses of the unix_sk helper using compiler warnings.
It has now caught one such case in lsm_audit.c. The code is technically
correct, but as it converts a const poi
Jiri Pirko wrote:
>>> + int (*port_init)(struct rocker_port *rocker_port, void *priv,
>>> +void *port_priv);
>>
>> Yuck, void *. Can we do better?
>
> I see nothing wrong with this priv usage. It's done like this on many
> places. I think it is completely legit, s
Add support for the ethtool statistic interface, returning the full set
of statistics which both Armada 370 and Armada XP can support.
Signed-off-by: Russell King
---
Andrew,
Here's the patch updated to use the example set by mv643xx_eth.c.
drivers/net/ethernet/marvell/mvneta.c | 99 ++
From: Jon Ringle
This ethernet driver supports the Micorchip enc424j600/626j600 Ethernet
controller over a SPI bus interface. This driver makes use of the regmap API to
optimize access to registers by caching registers where possible.
Datasheet:
http://ww1.microchip.com/downloads/en/DeviceDoc/39
On 10/6/15, 1:11 PM, Eric W. Biederman wrote:
> ebied...@xmission.com (Eric W. Biederman) writes:
>
>> Roopa Prabhu writes:
>>
>>> From: Roopa Prabhu
>>>
>>> This patch adds support for MPLS multipath routes.
>>>
>>> Includes following changes to support multipath:
>>> - splits struct mpls_route
ebied...@xmission.com (Eric W. Biederman) writes:
> Roopa Prabhu writes:
>
>> From: Roopa Prabhu
>>
>> This patch adds support for MPLS multipath routes.
>>
>> Includes following changes to support multipath:
>> - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'
>>
>> - 'struct
On 10/6/15, 12:44 PM, Eric W. Biederman wrote:
> Roopa Prabhu writes:
>
>> From: Roopa Prabhu
>>
>> This patch adds support for MPLS multipath routes.
>>
>> Includes following changes to support multipath:
>> - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'
>>
>> - 'struct mpl
Hi Tilman,
On wo, 2015-09-30 at 01:45 +0200, Tilman Schmidt wrote:
> --- a/Documentation/serial/tty.txt
> +++ b/Documentation/serial/tty.txt
> + Should [...] set receive_room
> + in the tty_struct to the maximum amount of data
> + the li
Jarod Wilson wrote:
From: Uwe Koziolek
With some very finicky switch hardware, active backup bonding can get into
a situation where we play ping-pong between interfaces, trying to get one
to come up as the active slave. There seems to be an issue with the
switch's arp replies either taking too l
From: Uwe Koziolek
With some very finicky switch hardware, active backup bonding can get into
a situation where we play ping-pong between interfaces, trying to get one
to come up as the active slave. There seems to be an issue with the
switch's arp replies either taking too long, or simply gettin
Roopa Prabhu writes:
> From: Roopa Prabhu
>
> This patch adds support for MPLS multipath routes.
>
> Includes following changes to support multipath:
> - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'
>
> - 'struct mpls_nh' represents a mpls nexthop label forwarding entry
>
>
On Tuesday 06 October 2015 21:28:29 Nikolay Aleksandrov wrote:
> I posted a fix for this a couple of days ago, but I like your approach better.
> Since mine is not yet applied (I sent it to netfilter-devel only, wasn't sure
> which
> jurisdiction this falls into exactly) we can drop it.
> Just for
From: "Devon H. O'Dell"
The netfilter tee code does not clear skb->sender_cpu after copying the
skb. When both CONFIG_XPS and CONFIG_NET_RX_BUSY_POLL are active, it is
possible for a tee rule to duplicate a skb from input, leaving its
its napi queue id set. Because this field is shared in a union
On Tue, 6 Oct 2015 12:21:24 -0700, Pravin Shelar wrote:
> It should report the flag when device parameters are requested by
> userspace if there is support for lwtunnel. So check for the flag
> should be good enough test for lwtunnel support. Why is that not
> reliable check?
Which device? You'll
Hi
This patchset adds support for the iProc MDIO interface and the
Broadcom Cygnus SoC's internal Ethernet PHY.
The internal Ethernet PHY(s) in the Cygnus SoC's are accessed
via the MDIO interface found in most of the iProc based chips.
The patch also consolidates the common API's used by the
Bro
Add device tree binding documentation for the Broadcom iProc MDIO
bus driver.
Signed-off-by: Arun Parameswaran
---
.../devicetree/bindings/net/brcm,iproc-mdio.txt| 23 ++
1 file changed, 23 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/brcm,iproc
This patch adds support for the Broadcom iProc MDIO bus interface.
The MDIO interface can be found in the Broadcom iProc family Soc's.
The MDIO bus is accessed using a combination of command and data
registers. This MDIO driver provides access to the Etherent GPHY's
connected to the MDIO bus.
Sig
On 10/06/2015 09:22 PM, Arnd Bergmann wrote:
> With the ARM mini2440_defconfig, the bridge netfilter code gets
> built with both CONFIG_NF_DEFRAG_IPV4 and CONFIG_NF_DEFRAG_IPV6
> disabled, which leads to a harmless gcc warning:
>
> net/bridge/br_netfilter_hooks.c: In function 'br_nf_dev_queue_xmit
This patch adds the Broadcom phy library to consolidate common
interfaces shared by Broadcom phy's.
Moved the common interfaces to the 'bcm-phy-lib.c' and updated
the Broadcom PHY drivers to use the new APIs.
Signed-off-by: Arun Parameswaran
---
drivers/net/phy/Kconfig | 6 ++
drivers/n
On 10/6/15 10:56 AM, Eric Dumazet wrote:
On Tue, 2015-10-06 at 10:50 -0700, Alexei Starovoitov wrote:
was also thinking that we can do it only in paths that actually
have multiple protocol layers, since today bpf is mainly used with
tcpdump(raw_socket) and new af_packet fanout both have cb clea
Modified the bcm7xxx phy driver to remove local core register
defines and use the common ones from "include/linux/brcmphy.h"
Signed-off-by: Arun Parameswaran
---
drivers/net/phy/bcm7xxx.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/phy/bcm7xxx.c b/dri
Add support for the Broadcom Cygnus SoCs internal PHY's.
The PHYs are 1000M/100M/10M capable with support for 'EEE'
and 'APD' (Auto Power Down).
This driver supports the following Broadcom Cygnus SoCs:
- BCM583XX (BCM58300, BCM58302, BCM58303, BCM58305)
- BCM113XX (BCM11300, BCM11320, BCM11350,
With the ARM mini2440_defconfig, the bridge netfilter code gets
built with both CONFIG_NF_DEFRAG_IPV4 and CONFIG_NF_DEFRAG_IPV6
disabled, which leads to a harmless gcc warning:
net/bridge/br_netfilter_hooks.c: In function 'br_nf_dev_queue_xmit':
net/bridge/br_netfilter_hooks.c:792:2: warning: labe
On Tue, Oct 6, 2015 at 12:03 PM, Jiri Benc wrote:
> On Tue, 6 Oct 2015 11:55:35 -0700, Pravin Shelar wrote:
>> We should be able to use lwtunnel devices on 4.3. How about using
>> tunnel device parameters to detect lwtunnel support. For example in
>> case of vxlan tunnel IFLA_VXLAN_COLLECT_METADAT
On Tue, Oct 6, 2015 at 11:55 AM, Jiri Benc wrote:
> On Tue, 6 Oct 2015 11:26:31 -0700, Pravin Shelar wrote:
>> I do not see need to drop and reallocate dst in this operation. I just
>> need to set source IP address and source and dst port in the metadata
>> dst already set in skb.
>
> If I'm looki
The network namespace is already passed into dst_output pass it into
dst->output lwt->output and friends.
Signed-off-by: "Eric W. Biederman"
---
drivers/net/vrf.c| 3 +--
include/net/dst.h| 8
include/net/ip.h | 4 ++--
include/net/ipv6.h | 2 +-
includ
Compute net and store it in a variable in pptp_xmit, so that the value
can be reused the next time it is needed.
Signed-off-by: "Eric W. Biederman"
---
drivers/net/ppp/pptp.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ppp/pptp.c b/drivers/net/ppp/pptp.c
Compute net once in ipvlan_process_v4_outbound and ipvlan_process_v6_outbound
and store it in a variable so that net does not need to be recomputed next time
it is used.
Signed-off-by: "Eric W. Biederman"
---
drivers/net/ipvlan/ipvlan_core.c | 6 --
1 file changed, 4 insertions(+), 2 deletio
Signed-off-by: "Eric W. Biederman"
---
drivers/net/vrf.c | 2 +-
include/net/dst_ops.h | 3 ++-
include/net/ip.h | 2 +-
include/net/ipv6.h | 2 +-
net/ipv4/ip_output.c | 5 ++---
net/ipv6/output_core.c | 5 ++---
net/xfrm/xfrm_output.c | 2 +-
7 files changed, 10 insertions(+),
Signed-off-by: "Eric W. Biederman"
---
drivers/net/ipvlan/ipvlan_core.c| 4 ++--
drivers/net/ppp/pptp.c | 2 +-
drivers/net/vrf.c | 4 ++--
include/net/ip.h| 2 +-
include/net/ip6_tunnel.h| 2 +-
include/net/ipv6.h
On Tue, 6 Oct 2015 11:55:35 -0700, Pravin Shelar wrote:
> We should be able to use lwtunnel devices on 4.3. How about using
> tunnel device parameters to detect lwtunnel support. For example in
> case of vxlan tunnel IFLA_VXLAN_COLLECT_METADATA flags can confirm
> lwtunnel support.
You would have
Make unix_sk() just like inet[6]_sk() by constify'ing the sock
parameter.
Signed-off-by: Paul Moore
---
include/net/af_unix.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/af_unix.h b/include/net/af_unix.h
index cb1b9bb..b36d837 100644
--- a/include/net/af_un
Signed-off-by: "Eric W. Biederman"
---
net/xfrm/xfrm_policy.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index 418daa038edf..be1776bc5673 100644
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -1887,6 +18
For consistency with the other similar methods in the kernel pass a
struct sock into the dst_ops .local_out method.
Simplifying the socket passing case is needed a prequel to passing a struct net
reference into .local_out.
Signed-off-by: "Eric W. Biederman"
---
drivers/net/vrf.c | 4 ++--
Compute net and store it in a variable in the functions
ip_build_and_send_pkt and ip_queue_xmit so that it does not need to be
recomputed next time it is needed.
Signed-off-by: "Eric W. Biederman"
---
net/ipv4/ip_output.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --g
Only __ip6_local_out_sk has callers so rename __ip6_local_out_sk
__ip6_local_out and remove the previous __ip6_local_out.
Signed-off-by: "Eric W. Biederman"
---
include/net/ipv6.h | 3 +--
net/ipv6/output_core.c | 9 ++---
net/ipv6/route.c| 2 +-
net/ipv6/xfrm6_policy.c | 2 +-
Replace dst_output_okfn with dst_output
Signed-off-by: "Eric W. Biederman"
---
include/net/dst.h | 6 +-
net/decnet/dn_nsp_out.c | 4 ++--
net/ipv4/ip_forward.c | 2 +-
net/ipv4/ip_output.c| 7 ---
net/ipv4/ip_vti.c | 2 +-
net/ip
Signed-off-by: "Eric W. Biederman"
---
include/net/ip.h| 3 +--
net/ipv4/ip_output.c| 9 ++---
net/ipv4/route.c| 2 +-
net/ipv4/xfrm4_policy.c | 2 +-
4 files changed, 5 insertions(+), 11 deletions(-)
diff --git a/include/net/ip.h b/include/net/ip.h
index ea1f721f7224..46
Stop hidding the sk paramater with an inline helper function and
make all of the callers pass it, so that it is clear what the
function is doing.
Signed-off-by: "Eric W. Biederman"
---
drivers/net/ipvlan/ipvlan_core.c| 2 +-
include/net/ip6_tunnel.h| 2 +-
include/net/ipv6.h
It is confusing and silly hiding a paramater so modify all of
the callers to pass in the appropriate socket or skb->sk if
no socket is known.
Signed-off-by: "Eric W. Biederman"
---
drivers/net/ipvlan/ipvlan_core.c| 2 +-
drivers/net/ppp/pptp.c | 2 +-
drivers/net/vrf.c
Store net in a variable in ip_tunnel_xmit so it does not need
to be recomputed when it is used again.
Signed-off-by: "Eric W. Biederman"
---
net/ipv4/ip_tunnel_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/ip_tunnel_core.c b/net/ipv4/ip_tunnel_core.c
ind
In the rare case where sk != skb->sk ip_local_out_sk arranges
to call dst->output differently if the skb is queued or not.
This is a bug.
Fix this bug by passing the sk parameter of ip_local_out_sk through
from ip_local_out_sk to __ip_local_out_sk (skipping __ip_local_out).
Fixes: 7026b1ddb6b8d4e
This is the next installment of my work to pass struct net through the
output path so the code does not need to guess how to figure out which
network namespace it is in, and ultimately routes can have output
devices in another network namespace.
The first patch in this series is a fix for a bug t
On Tue, 6 Oct 2015 11:26:31 -0700, Pravin Shelar wrote:
> I do not see need to drop and reallocate dst in this operation. I just
> need to set source IP address and source and dst port in the metadata
> dst already set in skb.
If I'm looking at the code correctly, metadata_dst is stored in the
act
On 15-09-30 09:04 PM, kbuild test robot wrote:
> Hi Arun,
>
> [auto build test results on v4.3-rc3 -- if it's inappropriate base, please
> ignore]
>
> config: um-allyesconfig (attached as .config)
> reproduce:
> git checkout 0560b94805aa3bb38439b4f72b776d85d2aac394
> # save the a
On Tue, Oct 6, 2015 at 11:45 AM, Jiri Benc wrote:
> On Tue, 6 Oct 2015 11:28:08 -0700, Pravin Shelar wrote:
>> What do you have in mind? I do not see way to fix this issue in vport-*.c.
>
> It seems to me that e.g. the code you have in vxlan_egress_tun_info in
> drivers/net/vxlan.c can be put into
From: Roopa Prabhu
This patch adds support for MPLS multipath routes.
Includes following changes to support multipath:
- splits struct mpls_route into 'struct mpls_route + struct mpls_nh'
- 'struct mpls_nh' represents a mpls nexthop label forwarding entry
- moves mpls route and nexthop structu
From: Roopa Prabhu
This patch adds support for MPLS multipath routes.
Includes following changes to support multipath:
- splits struct mpls_route into 'struct mpls_route + struct mpls_nh'.
- struct mpls_nh represents a mpls nexthop label forwarding entry
- Adds support to parse/fill RTA_MULTIP
1 - 100 of 224 matches
Mail list logo
