Re: [pve-devel] bridge vlan range, kernel 4.1 : "message truncated" warning when too much vlans defined

2015-09-09 Thread Alexandre DERUMIER
Hi, This still not fixed in iproute 4.2. Is they any plan to increase the rtnl_dump_filter buffer size soon ? Regards, Alexandre Derumier - Mail original - De: "aderumier" À: "Arad, Ronen" Cc: "netdev" , "pve-devel" Envoyé: Jeudi 30 Juillet 2015 07:31:44 Objet: Re: [pve-devel] brid

Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-09 Thread Petr Cvek
Dne 9.9.2015 v 08:25 Robert Jarzmik napsal(a): > Petr Cvek writes: > >> Dne 8.9.2015 v 22:24 Petr Cvek napsal(a): >>> >>> Did you defined resources somewhere? Actual resources are in >>> "pxa_ir_resources" variable at: > I have them in patch [1], which is exactly the patch you have made yourself.

Re: [PATCH net-next] Revert "net/ipv6: add sysctl option accept_ra_min_hop_limit"

2015-09-09 Thread YOSHIFUJI Hideaki
Sabrina Dubroca wrote: > 2015-09-02, 16:11:10 -0700, David Miller wrote: >> From: Sabrina Dubroca >> Date: Wed, 2 Sep 2015 11:43:01 +0200 >> >>> This reverts commit 8013d1d7eafb0589ca766db6b74026f76b7f5cb4. >>> >>> There are several issues with this patch. >>> It completely cancels the security ch

Re: [PATCH] ipv6: fix ifnullfree.cocci warnings

2015-09-09 Thread roopa
On 9/9/15, 3:57 PM, kbuild test robot wrote: net/ipv6/route.c:2946:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before s

Re: [PATCH net v4] ipv6: fix multipath route replace error recovery

2015-09-09 Thread roopa
On 9/9/15, 2:10 PM, David Miller wrote: From: Roopa Prabhu Date: Tue, 8 Sep 2015 10:53:04 -0700 This patch reduces the possibility of this by doing the following: a) Changes the existing multipath route add code to a two stage process: build rt6_infos + insert them ip6_route_add rt

Re: [PATCH net v2 0/2] xen-net{front,back}: respect user provided max_queues

2015-09-09 Thread David Miller
From: David Miller Date: Wed, 09 Sep 2015 21:53:22 -0700 (PDT) > From: Wei Liu > Date: Wed, 9 Sep 2015 11:23:04 +0100 > >> Wei Liu (2): >> xen-netback: respect user provided max_queues >> xen-netfront: respect user provided max_queues > > Both applied, thanks. Yo, this doesn't even compil

[PATCH net 2/2] tcp_cubic: better follow cubic curve after idle period

2015-09-09 Thread Eric Dumazet
From: Eric Dumazet Jana Iyengar found an interesting issue on CUBIC : The epoch is only updated/reset initially and when experiencing losses. The delta "t" of now - epoch_start can be arbitrary large after app idle as well as the bic_target. Consequentially the slope (inverse of ca->cnt) would b

[PATCH net 1/2] tcp: generate CA_EVENT_TX_START on data frames

2015-09-09 Thread Eric Dumazet
From: Neal Cardwell Issuing a CC TX_START event on control frames like pure ACK is a waste of time, as a CC should not care. Following patch needs this change, as we want CUBIC to properly track idle time at a low cost, with a single TX_START being generated. Yuchung might slightly refine the c

Re: [PATCH] ether: add IEEE 1722 ethertype - TSN

2015-09-09 Thread David Miller
From: Henrik Austad Date: Wed, 9 Sep 2015 11:26:32 +0200 > IEEE 1722 describes AVB (later renamed to TSN - Time Sensitive > Networking), a protocol, encapsualtion and synchronization to utilize > standard networks for audio/video (and later other time-sensitive) > streams. > > This standard use

Re: [PATCH net v2 0/2] xen-net{front,back}: respect user provided max_queues

2015-09-09 Thread David Miller
From: Wei Liu Date: Wed, 9 Sep 2015 11:23:04 +0100 > Wei Liu (2): > xen-netback: respect user provided max_queues > xen-netfront: respect user provided max_queues Both applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@

Help: brctl problem

2015-09-09 Thread zhouxw
Hi,I had a problem with brctl. I got a brand new Ubuntu 14.04 system installed, and then installed the bridge-utile package with apt-get command. Then I issued: "brctl addbr testbr", it was ok, then I issued: "brctl setfd testbr 1", I got following output: "set forward delay failed: File exists"

Re: [PATCH net] netlink, mmap: fix edge-case leakages in nf queue zero-copy

2015-09-09 Thread David Miller
From: Daniel Borkmann Date: Thu, 10 Sep 2015 02:10:57 +0200 > When netlink mmap on receive side is the consumer of nf queue data, > it can happen that in some edge cases, we write skb shared info into > the user space mmap buffer: > > Assume a possible rx ring frame size of only 4096, and the ne

Re: [PATCH net] netlink, mmap: don't walk rx ring on poll if receive queue non-empty

2015-09-09 Thread David Miller
From: Daniel Borkmann Date: Thu, 10 Sep 2015 01:20:46 +0200 > In case of netlink mmap, there can be situations where received frames > have to be placed into the normal receive queue. The ring buffer indicates > this through NL_MMAP_STATUS_COPY, so the user is asked to pick them up > via recvmsg(

Re: [PATCH net] cxgb4: changes for new firmware 1.14.4.0

2015-09-09 Thread David Miller
From: Hariprasad Shenai Date: Thu, 10 Sep 2015 09:55:13 +0530 > Incorporate fw_ldst_cmd structure change for new firmware and also > update version string for the same > > Signed-off-by: Hariprasad Shenai > --- > V2: Rebased patch to apply cleanly Applied, thanks. -- To unsubscribe from this l

[PATCH net] cxgb4: changes for new firmware 1.14.4.0

2015-09-09 Thread Hariprasad Shenai
Incorporate fw_ldst_cmd structure change for new firmware and also update version string for the same Signed-off-by: Hariprasad Shenai --- V2: Rebased patch to apply cleanly drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h | 33 +-- drivers/net/ethernet/chelsio/cxgb4/t4fw_v

[PATCH] igb: don't unmap hw_addr if its NULL

2015-09-09 Thread Jarod Wilson
I've got a startech thunderbolt dock someone loaned me, which among other things, has the following device in it: 08:00.0 Ethernet controller: Intel Corporation I210 Gigabit Network Connection (rev 03) This hotplugs just fine (kernel 4.2.0 plus a patch or two here): [ 863.020315] igb: Intel(R)

Re: [PATCH 2/2 v2] net: Remove VRF change to udp_sendmsg

2015-09-09 Thread David Ahern
On 9/9/15 9:20 PM, David Miller wrote: From: Tom Herbert Date: Wed, 9 Sep 2015 17:51:19 -0700 Consider that ip_local_out_sk calls netfilter NF_INET_LOCAL_OUT hook before dst->output, so then netfilter would start seeing packets with zero source address??? I have to agree with Tom here, this

Re: [PATCH v2] r8169: Fix sleeping function called during get_stats64

2015-09-09 Thread David Miller
From: Corinna Vinschen Date: Wed, 9 Sep 2015 23:16:40 +0200 > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=104031 > Fixes: 6e85d5ad36a26debc23a9a865c029cbe242b2dc8 > > Based on the discussion starting at > http://www.spinics.net/lists/netdev/msg342193.html > > Tested locally on RTL816

Re: [PATCH net v2 1/1] net: fec: add netif status check before set mac address

2015-09-09 Thread David Miller
From: Fugang Duan Date: Thu, 10 Sep 2015 09:35:39 +0800 > There exist one issue by below case that case system hang: > ifconfig eth0 down > ifconfig eth0 hw ether 00:10:19:19:81:19 > > After eth0 down, all fec clocks are gated off. In the .fec_set_mac_address() > function, it will set new MAC ad

Re: [PATCH 2/2 v2] net: Remove VRF change to udp_sendmsg

2015-09-09 Thread David Miller
From: Tom Herbert Date: Wed, 9 Sep 2015 17:51:19 -0700 > Consider that ip_local_out_sk calls netfilter NF_INET_LOCAL_OUT hook > before dst->output, so then netfilter would start seeing packets > with zero source address??? I have to agree with Tom here, this is fatal. -- To unsubscribe from this

Re: [PATCH net-next] Revert "net/ipv6: add sysctl option accept_ra_min_hop_limit"

2015-09-09 Thread Hangbin Liu
Hi Sabrina, 2015-09-09 18:10 GMT+08:00 Sabrina Dubroca : > 2015-09-02, 16:11:10 -0700, David Miller wrote: >> From: Sabrina Dubroca >> Date: Wed, 2 Sep 2015 11:43:01 +0200 >> >> > This reverts commit 8013d1d7eafb0589ca766db6b74026f76b7f5cb4. >> > >> > There are several issues with this patch. >>

[PATCH net v2 1/1] net: fec: add netif status check before set mac address

2015-09-09 Thread Fugang Duan
There exist one issue by below case that case system hang: ifconfig eth0 down ifconfig eth0 hw ether 00:10:19:19:81:19 After eth0 down, all fec clocks are gated off. In the .fec_set_mac_address() function, it will set new MAC address to registers, which causes system hang. So it needs to add neti

RE: [PATCH net-next 1/1] net: fec: add netif status check before set mac address

2015-09-09 Thread Duan Andy
From: Lucas Stach Sent: Wednesday, September 09, 2015 5:14 PM > To: Duan Fugang-B38611 > Cc: da...@davemloft.net; netdev@vger.kernel.org; > bhutchi...@solarflare.com > Subject: Re: [PATCH net-next 1/1] net: fec: add netif status check before > set mac address > > Am Mittwoch, den 09.09.2015, 10:

Re: [PATCH 2/2 v2] net: Remove VRF change to udp_sendmsg

2015-09-09 Thread David Ahern
On 9/9/15 6:51 PM, Tom Herbert wrote: It is NAT since you are changing the source address and modifying the transport protocol checksum below IP and transport layer. There are a bunch of side effects that you would need to consider. This is creating custom APIs changing the semantics of address s

Contact Us For Unsecured Guaranteed Loans Today!!!?

2015-09-09 Thread Guaranteed
Do you need a genuine Loan to settle your bills and start up a good business? Kindly contact us now with your details to get a good Loan at a low rate of 3% per Annu, Quick send your details via: guarloa...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body o

Re: [PATCH 3/6] ebpf: add a way to dump an eBPF program

2015-09-09 Thread Tycho Andersen
On Wed, Sep 09, 2015 at 05:44:06PM -0700, Andy Lutomirski wrote: > On Wed, Sep 9, 2015 at 5:13 PM, Tycho Andersen > wrote: > > On Wed, Sep 09, 2015 at 04:44:24PM -0700, Andy Lutomirski wrote: > >> On Wed, Sep 9, 2015 at 3:34 PM, Tycho Andersen > >> wrote: > >> > > >> > Here's a thought, > >> > >

Re: [PATCH 2/2 v2] net: Remove VRF change to udp_sendmsg

2015-09-09 Thread Tom Herbert
On Wed, Sep 9, 2015 at 5:23 PM, David Ahern wrote: > On 9/9/15 6:04 PM, Tom Herbert wrote: >> >> On Wed, Sep 9, 2015 at 2:57 PM, David Ahern >> wrote: >>> >>> Remove the VRF change in udp_sendmsg to set the source address. The VRF >>> driver already has access to the packet on the TX path via the

Re: [PATCH 3/6] ebpf: add a way to dump an eBPF program

2015-09-09 Thread Andy Lutomirski
On Wed, Sep 9, 2015 at 5:13 PM, Tycho Andersen wrote: > On Wed, Sep 09, 2015 at 04:44:24PM -0700, Andy Lutomirski wrote: >> On Wed, Sep 9, 2015 at 3:34 PM, Tycho Andersen >> wrote: >> > >> > Here's a thought, >> > >> > The set I'm currently proposing effectively separates the ref-counting >> > of

Re: [PATCH] alx: Add the Device ID for the Killer E2400

2015-09-09 Thread Ben Pope
On Thursday, September 10, 2015 03:44 AM, David Miller wrote: That's a rather rediculous Subject line, you'll need to fix that before anyone will consider your submission seriously. My apologies, first time user of git-send-email, I should have just sent it to myself as a test. The body was

[PATCH] mv643xx_eth: Neaten mv643xx_eth_program_multicast_filter

2015-09-09 Thread Joe Perches
The code around the allocation and loops are a bit obfuscated. Neaten it by using: o kcalloc with decimal count and sizeof(u32) o Decimal loop indexing and i++ not i += 4 o A promiscuous block using a similar style to the multicast block o Remove unnecessary variables Signed-off-by: Joe Perche

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-09 Thread poma
On 09.09.2015 21:04, David Miller wrote: > From: poma > Date: Wed, 9 Sep 2015 20:34:36 +0200 > >> [ 230.110233] [] dma_generic_alloc_coherent+0x96/0x130 >> [ 230.110242] [] x86_swiotlb_alloc_coherent+0x25/0x50 >> [ 230.110250] [] dma_alloc_attrs+0x6d/0xe0 >> [ 230.110265] [] rtl8169_map_c

Re: [PATCH 2/2 v2] net: Remove VRF change to udp_sendmsg

2015-09-09 Thread David Ahern
On 9/9/15 6:04 PM, Tom Herbert wrote: On Wed, Sep 9, 2015 at 2:57 PM, David Ahern wrote: Remove the VRF change in udp_sendmsg to set the source address. The VRF driver already has access to the packet on the TX path via the dst. It can be used to update the source address in the header. Since t

Re: [PATCH] ipv6: fix ifnullfree.cocci warnings

2015-09-09 Thread David Miller
From: kbuild test robot Date: Thu, 10 Sep 2015 06:57:12 +0800 > net/ipv6/route.c:2946:3-8: WARNING: NULL check before freeing functions like > kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not > needed. Maybe consider reorganizing relevant code to avoid passing NULL > valu

Re: [PATCH net] add microchip LAN88xx phy driver

2015-09-09 Thread David Miller
From: Date: Wed, 9 Sep 2015 20:49:53 + > Add Microchip LAN88XX phy driver for phylib. > > Signed-off-by: Woojung Huh Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vg

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-09 Thread David Miller
From: Marcelo Ricardo Leitner Date: Wed, 9 Sep 2015 17:03:01 -0300 > So the fix then is to invert the initialization order inside > register_pernet_subsys() so that the control socket is created by last > and also block socket creation if netns initialization wasn't yet > performed. If we reall

Re: [PATCH 3/6] ebpf: add a way to dump an eBPF program

2015-09-09 Thread Tycho Andersen
On Wed, Sep 09, 2015 at 04:44:24PM -0700, Andy Lutomirski wrote: > On Wed, Sep 9, 2015 at 3:34 PM, Tycho Andersen > wrote: > > > > Here's a thought, > > > > The set I'm currently proposing effectively separates the ref-counting > > of the struct seccomp_filter from the struct bpf_prog (by necessit

[PATCH net] netlink, mmap: fix edge-case leakages in nf queue zero-copy

2015-09-09 Thread Daniel Borkmann
When netlink mmap on receive side is the consumer of nf queue data, it can happen that in some edge cases, we write skb shared info into the user space mmap buffer: Assume a possible rx ring frame size of only 4096, and the network skb, which is being zero-copied into the netlink skb, contains pag

Re: [PATCH v4] stmmac: fix check for phydev being open

2015-09-09 Thread David Miller
From: Alexey Brodkin Date: Wed, 9 Sep 2015 18:01:08 +0300 > Current check of phydev with IS_ERR(phydev) may make not much sense > because of_phy_connect() returns NULL on failure instead of error value. > > Still for checking result of phy_connect() IS_ERR() makes perfect sense. > > So let's u

Re: [PATCH 0/4] net: a few kzalloc/memset cleanups

2015-09-09 Thread David Miller
From: Rasmus Villemoes Date: Wed, 9 Sep 2015 10:38:01 +0200 > These are just a few k[czm]alloc/memset related cleanups. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 2/2 v2] net: Remove VRF change to udp_sendmsg

2015-09-09 Thread Tom Herbert
On Wed, Sep 9, 2015 at 2:57 PM, David Ahern wrote: > Remove the VRF change in udp_sendmsg to set the source address. The VRF > driver already has access to the packet on the TX path via the dst. It > can be used to update the source address in the header. Since the VRF > device is directly associa

Re: [PATCH net-next 1/2] net: Refactor path selection in __ip_route_output_key

2015-09-09 Thread David Miller
From: David Ahern Date: Wed, 9 Sep 2015 16:56:16 -0600 > arg... I goofed the subject line (default is net-next via git config), > but this one is required for 2/2 so if you want 2/2 for net this one > should be net as well. Understood. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-09 Thread poma
[PATCH v2] r8169: Fix sleeping function called during get_stats64 http://www.spinics.net/lists/netdev/msg342490.html - the noise is still present Corinna, care to share kernel-core & kernel-modules you are testing with, to unravel the Gordian Knot? -- To unsubscribe from this list: send the line

Re: [PATCH 3/6] ebpf: add a way to dump an eBPF program

2015-09-09 Thread Andy Lutomirski
On Wed, Sep 9, 2015 at 3:34 PM, Tycho Andersen wrote: > On Fri, Sep 04, 2015 at 06:27:27PM -0600, Tycho Andersen wrote: >> On Fri, Sep 04, 2015 at 04:08:53PM -0700, Andy Lutomirski wrote: >> > On Fri, Sep 4, 2015 at 3:28 PM, Tycho Andersen >> > wrote: >> > > On Fri, Sep 04, 2015 at 02:48:03PM -07

Re: [PATCH 3/4] net: mv643xx_eth: use kzalloc

2015-09-09 Thread Joe Perches
On Wed, 2015-09-09 at 11:45 -0700, Joe Perches wrote: > On Wed, 2015-09-09 at 20:34 +0200, Rasmus Villemoes wrote: > > mc_spec and mc_other are u32*, we allocate 0x200 = 512 bytes = 128 > > u32s, and pointer arithmetic makes mc_other point to the latter 64. Then > > the memory is cleared 256 bytes

[PATCH net] netlink, mmap: don't walk rx ring on poll if receive queue non-empty

2015-09-09 Thread Daniel Borkmann
In case of netlink mmap, there can be situations where received frames have to be placed into the normal receive queue. The ring buffer indicates this through NL_MMAP_STATUS_COPY, so the user is asked to pick them up via recvmsg(2) syscall, and to put the slot back to NL_MMAP_STATUS_UNUSED. Commit

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-09 Thread poma
On 09/09/2015 09:08 PM, Corinna Vinschen wrote: > On Sep 9 20:34, poma wrote: >> On 09/09/2015 05:55 PM, Corinna Vinschen wrote: >>> On Sep 9 17:54, Corinna Vinschen wrote: On Sep 9 17:24, poma wrote: > [PATCH net] r8169: Fix sleeping function called during get_stats64 > http://marc

Re: IFLA_INET6_[ICMP6]STATS

2015-09-09 Thread Eric Dumazet
On Wed, 2015-09-09 at 17:34 -0400, Sowmini Varadhan wrote: > I'm doing some experiments that are trying to simultaneously > scaling the number of CPUs, and the number of processes > and encountering getifaddrs() weaknesses. > > Others have run into similar things in the past, e.g., > http://l

[net:master 30/34] net/ipv6/route.c:2946:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizi

2015-09-09 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master head: f53de1e9a4aaf8cbe08845da6f7ff26a078ac507 commit: 6b9ea5a64ed5eeb3f68f2e6fcce0ed1179801d1e [30/34] ipv6: fix multipath route replace error recovery coccinelle warnings: (new ones prefixed by >>) >> net/ipv6/rout

[PATCH] ipv6: fix ifnullfree.cocci warnings

2015-09-09 Thread kbuild test robot
net/ipv6/route.c:2946:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on

Re: [PATCH net-next 1/2] net: Refactor path selection in __ip_route_output_key

2015-09-09 Thread David Ahern
arg... I goofed the subject line (default is net-next via git config), but this one is required for 2/2 so if you want 2/2 for net this one should be net as well. On 9/9/15 3:57 PM, David Ahern wrote: VRF device needs same path selection following lookup to set source address. Rather than dup

Re: [PATCH 3/6] ebpf: add a way to dump an eBPF program

2015-09-09 Thread Tycho Andersen
On Fri, Sep 04, 2015 at 06:27:27PM -0600, Tycho Andersen wrote: > On Fri, Sep 04, 2015 at 04:08:53PM -0700, Andy Lutomirski wrote: > > On Fri, Sep 4, 2015 at 3:28 PM, Tycho Andersen > > wrote: > > > On Fri, Sep 04, 2015 at 02:48:03PM -0700, Andy Lutomirski wrote: > > >> On Fri, Sep 4, 2015 at 1:45

Re: [PATCH v6 02/10] ss: created formatters for json and hr

2015-09-09 Thread Stephen Hemminger
On Wed, 9 Sep 2015 22:00:36 + Matthias Tafelmeier wrote: > >> +#define STATIC_ASSERT(COND, MSG) \ > >> +{ \ > >> + char STATIC_ASSERT##MSG[(COND) ? 1 : -1]; \ > >> + (void)STATIC_ASSERT##MSG[0];\ > >> +} > >

Re: [PATCH v2] r8169: Fix sleeping function called during get_stats64

2015-09-09 Thread Francois Romieu
Corinna Vinschen : [...] > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 24dcbe6..c12 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c > @@ -833,7 +833,8 @@ struct rtl8169_private { > un

Re: [PATCH v6 02/10] ss: created formatters for json and hr

2015-09-09 Thread Matthias Tafelmeier
>> +#define STATIC_ASSERT(COND, MSG)\ >> +{ \ >> +char STATIC_ASSERT##MSG[(COND) ? 1 : -1]; \ >> +(void)STATIC_ASSERT##MSG[0];\ >> +} > > If you are going to introduce this, please use same convention >

[PATCH 2/2 v2] net: Remove VRF change to udp_sendmsg

2015-09-09 Thread David Ahern
Remove the VRF change in udp_sendmsg to set the source address. The VRF driver already has access to the packet on the TX path via the dst. It can be used to update the source address in the header. Since the VRF device is directly associated with a table use fib_table_lookup rather than the ip_rou

[PATCH net-next 1/2] net: Refactor path selection in __ip_route_output_key

2015-09-09 Thread David Ahern
VRF device needs same path selection following lookup to set source address. Rather than duplicating code, move existing code into a function that is exported to modules. Signed-off-by: David Ahern --- include/net/ip_fib.h | 2 ++ net/ipv4/fib_semantics.c | 18 ++ net/ipv4/r

Re: IFLA_INET6_[ICMP6]STATS

2015-09-09 Thread Sowmini Varadhan
On (09/09/15 14:43), David Miller wrote: > > But what we could do is add a flag in the netlink request which > elides the stats. GLIBC et al. could then start setting the flag. > Yes, interestingly that's what I was experimenting with myself (though I was using a setsockopt in my version). I'l

Re: IFLA_INET6_[ICMP6]STATS

2015-09-09 Thread David Miller
From: Sowmini Varadhan Date: Wed, 9 Sep 2015 17:34:44 -0400 > So the question is- who uses IFLA_INET6_STATS/IFLA_INET6_ICMP6STATS? > Is this intended for some ND/ripngd etc daemon? Doesnt seem to > be documented in rtnetlink(7), and couldnt find any users in glibc, > and google did not find any

IFLA_INET6_[ICMP6]STATS

2015-09-09 Thread Sowmini Varadhan
I'm doing some experiments that are trying to simultaneously scaling the number of CPUs, and the number of processes and encountering getifaddrs() weaknesses. Others have run into similar things in the past, e.g., http://lists.openwall.net/netdev/2014/01/23/119 and more relevant to my experi

Re: [PATCH v6 02/10] ss: created formatters for json and hr

2015-09-09 Thread Stephen Hemminger
On Wed, 9 Sep 2015 19:43:13 + Matthias Tafelmeier wrote: > +#define STATIC_ASSERT(COND, MSG) \ > +{\ > + char STATIC_ASSERT##MSG[(COND) ? 1 : -1]; \ > + (void)STATIC_ASSERT##MSG[0];\ > +} If you

Re: [net-next PATCH v3] net: ipv6: use common fib_default_rule_pref

2015-09-09 Thread David Miller
From: Phil Sutter Date: Wed, 9 Sep 2015 14:20:56 +0200 > This switches IPv6 policy routing to use the shared > fib_default_rule_pref() function of IPv4 and DECnet. It is also used in > multicast routing for IPv4 as well as IPv6. > > The motivation for this patch is a complaint about iproute2 be

[PATCH 05/13] Hide some of "struct elf_prstatus" behind #ifdef __KERNEL__

2015-09-09 Thread Palmer Dabbelt
This one scares me: while I can't find any system calls that directly take this as an argument, a comment in " Generic ptrace interface that exports the architecture specific regsets using the corresponding NT_* types (which are also used in the core dump). Please note that the NT_PRS

[PATCH v2] r8169: Fix sleeping function called during get_stats64

2015-09-09 Thread Corinna Vinschen
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=104031 Fixes: 6e85d5ad36a26debc23a9a865c029cbe242b2dc8 Based on the discussion starting at http://www.spinics.net/lists/netdev/msg342193.html Tested locally on RTL8168evl/8111evl with various concurrent processes accessing /proc/net/dev while

[PATCH 03/13] Hide COMPAT_ATM_ADDPARTY behind #ifdef __KERNEL__

2015-09-09 Thread Palmer Dabbelt
This used to just be behind an #ifdef COMPAT_COMPAT, so most of userspace wouldn't have seen the definition before. This change just makes the __KERNEL__ part explicit to quiet the header checker. Signed-off-by: Palmer Dabbelt Reviewed-by: Andrew Waterman Reviewed-by: Albert Ou --- include/ua

Re: [PATCH] net: ethoc: Remove unnecessary #ifdef CONFIG_OF

2015-09-09 Thread David Miller
From: Tobias Klauser Date: Wed, 9 Sep 2015 11:24:29 +0200 > For !CONFIG_OF of_get_property() is defined to always return NULL. Thus > there's no need to protect the call to of_get_property() with #ifdef > CONFIG_OF. > > Signed-off-by: Tobias Klauser Applied, thanks. -- To unsubscribe from thi

Re: [PATCH] Remove #ifdef CONFIG_64BIT from all asm-generic/fcntl.h

2015-09-09 Thread Palmer Dabbelt
I cut the RISC-V stuff, but I intend to reply to it later. As you said, it's just a different topic. >>> However, I did see a lot of similar bugs now that you point me to it: >>> >>> $ grep -r \\\>> obj-tmp/usr/include/asm-generic/fcntl.h:#ifndef CONFIG_64BIT >>> obj-tmp/usr/include/asm-generic/

[PATCH 01/13] Remove #ifdef CONFIG_64BIT from all asm-generic/fcntl.h

2015-09-09 Thread Palmer Dabbelt
When working on the RISC-V port I noticed that F_SETLK64 was being defined on our 64-bit platform, despite our port being so new that we've only ever had the 64-bit file ops. Since there's not compat layer for these, this causes fcntl to bail out. It turns out that one of the ways in with F_SETLK

[PATCH 02/13] Always expose __SYSCALL(... fork ...)

2015-09-09 Thread Palmer Dabbelt
I think this change actually doesn't do anything: __NR_fork was still being defined either way, and on my machine fork() in comes from libc. That said, I don't think there's any way to determine this automatically, so this at least quiets the checker. Signed-off-by: Palmer Dabbelt Reviewed-by:

[PATCH 04/13] Always expose MAP_UNINITIALIZED to userspace

2015-09-09 Thread Palmer Dabbelt
This used to be hidden behind CONFIG_MMAP_ALLOW_UNINITIALIZED, so userspace wouldn't actually ever see it. While I could have kept hiding it, the man pages seem to indicate that MAP_UNINITIALIZED should be visible: mmap(2) MAP_UNINITIALIZED (since Linux 2.6.33) Don't clear anonymous pages

Re: [PATCH net-next 1/1] net: fec: add netif status check before set mac address

2015-09-09 Thread David Miller
From: Duan Andy Date: Wed, 9 Sep 2015 03:45:48 + > From: Florian Fainelli Sent: Wednesday, September 09, > 2015 11:38 AM >> To: Duan Fugang-B38611; da...@davemloft.net >> Cc: netdev@vger.kernel.org; bhutchi...@solarflare.com >> Subject: Re: [PATCH net-next 1/1] net: fec: add netif status ch

Re: [PATCH net] net: dsa: bcm_sf2: Fix 64-bits register writes

2015-09-09 Thread David Miller
From: Florian Fainelli Date: Tue, 8 Sep 2015 20:06:41 -0700 > The macro to write 64-bits quantities to the 32-bits register swapped > the value and offsets arguments, we want to preserve the ordering of the > arguments with respect to how writel() is implemented for instance: > value first, offs

[PATCH 06/13] Hide ep_take_care_of_epollwakeup() behind #ifdef __KERNEL__

2015-09-09 Thread Palmer Dabbelt
This doesn't make any sense to expose to userspace. Signed-off-by: Palmer Dabbelt Reviewed-by: Andrew Waterman Reviewed-by: Albert Ou --- include/uapi/linux/eventpoll.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/uapi/linux/eventpoll.h b/include/uapi/linux/eventpoll.h index

[PATCH 08/13] Hide MAX_SHARED_LIBS behind #ifdef __KERNEL__

2015-09-09 Thread Palmer Dabbelt
I'm not sure what this is, but it doesn't feel like something that should be exposed to userspace here. I'm assuming this file was exposed for the structure in it, which doesn't depend on MAX_SHARED_LIBS. Signed-off-by: Palmer Dabbelt Reviewed-by: Andrew Waterman Reviewed-by: Albert Ou --- in

Re: [PATCH net] r8169: Fix sleeping function called during get_stats64

2015-09-09 Thread Corinna Vinschen
On Sep 9 22:23, Francois Romieu wrote: > Corinna Vinschen : > [...] > > diff --git a/drivers/net/ethernet/realtek/r8169.c > > b/drivers/net/ethernet/realtek/r8169.c > > index 24dcbe6..630811a 100644 > > --- a/drivers/net/ethernet/realtek/r8169.c > > +++ b/drivers/net/ethernet/realtek/r8169.c > [

[PATCH 12/13] Hide AT_VECTOR_SIZE_ARCH behind #ifdef __KERNEL__

2015-09-09 Thread Palmer Dabbelt
I think this actually isn't a good idea, but I can't find anything outside of the kernel that's using this so I'm going to hide it. Signed-off-by: Palmer Dabbelt Reviewed-by: Andrew Waterman Reviewed-by: Albert Ou --- arch/x86/include/uapi/asm/auxvec.h | 2 ++ 1 file changed, 2 insertions(+)

[PATCH 13/13] Re-enable and clean up "check_config()" in headers_check.pl

2015-09-09 Thread Palmer Dabbelt
I recently got bit by a CONFIG_ in userspace bug. This has apparently happened before, but the check got disabled for triggering too much. In order to reduce false positives, I added some hueristics to avoid detecting comments. Since these tests all pass, I've now re-enabled them. Signed-off-by:

Re: [PATCH net] bpf: fix out of bounds access in verifier log

2015-09-09 Thread David Miller
From: Alexei Starovoitov Date: Tue, 8 Sep 2015 13:40:01 -0700 > when the verifier log is enabled the print_bpf_insn() is doing > bpf_alu_string[BPF_OP(insn->code) >> 4] > and > bpf_jmp_string[BPF_OP(insn->code) >> 4] > where BPF_OP is a 4-bit instruction opcode. > Malformed insns can cause out o

[PATCH 10/13] Hide USE_WCACHING behind #ifdef __KERNEL__

2015-09-09 Thread Palmer Dabbelt
I don't think this was ever intended to be exposed to userspace. Signed-off-by: Palmer Dabbelt Reviewed-by: Andrew Waterman Reviewed-by: Albert Ou --- include/uapi/linux/pktcdvd.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/pktcdvd.h b/include/uapi/linux/pktcdvd.h

[PATCH 09/13] Hide bp_type_idx behind #ifdef __KERNEL__

2015-09-09 Thread Palmer Dabbelt
I'm actually not sure what to do here: if this enum is meant to be used by userspace, then it has to be the same regardless of kernel configuration. One option would be to have the kernel expose all the values to userspace and then map them internally if CONFIG_HAVE_MIXED_BREAKPOINT_REGS isn't set

[PATCH 11/13] Hide MAX_RAW_MINORS behind #ifdef __KERNEL__

2015-09-09 Thread Palmer Dabbelt
I don't think this was ever meant to be exposed to userspace. Signed-off-by: Palmer Dabbelt Reviewed-by: Andrew Waterman Reviewed-by: Albert Ou --- include/uapi/linux/raw.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/raw.h b/include/uapi/linux/raw.h index 62d543e70

Re: [PATCH net v4] ipv6: fix multipath route replace error recovery

2015-09-09 Thread David Miller
From: Roopa Prabhu Date: Tue, 8 Sep 2015 10:53:04 -0700 > This patch reduces the possibility of this by doing the following: > a) Changes the existing multipath route add code to a two stage process: > build rt6_infos + insert them > ip6_route_add rt6_info creation code is moved into >

[PATCH 07/13] Make FB_BACKLIGHT_{LEVELS,MAX} always visible

2015-09-09 Thread Palmer Dabbelt
Nothing else in the kernel defines this, and this header is visible to userspace. Rather than hiding it in an #ifdef, I think it's sane to just make this visible to userspace. Signed-off-by: Palmer Dabbelt Reviewed-by: Andrew Waterman Reviewed-by: Albert Ou --- include/uapi/linux/fb.h | 3 ---

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-09 Thread Marcelo Ricardo Leitner
Em 09-09-2015 17:30, Vlad Yasevich escreveu: On 09/09/2015 04:03 PM, Marcelo Ricardo Leitner wrote: Consider sctp module is unloaded and is being requested because an user is creating a sctp socket. During initialization, sctp will add the new protocol type and then initialize pernet subsys:

Re: PATCH: netdev: add a cast NLMSG_OK to avoid a GCC warning in users' code

2015-09-09 Thread David Miller
From: "D. Hugh Redelmeier" Date: Wed, 9 Sep 2015 16:24:07 -0400 (EDT) > | From: David Miller > > | From: "D. Hugh Redelmeier" > | Date: Tue, 8 Sep 2015 09:46:56 -0400 (EDT) > | > | > Using netlink.h's NLMSG_OK correctly will cause GCC to issue a warning > | > on systems with 32-bit userland.

[PATCH] net/mac80211/rate.c: fix wrong sizeof()

2015-09-09 Thread Sergei Trofimovich
From: Sergei Trofimovich Noticed by gcc-5.2.0: net/mac80211/rate.c: In function 'rate_control_cap_mask': net/mac80211/rate.c:719:25: warning: 'sizeof' on array function parameter 'mcs_mask' will return size of 'u8 * {aka unsigned char *}' [-Wsizeof-array-argument] for (i = 0; i

[PATCH net] add microchip LAN88xx phy driver

2015-09-09 Thread Woojung.Huh
Add Microchip LAN88XX phy driver for phylib. Signed-off-by: Woojung Huh --- drivers/net/phy/Kconfig | 5 ++ drivers/net/phy/Makefile | 1 + drivers/net/phy/microchip.c | 148 +++ include/linux/microchipphy.h | 73 + 4 fil

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-09 Thread Vlad Yasevich
On 09/09/2015 04:03 PM, Marcelo Ricardo Leitner wrote: > Consider sctp module is unloaded and is being requested because an user > is creating a sctp socket. > > During initialization, sctp will add the new protocol type and then > initialize pernet subsys: > > status = sctp_v4_protosw_in

Re: [PATCH net] r8169: Fix sleeping function called during get_stats64

2015-09-09 Thread Francois Romieu
Corinna Vinschen : [...] > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 24dcbe6..630811a 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c [...] > + if (!paddr) > + return false;

Re: PATCH: netdev: add a cast NLMSG_OK to avoid a GCC warning in users' code

2015-09-09 Thread D. Hugh Redelmeier
| From: David Miller | From: "D. Hugh Redelmeier" | Date: Tue, 8 Sep 2015 09:46:56 -0400 (EDT) | | > Using netlink.h's NLMSG_OK correctly will cause GCC to issue a warning | > on systems with 32-bit userland. The definition can easily be changed | > to avoid this. | | Everyone either uses an

[PATCH net] sctp: fix race on protocol/netns initialization

2015-09-09 Thread Marcelo Ricardo Leitner
Consider sctp module is unloaded and is being requested because an user is creating a sctp socket. During initialization, sctp will add the new protocol type and then initialize pernet subsys: status = sctp_v4_protosw_init(); if (status) goto err_protosw_init;

[PATCH v6 10/10] ss: activate json_writer excluded logic

2015-09-09 Thread Matthias Tafelmeier
This small patch extends the lib json_writer module for formerly deactivated functionality. Signed-off-by: Matthias Tafelmeier --- include/json_writer.h | 1 + lib/json_writer.c | 7 --- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/include/json_writer.h b/include/json_wr

Re: [PATCH] alx: Add the Device ID for the Killer E2400 03:00.0 Ethernet controller: Qualcomm Atheros Device e0a1 (rev 10) Subsystem: Micro-Star International Co., Ltd. [MSI] Device 7977 Control: I/O+

2015-09-09 Thread David Miller
That's a rather rediculous Subject line, you'll need to fix that before anyone will consider your submission seriously. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordom

[PATCH v6 03/10] ss: removed obsolet fmt functions

2015-09-09 Thread Matthias Tafelmeier
Those functions are obsoleted since the new fmt handler mechanism subsumes their tasks. Rendundancy would be contradictory to the new mechanism. Signed-off-by: Matthias Tafelmeier Suggested-by: Hagen Paul Pfeifer --- misc/ss.c | 190 --

[PATCH v6 05/10] ss: replaced old output with new generic output mechanisms

2015-09-09 Thread Matthias Tafelmeier
This patch just adds the -j and --json flag to ss. Also it ensures proper stats components bracketization – that goes for ex. TCP, UDP, NETLINK etc. Moreover, this patch prevents human readable headers to be printed. Most importantly, with this patch, the new prepared interface to the generic out

[PATCH v6 08/10] ss: symmetrical formatter extension example

2015-09-09 Thread Matthias Tafelmeier
This commit shall show shortly where to place changes when one wants to extend an ss output formatter with a new handler (format print procedure). The extension is done symmetrically. That means, every up to now existing formatter is extended with a semantically equivalent handler (hr and json form

[PATCH v6 06/10] ss: renaming and export of current_filter

2015-09-09 Thread Matthias Tafelmeier
Exported current_filter as ss_current_filter, because in the fmt handlers, I need that piece of info to resolve out issues of json. Signed-off-by: Matthias Tafelmeier --- misc/ss.c | 154 +++--- 1 file changed, 78 insertions(+), 76 deletion

[PATCH v6 07/10] ss: symmetrical subhandler output extension example

2015-09-09 Thread Matthias Tafelmeier
This small sized patch shall convey the locations which have to be changed for a symmetrical output extension. Symmetrical means in this context all existing semantically related handlers in the diverse formatters (for hr and json up to now). Suggested-by: Hagen Paul Pfeifer Signed-off-by: Matthi

[PATCH v6 02/10] ss: created formatters for json and hr

2015-09-09 Thread Matthias Tafelmeier
This patch creates a central formatter module that acts as a kind of switch. From there, more specific handler modules for the certain output formats are called. Up to now, humand readable and json do exist. That prepares ss for potential output format extensions in the future. With the help of su

[PATCH v6 01/10] ss: rooted out ss type declarations for output formatters

2015-09-09 Thread Matthias Tafelmeier
The prospected output formatters and ss do share type declarations like slabstat or tcpstat so that the decision has been made to centralize those declarations in ss_types.h. Potential future declarations shall be placed there. The latter should help amend the extent of ss.c as well. Signed-off-b

iproute2 v6: full ss json support and general output simplification

2015-09-09 Thread Matthias Tafelmeier
- add full JSON support for ss - Patchset provides a general and easy to use abstraction to extend ss later - Patchset size is large to minimize daily use ("user" should not deal with formation (json, human readble) later on) - Patches 7/10 and 8/10 illustrate how to extend ss for new data

  1   2   >