Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-25 Thread B Viswanath
>> >> I'd rather we fix the essence of the scalability problem than add >> more spaghetti code to the various bridge paths. >> >> Can we make the fdb entries smaller? >> >> Can we enhance how we store such local entries such that they live in >> a compact datastructure? Perhaps the FDB can consist

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-25 Thread David Miller
From: Jiri Pirko Date: Wed, 26 Aug 2015 07:52:15 +0200 > They are simple statistics. But they does not fit into any existing > interface. This is about EMAD packets. They are not per-netdevice, but > per-pcidevice. So I cannot put them into ethtool. > > I see no other iface to expose this other

Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-25 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 25 Aug 2015 22:28:16 -0700 > Certainly, that should be done and I will look into it, but the > essence of this patch is a bit different. The problem here is not > the size of the fdb entries, it’s more the number of them - having > 96000 entries (even if they

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-25 Thread Jiri Pirko
Tue, Aug 25, 2015 at 11:25:21PM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Mon, 24 Aug 2015 16:45:46 +0200 > >> From: Jiri Pirko >> >> Signed-off-by: Jiri Pirko >> Signed-off-by: Ido Schimmel >> Signed-off-by: Elad Raz > >Enough with this debugfs madness. > >Expose this stuff t

Re: [PATCH net-next 0/9] DSA port configuration and status

2015-08-25 Thread Andrew Lunn
> It looks to me like there will be at least one more revision to this > series, so I'm not applying this version. Correct, and thanks. Andrew -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-25 Thread Jason Wang
On 08/26/2015 12:32 AM, Vlad Yasevich wrote: > On 08/25/2015 07:30 AM, Jason Wang wrote: >> >> On 08/25/2015 06:17 PM, Michael S. Tsirkin wrote: >>> On Mon, Aug 24, 2015 at 04:33:12PM +0800, Jason Wang wrote: > For macvlan, switch to use IFF_NO_QUEUE instead of tx_queue_len = 0. > > F

Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-25 Thread Nikolay Aleksandrov
> On Aug 25, 2015, at 5:56 PM, Stephen Hemminger > wrote: > > On Tue, 25 Aug 2015 17:34:55 -0700 > Nikolay Aleksandrov wrote: > >> From: Nikolay Aleksandrov >> >> This patch adds a new knob that, when enabled, allows to suppress the >> installation of local fdb entries in newly created vlan

Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-25 Thread Nikolay Aleksandrov
> On Aug 25, 2015, at 7:42 PM, David Miller wrote: > > From: Nikolay Aleksandrov > Date: Tue, 25 Aug 2015 17:34:55 -0700 > >> From: Nikolay Aleksandrov >> >> This patch adds a new knob that, when enabled, allows to suppress the >> installation of local fdb entries in newly created vlans. Thi

Re: [PATCH RFC 0/5] net: L2 only interfaces

2015-08-25 Thread Marcel Holtmann
Hi Dave, >> This patch series implements a L2 only interface concept which >> basically denies any kind of IP address configuration on these >> interfaces, but still allows them to be used as configuration >> end-points to keep using ethtool and friends. >> >> A cleaner approach might be to final

Re: [PATCH net] netlink: mmap: fix status setting in skb destructor

2015-08-25 Thread David Miller
From: Ken-ichirou MATSUZAWA Date: Thu, 20 Aug 2015 16:07:33 +0900 > I don't know the intension of setting VALID status in the skb > destructor. But I think it need to be set UNUSED status in case of > error then release skb, or rx ring might be filled with RESERVED > frames. > > Signed-off-by: K

Re: [PATCH net] netlink: rx mmap: fix POLLIN condition

2015-08-25 Thread David Miller
From: Ken-ichirou MATSUZAWA Date: Thu, 20 Aug 2015 14:54:47 +0900 > Now poll() returns immediately after setting kernel current frame > (ring->head) to SKIP from user space even if there are no new > frames. And in a case of all frames is VALID, user space program > unintensionally sets (only) ke

[PATCH v2 net-next 0/5] act_bpf: remove spinlock in fast path

2015-08-25 Thread Alexei Starovoitov
v1 version had a race condition in cleanup path of bpf_prog. I tried to fix it by adding new callback 'cleanup_rcu' to 'struct tcf_common' and call it out of act_api cleanup path, but Daniel noticed (thanks for the idea!) that most of the classifiers already do action cleanup out of rcu callback. S

[PATCH v2 net-next 3/5] net_sched: convert tcindex to call tcf_exts_destroy from rcu callback

2015-08-25 Thread Alexei Starovoitov
Adjust destroy path of cls_tcindex to call tcf_exts_destroy() after rcu grace period. Signed-off-by: Alexei Starovoitov --- net/sched/cls_tcindex.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/net/sched/cls_tcindex.c b/net/sched/cls_tcindex

[PATCH v2 net-next 5/5] net_sched: act_bpf: remove spinlock in fast path

2015-08-25 Thread Alexei Starovoitov
Similar to act_gact/act_mirred, act_bpf can be lockless in packet processing with extra care taken to free bpf programs after rcu grace period. Replacement of existing act_bpf (very rare) is done with synchronize_rcu() and final destruction is done from tc_action_ops->cleanup() callback that is cal

[PATCH v2 net-next 1/5] net_sched: make tcf_hash_destroy() static

2015-08-25 Thread Alexei Starovoitov
tcf_hash_destroy() used once. Make it static. Signed-off-by: Alexei Starovoitov --- include/net/act_api.h |1 - net/sched/act_api.c |3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/include/net/act_api.h b/include/net/act_api.h index 4519c81304bd..9d446f136607 10064

[PATCH v2 net-next 2/5] net_sched: act_bpf: remove unnecessary copy

2015-08-25 Thread Alexei Starovoitov
Fix harmless typo and avoid unnecessary copy of empty 'prog' into unused 'strcut tcf_bpf_cfg old'. Fixes: f4eaed28c783 ("act_bpf: fix memory leaks when replacing bpf programs") Signed-off-by: Alexei Starovoitov --- net/sched/act_bpf.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH v2 net-next 4/5] net_sched: convert rsvp to call tcf_exts_destroy from rcu callback

2015-08-25 Thread Alexei Starovoitov
Adjust destroy path of cls_rsvp to call tcf_exts_destroy() after rcu grace period. Signed-off-by: Alexei Starovoitov --- net/sched/cls_rsvp.h | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/net/sched/cls_rsvp.h b/net/sched/cls_rsvp.h index 02fa82792dab..

Re: [PATCH net v2] sctp: donot reset the overall_error_count in SHUTDOWN_RECEIVE state

2015-08-25 Thread David Miller
From: Xin Long Date: Sun, 23 Aug 2015 19:30:15 +0800 Vlad et al., please review. > commit f8d960524 fix the 0 peer.rwnd issue in SHUTDOWN_PENDING state through > not reseting the overall_error_count when receive a heartbeat, but the same > issue also exists in SHUTDOWN_RECEIVE state. > > so we

Re: [PATCH 2/2] usbnet: Fix a race between usbnet_stop() and the BH

2015-08-25 Thread David Miller
From: Eugene Shatokhin Date: Mon, 24 Aug 2015 23:13:43 +0300 > The race may happen when a device (e.g. YOTA 4G LTE Modem) is > unplugged while the system is downloading a large file from the Net. > > Hardware breakpoints and Kprobes with delays were used to confirm that > the race does actually

Re: [PATCH 1/2] usbnet: Get EVENT_NO_RUNTIME_PM bit before it is cleared

2015-08-25 Thread David Miller
From: Eugene Shatokhin Date: Mon, 24 Aug 2015 23:13:42 +0300 > It is needed to check EVENT_NO_RUNTIME_PM bit of dev->flags in > usbnet_stop(), but its value should be read before it is cleared > when dev->flags is set to 0. > > The problem was spotted and the fix was provided by > Oliver Neukum

Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-25 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 25 Aug 2015 17:34:55 -0700 > From: Nikolay Aleksandrov > > This patch adds a new knob that, when enabled, allows to suppress the > installation of local fdb entries in newly created vlans. This could > pose a big scalability issue if we have a large number o

Re: [PATCH net-next 4/9] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-08-25 Thread Florian Fainelli
Le 08/23/15 14:24, Andrew Lunn a écrit : >>> + port_dn = cd->port_dn[port]; >>> + if (of_phy_is_fixed_link(port_dn)) { >>> + ret = of_phy_register_fixed_link(port_dn); >>> + if (ret) { >>> + netdev_err(master, >>> +

Re: [PATCH net] net: dsa: fix EDSA frame from hwaccel frame

2015-08-25 Thread Guenter Roeck
On Tue, Aug 25, 2015 at 06:28:34PM -0700, Florian Fainelli wrote: > Le 08/03/15 23:35, Vivien Didelot a écrit : > > If the underlying network device features NETIF_F_HW_VLAN_CTAG_TX, > > an EDSA frame is prepended with a 802.1q header once queued. > > > > To fix this, push the VLAN tag to the payl

Re: [PATCH net] net: dsa: fix EDSA frame from hwaccel frame

2015-08-25 Thread Florian Fainelli
Le 08/03/15 23:35, Vivien Didelot a écrit : > If the underlying network device features NETIF_F_HW_VLAN_CTAG_TX, > an EDSA frame is prepended with a 802.1q header once queued. > > To fix this, push the VLAN tag to the payload if present, before > checking the frame protocol. Makes sense, but you

Re: netlink_route kernel data dump size increased

2015-08-25 Thread tej parkash
On Thu, Aug 20, 2015 at 2:47 AM, Eric Dumazet wrote: > On Wed, 2015-08-19 at 23:41 +0530, tej parkash wrote: >> All, >> >> We are running application on Linux Kernel 3.10 to collect network >> interface information using NETLINK_ROUTE protocol. earlier (kernel >> 2.6.32) we were having 8K buffer

Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-25 Thread Stephen Hemminger
On Tue, 25 Aug 2015 17:34:55 -0700 Nikolay Aleksandrov wrote: > diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h > index 3d95647039d0..2bda472c5a6e 100644 > --- a/net/bridge/br_private.h > +++ b/net/bridge/br_private.h > @@ -294,6 +294,7 @@ struct net_bridge > u32

Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-25 Thread Stephen Hemminger
On Tue, 25 Aug 2015 17:34:55 -0700 Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > This patch adds a new knob that, when enabled, allows to suppress the > installation of local fdb entries in newly created vlans. This could > pose a big scalability issue if we have a large number of

[PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-25 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch adds a new knob that, when enabled, allows to suppress the installation of local fdb entries in newly created vlans. This could pose a big scalability issue if we have a large number of ports and a large number of vlans, e.g. in a 48 port device with 2000 vlan

Re: [PATCH] lib/Makefile: remove CONFIG_AVERAGE build rule

2015-08-25 Thread David Miller
From: Johannes Berg Date: Fri, 21 Aug 2015 12:13:23 +0200 > On Fri, 2015-08-21 at 10:05 +, Valentin Rothberg wrote: >> The Kconfig option AVERAGE and its implementation has been removed by >> commit f4e774f55fe0 ("average: remove out-of-line implementation"). >> Remove the dead build rule in

Re: tcp: add NV congestion control

2015-08-25 Thread David Miller
From: Lawrence Brakmo Date: Tue, 25 Aug 2015 16:33:50 -0700 > Changes from v5: cleaning of NV code, changing some default parameters I have no fundamental objections to this patch series. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@v

Re: [PATCH RFC 0/5] net: L2 only interfaces

2015-08-25 Thread David Miller
From: Florian Fainelli Date: Tue, 25 Aug 2015 15:50:10 -0700 > This patch series implements a L2 only interface concept which > basically denies any kind of IP address configuration on these > interfaces, but still allows them to be used as configuration > end-points to keep using ethtool and fri

Re: [PATCH net] net: dsa: fix EDSA frame from hwaccel frame

2015-08-25 Thread Vivien Didelot
Hi All, On Aug. Tuesday 04 (32) 02:35 AM, Vivien Didelot wrote: > If the underlying network device features NETIF_F_HW_VLAN_CTAG_TX, > an EDSA frame is prepended with a 802.1q header once queued. > > To fix this, push the VLAN tag to the payload if present, before > checking the frame protocol. >

Re: [PATCH RFC 5/5] net: dsa: bcm_sf2: Allow disabling tagging protocol

2015-08-25 Thread David Miller
From: Florian Fainelli Date: Tue, 25 Aug 2015 15:50:15 -0700 > /* Enable Broadcom tags for IMP port */ > reg = core_readl(priv, CORE_BRCM_HDR_CTRL); > - reg |= val; > + if (!tagging_disabled) Just a pet-peeve of mine, I hate conditions that read as double negatives, like this

Re: [RFC PATCH v5 net-next 4/4] tcp: add NV congestion control

2015-08-25 Thread Lawrence Brakmo
On 8/5/15, 5:51 PM, "knn...@gmail.com on behalf of Kenneth Klette Jonassen" wrote: >On Wed, Aug 5, 2015 at 3:39 AM, Lawrence Brakmo wrote: >> This is a request for comments. > >Nice to see more development on delay-based congestion control. > >It would be good to see how NV stacks up against C

Re: [PATCH] drivers: net: xgene: fix: Oops in linkwatch_fire_event

2015-08-25 Thread David Miller
From: Iyappan Subramanian Date: Tue, 25 Aug 2015 15:03:03 -0700 > [ 1065.801569] Internal error: Oops: 9606 [#1] SMP > ... > [ 1065.866655] Hardware name: AppliedMicro Mustang/Mustang, BIOS 1.1.0 Apr 22 > 2015 > [ 1065.873937] Workqueue: events_power_efficient phy_state_machine > [ 1065.8798

Re: [PATCH RFC 0/5] net: L2 only interfaces

2015-08-25 Thread Sowmini Varadhan
On Tue, Aug 25, 2015 at 4:52 PM, David Ahern wrote: > The VRF driver can check the device when the enslave request happens. > Will this work correctly if I set up a bonding interface or SVI, and want to put the bond-master or SVI in the vrf (but subsequently want to get, say, timestamp/other-st

Re: [PATCH v3 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

2015-08-25 Thread Pravin Shelar
On Tue, Aug 25, 2015 at 2:35 PM, Jesse Gross wrote: > On Tue, Aug 25, 2015 at 1:54 PM, Pravin Shelar wrote: >> On Tue, Aug 25, 2015 at 12:03 PM, Jesse Gross wrote: >>> On Mon, Aug 24, 2015 at 10:43 AM, Pravin B Shelar >>> wrote: diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c >>>

Re: [PATCH net-next] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-25 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 25 Aug 2015 16:47:00 -0700 > hahaha :-) > Sorry about that, I’m in the US but my VM is in another timezone. Anyway I’ll > submit a v2 shortly back in the future. "the future", very funny... N‹§²ζμrΈ›yϊθšΨb²X¬ΆΗ§vΨ^–)ήΊ{.nΗ+‰·§zΧ^Ύ)ν… ζθw*jg¬±¨Ά‰šŽŠέ’j/κδzΉ

Re: [Patch net] cls_u32: complete the check for non-forced case in u32_destroy()

2015-08-25 Thread David Miller
From: Cong Wang Date: Tue, 25 Aug 2015 16:38:12 -0700 > In commit 1e052be69d04 ("net_sched: destroy proto tp when all filters are > gone") > I added a check in u32_destroy() to see if all real filters are gone > for each tp, however, that is only done for root_ht, same is needed > for others. >

Re: [PATCH net-next v3 0/2] Documentation: dsa

2015-08-25 Thread David Miller
From: Florian Fainelli Date: Tue, 25 Aug 2015 15:33:12 -0700 > This patch series adds some documentation about DSA as a subsystem as well > as the SF2 driver since it slightly diverges from your average DSA driver ;) This looks great, applied, thanks! -- To unsubscribe from this list: send the l

Re: [PATCH RFC 0/5] net: L2 only interfaces

2015-08-25 Thread David Ahern
On 8/25/15 4:44 PM, Sowmini Varadhan wrote: On Tue, Aug 25, 2015 at 3:50 PM, Florian Fainelli wrote: Hi all, This patch series implements a L2 only interface concept which basically denies any kind of IP address configuration on these interfaces, but still allows them to be used as configurati

Re: [PATCH net-next] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-25 Thread Nikolay Aleksandrov
> On Aug 25, 2015, at 4:41 PM, David Miller wrote: > > From: Nikolay Aleksandrov > Date: Tue, 25 Aug 2015 03:55:27 +0300 > > If it is actually 03:55:27 +0300 where you are, please send me your > time travel device. > > And in the future please submit patches outside of your time > travelling

Re: [PATCH RFC 0/5] net: L2 only interfaces

2015-08-25 Thread Sowmini Varadhan
On Tue, Aug 25, 2015 at 3:50 PM, Florian Fainelli wrote: > Hi all, > > This patch series implements a L2 only interface concept which basically > denies > any kind of IP address configuration on these interfaces, but still allows > them > to be used as configuration end-points to keep using etht

Re: [PATCH net-next v3 2/2] Documentation: networking: dsa: Add Broadcom SF2 document

2015-08-25 Thread Vivien Didelot
On Aug. Tuesday 25 (35) 03:33 PM, Florian Fainelli wrote: > Add a document describing the Broadcom Starfigther 2 switch hardware, > its specifics, and how the driver is implemented and its specifics. > > Signed-off-by: Florian Fainelli > --- > Changes in v2: > > - address Randy Dunlap's feedback

Re: [PATCH net-next] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-25 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 25 Aug 2015 03:55:27 +0300 If it is actually 03:55:27 +0300 where you are, please send me your time travel device. And in the future please submit patches outside of your time travelling activities (ie. fix the date on your computer) thanks :-) -- To unsubsc

[PATCH net-next] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-25 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch adds a new knob that, when enabled, allows to suppress the installation of local fdb entries in newly created vlans. This could pose a big scalability issue if we have a large number of ports and a large number of vlans, e.g. in a 48 port device with 2000 vlan

[Patch net] cls_u32: complete the check for non-forced case in u32_destroy()

2015-08-25 Thread Cong Wang
In commit 1e052be69d04 ("net_sched: destroy proto tp when all filters are gone") I added a check in u32_destroy() to see if all real filters are gone for each tp, however, that is only done for root_ht, same is needed for others. This can be reproduced by the following tc commands: tc filter add

tcp: add NV congestion control

2015-08-25 Thread Lawrence Brakmo
Changes from v5: cleaning of NV code, changing some default parameters I've run more extensive tests, I'm working on updating the NV website (http://www.brakmo.org/networking/tcp-nv/TCPNV.html) should be updated by tomorrow (8/26). The updated tests include Reno, Cubic, NV and CDG and include mor

[RFC PATCH v6 net-next 1/4] tcp: replace cnt & rtt with struct in pkts_acked()

2015-08-25 Thread Lawrence Brakmo
Replace 2 arguments (cnt and rtt) in the congestion control modules' pkts_acked() function with a struct. This will allow adding more information without having to modify existing congestion control modules (tcp_nv in particular needs bytes in flight when packet was sent). As proposed by Neal Card

[RFC PATCH v6 net-next 4/4] tcp: add NV congestion control

2015-08-25 Thread Lawrence Brakmo
This is a request for comments. TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC. It is a delayed based congestion avoidance for the data center. This version has been tested within a 10G rack where the HW RTTs are 20-50us. A description of T

[RFC PATCH v6 net-next 2/4] tcp: refactor struct tcp_skb_cb

2015-08-25 Thread Lawrence Brakmo
Refactor tcp_skb_cb to create two overlaping areas to store state for incoming or outgoing skbs based on comments by Neal Cardwell to tcp_nv patch: AFAICT this patch would not require an increase in the size of sk_buff cb[] if it were to take advantage of the fact that the tcp_skb_cb head

[RFC PATCH v6 net-next 3/4] tcp: add in_flight to tcp_skb_cb

2015-08-25 Thread Lawrence Brakmo
Add in_flight (bytes in flight when packet was sent) field to tx component of tcp_skb_cb and make it available to congestion modules' pkts_acked() function through the ack_sample function argument. Signed-off-by: Lawrence Brakmo --- include/net/tcp.h | 2 ++ net/ipv4/tcp_input.c | 5 -

Re: [PATCH] net: fec: use reinit_completion() in mdio accessor functions

2015-08-25 Thread David Miller
From: Russell King Date: Tue, 25 Aug 2015 09:49:53 +0100 > Rather than re-initialising the entire completion on every mdio access, > use reinit_completion() which only resets the completion count. This > avoids possible reinitialisation of the contained spinlock and waitqueue > while they may be

Re: [PATCH RFC 0/5] net: L2 only interfaces

2015-08-25 Thread David Ahern
On 8/25/15 4:20 PM, Alexei Starovoitov wrote: On Tue, Aug 25, 2015 at 03:50:10PM -0700, Florian Fainelli wrote: Hi all, This patch series implements a L2 only interface concept which basically denies any kind of IP address configuration on these interfaces, but still allows them to be used as c

Re: [PATCH] net: phy: add locking to phy_read_mmd_indirect()/phy_write_mmd_indirect()

2015-08-25 Thread David Miller
From: Florian Fainelli Date: Tue, 25 Aug 2015 07:08:24 -0700 > Le 08/25/15 01:49, Russell King a écrit : >> The phy layer is missing locking for the above two functions - it >> has been observed that two threads (userspace and the phy worker >> thread) can race, entering the bus ->write or ->read

Re: [PATCH 0/6] RDS: Few more fixes

2015-08-25 Thread David Miller
From: Santosh Shilimkar Date: Tue, 25 Aug 2015 12:01:57 -0700 > As indicated in the earlier series [1], this is a follow-up series which > addresses few issues around the RDS FMR code. With [1] and the subject > series, now I can run many parallel threads with multiple sockets with > N x N traffi

Re: [PATCH RFC 0/5] net: L2 only interfaces

2015-08-25 Thread Florian Fainelli
On 25/08/15 16:20, Alexei Starovoitov wrote: > On Tue, Aug 25, 2015 at 03:50:10PM -0700, Florian Fainelli wrote: >> Hi all, >> >> This patch series implements a L2 only interface concept which basically >> denies >> any kind of IP address configuration on these interfaces, but still allows >> the

Re: [PATCH RFC 0/5] net: L2 only interfaces

2015-08-25 Thread Florian Fainelli
On 25/08/15 16:24, Stephen Hemminger wrote: > On Tue, 25 Aug 2015 15:50:10 -0700 > Florian Fainelli wrote: > >> Hi all, >> >> This patch series implements a L2 only interface concept which basically >> denies >> any kind of IP address configuration on these interfaces, but still allows >> them

Re: [PATCH net] vxlan: re-ignore EADDRINUSE from igmp_join

2015-08-25 Thread David Miller
From: Marcelo Ricardo Leitner Date: Tue, 25 Aug 2015 20:22:35 -0300 > Before 56ef9c909b40[1] it used to ignore all errors from igmp_join(). > That commit enhanced that and made it error out whatever error happened > with igmp_join(), but that's not good because when using multicast > groups vxlan

Re: [PATCH RFC 0/5] net: L2 only interfaces

2015-08-25 Thread Stephen Hemminger
On Tue, 25 Aug 2015 15:50:10 -0700 Florian Fainelli wrote: > Hi all, > > This patch series implements a L2 only interface concept which basically > denies > any kind of IP address configuration on these interfaces, but still allows > them > to be used as configuration end-points to keep using

Re: [PATCH net-next 1/4] net/mlx5_core: Expose transobj APIs from mlx5 core

2015-08-25 Thread David Miller
From: Achiad Shochat Date: Tue, 25 Aug 2015 15:29:57 +0300 > From: Yishai Hadas > > Move transobj.h from the core library to include/linux/mlx5 > and expose its APIs. > It enables using its functionality outside of mlx5 core. > > Signed-off-by: Yishai Hadas You can submit this patch when you

[PATCH net] vxlan: re-ignore EADDRINUSE from igmp_join

2015-08-25 Thread Marcelo Ricardo Leitner
Before 56ef9c909b40[1] it used to ignore all errors from igmp_join(). That commit enhanced that and made it error out whatever error happened with igmp_join(), but that's not good because when using multicast groups vxlan will try to join it multiple times if the socket is reused and then the 2nd a

Re: pull request: batman-adv 20150825

2015-08-25 Thread David Miller
From: Antonio Quartulli Date: Tue, 25 Aug 2015 13:02:24 +0200 > here you have another batch intended for net-next/linux-4.3. > > Most of the patches are about code restyling and beautification, > but we also a couple of non critical fixes which didn't make their > way through net. > > Please pu

Re: [PATCH RFC 0/5] net: L2 only interfaces

2015-08-25 Thread Alexei Starovoitov
On Tue, Aug 25, 2015 at 03:50:10PM -0700, Florian Fainelli wrote: > Hi all, > > This patch series implements a L2 only interface concept which basically > denies > any kind of IP address configuration on these interfaces, but still allows > them > to be used as configuration end-points to keep u

Re: pull-request: can 2015-08-25

2015-08-25 Thread David Miller
ry at: > > git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git > tags/linux-can-fixes-for-4.2-20150825 Pulled, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC, RFT PATCH 1/2] dl2k: Add support for IP1000A-based cards

2015-08-25 Thread Francois Romieu
Ondrej Zary : [...] > Actually, gigabit works with this patch. The "PHY magic" part contains > mii_write(9, 0x0700) which makes gigabit work. It'd be extatic if you could set mii->supports_gmii for the appropriate PHY so that dl2k.c::rio_get_settings returns sensible gigabit status (note: neithe

Re: [PATCH RFC 0/2] Optimize the snmp stat aggregation for large cpus

2015-08-25 Thread David Miller
From: Raghavendra K T Date: Tue, 25 Aug 2015 13:24:24 +0530 > Please let me know if you have suggestions/comments. Like Eric Dumazet said the idea is good but needs some adjustments. You might want to see whether a per-cpu work buffer works for this. It's extremely unfortunately that we can't

Re: [PATCH net-next v2] enic: reduce ioread in devcmd2

2015-08-25 Thread David Miller
From: Govindarajulu Varadarajan <_gov...@gmx.com> Date: Tue, 25 Aug 2015 14:15:11 +0530 > posted_index is RO in firmware. We need not do ioread everytime to get > posted index. Store posted index locally. > > Signed-off-by: Govindarajulu Varadarajan <_gov...@gmx.com> > --- > v2: initialize devcmd

Re: [PATCH repost net-next] net: compile renesas directory if NET_VENDOR_RENESAS is configured

2015-08-25 Thread David Miller
From: Simon Horman Date: Wed, 26 Aug 2015 08:55:39 +1000 > On Wed, Aug 26, 2015 at 12:15:57AM +0300, Sergei Shtylyov wrote: >> On 08/25/2015 11:34 AM, Sergei Shtylyov wrote: >> >> >>From: Kazuya Mizuguchi >> >> >> >>Currently the renesas ethernet driver directory is compiled if SH_ETH is >> >>c

Re: [net-next:master 1267/1290] net/rds/ib_recv.c:382:28: sparse: incorrect type in initializer (different base types)

2015-08-25 Thread santosh.shilim...@oracle.com
On 8/25/15 3:55 PM, David Miller wrote: From: kbuild test robot Date: Wed, 26 Aug 2015 06:42:39 +0800 sparse warnings: (new ones prefixed by >>) net/rds/ib_recv.c:382:28: sparse: incorrect type in initializer (different base types) net/rds/ib_recv.c:382:28:expected int [signed] can

Re: [PATCH v4 net-next] r8169: Add values missing in @get_stats64 from HW counters

2015-08-25 Thread David Miller
From: David Miller Date: Tue, 25 Aug 2015 15:59:21 -0700 (PDT) > From: Francois Romieu > Date: Wed, 26 Aug 2015 00:54:06 +0200 > >>> Bringing the interface is brought down/up should not reset the >>> counters. >> >> Afaiks rtl8169_tc_offsets.inited in rtl8169_init_counter_offsets >> takes care

Re: [PATCH v4 net-next] r8169: Add values missing in @get_stats64 from HW counters

2015-08-25 Thread David Miller
From: Francois Romieu Date: Wed, 26 Aug 2015 00:54:06 +0200 > David Miller : > [...] >> Your counter offsets should be read at probe time, not open time. > > It can be done but the "CmdRxEnb / rx traffic must be enabled" constraint > will make it a major pita. > > Reading counter offsets at t

Re: [PATCH repost net-next] net: compile renesas directory if NET_VENDOR_RENESAS is configured

2015-08-25 Thread Simon Horman
On Wed, Aug 26, 2015 at 12:15:57AM +0300, Sergei Shtylyov wrote: > On 08/25/2015 11:34 AM, Sergei Shtylyov wrote: > > >>From: Kazuya Mizuguchi > >> > >>Currently the renesas ethernet driver directory is compiled if SH_ETH is > >>configured rather than NET_VENDOR_RENESAS. Although incorrect that w

Re: [net-next:master 1267/1290] net/rds/ib_recv.c:382:28: sparse: incorrect type in initializer (different base types)

2015-08-25 Thread David Miller
From: kbuild test robot Date: Wed, 26 Aug 2015 06:42:39 +0800 > sparse warnings: (new ones prefixed by >>) > >>> net/rds/ib_recv.c:382:28: sparse: incorrect type in initializer (different >>> base types) >net/rds/ib_recv.c:382:28:expected int [signed] can_wait >net/rds/ib_recv.c:382

Re: [PATCH v4 net-next] r8169: Add values missing in @get_stats64 from HW counters

2015-08-25 Thread Francois Romieu
David Miller : [...] > Your counter offsets should be read at probe time, not open time. It can be done but the "CmdRxEnb / rx traffic must be enabled" constraint will make it a major pita. Reading counter offsets at the end of open() naturally solves this constraint (retentive error unwinding

[PATCH RFC 0/5] net: L2 only interfaces

2015-08-25 Thread Florian Fainelli
Hi all, This patch series implements a L2 only interface concept which basically denies any kind of IP address configuration on these interfaces, but still allows them to be used as configuration end-points to keep using ethtool and friends. A cleaner approach might be to finally come up with the

[PATCH RFC 3/5] net: ipv6: Skip in6_dev initialization for IFF_L2_ONLY interfaces

2015-08-25 Thread Florian Fainelli
IFF_L2_ONLY interfaces are Layer-2 only network devices and do not support configuration of IPv6 addresses, nor the full IPv6 protocol stack. Do nothing for these interfaces. Signed-off-by: Florian Fainelli --- net/ipv6/addrconf.c | 4 1 file changed, 4 insertions(+) diff --git a/net/ipv6/

[PATCH RFC 1/5] net: add IFF_L2_ONLY flag

2015-08-25 Thread Florian Fainelli
Allow network device drivers to flag specific network devices as being L2 only, that is, no IPv4/v6 configuration will be allowed on these interfaces, yet they are still usable as configuration endpoints for ethtool interfaces. Signed-off-by: Florian Fainelli --- include/uapi/linux/if.h | 5

[PATCH RFC 4/5] net: dsa: Flag slave network devices with IFF_L2_ONLY

2015-08-25 Thread Florian Fainelli
When tagging is not supported by the underlying switch driver, ds->tag_protocol will be set to DSA_TAG_PROTO_NONE, and we should be flagging the slave network devices with IFF_L2_ONLY such that IP configuration is denied and they are just control end-points. Signed-off-by: Florian Fainelli --- n

[PATCH RFC 2/5] net: ipv4: Skip in_dev initialization for IFF_L2_ONLY interfaces

2015-08-25 Thread Florian Fainelli
IFF_L2_ONLY interfaces are Layer-2 only and do not support configuration of IPv4 addresses, nor the full IPv4 protocol stack. Do nothing for these interfaces. Signed-off-by: Florian Fainelli --- net/ipv4/devinet.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ipv4/devinet.c b/net/ip

[PATCH RFC 5/5] net: dsa: bcm_sf2: Allow disabling tagging protocol

2015-08-25 Thread Florian Fainelli
Update the IMP port configuration to check whether tagging is enabled (DSA_TAG_PROTO_BRCM) or disabled (DSA_TAG_PROTO_NONE) and correctly program the relevant registers in both cases. Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 16 +--- 1 file changed, 13 insertio

Re: [PATCH net-next] inetpeer: Add support for VRFs

2015-08-25 Thread David Miller
From: David Ahern Date: Tue, 25 Aug 2015 15:41:36 -0700 > Meaning rename struct inetpeer_addr to struct inetpeer_key and > addr_compare to entry_compare or key_compare? I'm not talking about inetpeer specifically, but generally speaking everywhere you're going to have to handle this including in

Re: [PATCH net-next] vrf: Add ethernet header for pass through VRF device

2015-08-25 Thread David Miller
From: David Ahern Date: Tue, 25 Aug 2015 15:37:55 -0700 > On 8/25/15 2:02 PM, David Miller wrote: >> From: David Ahern >> Date: Sun, 23 Aug 2015 12:41:00 -0600 >> >>> @@ -250,6 +253,17 @@ static netdev_tx_t vrf_xmit(struct sk_buff *skb, >>> struct net_device *dev) >>> >>> static netdev_tx_t vr

Re: [PATCH net-next] inetpeer: Add support for VRFs

2015-08-25 Thread David Ahern
On 8/25/15 1:47 PM, David Miller wrote: From: David Ahern Date: Sun, 23 Aug 2015 20:01:34 -0600 On 8/23/15 6:15 PM, Thomas Graf wrote: On 08/23/15 at 08:26am, David Ahern wrote: inetpeer caches based on address only, so duplicate IP addresses within a namespace return the same cached entry.

[net-next:master 1267/1290] net/rds/ib_recv.c:382:28: sparse: incorrect type in initializer (different base types)

2015-08-25 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 04e1b7341dc33abe4dd3f761e2e9137701e55684 commit: 73ce4317bf983282593aff710b112a7e705620c3 [1267/1290] RDS: make sure we post recv buffers reproduce: # apt-get install sparse git checkout 73ce4317bf983282593

Re: [PATCH net-next] vrf: Add ethernet header for pass through VRF device

2015-08-25 Thread David Ahern
On 8/25/15 2:02 PM, David Miller wrote: From: David Ahern Date: Sun, 23 Aug 2015 12:41:00 -0600 @@ -250,6 +253,17 @@ static netdev_tx_t vrf_xmit(struct sk_buff *skb, struct net_device *dev) static netdev_tx_t vrf_finish(struct sock *sk, struct sk_buff *skb) { + int err; + + _

[PATCH net-next v3 2/2] Documentation: networking: dsa: Add Broadcom SF2 document

2015-08-25 Thread Florian Fainelli
Add a document describing the Broadcom Starfigther 2 switch hardware, its specifics, and how the driver is implemented and its specifics. Signed-off-by: Florian Fainelli --- Changes in v2: - address Randy Dunlap's feedback - address Vivien's feedback - fix typos/misc spelling mistakes and punctu

[PATCH net-next v3 0/2] Documentation: dsa

2015-08-25 Thread Florian Fainelli
Hi all, This patch series adds some documentation about DSA as a subsystem as well as the SF2 driver since it slightly diverges from your average DSA driver ;) Florian Fainelli (2): Documentation: networking: add a DSA document Documentation: networking: dsa: Add Broadcom SF2 document Docum

[PATCH net-next v3 1/2] Documentation: networking: add a DSA document

2015-08-25 Thread Florian Fainelli
Describe how the DSA subsystem works, its design principles, limitations, and describe in details how to implement a DSA switch driver. Acked-by: Andrew Lunn Acked-by: Scott Feldman Reviewed-by: Vivien Didelot Signed-off-by: Florian Fainelli --- Changes in v3: - add tags from Scott, Andrew an

[PATCH] drivers: net: xgene: fix: Oops in linkwatch_fire_event

2015-08-25 Thread Iyappan Subramanian
[ 1065.801569] Internal error: Oops: 9606 [#1] SMP ... [ 1065.866655] Hardware name: AppliedMicro Mustang/Mustang, BIOS 1.1.0 Apr 22 2015 [ 1065.873937] Workqueue: events_power_efficient phy_state_machine [ 1065.879837] task: fe01de105e80 ti: fe00bcf18000 task.ti: fe00bcf18000 [ 1

Re: [PATCH net-next] MAINTAINERS: update vmxnet3 driver maintainer

2015-08-25 Thread David Miller
From: Shrikrishna Khare Date: Mon, 24 Aug 2015 14:24:11 -0700 > Shreyas Bhatewara would no longer maintain the vmxnet3 driver. Taking over > the role of vmxnet3 maintainer. > > Signed-off-by: Shrikrishna Khare > Signed off-by: Shreyas Bhatewara Applied, thanks. -- To unsubscribe from this lis

Re: [PATCH v3 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

2015-08-25 Thread Jesse Gross
On Tue, Aug 25, 2015 at 1:54 PM, Pravin Shelar wrote: > On Tue, Aug 25, 2015 at 12:03 PM, Jesse Gross wrote: >> On Mon, Aug 24, 2015 at 10:43 AM, Pravin B Shelar wrote: >>> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c >>> index c05bc13..8eb875d 100644 >>> --- a/drivers/net/geneve.c >

Re: [PATCH net] ip6_gre: release cached dst on tunnel removal

2015-08-25 Thread David Miller
From: Nicolas Dichtel Date: Tue, 25 Aug 2015 16:20:34 +0200 > From: huaibin Wang > > When a tunnel is deleted, the cached dst entry should be released. > > This problem may prevent the removal of a netns (seen with a x-netns IPv6 > gre tunnel): > unregister_netdevice: waiting for lo to becom

Re: [PATCH net-next] vxlan: fix multiple inclusion of vxlan.h

2015-08-25 Thread David Miller
From: Jiri Benc Date: Tue, 25 Aug 2015 18:36:50 +0200 > The vxlan_get_sk_family inline function was added after the last #endif, > making multiple inclusion of net/vxlan.h fail. Move it to the proper place. > > Reported-by: Mark Rustad > Fixes: 705cc62f6728c ("vxlan: provide access function for

Re: [PATCH net-next] MAINTAINERS: Add VRF entry

2015-08-25 Thread David Miller
From: David Ahern Date: Tue, 25 Aug 2015 10:26:22 -0700 > Add entry for new VRF device driver. > > Signed-off-by: David Ahern Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

Re: [Patch net-next] route: fix a use-after-free

2015-08-25 Thread David Miller
From: Cong Wang Date: Tue, 25 Aug 2015 10:38:53 -0700 > This patch fixes the following crash: ... > dst is freed right before lwtstate_put(), this is not correct... > > Fixes: 61adedf3e3f1 ("route: move lwtunnel state to dst_entry") > Acked-by: Jiri Benc > Signed-off-by: Cong Wang > Signed-of

Re: [PATCH stable] Revert "dev: set iflink to 0 for virtual interfaces"

2015-08-25 Thread David Miller
From: Stephen Hemminger Date: Tue, 25 Aug 2015 14:09:58 -0700 > Dave could you include this in next update to 4.1 stable update? Queued up, thanks Stephen. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo in

Re: [RFC, RFT PATCH 1/2] dl2k: Add support for IP1000A-based cards

2015-08-25 Thread Ondrej Zary
On Tuesday 25 August 2015 23:04:30 David Miller wrote: > From: Ondrej Zary > Date: Sun, 23 Aug 2015 23:06:27 +0200 > > > Add support for IP1000A chips to dl2k driver. > > IP1000A chip looks like a TC9020 with integrated PHY. > > > > Tested with Asus NX1101. > > You're saying the PHY support is inc

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-25 Thread David Miller
From: Jiri Pirko Date: Mon, 24 Aug 2015 16:45:46 +0200 > From: Jiri Pirko > > Signed-off-by: Jiri Pirko > Signed-off-by: Ido Schimmel > Signed-off-by: Elad Raz Enough with this debugfs madness. Expose this stuff through standard interfaces. They are simple statistics for crying out loud!

Re: [PATCH] net-next: Fix warning while make xmldocs caused by skbuff.c

2015-08-25 Thread David Miller
From: Masanari Iida Date: Mon, 24 Aug 2015 22:56:54 +0900 > This patch fix following warnings. > > .//net/core/skbuff.c:407: warning: No description found > for parameter 'len' > .//net/core/skbuff.c:407: warning: Excess function parameter > 'length' description in '__netdev_alloc_skb' > .//net

  1   2   3   >