[PATCH] veth: replace iflink by a dedicated symlink in sysfs

2015-08-18 Thread Vincent Bernat
While the documentation doesn't say exactly what kind of relationship iflink should represent, until a45253, only lower devices were advertised this way. While veth cannot have a lower device, using iflink to advertise the peer may create infinite loops in programs using iflink to discover device t

Re: Regression in 4.1 with veth and IFLA_LINK

2015-08-18 Thread Vincent Bernat
Here is a proposed patch to fix this by providing a symlink to the peer instead. This may not totally replace the use of iflink since the peer won't be available through netlink anymore but maybe this is good enough for the intended use. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH net-next 06/13] route: move lwtunnel state to dst_entry

2015-08-18 Thread roopa
On 8/18/15, 1:33 PM, Jiri Benc wrote: Currently, the lwtunnel state resides in per-protocol data. This is a problem if we encapsulate ipv6 traffic in an ipv4 tunnel (or vice versa). The xmit function of the tunnel does not know whether the packet has been routed to it by ipv4 or ipv6, yet it need

[PATCH v1 4/6] ARM: dts: imx: pinfunc: add GPIO1 pin define for i.MX7d

2015-08-18 Thread Fugang Duan
Add GPIO1 pin define for i.MX7d. Signed-off-by: Fugang Duan --- arch/arm/boot/dts/imx7d-pinfunc.h | 115 ++ 1 file changed, 115 insertions(+) diff --git a/arch/arm/boot/dts/imx7d-pinfunc.h b/arch/arm/boot/dts/imx7d-pinfunc.h index a8d8149..8b3cf2bc 100644 --

[PATCH v1 2/6] ARM: imx7d: add imx7d iomux-gpr field define

2015-08-18 Thread Fugang Duan
Add imx7d iomux-gpr field define. Signed-off-by: Fugang Duan --- include/linux/mfd/syscon/imx7-iomuxc-gpr.h | 49 ++ 1 file changed, 49 insertions(+) diff --git a/include/linux/mfd/syscon/imx7-iomuxc-gpr.h b/include/linux/mfd/syscon/imx7-iomuxc-gpr.h new file mode 1

Re: [PATCH net-next] r8169:Set RxConfig on same func. with TxConfig

2015-08-18 Thread Marian Corcodel
It s not mandatory to accept these patches, if you wish to apply good if you not ,not problem. 2015-08-18 23:04 GMT+03:00, Eric Dumazet : > On Tue, 2015-08-18 at 22:10 +0300, Corcodel Marian wrote: >> Add set DMA burst size and Rx FIFO threshold on RxConfig >> register to function rtl_set_rx_t

[PATCH v1 1/6] net: phy: broadcom: add bcm54220 phy ID

2015-08-18 Thread Fugang Duan
Add bcm54220 phy ID entry. Signed-off-by: Fugang Duan --- include/linux/brcmphy.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h index 697ca77..20bed15 100644 --- a/include/linux/brcmphy.h +++ b/include/linux/brcmphy.h @@ -16,6 +16,7 @@ #de

[PATCH v1 6/6] ARM: dts: imx7d-sdb: add fec1 and fec2 support

2015-08-18 Thread Fugang Duan
Enable fec1 and fec2 for i.MX7d-sdb board. Signed-off-by: Fugang Duan --- arch/arm/boot/dts/imx7d-sdb.dts | 76 - 1 file changed, 75 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts index 4d1a4b9.

[PATCH v1 5/6] ARM: dts: imx7d: add fec1 and fec2 support for i.MX7d soc

2015-08-18 Thread Fugang Duan
Add fec1 and fec2 nodes for i.MX7d soc. Signed-off-by: Fugang Duan --- arch/arm/boot/dts/imx7d.dtsi | 36 1 file changed, 36 insertions(+) diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi index b738ce0..7631492 100644 --- a/arch/arm/b

[PATCH v1 0/6] Add fec1 and fec2 support for i.MX7d sdb board

2015-08-18 Thread Fugang Duan
The patch series is to add fec support for i.MX7d sdb board. Since i.MX7d fec ip is the same as i.MX6SX, so there have no change for driver itself. Patch#1: add bcm54220 PHY ID entry into brcmphy.h file. Patch#2: add new iomux-gpr file to define iomux-gpr register and field for i.MX7d. Patch#3:

[PATCH v1 3/6] ARM: imx: add enet init for i.MX7D platform

2015-08-18 Thread Fugang Duan
Add enet phy fixup, clock source init for i.MX7D platform. Signed-off-by: Fugang Duan --- arch/arm/mach-imx/mach-imx7d.c | 75 -- 1 file changed, 73 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-imx/mach-imx7d.c b/arch/arm/mach-imx/mach-imx7d.c

[PATCH net] sctp: start t5 timer only when peer.rwnd == 0 and in SHUTDOWN_PENDING

2015-08-18 Thread Xin Long
when A send a data to B, A close() to be in SHUTDOWN_PENDING state, but B neither claim his rwnd is 0 nor SACK this data, then A keep retransmiting this data. it should send abord after Max.Retrans times, only when peer.rwnd == 0 and more than Max.Retrans times, it will start t5 timer. Fixes: f8d9

[PATCH net] sctp: donot reset the overall_error_count in SHUTDOWN_RECEIVE state

2015-08-18 Thread Xin Long
commit f8d960524 fix the 0 peer.rwnd issue in SHUTDOWN_PENING state through not reseting the overall_error_count when recevie a heartbeat, but the same issue also exists in SHUTDOWN_RECEIVE state. Fixes: f8d960524 ("sctp: Enforce retransmission limit during shutdown") Signed-off-by: Xin Long ---

[net-next:master 269/271] drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h:970:38: sparse: incorrect type in assignment (different base types)

2015-08-18 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: c938a003448063382e0575aee2d381d4cd7aec34 commit: f34fa14cc033239037622dbe84faf53923bb7e74 [269/271] bnx2x: Add vxlan RSS support reproduce: # apt-get install sparse git checkout f34fa14cc033239037622dbe84fa

[net-next:master 272/276] net/ipv4/fib_semantics.c:553:3: error: implicit declaration of function 'lwtstate_free'

2015-08-18 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: def63be85fe774477fb66043003e5b2ee748c4fa commit: df383e6240ef222703648072dafd2a1ae21b0d2a [272/276] lwtunnel: fix memory leak config: x86_64-randconfig-i0-201533 (attached as .config) reproduce: git checkout

Re: [PATCH net-next v3] vrf: vrf_master_ifindex_rcu is not always called with rcu read lock

2015-08-18 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 18 Aug 2015 21:40:16 +0300 > From: Nikolay Aleksandrov > > While running net-next I hit this: ... > It would seem vrf_master_ifindex_rcu() can be called without RCU held in > other contexts as well so introduce a new helper which acquires rcu and > returns

Re: [net-next 00/15][pull request] Intel Wired LAN Driver Updates 2015-08-18

2015-08-18 Thread David Miller
From: Jeff Kirsher Date: Tue, 18 Aug 2015 14:09:07 -0700 > This series contains updates to igb, e100, e1000e and ixgbe. Looks good, pulled, thanks Jeff. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH net-next 1/2] lwt: Add cfg argumnt to build_state

2015-08-18 Thread Tom Herbert
Add cfg and family arguments to lwt build state functions. cfg is a void pointer and will either be a pointer to a fib_config or fib6_config structure. The family parametter indicates which one (either AF_INET or AF_INET6). LWT encpasulation implementation may use the fib configuration to build th

[PATCH net-next 2/2] ila: Precompute checksum difference for translations

2015-08-18 Thread Tom Herbert
In the ILA build state for LWT compute the checksum difference to apply to transport checksums that include the IPv6 pseudo header. The difference is between the route destination (from fib6_config) and the locator to write. Signed-off-by: Tom Herbert --- net/ipv6/ila.c | 18 ++

[PATCH net-next 0/2] ila: Precompute checksums

2015-08-18 Thread Tom Herbert
This patch set: - Adds argument ot LWT build_state that holds a pointer to the fib configuration being applied to the new route - Adds support in ILA to precompute checksum difference for performance optimization Tom Herbert (2): lwt: Add cfg argumnt to build_state ila: Precompute chec

Re: [PATCH net-next 0/4] vrf: a few simplifications and cleanups

2015-08-18 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 18 Aug 2015 20:28:00 +0300 > These patches remove some unnecessary checks (patches 3, 4), unnecessary > num_slaves member and refcnt manipulations which are already done by the > upper functions. Series applied, thanks. -- To unsubscribe from this list: send

Re: [PATCH net-next] hv_netvsc: Fix dereference of nvdev before check

2015-08-18 Thread David Miller
From: Andrew Schwartzmeyer Date: Tue, 18 Aug 2015 20:06:32 -0700 > Passes static analysis by Smatch. > > Signed-off-by: Andrew Schwartzmeyer Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordom

[PATCH net-next] hv_netvsc: Fix dereference of nvdev before check

2015-08-18 Thread Andrew Schwartzmeyer
Passes static analysis by Smatch. Signed-off-by: Andrew Schwartzmeyer --- drivers/net/hyperv/netvsc_drv.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index f3b9d3eb753b..2990024b90f9 100644 --- a/dri

RE: [PATCH] r8169: Add values missing in @get_stats64 from HW counters

2015-08-18 Thread Hayes Wang
[...] > > The TCs are only reset by a power cycle and there's no known way > > to reset them programatically. It could be cleared by setting bit 0, such as rtl_tally_reset() of r8152. Best Regards, Hayes N�r��yb�X��ǧv�^�)޺{.n�+���z�^�)w*jg����ݢj/���z�ޖ��2�ޙ&�)ߡ�a�����G���

Re: [PATCH net-next] lwtunnel: ip tunnel: fix multiple routes with different encap

2015-08-18 Thread David Miller
From: Jiri Benc Date: Tue, 18 Aug 2015 18:42:09 +0200 > Currently, two routes going through the same tunnel interface are considered > the same even when they are routed to a different host after encapsulation. > This causes all routes added after the first one to have incorrect > encapsulation p

Re: [PATCH net-next] lwtunnel: fix memory leak

2015-08-18 Thread David Miller
From: Jiri Benc Date: Tue, 18 Aug 2015 18:41:13 +0200 > The built lwtunnel_state struct has to be freed after comparison. > > Fixes: 571e722676fe3 ("ipv4: support for fib route lwtunnel encap attributes") > Signed-off-by: Jiri Benc Applied. -- To unsubscribe from this list: send the line "unsu

Re: [PATCH net] batman-adv: Fix memory leak on tt add with invalid vlan

2015-08-18 Thread David Miller
From: Sven Eckelmann Date: Tue, 18 Aug 2015 13:37:01 +0200 > The object tt_local is allocated with kmalloc and not initialized when the > function batadv_tt_local_add checks for the vlan. But this function can > only cleanup the object when the (not yet initialized) reference counter of > the obj

Re: [patch] cxgb4: memory corruption in debugfs

2015-08-18 Thread David Miller
From: Dan Carpenter Date: Tue, 18 Aug 2015 12:31:44 +0300 > You can't use kstrtoul() with an int or it causes memory corruption. > Also j should be unsigned or we have underflow bugs. > > I considered changing "j" to unsigned long but everything fits in a u32. > > Fixes: 8e3d04fd7d70 ('cxgb4: A

Re: [PATCH] r8169: Add values missing in @get_stats64 from HW counters

2015-08-18 Thread David Miller
From: Francois Romieu Date: Tue, 18 Aug 2015 23:40:17 +0200 > Corinna Vinschen : >> The r8169 driver collects statistical information returned by >> @get_stats64 by counting them in the driver itself, even though many >> (but not all) of the values are already collected by tally counters >> (TCs

Re: [PATCH] usbnet: Fix two races between usbnet_stop() and the BH

2015-08-18 Thread David Miller
From: Eugene Shatokhin Date: Fri, 14 Aug 2015 19:58:36 +0300 > 2. The second race is on dev->flags. > > dev->flags is set to 0 here: > *0 usbnet_stop (usbnet.c:816) > /* deferred work (task, timer, softirq) must also stop. > * can't flush_scheduled_work() until we drop rtnl (later), >

Re: [PATCH net-next v2 5/9] geneve: Add support to collect tunnel metadata.

2015-08-18 Thread Jesse Gross
On Mon, Aug 17, 2015 at 2:11 PM, Pravin B Shelar wrote: > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c > index 546494d..cb2d874 100644 > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve.c > +static int geneve_configure(struct net *net, struct net_device *dev, > +

Re: [PATCH net-next 04/13] ip_tunnels: add IPv6 addresses to ip_tunnel_key

2015-08-18 Thread Alexei Starovoitov
On Tue, Aug 18, 2015 at 10:33:13PM +0200, Jiri Benc wrote: > Signed-off-by: Jiri Benc > --- > drivers/net/vxlan.c| 6 +++--- > include/net/ip_tunnels.h | 23 +++ > net/core/filter.c | 4 ++-- > net/ipv4/ip_gre.c | 10 +- >

Re: [PATCH net-next v2 4/9] geneve: Make dst-port configurable.

2015-08-18 Thread Jesse Gross
On Mon, Aug 17, 2015 at 2:11 PM, Pravin B Shelar wrote: > Add netlink interface to configure Geneve UDP port number. > So that user can configure it for a Gevene device. > > Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross -- To unsubscribe from this list: send the line "unsubscribe netd

Re: [PATCH net-next v2 2/9] geneve: Use skb mark and protocol to lookup route.

2015-08-18 Thread Jesse Gross
On Mon, Aug 17, 2015 at 2:11 PM, Pravin B Shelar wrote: > On packet transmit path geneve need to lookup route. Following > patch improves route lookup using more parameters. > > Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH net-next v2 1/9] geneve: Initialize ethernet address in device setup.

2015-08-18 Thread Jesse Gross
On Mon, Aug 17, 2015 at 2:11 PM, Pravin B Shelar wrote: > Signed-off-by: Pravin B Shelar > --- > drivers/net/geneve.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Jesse Gross -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messag

[PATCHv4 net-next 01/10] openvswitch: Serialize acts with original netlink len

2015-08-18 Thread Joe Stringer
Previously, we used the kernel-internal netlink actions length to calculate the size of messages to serialize back to userspace. However,the sw_flow_actions may not be formatted exactly the same as the actions on the wire, so store the original actions length when de-serializing and re-use the orig

[PATCHv4 net-next 00/10] OVS conntrack support

2015-08-18 Thread Joe Stringer
The goal of this series is to allow OVS to send packets through the Linux kernel connection tracker, and subsequently match on fields populated by conntrack. This version addresses the feedback from v3, primarily shifting the masked set of connmark and connlabel to nest under the conntrack action.

[PATCHv4 net-next 09/10] openvswitch: Allow matching on conntrack label

2015-08-18 Thread Joe Stringer
Allow matching and setting the conntrack label field. As with ct_mark, this is populated by executing the CT action, and is a writable field. Specifying a label and optional mask allows the label to be modified, which takes effect on the entry found by the lookup of the CT action. E.g.: actions:ct

[PATCHv4 net-next 06/10] openvswitch: Allow matching on conntrack mark

2015-08-18 Thread Joe Stringer
Allow matching and setting the conntrack mark field. As with conntrack state and zone, these are populated when the CT action is executed, and are made available for matching via RECIRC. To write to this field, a value and optional mark can be passed as part of the conntrack action. E.g.: actions:

[PATCHv4 net-next 08/10] netfilter: connlabels: Export setting connlabel length

2015-08-18 Thread Joe Stringer
Add functions to change connlabel length into nf_conntrack_labels.c so they may be reused by other modules like OVS and nftables without needing to jump through xt_match_check() hoops. Suggested-by: Florian Westphal Signed-off-by: Joe Stringer Acked-by: Florian Westphal --- v2: Protect connlabe

[PATCHv4 net-next 05/10] openvswitch: Add conntrack action

2015-08-18 Thread Joe Stringer
Expose the kernel connection tracker via OVS. Userspace components can make use of the "ct()" action, followed by "recirculate", to populate the conntracking state in the OVS flow key, and subsequently match on that state. Example ODP flows allowing traffic from 1->2, only replies from 2->1: in_po

[PATCHv4 net-next 04/10] dst: Add __skb_dst_copy() variation

2015-08-18 Thread Joe Stringer
This variation on skb_dst_copy() doesn't require two skbs. Signed-off-by: Joe Stringer Acked-by: Pravin B Shelar --- v4: Add ack. --- include/net/dst.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/include/net/dst.h b/include/net/dst.h index 2578811..0539940 10064

[PATCHv4 net-next 10/10] openvswitch: Allow attaching helpers to ct action

2015-08-18 Thread Joe Stringer
Add support for using conntrack helpers to assist protocol detection. The new OVS_CT_ATTR_HELPER attribute of the ct action specifies a helper to be used for this connection. Example ODP flows allowing FTP connections from ports 1->2: in_port=1,tcp,action=ct(helper=ftp,commit),2 in_port=2,tcp,ct_s

[PATCHv4 net-next 02/10] openvswitch: Move MASKED* macros to datapath.h

2015-08-18 Thread Joe Stringer
This will allow the ovs-conntrack code to reuse these macros. Signed-off-by: Joe Stringer Acked-by: Thomas Graf Acked-by: Pravin B Shelar --- v4: Add ack. --- net/openvswitch/actions.c | 52 ++ net/openvswitch/datapath.h | 4 2 files changed,

[PATCHv4 net-next 07/10] netfilter: Always export nf_connlabels_replace()

2015-08-18 Thread Joe Stringer
The following patches will reuse this code from OVS. Signed-off-by: Joe Stringer --- v2-v4: No change. --- net/netfilter/nf_conntrack_labels.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/netfilter/nf_conntrack_labels.c b/net/netfilter/nf_conntrack_labels.c index bb53f12..daa7c13 10

[PATCHv4 net-next 03/10] ipv6: Export nf_ct_frag6_gather()

2015-08-18 Thread Joe Stringer
Signed-off-by: Joe Stringer Acked-by: Thomas Graf Acked-by: Pravin B Shelar --- v4: Add ack. --- net/ipv6/netfilter/nf_conntrack_reasm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c b/net/ipv6/netfilter/nf_conntrack_reasm.c index 6d02498..701cd2b

Re: [PATCH] r8169: Add values missing in @get_stats64 from HW counters

2015-08-18 Thread Francois Romieu
Corinna Vinschen : > The r8169 driver collects statistical information returned by > @get_stats64 by counting them in the driver itself, even though many > (but not all) of the values are already collected by tally counters > (TCs) in the NIC. Some of these TC values are not returned by > @get_st

Re: linux-next: build failure after merge of the net-next tree

2015-08-18 Thread David Miller
From: Stephen Rothwell Date: Tue, 18 Aug 2015 18:39:17 +1000 > drivers/net/built-in.o: In function `.vnic_wq_devcmd2_alloc': > (.text+0x49fe40): multiple definition of `.vnic_wq_devcmd2_alloc' > drivers/scsi/built-in.o:(.text+0xb4318): first defined here > drivers/net/built-in.o:(.opd+0x2af00): m

Re: [PATCH net-next] bnx2x: Add vxlan RSS support

2015-08-18 Thread David Miller
From: Yuval Mintz Date: Tue, 18 Aug 2015 10:22:59 +0300 > From: Rajesh Borundia > > Latest FW submission added some vxlan offload capabilities to our device. > This patch adds the ability to connect to the vxlan NDOs and configure > the UDP port associated with it in the HW. > > The device wou

Re: [PATCH net-next 0/3] D in DSA patches

2015-08-18 Thread David Miller
From: Andrew Lunn Date: Mon, 17 Aug 2015 23:52:49 +0200 > The D in DSA is distributed, meaning multiple switches can be > connected together. Currently no mainline system does this, and so the > code is broken. This patchset contains two fixes, and a small helper. > > With three of more switches

Re: [PATCH net-next v2 5/9] geneve: Add support to collect tunnel metadata.

2015-08-18 Thread David Miller
From: Pravin B Shelar Date: Mon, 17 Aug 2015 14:11:41 -0700 > + if (tun_dst) > + skb_dst_set(skb, (struct dst_entry *)tun_dst); > + Please don't cast things like this, it is completely unnecessary: skb_dst_set(skb, &tun_dst->dst); -- To unsubscribe from this list: send t

[net-next 07/15] e100: Add a check after pci_pool_create to avoid null pointer dereference

2015-08-18 Thread Jeff Kirsher
From: Jia-Ju Bai The driver lacks the check of nic->cbs_pool after pci_pool_create in e100_probe. When this function is failed, a null pointer dereference occurs when pci_pool_alloc uses nic->cbs_pool in e100_alloc_cbs. This patch adds a check and related error handling code to fix it. Signed-of

[net-next 08/15] e100: Release skb when DMA mapping is failed in e100_xmit_prepare

2015-08-18 Thread Jeff Kirsher
From: Jia-Ju Bai When pci_dma_mapping_error in e100_xmit_prepare is failed, the skb buffer allocated by netdev_alloc_skb_ip_align in e100_rx_alloc_skb is not released, which causes a possible resource leak. This patch adds error handling code to fix it. Signed-off-by: Jia-Ju Bai Tested-by: Aaro

[net-next 11/15] igb: Fix a memory leak in igb_probe

2015-08-18 Thread Jeff Kirsher
From: Jia-Ju Bai In error handling code of igb_probe, the memory adapter->shadow_vfta allocated by kcalloc in igb_sw_init is not freed. So when register_netdev or igb_init_i2c is failed, a memory leak will occur. This patch adds kfree to fix it. Signed-off-by: Jia-Ju Bai Tested-by: Aaron Brown

[net-next 15/15] ixgbe: TRIVIAL fix up double 'the' and comment style

2015-08-18 Thread Jeff Kirsher
From: Jacob Keller Signed-off-by: Jacob Keller Tested-by: Phil Schmitt Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/inte

[net-next 13/15] igb: make sure SR-IOV init uses the right number of queues

2015-08-18 Thread Jeff Kirsher
From: Todd Fujinaka Recent changes to igb_probe_vfs() could lead to the PF holding onto all of the queues. Reorder igb_probe_vfs() to be before gb_init_queue_configuration() and add some more error checking. Signed-off-by: Todd Fujinaka Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher ---

[net-next 03/15] igb: do not re-init SR-IOV during probe

2015-08-18 Thread Jeff Kirsher
From: Stefan Assmann During driver probing the following code path is triggered. igb_probe ->igb_sw_init ->igb_probe_vfs ->igb_pci_enable_sriov ->igb_sriov_reinit Doing the SR-IOV re-init is not necessary during probing since we're starting from scratch. Here we can call igb_enable_s

[net-next 06/15] igb: Teardown SR-IOV before unregister_netdev()

2015-08-18 Thread Jeff Kirsher
From: Alex Williamson When the .remove() callback for a PF is called, SR-IOV support for the device is disabled, which requires unbinding and removing the VFs. The VFs may be in-use either by the host kernel or userspace, such as assigned to a VM through vfio-pci. In this latter case, the VFs ma

[net-next 09/15] igb: Fix a deadlock in igb_sriov_reinit

2015-08-18 Thread Jeff Kirsher
From: Jia-Ju Bai When igb_init_interrupt_scheme in igb_sriov_reinit is failed, the lock acquired by rtnl_lock() is not released, which causes a deadlock. This patch adds rtnl_unlock() in error handling to fix it. Signed-off-by: Jia-Ju Bai Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher ---

[net-next 14/15] ixgbe: Simplify port-specific macros

2015-08-18 Thread Jeff Kirsher
From: Mark Rustad Simplify port-specific macros by eliminating explicit comparison with 0. More importantly, enclose formal parameter in parens to eliminate the risk of an operator precedence surprise. Signed-off-by: Mark Rustad Tested-by: Phil Schmitt Signed-off-by: Jeff Kirsher --- drivers

[net-next 02/15] igb: missing rtnl_unlock in igb_sriov_reinit()

2015-08-18 Thread Jeff Kirsher
From: Vasily Averin Signed-off-by: Vasily Averin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igb/igb_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 7b

[net-next 00/15][pull request] Intel Wired LAN Driver Updates 2015-08-18

2015-08-18 Thread Jeff Kirsher
This series contains updates to igb, e100, e1000e and ixgbe. Shota Suzuki provides a fix for a possible overflow in igb_set_interrupt_capability() which leads to an oops. When changing the number of queues by "ethtool -L", set IGB_FLAG_QUEUE_PAIRS in the same manner as when initializing the igb d

[net-next 10/15] e1000e: Modify Tx/Rx configurations to avoid null pointer dereferences in e1000_open

2015-08-18 Thread Jeff Kirsher
From: Jia-Ju Bai When e1000e_setup_rx_resources is failed in e1000_open, e1000e_free_tx_resources in "err_setup_rx" segment is executed. "writel(0, tx_ring->head)" statement in e1000_clean_tx_ring in e1000e_free_tx_resources will cause a null poonter dereference(crash), because "tx_ring->head" is

[net-next 05/15] igb: add support for 1512 PHY

2015-08-18 Thread Jeff Kirsher
From: Todd Fujinaka This patch adds support for Marvell PHY 1512 (required for I354). Submitted by: Maciej Szwed Signed-off-by: Todd Fujinaka Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igb/e1000_82575.c | 20 +- drivers/net/ethernet/intel/igb/e10

[net-next 04/15] igb: implement high frequency periodic output signals

2015-08-18 Thread Jeff Kirsher
From: Richard Cochran In addition to interrupt driven target time output events, the i210 also has two programmable clock outputs. These clocks support periods between 16 nanoseconds and 140 milliseconds. This patch implements the periodic output function using the clock outputs when possible,

[net-next 01/15] igb: Fix oops caused by missing queue pairing

2015-08-18 Thread Jeff Kirsher
From: Shota Suzuki When initializing igb driver (e.g. 82576, I350), IGB_FLAG_QUEUE_PAIRS is set if adapter->rss_queues exceeds half of max_rss_queues in igb_init_queue_configuration(). On the other hand, IGB_FLAG_QUEUE_PAIRS is not set even if the number of queues exceeds half of max_combined in

[net-next 12/15] igbvf: clear buffer_info->dma after dma_unmap_single()

2015-08-18 Thread Jeff Kirsher
From: Stefan Assmann The driver doesn't clear buffer_info->dma after calling dma_unmap_single() in all cases. This has been discovered by changing the mtu twice, which caused the following backtrace. [ 68.569280] WARNING: CPU: 2 PID: 1860 at drivers/iommu/intel-iommu.c:3517 intel_unmap+0x20c/

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2015-08-18 Thread David Miller
From: Scott Feldman Date: Tue, 18 Aug 2015 13:37:56 -0700 > On Tue, Aug 18, 2015 at 11:19 AM, Andrew Lunn wrote: >> On Tue, Aug 18, 2015 at 10:18:51AM -0700, Scott Feldman wrote: >>> On Tue, Aug 18, 2015 at 7:01 AM, Andrew Lunn wrote: >>> > On Mon, Aug 17, 2015 at 03:36:17PM -0700, sfel...@gmai

Re: [net-next RFC] net: ipv4: Send IGMP messages from highest scoped address

2015-08-18 Thread Andrew Lunn
On Tue, Aug 18, 2015 at 12:01:10PM -0700, David Miller wrote: > From: Andrew Lunn > Date: Tue, 18 Aug 2015 15:36:41 +0200 > > > We currently take the first address from the interface which is scope > > link or higher. > > > > Historically, the global scope address would of been used, but my > >

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2015-08-18 Thread Scott Feldman
On Tue, Aug 18, 2015 at 11:19 AM, Andrew Lunn wrote: > On Tue, Aug 18, 2015 at 10:18:51AM -0700, Scott Feldman wrote: >> On Tue, Aug 18, 2015 at 7:01 AM, Andrew Lunn wrote: >> > On Mon, Aug 17, 2015 at 03:36:17PM -0700, sfel...@gmail.com wrote: >> >> From: Scott Feldman >> >> >> >> > tree /sys/k

[PATCH net-next 13/13] ipv6: route: per route IP tunnel metadata via lightweight tunnel

2015-08-18 Thread Jiri Benc
Allow specification of per route IP tunnel instructions also for IPv6. This complements commit 3093fbe7ff4b ("route: Per route IP tunnel metadata via lightweight tunnel"). Signed-off-by: Jiri Benc --- include/uapi/linux/lwtunnel.h | 16 +++ net/ipv4/ip_tunnel_core.c | 102 ++

[PATCH net-next 11/13] vxlan: metadata based tunneling for IPv6

2015-08-18 Thread Jiri Benc
Support metadata based (formerly flow based) tunneling also for IPv6. This complements commit ee122c79d422 ("vxlan: Flow based tunneling"). Signed-off-by: Jiri Benc --- drivers/net/vxlan.c | 69 +++-- 1 file changed, 40 insertions(+), 29 deletions(

[PATCH net-next 01/13] ip_tunnels: remove custom alignment and packing

2015-08-18 Thread Jiri Benc
The custom alignment of struct ip_tunnel_key is unnecessary. In struct sw_flow_key, it starts at offset 256, in struct ip_tunnel_info it's the first field. The structure is also packed even without the __packed keyword. Signed-off-by: Jiri Benc --- include/net/ip_tunnels.h | 2 +- 1 file change

[PATCH net-next 09/13] vxlan: provide access function for vxlan socket address family

2015-08-18 Thread Jiri Benc
Signed-off-by: Jiri Benc --- drivers/net/vxlan.c | 8 include/net/vxlan.h | 5 + 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index e4b8ab63d0fa..d5ca1d7e0b81 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -23

[PATCH net-next 05/13] ip_tunnels: use tos and ttl fields also for IPv6

2015-08-18 Thread Jiri Benc
Rename the ipv4_tos and ipv4_ttl fields to just 'tos' and 'ttl', as they'll be used with IPv6 tunnels, too. Signed-off-by: Jiri Benc --- drivers/net/vxlan.c| 8 include/net/ip_tunnels.h | 8 net/ipv4/ip_gre.c | 8 net/ipv4/ip_tunnel_co

[PATCH net-next 02/13] ip_tunnels: use u8/u16/u32

2015-08-18 Thread Jiri Benc
The ip_tunnels.h include file uses mixture of __u16 and u16 (etc.) types. Unify it to the non-underscore variants. Signed-off-by: Jiri Benc --- include/net/ip_tunnels.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/include/net/ip_tunnels.h b/include/net/ip_

[PATCH net-next 03/13] ip_tunnels: use offsetofend

2015-08-18 Thread Jiri Benc
Signed-off-by: Jiri Benc --- include/net/ip_tunnels.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/net/ip_tunnels.h b/include/net/ip_tunnels.h index ca173f22f07f..cc3b39e9010b 100644 --- a/include/net/ip_tunnels.h +++ b/include/net/ip_tunnels.h @@ -23,9 +23,7 @@

[PATCH net-next 04/13] ip_tunnels: add IPv6 addresses to ip_tunnel_key

2015-08-18 Thread Jiri Benc
Signed-off-by: Jiri Benc --- drivers/net/vxlan.c| 6 +++--- include/net/ip_tunnels.h | 23 +++ net/core/filter.c | 4 ++-- net/ipv4/ip_gre.c | 10 +- net/ipv4/ip_tunnel_core.c | 8 net/openvswitch/flow_netlin

[PATCH net-next 07/13] ipv6: drop metadata dst in ip6_route_input

2015-08-18 Thread Jiri Benc
The fix in commit 48fb6b554501 is incomplete, as now ip6_route_input can be called with non-NULL dst if it's a metadata dst and the reference is leaked. Drop the reference. Fixes: 48fb6b554501 ("ipv6: fix crash over flow-based vxlan device") Fixes: ee122c79d422 ("vxlan: Flow based tunneling") CC:

[PATCH net-next 08/13] ipv6: ndisc: inherit metadata dst when creating ndisc requests

2015-08-18 Thread Jiri Benc
If output device wants to see the dst, inherit the dst of the original skb in the ndisc request. This is an IPv6 counterpart of commit 0accfc268f4d ("arp: Inherit metadata dst when creating ARP requests"). Signed-off-by: Jiri Benc --- include/net/ndisc.h | 3 ++- net/ipv6/addrconf.c | 2 +- n

[PATCH net-next 12/13] ipv6: route: extend flow representation with tunnel key

2015-08-18 Thread Jiri Benc
Use flowi_tunnel in flowi6 similarly to what is done with IPv4. This complements commit 1b7179d3adff ("route: Extend flow representation with tunnel key"). Signed-off-by: Jiri Benc --- include/net/flow.h | 1 + net/ipv6/route.c | 6 ++ 2 files changed, 7 insertions(+) diff --git a/include

[PATCH net-next 06/13] route: move lwtunnel state to dst_entry

2015-08-18 Thread Jiri Benc
Currently, the lwtunnel state resides in per-protocol data. This is a problem if we encapsulate ipv6 traffic in an ipv4 tunnel (or vice versa). The xmit function of the tunnel does not know whether the packet has been routed to it by ipv4 or ipv6, yet it needs the lwtstate data. Moving the lwtstate

[PATCH net-next 00/13] lwtunnel: per route ipv6 support for vxlan

2015-08-18 Thread Jiri Benc
This series enables IPv6 tunnels based on lwtunnel infrastructure. Only vxlan is supported for now. Tested in all combinations of IPv4 over IPv6, IPv6 over IPv4 and IPv6 over IPv6. Applies on top of the two generic/IPv4 fixes I posted earlier today. Jiri Benc (13): ip_tunnels: remove custom ali

[PATCH net-next 10/13] vxlan: do not shadow flags variable

2015-08-18 Thread Jiri Benc
The 'flags' variable is already defined in the outer scope. Signed-off-by: Jiri Benc --- drivers/net/vxlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index d5ca1d7e0b81..d0caac63231c 100644 --- a/drivers/net/vxlan.c +++

[PATCH net-next v3] vrf: vrf_master_ifindex_rcu is not always called with rcu read lock

2015-08-18 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov While running net-next I hit this: [ 634.073119] === [ 634.073150] [ INFO: suspicious RCU usage. ] [ 634.073182] 4.2.0-rc6+ #45 Not tainted [ 634.073213] --- [ 634.073244] include/net/vrf.h:38 suspicious rcu_de

Re: [PATCH net-next v2] vrf: vrf_master_ifindex_rcu is not always called with rcu read lock

2015-08-18 Thread Nikolay Aleksandrov
> On Aug 18, 2015, at 11:10 PM, David Ahern wrote: > > On 8/18/15 12:15 PM, Nikolay Aleksandrov wrote: >> diff --git a/include/net/vrf.h b/include/net/vrf.h >> index 3bb4af462ed6..b039850a94a3 100644 >> --- a/include/net/vrf.h >> +++ b/include/net/vrf.h >> @@ -34,7 +34,6 @@ struct net_vrf { >>

Re: [PATCH net-next v2] vrf: vrf_master_ifindex_rcu is not always called with rcu read lock

2015-08-18 Thread David Ahern
On 8/18/15 12:15 PM, Nikolay Aleksandrov wrote: diff --git a/include/net/vrf.h b/include/net/vrf.h index 3bb4af462ed6..b039850a94a3 100644 --- a/include/net/vrf.h +++ b/include/net/vrf.h @@ -34,7 +34,6 @@ struct net_vrf { #if IS_ENABLED(CONFIG_NET_VRF) -/* called with rcu_read_lock() */ sta

[PATCH net-next v2] vrf: vrf_master_ifindex_rcu is not always called with rcu read lock

2015-08-18 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov While running net-next I hit this: [ 634.073119] === [ 634.073150] [ INFO: suspicious RCU usage. ] [ 634.073182] 4.2.0-rc6+ #45 Not tainted [ 634.073213] --- [ 634.073244] include/net/vrf.h:38 suspicious rcu_de

Re: [PATCH net-next] r8169:Set RxConfig on same func. with TxConfig

2015-08-18 Thread Eric Dumazet
On Tue, 2015-08-18 at 22:10 +0300, Corcodel Marian wrote: > Add set DMA burst size and Rx FIFO threshold on RxConfig > register to function rtl_set_rx_tx_config_register. > > > Signed-off-by: Corcodel Marian > > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/r

Re: [PATCH net-next] vrf: vrf_master_ifindex_rcu is not always called with rcu read lock

2015-08-18 Thread David Ahern
On 8/18/15 10:17 AM, Nikolay Aleksandrov wrote: diff --git a/include/net/vrf.h b/include/net/vrf.h index 40e3793c7a05..22dfe2195092 100644 --- a/include/net/vrf.h +++ b/include/net/vrf.h @@ -35,7 +35,6 @@ struct net_vrf { #if IS_ENABLED(CONFIG_NET_VRF) -/* called with rcu_read_lock() */ sta

Re: [PATCH net-next] r8169:Set RxConfig on same func. with TxConfig

2015-08-18 Thread David Miller
From: Corcodel Marian Date: Tue, 18 Aug 2015 22:10:21 +0300 > Add set DMA burst size and Rx FIFO threshold on RxConfig > register to function rtl_set_rx_tx_config_register. > > > Signed-off-by: Corcodel Marian I would like to politely ask you to stop submitting these r8169 patches right

Re: [PATCH net-next 0/4] vrf: a few simplifications and cleanups

2015-08-18 Thread David Ahern
On 8/18/15 11:28 AM, Nikolay Aleksandrov wrote: From: Nikolay Aleksandrov Hi, These patches remove some unnecessary checks (patches 3, 4), unnecessary num_slaves member and refcnt manipulations which are already done by the upper functions. Cheers, Nik Nikolay Aleksandrov (4): vrf: drop

[PATCH net-next 2/4] vrf: drop unused num_slaves member

2015-08-18 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov slave_queue has a num_slaves member which is unused, drop it. Signed-off-by: Nikolay Aleksandrov --- drivers/net/vrf.c | 2 -- include/net/vrf.h | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index cd4bc77f2e04..3d7da0c6f827

[PATCH net-next 4/4] vrf: simplify the netdev notifier function

2015-08-18 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov We can drop the check because if vrf_ptr is present then we must have the vrf device as a master and since we're running with rtnl it can't go away. Signed-off-by: Nikolay Aleksandrov --- drivers/net/vrf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) di

[PATCH net-next 3/4] vrf: don't check for dstats and rth in uninit path

2015-08-18 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov dstats and rth are always present because we fail the device registration if they can't be allocated in vrf_init() (ndo_init) so drop the unnecessary checks. Signed-off-by: Nikolay Aleksandrov --- drivers/net/vrf.c | 6 ++ 1 file changed, 2 insertions(+), 4 deleti

[PATCH net-next 1/4] vrf: drop unnecessary dev refcnt changes

2015-08-18 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov netdev_master_upper_dev_link/unlink already do a dev_hold/put on the devices being linked, so no need to take another reference. Signed-off-by: Nikolay Aleksandrov --- drivers/net/vrf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/vrf.c b/drivers/n

[PATCH net-next 0/4] vrf: a few simplifications and cleanups

2015-08-18 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Hi, These patches remove some unnecessary checks (patches 3, 4), unnecessary num_slaves member and refcnt manipulations which are already done by the upper functions. Cheers, Nik Nikolay Aleksandrov (4): vrf: drop unnecessary dev refcnt changes vrf: drop unused nu

[PATCH net-next] r8169:Set RxConfig on same func. with TxConfig

2015-08-18 Thread Corcodel Marian
Add set DMA burst size and Rx FIFO threshold on RxConfig register to function rtl_set_rx_tx_config_register. Signed-off-by: Corcodel Marian diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 6d16de3..c3c908c 100644 --- a/drivers/net/ethernet/re

Re: [net-next RFC] net: ipv4: Send IGMP messages from highest scoped address

2015-08-18 Thread David Miller
From: Andrew Lunn Date: Tue, 18 Aug 2015 15:36:41 +0200 > We currently take the first address from the interface which is scope > link or higher. > > Historically, the global scope address would of been used, but my > previous fix, which stopped it taking a global scope address from a > differen

Re: [PATCH 00/21] net: Convert drivers to IFF_NO_QUEUE and cleanup afterwards

2015-08-18 Thread David Miller
From: Phil Sutter Date: Tue, 18 Aug 2015 10:30:28 +0200 > This series converts in-tree users away from the old and deprecated > 'tx_queue_len = 0' idiom, adds a warning to notify out-of-tree driver > maintainers that there is need for action on their behalf and finally drops > any > workarounds

  1   2   >