Re: [PATCH 1/6] net/bonding: enable LRO if one device supports it

2015-08-13 Thread Michal Kubecek
On Thu, Aug 13, 2015 at 02:02:55PM -0400, Jarod Wilson wrote: > Currently, all bonding devices come up, and claim to have LRO support, > which ethtool will let you toggle on and off, even if none of the > underlying hardware devices actually support it. While the bonding driver > takes precautions

Re: [PATCH 1/2] average: provide macro to create static EWMA

2015-08-13 Thread Johannes Berg
On Thu, 2015-08-13 at 17:26 -0700, David Miller wrote: > From: Johannes Berg > Date: Thu, 13 Aug 2015 11:11:48 +0200 > > > From: Johannes Berg > > > > Having the EWMA parameters stored in the runtime struct imposes > > memory requirements for the constant values that could just be > > inlined i

Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-13 Thread roopa
On 8/13/15, 11:23 PM, Premkumar Jonnala wrote: Bridge devices have ageing interval used to age out MAC addresses from FDB. This ageing interval was not configuratble. Enable netlink based configuration of ageing interval for bridges and switch devices. The ageing interval changes the timer use

Re: [PATCH v2 4/4] Added getsynctime64() callback

2015-08-13 Thread Richard Cochran
On Thu, Aug 13, 2015 at 09:10:36PM +, Hall, Christopher S wrote: > > > + if (!cpu_has_art) > > > + return -EOPNOTSUPP; > > > > Perform this check before registration, setting .getsynctime64 > > accordingly. > > The problem here is that ART initialization doesn't happen until we > inst

[PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-13 Thread Premkumar Jonnala
Bridge devices have ageing interval used to age out MAC addresses from FDB. This ageing interval was not configuratble. Enable netlink based configuration of ageing interval for bridges and switch devices. The ageing interval changes the timer used to purge inactive FDB entries in bridges. The

Re: [PATCH net] inet: fix potential deadlock in reqsk_queue_unlink()

2015-08-13 Thread David Miller
From: Eric Dumazet Date: Thu, 13 Aug 2015 15:44:51 -0700 > From: Eric Dumazet > > When replacing del_timer() with del_timer_sync(), I introduced > a deadlock condition : > > reqsk_queue_unlink() is called from inet_csk_reqsk_queue_drop() > > inet_csk_reqsk_queue_drop() can be called from many

Re: [PATCH net-next 00/10] VRF-lite - v6

2015-08-13 Thread David Miller
From: David Ahern Date: Thu, 13 Aug 2015 14:58:59 -0600 > In the context of internet scale routing a requirement that always comes > up is the need to partition the available routing tables into disjoint > routing planes. A specific use case is the multi-tenancy problem where > each tenant has th

Re: [PATCH net-next] net: addr IFLA_OPERSTATE to netlink message for ipv6 ifinfo

2015-08-13 Thread David Miller
From: Andy Gospodarek Date: Thu, 13 Aug 2015 15:26:35 -0400 > This is useful information to include in ipv6 netlink messages that > report interface information. IFLA_OPERSTATE is already included in > ipv4 messages, but missing for ipv6. This closes that gap. > > Signed-off-by: Andy Gospodare

Re: [PATCH] net: allow sleeping when modifying store_rps_map

2015-08-13 Thread David Miller
From: Sasha Levin Date: Thu, 13 Aug 2015 14:03:16 -0400 > Commit 10e4ea751 ("net: Fix race condition in store_rps_map") has moved the > manipulation of the rps_needed jump label under a spinlock. Since changing > the state of a jump label may sleep this is incorrect and causes warnings > during r

Re: [PATCH net-next 0/7] net: dsa: mv88e6xxx: add hardware VLAN support

2015-08-13 Thread David Miller
From: Vivien Didelot Date: Thu, 13 Aug 2015 12:52:16 -0400 > This patchset brings support to access hardware VLAN entries in DSA and > mv88e6xxx, through switchdev VLAN objects. Looks good, series applied, thanks Vivien. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH] iwlwifi: out-of-bounds access in iwl_init_sband_channels

2015-08-13 Thread Grumbach, Emmanuel
Hi, On 08/14/2015 03:36 AM, Adrien Schildknecht wrote: > Both loops of this function compare data from the 'chan' array and then > check if the index is valid. > > The 2 conditions should be inverted to avoid an out-of-bounds access. > Was that found by a static analyzer or any other automated

Re: [PATCH net-next] rocker: add debugfs support to dump internal tables

2015-08-13 Thread David Miller
From: Stephen Hemminger Date: Thu, 13 Aug 2015 08:46:39 -0700 > Looks good. > A couple caveats about debugfs. > 1) Don't use it for API's not available elsewhere. You don't want it to become >a stable API which other tools get tied too. > 2) Best to make it an optional config option (dependen

[PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2015-08-13 Thread shh.xie
From: Shaohui Xie Currently, if phy state is PHY_RUNNING, we always register a CHANGE when phy works in polling or interrupt ignored, this will make the adjust_link being called even the phy link did Not changed. checking the phy link to make sure the link did changed before we register a CHANGE

Re: [PATCH net-next v2 2/2] net: ipv6 sysctl option to ignore routes when nexthop link is down

2015-08-13 Thread David Miller
From: Andy Gospodarek Date: Thu, 13 Aug 2015 10:39:01 -0400 > Like the ipv4 patch with a similar title, this adds a sysctl to allow > the user to change routing behavior based on whether or not the > interface associated with the nexthop was an up or down link. The > default setting preserves th

Re: [PATCH net-next v2 1/2] net: track link status of ipv6 nexthops

2015-08-13 Thread David Miller
From: Andy Gospodarek Date: Thu, 13 Aug 2015 10:39:00 -0400 > Add support to track current link status of ipv6 nexthops to match > recent changes that added support for ipv4 nexthops. This takes a > simple approach to track linkdown status for next-hops and simply > checks the dev for the dst en

Re: [PATCH net] gianfar: Restore link state settings after MAC reset

2015-08-13 Thread David Miller
From: Claudiu Manoil Date: Thu, 13 Aug 2015 16:50:37 +0300 > There are some MAC registers that need to be kept in sync > with the link state parameters, see adjust_link(). > However, after a MAC soft reset default values for > these registers are assumed. In some cases (excepting > if down/ if u

Re: [PATCH net-next 0/2] ppp: implement x-netns support

2015-08-13 Thread David Miller
From: Guillaume Nault Date: Thu, 13 Aug 2015 15:28:02 +0200 > This series allows PPP devices to reside in a different netns from the > PPP unit/channels. Packets only cross netns boundaries when they're > transmitted between the net_device and the PPP unit (units and channels > always remain in t

Re: [PATCH net] ppp: fix device unregistration upon netns deletion

2015-08-13 Thread David Miller
From: Guillaume Nault Date: Thu, 13 Aug 2015 15:18:25 +0200 > + idr_for_each_entry(&pn->units_idr, ppp, id) { > + unregister_netdevice_queue(ppp->dev, &list); > + } Single line basic blocks should not use curly braces. Please remove them, thank you. -- To unsubscribe from th

Re: [PATCH 1/1 V2] ipv4: off-by-one in continuation handling in /proc/net/route

2015-08-13 Thread David Miller
From: Andy Whitcroft Date: Thu, 13 Aug 2015 20:49:01 +0100 > When generating /proc/net/route we emit a header followed by a line for > each route. When a short read is performed we will restart this process > based on the open file descriptor. When calculating the start point we > fail to take

Re: [PATCH net-next] cxgb4: Add MPS tracing support

2015-08-13 Thread David Miller
From: Hariprasad Shenai Date: Thu, 13 Aug 2015 09:44:22 +0530 > Handle TRACE_PKT, stack can sniff them on the first port > Add debubfs enrty to configure tracing for offload traffic like iWARP > & iSCSI for debugging purpose. > > Signed-off-by: Hariprasad Shenai Applied. -- To unsubscribe from

Re: [PATCH] net/fddi: remove HWM_REVERSE() macro

2015-08-13 Thread David Miller
From: yalin wang Date: Thu, 13 Aug 2015 12:01:33 +0800 > HWM_REVERSE() macro is unused, remove it. > > Signed-off-by: yalin wang Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vg

[PATCH iproute2] ip-link: cut one level indentation

2015-08-13 Thread Zhang Shengju
Cut one level indentation to make things easier to read. Signed-off-by: Zhang Shengju --- ip/iplink.c | 65 +++-- 1 file changed, 33 insertions(+), 32 deletions(-) diff --git a/ip/iplink.c b/ip/iplink.c index 520f750..504aa74 100644 --- a/

[PATCH iproute2 2/2] netns: add missing file close

2015-08-13 Thread Zhang Shengju
Add missing file close. Signed-off-by: Zhang Shengju --- ip/ipnetns.c | 5 + 1 file changed, 5 insertions(+) diff --git a/ip/ipnetns.c b/ip/ipnetns.c index 088096f..d1af0c6 100644 --- a/ip/ipnetns.c +++ b/ip/ipnetns.c @@ -462,8 +462,10 @@ static int netns_pids(int argc, char **argv)

[PATCH iproute2 1/2] libs: close file in netns_switch()

2015-08-13 Thread Zhang Shengju
Add mising close() calls. Signed-off-by: Zhang Shengju --- lib/namespace.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/namespace.c b/lib/namespace.c index 8197165..025ed47 100644 --- a/lib/namespace.c +++ b/lib/namespace.c @@ -45,7 +45,7 @@ static void bind_etc(

[PATCH iproute2 0/2] Add missing file close

2015-08-13 Thread Zhang Shengju
This patch set adds some missing close() calls. Zhang Shengju (2): libs: close file in netns_switch() netns: add missing file close ip/ipnetns.c| 5 + lib/namespace.c | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) -- 1.8.3.1 -- To unsubscribe from this list: send t

Re: [PATCH iproute2] utils: add missing return value

2015-08-13 Thread Stephen Hemminger
On Fri, 14 Aug 2015 01:36:20 + Zhang Shengju wrote: > Add missing return value to fix warnings > > Signed-off-by: Zhang Shengju > --- > include/utils.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/utils.h b/include/utils.h > index 95d162c..0c57ccd 10064

I218 e1000e hangs.

2015-08-13 Thread Dave Jones
I've got a machine with an onboard NIC that reproduces a hardware hang every time I do an rsync to it. [ 488.752630] e1000e :00:19.0 eth0: Detected Hardware Unit Hang: TDH <27> TDT <34> next_to_use <34> next_to_clean<23> buffer_info[n

3.14 stable request for net: gso: use feature flag argument in all protocol gso handlers

2015-08-13 Thread Jay Vosburgh
For 3.14 -stable, please consider commit: commit 1e16aa3ddf863c6b9f37eddf52503230a62dedb3 Author: Florian Westphal Date: Mon Oct 20 13:49:16 2014 +0200 net: gso: use feature flag argument in all protocol gso handlers We have observed kernel panics when an openvswitch bri

[net-next PATCH] net: fix endian check warning in etherdevice.h

2015-08-13 Thread Jesse Brandeburg
Sparse builds have been warning for a really long time now that etherdevice.h has a conversion that is unsafe. include/linux/etherdevice.h:79:32: warning: restricted __be16 degrades to integer This code change fixes the issue and generates the exact same assembly before/after (checked on x86_6

[PATCH iproute2] utils: add missing return value

2015-08-13 Thread Zhang Shengju
Add missing return value to fix warnings Signed-off-by: Zhang Shengju --- include/utils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/utils.h b/include/utils.h index 95d162c..0c57ccd 100644 --- a/include/utils.h +++ b/include/utils.h @@ -137,7 +137,7 @@ const char

Re: Linux kernel commit breaks IPMI on iface downing

2015-08-13 Thread Michael Chan
+netdev and Harish who is the current maintainer of bnx2 at qlogic. The patch in question effectively just removes the bnx2_set_power_state() call during "ip link set down". If there is IPMI, the firmware should know the link needs to stay up when the driver resets the device during bnx2_close().

[PATCH/RFC] openvswitch: Retain parsed IPv6 header fields in flow on error skipping extension headers

2015-08-13 Thread Simon Horman
When an error occurs skipping IPv6 extension headers retain the already parsed IP protocol and IPv6 addresses in the flow. Also assume that the packet is not a fragment in the absence of information to the contrary; that is always use the frag_off value set by ipv6_skip_exthdr(). This allows match

Re: [PATCH net-next 1/7] net: dsa: add support for switchdev VLAN objects

2015-08-13 Thread Andrew Lunn
On Thu, Aug 13, 2015 at 05:01:57PM -0400, Vivien Didelot wrote: > Hi Andrew, > > On 15-08-13 22:16:08, Andrew Lunn wrote: > > On Thu, Aug 13, 2015 at 12:52:17PM -0400, Vivien Didelot wrote: > > > Add new functions in DSA drivers to access hardware VLAN entries through > > > SWITCHDEV_OBJ_PORT_VLAN

[PATCH] iwlwifi: out-of-bounds access in iwl_init_sband_channels

2015-08-13 Thread Adrien Schildknecht
Both loops of this function compare data from the 'chan' array and then check if the index is valid. The 2 conditions should be inverted to avoid an out-of-bounds access. Signed-off-by: Adrien Schildknecht --- drivers/net/wireless/iwlwifi/iwl-eeprom-parse.c | 4 ++-- 1 file changed, 2 insertion

Re: [PATCH RFC net 0/3] ipv6: Fix potential deadlock when creating pcpu rt

2015-08-13 Thread David Miller
From: Martin KaFai Lau Date: Thu, 13 Aug 2015 00:58:00 -0700 > This patch series fixes a potential deadlock when creating a pcpu rt. > It happens when dst_alloc() decided to run gc. Something like this: > > read_lock(&table->tb6_lock); > ip6_rt_pcpu_alloc() > => dst_alloc() > => ip6_dst_gc() > =

Re: [PATCH 1/2] average: provide macro to create static EWMA

2015-08-13 Thread David Miller
From: Johannes Berg Date: Thu, 13 Aug 2015 11:11:48 +0200 > From: Johannes Berg > > Having the EWMA parameters stored in the runtime struct imposes > memory requirements for the constant values that could just be > inlined in the code. This particularly makes sense if there are > a lot of such

Re: [PATCH] net: fix wrong skb_get() usage / crash in IGMP/MLD parsing code

2015-08-13 Thread David Miller
From: Linus Lüssing Date: Thu, 13 Aug 2015 05:54:07 +0200 > The recent refactoring of the IGMP and MLD parsing code into > ipv6_mc_check_mld() / ip_mc_check_igmp() introduced a potential crash / > BUG() invocation for bridges: > > I wrongly assumed that skb_get() could be used as a simple refere

Re: [PATCH net-next] rocker: hook ndo_neigh_destroy to cleanup neigh refs in driver

2015-08-13 Thread David Miller
From: sfel...@gmail.com Date: Wed, 12 Aug 2015 18:45:25 -0700 > From: Scott Feldman > > Rocker driver tracks arp_tbl neighs to resolve IPv4 route nexthops. The > driver uses NETEVENT_NEIGH_UPDATE for neigh adds and updates, but there is > no event when the neigh is removed from the device (such

Re: [PATCH net-next] rocker: print switch ID consistent with phys_switch_id sysfs node

2015-08-13 Thread David Miller
From: sfel...@gmail.com Date: Wed, 12 Aug 2015 18:44:13 -0700 > From: Scott Feldman > > On sucessful probe, driver prints the switch ID. This patch changes the > format of the printed ID to match what's used in sysfs phys_switch_id node. > > Signed-off-by: Scott Feldman Applied. -- To unsubs

Re: [PATCH 0/2] Enable smsc911x for use with ACPI

2015-08-13 Thread David Miller
From: Jeremy Linton Date: Wed, 12 Aug 2015 17:06:25 -0500 > This set of patches enables the front Ethernet port on the > ARM Juno development platform when used with an ACPI enabled kernel. > > These patches covert the of_property* calls in the driver to the > DT/ACPI agnostic device_property* c

Re: [PATCH net-next v2 0/2] minor tail loss probe improvements

2015-08-13 Thread David Miller
From: Yuchung Cheng Date: Wed, 12 Aug 2015 11:18:17 -0700 > This patch series enhance the tail loss probe (TLP) on some error > conditions. When TLP fails to send a probe, it will no longer > extend the RTO. When it fails to send a new packet because of > receiver window limit, it'll try to retra

Re: [net-next PATCH 0/3] Add AM335x PG1.0 CPSW errata workaround

2015-08-13 Thread David Miller
From: Mugunthan V N Date: Wed, 12 Aug 2015 15:22:52 +0530 > With commit 870915feabdc ("drivers: net: cpsw: remove > disable_irq/enable_irq as irq can be masked from cpsw itself"), > CPSW on AM335x beagle bone white is broken as there is a errata > for AM335x PG1.0. This patch series implements th

Re: kernel warning in tcp_fragment

2015-08-13 Thread Jovi Zhangwei
Hi, On Wed, Aug 12, 2015 at 8:45 PM, Martin KaFai Lau wrote: > On Mon, Aug 10, 2015 at 02:35:37PM -0400, Neal Cardwell wrote: >> On Mon, Aug 10, 2015 at 2:10 PM, Jovi Zhangwei wrote: >> > >> > Ping? >> > >> > We saw a lot of this warnings in our production system. It would be >> > great apprecia

Re: [PATCH] Revert "net: limit tcp/udp rmem/wmem to SOCK_{RCV,SND}BUF_MIN"

2015-08-13 Thread Eric Dumazet
On Thu, 2015-08-13 at 14:21 -0700, Calvin Owens wrote: > Commit 8133534c760d4083 ("net: limit tcp/udp rmem/wmem to > SOCK_{RCV,SND}BUF_MIN") modified four sysctls to enforce that the values > written to them are not less than SOCK_MIN_{RCV,SND}BUF. > ... > > This reverts commit 8133534c760d4083f7

[PATCH net] inet: fix potential deadlock in reqsk_queue_unlink()

2015-08-13 Thread Eric Dumazet
From: Eric Dumazet When replacing del_timer() with del_timer_sync(), I introduced a deadlock condition : reqsk_queue_unlink() is called from inet_csk_reqsk_queue_drop() inet_csk_reqsk_queue_drop() can be called from many contexts, one being the timer handler itself (reqsk_timer_handler()). In

Re: [PATCH net-next 5/6] geneve: Consolidate Geneve functionality in single module.

2015-08-13 Thread Pravin Shelar
On Thu, Aug 13, 2015 at 2:24 PM, Jesse Gross wrote: > On Wed, Aug 12, 2015 at 4:33 PM, Pravin Shelar wrote: >> On Wed, Aug 12, 2015 at 2:55 PM, Jesse Gross wrote: >>> The farther I go in the series, the more that I hope that we can avoid >>> the use of collect_md_tun. It really seems to add a lo

[PATCH] net/fsl: simplify Kconfig dependency list for fsl networking

2015-08-13 Thread Stuart Yoder
make the list of Kconfig dependencies for Freescale networking more general. Simplify to supported architectures: ARM, ARM64, PPC, M68K Signed-off-by: Stuart Yoder --- drivers/net/ethernet/freescale/Kconfig | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethern

Re: [PATCH net-next] net: atl1c: add BQL support

2015-08-13 Thread Francois Romieu
Ron Angeles : [...] > I only have one of these NICs and it is running on something critical > throughout the weekdays. I can try running these when I have time on a > weekend. Thanks, it would be perfect: I can't promise it won't crash. > Is there any particular way you would suggest testing? Wo

Re: [PATCH net] inet: fix races with reqsk timers

2015-08-13 Thread Eric Dumazet
On Fri, 2015-08-14 at 00:13 +0300, Nikolay Aleksandrov wrote: > > On Aug 13, 2015, at 11:44 PM, Eric Dumazet wrote: > > > > On Thu, 2015-08-13 at 13:19 -0700, Eric Dumazet wrote: > > > >> > >> A caller handler can not call del_timer_sync() > > > > A timer handler can not call del_timer_sync()

Re: [PATCH net-next 5/6] geneve: Consolidate Geneve functionality in single module.

2015-08-13 Thread Jesse Gross
On Wed, Aug 12, 2015 at 4:33 PM, Pravin Shelar wrote: > On Wed, Aug 12, 2015 at 2:55 PM, Jesse Gross wrote: >> The farther I go in the series, the more that I hope that we can avoid >> the use of collect_md_tun. It really seems to add a lot of special >> cases. > > Use of collect_md_tun allows us

[PATCH] Revert "net: limit tcp/udp rmem/wmem to SOCK_{RCV,SND}BUF_MIN"

2015-08-13 Thread Calvin Owens
Commit 8133534c760d4083 ("net: limit tcp/udp rmem/wmem to SOCK_{RCV,SND}BUF_MIN") modified four sysctls to enforce that the values written to them are not less than SOCK_MIN_{RCV,SND}BUF. That change causes 4096 to no longer be accepted as a valid value for 'min' in tcp_wmem and udp_wmem_min. 4096

Re: [PATCH net-next 3/6] geneve: Add support to collect tunnel metadata.

2015-08-13 Thread Jesse Gross
On Wed, Aug 12, 2015 at 4:08 PM, Pravin Shelar wrote: > On Wed, Aug 12, 2015 at 1:53 PM, Jesse Gross wrote: >> On Tue, Aug 11, 2015 at 10:17 PM, Pravin B Shelar wrote: >>> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c >>> index 5e9bab8..a463383 100644 >>> --- a/drivers/net/geneve.c >>

Re: [PATCH net] inet: fix races with reqsk timers

2015-08-13 Thread Nikolay Aleksandrov
> On Aug 13, 2015, at 11:44 PM, Eric Dumazet wrote: > > On Thu, 2015-08-13 at 13:19 -0700, Eric Dumazet wrote: > >> >> A caller handler can not call del_timer_sync() > > A timer handler can not call del_timer_sync() > > I am testing a minimal fix : > > diff --git a/net/ipv4/inet_connection_

RE: [PATCH v2 4/4] Added getsynctime64() callback

2015-08-13 Thread Hall, Christopher S
> -Original Message- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Monday, August 10, 2015 1:50 AM > To: Hall, Christopher S > Cc: john.stu...@linaro.org; t...@linutronix.de; mi...@redhat.com; Kirsher, > Jeffrey T; Ronciak, John; h...@zytor.com; x...@kernel.org; linux-

Re: [PATCH] net: Use SK_MEM_QUANTUM as minimum for tcp/udp rmem/wmem

2015-08-13 Thread Calvin Owens
On Wednesday 08/12 at 10:46 -0700, Eric Dumazet wrote: > On Wed, 2015-08-12 at 20:00 +0300, Sorin Dumitru wrote: > > > Would clamping the values to a min value, like setsockopt(SO_SNDBUF) > > does, be an option? > > I still find it odd that SO_SNDBUF limits you, while the /proc > > interface doesn

Re: [PATCH 6/6] MIPS: net: BPF: Introduce BPF ASM helpers

2015-08-13 Thread Aurelien Jarno
On 2015-06-04 11:56, Markos Chandras wrote: > This commit introduces BPF ASM helpers for MIPS and MIPS64 kernels. > The purpose of this patch is to twofold: > > 1) We are now able to handle negative offsets instead of either > falling back to the interpreter or to simply not do anything and > bail

Re: [PATCH net-next 1/7] net: dsa: add support for switchdev VLAN objects

2015-08-13 Thread Vivien Didelot
Hi Andrew, On 15-08-13 22:16:08, Andrew Lunn wrote: > On Thu, Aug 13, 2015 at 12:52:17PM -0400, Vivien Didelot wrote: > > Add new functions in DSA drivers to access hardware VLAN entries through > > SWITCHDEV_OBJ_PORT_VLAN objects: > > > > - port_pvid_get() and vlan_getnext() to dump a VLAN > >

[PATCH net-next 08/11] net: Use passed in table for nexthop lookups

2015-08-13 Thread David Ahern
If a user passes in a table for new routes use that table for nexthop lookups. Specifically, this solves the case where a connected route does not exist in the main table, but only another table and then a subsequent route is added with a next hop using the connected route. ie., $ ip route ls defa

[PATCH net-next 01/11] net: Introduce VRF related flags and helpers

2015-08-13 Thread David Ahern
Add a VRF_MASTER flag for interfaces and helper functions for determining if a device is a VRF_MASTER. Add link attribute for passing VRF_TABLE id. Add vrf_ptr to netdevice. Add various macros for determining if a device is a VRF device, the index of the master VRF device and table associated wi

[PATCH net-next 11/11] net: Introduce VRF device driver

2015-08-13 Thread David Ahern
This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a VRF master device with an associated table and enslaving all routed interfaces that participate in the domain. As part of the enslavement, all connected routes for the enslaved de

[PATCH net-next 06/11] net: Fix up inet_addr_type checks

2015-08-13 Thread David Ahern
Currently inet_addr_type and inet_dev_addr_type expect local addresses to be in the local table. With the VRF device local routes for devices associated with a VRF will be in the table associated with the VRF. Provide an alternate inet_addr lookup to use a specific table rather than defaulting to t

[PATCH net-next 07/11] net: Add routes to the table associated with the device

2015-08-13 Thread David Ahern
When a device associated with a VRF is brought up or down routes should be added to/removed from the table associated with the VRF. fib_magic defaults to using the main or local tables. Have it use the table with the device if there is one. A part of this is directing prefsrc validations to the co

[PATCH net-next 05/11] net: Add inet_addr lookup by table

2015-08-13 Thread David Ahern
Currently inet_addr_type and inet_dev_addr_type expect local addresses to be in the local table. With the VRF device local routes for devices associated with a VRF will be in the table associated with the VRF. Provide an alternate inet_addr lookup to use a specific table rather than defaulting to t

[PATCH net-next 04/11] udp: Handle VRF device in sendmsg

2015-08-13 Thread David Ahern
For unconnected UDP sockets using a VRF device lookup source address based on VRF table. This allows the UDP header to be properly setup before showing up at the VRF device via the dst. Signed-off-by: Shrijeet Mukherjee Signed-off-by: David Ahern --- net/ipv4/udp.c | 22 +-

[PATCH net-next 02/11] net: Use VRF device index for lookups on RX

2015-08-13 Thread David Ahern
On ingress use index of VRF master device for route lookups if real device is enslaved. Rules are expected to be installed for the VRF device to direct lookups to a specific table. Signed-off-by: Shrijeet Mukherjee Signed-off-by: David Ahern --- net/ipv4/fib_frontend.c | 8 +++- net/ipv4/ro

[PATCH net-next 00/10] VRF-lite - v6

2015-08-13 Thread David Ahern
In the context of internet scale routing a requirement that always comes up is the need to partition the available routing tables into disjoint routing planes. A specific use case is the multi-tenancy problem where each tenant has their own unique routing tables and in the very least need different

[PATCH net-next 03/11] net: Use VRF device index for lookups on TX

2015-08-13 Thread David Ahern
As with ingress use the index of VRF master device for route lookups on egress. However, the oif should only be used to direct the lookups to a specific table. Routes in the table are not based on the VRF device but rather interfaces that are part of the VRF so do not consider the oif for lookups w

[PATCH net-next 09/11] net: Use VRF index for oif in ip_send_unicast_reply

2015-08-13 Thread David Ahern
If output device is not specified use VRF device if input device is enslaved. This is needed to ensure tcp acks and resets go out VRF device. Signed-off-by: David Ahern --- net/ipv4/ip_output.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/net/ipv4/ip_output.c b/net/i

[PATCH net-next] iproute2: Add support for VRF device

2015-08-13 Thread David Ahern
Allow user to create a vrf device and specify its table binding. Based on the iplink_vlan implementation. Signed-off-by: Shrijeet Mukherjee Signed-off-by: David Ahern --- include/linux/if_link.h | 8 + ip/Makefile | 2 +- ip/iplink.c | 2 +- ip/iplink_vrf.c

[PATCH net-next 10/11] net: frags: Add VRF device index to cache and lookup

2015-08-13 Thread David Ahern
Fragmentation cache uses information from the IP header to reassemble packets. That information can be duplicated across VRFs -- same source and destination addresses, protocol and id. Handle fragmentation with VRFs by adding the VRF device index to entries in the cache and the lookup arg. Signed-

Re: [PATCH net] inet: fix races with reqsk timers

2015-08-13 Thread Eric Dumazet
On Thu, 2015-08-13 at 13:19 -0700, Eric Dumazet wrote: > > A caller handler can not call del_timer_sync() A timer handler can not call del_timer_sync() I am testing a minimal fix : diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c index 05e3145f7dc3..134957159c27 1

Re: [patch -next] bpf: off by one in check_map_func_compatibility()

2015-08-13 Thread Daniel Borkmann
On 08/13/2015 10:27 PM, Dan Carpenter wrote: The loop iterates one space too far, so we might read beyond the end of the func_limit[] array. Fixes: 35578d798400 ('bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter') Signed-off-by: Dan Carpenter Thanks fo

Re: [PATCH net-next 1/7] net: dsa: add support for switchdev VLAN objects

2015-08-13 Thread Andrew Lunn
On Thu, Aug 13, 2015 at 12:52:17PM -0400, Vivien Didelot wrote: > Add new functions in DSA drivers to access hardware VLAN entries through > SWITCHDEV_OBJ_PORT_VLAN objects: > > - port_pvid_get() and vlan_getnext() to dump a VLAN > - port_vlan_del() to exclude a port from a VLAN > - port_pvid_s

[patch -next] bpf: off by one in check_map_func_compatibility()

2015-08-13 Thread Dan Carpenter
The loop iterates one space too far, so we might read beyond the end of the func_limit[] array. Fixes: 35578d798400 ('bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter') Signed-off-by: Dan Carpenter diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.

Re: [PATCH net] inet: fix races with reqsk timers

2015-08-13 Thread Eric Dumazet
On Mon, 2015-08-10 at 21:18 -0700, David Miller wrote: > From: Eric Dumazet > Date: Mon, 10 Aug 2015 09:09:13 -0700 > > > From: Eric Dumazet > > > > reqsk_queue_destroy() and reqsk_queue_unlink() should use > > del_timer_sync() instead of del_timer() before calling reqsk_put(), > > otherwise we

[PATCH 1/1 V2] ipv4: off-by-one in continuation handling in /proc/net/route

2015-08-13 Thread Andy Whitcroft
When generating /proc/net/route we emit a header followed by a line for each route. When a short read is performed we will restart this process based on the open file descriptor. When calculating the start point we fail to take into account that the 0th entry is the header. This leads us to skip

[PATCH net-next] net: addr IFLA_OPERSTATE to netlink message for ipv6 ifinfo

2015-08-13 Thread Andy Gospodarek
This is useful information to include in ipv6 netlink messages that report interface information. IFLA_OPERSTATE is already included in ipv4 messages, but missing for ipv6. This closes that gap. Signed-off-by: Andy Gospodarek --- net/ipv6/addrconf.c | 5 - 1 file changed, 4 insertions(+),

Re: [PATCH] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-13 Thread Igor Plyatov
Dear David and Joe, thank you for patch review! Please look at email with subject "[PATCH v2] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging" Best wishes. -- Igor Plyatov From: Joe Perches Date: Thu, 13 Aug 2015 10:15:15 -0700 On Thu, 2015-08-13 at 20:11 +

[PATCH v2] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-13 Thread Igor Plyatov
* Due to HW bug, LAN8700 sometimes does not detect presence of energy in the Ethernet cable in Energy Detect Power-Down mode (e.g while EDPWRDOWN bit is set, the ENERGYON bit does not asserted sometimes). This is a common bug of LAN87xx family of PHY chips. * The lan87xx_read_status() was imp

Re: [PATCH 0/2] net: introduce IFF_NO_QUEUE as successor of zero tx_queue_len

2015-08-13 Thread Stephen Hemminger
On Thu, 13 Aug 2015 20:40:37 +0200 Jesper Dangaard Brouer wrote: > On Thu, 13 Aug 2015 10:49:50 -0700 > Stephen Hemminger wrote: > > > On Thu, 13 Aug 2015 19:01:05 +0200 > > Phil Sutter wrote: > > > > > Up to now, drivers being aware of the above applying to them set > > > dev->tx_queue_len t

Re: [PATCH] net: allow sleeping when modifying store_rps_map

2015-08-13 Thread Tom Herbert
On Thu, Aug 13, 2015 at 11:03 AM, Sasha Levin wrote: > Commit 10e4ea751 ("net: Fix race condition in store_rps_map") has moved the > manipulation of the rps_needed jump label under a spinlock. Since changing > the state of a jump label may sleep this is incorrect and causes warnings > during runti

Re: [PATCH 0/2] net: introduce IFF_NO_QUEUE as successor of zero tx_queue_len

2015-08-13 Thread Jesper Dangaard Brouer
On Thu, 13 Aug 2015 10:49:50 -0700 Stephen Hemminger wrote: > On Thu, 13 Aug 2015 19:01:05 +0200 > Phil Sutter wrote: > > > Up to now, drivers being aware of the above applying to them set > > dev->tx_queue_len to zero to indicate no qdisc should be attached to the > > interface they drive and

Re: [PATCH] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-13 Thread David Miller
From: Joe Perches Date: Thu, 13 Aug 2015 10:15:15 -0700 > On Thu, 2015-08-13 at 20:11 +0300, Igor Plyatov wrote: >> > On Thu, 2015-08-13 at 16:12 +0300, Igor Plyatov wrote: >> >> * Due to HW bug, LAN8700 sometimes does not detect presence of energy in >> >> the >> >>Ethernet cable in Energy

[PATCH 4/6] ethernet/netxen: advertise LRO support in vlan_features

2015-08-13 Thread Jarod Wilson
Without this, the presence of a netxen device in a bond will not trigger LRO support to be enabled at the bond level, even while it is enabled on the slave itself. This change becomes necessary when NETIF_F_LRO is added to netdev_features.h's NETIF_F_ONE_FOR_ALL. CC: Manish Chopra CC: Sony Chack

[PATCH 3/6] ethernet/ixgbe: advertise LRO support in vlan_features

2015-08-13 Thread Jarod Wilson
Without this, the presence of a ixgbe device in a bond will not trigger LRO support to be enabled at the bond level, even while it is enabled on the slave itself. This change becomes necessary when NETIF_F_LRO is added to netdev_features.h's NETIF_F_ONE_FOR_ALL. CC: Jeff Kirsher CC: intel-wired-

Re: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-13 Thread Thadeu Lima de Souza Cascardo
On Thu, Aug 13, 2015 at 07:01:37PM +0200, Andrew Lunn wrote: > On Thu, Aug 13, 2015 at 04:52:32PM +, Philip Downey wrote: > > Hi Andrew > > IGMP snooping is designed to prevent hosts on a local network from > > receiving traffic for a multicast group they have not explicitly joined. > > Lin

[PATCH 1/6] net/bonding: enable LRO if one device supports it

2015-08-13 Thread Jarod Wilson
Currently, all bonding devices come up, and claim to have LRO support, which ethtool will let you toggle on and off, even if none of the underlying hardware devices actually support it. While the bonding driver takes precautions for slaves that don't support all features, this is at least a little

Re: [PATCH net-next v2 1/2] tcp: don't extend RTO on failed loss probe attempts

2015-08-13 Thread Eric Dumazet
On Wed, 2015-08-12 at 11:18 -0700, Yuchung Cheng wrote: > If TLP was unable to send a probe, it extended the RTO to > now + icsk_rto. But extending the RTO makes little sense > if no TLP probe went out. With this commit, instead of > extending the RTO we re-arm it relative to the transmit time > of

[PATCH 0/6] bonding: only advertise LRO if underlying hardware can LRO

2015-08-13 Thread Jarod Wilson
At present, you can create a bond, containing only underlying slaves that do not support LRO, and the bond will happily claim to support LRO, and allow LRO to be toggled on and off by ethtool. While things actually do function fine in the scenario, and this is merely cosmetic, its a bit misleading

[PATCH] net: allow sleeping when modifying store_rps_map

2015-08-13 Thread Sasha Levin
Commit 10e4ea751 ("net: Fix race condition in store_rps_map") has moved the manipulation of the rps_needed jump label under a spinlock. Since changing the state of a jump label may sleep this is incorrect and causes warnings during runtime. Make rps_map_lock a mutex to allow sleeping under it. Fi

[PATCH 6/6] ethernet/s2io: advertise what hw supports in vlan_features

2015-08-13 Thread Jarod Wilson
For some reason, the s2io driver has never filled in vlan_features. If that's fully intentional, then this patch should be dropped. If its not, then this patch is necessary to maintain some functionality of slave s2io devices in a bonding group. Without this, the presence of a s2io device in a bon

[PATCH 5/6] ethernet/qlcnic: advertise LRO support in vlan_features

2015-08-13 Thread Jarod Wilson
Without this, the presence of a qlcnic device in a bond will not trigger LRO support to be enabled at the bond level, even while it is enabled on the slave itself. This change becomes necessary when NETIF_F_LRO is added to netdev_features.h's NETIF_F_ONE_FOR_ALL. CC: Shahed Shaikh CC: dept-gelin

[PATCH 2/6] ethernet/bnx2x: advertise LRO support in vlan_features

2015-08-13 Thread Jarod Wilson
Without this, the presence of a bnx2x device in a bond will not trigger LRO support to be enabled at the bond level, even while it is enabled on the slave itself. This change becomes necessary when NETIF_F_LRO is added to netdev_features.h's NETIF_F_ONE_FOR_ALL. CC: Ariel Elior CC: netdev@vger.k

Re: [PATCH 0/2] net: introduce IFF_NO_QUEUE as successor of zero tx_queue_len

2015-08-13 Thread Stephen Hemminger
On Thu, 13 Aug 2015 19:01:05 +0200 Phil Sutter wrote: > Up to now, drivers being aware of the above applying to them set > dev->tx_queue_len to zero to indicate no qdisc should be attached to the > interface they drive and the kernel reacts upon this by assigning the noop > qdisc instead of the d

Re: [PATCH] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-13 Thread Joe Perches
On Thu, 2015-08-13 at 20:11 +0300, Igor Plyatov wrote: > > On Thu, 2015-08-13 at 16:12 +0300, Igor Plyatov wrote: > >> * Due to HW bug, LAN8700 sometimes does not detect presence of energy in > >> the > >>Ethernet cable in Energy Detect Power-Down mode (e.g while EDPWRDOWN > >> bit is > >>

Re: [PATCHv3 net-next 06/10] openvswitch: Allow matching on conntrack mark

2015-08-13 Thread Pravin Shelar
On Wed, Aug 12, 2015 at 4:41 PM, Joe Stringer wrote: > On 12 August 2015 at 16:00, Pravin Shelar wrote: >> On Tue, Aug 11, 2015 at 3:59 PM, Joe Stringer wrote: >>> From: Justin Pettit >>> >>> Allow matching and setting the conntrack mark field. As with conntrack >>> state and zone, these are po

Re: [PATCH] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-13 Thread Igor Plyatov
Dear Joe, On Thu, 2015-08-13 at 16:12 +0300, Igor Plyatov wrote: * Due to HW bug, LAN8700 sometimes does not detect presence of energy in the Ethernet cable in Energy Detect Power-Down mode (e.g while EDPWRDOWN bit is set, the ENERGYON bit does not asserted sometimes). This is a common bu

Re: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-13 Thread Andrew Lunn
On Thu, Aug 13, 2015 at 04:52:32PM +, Philip Downey wrote: > Hi Andrew > IGMP snooping is designed to prevent hosts on a local network from receiving > traffic for a multicast group they have not explicitly joined. Link-Local > multicast traffic should not have an IGMP client since it is re

[PATCH 1/2] net: declare new net_device priv_flag IFF_NO_QUEUE

2015-08-13 Thread Phil Sutter
This private net_device flag can be set by drivers to inform that a device runs fine without a qdisc attached. This was formerly done by setting tx_queue_len to zero. Signed-off-by: Phil Sutter --- include/linux/netdevice.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/net

[PATCH 2/2] net: sch_generic: react upon IFF_NO_QUEUE flag

2015-08-13 Thread Phil Sutter
Handle IFF_NO_QUEUE as alternative to tx_queue_len being zero. Signed-off-by: Phil Sutter --- net/sched/sch_generic.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c index 6efca30..942fea8 100644 --- a/net/sched/sch_gene

  1   2   >