From: Eric Dumazet <eric.duma...@gmail.com>
Date: Thu, 13 Aug 2015 15:44:51 -0700
> From: Eric Dumazet <eduma...@google.com>
>
> When replacing del_timer() with del_timer_sync(), I introduced
> a deadlock condition :
>
> reqsk_queue_unlink() is called from inet_csk_reqsk_queue_drop()
>
> inet_csk_reqsk_queue_drop() can be called from many contexts,
> one being the timer handler itself (reqsk_timer_handler()).
>
> In this case, del_timer_sync() loops forever.
>
> Simple fix is to test if timer is pending.
>
> Fixes: 2235f2ac75fd ("inet: fix races with reqsk timers")
> Signed-off-by: Eric Dumazet <eduma...@google.com>
Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
