Re: Problem with patch "make nlmsg_end() and genlmsg_end() void"

2015-06-17 Thread David Woodhouse
On Thu, 2015-06-11 at 23:03 +0100, David Woodhouse wrote: > On Thu, 2015-06-11 at 01:31 +0100, David Woodhouse wrote: > > On Tue, 2015-06-09 at 17:49 -0700, Eric Dumazet wrote: > > > > I've added some debugging, and it seems that when it deadlocks, > > > > glibc > > > > doesn't get *any* response

[RFC] COLO Proxy Module

2015-06-17 Thread Li Zhijian
Hi, all We are planning to implement a kernel module called COLO Proxy to buffer and compare packets. This module is one of the important component of COLO project and now it is still in early stage, so any comments and feedback are warmly welcomed, thanks in advance. = # RFC: COLO-Proxy Mod

RE: [Intel-wired-lan] [PATCH v6 1/3] if_link: Add control trust VF

2015-06-17 Thread Hiroshi Shimamoto
> Subject: Re: [Intel-wired-lan] [PATCH v6 1/3] if_link: Add control trust VF > > On 06/17/2015 04:41 AM, Hiroshi Shimamoto wrote: > > From: Hiroshi Shimamoto > > > > Add netlink directives and ndo entry to trust VF user. > > > > This controls the special permission of VF user. > > The administra

pull-request: wireless-drivers-next 2015-06-18

2015-06-17 Thread Kalle Valo
Hi Dave, here's one more pull request I would like to get to 4.2 if possible. Nothing major this time, just small stuff all over. Please let me know if you have any problems. Kalle The following changes since commit c39c4c6abb89d24454b63798ccbae12b538206a5: tcp: double default TSQ output byte

Re: [PATCH net-next] switchdev: fdb filter_dev is always NULL for self (device), so remove check

2015-06-17 Thread Samudrala, Sridhar
On 6/17/2015 4:08 PM, sfel...@gmail.com wrote: From: Scott Feldman Remove the filter_dev check when dumping fdb entries, otherwise dump returns empty list. filter_dev is always passed as NULL when dumping fdbs on SELF. We want the fdbs installed on the device to be listed in the dump. Sign

Re: [PATCH net 2/2] bridge: multicast: start querier timer when running user-space stp

2015-06-17 Thread Herbert Xu
On Wed, Jun 17, 2015 at 04:28:31AM -0700, Nikolay Aleksandrov wrote: > From: Satish Ashok > > When STP is running in user-space and querier is configured, the > querier timer is not started when a port goes to forwarding state. > > Signed-off-by: Satish Ashok > Signed-off-by: Nikolay Aleksandro

Re: [PATCH net 1/2] bridge: multicast: restore router configuration on port link down/up

2015-06-17 Thread Herbert Xu
On Wed, Jun 17, 2015 at 04:28:30AM -0700, Nikolay Aleksandrov wrote: > From: Satish Ashok > > When a port goes through a link down/up the multicast router configuration > is not restored. > > Signed-off-by: Satish Ashok > Signed-off-by: Nikolay Aleksandrov > Fixes: 0909e11758bd ("bridge: Add m

[PATCH] fm10k: Report MAC address on driver load

2015-06-17 Thread Alexander Duyck
This change adds the MAC address to the list of values recorded on driver load. The MAC address represents the serial number of the unit and allows us to track the value should a card be replaced in a system. Signed-off-by: Alexander Duyck --- drivers/net/ethernet/intel/fm10k/fm10k_pci.c |4

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-17 Thread Steven Rostedt
On Fri, 12 Jun 2015 11:50:38 -0400 Steven Rostedt wrote: > I reverted the following commits: > > c627d31ba0696cbd829437af2be2f2dee3546b1e > 9e2b9f37760e129cee053cc7b6e7288acc2a7134 > caf4ccd4e88cf2795c927834bc488c8321437586 > > And the issue goes away. That is, I watched the port go from > ESTA

Re: [PATCH] tipc:Make the function tipc_buf_append have a return type of bool

2015-06-17 Thread Ying Xue
On 06/18/2015 10:44 AM, Nicholas Krause wrote: > This converts the function tipc_buf_append now due to this > particular function only returning either one or zero as > its return value. > > Signed-off-by: Nicholas Krause Acked-by: Ying Xue > --- > net/tipc/msg.c | 12 ++-- > net/tipc

Re: [PATCH 19/22] fjes: update_zone_task

2015-06-17 Thread Joe Perches
On Thu, 2015-06-18 at 09:49 +0900, Taku Izumi wrote: > This patch adds update_zone_task. > diff --git a/drivers/platform/x86/fjes/fjes_hw.c > b/drivers/platform/x86/fjes/fjes_hw.c [] > +static void fjes_hw_update_zone_task(struct work_struct *work) > +{ Some of the line length can be removed her

Re: [PATCH 02/22] fjes: Hardware initialization routine

2015-06-17 Thread Joe Perches
On Thu, 2015-06-18 at 09:49 +0900, Taku Izumi wrote: > This patch adds hardware initialization routine to be > invoked at driver's .probe routine. Trivial notes: Please run all your patches through scripts/checkpatch.pl and fix whatever messages it emits as you think appropriate. > diff --git a/

Re: [PATCH 01/22] fjes: Introduce FUJITSU Extended Socket Network Device driver

2015-06-17 Thread Joe Perches
On Thu, 2015-06-18 at 09:49 +0900, Taku Izumi wrote: > This patch adds the basic code of FUJITSU Extended Socket > Network Device driver. [] > diff --git a/drivers/platform/x86/fjes/fjes_main.c > b/drivers/platform/x86/fjes/fjes_main.c [] > +static acpi_status fjes_get_acpi_resource(struct acpi_re

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-17 Thread Andrew Lunn
On Wed, Jun 17, 2015 at 02:09:52PM -0400, Vivien Didelot wrote: > Hi Andrew, All, > > On 12/06/15 10:18, Andrew Lunn wrote: > > By default, DSA and CPU ports are configured to the maximum speed the > > switch supports. However there can be use cases where the peer device > > port is slower. Allow

Re: [PATCH 22/22] fjes: ethtool support

2015-06-17 Thread Stephen Hemminger
On Thu, 18 Jun 2015 09:49:47 +0900 Taku Izumi wrote: > +static void fjes_get_ethtool_stats(struct net_device *netdev, > + struct ethtool_stats *stats, u64 *data) > +{ > + struct fjes_adapter *adapter = netdev_priv(netdev); > + int i; > + char *p = NULL; Although harmless,

[PATCH next v2] bonding: Display LACP info only to CAP_NET_ADMIN capable user

2015-06-17 Thread Mahesh Bandewar
Actor and Partner details can be accessed via proc-fs, sys-fs entries or netlink interface. These interfaces are world readable at this moment. The earlier patch-series made the LACP communication secure to avoid nuisance attack from within the same L2 domain but it did not prevent "someone unprivi

[PATCH 05/22] fjes: ES information acquisition routine

2015-06-17 Thread Taku Izumi
This patch adds ES information acquisition routine. ES information can be retrieved issuing information request command. ES information includes which receiver is same zone. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_hw.c | 101 ++ drivers/plat

[PATCH 17/22] fjes: force_close_task

2015-06-17 Thread Taku Izumi
This patch adds force_close_task. This task is used to close network device forcibly. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes.h | 1 + drivers/platform/x86/fjes/fjes_main.c | 13 + 2 files changed, 14 insertions(+) diff --git a/drivers/platform/x86/fjes/fj

[PATCH 06/22] fjes: buffer address regist/unregistration routine

2015-06-17 Thread Taku Izumi
This patch adds buffer address regist/unregistration routine. This function is mainly invoked when network device's activation (open) and deactivation (close) in order to retist/unregist shared buffer address. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_hw.c | 189 +

[PATCH 11/22] fjes: NAPI polling function

2015-06-17 Thread Taku Izumi
This patch adds NAPI polling function and receive related work. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_hw.c | 46 + drivers/platform/x86/fjes/fjes_hw.h | 6 ++ drivers/platform/x86/fjes/fjes_main.c | 179 ++ 3 files changed, 23

[PATCH 16/22] fjes: interrupt_watch_task

2015-06-17 Thread Taku Izumi
This patch adds interrupt_watch_task. This task is used to prevent delay of interrupts. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes.h | 5 + drivers/platform/x86/fjes/fjes_main.c | 40 ++- 2 files changed, 44 insertions(+), 1 deletion(-)

[PATCH 09/22] fjes: raise_intr_rxdata_task

2015-06-17 Thread Taku Izumi
This patch add raise_intr_rxdata_task. Extended Socket Network Device is shared memory based, so someone's transmission denotes other's reception. In order to notify receivers, sender has to raise interruption of receivers. raise_intr_rxdata_task does this work. Signed-off-by: Taku Izumi --- dr

[PATCH 20/22] fjes: epstop_task

2015-06-17 Thread Taku Izumi
This patch adds epstop_task. This task is used to process other receiver's cancellation request. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_hw.c | 34 ++ drivers/platform/x86/fjes/fjes_hw.h | 1 + drivers/platform/x86/fjes/fjes_main.c | 1 +

[PATCH 15/22] fjes: net_device_ops.ndo_vlan_rx_add/kill_vid

2015-06-17 Thread Taku Izumi
This patch adds net_device_ops.ndo_vlan_rx_add_vid and net_device_ops.ndo_vlan_rx_kill_vid callback. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_hw.c | 27 +++ drivers/platform/x86/fjes/fjes_hw.h | 2 ++ drivers/platform/x86/fjes/fjes_main.c | 40 +++

[PATCH 22/22] fjes: ethtool support

2015-06-17 Thread Taku Izumi
This patch adds implementation for ethtool support. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/Makefile | 2 +- drivers/platform/x86/fjes/fjes.h | 2 + drivers/platform/x86/fjes/fjes_ethtool.c | 135 +++ drivers/platform/x86/fjes/fjes_ma

[PATCH 19/22] fjes: update_zone_task

2015-06-17 Thread Taku Izumi
This patch adds update_zone_task. Zoning information can be changed by user. This task is used to monitor if zoning information is changed or not. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_hw.c | 183 ++ drivers/platform/x86/fjes/fjes_hw.h

[PATCH 18/22] fjes: unshare_watch_task

2015-06-17 Thread Taku Izumi
This patch adds unshare_watch_task. Shared buffer's status can be changed into unshared. This task is used to monitor shared buffer's status. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes.h | 3 + drivers/platform/x86/fjes/fjes_main.c | 152

[PATCH 21/22] fjes: handle receive cancellation request interrupt

2015-06-17 Thread Taku Izumi
This patch adds implementation of handling IRQ of other receiver's receive cancellation request. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_main.c | 85 +++ 1 file changed, 85 insertions(+) diff --git a/drivers/platform/x86/fjes/fjes_main.c b/d

[PATCH 14/22] fjes: net_device_ops.ndo_tx_timeout

2015-06-17 Thread Taku Izumi
This patch adds net_device_ops.ndo_tx_timeout callback. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_main.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/platform/x86/fjes/fjes_main.c b/drivers/platform/x86/fjes/fjes_main.c index 72541a7..84727d8 100644 --

[PATCH 02/22] fjes: Hardware initialization routine

2015-06-17 Thread Taku Izumi
This patch adds hardware initialization routine to be invoked at driver's .probe routine. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/Makefile| 2 +- drivers/platform/x86/fjes/fjes_hw.c | 305 ++ drivers/platform/x86/fjes/fjes_hw.h | 254

[PATCH 12/22] fjes: net_device_ops.ndo_get_stats64

2015-06-17 Thread Taku Izumi
This patch adds net_device_ops.ndo_get_stats64 callback. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_main.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/platform/x86/fjes/fjes_main.c b/drivers/platform/x86/fjes/fjes_main.c index 97bf487..eeda824 1

[PATCH 10/22] fjes: tx_stall_task

2015-06-17 Thread Taku Izumi
This patch adds tx_stall_task. When receiver's buffer is full, sender stops its tx queue. This task is used to monitor receiver's status and when receiver's buffer is avairable, it resumes tx queue. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes.h | 2 ++ drivers/platform/x86

[PATCH 13/22] fjes: net_device_ops.ndo_change_mtu

2015-06-17 Thread Taku Izumi
This patch adds net_device_ops.ndo_change_mtu. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_main.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/platform/x86/fjes/fjes_main.c b/drivers/platform/x86/fjes/fjes_main.c index eeda824..725

[PATCH 08/22] fjes: net_device_ops.ndo_start_xmit

2015-06-17 Thread Taku Izumi
This patch adds net_device_ops.ndo_start_xmit callback, which is called when sending packets. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes.h | 1 + drivers/platform/x86/fjes/fjes_hw.c | 58 +++ drivers/platform/x86/fjes/fjes_hw.h | 12 +++ drivers/platform/x8

[PATCH 07/22] fjes: net_device_ops.ndo_open and .ndo_stop

2015-06-17 Thread Taku Izumi
This patch adds net_device_ops.ndo_open and .ndo_stop callback. These function is called when network device activation and deactivation. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes.h | 2 +- drivers/platform/x86/fjes/fjes_hw.c | 150 drivers/platfo

[PATCH 04/22] fjes: platform_driver's .probe and .remove routine

2015-06-17 Thread Taku Izumi
This patch implements platform_driver's .probe and .remove routine, and also adds board specific private data structure. This driver registers net_device at platform_driver's .probe routine and unregisters net_device at its .remove routine. Signed-off-by: Taku Izumi --- drivers/platform/x86/fje

[PATCH 03/22] fjes: Hardware cleanup routine

2015-06-17 Thread Taku Izumi
This patch adds hardware cleanup routine to be invoked at driver's .remove routine. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_hw.c | 66 + drivers/platform/x86/fjes/fjes_hw.h | 1 + 2 files changed, 67 insertions(+) diff --git a/drivers/pl

[PATCH 01/22] fjes: Introduce FUJITSU Extended Socket Network Device driver

2015-06-17 Thread Taku Izumi
This patch adds the basic code of FUJITSU Extended Socket Network Device driver. When "PNP0C02" is found in ACPI DSDT, it evaluates "_STR" to check if "PNP0C02" is for Extended Socket device driver and retrieves ACPI resource information. Then creates platform_device. Signed-off-by: Taku Izumi -

[PATCH 00/22] FUJITSU Extended Socket network device driver

2015-06-17 Thread Taku Izumi
This patchsets adds FUJITSU Extended Socket network device driver. Extended Socket network device is a shared memory based high-speed network interface between Extended Partitions of PRIMEQUEST 2000 E2 series. You can get some information about Extended Partition and Extended Socket by referring

[PATCH net] Revert "tcp: switch tcp_fastopen key generation to net_get_random_once"

2015-06-17 Thread Christoph Paasch
This reverts commit 222e83d2e0aecb6a5e8d42b1a8d51332a1eba960. tcp_fastopen_reset_cipher really cannot be called from interrupt context. It allocates the tcp_fastopen_context with GFP_KERNEL and calls crypto_alloc_cipher, which allocates all kind of stuff with GFP_KERNEL. Thus, we might sleep when

[PATCH net-next] switchdev: fdb filter_dev is always NULL for self (device), so remove check

2015-06-17 Thread sfeldma
From: Scott Feldman Remove the filter_dev check when dumping fdb entries, otherwise dump returns empty list. filter_dev is always passed as NULL when dumping fdbs on SELF. We want the fdbs installed on the device to be listed in the dump. Signed-off-by: Scott Feldman Fixes: 45d4122c ("switchd

Re: [RFC V3] net: don't wait for order-3 page allocation

2015-06-17 Thread David Rientjes
On Fri, 12 Jun 2015, Vlastimil Babka wrote: > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > > index 3cfff2a..41ec022 100644 > > --- a/net/core/skbuff.c > > +++ b/net/core/skbuff.c > > @@ -4398,7 +4398,7 @@ struct sk_buff *alloc_skb_with_frags(unsigned long > > header_len, > > > >

Re: [PATCH net-next] switchdev: change BUG_ON to WARN for attr set failure case

2015-06-17 Thread Scott Feldman
On Thu, Jun 11, 2015 at 4:27 PM, David Miller wrote: > From: sfel...@gmail.com > Date: Thu, 11 Jun 2015 11:20:42 -0700 > >> From: Scott Feldman >> >> This particular BUG_ON condition was checking for attr set err in the >> COMMIT phase, which isn't expected (it's a driver bug if PREPARE phase is

Re: [PATCH net-next 00/15] Simplify netfilter and network namespaces

2015-06-17 Thread Julian Anastasov
Hello, On Wed, 17 Jun 2015, Eric W. Biederman wrote: > p.s. I do have my patch that I can toss in your direction if you are > interested. Of course... I'll be able to check it after 8 hours... Regards -- Julian Anastasov -- To unsubscribe from this list: send the line "unsub

[PATCH 3/4] net: stmmac: dwmac-rk: abstract access to mac settings in GRF

2015-06-17 Thread Heiko Stuebner
The mac settings like RGMII/RMII, speeds etc are done in the so called "General Register Files", contain numerous other settings as well and always seem to change between Rockchip SoCs. Therefore abstract the register accesses into a per-soc ops struct to make this reusable on other Rockchip SoCs.

[PATCH 1/4] net: stmmac: dwmac-rk: remove unused gpio register defines

2015-06-17 Thread Heiko Stuebner
In a first version the driver did want to do some gpio wiggling, which of course never made it into the kernel, but somehow these register defines where forgotten. Remove them, as they shouldn't be here. Signed-off-by: Heiko Stuebner --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 3 --- 1

[PATCH 0/4] net: stmmac: dwmac-rk: add support for rk3368

2015-06-17 Thread Heiko Stuebner
Apart from small cleanups, this series provides support for the dwmac on the new rk3368 ARM64 soc. Tested on a R88 board using a RMII phy. Heiko Stuebner (4): net: stmmac: dwmac-rk: remove unused gpio register defines net: stmmac: dwmac-rk: Fix clk rate when provided by soc net: stmmac: dwm

[PATCH 2/4] net: stmmac: dwmac-rk: Fix clk rate when provided by soc

2015-06-17 Thread Heiko Stuebner
The first iteration of the dwmac-rk support did access an intermediate clock directly below the pll selector. This was removed in a subsequent revision, but the clock and one invocation remained. This results in the driver trying to set the rate of a non-existent clock when the soc and not some ext

Re: [PATCH v2 1/3] net: mvneta: introduce compatible string "marvell, armada-xp-neta"

2015-06-17 Thread Jason Cooper
Hey Thomas, On Wed, Jun 17, 2015 at 10:43:12PM +0200, Thomas Petazzoni wrote: > On Wed, 17 Jun 2015 17:01:12 +, Jason Cooper wrote: > > > I disagree with this. We can't predict what incosistencies we'll discover > > in > > the future. We should only assign new compatible strings based on k

[PATCH 4/4] net: stmmac: dwmac-rk: add rk3368-specific data

2015-06-17 Thread Heiko Stuebner
Add constants and callback functions for the dwmac on rk3368 socs. As can be seen, the base structure is the same, only registers and the bits in them moved slightly. Signed-off-by: Heiko Stuebner --- .../devicetree/bindings/net/rockchip-dwmac.txt | 2 +- drivers/net/ethernet/stmicro/stmma

[RFC PATCH net-next v2 1/5] net: don't reforward packets already forwarded by offload device

2015-06-17 Thread sfeldma
From: Scott Feldman Just before queuing skb for xmit on port, check if skb has been marked by switchdev port driver as already fordwarded by device. If so, drop skb. A non-zero skb->offload_fwd_mark field is set by the switchdev port driver/device on ingress to indicate the skb has already been

[RFC PATCH net-next v2 3/5] switchdev: add offload_fwd_mark generator helper

2015-06-17 Thread sfeldma
From: Scott Feldman skb->offload_fwd_mark and dev->offload_fwd_mark are 32-bit and should be unique for device and may even be unique for a sub-set of ports within device, so add switchdev helper function to generate unique marks based on port's switch ID and group_ifindex. group_ifindex would t

[RFC PATCH net-next v2 2/5] net: add phys ID compare helper to test if two IDs are the same

2015-06-17 Thread sfeldma
From: Scott Feldman Signed-off-by: Scott Feldman --- include/linux/netdevice.h |7 +++ net/switchdev/switchdev.c |8 ++-- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 7be616e1..63090ce 100644 --- a/inc

[RFC PATCH net-next v2 5/5] switchdev: update documentation for offload_fwd_mark

2015-06-17 Thread sfeldma
From: Scott Feldman Signed-off-by: Scott Feldman --- Documentation/networking/switchdev.txt | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt index c5d7ade..b864e47 100644 --- a/

[RFC PATCH net-next v2 4/5] rocker: add offload_fwd_mark support

2015-06-17 Thread sfeldma
From: Scott Feldman If device flags ingress packet as "fwd offload", mark the skb->offlaod_fwd_mark using the ingress port's dev->offlaod_fwd_mark. This will be the hint to the kernel that this packet has already been forwarded by device to egress ports matching skb->offlaod_fwd_mark. For rocke

[RFC PATCH net-next v2 0/5] switchdev: avoid duplicate packet forwarding

2015-06-17 Thread sfeldma
From: Scott Feldman (RFC because we're at rc7+ now) v2: - s/fwd_mark/offload_fwd_mark - use consume_skb rather than kfree_skb when dropping pkt on egress. - Use Jiri's suggestion to use ifindex of one of the ports in a group as the mark for all the ports in the group. This can be done wi

[PATCH iproute2] tests: Add output testing

2015-06-17 Thread Vadim Kochan
From: Vadim Kochan Added possibility to check command output by grep from the testing script. Now TMP_OUT & TMP_ERR are passed from Makefile and changed to STD_ERR & STD_OUT. Also changed some existing tests to make output testing. Signed-off-by: Vadim Kochan --- testsuite/Makefile

Re: [PATCH net-next 00/15] Simplify netfilter and network namespaces

2015-06-17 Thread Eric W. Biederman
Julian Anastasov writes: > Hello, > > On Sun, 14 Jun 2015, Eric W. Biederman wrote: > >> This patshset roots out all of the very weird network namespace >> computation logic (except for the code in ipvs) and fixes it. I really >> don't like how the code has been essentially guessing which

Re: [PATCH v2 0/3] Fix Ethernet jumbo frames support for Armada 370 and 38x

2015-06-17 Thread Thomas Petazzoni
Simon, On Wed, 17 Jun 2015 19:22:17 +0200, Simon Guinot wrote: > > You should add a Fixes: tag to each commit to indicate which commit is > > being fixed by your patches. > > > > Also, I was a bit surprised by your statement that Armada 38x is also > > affected by the problem, since Armada 38x i

Re: [PATCH v2 1/3] net: mvneta: introduce compatible string "marvell, armada-xp-neta"

2015-06-17 Thread Thomas Petazzoni
Jason, On Wed, 17 Jun 2015 17:01:12 +, Jason Cooper wrote: > I disagree with this. We can't predict what incosistencies we'll discover in > the future. We should only assign new compatible strings based on known IP > variations when we discover them. This seems fraught with demons since we

Re: [PATCH net-next 43/43] netfilter: Skip unnecessary calls to synchronize_net

2015-06-17 Thread Eric W. Biederman
Patrick McHardy writes: > On 17.06, Eric W. Biederman wrote: >> From: Eric W Biederman >> >> Signed-off-by: "Eric W. Biederman" >> --- >> net/netfilter/core.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/net/netfilter/core.c b/net/netfilter/core.c >> index 9

Re: [PATCH net-next v2] ipv4: include NLM_F_APPEND flag in append route notifications

2015-06-17 Thread roopa
On 6/17/15, 11:30 AM, Scott Feldman wrote: On Wed, Jun 17, 2015 at 11:07 AM, Roopa Prabhu wrote: From: Roopa Prabhu This patch adds NLM_F_APPEND flag to struct nlmsg_hdr->nlmsg_flags in newroute notifications if the route add was an append. (This is similar to how NLM_F_REPLACE is already par

Re: macb napi strange behavior

2015-06-17 Thread Florian Fainelli
2015-06-17 12:00 GMT-07:00 Nicolae Rosia : > Hi, > > On Wed, Jun 17, 2015 at 9:54 PM, Jaeden Amero wrote: >> On 06/17/2015 11:09 AM, Nicolae Rosia wrote: >> The times we've seen tons of interrupts on Ethernet with interrupts >> routed through the PL was when the FPGA was unprogrammed (or in the >>

Re: [PATCH net-next 0/3 v4] changes to make ipv4 routing table aware of next-hop link status

2015-06-17 Thread Andy Gospodarek
On Wed, Jun 17, 2015 at 09:52:11PM +0200, Nicolas Dichtel wrote: > Le 17/06/2015 21:10, Andy Gospodarek a écrit : > >On Wed, Jun 17, 2015 at 06:05:32PM +0200, Nicolas Dichtel wrote: > >>Le 15/06/2015 18:33, Andy Gospodarek a écrit : > >>>This series adds the ability to have the Linux kernel track w

[PATCH net-next 3/3] ipv4: ICMP packet inspection for multipath

2015-06-17 Thread Peter Nørlund
ICMP packets are inspected to let them route together with the flow they belong to, allowing anycast environments to work with ECMP. Signed-off-by: Peter Nørlund --- net/ipv4/icmp.c | 27 ++- net/ipv4/route.c | 80 ++-- 2 files

[PATCH net-next 1/3] ipv4: Lock-less per-packet multipath

2015-06-17 Thread Peter Nørlund
The current multipath attempted to be quasi random, but in most cases it behaved just like a round robin balancing. This patch refactors the algorithm to be exactly that and in doing so, avoids the spin lock. The new design paves the way for hash-based multipath, replacing the modulo with threshol

[PATCH net-next 0/3] ipv4: Hash-based multipath routing

2015-06-17 Thread Peter Nørlund
This patch series enhances the IPv4 multipath code, adding support for hash-based multipath. The multipath algorithm is a per-route attribute (RTA_MP_ALGO) with some degree of binary compatibility with the old implementation (2.6.12 - 2.6.22), but without source level compatibility since attribute

[PATCH net-next 2/3] ipv4: L3 and L4 hash-based multipath routing

2015-06-17 Thread Peter Nørlund
This patch adds L3 and L4 hash-based multipath routing, selectable on a per-route basis with the reintroduced RTA_MP_ALGO attribute. The default is now RT_MP_ALG_L3_HASH. Signed-off-by: Peter Nørlund --- include/net/ip_fib.h | 4 ++- include/net/route.h| 5 ++-- include/u

[PATCH net v2] packet: avoid out of bounds read in round robin fanout

2015-06-17 Thread Willem de Bruijn
From: Willem de Bruijn PACKET_FANOUT_LB computes f->rr_cur such that it is modulo f->num_members. It returns the old value unconditionally, but f->num_members may have changed since the last store. Ensure that the return value is always < num. When modifying the logic, simplify it further by rep

Re: [PATCH net-next 0/3 v4] changes to make ipv4 routing table aware of next-hop link status

2015-06-17 Thread Nicolas Dichtel
Le 17/06/2015 21:10, Andy Gospodarek a écrit : On Wed, Jun 17, 2015 at 06:05:32PM +0200, Nicolas Dichtel wrote: Le 15/06/2015 18:33, Andy Gospodarek a écrit : This series adds the ability to have the Linux kernel track whether or not a particular route should be used based on the link-status of

Re: [PATCH net-next 00/15] Simplify netfilter and network namespaces

2015-06-17 Thread Julian Anastasov
Hello, On Sun, 14 Jun 2015, Eric W. Biederman wrote: > This patshset roots out all of the very weird network namespace > computation logic (except for the code in ipvs) and fixes it. I really > don't like how the code has been essentially guessing which network > namespace to use. > >

Re: [PATCH net-next 0/3 v4] changes to make ipv4 routing table aware of next-hop link status

2015-06-17 Thread Andy Gospodarek
On Wed, Jun 17, 2015 at 06:05:32PM +0200, Nicolas Dichtel wrote: > Le 15/06/2015 18:33, Andy Gospodarek a écrit : > >This series adds the ability to have the Linux kernel track whether or > >not a particular route should be used based on the link-status of the > >interface associated with the next-

Re: macb napi strange behavior

2015-06-17 Thread Nicolae Rosia
Hi, On Wed, Jun 17, 2015 at 9:54 PM, Jaeden Amero wrote: > On 06/17/2015 11:09 AM, Nicolae Rosia wrote: > The times we've seen tons of interrupts on Ethernet with interrupts > routed through the PL was when the FPGA was unprogrammed (or in the > process of being reprogrammed), or was configured w

Re: [PATCH] xilinx:Remove unused variable num_frag in the function axienet_start_xmit

2015-06-17 Thread Sören Brinkmann
On Wed, 2015-06-17 at 12:21PM -0400, Nicholas Krause wrote: > > > On June 17, 2015 12:07:30 PM EDT, "Sören Brinkmann" > wrote: > >On Wed, 2015-06-17 at 11:52AM -0400, Nicholas Krause wrote: > >> This removes the unused variable num_frag and the setting of it > >> to the number of fragments from

Re: macb napi strange behavior

2015-06-17 Thread Jaeden Amero
On 06/17/2015 11:09 AM, Nicolae Rosia wrote: > I'm trying to determine why I have a huge number of IRQs for only a > macb interface and the other one works just fine (low IRQ activity). I > have activated IP forward and I'm just forwarding packets from eth0 to > eth1. > The platform is Zynq7, Linux

Re: [RFC PATCH 0/2] sctp: add new getsockopt option SCTP_SOCKOPT_PEELOFF_KERNEL

2015-06-17 Thread Neil Horman
On Wed, Jun 17, 2015 at 10:40:26AM -0300, Marcelo Ricardo Leitner wrote: > On 17-06-2015 10:16, Neil Horman wrote: > >On Wed, Jun 17, 2015 at 09:40:32AM -0300, Marcelo Ricardo Leitner wrote: > >>On 17-06-2015 09:20, Neil Horman wrote: > >>>On Wed, Jun 17, 2015 at 08:38:10AM -0300, Marcelo Ricardo L

DSA: Exposing CPU port [Was: Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex]

2015-06-17 Thread Florian Fainelli
2015-06-17 11:09 GMT-07:00 Vivien Didelot : > Hi Andrew, All, > > On 12/06/15 10:18, Andrew Lunn wrote: >> By default, DSA and CPU ports are configured to the maximum speed the >> switch supports. However there can be use cases where the peer device >> port is slower. Allow a fixed-link property to

Re: [PATCH net-next v2] ipv4: include NLM_F_APPEND flag in append route notifications

2015-06-17 Thread Scott Feldman
On Wed, Jun 17, 2015 at 11:07 AM, Roopa Prabhu wrote: > From: Roopa Prabhu > > This patch adds NLM_F_APPEND flag to struct nlmsg_hdr->nlmsg_flags > in newroute notifications if the route add was an append. > (This is similar to how NLM_F_REPLACE is already part of new > route replace notification

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-17 Thread Vivien Didelot
Hi Andrew, All, On 12/06/15 10:18, Andrew Lunn wrote: > By default, DSA and CPU ports are configured to the maximum speed the > switch supports. However there can be use cases where the peer device > port is slower. Allow a fixed-link property to be used with the DSA > and CPU port in the device t

Re: [PATCH net] ipv4: include NLM_F_APPEND flag in append route notifications

2015-06-17 Thread roopa
On 6/17/15, 10:31 AM, Alexander Duyck wrote: I'd say go with something closer to the original patch, but flip the logic like you have here, and lose the "|=" in favor of an "=" since you are either sending a message with 0 or NLM_F_APPEND. Anyway that is just my $.02. agreed, thanks alex,

[PATCH net-next v2] ipv4: include NLM_F_APPEND flag in append route notifications

2015-06-17 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds NLM_F_APPEND flag to struct nlmsg_hdr->nlmsg_flags in newroute notifications if the route add was an append. (This is similar to how NLM_F_REPLACE is already part of new route replace notifications today) This helps userspace determine if the route add operatio

Re: [PATCH 01/12] fsl/fman: Add the FMan FLIB headers

2015-06-17 Thread Scott Wood
On Wed, 2015-06-17 at 09:59 -0500, Liberman Igal-B31950 wrote: > > Regards, > Igal Liberman. > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Wednesday, June 10, 2015 9:54 PM > > To: Bucur Madalin-Cristian-B32716 > > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org;

Re: [PATCH net] ipv4: include NLM_F_APPEND flag in append route notifications

2015-06-17 Thread Alexander Duyck
On 06/17/2015 09:20 AM, roopa wrote: On 6/17/15, 8:35 AM, Alexander Duyck wrote: @@ -1189,8 +1190,9 @@ int fib_table_insert(struct fib_table *tb, struct fib_config *cfg) fib_release_info(fi_drop); if (state & FA_S_ACCESSED) rt_cache_flush(cfg->

Re: [PATCH V3 0/2] pci: Provide a flag to access VPD through function 0

2015-06-17 Thread Alexander Duyck
On 06/17/2015 09:29 AM, Rustad, Mark D wrote: + Alex On Jun 5, 2015, at 2:59 PM, Rustad, Mark D wrote: On Jun 3, 2015, at 11:46 AM, Mark D Rustad wrote: Many multi-function devices provide shared registers in extended config space for accessing VPD. The behavior of these registers means th

Re: [PATCH v2 0/3] Fix Ethernet jumbo frames support for Armada 370 and 38x

2015-06-17 Thread Simon Guinot
On Wed, Jun 17, 2015 at 05:24:58PM +0200, Thomas Petazzoni wrote: > Dear Simon Guinot, > > On Wed, 17 Jun 2015 15:19:19 +0200, Simon Guinot wrote: > > > This patch series fixes the Ethernet jumbo frames support for the SoCs > > Armada 370, 380 and 385. Unlike Armada XP, the Ethernet controller fo

Re: [PATCH net-next 43/43] netfilter: Skip unnecessary calls to synchronize_net

2015-06-17 Thread Patrick McHardy
On 17.06, Eric W. Biederman wrote: > From: Eric W Biederman > > Signed-off-by: "Eric W. Biederman" > --- > net/netfilter/core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/net/netfilter/core.c b/net/netfilter/core.c > index 95456c09cf69..1b4eadc9c030 100644 > --

Re: [PATCH 08/11] IB/cma: Add net_dev and private data checks to RDMA CM

2015-06-17 Thread Jason Gunthorpe
On Tue, Jun 16, 2015 at 08:26:26AM +0300, Haggai Eran wrote: > On 15/06/2015 20:08, Jason Gunthorpe wrote: > > On Mon, Jun 15, 2015 at 11:47:13AM +0300, Haggai Eran wrote: > >> Instead of relying on a the ib_cm module to check an incoming CM request's > >> private data header, add these checks to t

Re: [Intel-wired-lan] [PATCH v6 3/3] ixgbe, ixgbevf: Add new mbox API to enable MC promiscuous mode

2015-06-17 Thread Alexander Duyck
On 06/17/2015 04:45 AM, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto The limitation of the number of multicast address for VF is not enough for the large scale server with SR-IOV feature. IPv6 requires the multicast MAC address for each IP address to handle the Neighbor Solicitation message

Re: [PATCH net-next] x_table: align per cpu xt_counter

2015-06-17 Thread Florian Westphal
Eric Dumazet wrote: > From: Eric Dumazet > > Let's force a 16 bytes alignment on xt_counter percpu allocations, > so that bytes and packets sit in same cache line. > > xt_counter being exported to user space, we cannot add __align(16) on > the structure itself. Sorry, I was away. Looks great.

Re: [PATCH 04/11] IB/cm: Expose DGID in SIDR request events

2015-06-17 Thread Jason Gunthorpe
On Tue, Jun 16, 2015 at 02:25:07PM +0300, Haggai Eran wrote: > > But how is that going to work? How is the sender to know it should be > > sending a GRH with the CM message? > > If the admin wants to use SIDR with alias GIDs, they will need to > configure the system to enable GRH for such GMPs. (

Re: [PATCH v2 1/3] net: mvneta: introduce compatible string "marvell, armada-xp-neta"

2015-06-17 Thread Jason Cooper
Hi Gregory, On Wed, Jun 17, 2015 at 05:15:28PM +0200, Gregory CLEMENT wrote: > On 17/06/2015 17:12, Gregory CLEMENT wrote: > > On 17/06/2015 15:19, Simon Guinot wrote: > >> The mvneta driver supports the Ethernet IP found in the Armada 370, XP, > >> 380 and 385 SoCs. Since at least one more hardwa

Re: [PATCH V3 0/2] pci: Provide a flag to access VPD through function 0

2015-06-17 Thread Bjorn Helgaas
On Wed, Jun 17, 2015 at 11:29 AM, Rustad, Mark D wrote: > + Alex > >> On Jun 5, 2015, at 2:59 PM, Rustad, Mark D wrote: >> >>> On Jun 3, 2015, at 11:46 AM, Mark D Rustad wrote: >>> >>> Many multi-function devices provide shared registers in extended >>> config space for accessing VPD. The behavi

[PATCH net-next 0/3] bna: clean-up 2

2015-06-17 Thread Ivan Vecera
Next round of cleaning patches. Ivan Vecera (3): bna: remove unnecessary cast of BIT value bna: make pointers to read-only inputs const bna: remove superfluous parentheses .../net/ethernet/brocade/bna/bfa_defs_mfg_comm.h | 2 +- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 10

[PATCH net-next 2/3] bna: make pointers to read-only inputs const

2015-06-17 Thread Ivan Vecera
Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bna.h | 19 +-- drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 14 +++--- drivers/net/ethernet/brocade/bna/bnad.c | 6 +++--- drivers/net/ethernet/brocade/bna/bnad.h | 2 +- 4 files changed,

[PATCH net-next 1/3] bna: remove unnecessary cast of BIT value

2015-06-17 Thread Ivan Vecera
BIT value is already unsigned so casting is not necessary. Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bfa_ioc_ct.c | 3 +-- drivers/net/ethernet/brocade/bna/bna_enet.c | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/brocade/bna

[PATCH net-next 3/3] bna: remove superfluous parentheses

2015-06-17 Thread Ivan Vecera
Signed-off-by: Ivan Vecera --- .../net/ethernet/brocade/bna/bfa_defs_mfg_comm.h | 2 +- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 10 +-- drivers/net/ethernet/brocade/bna/bfa_ioc_ct.c | 98 +++--- drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 4 +- drive

Re: [PATCH V3 0/2] pci: Provide a flag to access VPD through function 0

2015-06-17 Thread Rustad, Mark D
+ Alex > On Jun 5, 2015, at 2:59 PM, Rustad, Mark D wrote: > >> On Jun 3, 2015, at 11:46 AM, Mark D Rustad wrote: >> >> Many multi-function devices provide shared registers in extended >> config space for accessing VPD. The behavior of these registers >> means that the state must be tracked an

Re: [Intel-wired-lan] [PATCH v6 2/3] ixgbe: Add new ndo to trust VF

2015-06-17 Thread Alexander Duyck
On 06/17/2015 04:43 AM, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto Implements the new netdev op to trust VF in ixgbe. The administrator can turn on and off VF trusted by ip command which supports trust message. # ip link set dev eth0 vf 1 trust on or # ip link set dev eth0 vf 1 trust

Re: [PATCH net] ipv4: include NLM_F_APPEND flag in append route notifications

2015-06-17 Thread roopa
On 6/17/15, 8:35 AM, Alexander Duyck wrote: @@ -1189,8 +1190,9 @@ int fib_table_insert(struct fib_table *tb, struct fib_config *cfg) fib_release_info(fi_drop); if (state & FA_S_ACCESSED) rt_cache_flush(cfg->fc_nlinfo.nl_net); +

Re: [Intel-wired-lan] [PATCH v6 1/3] if_link: Add control trust VF

2015-06-17 Thread Alexander Duyck
On 06/17/2015 04:41 AM, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto Add netlink directives and ndo entry to trust VF user. This controls the special permission of VF user. The administrator will dedicatedly trust VF user to use some features which impacts security and/or performance. The

  1   2   3   >