RE: [PATCH net-next] cxgb4: replace ntoh{s,l} and hton{s,l} calls with the generic byteorder

2015-05-18 Thread Hariprasad S
Ignore this. Needs some correction. Using incorrect byte-ordering at 2 places. Will send a V2 for the same. Thanks, Hari From: Hariprasad Shenai [haripra...@chelsio.com] Sent: Tuesday, May 19, 2015 3:43 PM To: netdev@vger.kernel.org Cc: da...@davemloft.ne

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-18 Thread roopa
On 5/18/15, 1:19 PM, David Miller wrote: From: Roopa Prabhu Date: Sun, 17 May 2015 16:42:05 -0700 On most systems where you can offload routes to hardware, doing routing in software is not an option (the cpu limitations make routing impossible in software). You absolutely do not get to determ

Re: [PATCH net] inet: properly align icsk_ca_priv

2015-05-18 Thread David Miller
From: Eric Dumazet Date: Mon, 18 May 2015 17:06:14 -0700 > From: Eric Dumazet > > tcp_illinois and upcoming tcp_cdg require 64bit alignment of > icsk_ca_priv > > x86 does not care, but other architectures might. > > Fixes: 05cbc0db03e82 ("ipv4: Create probe timer for tcp PMTU as per RFC4821")

Re: [PATCH] tcp: ensure epoll edge trigger wakeup when out of memory

2015-05-18 Thread David Miller
From: David Miller Date: Tue, 19 May 2015 00:09:45 -0400 (EDT) > From: Jason Baron > Date: Fri, 15 May 2015 21:17:07 + (GMT) > >> From: Jason Baron >> >> If we really can't get an skb allocated, make sure that we let >> userspace know. This at least gives us a chance to re-try or abort. >

Re: [PATCH] tcp: ensure epoll edge trigger wakeup when out of memory

2015-05-18 Thread David Miller
From: Jason Baron Date: Fri, 15 May 2015 21:17:07 + (GMT) > From: Jason Baron > > If we really can't get an skb allocated, make sure that we let > userspace know. This at least gives us a chance to re-try or abort. > > Signed-off-by: Jason Baron Applied to net-next, thanks Jason. Eric a

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-18 Thread David Miller
From: John Fastabend Date: Mon, 18 May 2015 17:21:29 -0700 > So how about having an error strategy sysctl field that we can set > at provisioning time. I think this would align to Roopa's option (b). > This way we can default to "transparent" mode and the users where > this wont work can set the

Re: [PATCH v2 net-next 0/2] rocker: unused parameter and const cleanups

2015-05-18 Thread Simon Horman
On Mon, May 18, 2015 at 03:47:22PM -0400, David Miller wrote: > From: Simon Horman > Date: Thu, 14 May 2015 12:42:54 +0900 > > > This series provides some minor though verbose cleanup of rocker. > > > > The second patch depends on the first though it could be rebased. > > > > * Changes v1 -> v2

[PATCH net] inet: properly align icsk_ca_priv

2015-05-18 Thread Eric Dumazet
From: Eric Dumazet tcp_illinois and upcoming tcp_cdg require 64bit alignment of icsk_ca_priv x86 does not care, but other architectures might. Fixes: 05cbc0db03e82 ("ipv4: Create probe timer for tcp PMTU as per RFC4821") Signed-off-by: Eric Dumazet Cc: Fan Du --- include/net/inet_connection_

Re: [V4 PATCH 1/6] ACPI / scan: Parse _CCA and setup device coherency

2015-05-18 Thread Rafael J. Wysocki
On Monday, May 18, 2015 05:38:17 PM Suravee Suthikulanit wrote: > Hi Rafael, > > On 5/15/2015 6:53 PM, Rafael J. Wysocki wrote: > > On Friday, May 15, 2015 04:23:09 PM Suravee Suthikulpanit wrote: > >> [...] > >> diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c > >> index 4

Re: [PATCH net-next v3 2/2] net: Adding support for Cavium ThunderX network controller

2015-05-18 Thread David Miller
From: David Daney Date: Mon, 18 May 2015 14:52:30 -0700 > As I see it there are two options: > > 1) Keep the writeq_relaxed()/readq_relaxed(), but add a comment about > why they are safe. > > 2) Change the patch so that we are using writeq()/readq() and suffer a > decrease in performance. I wa

Re: [PATCH -next] net: preserve geometry of fragment sizes when forwarding

2015-05-18 Thread David Miller
From: Florian Westphal Date: Mon, 18 May 2015 23:33:29 +0200 > Thanks for spending time on this. Ok, I've heard what you have to say. Of the fixes you've proposed already, I prefer the device MTU one because it doesn't penalize the ip_fragment.c optimizations just because a netfilter module is

Re: rhashtable: Add cap on number of elements in hash table

2015-05-18 Thread Herbert Xu
On Mon, May 18, 2015 at 04:12:01PM -0400, David Miller wrote: > > Ok, this of course depends upon the distribution of the input data > and the strength/suitability of the hash function. > > I'm a little bit disappointed in what Thomas found. I would expect > the distribution to be at least a litt

Re: [RFC PATCH net-next] tcp: add CDG congestion control

2015-05-18 Thread Stephen Hemminger
I am really happy to see more congestion control development. > +static int window __read_mostly = 8; > +static bool use_shadow __read_mostly = true; > +static bool use_tolerance __read_mostly; > +static uint backoff_beta __read_mostly = 0.70 * 1024; > +static uint backoff_factor __read_mostly =

Re: [PATCH net-next v3 2/2] net: Adding support for Cavium ThunderX network controller

2015-05-18 Thread David Daney
On 05/18/2015 01:09 PM, David Miller wrote: From: Aleksey Makarov Date: Fri, 15 May 2015 20:36:39 -0700 +/* Register read/write APIs */ +static void nic_reg_write(struct nicpf *nic, u64 offset, u64 val) +{ + writeq_relaxed(val, nic->reg_base + offset); +} + +static u64 nic_reg_read(struc

Re: [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id

2015-05-18 Thread David Miller
From: Aleksey Makarov Date: Mon, 18 May 2015 14:00:22 -0700 > > Author of this patch is > > Author: Sunil Goutham > > Sorry for this. It will be fixed in next versions. You indicate this with: From: Sunil Goutham at the top of the commit message when you post the patch. -- To unsubscribe

Re: [PATCH net-next] selftests/net: expect headroom in psock_fanout rollover

2015-05-18 Thread David Miller
From: Willem de Bruijn Date: Mon, 18 May 2015 15:42:11 -0400 > From: Willem de Bruijn > > psock_fanout tests the various fanout modes. Change the test for > rollover mode to expect early rollover due to socket pressure > as implemented in 2ccdbaa6d55b ("packet: rollover lock contention > avoida

Re: [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id

2015-05-18 Thread Aleksey Makarov
Author of this patch is Author: Sunil Goutham Sorry for this. It will be fixed in next versions. On 05/15/2015 08:36 PM, Aleksey Makarov wrote: Signed-off-by: Aleksey Makarov --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/incl

Re: [PATCH] vxlan: correct typo in call to unregister_netdevice_queue

2015-05-18 Thread David Miller
From: "John W. Linville" Date: Mon, 18 May 2015 13:51:24 -0400 > By inspection, this appears to be a typo. The gating comparison > involves vxlan->dev rather than dev. In fact, dev is the iterator in > the preceding loop above but it is actually constant in the 2nd loop. > > Use of dev seems t

Re: [PATCH -next] net: preserve geometry of fragment sizes when forwarding

2015-05-18 Thread David Miller
From: Florian Westphal Date: Mon, 18 May 2015 22:40:49 +0200 > But, to the best of my understanding, what you ask will push a lot of > non-trivial code into the kernel for no functional gain over > what has been proposed. The functional gain is that we stop linearizing the packet, which involves

Re: [PATCH -next] net: preserve geometry of fragment sizes when forwarding

2015-05-18 Thread David Miller
From: Florian Westphal Date: Mon, 18 May 2015 22:06:37 +0200 > So, please please re-evaluate your stance on any of the previous > attempts or tell me how you would provide bridge netfilter with > the means to transparently forward (refrag) reassembled skbs, without > breaking PMTUD, in ipv4 and i

Re: [RFC PATCH net-next] tcp: add CDG congestion control

2015-05-18 Thread Yuchung Cheng
On Sun, May 17, 2015 at 1:31 PM, Kenneth Klette Jonassen wrote: > This is a request for comments. > > CAIA Delay-Gradient (CDG) is a TCP congestion control that modifies > the TCP sender in order to [1]: > > o Use the delay gradient as a congestion signal. > o Back off with an average probabil

Re: [PATCH net-next] sfc: nicer log message on Siena SR-IOV probe fail

2015-05-18 Thread David Miller
From: Edward Cree Date: Mon, 18 May 2015 14:18:27 +0100 > We expect that MC_CMD_SRIOV will fail if the card has no VFs configured. > So output a readable message instead of a cryptic MCDI error. > > Signed-off-by: Edward Cree Applied, thank you. -- To unsubscribe from this list: send the line

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-18 Thread David Miller
From: Roopa Prabhu Date: Sun, 17 May 2015 16:42:05 -0700 > On most systems where you can offload routes to hardware, > doing routing in software is not an option (the cpu limitations > make routing impossible in software). You absolutely do not get to determine this policy, none of us do. What

Re: pull request: bluetooth 2015-05-17

2015-05-18 Thread David Miller
From: Johan Hedberg Date: Sun, 17 May 2015 15:51:36 +0300 > A couple more Bluetooth updates for 4.1: > > - New USB IDs for ath3k & btusb > - Fix for remote name resolving during device discovery > > Please let me know if there are any issues pulling. Thanks. Pulled, thanks Johan. -- To unsubsc

Re: rhashtable: Add cap on number of elements in hash table

2015-05-18 Thread David Miller
From: Herbert Xu Date: Sun, 17 May 2015 09:38:29 +0800 > On Sat, May 16, 2015 at 06:09:46PM -0400, David Miller wrote: >> >> Obviously something like 50 or 100 is too much. >> >> Perhaps something between 5 and 10. > > You are even more parsimonious than I :) Because the maximum chain > length

Re: [PATCH net-next v3 2/2] net: Adding support for Cavium ThunderX network controller

2015-05-18 Thread David Miller
From: Aleksey Makarov Date: Fri, 15 May 2015 20:36:39 -0700 > +/* Register read/write APIs */ > +static void nic_reg_write(struct nicpf *nic, u64 offset, u64 val) > +{ > + writeq_relaxed(val, nic->reg_base + offset); > +} > + > +static u64 nic_reg_read(struct nicpf *nic, u64 offset) > +{ > +

Re: [PATCH v2 net-next 0/2] rocker: unused parameter and const cleanups

2015-05-18 Thread David Miller
From: Simon Horman Date: Thu, 14 May 2015 12:42:54 +0900 > This series provides some minor though verbose cleanup of rocker. > > The second patch depends on the first though it could be rebased. > > * Changes v1 -> v2 > - Found quite a few more variables and parameters to make const As state

Re: [PATCH -next] net: preserve geometry of fragment sizes when forwarding

2015-05-18 Thread David Miller
From: Florian Westphal Date: Thu, 7 May 2015 23:04:24 +0200 > There was interest in keeping geometry of original fragments on forward. > > This (re)enables this feature. > > on router with mtu 1500 on all interfaces and netfilter conntrack enabled: ... > Caveat: > This disables the optimizati

[PATCH] net/ipv6/udp: Fix ipv6 multicast socket filter regression

2015-05-18 Thread Henning Rogge
Commit <5cf3d46192fc> ("udp: Simplify__udp*_lib_mcast_deliver") simplified the filter for incoming IPv6 multicast but removed the check of the local socket address and the UDP destination address. This patch restores the filter to prevent sockets bound to a IPv6 multicast IP to receive other UDP t

Re: [PATCH 00/21] Netfilter updates for net-next

2015-05-18 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 18 May 2015 18:25:03 +0200 > The following patchset contains Netfilter updates for net-next. Briefly > speaking, cleanups and minor fixes for ipset from Jozsef Kadlecsik and > Serget Popovich, more incremental updates to make br_netfilter a better > place from F

Re: [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id

2015-05-18 Thread Bjorn Helgaas
On Mon, May 18, 2015 at 11:41 AM, David Miller wrote: > From: Bjorn Helgaas > Date: Mon, 18 May 2015 11:35:20 -0500 > >> [+cc Greg] >> >> On Sat, May 16, 2015 at 4:14 PM, David Miller wrote: >>> From: Bjorn Helgaas >>> Date: Sat, 16 May 2015 09:49:40 -0500 >>> Hi Aleksey, On Fri,

Re: [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id

2015-05-18 Thread David Miller
From: Bjorn Helgaas Date: Mon, 18 May 2015 11:35:20 -0500 > [+cc Greg] > > On Sat, May 16, 2015 at 4:14 PM, David Miller wrote: >> From: Bjorn Helgaas >> Date: Sat, 16 May 2015 09:49:40 -0500 >> >>> Hi Aleksey, >>> >>> On Fri, May 15, 2015 at 10:36 PM, Aleksey Makarov >>> wrote: Signed-o

Re: [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id

2015-05-18 Thread Bjorn Helgaas
[+cc Greg] On Sat, May 16, 2015 at 4:14 PM, David Miller wrote: > From: Bjorn Helgaas > Date: Sat, 16 May 2015 09:49:40 -0500 > >> Hi Aleksey, >> >> On Fri, May 15, 2015 at 10:36 PM, Aleksey Makarov >> wrote: >>> Signed-off-by: Aleksey Makarov >>> --- >>> include/linux/pci_ids.h | 2 ++ >>> 1

[PATCH 21/21] netfilter: Use correct return for seq_show functions

2015-05-18 Thread Pablo Neira Ayuso
From: Joe Perches Using seq_has_overflowed doesn't produce the right return value. Either 0 or -1 is, but 0 is much more common and works well when seq allocation retries. I believe this doesn't matter as the initial allocation is always sufficient, this is just a correctness patch. Miscellanea

[PATCH 19/21] netfilter: xt_MARK: Add ARP support

2015-05-18 Thread Pablo Neira Ayuso
From: Zhang Chunyu Add arpt_MARK to xt_mark. The corresponding userspace update is available at: http://git.netfilter.org/arptables/commit/?id=4bb2f8340783fd3a3f70aa6f8807428a280f8474 Signed-off-by: Zhang Chunyu Signed-off-by: Pablo Neira Ayuso --- net/netfilter/xt_mark.c |1 + 1 file c

Re: [PATCH net-next 01/16] sfc: Add permissions to MCDI commands

2015-05-18 Thread David Miller
From: Shradha Shah Date: Mon, 18 May 2015 16:27:00 +0100 > @@ -637,6 +637,9 @@ > * Read multiple 32byte words from MC memory. > */ > #define MC_CMD_READ32 0x1 > +#undef MC_CMD_0x1_PRIVILEGE_CTG > + > +#define MC_CMD_0x1_PRIVILEGE_CTG SRIOV_CTG_ADMIN Please do not add unnecessary #undef stat

[PATCH 12/21] netfilter: ipset: Fix ext_*() macros

2015-05-18 Thread Pablo Neira Ayuso
From: Sergey Popovich So pointers returned by these macros could be referenced with -> directly. Signed-off-by: Sergey Popovich Signed-off-by: Jozsef Kadlecsik Signed-off-by: Pablo Neira Ayuso --- include/linux/netfilter/ipset/ip_set.h |8 1 file changed, 4 insertions(+), 4 dele

Re: [PATCH net-next 0/8] s390: network patches for net-next

2015-05-18 Thread David Miller
From: Ursula Braun Date: Mon, 18 May 2015 14:27:51 +0200 > here are s390 related patches for net-next Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/

Re: [PATCH] net-next: ethtool: Added port speed macros.

2015-05-18 Thread David Miller
From: Parav Pandit Date: Mon, 18 May 2015 16:31:47 +0530 > Signed-off-by: Parav Pandit I thought we had decided that we weren't going to keep adding convenience macros for new speeds, and were simply going to use the appropriate constants in the future. Ben? -- To unsubscribe from this list: s

[PATCH iproute2 08/10] tc: gred: Handle unsigned values properly in option parsing/printing

2015-05-18 Thread David Ward
DPs, def_DP, and DP are unsigned values that are sent and received in TCA_GRED_* netlink attributes; handle them properly when they are parsed or printed. Use MAX_DPs as the initial value for def_DP and DP, and fix the operator used for bounds checking them. Signed-off-by: David Ward --- tc/q_gr

Re: [net PATCH] ip_vti/ip6_vti: Clear skb->mark when resetting skb->dev in receive path

2015-05-18 Thread Herbert Xu
On Mon, May 18, 2015 at 09:04:27AM +0200, Steffen Klassert wrote: > > The policy and state mark must match the tunnels i_key/o_key > on lookup. It is not required to set skb->mark, but we have > to make sure to use the tunnels gre keys as the mark when we > do a policy or state lookup. So is it po