From: Shradha Shah <ss...@solarflare.com> Date: Mon, 18 May 2015 16:27:00 +0100
> @@ -637,6 +637,9 @@ > * Read multiple 32byte words from MC memory. > */ > #define MC_CMD_READ32 0x1 > +#undef MC_CMD_0x1_PRIVILEGE_CTG > + > +#define MC_CMD_0x1_PRIVILEGE_CTG SRIOV_CTG_ADMIN Please do not add unnecessary #undef statements like this. It makes your code harder to read, and in particular harder to audit for problems. Because you're making it look like you are explicitly overriding a definition from somewhere else, so people have to go grepping around to find out where that is only to find out that no such place even exists. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
