[v2] act_mirred: Fix bogus header when redirecting from VLAN

On Thu, Apr 16, 2015 at 07:40:30PM -0700, Alexei Starovoitov wrote: > On Fri, Apr 17, 2015 at 10:15:01AM +0800, Herbert Xu wrote: > > > seems the cleaner fix will be to push skb->mac_len instead? > > > > No skb->mac_len is the same as skb2->dev->hard_header_len. > > hmm. please help me understand

Re: [PATCH net-next v4 00/24] switchdev: spring cleanup

On 4/13/15, 10:47 PM, roopa wrote: On 4/12/15, 11:16 PM, sfel...@gmail.com wrote: From: Scott Feldman v4: Well, it was a lot of work, but now prepare-commit transaction model is how davem advises: if prepare fails, abort the transaction. The driver must do resource reservations up front in

Re: act_mirred: Fix bogus header when redirecting from VLAN

On Fri, Apr 17, 2015 at 10:15:01AM +0800, Herbert Xu wrote: > > seems the cleaner fix will be to push skb->mac_len instead? > > No skb->mac_len is the same as skb2->dev->hard_header_len. hmm. please help me understand the problem then. In the commit log you mentioned that your vlan dev and ifb ha

Re: [PATCH 2/2] net: dsa: register hwmon for any provided function

hi Vivien, On 04/16/2015 03:05 PM, Vivien Didelot wrote: Hi Guenter, switch (index) { +case 0: /* temp1_input */ +if (drv->get_temp) +mode |= S_IRUGO; This should be mandatory. Sorry, I don't really understand what you are trying to a

Re: act_mirred: Fix bogus header when redirecting from VLAN

On Thu, Apr 16, 2015 at 06:34:02PM -0700, Alexei Starovoitov wrote: > On Fri, Apr 17, 2015 at 09:02:16AM +0800, Herbert Xu wrote: > > @@ -105,7 +105,7 @@ static void ri_tasklet(unsigned long dev) > > if (from & AT_EGRESS) { > > dev_queue_xmit(skb); > > }

Re: [PATCH] dsa: mv88e6xxx: Fix error handling in mv88e6xxx_set_port_state

On 04/16/2015 11:51 AM, Geert Uytterhoeven wrote: On Thu, Apr 16, 2015 at 3:46 PM, Guenter Roeck wrote: On 04/15/2015 10:12 PM, Guenter Roeck wrote: Return correct error code if _mv88e6xxx_reg_read returns an error. Fixes: facd95b2e0ec0 ("net: dsa: mv88e6xxx: Add Hardware bridging support")

Re: act_mirred: Fix bogus header when redirecting from VLAN

On Fri, Apr 17, 2015 at 09:02:16AM +0800, Herbert Xu wrote: > @@ -105,7 +105,7 @@ static void ri_tasklet(unsigned long dev) > if (from & AT_EGRESS) { > dev_queue_xmit(skb); > } else if (from & AT_INGRESS) { > - skb_pull(skb, skb-

[PATCH net] inet_diag: fix access to tcp cc information

From: Eric Dumazet Two different problems are fixed here : 1) inet_sk_diag_fill() might be called without socket lock held. icsk->icsk_ca_ops can change under us and module be unloaded. -> Access to freed memory. Fix this using rcu_read_lock() to prevent module unload. 2) Some TCP Cong

act_mirred: Fix bogus header when redirecting from VLAN

When you redirect a VLAN device to an ifb device, you end up with crap within the ifb device because they have unequal hard header lengths and the redirected packet contains four extra bytes at the start which then gets interpreted as part of the MAC address. This patch fixes this by only pushing

Re: [PATCH -next 0/3] net: cap size to original frag size when refragmenting

On 17.04, Hannes Frederic Sowa wrote: > > > On Thu, Apr 16, 2015, at 22:56, Patrick McHardy wrote: > > On 17.04, Herbert Xu wrote: > > > On Thu, Apr 16, 2015 at 06:13:25PM +0200, Hannes Frederic Sowa wrote: > > > > > > > > So currently we have one fast path, that is: we are not fragmented, we > >

Re: [PATCH -next 0/3] net: cap size to original frag size when refragmenting

On Thu, Apr 16, 2015, at 22:56, Patrick McHardy wrote: > On 17.04, Herbert Xu wrote: > > On Thu, Apr 16, 2015 at 06:13:25PM +0200, Hannes Frederic Sowa wrote: > > > > > > So currently we have one fast path, that is: we are not fragmented, we > > > get out non-fragmented, none of this code is ever

Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

On Thu, 2015-04-16 at 18:15 +0100, Ian Jackson wrote: > Michael Chan writes ("Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more > messages]"): > > On Thu, 2015-04-16 at 09:24 -0300, casca...@linux.vnet.ibm.com wrote: > > > Yes, this looks like the driver is not syncing the DMA buffers. Unmap

[PATCH net] tcp: tcp_get_info() should fetch socket fields once

From: Eric Dumazet tcp_get_info() can be called without holding socket lock, so any socket fields can change under us. Use READ_ONCE() to fetch sk_pacing_rate and sk_max_pacing_rate Fixes: 977cb0ecf82e ("tcp: add pacing_rate information into tcp_info") Signed-off-by: Eric Dumazet --- David, I

[PATCH 06/16] netconsole: make netconsole_target->enabled a bool

We'll add more bool's to netconsole_target. Let's convert ->enabled to bool first so that things stay consistent. Signed-off-by: Tejun Heo Cc: David Miller --- drivers/net/netconsole.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/netconsole

[PATCH 11/16] netconsole: consolidate enable/disable and create/destroy paths

netconsole management paths are scattered around in different places. This patch reorganizes them so that * All enable logic is in netconsole_enable() and disable in netconsole_disable(). Both should be called with netconsole_mutex held and netconsole_disable() may be invoked without interven

[PATCH 13/16] netconsole: implement retransmission support for extended consoles

With extended netconsole, the logger can reliably determine which messages are missing. This patch implements receiver for extended netconsole which accepts retransmission request packets coming into the the netconsole source port and sends back the requested messages. The receiving socket is aut

[PATCH 12/16] netconsole: implement extended console support

netconsole transmits raw console messages using one or multiple UDP packets and there's no way to find out whether the packets are lost in transit or received out of order. Depending on the setup, this can make the logging significantly unreliable and untrustworthy. With the new extended console

[PATCH 10/16] netconsole: introduce netconsole_mutex

console_lock protects the target_list itself and setting and clearing of its ->enabled flag; however, nothing protects the overall enable/disable operations which we'll need to make netconsole management more dynamic for the scheduled reliable transmission support. Also, an earlier patch introduce

[PATCH 05/16] printk: implement log_seq_range() and ext_log_from_seq()

Implement two functions to access log messages by their sequence numbers. * log_seq_range() determines the currently available sequence number range. * ext_log_from_seq() outputs log message identified by a given sequence number in the extended format. These will be used to implement reliabl

[PATCH 14/16] netconsole: implement ack handling and emergency transmission

While the retransmission support added by the previous patch goes a long way towards enabling implementation of reliable remote logger, it depends on a lot larger part of the kernel working and there's no non-polling way of discovering whether the latest messages have been lost. This patch impleme

[PATCH 08/16] netconsole: punt disabling to workqueue from netdevice_notifier

The netdevice_notifier callback, netconsole_netdev_event(), needs to perform netpoll_cleanup() for the affected targets; however, the notifier is called with rtnl_lock held which the netpoll_cleanup() path also grabs. To avoid deadlock, the path uses __netpoll_cleanup() instead and making the code

[PATCH 16/16] netconsole: update documentation for extended netconsole

Signed-off-by: Tejun Heo Cc: David Miller --- Documentation/networking/netconsole.txt | 95 - 1 file changed, 94 insertions(+), 1 deletion(-) diff --git a/Documentation/networking/netconsole.txt b/Documentation/networking/netconsole.txt index a5d574a..e7a57c2 10

[PATCH 07/16] netconsole: factor out alloc_netconsole_target()

alloc_param_target() and make_netconsole_target() were duplicating the same allocation and init logic. Factor it out to alloc_netconsole_target(). This is pure reorganization. Signed-off-by: Tejun Heo Cc: David Miller --- drivers/net/netconsole.c | 40

[PATCH 04/16] printk: implement support for extended console drivers

printk log_buf keeps various metadata for each message including its sequence number and timestamp. The metadata is currently available only through /dev/kmsg and stripped out before passed onto console drivers. We want this metadata to be available to console drivers too. Immediately, it's to i

[PATCH 15/16] netconsole: implement netconsole receiver library

This patch implements libncrx.a and a simple receiver program ncrx using the library. The library makes use of the extended header, retransmission and ack support to implement reliable netconsole receiver. The library is structured as a pure state machine leaving all IO and timing handling to the

[PATCH 09/16] netconsole: replace target_list_lock with console_lock

netconsole has been using a spinlock - target_list_lock - to protect the list of configured netconsole targets and their enable/disable states. With the disabling from netdevice_notifier moved off to a workqueue by the previous patch and thus outside of rtnl_lock, target_list_lock can be replaced

[PATCHSET] printk, netconsole: implement reliable netconsole

In a lot of configurations, netconsole is a useful way to collect system logs; however, all netconsole does is simply emitting UDP packets for the raw messages and there's no way for the receiver to find out whether the packets were lost and/or reordered in flight. printk already keeps log metadat

[PATCH 02/16] printk: factor out message formatting from devkmsg_read()

The extended message formatting used for /dev/kmsg will be used implement extended consoles. Factor out msg_print_ext_header() and msg_print_ext_body() from devkmsg_read(). This is pure restructuring. Signed-off-by: Tejun Heo Cc: Kay Sievers Cc: Petr Mladek --- kernel/printk/printk.c | 157 +

[PATCH 01/16] printk: guard the amount written per line by devkmsg_read()

devkmsg_read() uses 8k buffer and assumes that the formatted output message won't overrun which seems safe given LOG_LINE_MAX, the current use of dict and the escaping method being used; however, we're planning to use devkmsg formatting wider and accounting for the buffer size properly isn't that c

[PATCH 03/16] printk: move LOG_NOCONS skipping into call_console_drivers()

When a line is printed by multiple printk invocations, each chunk is directly sent out to console drivers so that they don't get lost. When the line is completed and stored in the log buffer, the line is suppressed from going out to consoles as that'd lead to duplicate outputs. This is tracked wit

Re: [PATCH 2/2] net: dsa: register hwmon for any provided function

Hi Guenter, > > switch (index) { > > +case 0: /* temp1_input */ > > +if (drv->get_temp) > > +mode |= S_IRUGO; > > This should be mandatory. Sorry, I don't really understand what you are > trying to accomplish here. > > Can you give me a re

[PATCH 1/1] altera tse: Fix network-delays and -retransmissions after high throughput.

From: Andreas Oetken Fix bug which occurs when more than packets are available during napi-poll, leading to "delays" and retransmissions on the network. Check for (count < limit) before checking the get_rx_status in tse_rx-function. Function get_rx_status is reading from the response-fifo. If t

Re: [PATCH 2/2] net: dsa: register hwmon for any provided function

On Thu, Apr 16, 2015 at 02:38:19PM -0400, Vivien Didelot wrote: > A switch driver may only provide one of the temperature limit accessors, > or the temperature alarm getter. So register the hwmon subsystem if any > of the related functions is provided. > > Thus, check get_temp to set the visibilit

Re: [PATCH 1/2] net: dsa: use DEVICE_ATTR_RW to declare temp1_max

On Thu, Apr 16, 2015 at 02:38:18PM -0400, Vivien Didelot wrote: > Since commit da4759c, sysfs will only use the permissions returned by > is_visible, instead of OR'ing them with the default file mode. > > This allows us to declare temp1_max with the DEVICE_ATTR_RW macro and > just return the desir

Re: [PATCH] ethtool: return 1 as exit code on a settings(-s) failure.

On Thu, 2015-04-16 at 13:55 -0700, Sridhar Samudrala wrote: > Currently 0 is returned on both success or failure. Previously discussed here: . Ben. > Signed-off-by: Sridhar Samudrala > --- > ethtool.c | 4 ++-- > 1 file changed, 2 insertions(

Re: [PATCH -next 0/3] net: cap size to original frag size when refragmenting

On 17.04, Herbert Xu wrote: > On Thu, Apr 16, 2015 at 06:13:25PM +0200, Hannes Frederic Sowa wrote: > > > > So currently we have one fast path, that is: we are not fragmented, we > > get out non-fragmented, none of this code is ever touched and no > > problem. > > > > We don't want to mak this mor

Re: [PATCH -next 0/3] net: cap size to original frag size when refragmenting

On 16.04, David Miller wrote: > > Netfilter may change the contents of the packet, even change its size. > > It is *really* hard to do this while keeping the original fragments > > intact. > > I keep hearing a lot of "it's hard" as the only reason we shouldn't do > this properly, and that frankly

[PATCH] ethtool: return 1 as exit code on a settings(-s) failure.

Currently 0 is returned on both success or failure. Signed-off-by: Sridhar Samudrala --- ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ethtool.c b/ethtool.c index 01b13a6..163dff2 100644 --- a/ethtool.c +++ b/ethtool.c @@ -2352,7 +2352,7 @@ static int do_sset(

Re: [PATCH -next 0/3] net: cap size to original frag size when refragmenting

On Thu, Apr 16, 2015 at 06:13:25PM +0200, Hannes Frederic Sowa wrote: > > So currently we have one fast path, that is: we are not fragmented, we > get out non-fragmented, none of this code is ever touched and no > problem. > > We don't want to mak this more complex, but You should read Dave's oth

Re: [PATCH] Bluetooth: Pre-initialize variables in read_local_oob_ext_data_complete()

Hi Geert, > net/bluetooth/mgmt.c: In function ‘read_local_oob_ext_data_complete’: > net/bluetooth/mgmt.c:6474: warning: ‘r256’ may be used uninitialized in this > function > net/bluetooth/mgmt.c:6474: warning: ‘h256’ may be used uninitialized in this > function > net/bluetooth/mgmt.c:6474: warni

Re: [PATCH -next 0/3] net: cap size to original frag size when refragmenting

Am 16. April 2015 17:43:23 MESZ, schrieb David Miller : >From: Hannes Frederic Sowa >Date: Thu, 16 Apr 2015 14:11:42 +0200 > >> On Thu, Apr 16, 2015, at 07:29, Herbert Xu wrote: >>> On Thu, Apr 16, 2015 at 06:24:00AM +0100, Patrick McHardy wrote: >>> > >>> > Netfilter may change the contents of th

Re: [PATCH] net: dsa: mv88e6xxx: Add missing initialization in mv88e6xxx_set_port_state()

From: Geert Uytterhoeven Date: Thu, 16 Apr 2015 20:49:14 +0200 > drivers/net/dsa/mv88e6xxx.c: In function ‘mv88e6xxx_set_port_state’: > drivers/net/dsa/mv88e6xxx.c:905: warning: ‘ret’ may be used uninitialized in > this function > > If oldstate == state, mv88e6xxx_set_port_state() will return a

[PATCH] Bluetooth: Pre-initialize variables in read_local_oob_ext_data_complete()

net/bluetooth/mgmt.c: In function ‘read_local_oob_ext_data_complete’: net/bluetooth/mgmt.c:6474: warning: ‘r256’ may be used uninitialized in this function net/bluetooth/mgmt.c:6474: warning: ‘h256’ may be used uninitialized in this function net/bluetooth/mgmt.c:6474: warning: ‘r192’ may be used

[PATCH iproute2 -next v2] tc: built-in eBPF exec proxy

This work follows upon commit 6256f8c9e45f ("tc, bpf: finalize eBPF support for cls and act front-end") and takes up the idea proposed by Hannes Frederic Sowa to spawn a shell (or any other command) that holds generated eBPF map file descriptors. File descriptors, based on their id, are being fetc

Re: [PATCH 1/2] net: dsa: use DEVICE_ATTR_RW to declare temp1_max

Hello Sergei, > > Since commit da4759c, sysfs will only use the permissions returned by > > Please also specify that commit's summary line in parens. Duly noted. da4759c is "sysfs: Use only return value from is_visible for the file mode" (see: https://git.kernel.org/cgit/linux/kernel/git/t

Re: [PATCH V1 net-next] IB/ipoib: Fix ndo_get_iflink

On Thu, Apr 16, 2015, Yann Droneaud wrote: > Hi, > > Le jeudi 16 avril 2015 à 16:34 +0300, Erez Shitrit a écrit : >> Currently, iflink of the parent interface was always accessed, even >> when interface didn't have a parent and hence we crashed there. > > + since commit 5aa7add8f14b ('infiniband/i

Re: [PATCH 1/2] net: dsa: use DEVICE_ATTR_RW to declare temp1_max

Hello. On 04/16/2015 09:38 PM, Vivien Didelot wrote: Since commit da4759c, sysfs will only use the permissions returned by Please also specify that commit's summary line in parens. is_visible, instead of OR'ing them with the default file mode. This allows us to declare temp1_max with

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

On Thu, Apr 16, 2015 at 01:18:37PM +0900, Hyong-Youb Kim wrote: > On Thu, Apr 16, 2015 at 01:58:16AM +0200, Luis R. Rodriguez wrote: > > > > An alternative... is to just ioremap_wc() the entire region, including > > MMIO registers for these old devices. I see one ethernet driver that does > > this

Re: [PATCH] dsa: mv88e6xxx: Fix error handling in mv88e6xxx_set_port_state

On Thu, Apr 16, 2015 at 3:46 PM, Guenter Roeck wrote: > On 04/15/2015 10:12 PM, Guenter Roeck wrote: >> >> Return correct error code if _mv88e6xxx_reg_read returns an error. >> >> Fixes: facd95b2e0ec0 ("net: dsa: mv88e6xxx: Add Hardware bridging >> support") >> Signed-off-by: Guenter Roeck > > >

[PATCH] net: dsa: mv88e6xxx: Add missing initialization in mv88e6xxx_set_port_state()

drivers/net/dsa/mv88e6xxx.c: In function ‘mv88e6xxx_set_port_state’: drivers/net/dsa/mv88e6xxx.c:905: warning: ‘ret’ may be used uninitialized in this function If oldstate == state, mv88e6xxx_set_port_state() will return an uninitialized value. Pre-initialize ret to zero to fix this. Signed-off-

[PATCH 2/2] net: dsa: register hwmon for any provided function

A switch driver may only provide one of the temperature limit accessors, or the temperature alarm getter. So register the hwmon subsystem if any of the related functions is provided. Thus, check get_temp to set the visibility of temp1_input. Signed-off-by: Vivien Didelot --- net/dsa/dsa.c | 7 +

[PATCH 1/2] net: dsa: use DEVICE_ATTR_RW to declare temp1_max

Since commit da4759c, sysfs will only use the permissions returned by is_visible, instead of OR'ing them with the default file mode. This allows us to declare temp1_max with the DEVICE_ATTR_RW macro and just return the desired permissions for the hwmon sysfs attributes in dsa_hwmon_attrs_visible.

Re: Revert "net: Reset secmark when scrubbing packet"

From: Herbert Xu Date: Thu, 16 Apr 2015 16:12:53 +0800 > On Thu, Apr 16, 2015 at 05:02:15PM +1000, James Morris wrote: >> >> They don't support namespaces, and maintaining the label is critical for >> SELinux, at least, which mediates security for the system as a whole. > > Thanks for the conf

Re: [v3] skbuff: Do not scrub skb mark within the same name space

From: Thomas Graf Date: Thu, 16 Apr 2015 09:33:35 +0100 > On 04/16/15 at 09:03am, Herbert Xu wrote: >> The commit ea23192e8e577dfc51e0f4fc5ca113af334edff9 ("tunnels: >> harmonize cleanup done on skb on rx path") broke anyone trying to >> use netfilter marking across IPv4 tunnels. While most of t

Re: [PATCH v3 1/1] stmmac: fix oops on rmmod after assigning ip addr

From: Bryan O'Donoghue Date: Thu, 16 Apr 2015 17:56:03 +0100 > An oops exists in the flow of stmmac_release(). > phy_ethtool_get_wol() depends on phydev->drv. > phydev->drv will be null after stmmac_mdio_unreg() completes. > > Steps to reproduce on Quark X1000: > > 1. ifconfig eth0 192.168.0.1

Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

From: Michael Chan Date: Thu, 16 Apr 2015 09:39:13 -0700 > On Thu, 2015-04-16 at 09:24 -0300, casca...@linux.vnet.ibm.com wrote: >> Yes, this looks like the driver is not syncing the DMA buffers. Unmap is >> supposed to synchronize as well. >> > > For small rx packets (< 256 bytes), we sync th

Re: [PATCH net] bpf: fix two bugs in verification logic when accessing 'ctx' pointer

From: Alexei Starovoitov Date: Wed, 15 Apr 2015 16:19:33 -0700 > 1. > first bug is a silly mistake. It broke tracing examples and prevented > simple bpf programs from loading. ... > 2. > second bug is more subtle. > If malicious code is using the same dest register as source register, > the chec

Re: [PATCH net 0/5] stmmac: Correct flow control configuration

From: Vince Bridgers Date: Wed, 15 Apr 2015 11:17:37 -0500 > This series of patches corrects flow control configuration for the Synopsys > GMAC driver. > > Flow control is configured based on a configurable receive fifo size. If > less than 4Kbytes flow control is left disabled and a warning is

Re: [PATCH net] bpf: fix bpf helpers to use skb->mac_header relative offsets

From: Alexei Starovoitov Date: Wed, 15 Apr 2015 12:55:45 -0700 > For the short-term solution, lets fix bpf helper functions to use > skb->mac_header relative offsets instead of skb->data in order to > get the same eBPF programs with cls_bpf and act_bpf work on ingress > and egress qdisc path. We

Re: [PATCH iproute2 -next] tc: built-in eBPF exec proxy

On 04/16/2015 07:48 PM, Alexei Starovoitov wrote: On 4/15/15 7:52 AM, Daniel Borkmann wrote: File descriptors, based on their id, are being fetched from the same unix domain socket as demonstrated in the bpf_agent, the shell spawned via execvpe(2) and the map fds passed over the environment, an

Re: [PATCH iproute2 -next] tc: built-in eBPF exec proxy

On 4/15/15 7:52 AM, Daniel Borkmann wrote: File descriptors, based on their id, are being fetched from the same unix domain socket as demonstrated in the bpf_agent, the shell spawned via execvpe(2) and the map fds passed over the environment, and thus are made available to applications in the fa

Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

Michael Chan writes ("Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]"): > On Thu, 2015-04-16 at 09:24 -0300, casca...@linux.vnet.ibm.com wrote: > > Yes, this looks like the driver is not syncing the DMA buffers. Unmap is > > supposed to synchronize as well. > > For small rx pac

Re: [PATCH V1 net-next] IB/ipoib: Fix ndo_get_iflink

Hi, Le jeudi 16 avril 2015 à 16:34 +0300, Erez Shitrit a écrit : > Currently, iflink of the parent interface was always accessed, even > when interface didn't have a parent and hence we crashed there. + since commit 5aa7add8f14b ('infiniband/ipoib: implement ndo_get_iflink'). as there was no cr

[PATCH v3 1/1] stmmac: fix oops on rmmod after assigning ip addr

An oops exists in the flow of stmmac_release(). phy_ethtool_get_wol() depends on phydev->drv. phydev->drv will be null after stmmac_mdio_unreg() completes. Steps to reproduce on Quark X1000: 1. ifconfig eth0 192.168.0.1 2. rmmod stmmac_pci To fix this stmmac_mdio_unreg() should be run after unre

[PATCH v3 0/1] stmmac: rmmod oops after ifconfig

We have an oops with stmmac on Quark X1000/Galileo, triggered by rmmod after ifconfig. Fix for issue contained in next mail against git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git root@clanton:~# ifconfig eth0 192.168.0.1 root@clanton:~# rmmod stmmac_pci [ 39.257871] stmmac_dvr_remo

Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

On Thu, 2015-04-16 at 09:24 -0300, casca...@linux.vnet.ibm.com wrote: > Yes, this looks like the driver is not syncing the DMA buffers. Unmap is > supposed to synchronize as well. > For small rx packets (< 256 bytes), we sync the DMA buffer before we copy the data to another SKB. For larger pac

Re: [PATCH v2 1/1] stmmac: fix oops on rmmod after assigning ip addr

From: Bryan O'Donoghue Date: Thu, 16 Apr 2015 17:20:50 +0100 > I'll spin again against : > https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/ Currently active tree is 'net', not 'net-next' -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: [PATCH stable 3.10-3.16] tcp: Fix crash in TCP Fast Open

On Wed, Apr 15, 2015 at 07:00:32PM +0100, Ben Hutchings wrote: > Commit 355a901e6cf1 ("tcp: make connect() mem charging friendly") > changed tcp_send_syn_data() to perform an open-coded copy of the 'syn' > skb rather than using skb_copy_expand(). > > The open-coded copy does not cover the skb_shar

Re: [PATCH v2 1/1] stmmac: fix oops on rmmod after assigning ip addr

On 16/04/15 17:07, David Miller wrote: This patch does not apply to the current tree, please respin. /facepalm Did this against : https://github.com/torvalds/linux.git I'll spin again against : https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/ -- To unsubscribe from this list

Re: [PATCH] dsa: mv88e6xxx: Drop duplicate declaration of 'ret' variable

From: Guenter Roeck Date: Thu, 16 Apr 2015 06:49:50 -0700 > A duplicate declaration of 'ret' can result in hiding an error code. > Drop it. > > Fixes: 17ee3e04ddbf ("net: dsa: Provide additional RMON statistics") > Signed-off-by: Guenter Roeck Applied, thank you. -- To unsubscribe from this li

Re: [PATCH -next] ethernet: remove unused including

From: weiyj...@163.com Date: Thu, 16 Apr 2015 21:06:47 +0800 > From: Wei Yongjun > > Remove including that don't need it. > > Signed-off-by: Wei Yongjun Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCH -next] netns: remove duplicated include from net_namespace.c

From: weiyj...@163.com Date: Thu, 16 Apr 2015 21:17:35 +0800 > From: Wei Yongjun > > Remove duplicated include. > > Signed-off-by: Wei Yongjun Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH -next 0/3] net: cap size to original frag size when refragmenting

Hi David, On Thu, Apr 16, 2015, at 17:43, David Miller wrote: > From: Hannes Frederic Sowa > Date: Thu, 16 Apr 2015 14:11:42 +0200 > > > On Thu, Apr 16, 2015, at 07:29, Herbert Xu wrote: > >> On Thu, Apr 16, 2015 at 06:24:00AM +0100, Patrick McHardy wrote: > >> > > >> > Netfilter may change the

Re: [PATCH] dsa: mv88e6xxx: Fix error handling in mv88e6xxx_set_port_state

From: Guenter Roeck Date: Wed, 15 Apr 2015 22:12:42 -0700 > Return correct error code if _mv88e6xxx_reg_read returns an error. > > Fixes: facd95b2e0ec0 ("net: dsa: mv88e6xxx: Add Hardware bridging support") > Signed-off-by: Guenter Roeck Applied, thanks. -- To unsubscribe from this list: send

Re: [PATCH] rocker: fix error return code in rocker_probe()

From: weiyj...@163.com Date: Thu, 16 Apr 2015 20:21:02 +0800 > From: Wei Yongjun > > Fix to return -EINVAL from the invalid PCI region size error > handling case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Applied. -- To unsubscribe from this list: send th

Re: [PATCH V1 net-next] IB/ipoib: Fix ndo_get_iflink

On Thu, Apr 16, 2015 at 04:34:34PM +0300, Erez Shitrit wrote: > Currently, iflink of the parent interface was always accessed, even > when interface didn't have a parent and hence we crashed there. > > Handle the interface types properly: for a child interface, return > the ifindex of the parent,

Re: [PATCH -next] fou: Fix missing unlock on error in fou_nl_dump()

From: weiyj...@163.com Date: Thu, 16 Apr 2015 20:14:39 +0800 > From: Wei Yongjun > > Add the missing unlock before return from function fou_nl_dump() > in the error handling case. > > Fixes: 7a6c8c34e5b7 (fou: implement FOU_CMD_GET) > Signed-off-by: Wei Yongjun Your patch adds a warning becau

Re: [Patch net-next v2] fou: avoid missing unlock in failure path

From: Cong Wang Date: Wed, 15 Apr 2015 11:48:49 -0700 > Fixes: 7a6c8c34e5b7 ("fou: implement FOU_CMD_GET") > Reported-by: Dan Carpenter > Cc: Dan Carpenter > Signed-off-by: Cong Wang Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: [PATCH v2 1/1] stmmac: fix oops on rmmod after assigning ip addr

From: Bryan O'Donoghue Date: Wed, 15 Apr 2015 02:07:46 +0100 > An oops exists in the flow of stmmac_release(). > phy_ethtool_get_wol() depends on phydev->drv. > phydev->drv will be null after stmmac_mdio_unreg() completes. > > Steps to reproduce on Quark X1000: > > 1. ifconfig eth0 192.168.0.1

Re: [PATCH net] bpf: fix verifier memory corruption

From: Alexei Starovoitov Date: Tue, 14 Apr 2015 15:57:13 -0700 > Due to missing bounds check the DAG pass of the BPF verifier can corrupt > the memory which can cause random crashes during program loading: > > [8.449451] BUG: unable to handle kernel paging request at > [8.451293

Re: [patch 31/39] net: core: pktgen: Remove bogus hrtimer_active() check

From: Thomas Gleixner Date: Tue, 14 Apr 2015 21:09:16 - > The check for hrtimer_active() after starting the timer is > pointless. If the timer is inactive it has expired already and > therefor the task pointer is already NULL. > > Signed-off-by: Thomas Gleixner Acked-by: David S. Miller -

Re: [patch 03/39] net: sched: Use hrtimer_resolution instead of hrtimer_get_res()

From: Thomas Gleixner Date: Tue, 14 Apr 2015 21:08:28 - > No point in converting a timespec now that the value is directly > accessible. > > Signed-off-by: Thomas Gleixner Acked-by: David S. Miller -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messa

Re: [patch 1/1] cxgb4: drop __GFP_NOFAIL allocation

From: a...@linux-foundation.org Date: Tue, 14 Apr 2015 13:24:33 -0700 > From: Michal Hocko > Subject: cxgb4: drop __GFP_NOFAIL allocation > > set_filter_wr is requesting __GFP_NOFAIL allocation although it can return > ENOMEM without any problems obviously (t4_l2t_set_switching does that > alrea

Re: [PATCH 1/1] altera tse: Fix network-delays and -retransmissions after high throughput.

From: Andreas Oetken Date: Tue, 14 Apr 2015 22:25:26 +0200 > From: Andreas Oetken > > Fix bug which occurs when more than packets are available during > napi-poll, > leading to "delays" and retransmissions on the network. > > Check for (count < limit) before checking the get_rx_status in >

Re: [PATCH -next 0/3] net: cap size to original frag size when refragmenting

From: Hannes Frederic Sowa Date: Thu, 16 Apr 2015 14:11:42 +0200 > On Thu, Apr 16, 2015, at 07:29, Herbert Xu wrote: >> On Thu, Apr 16, 2015 at 06:24:00AM +0100, Patrick McHardy wrote: >> > >> > Netfilter may change the contents of the packet, even change its size. >> > It is *really* hard to do

Re: [PATCH] netns: deinline net_generic()

From: Denys Vlasenko Date: Thu, 16 Apr 2015 13:14:14 +0200 > It would help if you tell me how I should change the patches. Why ask Eric when I told you exactly how to change the patch to make it acceptable, so please do so. -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH -next 0/3] net: cap size to original frag size when refragmenting

From: Patrick McHardy Date: Thu, 16 Apr 2015 06:24:00 +0100 > On 16.04, Herbert Xu wrote: >> David Miller wrote: >> > >> > Because then there is no ambiguity at all, you preserve on output >> > exactly what you had on input. The same geometry, the same >> > everything. No special checks, no m

Re: [PATCH -next] netns: remove duplicated include from net_namespace.c

Le 16/04/2015 15:17, weiyj...@163.com a écrit : From: Wei Yongjun Remove duplicated include. Signed-off-by: Wei Yongjun Acked-by: Nicolas Dichtel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH] dsa: mv88e6xxx: Drop duplicate declaration of 'ret' variable

A duplicate declaration of 'ret' can result in hiding an error code. Drop it. Fixes: 17ee3e04ddbf ("net: dsa: Provide additional RMON statistics") Signed-off-by: Guenter Roeck --- Found by compiling the file with W=2. drivers/net/dsa/mv88e6xxx.c | 2 -- 1 file changed, 2 deletions(-) diff --gi

Re: [PATCH] dsa: mv88e6xxx: Fix error handling in mv88e6xxx_set_port_state

On 04/15/2015 10:12 PM, Guenter Roeck wrote: Return correct error code if _mv88e6xxx_reg_read returns an error. Fixes: facd95b2e0ec0 ("net: dsa: mv88e6xxx: Add Hardware bridging support") Signed-off-by: Guenter Roeck I should have given proper credit. Reported-by: kbuild test robot For the

Re: [Xen-devel] "tcp: refine TSO autosizing" causes performance regression on Xen

At 12:39 +0100 on 16 Apr (1429187952), George Dunlap wrote: > Your comment lists three benefits: > 1. better RTT estimation > 2. faster recovery > 3. high rates > > #3 is just marketing fluff; it's also contradicted by the statement that > immediately follows it -- i.e., there are drivers for whic

[PATCH V1 net-next] IB/ipoib: Fix ndo_get_iflink

Currently, iflink of the parent interface was always accessed, even when interface didn't have a parent and hence we crashed there. Handle the interface types properly: for a child interface, return the ifindex of the parent, for parent interface, return its ifindex. For child devices, make sure

[PATCH net-next] IB/ipoib: Fix ndo_get_iflink

Currently, iflink of the parent interface was always accessed, event when interface didn't have a parent and hence we rashed there. Handle the interface types properly: for a child interface, return the ifindex of the parent, for parent interface, return its ifindex. For child devices, make sure

Re: [PATCH] hso: fix refcnt leak in recent patch.

On Tue, Apr 14, 2015 at 11:03:03AM +1000, NeilBrown wrote: > On Tue, 14 Apr 2015 09:36:34 +1000 NeilBrown wrote: > > > > > > > Prior to > > commit 29bd3bc1194c624ce863cab2a7da9bc1f0c3b47b > > hso: fix crash when device disappears while serial port is open > > > > hso_serial_open would alwa

[PATCH -next] netns: remove duplicated include from net_namespace.c

From: Wei Yongjun Remove duplicated include. Signed-off-by: Wei Yongjun --- net/core/net_namespace.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index e5e96b0..9c43cf6 100644 --- a/net/core/net_namespace.c +++ b/net/core/net_namespace.

[PATCH -next] ethernet: remove unused including

From: Wei Yongjun Remove including that don't need it. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/qualcomm/qca_spi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index 4a42e96..f66641d 100644 ---

Re: [PATCH] dsa: mv88e6xxx: Fix error handling in mv88e6xxx_set_port_state

On 04/16/2015 05:37 AM, Andrew Lunn wrote: On Wed, Apr 15, 2015 at 10:12:42PM -0700, Guenter Roeck wrote: Return correct error code if _mv88e6xxx_reg_read returns an error. Fixes: facd95b2e0ec0 ("net: dsa: mv88e6xxx: Add Hardware bridging support") Signed-off-by: Guenter Roeck Hi Guenter Go

Re: [PATCH] rocker: fix error return code in rocker_probe()

Thu, Apr 16, 2015 at 02:21:02PM CEST, weiyj...@163.com wrote: >From: Wei Yongjun > >Fix to return -EINVAL from the invalid PCI region size error >handling case instead of 0, as done elsewhere in this function. > >Signed-off-by: Wei Yongjun Good catch. Acked-by: Jiri Pirko -- To unsubscribe fr

Re: [Xen-devel] "tcp: refine TSO autosizing" causes performance regression on Xen

On Thu, 2015-04-16 at 11:01 +0100, George Dunlap wrote: > He suggested that after he'd been prodded by 4 more e-mails in which two > of us guessed what he was trying to get at. That's what I was > complaining about. My big complain is that I suggested to test to double the sysctl, which gave goo

Re: [PATCH] dsa: mv88e6xxx: Fix error handling in mv88e6xxx_set_port_state

On Wed, Apr 15, 2015 at 10:12:42PM -0700, Guenter Roeck wrote: > Return correct error code if _mv88e6xxx_reg_read returns an error. > > Fixes: facd95b2e0ec0 ("net: dsa: mv88e6xxx: Add Hardware bridging support") > Signed-off-by: Guenter Roeck Hi Guenter Good catch. I'm surprised there is no com

  1   2   >