On Thu, Apr 16, 2015 at 06:34:02PM -0700, Alexei Starovoitov wrote:
> On Fri, Apr 17, 2015 at 09:02:16AM +0800, Herbert Xu wrote:
> > @@ -105,7 +105,7 @@ static void ri_tasklet(unsigned long dev)
> >             if (from & AT_EGRESS) {
> >                     dev_queue_xmit(skb);
> >             } else if (from & AT_INGRESS) {
> > -                   skb_pull(skb, skb->dev->hard_header_len);
> > +                   skb_pull(skb, _dev->hard_header_len);
> ...
> >     if (!(at & AT_EGRESS)) {
> >             if (m->tcfm_ok_push)
> > -                   skb_push(skb2, skb2->dev->hard_header_len);
> > +                   skb_push(skb2, dev->hard_header_len);
> 
> seems the cleaner fix will be to push skb->mac_len instead?

No skb->mac_len is the same as skb2->dev->hard_header_len.

Cheers,
-- 
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to