Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x

2008-02-25 Thread Grant Grundler
On Mon, Feb 25, 2008 at 02:30:00AM -0500, Jeff Garzik wrote: > Grant Grundler wrote: >> On Mon, Feb 18, 2008 at 05:40:42PM +0100, Ondrej Zary wrote: >>> I think that de2104x driver should be removed (or at least its >>> MODULE_DEVICE_TABLE) and MODULE_DEVICE_TABLE with only 21040 and 21041 >>> PC

Re: [PATCH] Don't limit the number of tunnels with generic name explicitly.

2008-02-25 Thread Pavel Emelyanov
David Miller wrote: > From: Pavel Emelyanov <[EMAIL PROTECTED]> > Date: Thu, 21 Feb 2008 15:38:16 +0300 > >> Changelog: >> >> Use the added dev_alloc_name() call to create tunnel device name, >> rather than iterate in a hand-made loop with an artificial limit. >> >> Thanks Patrick for noticing thi

Re: [PATCH] Can not send icmp netunreach packet

2008-02-25 Thread Jarek Poplawski
On 26-02-2008 07:34, Li Yewang wrote: > Hi All > >There is a bug about icmp netunreach. >If the kernel does not find a route for a packet, >it must send a icmp netunreach packet to the source host, >and discard the packet. But the kernel does not send >a icmp netunreach

Re: [PATCH] llc: dont trust payload size on test cmd

2008-02-25 Thread Joonwoo Park
On Mon, Feb 25, 2008 at 08:14:39AM -0800, Jim Westfall wrote: > Hi > > In testing its not safe to trust the payload length we are given in a > received llc test command header. Instead we should calculate this > ourselves or run the risk of an skb_over_panic() if the received length in > the he

Re: [PATCH] llc: fix skb size for test responses

2008-02-25 Thread Joonwoo Park
On Sun, Feb 24, 2008 at 11:07:58AM -0800, Jim Westfall wrote: > Hi > > The llc test command is used for a layer2 ping and contains a variable > length payload that we must include in the response. Use the size of the > received skb as the size of the skb we must allocate to hold the payload. >

Re: [patch 2.6.25-rc2-git] rndis_host: fix transfer size negotiation

2008-02-25 Thread Jussi Kivilinna
On Mon, 2008-02-25 at 13:29 -0500, John W. Linville wrote: > On Fri, Feb 22, 2008 at 05:31:16PM -0800, David Brownell wrote: > > From: Jean-Christophe Dubois <[EMAIL PROTECTED]> > > > > This patch should resolve a problem that's troubled support for > > some RNDIS peripherals. It seems to have bo

[PATCH] Can not send icmp netunreach packet

2008-02-25 Thread Li Yewang
Hi All There is a bug about icmp netunreach. If the kernel does not find a route for a packet, it must send a icmp netunreach packet to the source host, and discard the packet. But the kernel does not send a icmp netunreach packet because of the fib_lookup return value o

Re: [PATCH 00/28] Swap over NFS -v16

2008-02-25 Thread Neil Brown
On Saturday February 23, [EMAIL PROTECTED] wrote: > On Wed, 20 Feb 2008 15:46:10 +0100 Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > > Another posting of the full swap over NFS series. > > Well I looked. There's rather a lot of it and I wouldn't pretend to > understand it. But pretending is fu

Re: [Bluez-devel] forcing SCO connection patch

2008-02-25 Thread Louis JANG
Hi Marcel >> --- linux-2.6.23/net/bluetooth/hci_event.c.orig 2008-02-25 >> 17:17:11.0 +0900 >> +++ linux-2.6.23/net/bluetooth/hci_event.c 2008-02-25 >> 17:30:23.0 +0900 >> @@ -1313,8 +1313,17 @@ >> hci_dev_lock(hdev); >> >> conn = hci_conn_hash_lookup_ba(hdev, ev->link_type, &ev->

Re: [Bluez-devel] forcing SCO connection patch

2008-02-25 Thread Marcel Holtmann
Hi Louis, I fixed all of errors except 80 characters warning. Thanks Louis JANG Signed-off-by: Louis JANG <[EMAIL PROTECTED]> --- linux-2.6.23/net/bluetooth/hci_event.c.orig 2008-02-25 17:17:11.0 +0900 +++ linux-2.6.23/net/bluetooth/hci_event.c 2008-02-25 17:30:23.0 +0900

Get loan from xaio loan company........Apply now!!!

2008-02-25 Thread XAIO LOAN COMPANY
You can quickly qualify for a personal loan. We have come up with the resources that offer flexible plans to meet ones life goal. We offer some of the most flexible finance programs on the Internet. The procedure to apply for this type of financing is safe and simple, documentation is minimal

Re: [Netem] Fixed delay patch for netem

2008-02-25 Thread Stephen Hemminger
On Sun, 24 Feb 2008 12:11:16 -0200 "Julio Kriger" <[EMAIL PROTECTED]> wrote: > Hi! > I have created this patch to add a fixed delay on packet filtered by > netem. Soon I will send the patch to iproute2. > This patch comes from a need I have to delay all packets 50ms, beside > the actual delay sett

Re: [Bugme-new] [Bug 10073] New: Just-small-enough packets in tunnels are silently eaten

2008-02-25 Thread Andrew Morton
On Sat, 23 Feb 2008 09:17:14 -0800 (PST) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=10073 > >Summary: Just-small-enough packets in tunnels are silently eaten >Product: Networking >Version: 2.5 > KernelVersion: 2.6.23 (mainline),

Re: [git patches] net driver updates

2008-02-25 Thread Jeff Garzik
Divy Le Ray wrote: So, it sounds like Krishna's patch is ok, because the race does not exist anymore in this driver? The first part is right indeed, but the second part is breaking the current usage of txq_stopped and the logic that stops and restarts the Tx queue. I can submit a patch fixi

Re: [git patches] net driver updates

2008-02-25 Thread Divy Le Ray
So, it sounds like Krishna's patch is ok, because the race does not exist anymore in this driver? The first part is right indeed, but the second part is breaking the current usage of txq_stopped and the logic that stops and restarts the Tx queue. I can submit a patch fixing it. Plese let me

Re: printk_ratelimit and net_ratelimit conflict and tunable behavior

2008-02-25 Thread Andrew Morton
On Mon, 25 Feb 2008 14:36:40 -0600 Steven Hawkes <[EMAIL PROTECTED]> wrote: > From: Steve Hawkes <[EMAIL PROTECTED]> > > The printk_ratelimit() and net_ratelimit() functions each have their own > tunable parameters to control their respective rate limiting feature, but > they share common state v

Re: [git patches] net driver updates

2008-02-25 Thread Jeff Garzik
Marin Mitov wrote: On Tuesday 26 February 2008 12:59:04 am you wrote: Divy Le Ray wrote: From: "Divy Le Ray" <[EMAIL PROTECTED]> Date: Wed, 20 Feb 2008 21:57:08 -0800 The driver is cxgb3 here, it uses LLTX. That's extremely unfortunate, hopefully you can update it to use a model like tg3 and

Re: [git patches] net driver updates

2008-02-25 Thread Jeff Garzik
Divy Le Ray wrote: From: "Divy Le Ray" <[EMAIL PROTECTED]> Date: Wed, 20 Feb 2008 21:57:08 -0800 The driver is cxgb3 here, it uses LLTX. That's extremely unfortunate, hopefully you can update it to use a model like tg3 and others use. LLTX is a lost cause for hardware device drivers, and in f

Re: [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Shift calculation wrong for single sge entries.

2008-02-25 Thread Roland Dreier
Thanks, applied, although I assume based on the Signed-off-by line that you left out a From: Bryan Rosenburg <[EMAIL PROTECTED]> at the top (to get the authorship in git correctly). > RDMA/cxgb3: Shift calculation wrong for single sge entries. BTW, there's no need to duplicate the subject li

r8169 driver compatibility with rtl8168 [need confirm]

2008-02-25 Thread Miroslav Kratochvil
Hi, Many users who have onboard Realtek 8168 network controllers in combination with nVidia hardware (mostly nVidia graphic card and/or nForce motherboard (MCP5x) ) experience still-not-very-explained hangup triggered by heavy network usage which fills a tx buffer, and (speculation) causes race con

Re: [Bugme-new] [Bug 10071] New: kernel hang in inet_init

2008-02-25 Thread Andrew Morton
On Sat, 23 Feb 2008 00:34:06 -0800 (PST) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=10071 > >Summary: kernel hang in inet_init >Product: Networking >Version: 2.5 > KernelVersion: 2.6.25 rc2 latest git > Platform: All >

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-25 Thread Jarek Poplawski
Jarek Poplawski wrote, On 02/25/2008 02:39 PM: ... > Hmm... Wait a minute! But on the other hand David has written about > his cons here, and it looks reasonable: this place would be fixed, > but some others can start reports like this. Maybe, it's better to > analyze yet if it's really so hard to

Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x

2008-02-25 Thread Ondrej Zary
On Monday 25 February 2008 08:28:14 Jeff Garzik wrote: > Grant Grundler wrote: > > ISTR there was a time when tulip would compete with de4x5 for devices. > > tulip is the preferred driver. That's clearly no longer the case > > and perhaps both distro's need to revisit this. > > The only reason why

Re: [patch 2.6.25-rc2-git] rndis_host: fix transfer size negotiation

2008-02-25 Thread David Brownell
> > This patch should resolve a problem that's troubled support for > > some RNDIS peripherals. It seems to have boiled down to using a > > variable to establish transfer size limits before it was assigned, > > which caused those devices to fallback to a default "jumbogram" > > mode we don't suppo

printk_ratelimit and net_ratelimit conflict and tunable behavior

2008-02-25 Thread Steven Hawkes
From: Steve Hawkes <[EMAIL PROTECTED]> The printk_ratelimit() and net_ratelimit() functions each have their own tunable parameters to control their respective rate limiting feature, but they share common state variables, preventing independent tuning of the parameters from working correctly. Also,

Re: [PATCH] [XFRM] Beet: Fix output for ipv6

2008-02-25 Thread Joakim Koskela
Hi Herbert, Have you had a chance to look this, or are you working on something else for it? On Friday 08 February 2008 18:12, Joakim Koskela wrote: > Hi, > > This patch fixes the ipv6 mode of ipsec beet. It has been using logic > similar to tunnel mode, making it crash during esp packaging. >

Re: New sparse warning in net/mac80211/debugfs_sta.c

2008-02-25 Thread David Miller
From: Johannes Berg <[EMAIL PROTECTED]> Date: Mon, 25 Feb 2008 21:05:42 +0100 > > On Mon, 2008-02-25 at 20:56 +0100, Johannes Berg wrote: > > On Mon, 2008-02-25 at 11:52 -0800, David Miller wrote: > > > From: Johannes Berg <[EMAIL PROTECTED]> > > > Date: Mon, 25 Feb 2008 10:53:48 +0100 > > > > >

RE: printk_ratelimit and net_ratelimit conflict and tunable behavior

2008-02-25 Thread Joe Perches
On Mon, 2008-02-25 at 09:47 -0600, Hawkes Steve-FSH016 wrote: > How about this? line wrapped, but seems better. > Signed-off-by: Steve Hawkes <[EMAIL PROTECTED]> > > diff -uprN linux-2.6.24/include/linux/kernel.h > linux-2.6.24-printk_ratelimit/include/linux/kernel.h > --- linux-2.6.24/include/

Re: [patch 2.6.25-rc3] smc91x section fix

2008-02-25 Thread Sam Ravnborg
On Sun, Feb 24, 2008 at 10:33:12PM -0800, David Brownell wrote: > On Sunday 24 February 2008, Sam Ravnborg wrote: > > > From a quick look this is wrong. > > smc_drv_probe is assined the .probe member so it is used during > > hotplug and thus should be __devinit. > > Likewise smc_probe is used by s

Re: New sparse warning in net/mac80211/debugfs_sta.c

2008-02-25 Thread David Miller
From: Johannes Berg <[EMAIL PROTECTED]> Date: Mon, 25 Feb 2008 20:56:43 +0100 > > On Mon, 2008-02-25 at 11:52 -0800, David Miller wrote: > > From: Johannes Berg <[EMAIL PROTECTED]> > > Date: Mon, 25 Feb 2008 10:53:48 +0100 > > > > > Maybe we should just add a new printf modifier like %M for MAC

Re: New sparse warning in net/mac80211/debugfs_sta.c

2008-02-25 Thread Johannes Berg
On Mon, 2008-02-25 at 20:56 +0100, Johannes Berg wrote: > On Mon, 2008-02-25 at 11:52 -0800, David Miller wrote: > > From: Johannes Berg <[EMAIL PROTECTED]> > > Date: Mon, 25 Feb 2008 10:53:48 +0100 > > > > > Maybe we should just add a new printf modifier like %M for MAC > > > addresses? Then we

Re: printk_ratelimit and net_ratelimit conflict and tunable behavior

2008-02-25 Thread David Miller
From: "Hawkes Steve-FSH016" <[EMAIL PROTECTED]> Date: Mon, 25 Feb 2008 09:47:11 -0600 > > .facility = NULL > > How about this? Actually, for compile time initializations, setting anything to zero is superfluous and by convention is not therefore explicitly done in the sources. -- To unsubscribe

Re: New sparse warning in net/mac80211/debugfs_sta.c

2008-02-25 Thread Joe Perches
On Mon, 2008-02-25 at 12:47 +0100, Patrick McHardy wrote: > It would be good if Joe could go through the remaining print_mac users > and convert the remaining unintended function calls in fastpaths back > to MAC_FMT. Grepping for "start_xmit" in commit 0795af5729b shows that > at least 10 hard_sta

Re: New sparse warning in net/mac80211/debugfs_sta.c

2008-02-25 Thread Johannes Berg
On Mon, 2008-02-25 at 11:52 -0800, David Miller wrote: > From: Johannes Berg <[EMAIL PROTECTED]> > Date: Mon, 25 Feb 2008 10:53:48 +0100 > > > Maybe we should just add a new printf modifier like %M for MAC > > addresses? Then we could use sprintf, snprintf, printk and whatever we > > please witho

Re: New sparse warning in net/mac80211/debugfs_sta.c

2008-02-25 Thread David Miller
From: Johannes Berg <[EMAIL PROTECTED]> Date: Mon, 25 Feb 2008 10:53:48 +0100 > Maybe we should just add a new printf modifier like %M for MAC > addresses? Then we could use sprintf, snprintf, printk and whatever we > please without any of the macro stuff... But GCC has no idea what the heck it i

Re: [PATCH] llc: fix skb size for test responses

2008-02-25 Thread David Miller
From: Jim Westfall <[EMAIL PROTECTED]> Date: Sun, 24 Feb 2008 21:04:21 -0800 > I sent it a few minutes after this one, but seems like it never made it > to the list. My local smtp shows it was delivered sucussfully to > vger.kernel.org. Usually this means some string in the email triggered our

problems with e1000 and flow control

2008-02-25 Thread Wolfgang Walter
Hello, it seems that e1000 enables flow-control (rx pause frames) even if the switch does not advertise flow control. This seems to get a problem as (at least some) switches then forward pause frames directed to the card from other hosts. We think there are hosts which indeed do this in the lan

Re: [PATCH RESEND] libertas: Remove unused exports

2008-02-25 Thread Dan Williams
On Sat, 2008-02-23 at 20:10 -0800, Roland Dreier wrote: > Any chance of getting this applied? It seems the build is still > broken on ia64 at least due to the export of static functions. > --- Normal route is to [EMAIL PROTECTED] However; if the symbols aren't used anywhere in drivers/net/wirele

Re: [Bugme-new] [Bug 10097] New: SMP BUG in __nf_conntrack_find

2008-02-25 Thread Andrew Morton
On Mon, 25 Feb 2008 10:44:08 -0800 (PST) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=10097 > >Summary: SMP BUG in __nf_conntrack_find >Product: Networking >Version: 2.5 > KernelVersion: 2.6.25-rc3 > Platform: All >

Re: [patch 2.6.25-rc2-git] rndis_host: fix transfer size negotiation

2008-02-25 Thread Johannes Berg
On Mon, 2008-02-25 at 13:29 -0500, John W. Linville wrote: > On Fri, Feb 22, 2008 at 05:31:16PM -0800, David Brownell wrote: > > From: Jean-Christophe Dubois <[EMAIL PROTECTED]> > > > > This patch should resolve a problem that's troubled support for > > some RNDIS peripherals. It seems to have b

Re: [patch 2.6.25-rc2-git] rndis_host: fix transfer size negotiation

2008-02-25 Thread John W. Linville
On Fri, Feb 22, 2008 at 05:31:16PM -0800, David Brownell wrote: > From: Jean-Christophe Dubois <[EMAIL PROTECTED]> > > This patch should resolve a problem that's troubled support for > some RNDIS peripherals. It seems to have boiled down to using a > variable to establish transfer size limits bef

Re: [RFC] ethtool netlink interface

2008-02-25 Thread Thomas Graf
* Jeff Garzik <[EMAIL PROTECTED]> 2008-02-25 12:30 > However, I would think it inconsistent to only do SSET/GSET. If others > are OK with this patch, are you open to implementing the full set of > ethtool operations? Of course, I would also provide a documented userspace api within libnl. -- To

Re: [PATCH] de2104x: remove BUG_ON() when changing media type

2008-02-25 Thread Jeff Garzik
Ondrej Zary wrote: When the chip dies (probably because of a bug somewhere in the driver), de_stop_rxtx() fails and changing the media type crashes the whole machine. Replace BUG_ON() in de_set_media() with a warning. Signed-off-by: Ondrej Zary <[EMAIL PROTECTED]> --- linux-2.6.24-orig/driver

[PATCH] de2104x: remove BUG_ON() when changing media type

2008-02-25 Thread Ondrej Zary
When the chip dies (probably because of a bug somewhere in the driver), de_stop_rxtx() fails and changing the media type crashes the whole machine. Replace BUG_ON() in de_set_media() with a warning. Signed-off-by: Ondrej Zary <[EMAIL PROTECTED]> --- linux-2.6.24-orig/drivers/net/tulip/de2104x.c

Re: [RFC] ethtool netlink interface

2008-02-25 Thread Jeff Garzik
Thomas Graf wrote: Hello, Before I continue to finish this work I'd like to get a few comments on my implementation attempt. The following patch implements the ETHTOOL_SSET and ETHTOOL_GSET command via netlink. The individual commands are implemented as separate functions and hooked into a tabl

Re: New sparse warning in net/mac80211/debugfs_sta.c

2008-02-25 Thread Johannes Berg
> > Maybe we should just add a new printf modifier like %M for MAC > > addresses? Then we could use sprintf, snprintf, printk and whatever we > > please without any of the macro stuff... > > Could gcc validate the printf %M arguments? No, but it won't barf on it either, it silently ignores unkno

Re: New sparse warning in net/mac80211/debugfs_sta.c

2008-02-25 Thread Johannes Berg
On Mon, 2008-02-25 at 10:53 +0100, Johannes Berg wrote: > On Sat, 2008-02-23 at 20:02 -0800, David Miller wrote: > > From: Patrick McHardy <[EMAIL PROTECTED]> > > Date: Thu, 21 Feb 2008 19:00:03 +0100 > > > > > And adds back the overhead of two completely unnecessary > > > function calls to the V

Re: New sparse warning in net/mac80211/debugfs_sta.c

2008-02-25 Thread Joe Perches
On Mon, 2008-02-25 at 10:53 +0100, Johannes Berg wrote: > Maybe we should just add a new printf modifier like %M for MAC > addresses? Then we could use sprintf, snprintf, printk and whatever we > please without any of the macro stuff... Could gcc validate the printf %M arguments? Another possibil

[PATCH] llc: dont trust payload size on test cmd

2008-02-25 Thread Jim Westfall
Hi In testing its not safe to trust the payload length we are given in a received llc test command header. Instead we should calculate this ourselves or run the risk of an skb_over_panic() if the received length in the header is > then the actual payload size. Signed-off-by: Jim Westfall <[EMA

Re: [PATCH] tg3: ethtool phys_id default (rev2)

2008-02-25 Thread Eliezer Tamir
> > Doesn't this mean that ethtool -p will hold the RTNL lock forever? > > Is this a good idea? > > > > For example on the Red Hat machine I have here if you do: > > > > ethtool -p eth2 10 & > > reboot > > > > Various things the shutdown scripts try to do will fail because of the > > held RT

Re: [PATCH] tg3: ethtool phys_id default (rev2)

2008-02-25 Thread Stephen Hemminger
On Sun, 24 Feb 2008 07:42:06 +0200 "Eliezer Tamir" <[EMAIL PROTECTED]> wrote: > > On Sat, 2008-02-23 at 19:52 -0800, David Miller wrote: > > From: "Michael Chan" <[EMAIL PROTECTED]> > > Date: Fri, 22 Feb 2008 11:16:42 -0800 > > > > > On Fri, 2008-02-22 at 10:24 -0800, Stephen Hemminger wrote: >

RE: printk_ratelimit and net_ratelimit conflict and tunable behavior

2008-02-25 Thread Hawkes Steve-FSH016
Joe Perches wrote: > > On Wed, 2008-02-20 at 22:32 -0800, David Miller wrote: > > > + if (lost) { > > > + printk(KERN_WARNING > > > +"printk: %d %s%smessage%s suppressed.\n", > > > +lost, > > > +(state-

[MACVLAN]: Update Kconfig to refer to iproute

2008-02-25 Thread Patrick McHardy
[MACVLAN]: Update Kconfig to refer to iproute Since the macvlan release I had at least 5 users asking how to configure it since the old userspace tool doesn't work with the version in the kernel. Add a pointer to the Kconfig help. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> diff --git a/

Re: [PATCH] llc: fix skb size for test responses

2008-02-25 Thread Arnaldo Carvalho de Melo
Em Sun, Feb 24, 2008 at 09:04:21PM -0800, Jim Westfall escreveu: > David Miller <[EMAIL PROTECTED]> wrote [02.24.08]: > > From: Jim Westfall <[EMAIL PROTECTED]> > > Date: Sun, 24 Feb 2008 11:07:58 -0800 > > > > > Hi > > > > > > The llc test command is used for a layer2 ping and contains a variabl

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-25 Thread Jarek Poplawski
On Mon, Feb 25, 2008 at 01:39:48PM +, Jarek Poplawski wrote: ... > Maybe, it's better to > analyze yet if it's really so hard to eliminate taking this lock > on the xmit path? BTW, I'm not sure if it helps, but this matters only for the sockets which could be used (and locked) outside of pppol

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-25 Thread Jarek Poplawski
On Mon, Feb 25, 2008 at 01:05:08PM +, Jarek Poplawski wrote: ... > On Mon, Feb 25, 2008 at 12:19:50PM +, James Chapman wrote: > > Is this an acceptable solution? If so, I'll prepare and send official > > patches. > > IMHO this should be acceptable because I can't see any reason for > cha

Re: [PATCH] nf_conntrack: less hairy ifdefs around proc and sysctl

2008-02-25 Thread Patrick McHardy
Alexey Dobriyan wrote: Patch splits creation of /proc/net/nf_conntrack, /proc/net/stat/nf_conntrack and net.netfilter hierarchy into their own functions with dummy ones if PROC_FS or SYSCTL is not set. Also, remove dead "ret = 0" write while I'm at it. Queued for 2.6.26, thanks. -- To unsubscri

[RFC] ethtool netlink interface

2008-02-25 Thread Thomas Graf
Hello, Before I continue to finish this work I'd like to get a few comments on my implementation attempt. The following patch implements the ETHTOOL_SSET and ETHTOOL_GSET command via netlink. The individual commands are implemented as separate functions and hooked into a table holding a validate,

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-25 Thread Jarek Poplawski
On Mon, Feb 25, 2008 at 12:19:50PM +, James Chapman wrote: > Jarek Poplawski wrote: >> Jarek Poplawski wrote, On 02/21/2008 01:08 PM: >> ... >> >>> Another, probably simpler way would be to move almost all pppol2tp_xmit >> ... >> >> Actually, the simplest off all seems to be now this old idea t

Re: [NETFILTER]: Introduce nf_inet_address

2008-02-25 Thread David Woodhouse
On Mon, 2008-02-25 at 13:23 +0100, Patrick McHardy wrote: > David Woodhouse wrote: > > On Mon, 2008-02-25 at 13:20 +0100, Patrick McHardy wrote: > >> Right, I missed that. In that case the current headers should match > >> the kernel headers (with the compiler.h part removed). > > > > They don't.

Re: [NETFILTER]: Introduce nf_inet_address

2008-02-25 Thread Patrick McHardy
David Woodhouse wrote: On Mon, 2008-02-25 at 13:20 +0100, Patrick McHardy wrote: Right, I missed that. In that case the current headers should match the kernel headers (with the compiler.h part removed). They don't. When you run 'make headers_install' there are some missing. We don't need a

Re: [NETFILTER]: Introduce nf_inet_address

2008-02-25 Thread Patrick McHardy
David Woodhouse wrote: On Mon, 2008-02-25 at 13:12 +0100, Patrick McHardy wrote: Yes, the kernel headers need to be fixed as well to not include linux/compiler.h outside of #ifdef __KERNEL__. I'll take care of that. No. When you run 'make headers_install' that's already taken care of. Right

Re: [NETFILTER]: Introduce nf_inet_address

2008-02-25 Thread David Woodhouse
On Mon, 2008-02-25 at 13:20 +0100, Patrick McHardy wrote: > > Right, I missed that. In that case the current headers should match > the kernel headers (with the compiler.h part removed). They don't. When you run 'make headers_install' there are some missing. -- dwmw2 -- To unsubscribe from th

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-25 Thread James Chapman
Jarek Poplawski wrote: Jarek Poplawski wrote, On 02/21/2008 01:08 PM: ... Another, probably simpler way would be to move almost all pppol2tp_xmit ... Actually, the simplest off all seems to be now this old idea to maybe make sk_dst_lock globally softirq immune. At least I think it's worth of

Re: [NETFILTER]: Introduce nf_inet_address

2008-02-25 Thread David Woodhouse
On Mon, 2008-02-25 at 13:12 +0100, Patrick McHardy wrote: > > Yes, the kernel headers need to be fixed as well to not include > linux/compiler.h outside of #ifdef __KERNEL__. I'll take care > of that. No. When you run 'make headers_install' that's already taken care of. -- dwmw2 -- To unsubsc

Re: [NETFILTER]: Introduce nf_inet_address

2008-02-25 Thread Patrick McHardy
David Woodhouse wrote: On Fri, 2008-02-22 at 16:44 +0100, Patrick McHardy wrote: Pablo Neira Ayuso wrote: Patrick McHardy wrote: Yes, that was a bug in the lastest release. We need to release a 1.4.1 version or something like that, but I'm not too familiar with the release process, so I haven'

Re: [Bluez-devel] forcing SCO connection patch

2008-02-25 Thread Louis JANG
Dave Young 쓴 글: > On Mon, Feb 25, 2008 at 5:28 PM, Louis JANG <[EMAIL PROTECTED]> wrote: > >> > I ever asked marcel about the coding style. please see following thread: >> > http://lkml.org/lkml/2008/1/22/91 >> > >> > I think the style problem marcel said is >> > 1. using kernel codeing sty

Re: New sparse warning in net/mac80211/debugfs_sta.c

2008-02-25 Thread Patrick McHardy
David Miller wrote: From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 21 Feb 2008 19:00:03 +0100 And adds back the overhead of two completely unnecessary function calls to the VLAN fastpath. How about just stopping this idiocy and reverting the appropriate patches to bring back MAC_FMT an

Re: [BUG][AX25] spinlock lockup

2008-02-25 Thread Jann Traschewski
Applied. Thanks! Regards, Jann > -Ursprüngliche Nachricht- > Von: Jarek Poplawski [mailto:[EMAIL PROTECTED] > Gesendet: Sonntag, 24. Februar 2008 20:51 > An: Jann Traschewski > Cc: netdev@vger.kernel.org; 'Ralf Baechle' > Betreff: Re: [BUG][AX25] spinlock lockup > > On Sun, Feb 24, 2008

Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support

2008-02-25 Thread Johannes Berg
On Mon, 2008-02-25 at 12:16 +0100, Sebastian Siewior wrote: > * Johannes Berg | 2008-02-25 11:13:56 [+0100]: > > >That seems completely wrong since it's a full-mac "chip" (implemented in > >the HV or so maybe). What exactly does it need from mac80211? > Nothing, please drop. I've sent another pat

Re: circular locking, mirred, 2.6.24.2

2008-02-25 Thread Jarek Poplawski
On Mon, Feb 25, 2008 at 12:48:38PM +0200, Denys Fedoryshchenko wrote: > What does it mean early? > I have custom boot scripts, it is also custom system based on busybox. There > is a chance that i forgot to bring ifb0 up, but thats it. > I think such warning must not appear on any actions in users

Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support

2008-02-25 Thread Sebastian Siewior
* Johannes Berg | 2008-02-25 11:13:56 [+0100]: >That seems completely wrong since it's a full-mac "chip" (implemented in >the HV or so maybe). What exactly does it need from mac80211? Nothing, please drop. I've sent another patch which enables WEXT what is the correct thing to do. Sorry for the no

Re: circular locking, mirred, 2.6.24.2

2008-02-25 Thread Denys Fedoryshchenko
What does it mean early? I have custom boot scripts, it is also custom system based on busybox. There is a chance that i forgot to bring ifb0 up, but thats it. I think such warning must not appear on any actions in userspace. On Mon, 25 Feb 2008 09:56:46 +, Jarek Poplawski wrote > On 24-02-20

Re: lockdep trace from rc2.

2008-02-25 Thread Johannes Berg
On Sun, 2008-02-24 at 21:22 -0500, Dave Jones wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=431038 has some more info, > but the trace is below... > I'll get an rc3 kernel built and ask the user to retest, but in case this > isn't a known problem, I'm forwarding this here. I can't fix it b

[PATCH resend 2.6.25 11/12][BNX2X]: update version

2008-02-25 Thread Eliezer Tamir
[BNX2X]: update version Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]> --- drivers/net/bnx2x.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnx2x.c b/drivers/net/bnx2x.c index 2db0427..6db4805 100644 --- a/drivers/net/bnx2x.c +++ b/drivers/net/bnx2x.c

[PATCH resend 2.6.25 7/12][BNX2X]: HW attention and error handling

2008-02-25 Thread Eliezer Tamir
[BNX2X]: HW attention and error handling - many fixes, sometimes improperly acked HW attentions could cause lockup. Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]> --- drivers/net/bnx2x.c | 229 +-- 1 files changed, 150 insertions(+), 79 deletion

[PATCH resend 2.6.25 5/12][BNX2X]: fix stats

2008-02-25 Thread Eliezer Tamir
[BNX2X]: fix stats - rx errors were summed improperly, some were missing Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]> --- drivers/net/bnx2x.c | 164 +-- drivers/net/bnx2x.h |4 +- 2 files changed, 83 insertions(+), 85 deletions(-) diff --

[PATCH resend 2.6.25 4/12][BNX2X]: correct rx filtering (client-config)

2008-02-25 Thread Eliezer Tamir
[BNX2X]: correct rx filtering (client-config) Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]> --- drivers/net/bnx2x.c | 165 --- drivers/net/bnx2x.h |5 +- 2 files changed, 92 insertions(+), 78 deletions(-) diff --git a/drivers/net/bnx2x.c b/

[PATCH resend 2.6.25 0/12][BNX2X] bugfixes

2008-02-25 Thread Eliezer Tamir
Dave, Here are just the bug fixes out of the previous update. Please apply to 2.6.25 1 Spelling fixes 2 Fix bnx2x_init_one() - was printing wrong PCI-E info, failed to release netdev in one case. 3 Link mgmt and BC bugs - many link cfg fixes The move to boot code 4.2.0 is mandatory sinc

[PATCH resend 2.6.25 2/12][BNX2X]: fix bnx2x_init_one()

2008-02-25 Thread Eliezer Tamir
[BNX2X]: fix bnx2x_init_one() - was printing wrong PCI-E info, failed to release netdev in one case. Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]> --- drivers/net/bnx2x.c | 41 ++--- drivers/net/bnx2x.h |5 + 2 files changed, 31 insertions(+), 15

[PATCH resend 2.6.25 12/12][BNX2X]: add bnx2x to MAINTAINERS

2008-02-25 Thread Eliezer Tamir
[BNX2X]: add bnx2x to MAINTAINERS Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]> --- MAINTAINERS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 36c7bc6..38f5744 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -982,6 +982,12 @@ M: [EMA

[PATCH resend 2.6.25 8/12][BNX2X]: fixed slowpath races

2008-02-25 Thread Eliezer Tamir
[BNX2X]: fixed slowpath races - fixed up/down racing with timer and fastpath. Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]> --- drivers/net/bnx2x.c | 213 --- drivers/net/bnx2x.h |3 - 2 files changed, 116 insertions(+), 100 deletions(-) di

[PATCH resend 2.6.25 10/12][BNX2X]: Tx fixes

2008-02-25 Thread Eliezer Tamir
[BNX2X]: Tx fixes - fix several bugs in start_xmit Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]> --- drivers/net/bnx2x.c | 12 +++- drivers/net/bnx2x.h |3 +++ 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/net/bnx2x.c b/drivers/net/bnx2x.c index d21599c.

[PATCH resend 2.6.25 9/12][BNX2X]: workaround PCI queue overflow

2008-02-25 Thread Eliezer Tamir
[BNX2X]: workaround PCI queue overflow - limit traffic through an internal queue to prevent overflow. Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]> --- drivers/net/bnx2x_init.h | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnx2x_init.h b/driv

[PATCH resend 2.6.25 6/12][BNX2X]: MSI-X / INT#A errata

2008-02-25 Thread Eliezer Tamir
[BNX2X]: MSI-X / INT#A errata - workaround for a HW bug when moving from MSI-X to INT#A without a reboot Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]> --- drivers/net/bnx2x.c | 24 1 files changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/net/bnx2x.c b

[PATCH resend 2.6.25 1/12][BNX2X]: Spelling fixes

2008-02-25 Thread Eliezer Tamir
[BNX2X]: Spelling fixes Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]> --- drivers/net/bnx2x.c | 119 +++--- drivers/net/bnx2x.h |2 +- 2 files changed, 56 insertions(+), 65 deletions(-) diff --git a/drivers/net/bnx2x.c b/drivers/net/bnx2x.c ind

[PATCH] IPv6 - Add missing initializations of the new nl_info.nl_net field

2008-02-25 Thread Benjamin Thery
Here is an updated version of the patch without the initializations to "zero". Add some more missing initializations of the new nl_info.nl_net field in IPv6 stack. This field will be used when network namespaces are fully supported. Signed-off-by: Benjamin Thery <[EMAIL PROTECTED]> --- net/i

Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support

2008-02-25 Thread Johannes Berg
On Sat, 2008-02-23 at 15:26 -0500, Jeff Garzik wrote: > Sebastian Siewior wrote: > > so select it. > > Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]> > > --- > > drivers/net/Kconfig |1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/net/Kconfig b/dr

Re: New sparse warning in net/mac80211/debugfs_sta.c

2008-02-25 Thread Johannes Berg
On Sat, 2008-02-23 at 20:02 -0800, David Miller wrote: > From: Patrick McHardy <[EMAIL PROTECTED]> > Date: Thu, 21 Feb 2008 19:00:03 +0100 > > > And adds back the overhead of two completely unnecessary > > function calls to the VLAN fastpath. How about just > > stopping this idiocy and reverting

Re: [Bluez-devel] forcing SCO connection patch

2008-02-25 Thread Dave Young
On Mon, Feb 25, 2008 at 5:28 PM, Louis JANG <[EMAIL PROTECTED]> wrote: > > > I ever asked marcel about the coding style. please see following thread: > > http://lkml.org/lkml/2008/1/22/91 > > > > I think the style problem marcel said is > > 1. using kernel codeing style > > 2. marcel's style

Re: circular locking, mirred, 2.6.24.2

2008-02-25 Thread Jarek Poplawski
On 24-02-2008 23:20, Denys Fedoryshchenko wrote: > 2.6.24.2 with applied patches for printk,softlockup, and patch for htb (as i > understand, they are in 2.6.25 git and it is fixes). > > I will send also to private mails QoS rules i am using. > > [ 118.840072] ==

[PATCH] nf_conntrack: less hairy ifdefs around proc and sysctl

2008-02-25 Thread Alexey Dobriyan
Patch splits creation of /proc/net/nf_conntrack, /proc/net/stat/nf_conntrack and net.netfilter hierarchy into their own functions with dummy ones if PROC_FS or SYSCTL is not set. Also, remove dead "ret = 0" write while I'm at it. Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- net/netfilt

[PATCH 2/2] [ACKVEC]: Schedule Sync as out-of-band mechanism

2008-02-25 Thread Gerrit Renker
The problem with Ack Vectors is that i) their length is variable and can in principle grow quite large, ii) it is hard to predict exactly how large they will be. Due to the second point it seems not a good idea to reduce the MPS; in particular when on average there is enough room for the Ack

[PATCH 1/2] [DCCP]: Leave headroom for options when calculating the MPS

2008-02-25 Thread Gerrit Renker
The Maximum Packet Size (MPS) is of interest for applications which want to transfer data, so it is only relevant to the data transfer phase of a connection (unless one wants to send data on the DCCP-Request, but that is not considered here). The strategy chosen to deal with this requirement is to

[DCCP] [Patch v2 0/2] [Revision]: Fix Ack Vector MPS Minimum Value

2008-02-25 Thread Gerrit Renker
This is a resubmission to fix a problem with accounting for Ack Vector length in the MPS. The present solution did not work well: the MPS did not account for Ack Vectors, so that applications which relied on the MPS value via getopt were disadvantaged by having all their Ack Vectors put onto Syn

Re: 2.6.25-rc2-mm1 - several bugs and a crash

2008-02-25 Thread Tilman Schmidt
Paul E. McKenney schrieb: On Fri, Feb 22, 2008 at 01:52:53AM +0100, Tilman Schmidt wrote: So the nf_conntrack BUG is fixed, but the crash (and of course the swapper "spinlock bad magic" BUG) persists. Do you have CONFIG_DEBUG_PREEMPT set? That would help find any other bugs similar to nf_co

Re: [PATCH] llc: fix skb size for test responses

2008-02-25 Thread Joonwoo Park
2008/2/25, Jim Westfall <[EMAIL PROTECTED]>: > David Miller <[EMAIL PROTECTED]> wrote [02.24.08]: > > From: Jim Westfall <[EMAIL PROTECTED]> > > Date: Sun, 24 Feb 2008 11:07:58 -0800 > > > > > Hi > > > > > > The llc test command is used for a layer2 ping and contains a variable > > > length payload

[NET] Can not send icmp netunreach packet

2008-02-25 Thread Li Yewang
Hi Steven There is a bug about icmp netunreach. If the kernel does not find a route for a packet, it must send a icmp netunreach packet to the source host, and discard the packet. But the latest kernel does not send a icmp netunreach packet because of the fib_lookup return

Re: [Bluez-devel] forcing SCO connection patch

2008-02-25 Thread Dave Young
Sorry, [EMAIL PROTECTED] was missed in cc On Mon, Feb 25, 2008 at 3:34 PM, Dave Young <[EMAIL PROTECTED]> wrote: > > On Mon, Feb 25, 2008 at 3:30 PM, Dave Young <[EMAIL PROTECTED]> wrote: > > Quote mail from [EMAIL PROTECTED] : > > > > 2007/12/17 Louis JANG <[EMAIL PROTECTED]>: > > > > > >