On Sun, Feb 24, 2008 at 10:33:12PM -0800, David Brownell wrote: > On Sunday 24 February 2008, Sam Ravnborg wrote: > > > From a quick look this is wrong. > > smc_drv_probe is assined the .probe member so it is used during > > hotplug and thus should be __devinit. > > Likewise smc_probe is used by smc_drv_probe and thus smc_probe > > should be __devinit too. > > Thing is, with only rare exceptions, devices on the platform > bus are *NOT* hotpluggable. So using __devinit/__devexit and > friends adds up to no more than a waste of I-space.
It was a quick look - thanks for the explanation. Sam -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html