Please see the kernel messages following,(trigged while using some qemu session)
BTW, seems there's some e100 error message as well.
PCI: Setting latency timer of device :00:1b.0 to 64
e100: Intel(R) PRO/100 Network Driver, 3.5.23-k4-NAPI
e100: Copyright(c) 1999-2006 Intel Corporation
ACPI: PC
Paul E. McKenney wrote:
> On Sun, Jan 20, 2008 at 03:21:46PM -0800, Stephen Hemminger wrote:
>> Get rid of some more sparse warnings.
>>
>> Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
>
> Adding Josh to CC -- is __acquires() case-insensitive? If not, this
> needs to be __acquires(RCU) an
The rt_run_flush() can be stucked if it was called while netdev is on the
high load.
It's possible when pushing rtable to rt_hash is faster than pulling
from it.
The commands 'ifconfig up or ifconfig mtu' and netif_carrier_on() can
introduce soft lockup like this:
[ 363.528001] BUG: soft lockup
Hello. Its work, thanks for resend it!
Sorry, i understand that patch 53e52c729cc169db82a6105fac7a166e10c2ec36
("[NET]: Make ->poll() breakout consistent in Intel ethernet drivers.")
have regression and rollback it, i not see your patch.
Sorry again.
Thanks!
From: Badalian Vyacheslav <[EMAIL
On Mon, Jan 21, 2008 at 07:34:55AM +0100, Jarek Poplawski wrote:
...
> BTW, I've forgotten to mention with patch 1/3 that this checking with
> warning on gen_new_estimator() double call should be only temporary,
> and after more testing gen_estimator structure could be probably
> decreased after re
On Sun, Jan 20, 2008 at 03:55:44PM -0800, Stephen Hemminger wrote:
> On Mon, 21 Jan 2008 00:49:59 +0100
> Jarek Poplawski <[EMAIL PROTECTED]> wrote:
>
> > This patch changes the method of checking for empty list in est_timer():
> > list_empty() is not recommended for RCU protected lists. Now, it's
On Mon, Jan 21, 2008 at 05:28:31AM +, Al Viro wrote:
> On Sun, Jan 20, 2008 at 09:03:55PM -0800, Paul E. McKenney wrote:
> > On Sun, Jan 20, 2008 at 03:21:46PM -0800, Stephen Hemminger wrote:
> > > Get rid of some more sparse warnings.
> > >
> > > Signed-off-by: Stephen Hemminger <[EMAIL PROTE
On Sun, Jan 20, 2008 at 09:03:55PM -0800, Paul E. McKenney wrote:
> On Sun, Jan 20, 2008 at 03:21:46PM -0800, Stephen Hemminger wrote:
> > Get rid of some more sparse warnings.
> >
> > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
>
> Adding Josh to CC -- is __acquires() case-insensitive?
On Sun, Jan 20, 2008 at 03:21:46PM -0800, Stephen Hemminger wrote:
> Get rid of some more sparse warnings.
>
> Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Adding Josh to CC -- is __acquires() case-insensitive? If not, this
needs to be __acquires(RCU) and __releases(RCU).
On Mon, Jan 21, 2008 at 12:49:13PM +0800, Dave Young wrote:
> The rfcomm tty device will possibly retain even when conn is down,
> and sysfs doesn't support zombie device moving, so this patch
> move the tty device before conn device is destroyed.
>
> For the bug refered please see :
> http://lkml
The rfcomm tty device will possibly retain even when conn is down,
and sysfs doesn't support zombie device moving, so this patch
move the tty device before conn device is destroyed.
For the bug refered please see :
http://lkml.org/lkml/2007/12/28/87
Signed-off-by: Dave Young <[EMAIL PROTECTED]>
> (But new_value = 0 seems needed - just like from module_param()?)
Do you mean to initialize new_value before sscanf()? (There is a check 'if (sscanf(buf,
"%d", &new_value) != 1)', so is it necesarry?)
> - maybe to test if the value has changed at all,
Tested.
For now, patch will be like below
From: Andrew Morton <[EMAIL PROTECTED]>
Date: Sun, 20 Jan 2008 17:36:44 -0800
> On Sun, 20 Jan 2008 17:15:38 -0800 (PST) David Miller <[EMAIL PROTECTED]>
> wrote:
>
> > From: Jay Vosburgh <[EMAIL PROTECTED]>
> > Date: Thu, 17 Jan 2008 16:24:56 -0800
> >
> > > Following are seven patches to fi
David Miller wrote:
From: Jay Vosburgh <[EMAIL PROTECTED]>
Date: Thu, 17 Jan 2008 16:24:56 -0800
Following are seven patches to fix locking problems,
silence locking-related warnings and resolve one recent regression
in the current 2.6.24-rc.
Jeff, are you going to merge this stuff in
On Sun, 20 Jan 2008 17:15:38 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote:
> From: Jay Vosburgh <[EMAIL PROTECTED]>
> Date: Thu, 17 Jan 2008 16:24:56 -0800
>
> > Following are seven patches to fix locking problems,
> > silence locking-related warnings and resolve one recent regression
>
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Sun, 20 Jan 2008 18:21:27 +0100
> commit 6e470bd53fb50632fe1878bb74bb8531a21b6731
> Author: Patrick McHardy <[EMAIL PROTECTED]>
> Date: Sun Jan 20 18:19:15 2008 +0100
>
> [NET]: rtnl_link: fix use-after-free
>
> When unregistering the
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Sun, 20 Jan 2008 16:12:28 +0100
> commit 4dd3440faa345731c27337ee041c0e9abf2b70dc
> Author: Patrick McHardy <[EMAIL PROTECTED]>
> Date: Sun Jan 20 16:10:04 2008 +0100
>
> [AF_KEY]: Fix skb leak on pfkey_send_migrate() error
>
> Signed
From: Sam Ravnborg <[EMAIL PROTECTED]>
Date: Sat, 19 Jan 2008 14:29:04 +0100
> Acked-by: Sam Ravnborg <[EMAIL PROTECTED]>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majo
From: Sam Ravnborg <[EMAIL PROTECTED]>
Date: Sat, 19 Jan 2008 14:28:52 +0100
> On Sat, Jan 19, 2008 at 03:18:49PM +0200, Adrian Bunk wrote:
> > EXPORT_SYMBOL'ed code mustn't be __*init.
> >
> > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
> Acked-by: Sam Ravnborg <[EMAIL PROTECTED]>
Applied.
-
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Fri, 18 Jan 2008 14:48:37 -0800
> Add whitespace around operators, and add a few blank lines
> to improve readability.
>
> Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe
From: "Paul E. McKenney" <[EMAIL PROTECTED]>
Date: Fri, 18 Jan 2008 20:18:20 -0800
> On Fri, Jan 18, 2008 at 02:47:30PM -0800, Stephen Hemminger wrote:
> > SFQ doesn't need true random numbers, it is only using them to salt
> > a hash. Therefore it is better to use net_random() and avoid any possi
From: "Paul E. McKenney" <[EMAIL PROTECTED]>
Date: Fri, 18 Jan 2008 21:57:00 -0800
> On Fri, Jan 18, 2008 at 08:36:55PM -0800, Stephen Hemminger wrote:
> > On Fri, 18 Jan 2008 20:34:46 -0800
> > "Paul E. McKenney" <[EMAIL PROTECTED]> wrote:
> >
> > > On Fri, Jan 18, 2008 at 02:49:00PM -0800, Step
From: Jay Vosburgh <[EMAIL PROTECTED]>
Date: Thu, 17 Jan 2008 16:24:56 -0800
> Following are seven patches to fix locking problems,
> silence locking-related warnings and resolve one recent regression
> in the current 2.6.24-rc.
Jeff, are you going to merge this stuff in?
I'll drop that rt
Adrian Bunk wrote:
> EXPORT_SYMBOL'ed code mustn't be __*init.
>
Is it correct that the cases below are section mismatches as well?
If required I'll send separate patches to the respective maintainers
& lists.
__init
arch/arm/mach-imx/generic.c:330:EXPORT_SYMBOL(set_imx_fb_info);
__devinit
arch
From: Samuel Ortiz <[EMAIL PROTECTED]>
Date: Fri, 18 Jan 2008 08:53:22 +0100
> Hi Dave,
>
> Here goes an IrDA patch against your latest net-2.6 tree.
>
> This patch fixes some af_irda memory leaks.
> It also checks for irias_new_obect() return value.
>
> Signed-off-by: Jesper Juhl <[EMAIL PROTE
From: Andrew Morton <[EMAIL PROTECTED]>
Date: Thu, 17 Jan 2008 15:42:43 -0800
> Applying this:
>
> --- a/drivers/net/bonding/bond_sysfs.c~bonding-locking-fix
> +++ a/drivers/net/bonding/bond_sysfs.c
> @@ -,8 +,6 @@ static ssize_t bonding_store_primary(str
> out:
> write_unlock_bh(&
From: "Denis V. Lunev" <[EMAIL PROTECTED]>
Date: Thu, 17 Jan 2008 13:08:51 +0300
> FIB rule->action should operate in the same namespace as fib_lookup.
> This is definitely missed right now.
>
> There are two ways to implement this: pass struct net into another rules
> API call (2 levels) or plac
Hi.
Quoting Ingo Molnar <[EMAIL PROTECTED]>:
* Andi Kleen <[EMAIL PROTECTED]> wrote:
My workstation running 2.6.24-rc8 just hung during shutdown with an
endless (or rather I didn't wait more than a few minutes) loop of
unregister_netdev: waiting for ppp-device to become free. Usage count
=
From: Mariusz Kozlowski <[EMAIL PROTECTED]>
Date: Mon, 21 Jan 2008 01:09:41 +0100
> kernel: unregister_netdevice: waiting for eth1 to become free. Usage count = 1
Known problem:
http://bugzilla.kernel.org/show_bug.cgi?id=9778
--
To unsubscribe from this list: send the line "unsubscribe n
Hello,
I found that on current Linus tree unplugging my pcmcia wifi
card (Cabletron RoamAbout) causes part of the system to hang. I.e. mouse works
but keyboard is frozen until reboot. Actually only sysrq works but I can not
type in any terminal.
Syslog shows:
kernel: pccard: card ejected
Stephen Hemminger wrote:
Replace loop in dsmark_valid_indices with equivalent bit math.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/net/sched/sch_dsmark.c2008-01-20 13:07:58.0 -0800
+++ b/net/sched/sch_dsmark.c2008-01-20 13:22:54.0 -0800
@@ -45,13 +45,8 @@
From: Ingo Molnar <[EMAIL PROTECTED]>
Date: Sun, 20 Jan 2008 21:01:09 +0100
>
> * Andi Kleen <[EMAIL PROTECTED]> wrote:
>
> > My workstation running 2.6.24-rc8 just hung during shutdown with an
> > endless (or rather I didn't wait more than a few minutes) loop of
> >
> > unregister_netdev: wai
From: Andi Kleen <[EMAIL PROTECTED]>
Date: Sun, 20 Jan 2008 20:53:30 +0100
>
> My workstation running 2.6.24-rc8 just hung during shutdown with an endless
> (or rather I didn't wait more than a few minutes) loop of
>
> unregister_netdev: waiting for ppp-device to become free. Usage count = 1
>
On Mon, 21 Jan 2008 00:49:59 +0100
Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> This patch changes the method of checking for empty list in est_timer():
> list_empty() is not recommended for RCU protected lists. Now, it's simply
> a variable used for this.
>
> Signed-off-by: Jarek Poplawski <[EMA
White spaces etc. are changed in gen_replace_estimator() to make it similar
to others in a file.
Signed-off-by: Jarek Poplawski <[EMAIL PROTECTED]>
---
diff -Nurp 2.6.24-rc8-mm1-p2-/net/core/gen_estimator.c
2.6.24-rc8-mm1-p2+/net/core/gen_estimator.c
--- 2.6.24-rc8-mm1-p2-/net/core/gen_estimato
This patch changes the method of checking for empty list in est_timer():
list_empty() is not recommended for RCU protected lists. Now, it's simply
a variable used for this.
Signed-off-by: Jarek Poplawski <[EMAIL PROTECTED]>
---
diff -Nurp 2.6.24-rc8-mm1-p1-/net/core/gen_estimator.c
2.6.24-rc8-m
gen_kill_estimator() is called during qdisc_destroy() with BHs disabled,
and each time does searching for each list member. This can block soft
interrupts for quite a long time when many classes are used. This patch
changes this by storing a pointer to internal gen_estimator structures
with gnet_s
Get rid of some more sparse warnings.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/net/core/dev.c2008-01-20 14:25:00.0 -0800
+++ b/net/core/dev.c2008-01-20 14:25:48.0 -0800
@@ -2543,6 +2543,7 @@ static void *ptype_get_idx(loff_t pos)
}
static void *ptype_
Hi!
> My workstation running 2.6.24-rc8 just hung during shutdown with an endless
> (or rather I didn't wait more than a few minutes) loop of
>
> unregister_netdev: waiting for ppp-device to become free. Usage count = 1
>
> ppp-device was an active PPPoE device.
>
> No more information curren
Classifier code cleanup. Get rid of printk wrapper, and fix whitespace
and other style stuff reported by checkpatch
---
net/sched/cls_api.c | 100 +++-
net/sched/cls_tcindex.c | 60 +++-
2 files changed, 73 insertions(+),
ATM scheduler clean house:
* get rid of printk and qdisc_priv() wrapper
* split some assignment in if() statements
* whitespace and line breaks.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/net/sched/sch_atm.c 2008-01-20 13:51:58.0 -0800
+++ b/net/sched/sch_atm.c
Make dsmark work properly with non-linear and cloned skb's
Before modifying the header, it needs to check that skb header is
writeable.
Note: this makes the assumption, that if it queues a good skb
then a good skb will come out of the embedded qdisc.
Signed-off-by: Stephen Hemminger <[EMAIL PROTE
Replace loop in dsmark_valid_indices with equivalent bit math.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/net/sched/sch_dsmark.c2008-01-20 13:07:58.0 -0800
+++ b/net/sched/sch_dsmark.c2008-01-20 13:22:54.0 -0800
@@ -45,13 +45,8 @@ struct dsmark_qdisc_data {
Remove extraneous macro wrappers for printk and qdisc_priv.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/net/sched/sch_dsmark.c2008-01-20 08:36:10.0 -0800
+++ b/net/sched/sch_dsmark.c2008-01-20 08:47:26.0 -0800
@@ -15,23 +15,6 @@
#include
#include
-
-#
Get rid of all style things checkpatch warns about, indentation
and whitespace.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/net/sched/sch_dsmark.c2008-01-20 13:23:34.0 -0800
+++ b/net/sched/sch_dsmark.c2008-01-20 13:24:45.0 -0800
@@ -152,7 +152,7 @@ static i
> It seems to have stopped when i stopped using ipsec and started using
> vpnc.
Kernel ipsec was active yes. However I normally don't see it although
it is often active, that was the first time I think
(except long ago)
> (but no firm info - this was sporadic - happened every few months
> or
On Sun, 20 Jan 2008 20:53:30 +0100
Andi Kleen <[EMAIL PROTECTED]> wrote:
>
> My workstation running 2.6.24-rc8 just hung during shutdown with an endless
> (or rather I didn't wait more than a few minutes) loop of
>
> unregister_netdev: waiting for ppp-device to become free. Usage count = 1
>
Andi Kleen wrote:
> My workstation running 2.6.24-rc8 just hung during shutdown with an
> endless (or rather I didn't wait more than a few minutes) loop of
>
> unregister_netdev: waiting for ppp-device to become free. Usage count = 1
Same as http://lkml.org/lkml/2008/1/20/27? See also follow-up t
Andi Kleen wrote:
My workstation running 2.6.24-rc8 just hung during shutdown with an endless
(or rather I didn't wait more than a few minutes) loop of
unregister_netdev: waiting for ppp-device to become free. Usage count = 1
ppp-device was an active PPPoE device.
No more information current
* Andi Kleen <[EMAIL PROTECTED]> wrote:
> My workstation running 2.6.24-rc8 just hung during shutdown with an
> endless (or rather I didn't wait more than a few minutes) loop of
>
> unregister_netdev: waiting for ppp-device to become free. Usage count
> = 1
>
> ppp-device was an active PPPoE
My workstation running 2.6.24-rc8 just hung during shutdown with an endless
(or rather I didn't wait more than a few minutes) loop of
unregister_netdev: waiting for ppp-device to become free. Usage count = 1
ppp-device was an active PPPoE device.
No more information currently.
-Andi
--
To un
Ian Brown wrote:
Hello,
net 2.6.25 is broken when building with the wireless/iwlwifi
subtree; we get the following errors (we noticed that iwl_down() and
iwl_resume()
implementation do exist in garzik tree, but there are more differences
so a simple
patch with only adding these two methods might
Patrick McHardy wrote:
commit e97ba18f7a8f9342fa06d0f5606a186b18e1d7f8
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed Jan 16 12:22:06 2008 +0100
[NET_SCHED]: Consolidate class ops for pseudo classful qdisc
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
config NET_
commit e97ba18f7a8f9342fa06d0f5606a186b18e1d7f8
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed Jan 16 12:22:06 2008 +0100
[NET_SCHED]: Consolidate class ops for pseudo classful qdisc
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
diff --git a/include/net/sch_generic.h b/
commit 8b0737e99efbf5b51f950d9fa95d69f96bf0a926
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed Jan 16 12:22:00 2008 +0100
[NET_SCHED]: Use qdisc helpers
Use the new qdisc helpers where possible. Also pull return value
assignments out of conditions and use proper NET_XMIT
commit a6d1954517202bffb14f5122756891d8c5b8e2e2
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed Jan 16 12:08:18 2008 +0100
[NET_SCHED]: Introduce child qdisc helpers
Introduce a few helpers to dispatch calls to child qdiscs without
repeating the qdisc argument every time.
commit c1f4198dd24ce854b7d55d0ed23a61d36d7defc9
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed Jan 2 21:35:21 2008 +0100
[NET_SCHED]: Rename qdisc helpers for built-in queue
Rename all helper functions dealing with the built-in queue of
struct Qdisc (sch->q) to qdisc_q_..
commit e56c933715900be7c6ad30bd07d342d31c457112
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed Jan 2 21:35:19 2008 +0100
[NET_SCHED]: Consolidate default fifo setup
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
diff --git a/include/net/pkt_sched.h b/include/net/pkt_sche
These patches contain some preparatory cleanups and consolidate the
Qdisc_class_ops for pseudo-classful qdiscs. The main reason for
RFC is that the naming is not particular appealing (both qdisc_q_...
and sch_pseudo_classful), suggestions for better names are welcome.
include/net/pkt_sched.h
Get rid of a couple of sparse warnings in IPV6 addrconf code.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/net/ipv6/addrconf.c 2008-01-20 09:38:06.0 -0800
+++ b/net/ipv6/addrconf.c 2008-01-20 09:57:40.0 -0800
@@ -1900,7 +1900,7 @@ int addrconf_set_dstaddr
commit 6e470bd53fb50632fe1878bb74bb8531a21b6731
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Sun Jan 20 18:19:15 2008 +0100
[NET]: rtnl_link: fix use-after-free
When unregistering the rtnl_link_ops, all existing devices using
the ops are destroyed. With nested devices this
[VLAN]: Update list address
VLAN related mail should go to netdev.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit e7e221b07c3a3f77df617232ea0f76094edc1071
tree 347c69877e8e1b5fc5e730b099683739ba83a6d0
parent bea0af04454189d656afd69168e0e3ec3209b6b2
author Patrick McHardy <[EMAIL P
[VLAN]: Move protocol determination to seperate function
I think, that we can make this code flow easier to understand
by introducing the vlan_set_encap_proto() function (I hope the
name is good) to setup the skb proto and merge the paths calling
netif_rx() together.
[Patrick: Modified to apply o
[VLAN]: checkpatch cleanups
Checkpatch cleanups, consisting mainly of overly long lines and missing
spaces.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit bea0af04454189d656afd69168e0e3ec3209b6b2
tree 6b7d57540dbaf1e40c295d4ba0d40d021a0fec50
parent 40048c4ab8a08ea7f0e2df52f0ec02a8
[VLAN]: Clean up vlan_skb_recv()
- remove three instances of identical code
- remove unnecessary NULL initialization
- remove obvious and unnecessary comments
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit c314238cb2135e4bb812487ed47652a5e2e4b748
tree 42969440a4ea33d5addcbbce4758e
[VLAN]: Turn VLAN_DEV_INFO into inline function
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 84ea6a8ff0745f63e25d2d17664fd8c56448f985
tree de3ead8eda857231834d77e151be7ebc60ed3b5f
parent cd41c792d7df5107c05f2529426ae68f817e38f6
author Patrick McHardy <[EMAIL PROTECTED]> Sun, 20 J
[VLAN]: Turn __constant_htons into htons where possible
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 40048c4ab8a08ea7f0e2df52f0ec02a8010d2a0e
tree bf0486c7fd56dae810144d1695281fb39ce402e7
parent 84ea6a8ff0745f63e25d2d17664fd8c56448f985
author Patrick McHardy <[EMAIL PROTECTED]> S
[VLAN]: Clean up unregister_vlan_dev
Save two levels of indentation by aborting on error conditions,
remove unnecessary initialization to NULL and remove two obvious
comments.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 9f39c0253f370dae13a81cda9cf119052bb11750
tree d27c1417f8f1
[VLAN]: Simplify vlan unregistration
Keep track of the number of VLAN devices in a vlan group. This allows
to have the caller sense when the group is going to be destroyed and
stop using it, which in turn allows to remove the wrapper around
unregister_vlan_dev for the NETDEV_UNREGISTER notifier an
[VLAN]: Remove non-implemented ioctls
The GET_VLAN_INGRESS_PRIORITY_CMD/GET_VLAN_EGRESS_PRIORITY_CMD ioctls are
not implemented and won't be, new functionality will be added to the netlink
interface. Remove the code and make the ioctl handler return -EOPNOTSUPP
for unknown commands instead of -EIN
[VLAN]: Clean up initialization code
- move module init/exit functions to end of file, remove some now unnecessary
forward declarations
- remove some obvious comments
- clean up proc init function and move a proc-related printk there
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commi
[ETHER]: Bring back MAC_FMT
The print_mac function is not very suitable for debugging printks
in performance critical paths since without ifdefs it will always
get called. MAC_FMT can be used with pr_debug without any overhead
when debugging is disabled.
Signed-off-by: Patrick McHardy <[EMAIL PRO
[VLAN]: Clean up debugging and printks
- use pr_* functions and common prefix for non-device related messages
- remove VLAN_ printk levels
- kill lots of useless debugging statements
- remove a few unnecessary printks like for double VID registration (already
returns -EEXIST) and kill of a nu
[VLAN]: Move device setup to vlan_dev.c
Move device setup to vlan_dev.c and make all the VLAN device methods
static.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit aa7c9ed461cf1cf1977a7d5735d464a7539d2518
tree 06a7feef01dfd6494de6ed687895c6ca58a44f3d
parent fef4f968b4704bf2b37417c
[VLAN]: Kill useless check
vlan->real_dev is always equal to the device since thats what we used
for the lookup. It doesn't even seem worth a WARN_ON or BUG_ON.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 99c94d927602635ca0994a99bf75edc0d2f80871
tree b7455cbbe55a60f0d13a3b9b646
[VLAN]: Kill useless VLAN_NAME define
The only user already includes __FUNCTION__ (vlan_proto_init) in the output,
which is enough to identify what the message is about.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 6fcdd6b0d244f103898c3a37be2a3f4fec50fbd8
tree 6554c7cab6fdf09ac2
[VLAN]: Use dev->stats
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit fef4f968b4704bf2b37417ca6ba0dedda696e611
tree a5f8d87d4e193b681fba07727fc3ba1a078d0cfa
parent 6fcdd6b0d244f103898c3a37be2a3f4fec50fbd8
author Patrick McHardy <[EMAIL PROTECTED]> Sun, 20 Jan 2008 16:24:54 +0100
co
Hi Dave,
the following patches contain a VLAN update for 2.6.25, consisting mainly
of minor cleanups removing duplicate code, avoiding forward declarations,
makeing functions static etc. Next I'll look into the skb->cb issues
with VLAN.
Please apply, thanks.
drivers/net/cxgb3/l2t.c |2
[VLAN]: Remove unnecessary structure declarations
- struct packet_type is not used
- struct vlan_group is declared later in the file before the first use
- struct net_device is not needed since netdevice.h is included
- struct vlan_collection does not exist
- struct vlan_dev_info is declared later
[VLAN]: Clean up vlan_hdr/vlan_ethhdr structs
Fix 3 space indentation and some overly long lines by moving the comments
to a kdoc structure description.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit f12d203e024ce5e0c98a9e88f6fdf8517a665ce4
tree cebd9edb5b883aa901eaad4702ec428b2af
On Sun, 20 Jan 2008 16:35:01 +0100
Patrick McHardy <[EMAIL PROTECTED]> wrote:
> jamal wrote:
> > On Sun, 2008-20-01 at 15:32 +0100, Patrick McHardy wrote:
> >> These patches clean up sch_ingress by reformatting the code to match the
> >> usual kernel style, removing lots of debugging statements th
Hi
I am trying to run netconsole on Dell PowerEdge 1950, equipped with two
Broadcom NIC, without any success.
Tried to load netconsole on eth1 and eth0 (interface was renamed by udev), and
after that i am loading ppp_generic (which generate some data in kernel log).
Watching by tcpdump on remote,
jamal wrote:
On Sun, 2008-20-01 at 15:32 +0100, Patrick McHardy wrote:
These patches clean up sch_ingress by reformatting the code to match the
usual kernel style, removing lots of debugging statements that seem
unnecessary after years of stable operation, removing some "future use"
stuff that d
On Sun, 2008-20-01 at 15:32 +0100, Patrick McHardy wrote:
> These patches clean up sch_ingress by reformatting the code to match the
> usual kernel style, removing lots of debugging statements that seem
> unnecessary after years of stable operation, removing some "future use"
> stuff that doesn't s
commit 4dd3440faa345731c27337ee041c0e9abf2b70dc
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Sun Jan 20 16:10:04 2008 +0100
[AF_KEY]: Fix skb leak on pfkey_send_migrate() error
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
diff --git a/net/key/af_key.c b/net/key/af_key.c
The Marvell Orion system on chips have an integrated mv643xx MAC.
On these little endian ARM devices mv643xx will oops when checksum
offload is enabled. Swapping the byte order of the protocol and
checksum solves this problem.
Signed-off-by: Byron Bradley <[EMAIL PROTECTED]>
Cc: Dale Farnsworth <[
commit 2af10cb220dd73b91323d052f7ca4cb808906e78
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed Jan 16 12:22:06 2008 +0100
[NET_SCHED]: kill obsolete NET_CLS_POLICE option
The code is already gone for about half a year, the config option
has been kept around to select the
Fix a minor thinko in macvlan. The bug is uncritical, so this
doesn't need to go in 2.6.24.
commit b40b16bb72ae1ad192daef55a3e9f81d76cd97ab
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Thu Jan 17 09:18:11 2008 +0100
[MACVLAN]: Fix thinko in macvlan_transfer_operstate()
When t
commit 3320bc3c5d9a6c1dd96d515b7b6a4dee9cd31fd7
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Thu Jan 17 09:17:58 2008 +0100
[NET_SCHED]: sch_ingress: avoid a few #ifdefs
Move the repeating "ifndef CONFIG_NET_CLS_ACT/ifdef CONFIG_NETFILTER" ifdefs
into a single condition.
commit c96158287d0c87fc3e4d005ce8bf2c778a5c2cb6
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed Jan 16 12:22:07 2008 +0100
[NET_SCHED]: sch_ingress: remove unnecessary ops
- ->reset is optional
- sch_api provides identical defaults for ->dequeue/->requeue
- ->drop can'
commit 4c939213974319d9457dbbf038d38ef1fcf57ef9
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed Jan 16 12:22:08 2008 +0100
[NET_SCHED]: sch_ingress: move dependencies to Kconfig
Instead of complaining at scheduler initialization time, check the
dependencies
in Kconfig.
commit f8d51e131177c26c1033dfc804f11d9cac7637f4
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Thu Jan 17 09:17:59 2008 +0100
[NET_SCHED]: sch_ingress: remove useless printk
The printk about ingress qdisc registration error can't be triggered under
normal circumstances. Since
commit bb582f29b1f403d0df8a4a54daca89eafd2bfb69
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed Jan 16 12:22:07 2008 +0100
[NET_SCHED]: sch_ingress: remove unused inner qdisc
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
diff --git a/net/sched/sch_ingress.c b/net/sched/s
commit e039da57d244f15d4b920de63a20ab516a76ed5b
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed Jan 16 12:22:07 2008 +0100
[NET_SCHED]: sch_ingress: return proper error code in ingress_graft()
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
diff --git a/net/sched/sch_ingre
commit fdb1b974189eeab782ba3595d1ca550a1a5ee79e
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed Jan 16 12:22:06 2008 +0100
[NET_SCHED]: sch_ingress: remove excessive debugging
Remove excessive debugging statements and some "future use" stuff.
Signed-off-by: Patrick Mc
commit ec46354d4ba87fe98b8510f2d91fff4e106022ec
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed Jan 16 12:22:07 2008 +0100
[NET_SCHED]: sch_ingress: remove qdisc_priv() wrapper
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
diff --git a/net/sched/sch_ingress.c b/net/sched
commit e237be7bc5b3009d1021e0764d1745e9a4c3cefb
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed Jan 16 12:22:06 2008 +0100
[NET_SCHED]: sch_ingress: formatting fixes
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
diff --git a/net/sched/sch_ingress.c b/net/sched/sch_ingres
These patches clean up sch_ingress by reformatting the code to match the
usual kernel style, removing lots of debugging statements that seem
unnecessary after years of stable operation, removing some "future use"
stuff that doesn't seem likely to ever get used and some minor additional
cleanups.
From: Vlad Yasevich <[EMAIL PROTECTED]>
Date: Sun, 20 Jan 2008 05:47:13 -0500
> Anyway, here is a patch that sets the correct value.
Applied, but I had to fix up the trailing whitespace on
line 29 of your patch. :-/
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
Hello,
net 2.6.25 is broken when building with the wireless/iwlwifi
subtree; we get the following errors (we noticed that iwl_down() and
iwl_resume()
implementation do exist in garzik tree, but there are more differences
so a simple
patch with only adding these two methods might be risky)
...
...
1 - 100 of 105 matches
Mail list logo
