Re: [PATCH 25/26] atl1: add NAPI support

On Mon, 31 Dec 2007 20:22:52 -0600 Jay Cliburn <[EMAIL PROTECTED]> wrote: > Add support for NAPI, styled after the e1000 NAPI implementation. That we > follow the e1000 for NAPI shouldn't come as much of a surprise, since the > entire atl1 driver is based heavily upon it. > > Signed-off-by: Jay

Re: [PATCH] Force UNIX domain sockets to be built in

On Tue, Jan 01, 2008 at 04:45:21AM +0100, Bodo Eggert wrote: > > udev-free != embedded. > > But UNIX=m == waste RAM and have an effectively b0rken system until the > module is loaded. Well, the system isn't necessarily totally broken. If you don't use udev, then system will be crippled, but no

Re: [PATCH] Force UNIX domain sockets to be built in

On Mon, 31 Dec 2007, David Miller wrote: > From: Bodo Eggert <[EMAIL PROTECTED]> > > The big question is: Is there any non-embedded system where you have > > to aim for a small kernel image? > > One some platforms, due to bootloader restrictions or whatever, > there are hard limits on how large t

Re: [PATCH] Force UNIX domain sockets to be built in

From: Bodo Eggert <[EMAIL PROTECTED]> Date: Tue, 1 Jan 2008 04:45:21 +0100 (CET) > The big question is: Is there any non-embedded system where you have > to aim for a small kernel image? One some platforms, due to bootloader restrictions or whatever, there are hard limits on how large the main ke

Re: [PATCH] Force UNIX domain sockets to be built in

On Mon, 31 Dec 2007, Al Viro wrote: > On Mon, Dec 31, 2007 at 03:03:20PM +0100, Bodo Eggert wrote: > > On Mon, 31 Dec 2007, David Miller wrote: > > > From: Bodo Eggert <[EMAIL PROTECTED]> > > > > As suggested by Adrian Bunk, UNIX domain sockets should always be built > > > > in > > > > on normal

[PATCH 11/26] atl1: refactor initialization and startup

Refactor atl1 initialization and startup to conform with the current vendor driver version 1.2.40.2. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 507 --- drivers/net/atlx/atl1.h | 10 +- drivers/net/atlx/atlx.c |1

[PATCH 18/26] atl1: make function static

Make atl1_reset() a static function. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c index 6432956..7697e80 100644 --- a/drivers/net/atlx

[PATCH 22/26] atl1: update netpoll

Rename atl1_poll_controller() to atl1_netpoll() and update to conform with the current vendor driver version 1.2.40.2. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/atlx/atl

[PATCH 21/26] atl1: update atl1_close

Update atl1_close() to conform with current vendor driver version 1.2.40.2. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c index 7d8

[PATCH 15/26] atl1: tidy up ring management

Check for null pointers and such in ring handling functions. Make needlessly global functions static. Clean up some comments and indentation. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 20 +++- 1 files changed, 11 insertions(+), 9 deletions(-)

[PATCH 24/26] atl1: update wake-on-lan

Update wake-on-lan to conform with the current vendor driver version 1.2.40.2. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 140 --- 1 files changed, 84 insertions(+), 56 deletions(-) diff --git a/drivers/net/atlx/atl1.

[PATCH 26/26] atl1: remove experimental tag and clean up comments

All major netdevice functionality is now present in the atl1 driver. As a result, remove the EXPERIMENTAL Kconfig tag in the main driver, but leave it in the NAPI driver. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/Kconfig |4 ++-- drivers/net/atlx/atl1.c |8 ++

[PATCH 12/26] atl1: refactor atl1_probe

Refactor atl1_probe to conform with current vendor driver version 1.2.40.2. Also reorder functions to minimize the need for forward declarations. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 1397 +++ drivers/net/atlx/atl

[PATCH 20/26] atl1: update change mtu

Update atl1_change_mtu() to conform with the current vendor driver version 1.2.40.2. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 39 ++- 1 files changed, 22 insertions(+), 17 deletions(-) diff --git a/drivers/net/atlx/atl1.c

[PATCH 05/26] atl1: print debug info if rrd error

Add some debug dev_printks if we encounter a bad receive return descriptor. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 21 - 1 files changed, 20 insertions(+), 1 deletions(-) diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c in

[PATCH 23/26] atl1: update shutdown and remove functions

Update shutdown and remove functions to conform with the current vendor driver version 1.2.40.2. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 31 +++ 1 files changed, 23 insertions(+), 8 deletions(-) diff --git a/drivers/net/atlx/atl1

[PATCH 25/26] atl1: add NAPI support

Add support for NAPI, styled after the e1000 NAPI implementation. That we follow the e1000 for NAPI shouldn't come as much of a surprise, since the entire atl1 driver is based heavily upon it. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/Kconfig | 14 drivers/net/atl

[PATCH 16/26] atl1: modernize check link function

Update atl1_check_link() to conform with the current vendor driver version 1.2.40.2. Clean up vertical spacing, indentation, and remove dead code. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 65 +++--- drivers/net/atlx/at

[PATCH 17/26] atl1: update phy config function

Update atl1_phy_config() to conform with current vendor driver version 1.2.40.2. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c index abed547..64

[PATCH 13/26] atl1: refactor interrupt handling

Refactor interrupt handling to conform with the current vendor driver version 1.2.40.2. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 196 ++- drivers/net/atlx/atl1.h | 25 +- drivers/net/atlx/atlx.c |2 +- 3 fi

[PATCH 08/26] atl1: additional DMA engine configuration

Add DMA engine configuration tweaks per current vendor atl1 driver version 1.2.40.2. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 10 ++ drivers/net/atlx/atlx.h |6 ++ 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/drivers/net/atl

[PATCH 04/26] atl1: add ethtool register dump

Add the ethtool register dump option to the atl1 driver. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 53 +++ drivers/net/atlx/atl1.h |1 + 2 files changed, 54 insertions(+), 0 deletions(-) diff --git a/drivers/net

[PATCH 19/26] atl1: modernize down/up functions

Update atl1_down() and atl1_up() to conform with the current vendor driver version 1.2.40.2. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 21 - drivers/net/atlx/atl1.h |1 - drivers/net/atlx/atlx.c |2 +- 3 files changed, 9 insertions(

[PATCH 10/26] atl1: use csum_start

Use skb->csum_start for tx checksum offload preparation. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c index b0c3273..31aad9f 100644 --

[PATCH 06/26] atl1: update initialization parameters

Update initialization parameters to match the current vendor driver version 1.2.40.2. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c

[PATCH 07/26] atl1: clarify max rx frame size

When we initially set max rx frame size, we don't explicitly allow room for the VLAN header; it's done later in a somewhat obscure fashion. Let's make it clear from the top that we've allowed enough room for the VLAN header. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl

[PATCH 00/26] atl1: divide and modernize

[Neglected to cc netdev in the first wave.] Hello Jeff, Happy New Year to you and all. In preparation for a future atl2 driver for the Atheros L2 10/100 chip, we propose to move the existing atl1 driver to a new directory (drivers/net/atlx), then split out functions and definitions that both at

[PATCH 03/26] atl1: fix broken TSO

The L1 tx packet descriptor expects TCP Header Length to be expressed as a number of 32-bit dwords. The atl1 driver uses tcp_hdrlen() to populate the field, but tcp_hdrlen() returns the header length in bytes, not in dwords. Add a shift to convert tcp_hdrlen() to dwords when we write it to the tpd

[PATCH 09/26] atl1: refactor tx processing

Refactor tx processing to use a less convoluted tx packet descriptor and to conform generally with the vendor's current version 1.2.40.2. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 265 +-- drivers/net/atlx/atl1.h | 2

[PATCH 01/26] atl1: relocate atl1 driver to /drivers/net/atlx

In preparation for a future Atheros L2 NIC driver (called atl2), relocate the atl1 driver into a new /drivers/net/atlx directory that will ultimately be shared with the future atl2 driver. Signed-off-by: Chris Snook <[EMAIL PROTECTED]> Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/ne

[PATCH 14/26] atl1: move stray defines to header file

Move some stray defines out to a header file. Improve indentation from ghastly to horrid. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 29 - drivers/net/atlx/atl1.h |6 ++ 2 files changed, 18 insertions(+), 17 deletions(-) di

Re: [PATCH 0/4] New interface for memory accounting (take 1)

From: Eric Dumazet <[EMAIL PROTECTED]> Date: Mon, 31 Dec 2007 16:17:37 +0100 > Could you add the following patch, because it apparently was lost > during the battle :) > > Thank you > > [PATCH] use SK_MEM_QUANTUM_SHIFT in __sk_mem_reclaim() > > Avoid an expensive divide (as done in commit > 18

Re: [PATCH 3/3] [TCP]: Remove unnecessary local variable

From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 31 Dec 2007 16:21:47 +0200 > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel

Re: [PATCH 2/3] [TCP]: Code duplication removal, added tcp_bound_to_half_wnd()

From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 31 Dec 2007 16:21:46 +0200 > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel

Re: [PATCH 1/3] [TCP]: cleanup tcp_{in,out}put.c style

From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 31 Dec 2007 16:21:45 +0200 > These were manually selected from indent's results which as is > are too noisy to be of any use without human reason. In addition, > some extra newlines between function and its comment were removed > too. > > Signe

Re: [PATCH] Force UNIX domain sockets to be built in

On Dec 31 2007 18:43, Patrick Mau wrote: > >May I ask something that might be obvious for most of the >development community: > >Modules have to be loaded in seperate pages, right ? That seems to be the case, judging from /proc/modules always ending in 000, meaning each module is aligned at 0x100

Re: 2.6.24-rc6-mm1 - git-lblnet.patch and networking horkage

On Monday 31 December 2007 4:46:09 pm James Morris wrote: > On Mon, 31 Dec 2007, Paul Moore wrote: > > I'm pretty certain this is an uninitialized value problem now and not a > > use-after-free issue. The invalid/garbage ->iif value seems to only > > happen on packets that are generated locally an

Re: [PATCH] Re: Nested VLAN causes recursive locking error

On Mon, Dec 31, 2007 at 06:45:55PM +0100, Jarek Poplawski wrote: > On Mon, Dec 31, 2007 at 04:04:17PM +0100, Patrick McHardy wrote: ... > > That will increment the subclass globally, but it should actually just > > use real_dev->subclass + 1. [...] ... > to two subclasses - any nested vlan gets sec

Re: 2.6.24-rc6-mm1 - git-lblnet.patch and networking horkage

On Mon, 31 Dec 2007, Paul Moore wrote: > I'm pretty certain this is an uninitialized value problem now and not a > use-after-free issue. The invalid/garbage ->iif value seems to only happen > on packets that are generated locally and sent back into the stack for local > consumption, e.g. loopb

Re: [PATCH] USB VID/PID clash between pegasus and hci_usb drivers

Hi Chris, > As requested, here is the patch for the pegasus driver to resolve its VID/PID > clash with the > Belkin bluetooth adaptor. Acked-by: Marcel Holtmann <[EMAIL PROTECTED]> Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: 2.6.24-rc6-mm1

On Dec 30, 2007 4:34 AM, Torsten Kaiser <[EMAIL PROTECTED]> wrote: > On Dec 30, 2007 2:30 AM, Herbert Xu <[EMAIL PROTECTED]> wrote: > > On Sat, Dec 29, 2007 at 05:51:13PM +0100, Torsten Kaiser wrote: > > > > > > > > The cause, why I am resending this: I just got a crash with > > > > > 2.6.24-rc6-mm

Re: 2.6.24-rc6-mm1 - git-lblnet.patch and networking horkage

On Monday 31 December 2007 12:13:32 pm Paul Moore wrote: > On Wednesday 26 December 2007 4:52:03 pm James Morris wrote: > > On Thu, 26 Dec 2007, Paul Moore wrote: > > > As James said I'm away right now and computer access is limited. > > > However, I'm stuck in the airport right now and spent some

Re: [PATCH] Force UNIX domain sockets to be built in

On Mon, Dec 31, 2007 at 03:03:20PM +0100, Bodo Eggert wrote: > On Mon, 31 Dec 2007, David Miller wrote: > > From: Bodo Eggert <[EMAIL PROTECTED]> > > > > As suggested by Adrian Bunk, UNIX domain sockets should always be built > > > in > > > on normal systems. This is especially true since udev n

Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

On Mon, Dec 31, 2007 at 12:49:52PM -0500, Alan Stern wrote: > On Sun, 30 Dec 2007, Greg KH wrote: > > > > It looks like Greg misused the debugfs API -- which is ironic, because > > > he wrote debugfs in the first place! :-) > > > > Oh crap, sorry, I did mess that up :( > > > > > Let me know if

Re: [PATCH] [IPROUTE2] IPT action compatibility with iptables 1.4.0

On Mon, 24 Dec 2007 11:55:05 -0500 jamal <[EMAIL PROTECTED]> wrote: > > Stephen, > > Please apply this patch from Denys Fedoryshchenko to make the ipt action > work with latest iptables. > > cheers, > jamal > applied and pushed -- Stephen Hemminger <[EMAIL PROTECTED]> -- To unsubscribe from

Re: [PATCH] Force UNIX domain sockets to be built in

On Monday 31 December 2007 19:37:43 Torsten Kaiser wrote: > The base problem is that there already are many options to break > external modules. (CONFIG_MODULES=n ;) ) Exactly. There already are enough ways to break external modules. No need to introduce more. ;) > The question I can't answer in

Re: [PATCH 0/4] New interface for memory accounting (take 1)

Eric Dumazet wrote: > Hi David > > Could you add the following patch, because it apparently was lost > during the battle :) > > Thank you > > [PATCH] use SK_MEM_QUANTUM_SHIFT in __sk_mem_reclaim() > > Avoid an expensive divide (as done in commit > 18030477e70a826b91608aee40a987bbd368fec6 but l

Re: [PATCH 2/3] [UDP]: memory accounting in IPv4

Hideo AOKI a écrit : Eric Dumazet wrote: Hideo AOKI a écrit : This patch adds UDP memory usage accounting in IPv4. Currently, receiving buffer accounting is only supported. This patch is also introduced memory_allocated variable for UDP protocol. OK, but sockstat_seq_show() should be updated

Re: [PATCH 1/3] [UDP]: add udp_mem, udp_rmem_min and udp_wmem_min

David Miller wrote: > From: Hideo AOKI <[EMAIL PROTECTED]> > Date: Sun, 30 Dec 2007 04:01:46 -0500 > >> diff -pruN net-2.6.25-t12t19m-p4/net/ipv4/proc.c >> net-2.6.25-t12t19m-p5/net/ipv4/proc.c >> --- net-2.6.25-t12t19m-p4/net/ipv4/proc.c2007-12-27 10:19:02.0 >> -0500 >> +++ net-2.6.

Re: [PATCH] net: santize headers for iproute2

The Glib 2.7 version of netinet/tcp.h works for building iproute2, but since iproute needs to build on older versions of glibc; for now, I'll just put a corrected version of netinet/tcp.h in the iproute2 build tree. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body o

Re: [PATCH 2/4] [CORE]: adding memory accounting points

David Miller wrote: > This patch would not apply, because is contained changes > present in the first patch, specifically: > And now I see exactly what you did, and it is quite careless. > > You wrote one big patch then tried to split it up by hand. This > proves to me that you did not test the

Re: [PATCH 0/4] New interface for memory accounting (take 1)

Hello David, David Miller wrote: > From: Hideo AOKI <[EMAIL PROTECTED]> > Date: Sun, 30 Dec 2007 03:47:33 -0500 > >> The patch set consists of the following 4 patches. >> >> [1/4] introducing new memory accounting interface >> [2/4] adding memory accounting points to consolidate functions >> [3/4

Re: [PATCH 2/3] [UDP]: memory accounting in IPv4

Eric Dumazet wrote: > Hideo AOKI a écrit : >> This patch adds UDP memory usage accounting in IPv4. Currently, >> receiving buffer accounting is only supported. >> >> This patch is also introduced memory_allocated variable for UDP protocol. > > OK, but sockstat_seq_show() should be updated so that

Re: [PATCH] Force UNIX domain sockets to be built in

On Dec 31, 2007 6:18 PM, Michael Buesch <[EMAIL PROTECTED]> wrote: > On Monday 31 December 2007 17:38:03 Alan Cox wrote: > > On Mon, 31 Dec 2007 17:17:19 +0100 > > "Torsten Kaiser" <[EMAIL PROTECTED]> wrote: > > > > > a) this could be disabled during development if you want this > > > b) this would

Re: [PATCH] Force UNIX domain sockets to be built in

On Mon, Dec 31, 2007 at 04:34:55PM +0100, Jan Engelhardt wrote: > > > >If you'd aim for a small kernel image, you would build anything as a module > >that is not requred for booting. > > > Yes, there is a tradeoff for both. > > Example: > 16:30 ichi:../net/802 > l fc.o fc.ko > -rw-r--r-- 1 jenge

Re: [PATCH] Force UNIX domain sockets to be built in

On Mon, Dec 31, 2007 at 04:19:23PM +0100, Bodo Eggert wrote: > On Mon, 31 Dec 2007, Adrian Bunk wrote: > > On Mon, Dec 31, 2007 at 02:26:42PM +0100, Bodo Eggert wrote: > > > On Mon, 31 Dec 2007, Adrian Bunk wrote: > > > > On Mon, Dec 31, 2007 at 01:09:43PM +0100, Bodo Eggert wrote: > > > > > > As

Re: [patch 7/7] netxen: fix byte-swapping in tx and rx

Here's the reworked patch. This cleans up some unnecessary byte-swapping while setting up tx and interpreting rx desc. The 64 bit rx status data should be converted to host endian format only once and the macros just need to extract bitfields. This saves a spate of interrupts on pseries blades ca

Re: [PATCH] ip[6]_tables.c: remove some inlines

On Monday 31 December 2007 17:00, Patrick McHardy wrote: > Denys Vlasenko wrote: > > ip[6]_tables.c seem to abuse inline. > > > > This patch removes inlines except those which are used > > by packet matching code and thus are performance-critical. > > > > Some people also consider the ruleset r

Re: [PATCH] Force UNIX domain sockets to be built in

On Mon, Dec 31, 2007 at 04:19:23PM +0100, Bodo Eggert wrote: > On Mon, 31 Dec 2007, Adrian Bunk wrote: > > On Mon, Dec 31, 2007 at 02:26:42PM +0100, Bodo Eggert wrote: > > > On Mon, 31 Dec 2007, Adrian Bunk wrote: > > > > On Mon, Dec 31, 2007 at 01:09:43PM +0100, Bodo Eggert wrote: > > > > > > As

Re: [PATCH] Re: Nested VLAN causes recursive locking error

On Mon, Dec 31, 2007 at 06:45:55PM +0100, Jarek Poplawski wrote: > Patric, [...] OOPS... Sorry Patrick! Jarek P. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

On Sun, 30 Dec 2007, Greg KH wrote: > > It looks like Greg misused the debugfs API -- which is ironic, because > > he wrote debugfs in the first place! :-) > > Oh crap, sorry, I did mess that up :( > > > Let me know if this patch fixes the problem. If it does, I'll submit > > it to Greg with

Re: [IPSEC]: Move all calls to xfrm_audit_state_icvfail to xfrm_input

On Sunday 30 December 2007 11:23:55 pm Herbert Xu wrote: > Hi Dave: > > While refreshing the async IPsec patches I noticed some fresh code > duplication. > > [IPSEC]: Move all calls to xfrm_audit_state_icvfail to xfrm_input > > Let's nip the code duplication in the bud :) Thanks, not sure why I di

Re: [PATCH] Re: Nested VLAN causes recursive locking error

On Mon, Dec 31, 2007 at 04:04:17PM +0100, Patrick McHardy wrote: > Jarek Poplawski wrote: >> diff -Nurp linux-2.6.24-rc5-/net/8021q/vlan.c >> linux-2.6.24-rc5+/net/8021q/vlan.c >> --- linux-2.6.24-rc5-/net/8021q/vlan.c 2007-12-17 13:29:19.0 >> +0100 >> +++ linux-2.6.24-rc5+/net/8021

Re: [PATCH] Force UNIX domain sockets to be built in

On Monday 31 December 2007 17:38:03 Alan Cox wrote: > On Mon, 31 Dec 2007 17:17:19 +0100 > "Torsten Kaiser" <[EMAIL PROTECTED]> wrote: > > > a) this could be disabled during development if you want this > > b) this would even only affect development if you add new code that > > now needs a EXPORT_

Re: [PATCH] ip[6]_tables.c: remove some inlines

Denys Vlasenko wrote: ip[6]_tables.c seem to abuse inline. This patch removes inlines except those which are used by packet matching code and thus are performance-critical. Some people also consider the ruleset replacement path performance critical, but overall I agree with your patch. I'm

Re: [PATCH] Force UNIX domain sockets to be built in

On Mon, 31 Dec 2007 17:17:19 +0100 "Torsten Kaiser" <[EMAIL PROTECTED]> wrote: > a) this could be disabled during development if you want this > b) this would even only affect development if you add new code that > now needs a EXPORT_SYMBOL that was removed on an earlier build. And > right now thi

[PATCH] ip[6]_tables.c: remove some inlines

On Friday 28 December 2007 15:30, Patrick McHardy wrote: > >> This clashes with my pending patches, which I'll push upstream > >> today. I also spent some time resyncing ip_tables and ip6_tables > >> so a diff of both (with some sed'ing) shows only the actual > >> differences, so please update ip6_

Re: Bad escriptions in Kconfig

Matthew Wilcox wrote: > On Mon, Dec 31, 2007 at 10:16:43AM -0500, Douglas Gilbert wrote: >> Bodo Eggert wrote: >>> --- >>> SCSI target support (SCSI_TGT) [N/m/y/?] (NEW) ? >>> >>> If you want to use SCSI target mode drivers enable this option. >>> If you choose M, the module will be called scsi_tgt

Re: [PATCH] Force UNIX domain sockets to be built in

On Dec 31, 2007 5:01 PM, Alan Cox <[EMAIL PROTECTED]> wrote: > > I'd say the practical advantage to the user would be almost zero. > > Which distribution is going to enable this option and defacto > > banning external modules? > > It would be a real nuisance for developing code let alone for using

Re: [PATCH] Force UNIX domain sockets to be built in

On Dec 31, 2007 4:59 PM, Michael Buesch <[EMAIL PROTECTED]> wrote: > On Monday 31 December 2007 16:55:57 Torsten Kaiser wrote: > > One thing I always wondered about in this discussion about wasted > > EXPORT_SYMBOL's: > > Shouldn't it be possible to garbage collect these? > > > > depmod already con

Re: [PATCH] Force UNIX domain sockets to be built in

> I'd say the practical advantage to the user would be almost zero. > Which distribution is going to enable this option and defacto > banning external modules? It would be a real nuisance for developing code let alone for using it. The entries are currently far bigger than is needed and fixing tha

Re: [PATCH] Force UNIX domain sockets to be built in

On Monday 31 December 2007 16:55:57 Torsten Kaiser wrote: > On Dec 31, 2007 3:42 PM, Adrian Bunk <[EMAIL PROTECTED]> wrote: > > With CONFIG_MODULES=y the 13 EXPORT_SYMBOL's that only exist for the > > theoretical possibility of CONIG_UNIX=m waste a few hundred bytes > > of memory. > > One thing I

Re: [PATCH] Force UNIX domain sockets to be built in

On Dec 31, 2007 3:42 PM, Adrian Bunk <[EMAIL PROTECTED]> wrote: > With CONFIG_MODULES=y the 13 EXPORT_SYMBOL's that only exist for the > theoretical possibility of CONIG_UNIX=m waste a few hundred bytes > of memory. One thing I always wondered about in this discussion about wasted EXPORT_SYMBOL's:

Re: Bad escriptions in Kconfig

On Mon, Dec 31, 2007 at 10:16:43AM -0500, Douglas Gilbert wrote: > Bodo Eggert wrote: > > --- > > SCSI target support (SCSI_TGT) [N/m/y/?] (NEW) ? > > > > If you want to use SCSI target mode drivers enable this option. > > If you choose M, the module will be called scsi_tgt. > > --- > > > > What

Re: [PATCH net-2.6.25 4/7][ATM]: [br2864] routed support

In message <[EMAIL PROTECTED]>,Christoph Hellwig writes: >> +#define LLC 0xaa, 0xaa, 0x03 >> +#define SNAP_BRIDGED0x00, 0x80, 0xc2 >> +#define SNAP_ROUTED 0x00, 0x00, 0x00 >> +#define PID_ETHERNET0x00, 0x07 >> +#define ETHERTYPE_IPV4 0x08, 0x00 >> +#define ETHERTYPE_IPV

Re: [PATCH] Force UNIX domain sockets to be built in

On Dec 31 2007 16:19, Bodo Eggert wrote: >Adrian Bunk wrote: >> >> The only advantage I see is that the kernel image you have to flash >> can be made smaller - with the disadvantage that the running kernel >> is bigger by more than 10%. >> >> If you don't believe me, try it yourself: >> Build a

Re: [PATCH 0/4] New interface for memory accounting (take 1)

David Miller a écrit : From: Hideo AOKI <[EMAIL PROTECTED]> Date: Sun, 30 Dec 2007 03:47:33 -0500 Hello, This patch set introduces new memory accounting interface. Current interface is written for stream protocols only. To enable memory accounting in other protocols (e.g. UDP), I enhanced the

Re: [PATCH] Force UNIX domain sockets to be built in

On Mon, 31 Dec 2007, Adrian Bunk wrote: > On Mon, Dec 31, 2007 at 02:26:42PM +0100, Bodo Eggert wrote: > > On Mon, 31 Dec 2007, Adrian Bunk wrote: > > > On Mon, Dec 31, 2007 at 01:09:43PM +0100, Bodo Eggert wrote: > > > > As suggested by Adrian Bunk, UNIX domain sockets should always be built > >

Re: Bad escriptions in Kconfig

Bodo Eggert wrote: > In some of the Kconfig files, the options are not adequately decribed. I > collected a few of the bad descriptions I found: > > > --- > Lowlevel video output switch controls (VIDEO_OUTPUT_CONTROL) [M/n/y/?] (NEW) ? > > This framework adds support for low-level control of th

Re: [PATCH] Re: Nested VLAN causes recursive locking error

Jarek Poplawski wrote: diff -Nurp linux-2.6.24-rc5-/net/8021q/vlan.c linux-2.6.24-rc5+/net/8021q/vlan.c --- linux-2.6.24-rc5-/net/8021q/vlan.c 2007-12-17 13:29:19.0 +0100 +++ linux-2.6.24-rc5+/net/8021q/vlan.c 2007-12-20 14:21:02.0 +0100 @@ -307,12 +307,15 @@ int unregister_vlan

Re: [PATCH 1/3] [UDP]: add udp_mem, udp_rmem_min and udp_wmem_min

David Miller a écrit : From: Eric Dumazet <[EMAIL PROTECTED]> Date: Mon, 31 Dec 2007 09:54:32 +0100 Maybe I read the patch incorrectly, or we could add some new sysctl so that we not try to uncharge memory if a socket 'forward_alloc' is beyond a given limit (say 2 pages), so that number of ato

Re: [PATCH] Force UNIX domain sockets to be built in

On Mon, Dec 31, 2007 at 02:26:42PM +0100, Bodo Eggert wrote: > On Mon, 31 Dec 2007, Adrian Bunk wrote: > > On Mon, Dec 31, 2007 at 01:09:43PM +0100, Bodo Eggert wrote: > > > > As suggested by Adrian Bunk, UNIX domain sockets should always be built > > > in > > > on normal systems. This is especi

[PATCH 3/3] [TCP]: Remove unnecessary local variable

Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- net/ipv4/tcp_output.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index b3110fc..f6d279a 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c @@ -995,9 +995,8

[PATCH 2/3] [TCP]: Code duplication removal, added tcp_bound_to_half_wnd()

Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- net/ipv4/tcp_output.c | 19 +++ 1 files changed, 11 insertions(+), 8 deletions(-) diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index bb7e80a..b3110fc 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c

Re: [PATCH 3/9] [TCP]: Remove unnecessary local variables

On Mon, 31 Dec 2007, David Miller wrote: > From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> > Date: Mon, 31 Dec 2007 12:47:51 +0200 > > > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> > ... > > > > - in_flight = tcp_packets_in_flight(tp); > > - cwnd = tp->snd_cwnd; > > - if (in_flight < cwnd

Re: [PATCH] Force UNIX domain sockets to be built in

On Mon, 31 Dec 2007, David Miller wrote: > From: Bodo Eggert <[EMAIL PROTECTED]> > > As suggested by Adrian Bunk, UNIX domain sockets should always be built in > > on normal systems. This is especially true since udev needs these sockets > > and fails to run if UNIX=m. > > > > Signed-Off-By: Bod

[PATCH] USB VID/PID clash between pegasus and hci_usb drivers

Hi, As requested, here is the patch for the pegasus driver to resolve its VID/PID clash with the Belkin bluetooth adaptor. Cheers, Chris __ Sent from Yahoo! Mail - a smarter inbox http://uk.mail.yahoo.com --- linux-2.6.23/drivers/n

Re: [PATCH] Force UNIX domain sockets to be built in

On Mon, 31 Dec 2007, Adrian Bunk wrote: > On Mon, Dec 31, 2007 at 01:09:43PM +0100, Bodo Eggert wrote: > > As suggested by Adrian Bunk, UNIX domain sockets should always be built in > > on normal systems. This is especially true since udev needs these sockets > > and fails to run if UNIX=m. > >

Re: [PATCH] Force UNIX domain sockets to be built in

when i had that module modular and added to the initrd, udev didn`t work, though. same error message: udevd[1226]: init_udev_socket: error getting socket: Address family not supported by protocol not sure if i did a mistake here anyway, this message is not obvious to the end user. i like

Re: 2.6.24-rc6-mm1

On Dec 30, 2007 10:35 PM, Torsten Kaiser <[EMAIL PROTECTED]> wrote: > On Dec 30, 2007 10:24 PM, J. Bruce Fields <[EMAIL PROTECTED]> wrote: > > From: Tom Tucker <[EMAIL PROTECTED]> > > Date: Sun, 30 Dec 2007 10:07:17 -0600 > > > > Bruce/Aime: > > > > Here is what I believe to be the fix for the

Re: [PATCH 9/9] [TCP]: Code duplication removal, added tcp_bound_to_half_wnd()

From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 31 Dec 2007 12:47:57 +0200 > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> And because patch 3 and 8 aren't applied, this one will need to be refreshed as well. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH 8/9] [TCP]: cleanup tcp_{in,out}put.c style

From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 31 Dec 2007 12:47:56 +0200 > These were manually selected from indent's results which as is > are too noisy to be of any use without human reason. In addition, > some extra newlines between function and its comment were removed > too. > > Signe

Re: [PATCH 7/9] [TCP]: reduce tcp_output's indentation levels a bit

From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 31 Dec 2007 12:47:55 +0200 > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel

Re: [PATCH 6/9] [TCP]: Remove TCPCB_URG & TCPCB_AT_TAIL as unnecessary

From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 31 Dec 2007 12:47:54 +0200 > The snd_up check should be enough. I suspect this has been > there to provide a minor optimization in clean_rtx_queue which > used to have a small if (!->sacked) block which could skip > snd_up check among the other

Re: [PATCH 5/9] [TCP]: Dropped unnecessary skb/sacked accessing in reneging

From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 31 Dec 2007 12:47:53 +0200 > SACK reneging can be precalculated to a FLAG in clean_rtx_queue > which has the right skb looked up. This will help a bit in > future because skb->sacked access will be changed eventually, > changing it already won't

Re: [PATCH 4/9] [TCP]: Introduce tcp_wnd_end() to reduce line lengths

From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 31 Dec 2007 12:47:52 +0200 > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel

Re: [PATCH 3/9] [TCP]: Remove unnecessary local variables

From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 31 Dec 2007 12:47:51 +0200 > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> ... > > - in_flight = tcp_packets_in_flight(tp); > - cwnd = tp->snd_cwnd; > - if (in_flight < cwnd) > - return (cwnd - in_flight); > + i

Re: [PATCH 2/9] [TCP]: Rename update_send_head & include related increment to it

From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 31 Dec 2007 12:47:50 +0200 > There's very little need to have the packets_out incrementing in > a separate function. Also name the combined function > appropriately. > > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> Applied. -- To unsubscri

Re: [PATCH 1/9] [TCP]: Make invariant check complain about invalid sacked_out

From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 31 Dec 2007 12:47:49 +0200 > Earlier resolution for NewReno's sacked_out should now keep > it small enough for this to become invariant-like check. > > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list:

Re: [PATCH net-2.6.25] [IPV4] Remove unused multipath cached routing defintion in net/flow.h

From: "Rami Rosen" <[EMAIL PROTECTED]> Date: Mon, 31 Dec 2007 13:15:19 +0200 > The FLOWI_FLAG_MULTIPATHOLDROUTE definition in include/net/flow.h is an unused > definition. It belongs to IPV4 multipath cached routing support, >which has been dropped recently for 2.6.23 kernel (July 2007). Ye

  1   2   >