Re: [patch 2/4] net: use mutex_is_locked() for ASSERT_RTNL()

2007-12-16 Thread Jarek Poplawski
On Mon, Dec 17, 2007 at 03:31:33PM +0800, Herbert Xu wrote: > On Mon, Dec 17, 2007 at 08:26:01AM +0100, Jarek Poplawski wrote: > > > > Btw. #2: David Miller gave this example of ASSERT_RTNL use: > > > > ASSERT_RTNL(); > > page = alloc_page(GFP_KERNEL); > > > > But isn't there a debugging

Re: [patch 2/4] net: use mutex_is_locked() for ASSERT_RTNL()

2007-12-16 Thread Jarek Poplawski
On Mon, Dec 17, 2007 at 08:26:01AM +0100, Jarek Poplawski wrote: > On Mon, Dec 17, 2007 at 09:26:32AM +0800, Herbert Xu wrote: ... > > I retract what I've said in this thread and continue to oppose > > this change without a might_sleep. ... > So, I think using might_sleep() explicitly would be much

Re: [patch 2/4] net: use mutex_is_locked() for ASSERT_RTNL()

2007-12-16 Thread Herbert Xu
On Mon, Dec 17, 2007 at 08:26:01AM +0100, Jarek Poplawski wrote: > > Btw. #2: David Miller gave this example of ASSERT_RTNL use: > > ASSERT_RTNL(); > page = alloc_page(GFP_KERNEL); > > But isn't there a debugging duplication: it seems alloc_page() is used > in so many places and this

Re: [patch 2/4] net: use mutex_is_locked() for ASSERT_RTNL()

2007-12-16 Thread Jarek Poplawski
On Mon, Dec 17, 2007 at 09:26:32AM +0800, Herbert Xu wrote: > On Sun, Dec 16, 2007 at 07:06:41PM +0100, Jarek Poplawski wrote: > > > > It seemed to exist a few days ago: > > http://kerneltrap.org/mailarchive/linux-netdev/2007/12/4/473123 > > > > Btw., I don't know which of the patches: Eric's or y

RE: [PATCH 2/3] arch/ : Platform changes for UCC TDM driver for MPC8323ERDB.Also includes related QE changes.

2007-12-16 Thread Aggrwal Poonam
Thanks Stephen for your comments. I have gone through them. Shall incorporate them and repost the patch. Sorry for late reply as I was on leave for the last week. With Regards Poonam -Original Message- From: Stephen Rothwell [mailto:[EMAIL PROTECTED] Sent: Tuesday, December 11, 2

[PATCH] NET: ns83820.c remove fastcall macro

2007-12-16 Thread Harvey Harrison
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Dave, this is the remainder of the FASTCALL/fastcall removal patch that is not already in your tree. Generated against net-2.6.25.git drivers/net/ns83820.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drive

Re: [PATCH] bridge: assign random address

2007-12-16 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Sun, 16 Dec 2007 18:55:48 -0800 > Kinda funny. I (and I bet lots of others) spend a lot of time > fixing, cleaning up and totally rewriting patch titles. It's probably the majority of the typing I perform to apply a patch except for the folks who for

Re: [PATCH] [NET]: Remove FASTCALL/fastcall macros

2007-12-16 Thread David Miller
From: Harvey Harrison <[EMAIL PROTECTED]> Date: Sun, 16 Dec 2007 20:16:25 -0800 > X86_32 was the last user of the FASTCALL/fastcall macros, now that it > uses regparm(3) by default, these macros expand to nothing. > > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> > --- > Dave, this is a wrap

Re: [PATCH net-2.6.25 8/8] Remove unused IPV4TYPE macros

2007-12-16 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Sun, 16 Dec 2007 20:01:06 -0800 > On Sun, 2007-12-16 at 13:48 -0800, David Miller wrote: > > From: Joe Perches <[EMAIL PROTECTED]> > > Date: Thu, 13 Dec 2007 15:39:01 -0800 > > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > > Applied, thanks for doin

Re: [PATCH] bridge: assign random address

2007-12-16 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Sun, 16 Dec 2007 20:46:24 -0500 > David Miller wrote: > > [Patch 1/7] [SUBSYSTEM]: Foo bar baz... > > The most popular tool is git-am, which I and many others use. > > git-am will snip "[SUBSYSTEM]" in the example that you give. It should only snip th

[PATCH] [NET]: Remove FASTCALL/fastcall macros

2007-12-16 Thread Harvey Harrison
X86_32 was the last user of the FASTCALL/fastcall macros, now that it uses regparm(3) by default, these macros expand to nothing. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Dave, this is a wrap-up of my patch in your net-2.6.25.git with the build breakage fix from Andrew Morton include

Re: [PATCH net-2.6.25 8/8] Remove unused IPV4TYPE macros

2007-12-16 Thread Joe Perches
On Sun, 2007-12-16 at 13:48 -0800, David Miller wrote: > From: Joe Perches <[EMAIL PROTECTED]> > Date: Thu, 13 Dec 2007 15:39:01 -0800 > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > Applied, thanks for doing this work Joe. I broke the parisc build. Bad Joe... Here's the patch: Signed-off-

Re: [PATCH] bridge: assign random address

2007-12-16 Thread Andrew Morton
On Sun, 16 Dec 2007 20:46:24 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > David Miller wrote: > > From: Andrew Morton <[EMAIL PROTECTED]> > > Date: Sun, 16 Dec 2007 14:29:15 -0800 > > > >> On Sun, 16 Dec 2007 13:37:17 -0800 (PST) David Miller <[EMAIL PROTECTED]> > >> wrote: > >> > >>> From: St

Re: [PATCH] bridge: assign random address

2007-12-16 Thread Jeff Garzik
David Miller wrote: From: Andrew Morton <[EMAIL PROTECTED]> Date: Sun, 16 Dec 2007 14:29:15 -0800 On Sun, 16 Dec 2007 13:37:17 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 15:48:35 -0800 Subject: Re: [PATCH] bridge: a

Re: [patch 2/4] net: use mutex_is_locked() for ASSERT_RTNL()

2007-12-16 Thread Herbert Xu
On Sun, Dec 16, 2007 at 07:06:41PM +0100, Jarek Poplawski wrote: > > It seemed to exist a few days ago: > http://kerneltrap.org/mailarchive/linux-netdev/2007/12/4/473123 > > Btw., I don't know which of the patches: Eric's or yours will be chosen, > but, IMHO, there is no reason to remove rtnl_tryl

net-2.6.25 rebased...

2007-12-16 Thread David Miller
I needed to rebase for two reasons: 1) Ilpo asked me to revert a lot of TCP stuff and the easiest way to do that was during a rebase. 2) Patrick McHardy needs some of the pending net-2.6 bug fixes in there in order to send me patches for some netfilter compat stuff. It's all there in t

Re: [PATCH] bridge: assign random address

2007-12-16 Thread Andrew Morton
On Sun, 16 Dec 2007 15:40:18 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Sun, 16 Dec 2007 15:34:42 -0800 > > > Take a look at the git logs, see what most other people are doing. > > You're talking bucking a convention that has been used >

Re: [PATCH] PS3: gelic: Add wireless support for PS3

2007-12-16 Thread Jouni Malinen
On Sun, Dec 16, 2007 at 06:10:10PM -0500, Dan Williams wrote: > On Sun, 2007-12-16 at 10:11 -0800, Jouni Malinen wrote: > > It is a new key type regardless of whether it is PSK or passphrase. The > > current key types (IW_AUTH_CIPHER_*) are WEP40, TKIP, CCMP, and WEP104.. > Ah, it's a different ke

Re: [PATCH] bridge: assign random address

2007-12-16 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Sun, 16 Dec 2007 15:34:42 -0800 > Take a look at the git logs, see what most other people are doing. You're talking bucking a convention that has been used for all networking changes since we starting using real revision control. I've shown how the s

Re: [PATCH] bridge: assign random address

2007-12-16 Thread Randy Dunlap
On Sun, 16 Dec 2007 15:26:06 -0800 (PST) David Miller wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Sun, 16 Dec 2007 14:29:15 -0800 > > > On Sun, 16 Dec 2007 13:37:17 -0800 (PST) David Miller <[EMAIL PROTECTED]> > > wrote: > > > > > From: Stephen Hemminger <[EMAIL PROTECTED]> > > > D

Re: [PATCH] bridge: assign random address

2007-12-16 Thread Andrew Morton
On Sun, 16 Dec 2007 15:26:06 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Sun, 16 Dec 2007 14:29:15 -0800 > > > On Sun, 16 Dec 2007 13:37:17 -0800 (PST) David Miller <[EMAIL PROTECTED]> > > wrote: > > > > > From: Stephen Hemminger <[EMAIL

Re: [PATCH] bridge: assign random address

2007-12-16 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Sun, 16 Dec 2007 14:29:15 -0800 > On Sun, 16 Dec 2007 13:37:17 -0800 (PST) David Miller <[EMAIL PROTECTED]> > wrote: > > > From: Stephen Hemminger <[EMAIL PROTECTED]> > > Date: Tue, 11 Dec 2007 15:48:35 -0800 > > > > > Subject: Re: [PATCH] bridge: a

Re: sockets affected by IPsec always block (2.6.23)

2007-12-16 Thread David Miller
From: Bill Davidsen <[EMAIL PROTECTED]> Date: Sun, 16 Dec 2007 17:47:24 -0500 > David Miller wrote: > > From: Herbert Xu <[EMAIL PROTECTED]> > > Date: Wed, 5 Dec 2007 11:12:32 +1100 > > > >> [INET]: Export non-blocking flags to proto connect call > >> > >> Previously we made connect(2) block on I

Re: [PATCH] PS3: gelic: Add wireless support for PS3

2007-12-16 Thread Dan Williams
On Sun, 2007-12-16 at 10:11 -0800, Jouni Malinen wrote: > On Sun, Dec 16, 2007 at 12:49:14PM -0500, Dan Williams wrote: > > > Yeah, I was going to propose that on Friday but got side-tracked. What > > would require a new key type? Are there some firmwares that _only_ > > accept the WPA passphras

Re: [PATCH] bridge: assign random address

2007-12-16 Thread Andrew Morton
On Sun, 16 Dec 2007 13:37:17 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Tue, 11 Dec 2007 15:48:35 -0800 > > > Subject: Re: [PATCH] bridge: assign random address > > "bridge" should all-caps and in brackets, No, "bridge" should not b

Re: sockets affected by IPsec always block (2.6.23)

2007-12-16 Thread Bill Davidsen
David Miller wrote: From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 5 Dec 2007 11:12:32 +1100 [INET]: Export non-blocking flags to proto connect call Previously we made connect(2) block on IPsec SA resolution. This is good in general but not desirable for non-blocking sockets. To fix this pr

Re: Fw: [PACKET]: Fix /proc/net/packet crash due to bogus private pointer

2007-12-16 Thread Andrew Morton
On Sun, 16 Dec 2007 15:10:14 -0500 "Miles Lane" <[EMAIL PROTECTED]> wrote: > On Dec 16, 2007 3:19 AM, Herbert Xu <[EMAIL PROTECTED]> wrote: > > On Sat, Dec 15, 2007 at 11:56:04PM -0800, Andrew Morton wrote: > > > On Sun, 16 Dec 2007 01:37:01 -0500 "Miles Lane" <[EMAIL PROTECTED]> wrote: > > > > >

Re: [PATCH net-2.6.25] Revert recent TCP work

2007-12-16 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Fri, 14 Dec 2007 22:14:29 +0200 (EET) > Could you either drop my recent patches (+one fix to them from Herbert > Xu == "[TCP]: Fix crash in tcp_advance_send_head"), all mine after "[TCP]: > Abstract tp->highest_sack accessing & point to next skb" fr

Re: [PATCH 5/5] [IrDA] irda parameters warning fixes.

2007-12-16 Thread David Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Mon, 17 Dec 2007 00:46:53 +0100 > This patch fixes: > CHECK /home/kernel/src/net/irda/parameters.c > /home/kernel/src/net/irda/parameters.c:466:2: warning: Using plain integer as > NULL pointer > /home/kernel/src/net/irda/parameters.c:520:2: warnin

Re: [PATCH 4/5] [IrDA] stir4200 fixes

2007-12-16 Thread David Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Mon, 17 Dec 2007 00:46:52 +0100 > The attached patch observes the stir4200 fifo size and will clear the fifo, if > the size is increasing, while it should be transmitting bytes > > From: Olaf Hartmann <[EMAIL PROTECTED]> > Signed-off-by: Samuel Ortiz <

Re: oops with 2.6.23.1, marvel, software raid, reiserfs and samba

2007-12-16 Thread Andrew Morton
On Sun, 16 Dec 2007 06:55:51 -0800 jeffunit <[EMAIL PROTECTED]> wrote: > At 03:05 AM 12/16/2007, Andrew Morton wrote: > >On Fri, 07 Dec 2007 19:49:52 -0800 jeffunit <[EMAIL PROTECTED]> wrote: > > > > > I am running linux kernel 2.6.23.1, which I compiled. > > > The base system was mandriva 2008. >

Re: [PATCH 3/5] [IrDA] irlmp_unregister_link needs to free lsaps

2007-12-16 Thread David Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Mon, 17 Dec 2007 00:46:51 +0100 > While testing the mcs7780 based IrDA USB dongle I've stumbled upon > memory leak in irlmp_unregister_link(). Hashbin for lsaps is created in > irlmp_register_link and should probably be freed in irlmp_unregister_link().

Re: [PATCH 2/5] [IrDA] mcs7780 needs to free allocated rx buffer

2007-12-16 Thread David Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Mon, 17 Dec 2007 00:46:50 +0100 > While testing the mcs7780 based IrDA USB dongle I've stumbled upon > memory leak in mcs_net_close(). Patch below fixes it. > > From: Hinko Kocevar <[EMAIL PROTECTED]> > Signed-off-by: Hinko Kocevar <[EMAIL PROTECTED]>

Re: [PATCH 1/5] [IrDA] Race between open and disconnect in irda-usb

2007-12-16 Thread David Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Mon, 17 Dec 2007 00:46:49 +0100 > It seems to me that irda_usb_net_open() must set self->netopen > under spinlock or disconnect() may fail to kill all URBs, if it is called > while an interface is opened. > > From: Oliver Neukum <[EMAIL PROTECTED]> > S

Re: [PATCH] SCTP: Flush fragment queue when exiting partial delivery

2007-12-16 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Sun, 16 Dec 2007 02:08:36 -0500 > At the end of partial delivery, we may have complete messages > sitting on the fragment queue. These messages are stuck there > until a new fragment arrives. This can comletely stall a > given association. When clea

Re: [PATCH 2.6.25] SCTP: Use crc32c library for checksum calculations.

2007-12-16 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Sun, 16 Dec 2007 02:10:45 -0500 > The crc32c library used an identical table and algorithm > as SCTP. Switch to using the library instead of carrying > our own table. Using crypto layer proved to have too > much overhead compared to using the library

Re: [PACKET]: Fix /proc/net/packet crash due to bogus private pointer

2007-12-16 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sun, 16 Dec 2007 11:41:20 +0800 > [PACKET]: Fix /proc/net/packet crash due to bogus private pointer > > The seq_open_net patch changed the meaning of seq->private. > Unfortunately it missed two spots in AF_PACKET, which still > used the old way of derefe

Re: [PATCH take2] [AX25] circular locking with AX25 connection timeout

2007-12-16 Thread David Miller
From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Sat, 15 Dec 2007 11:18:10 +0100 > On Fri, Dec 14, 2007 at 11:29:28PM +0100, Bernard Pidoux wrote: > > Hi, > > > > This patch cancels a circular locking conflict that appeared with a timeout > > of an AX25 connection. > > > > signed off by Jarek Popl

Re: [PATCH] [IPV4]: Make tcp_input_metrics() get minimum RTO via tcp_rto_min()

2007-12-16 Thread David Miller
From: "Satoru SATOH" <[EMAIL PROTECTED]> Date: Sat, 15 Dec 2007 11:44:46 +0900 > tcp_input_metrics() refers to the built-time constant TCP_RTO_MIN > regardless of configured minimum RTO with iproute2. > > The following fixes that. > > > Signed-off-by: Satoru SATOH <[EMAIL PROTECTED]> Thanks fo

Re: 2.6.24-rc5-mm1 -- inconsistent {in-softirq-W} -> {softirq-on-R} usage.

2007-12-16 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Fri, 14 Dec 2007 15:36:33 -0800 > The networking bug looks to be around sock_i_ino()'s taking of > sk_callback_lock with softirq's enabled. Perhaps this will fix it. One should be suspicious of any case where write_lock is performed on sk->sk_callbac

Re: [PATCH net-2.6.25 7/8] drivers/infiniband: Use ipv4_is_

2007-12-16 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 15:39:00 -0800 > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/m

Re: [PATCH net-2.6.25 8/8] Remove unused IPV4TYPE macros

2007-12-16 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 15:39:01 -0800 > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Applied, thanks for doing this work Joe. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo i

Re: [PATCH net-2.6.25 5/8] net/netfilter: Use ipv4_is_

2007-12-16 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 15:38:58 -0800 > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/m

Re: [PATCH net-2.6.25 6/8] sctp: Use ipv4_is_

2007-12-16 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 15:38:59 -0800 > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/m

Re: [PATCH net-2.6.25 4/8] net/ipv4: Use ipv4_is_

2007-12-16 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 15:38:57 -0800 > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/m

Re: [PATCH net-2.6.25 2/8] include/net: Use ipv4_is_

2007-12-16 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 15:38:55 -0800 > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.or

Re: [PATCH net-2.6.25 3/8] net/core: Use ipv4_is_

2007-12-16 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 15:38:56 -0800 > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/m

Re: [PATCH net-2.6.25 1/8] Create ipv4_is_(__be32 addr) functions

2007-12-16 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 15:38:54 -0800 > Change IPV4 specific macros LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and > ZERONET > macros to inline functions ipv4_is_(__be32 addr) > > Adds type safety and arguably some readability. > > Changes since last submissio

Re: [PATCH 1/2] tulip: napi full quantum bug

2007-12-16 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 09:35:45 -0800 > This should fix the kernel warn/oops reported while routing. > > The tulip driver has a fencepost bug with new NAPI in 2.6.24 > It has an off by one bug if a full quantum is reached. > > Signed-off-by: Stephen He

Re: [PATCH] IPv6: Fix the return value of ipv6_getsockopt

2007-12-16 Thread David Miller
From: Wei Yongjun <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 14:44:00 +0900 > If CONFIG_NETFILTER if not selected when compile the kernel source code, > ipv6_getsockopt will returen an EINVAL error if optname is not supported by > the kernel. But if CONFIG_NETFILTER is selected, ENOPROTOOPT error

Re: [RFT] tehuti: napi fix

2007-12-16 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 13:58:52 -0800 > This should fix the tehuti napi fence post problems by getting > rid of priv->napi_stop, and setting weight to 32 (like other 10G). > > Also, used the wierd entry/exit macro's like rest of driver. It fixes the fe

Re: [PATCH] bridge: assign random address

2007-12-16 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 15:48:35 -0800 > Subject: Re: [PATCH] bridge: assign random address "bridge" should all-caps and in brackets, "assign random address" should be capitalized like a proper english sentence with a period at the end. These are change

Re: [PATCH] [NET]: Fix Ooops of napi net_rx_action.

2007-12-16 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 15:42:22 -0800 > Perhaps we should change the warning to identify the guilty device. Applied. Stephen, you often don't supply a proper signoff line for one-off changes like this and I find it very irritating. It doesn't cost you

Re: [PATCH net-2.6.25 7/7] Switch users of ipv4_devconf(_all) to use the pernet one

2007-12-16 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 21:02:18 +0300 > These are scattered over the code, but almost all the > "critical" places already have the proper struct net > at hand except for snmp proc showing function and routing > rtnl handler. > > Signed-off-by: Pavel Eme

Re: [PATCH net-2.6.25 5/7] Move the devinet pointers on the struct net

2007-12-16 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 20:57:18 +0300 > This is the core. > > Add all and default pointers on the netns_ipv4 and register > a new pernet subsys to initialize them. > > Also add the ctl_table_header to register the > net.ipv4.ip_forward ctl. > > I don't

Re: [PATCH net-2.6.25 6/7] Switch users of ipv4_devconf_dflt to use the pernet one

2007-12-16 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 20:59:58 +0300 > They are all collected in the net/ipv4/devinet.c file and > mostly use the IPV4_DEVCONF_DFLT macro. > > So I add the net parameter to it and patch users accordingly. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTE

Re: [PATCH net-2.6.25 4/7] Store the net pointer on devinet's ctl tables

2007-12-16 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 20:53:55 +0300 > Some handers and strategies of devinet sysctl tables need > to know the net to propagate the ctl change to all the > net devices. > > I use the (currently unused) extra2 pointer on the tables > to get it. > > Holdi

Re: [PATCH net-2.6.25 3/7] Pass the net pointer to the arp_req_set_proxy()

2007-12-16 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 20:50:59 +0300 > This one will need to set the IPV4_DEVCONF_ALL(PROXY_ARP), but > there's no ways to get the net right in place, so we have to > pull one from the inet_ioctl's struct sock. > > Signed-off-by: Pavel Emelyanov <[EMAIL

Re: [PATCH net-2.6.25 2/7] Make __devinet_sysctl_register return an error

2007-12-16 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 20:48:44 +0300 > Currently, this function is void, so failures in creating > sysctls for new/renamed devices are not reported to anywhere. > > Fixing this is another complex (needed?) task, but this > return value is needed during t

Re: [PATCH net-2.6.25 1/7] Add the netns_ipv4 struct

2007-12-16 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 20:45:58 +0300 > The ipv4 will store its parameters inside this structure. > This one is empty now, but it will be eventually filled. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list:

Re: [PATCH 0/4] [UDP]: memory accounting and limitation (take 10)

2007-12-16 Thread Hideo AOKI
David Miller wrote: > From: Hideo AOKI <[EMAIL PROTECTED]> > Date: Sat, 15 Dec 2007 00:07:44 -0500 > >> Changelog take 9 -> take 10: >> * supported using sk_forward_alloc >> * introduced several memory accounting functions with spin lock >> * changed detagram receive functions to be able to cus

Re: [PATCH 2/4] [CORE]: datagram: mem_scheudle functions

2007-12-16 Thread Hideo AOKI
Hello, Thank you for your quick comments. Herbert Xu wrote: >> +spin_lock_irqsave(&sk->sk_lock.slock, flags); > > Please use bh_lock_sock since this must never be used from an > IRQ handler. I'll try to re-implement this locking mechanism as David suggested. >> +static inline void sk_mem_r

[BUG] lack of /proc/net/ax25 with 2.6.24-rc5

2007-12-16 Thread Bernard Pidoux
With 2.6.24-rc5 there is no /proc/net/ax25 Here is an extract from dmesg after boot : === sysctl table check failed: /net/ax25/ax0/ax25_default_mode .3.9.1.2 Unknown sysctl binary path Pid: 2936, comm: kissattach Not tainted 2.6.24-rc5 #1 [] set_fail+0x3b/0x43 [] sysctl_c

[PATCH] endianness annotations and fixes for olympic

2007-12-16 Thread Al Viro
* missing braces in !readl(...) & ... * trivial endianness annotations * in olympic_arb_cmd() the loop collecting fragments of packet is b0rken on big-endian - we have (next_ptr && (buf_ptr=olympic_priv->olympic_lap + ntohs(next_ptr))) as condition and it should have

[PATCH] net/ipv4/netfilter/ip_tables.c: remove some inlines

2007-12-16 Thread Denys Vlasenko
Hi Patrick, Harald, I was working on unrelated problem and noticed that ip_tables.c seem to abuse inline. I prepared a patch which removes inlines except those which are used by packet matching code (and thus are really performance-critical). I added comments explaining that remaining inlines are

Re: Badness at net/core/dev.c:2199

2007-12-16 Thread Evgeniy Polyakov
On Sun, Dec 16, 2007 at 10:33:40AM -0800, Stephen Hemminger ([EMAIL PROTECTED]) wrote: > > index 3653314..9e0e97a 100644 > > --- a/drivers/net/tulip/interrupt.c > > +++ b/drivers/net/tulip/interrupt.c > > @@ -151,8 +151,9 @@ int tulip_poll(struct napi_struct *napi, int budget) > >

Re: Badness at net/core/dev.c:2199

2007-12-16 Thread Stephen Hemminger
On Sun, 16 Dec 2007 21:20:57 +0300 Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > On Sun, Dec 16, 2007 at 07:55:55PM +0200, Meelis Roos ([EMAIL PROTECTED]) > wrote: > > Just got this trace from current 2.6.24-rc5+git running on 32-bit ppc > > (PReP subarch, tulip NIC's) during apt-get update (log

Re: Badness at net/core/dev.c:2199

2007-12-16 Thread Evgeniy Polyakov
On Sun, Dec 16, 2007 at 07:55:55PM +0200, Meelis Roos ([EMAIL PROTECTED]) wrote: > Just got this trace from current 2.6.24-rc5+git running on 32-bit ppc > (PReP subarch, tulip NIC's) during apt-get update (logged in via ssh so > also ssh traffic): > > [ cut here ] > Badne

Re: [PATCH] PS3: gelic: Add wireless support for PS3

2007-12-16 Thread Jouni Malinen
On Sun, Dec 16, 2007 at 12:49:14PM -0500, Dan Williams wrote: > Yeah, I was going to propose that on Friday but got side-tracked. What > would require a new key type? Are there some firmwares that _only_ > accept the WPA passphrase? Because if there aren't (PS3 accepts WPA hex > keys too) then

Re: [patch 2/4] net: use mutex_is_locked() for ASSERT_RTNL()

2007-12-16 Thread Jarek Poplawski
Andrew Morton wrote, On 12/15/2007 11:48 AM: > On Sat, 15 Dec 2007 14:10:21 +0800 Herbert Xu <[EMAIL PROTECTED]> wrote: > >> On Fri, Dec 14, 2007 at 09:44:18PM -0800, Andrew Morton wrote: >>> That sounds like a bug in mutex_trylock() to me. >> I was relying on >> >> http://kerneltrap.org/mai

Badness at net/core/dev.c:2199

2007-12-16 Thread Meelis Roos
Just got this trace from current 2.6.24-rc5+git running on 32-bit ppc (PReP subarch, tulip NIC's) during apt-get update (logged in via ssh so also ssh traffic): [ cut here ] Badness at net/core/dev.c:2199 NIP: c01ccf98 LR: c01ccf38 CTR: REGS: cfc8dce0 TRAP: 0700

Re: [PATCH] PS3: gelic: Add wireless support for PS3

2007-12-16 Thread Dan Williams
On Fri, 2007-12-14 at 17:42 -0800, Jouni Malinen wrote: > On Fri, Dec 14, 2007 at 07:58:47AM -0500, Dan Williams wrote: > > On Fri, 2007-12-14 at 14:03 +0900, Masakazu Mokuno wrote: > > > The PS3 wireless device does the association and 4way handshake in its > > > firmware/hypervisor. No intervent

Hi

2007-12-16 Thread Elena
Hello, My name is Elena, I am 31 years and I live in Russian province. I have 6 years daughter, her father abandoned us and we live with my mother. Recently my mother lost job due to old age and our situation became very difficult. Prices for gas and electricity became very high in last mon

After many hours all outbound connections get stuck in SYN_SENT

2007-12-16 Thread James Nichols
Hello, I have a Java application that makes a large number of outbound webservice calls over HTTP/TCP. The hosts contacted are a fixed set of about 2000 hosts and a web service call is made to each of them approximately every 5 mintues by a pool of 200 Java threads. Over time, on average a perce

[PATCH 2/5] [IrDA] mcs7780 needs to free allocated rx buffer

2007-12-16 Thread Samuel Ortiz
While testing the mcs7780 based IrDA USB dongle I've stumbled upon memory leak in mcs_net_close(). Patch below fixes it. From: Hinko Kocevar <[EMAIL PROTECTED]> Signed-off-by: Hinko Kocevar <[EMAIL PROTECTED]> Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]> --- drivers/net/irda/mcs7780.c |2

[PATCH 4/5] [IrDA] stir4200 fixes

2007-12-16 Thread Samuel Ortiz
The attached patch observes the stir4200 fifo size and will clear the fifo, if the size is increasing, while it should be transmitting bytes From: Olaf Hartmann <[EMAIL PROTECTED]> Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]> --- drivers/net/irda/stir4200.c | 10 ++ 1 file changed,

[PATCH 5/5] [IrDA] irda parameters warning fixes.

2007-12-16 Thread Samuel Ortiz
This patch fixes: CHECK /home/kernel/src/net/irda/parameters.c /home/kernel/src/net/irda/parameters.c:466:2: warning: Using plain integer as NULL pointer /home/kernel/src/net/irda/parameters.c:520:2: warning: Using plain integer as NULL pointer /home/kernel/src/net/irda/parameters.c:573:2: wa

[PATCH 3/5] [IrDA] irlmp_unregister_link needs to free lsaps

2007-12-16 Thread Samuel Ortiz
While testing the mcs7780 based IrDA USB dongle I've stumbled upon memory leak in irlmp_unregister_link(). Hashbin for lsaps is created in irlmp_register_link and should probably be freed in irlmp_unregister_link(). Signed-off-by: Hinko Kocevar <[EMAIL PROTECTED]> Signed-off-by: Samuel Ortiz <[EMA

[PATCH 1/5] [IrDA] Race between open and disconnect in irda-usb

2007-12-16 Thread Samuel Ortiz
It seems to me that irda_usb_net_open() must set self->netopen under spinlock or disconnect() may fail to kill all URBs, if it is called while an interface is opened. From: Oliver Neukum <[EMAIL PROTECTED]> Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> Signed-off-by: Samuel Ortiz <[EMAIL PROTEC

[PATCH 0/5] [IrDA] IrDA net-2.6 fixes

2007-12-16 Thread Samuel Ortiz
Hi Dave, Here goes a batch of 5 IrDA patches against your latest net-2.6 tree. Cheers, Samuel. -- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: oops with 2.6.23.1, marvel, software raid, reiserfs and samba

2007-12-16 Thread jeffunit
At 03:05 AM 12/16/2007, Andrew Morton wrote: On Fri, 07 Dec 2007 19:49:52 -0800 jeffunit <[EMAIL PROTECTED]> wrote: > I am running linux kernel 2.6.23.1, which I compiled. > The base system was mandriva 2008. > > I have a dual processor pentium III 933 system. > It has 3gb of ram, an intel stl-2

Re: [RFC] mac80211: clean up frame receive handling

2007-12-16 Thread Johannes Berg
> > + if (local->bridge_packets && (sdata->type == IEEE80211_IF_TYPE_AP || > > + sdata->type == > > IEEE80211_IF_TYPE_VLAN) && > > i may miss something, but wouldn't you prefer to use eth_type_trans > here and just add compare_ether_addr check after it?

Re: oops with 2.6.23.1, marvel, software raid, reiserfs and samba

2007-12-16 Thread Herbert Xu
On Sun, Dec 16, 2007 at 07:56:56PM +0800, Herbert Xu wrote: > > What's spooky is that I just did a google and we've had reports > since 1998 all crashing on exactly the same line in tcp_recvmsg. However, there's been no reports at all since 2000 apart from this one so the earlier ones are probably

Re: oops with 2.6.23.1, marvel, software raid, reiserfs and samba

2007-12-16 Thread Herbert Xu
Andrew Morton <[EMAIL PROTECTED]> wrote: > >> Dec 7 17:20:53 sata_fileserver kernel: Code: 6c 39 df 74 59 8d b6 00 >> 00 00 00 85 db 74 4f 8b 55 cc 8d 43 20 8b 0a 3b 48 18 0f 88 f4 05 00 >> 00 89 ce 2b 70 18 8b 83 90 00 00 00 <0f> b6 50 0d 89 d0 83 e0 02 3c >> 01 8b 43 50 83 d6 ff 39 c6 0f 82

Re: [PATCH] MACB: clear transmit buffers properly on TX Underrun

2007-12-16 Thread Gregory CLEMENT
Haavard Skinnemoen a écrit : > On Thu, 13 Dec 2007 08:51:57 +0100 > Gregory CLEMENT <[EMAIL PROTECTED]> wrote: > >> Hi, >> I generated this patch for linux 2.6.24-rc5 and test it on AT91SAM9263 >> with iperf. >> >> From: Gregory CLEMENT <[EMAIL PROTECTED]> >> Date: Wed, 12 Dec 2007 18:10:14 +0100

WINNERS IN LRP DRAW!!!

2007-12-16 Thread [EMAIL PROTECTED]
LOTTO!!! Ferdinand-Sauerbruch-Strasse 2 DE-56073 Koblenz.Germany. Reference Number: LRP/19-DE/9317 Batch: LRP/07/38 You have therefore been approved for a lump sum payout of €1,000,000.00 (One Million EURO) in cash credited to file LRP/19-DE/9317.Contact below Mr.Wilson Gart Email: [EMAIL PROTE

Re: oops with 2.6.23.1, marvel, software raid, reiserfs and samba

2007-12-16 Thread Andrew Morton
On Fri, 07 Dec 2007 19:49:52 -0800 jeffunit <[EMAIL PROTECTED]> wrote: > I am running linux kernel 2.6.23.1, which I compiled. > The base system was mandriva 2008. > > I have a dual processor pentium III 933 system. > It has 3gb of ram, an intel stl-2 motherboard. > It also has a promise 100 tx2

Re: [PACKET]: Fix /proc/net/packet crash due to bogus private pointer

2007-12-16 Thread Mariusz Kozlowski
Hello, > Surprise surprise. The namespace seq patch missed two spots in > AF_PACKET. > > [PACKET]: Fix /proc/net/packet crash due to bogus private pointer > > The seq_open_net patch changed the meaning of seq->private. > Unfortunately it missed two spots in AF_PACKET, which still > used the old

Re: [RFC] mac80211: clean up frame receive handling

2007-12-16 Thread Ron Rindjunsky
> @@ -1150,14 +1148,27 @@ ieee80211_deliver_skb(struct ieee80211_t > - if (local->bridge_packets && (sdata->type == IEEE80211_IF_TYPE_AP > - || sdata->type == IEEE80211_IF_TYPE_VLAN) && > + dst = skb->data; > + > + if (compare_ether_addr(dev->dev_addr, dst) == 0) > +

Re: [PATCH 3/3] [UDP6]: Counter increment on BH mode

2007-12-16 Thread Ingo Molnar
* Herbert Xu <[EMAIL PROTECTED]> wrote: > On Sat, Dec 15, 2007 at 07:43:28PM +0100, Ingo Molnar wrote: > > > > we could perhaps introduce stat_smp_processor_id(), which signals that > > the CPU id is used for statistical purposes and does not have to be > > exact? In any case, your patch looks

Re: Fw: [PACKET]: Fix /proc/net/packet crash due to bogus private pointer

2007-12-16 Thread Herbert Xu
On Sat, Dec 15, 2007 at 11:56:04PM -0800, Andrew Morton wrote: > On Sun, 16 Dec 2007 01:37:01 -0500 "Miles Lane" <[EMAIL PROTECTED]> wrote: > > > > On Sun, Dec 16, 2007 at 11:07:07AM +0800, Herbert Xu wrote: So I posted this patch after 19:00 PST on 15 Dec. > > Dec 15 13:44:39 syntropy kernel: