2007/11/27, Herbert Xu <[EMAIL PROTECTED]>:
> On Tue, Nov 27, 2007 at 02:32:49PM +0900, Joonwoo Park wrote:
> >
> > Thanks Herbert.
> > Well.. I think patch would work propely for AF_PACKET also.
> > (I did not insert BUG() macro in my patch)
> > How do you think?
>
> Are you sure? I thought you n
From: Herbert Xu <[EMAIL PROTECTED]>
> On Mon, Nov 26, 2007 at 03:50:22PM +0900, Yasuyuki KOZAKAI wrote:
> >
> > The refcount of nfct is leaked by this function. As a result,
> > nf_conntrack_ipv6.ko cannot be unloaded after doing "ping6 -s 2000 ..." .
> > dst->dst and dst->secpath are also neede
On 26-11-2007 23:25, Jarek Poplawski wrote:
...
> Are you doing this on the same box? I was tracing this long time ago too,
> and, if
> I didn't miss something, it was about the place! So, as I recall (after
> finding
> some old message) this TOS is considered only for packets going through the
On Tue, Nov 27, 2007 at 02:32:49PM +0900, Joonwoo Park wrote:
>
> Thanks Herbert.
> Well.. I think patch would work propely for AF_PACKET also.
> (I did not insert BUG() macro in my patch)
> How do you think?
Are you sure? I thought you need to check both in the xmit function.
That is,
i
On Tue, 2007-11-27 at 15:49 +1100, Rusty Russell wrote:
> On Monday 26 November 2007 17:15:44 Roland Dreier wrote:
> > > Except C doesn't have namespaces and this mechanism doesn't create them.
> > > So this is just complete and utter makework; as I said before, noone's
> > > going to confuse
2007/11/26, Herbert Xu <[EMAIL PROTECTED]>:
> On Fri, Nov 23, 2007 at 12:12:52PM +, Joonwoo Park wrote:
> > This patch fixes http://bugzilla.kernel.org/show_bug.cgi?id=8766
> >
> > Is it possible?
> > BUG((veth->h_vlan_proto != htons(ETH_P_8021Q)) &&
> > !(VLAN_DEV_INFO(dev)->flags & VLAN_FLAG
On Monday 26 November 2007 17:15:44 Roland Dreier wrote:
> > Except C doesn't have namespaces and this mechanism doesn't create them.
> > So this is just complete and utter makework; as I said before, noone's
> > going to confuse all those udp_* functions if they're not in the udp
> > namespac
On Monday 26 November 2007 16:58:08 Roland Dreier wrote:
> > > I agree that we shouldn't make things too hard for out-of-tree
> > > modules, but I disagree with your first statement: there clearly is a
> > > large class of symbols that are used by multiple modules but which are
> > > not generi
Anil Veerabhadrappa wrote:
The sysfs bits related to the hba should be use one of the scsi sysfs
facilities or if they are related to iscsi bits and are generic then
through the iscsi hba
bnx2i needs 2 sysfs entries -
1. QP size info - this is used to size per connection shared data
structures
On Mon, Nov 26, 2007 at 05:52:15PM +0100, Patrick McHardy wrote:
>
> OK, here's a patch to use xfrm_state_put in __xfrm_state_delete().
> I've checked the other callers and it should be fine. lock ordering
> between x->lock and xfrm_state_gc_lock also doesn't seem to be an
> issue.
Patch applied.
On Tue, Nov 27, 2007 at 11:03:41AM +0800, Herbert Xu wrote:
> On Mon, Nov 26, 2007 at 04:33:31PM +, chas williams - CONTRACTOR wrote:
> > if you are lucky (unlucky?) enough to have shared interrupts, the
> > interrupt handler can be called before the tasklet and lock are ready
> > for use.
>
>
On Mon, Nov 26, 2007 at 04:33:31PM +, chas williams - CONTRACTOR wrote:
> if you are lucky (unlucky?) enough to have shared interrupts, the
> interrupt handler can be called before the tasklet and lock are ready
> for use.
Patch applied. Thanks Chas!
--
Visit Openswan at http://www.openswan.
Ian Brown <[EMAIL PROTECTED]> wrote:
>
> NOHASH hints that we do not keep the
> an entry in a hash. I doubt that such dst_entries , which are created with
> IPsec and so has the DST_NOHASH flag set, are not kept in the routing cache?
Exactly, they're not in the routing cache (for IPv4 anyway,
ther
On Tue, Nov 20, 2007 at 06:53:15PM +0530, Kamalesh Babulal wrote:
> Hi Andrew,
>
> The kernel build fails, with following message
>
> LD drivers/net/wireless/built-in.o
> drivers/net/wireless/rtl8187.o: In function `rtl8225z2_rf_init':
> (.opd+0x180): multiple definition of `rtl8225z2_rf_i
In message <[EMAIL PROTECTED]> you wrote:
> Michael Ellerman wrote on 26.11.2007 09:16:28:
> > Solutions that might be better:
> >
> > a) if there are a finite number of handles and we can predict their
> > values, just delete them all in the kdump kernel before the driver
> > loads.
>
>
Following patch is clearly 2.6.25 material and is needed to get SGI IP28
machines supported.
Thomas.
SGI IP28 machines would need special treatment (enable adding addtional
wait states) when accessing memory uncached. To avoid this pain I changed
the driver to use only cached access to memory.
S
Joe Perches wrote:
> Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
> ---
> drivers/net/ixgbe/ixgbe_common.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_common.c
> b/drivers/net/ixgbe/ixgbe_common.c
> index 512e3b2..b7e50bc 100644
> ---
Jeff Garzik wrote:
> Benjamin Herrenschmidt wrote:
>> The e1000 driver stores the content of the PCI resources into
>> unsigned long's before ioremapping. This breaks on 32 bits
>> platforms that support 64 bits MMIO resources such as ppc 44x.
>>
>> This fixes it by removing those temporary variabl
Martin Michlmayr <[EMAIL PROTECTED]> :
> * Francois Romieu <[EMAIL PROTECTED]> [2007-11-26 00:05]:
> > > I'd like to backport the fix to the 2.6.18 kernel that is in our
> > > stable release and have a couple of questions:
> > > - Does your later patch "align the IP header when there is no DMA
> >
Joerg Pommnitz wrote, On 11/23/2007 03:47 PM:
> Hello all,
> I might make a fool out of me, but I think the prio qdisc doesn't work as
> advertised in any document I could lay my hands on.
Marketing?
>
> My problem was that the link quality reported by the olsr.org olsrd degraded
> depending
Allow phylib specification of cases where hardware needs to configure
PHYs for Internal Delay only on either RX or TX (not both).
Signed-off-by: Kim Phillips <[EMAIL PROTECTED]>
Tested-by: Anton Vorontsov <[EMAIL PROTECTED]>
Acked-by: Li Yang <[EMAIL PROTECTED]>
---
include/linux/phy.h |2 ++
Extend the RGMII-Internal Delay specification case to include
TX-only and RX-only variants.
Signed-off-by: Kim Phillips <[EMAIL PROTECTED]>
Tested-by: Anton Vorontsov <[EMAIL PROTECTED]>
Acked-by: Li Yang <[EMAIL PROTECTED]>
---
drivers/net/ucc_geth.c | 10 ++
1 files changed, 10 insert
Pavel Emelyanov <[EMAIL PROTECTED]> writes:
> Rafael J. Wysocki wrote:
>> On Monday, 19 of November 2007, Pavel Machek wrote:
>>> Hi!
>>>
>>> I think that this worked before:
>>>
>>> [EMAIL PROTECTED]:/proc# find . -name "timer_info"
>>> find: WARNING: Hard link count is wrong for ./net: this may
> Agreed. On first glance, I was intrigued but:
>
> 1) Why is everyone so concerned that export symbol space is large?
> - does it cost cpu or running memory?
> - does it cause bugs?
> - or are you just worried about "evil modules"?
>
> 2) These aren't real namespaces
>
these 3 patches are a resend of patches 2-4 (out of 5) that were
originally sent 2007-11-05* (patches 1 and 5 were picked up by Kumar
to go through powerpc).
Jeff, Leo has acked these, please consider for 2.6.24.
Thanks,
Kim
* http://marc.info/?l=linux-netdev&m=119428688804765&w=1
-
To unsubscr
Previously, Internal Delay specification implied the delay be
applied to both TX and RX. This patch allows for separate TX/RX-only
internal delay specification.
Signed-off-by: Kim Phillips <[EMAIL PROTECTED]>
Tested-by: Anton Vorontsov <[EMAIL PROTECTED]>
Acked-by: Li Yang <[EMAIL PROTECTED]>
---
On Mon, Nov 26, 2007 at 11:19:26PM +0800, Herbert Xu wrote:
> On Sun, Nov 25, 2007 at 04:30:03PM +, Adrian Bunk wrote:
> > > >
> > > > Please look at net/ipv4/arp.c:arp_process()
> > > >
> > > > Am I right that CONFIG_NET_ETHERNET=n and CONFIG_NETDEV_1000=y or
> > > > CONFIG_NETDEV_1=y w
Need to increase TX threshold when doing Jumbo frames on dual port board
to avoid underruns. (Code from sk98lin).
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/drivers/net/skge.c2007-11-21 14:05:59.0 -0800
+++ b/drivers/net/skge.c2007-11-21 14:06:15.0
Make sure and retry when shutting down the MAC. This code is copied
from sk98lin driver.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/drivers/net/skge.c2007-11-21 14:40:58.0 -0800
+++ b/drivers/net/skge.c2007-11-21 14:44:02.0 -0800
@@ -1713,7 +1713,7
This resolves the skge problems that show up on dual ported
and fiber attached boards. These fixes have been validated by
the users that reported regressions with earlier patches.
--
Stephen Hemminger <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the
The driver would not work over fibre if other end when down then
came back up (would require reloading driver). The correct way
to manage the link the same way for both TP and fibre.
Resloves problem described in: http://lkml.org/lkml/2007/11/6/395
Signed-off-by: Stephen Hemminger <[EMAIL PROTE
The calculation of usable FIFO RAM is wrong in the skge driver.
First, is doesn't take into account the reserved area on the original
SysKonnect Genesis boards. Second it has an off-by-one error because
hw->ports is either 1 or 2.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/drivers
Receive FIFO overrun is not catastrophic condition, so don't flush when
it happens.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/drivers/net/skge.c2007-11-21 14:36:31.0 -0800
+++ b/drivers/net/skge.c2007-11-21 14:40:58.0 -0800
@@ -1801,11 +1801,6 @@ s
Version for 2.6.24
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/drivers/net/skge.c2007-11-21 14:07:37.0 -0800
+++ b/drivers/net/skge.c2007-11-21 14:08:35.0 -0800
@@ -44,7 +44,7 @@
#include "skge.h"
#define DRV_NAME "skge"
-#define DR
Currently the netmask/prefix-length of an IPsec SPD entry is not included in
any of the SPD related audit messages. This can cause a problem when the
audit log is examined as the netmask/prefix-length is vital in determining
what network traffic is affected by a particular SPD entry. This patch f
From: Jesse Brandeburg <[EMAIL PROTECTED]>
fix the typo in speed 1 setting.
Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]>
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
---
ethtool.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ethtool.c b/ethtool.c
index 3ad
On Mon, 26 Nov 2007 12:28:14 +1100
Rusty Russell <[EMAIL PROTECTED]> wrote:
> On Monday 26 November 2007 07:27:03 Roland Dreier wrote:
> > > This patch allows to export symbols only for specific modules by
> > > introducing symbol name spaces. A module name space has a white
> > > list of modul
Ryousei Takano wrote:
This patch includes the PSPacer (Precise Software Pacer) qdisc
module, which achieves precise transmission bandwidth control.
You can find more information at the project web page
(http://www.gridmpi.org/gridtcp.jsp).
Thanks for the update, but you didn't answer any of my
Hi,
On Mon, Nov 26, 2007 at 01:41:37PM -0200, Luke Browning wrote:
> On Mon, 2007-11-26 at 19:16 +1100, Michael Ellerman wrote:
>
> > For kdump we have to assume that the kernel is fundamentally broken,
If I may so humbly suggest: since ehea is a power6 thing only,
we should refocus our energie
In article <[EMAIL PROTECTED]> (at Mon, 26 Nov 2007 09:16:16 -0800), "Templin,
Fred L" <[EMAIL PROTECTED]> says:
> From: Fred L. Templin <[EMAIL PROTECTED]>
>
> This patch includes support for the Intra-Site Automatic Tunnel
> Addressing Protocol (ISATAP) per RFC4214. It uses the SIT
> module, a
On Thu, 22 Nov 2007 14:23:28 +0100
Johannes Berg <[EMAIL PROTECTED]> wrote:
> This patch makes the bridging code drop EAPOL frames as recommended by
> 802.1X-2004 in C.3.3.
>
> Is this really the right place to put it?
> ---
> include/linux/if_ether.h |1 +
> include/net/ieee80211.h |6
RDMA/cxgb3: Support 5.0 firmware.
The 5.0 firmware now supports translating sgls in recv wrs, so remove
the host driver logic currently doing the translation.
Note: this change requires 5.0 firmware.
Signed-off-by: Steve Wise <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/cxgb3/iwch_qp.c | 2
Hey roland,
Please pull these two iw_cxgb3 patches for 2.6.25. The 5.0 firmware
change must be committed along with the cxgb3 NIC changes submitted here:
http://lkml.org/lkml/2007/11/16/224
and merged by Jeff here:
http://lkml.org/lkml/2007/11/23/180
Shortlog:
RDMA/cxgb3: Hold rtnl_lo
RDMA/cxgb3: Hold rtnl_lock() around ethtool get_drvinfo call.
Currently the call into cxgb3 to get the driver info is not serialized.
The iw_cxgb3 module needs to hold the rtnl_lock around the ethtool ops
call like dev_ioctl() does.
Signed-off-by: Steve Wise <[EMAIL PROTECTED]>
---
drivers/inf
From: Fred L. Templin <[EMAIL PROTECTED]>
This patch includes support for the Intra-Site Automatic Tunnel
Addressing Protocol (ISATAP) per RFC4214.
The following diffs are specific to the iproute2-2.6.23
software distribution. This message includes the full and
patchable diff text; please use thi
From: Fred L. Templin <[EMAIL PROTECTED]>
This patch includes support for the Intra-Site Automatic Tunnel
Addressing Protocol (ISATAP) per RFC4214. It uses the SIT
module, and is configured using extensions to the "iproute2"
utility. The diffs are specific to the Linux 2.6.24-rc2 kernel
distributi
The 3rd argument is always zero (according to grep :) Eliminate
it and merge the function with sk_stream_alloc_skb.
This saves 44 more bytes, and together with the previous patch
we have:
add/remove: 1/0 grow/shrink: 0/8 up/down: 183/-751 (-568)
function old
This function seems too big for inlining. Indeed, it saves
half-a-kilo when uninlined:
add/remove: 1/0 grow/shrink: 0/7 up/down: 195/-719 (-524)
function old new delta
sk_stream_alloc_pskb - 195+195
ip_rt_init
On Monday 26 November 2007 11:47:09 am Joy Latten wrote:
> Paul Moore <[EMAIL PROTECTED]> wrote on 11/21/2007 03:34:31 PM:
> > I just noticed that the IPsec auditing code does not appear to audit the
> >
> > netmask for the selector source and destination addresses in
> > xfrm_audit_common_policyin
Herbert Xu wrote:
On Mon, Nov 26, 2007 at 04:56:01PM +0100, Patrick McHardy wrote:
That should work as long as we keep the del_timer_sync to avoid
a use-after-free. It seems a bit fragile though.
Well we're relying on the del_timer_sync already to avoid the
ref count on the timer. Otherwise i
if you are lucky (unlucky?) enough to have shared interrupts, the
interrupt handler can be called before the tasklet and lock are ready
for use.
commit 44b3e82778b0edf73147529c8b1c115d241a6a4d
Author: chas williams - CONTRACTOR <[EMAIL PROTECTED]>
Date: Mon Nov 26 11:30:33 2007 -0500
[ATM]:
I am sorry I sent an old patch.
Please see this one.
--
[PATCHv2 2/3] TC: PSPacer qdisc module
This patch includes the PSPacer (Precise Software Pacer) qdisc
tc part, which achieves precise transmission bandwidth control.
You can find more information at the project web page
(http://www.gridmpi.o
On Mon, Nov 26, 2007 at 04:56:01PM +0100, Patrick McHardy wrote:
>
> That should work as long as we keep the del_timer_sync to avoid
> a use-after-free. It seems a bit fragile though.
Well we're relying on the del_timer_sync already to avoid the
ref count on the timer. Otherwise if the admin dele
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-linus
to receive the following updates:
drivers/net/Kconfig|2 +-
drivers/net/amd8111e.c |6 ++
drivers/net/bfin_mac.c |2 +-
driv
Herbert Xu wrote:
On Mon, Nov 26, 2007 at 04:51:42PM +0100, Patrick McHardy wrote:
It actually won't get freed at all currently since nothing is
calling __xfrm_state_destroy(). __xfrm_state_delete() uses
__xfrm_state_put(), which only decrements the refcount, but
doesn't perform destruction.
Th
On Mon, Nov 26, 2007 at 04:51:42PM +0100, Patrick McHardy wrote:
>
> It actually won't get freed at all currently since nothing is
> calling __xfrm_state_destroy(). __xfrm_state_delete() uses
> __xfrm_state_put(), which only decrements the refcount, but
> doesn't perform destruction.
>
> This is v
Herbert Xu wrote:
On Mon, Nov 26, 2007 at 04:05:27PM +0100, Patrick McHardy wrote:
This patch fixes a xfrm_state leak, which appears to be a
regression from the reference count simplifications.
I was going to say this was a good find :)
But digging deeper it seems that it might not be a bug a
This patch includes the PSPacer (Precise Software Pacer) qdisc
tc part, which achieves precise transmission bandwidth control.
You can find more information at the project web page
(http://www.gridmpi.org/gridtcp.jsp).
Signed-off-by: Ryousei Takano <[EMAIL PROTECTED]>
---
include/linux/pkt_sched.
This patch includes the man page of the PSPacer (Precise Software
Pacing) qdisc module.
Signed-off-by: Ryousei Takano <[EMAIL PROTECTED]>
---
man/man8/tc-psp.8 | 166 +
1 files changed, 166 insertions(+), 0 deletions(-)
create mode 100644 man/
Hi all,
This is the 2nd version of PSPacer patches.
PSPacer (Precise Software Pacer) is a qdisc module which realizes
precise transmission bandwidth control. It makes bursty traffic which is
often generated by TCP smooth without any special hardware.
For your information, please see my previous
This patch includes the PSPacer (Precise Software Pacer) qdisc
module, which achieves precise transmission bandwidth control.
You can find more information at the project web page
(http://www.gridmpi.org/gridtcp.jsp).
Signed-off-by: Ryousei Takano <[EMAIL PROTECTED]>
---
include/linux/pkt_sched.h
On Mon, Nov 26, 2007 at 04:05:27PM +0100, Patrick McHardy wrote:
> This patch fixes a xfrm_state leak, which appears to be a
> regression from the reference count simplifications.
I was going to say this was a good find :)
But digging deeper it seems that it might not be a bug after
all. Even th
On Mon, 2007-11-26 at 19:16 +1100, Michael Ellerman wrote:
>
> Hi Thomas,
>
> I'm sorry, but this patch is all wrong IMHO.
>
> For kdump we have to assume that the kernel is fundamentally broken,
> we've panicked, so something bad has happened - every line of kernel
> code that is run decreases
On Mon, Nov 26, 2007 at 01:23:05PM -0200, Arnaldo Carvalho de Melo wrote:
> Em Mon, Nov 26, 2007 at 04:35:38PM +0200, Ilpo Järvinen escreveu:
> >
> > I keep getting this build error and couldn't find anyone fixing
> > it in archives. ...Maybe all net developers except me build
> > just SMP kernels
On Mon, Nov 26, 2007 at 10:24:03AM +, Joonwoo Park wrote:
> fib_hash: kmalloc + memset conversion to kzalloc
> fix to avoid memset entirely.
Patch applied.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~her
On Mon, Nov 26, 2007 at 10:24:03AM +, Joonwoo Park wrote:
> fib_semantics: kmalloc + memset conversion to kzalloc
> fix to avoid memset entirely.
Also applied.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/
On Mon, Nov 26, 2007 at 10:23:51AM +, Joonwoo Park wrote:
> 2007/11/26, Patrick McHardy <[EMAIL PROTECTED]>:
> > How about also switching vmalloc/get_free_pages to GFP_ZERO
> > and getting rid of the memset entirely while you're at it?
> >
>
> xfrm_hash: kmalloc + memset conversion to kzalloc
Em Mon, Nov 26, 2007 at 04:35:38PM +0200, Ilpo Järvinen escreveu:
>
> I keep getting this build error and couldn't find anyone fixing
> it in archives. ...Maybe all net developers except me build
> just SMP kernels :-).
Thank you! UP is for sissies anyway :-P
Acked-by: Arnaldo Carvalho de Melo <
On Sun, Nov 25, 2007 at 04:30:03PM +, Adrian Bunk wrote:
> > >
> > > Please look at net/ipv4/arp.c:arp_process()
> > >
> > > Am I right that CONFIG_NET_ETHERNET=n and CONFIG_NETDEV_1000=y or
> > > CONFIG_NETDEV_1=y will not be handled correctly there?
> > >
> > > And the best solution i
On Mon, Nov 26, 2007 at 03:50:22PM +0900, Yasuyuki KOZAKAI wrote:
>
> The refcount of nfct is leaked by this function. As a result,
> nf_conntrack_ipv6.ko cannot be unloaded after doing "ping6 -s 2000 ..." .
> dst->dst and dst->secpath are also needed to be released, I think.
>
> Please consider t
On Mon, 2007-11-26 at 17:29 +0300, Vitaly Bordug wrote:
> fixed-link says: register new "Fixed/emulated PHY", i.e. PHY that
> not connected to the real MDIO bus.
>
> Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]>
> Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
>
> ---
>
> Documentation/p
This patch fixes a xfrm_state leak, which appears to be a
regression from the reference count simplifications.
commit 817252c2a475371f9764883c7d0f0cde63b3cfe8
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Mon Nov 26 16:00:50 2007 +0100
[XFRM]: Fix leak of expired xfrm_states
T
I keep getting this build error and couldn't find anyone fixing
it in archives. ...Maybe all net developers except me build
just SMP kernels :-).
In file included from include/net/sock.h:50,
from ipc/mqueue.c:35:
include/linux/pcounter.h: In function 'pcounter_add':
include/linux
...thus use fixed-link to register proper "Fixed PHY"
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/mpc8349emitx.dts | 11 ++-
1 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/arch/powerpc/
With that patch fixed.c now fully emulates MDIO bus, thus no need
to duplicate PHY layer functionality. That, in turn, drastically
simplifies the code, and drops down line count.
As an additional bonus, now there is no need to register MDIO bus
for each PHY, all emulated PHYs placed on the platfo
fixed-link says: register new "Fixed/emulated PHY", i.e. PHY that
not connected to the real MDIO bus.
Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]>
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
Documentation/powerpc/booting-without-of.txt |3 +
arch/powerpc/sysdev/fsl_soc.c
Hello,
Thanks!
This make things clear a bit.
What I understand from thee code (__dst_free() in dst.c) is that if we
are freeing a
dst_entry (by calling __dst_free() ), than in case this dst_entry was
created as an IPsec dst_entry it has the DST_NOHASH flag set and this
dst_entry is the first in
On Fri, Nov 23, 2007 at 07:13:11PM +0300, Pavel Emelyanov wrote:
> The inet_ehash_locks_alloc() looks like this:
>
> #ifdef CONFIG_NUMA
> if (size > PAGE_SIZE)
> x = vmalloc(...);
> else
> #endif
> x = kmalloc(...);
>
> Unlike it, the inet_ehash_locks_alloc
On Fri, Nov 23, 2007 at 04:47:36PM +0300, Pavel Emelyanov wrote:
> Currently this size is 16, but as the comment says this
> is so only because all the chains (except one) has the
> length 1. I think, that some day this may change, so
> growing this hash will be much easier.
>
> Besides, symbolic
On Fri, Nov 23, 2007 at 04:43:11PM +0300, Pavel Emelyanov wrote:
> The sock_wake_async() performs a bit different actions
> depending on "how" argument. Unfortunately this argument
> ony has numerical magic values.
>
> I propose to give names to their constants to help people
> reading this fun
On Fri, Nov 23, 2007 at 12:12:52PM +, Joonwoo Park wrote:
> This patch fixes http://bugzilla.kernel.org/show_bug.cgi?id=8766
>
> Is it possible?
> BUG((veth->h_vlan_proto != htons(ETH_P_8021Q)) && !(VLAN_DEV_INFO(dev)->flags
> & VLAN_FLAG_REORDER_HDR))
> I'm afraid, queued packet before vcon
On Mon, 26 Nov 2007, Joonwoo Park wrote:
> 2007/11/26, Robert P. J. Day <[EMAIL PROTECTED]>:
> > i realized that. but all you can say is that only amb_init() calls
> > setup_dev() *currently*. when you're not looking, someone else might
> > (for whatever reason) call setup_dev() from elsewhere,
On Mon, Nov 26, 2007 at 11:18:45AM +0800, Herbert Xu wrote:
>
> I'm just going to revert this patch for 2.6.24 since we've lived
> with this race for so long anyway.
Actually, instead of reverting it completely I'm just going to
remove the newly added locks which should be just as effective.
This
2007/11/26, Robert P. J. Day <[EMAIL PROTECTED]>:
> i realized that. but all you can say is that only amb_init() calls
> setup_dev() *currently*. when you're not looking, someone else might
> (for whatever reason) call setup_dev() from elsewhere, and *that* call
> might not zero that memory area.
Michael Ellerman wrote on 26.11.2007 09:16:28:
> Solutions that might be better:
>
> a) if there are a finite number of handles and we can predict their
> values, just delete them all in the kdump kernel before the driver
> loads.
Guessing the values does not work, because of the handle s
On Fri, Nov 23, 2007 at 09:26:31PM +0800, Herbert Xu wrote:
> On Fri, Nov 23, 2007 at 12:09:22AM +, Daniel Drake wrote:
> > David Miller found a problem in a wireless driver where I was using
> > compare_ether_addr() on potentially unaligned data. Document that
> > compare_ether_addr() is not s
On Mon, 26 Nov 2007, Joonwoo Park wrote:
> 2007/11/26, Robert P. J. Day <[EMAIL PROTECTED]>:
> > i'm not sure the above is a safe thing to do, as you're zeroing that
> > area, then making a function call and assuming, upon entry to the
> > function call, that the caller has done the right thing.
>
> i believe the more common standard for the above is:
>
> else if (hashdist) {
>
> to reduce the level of overall indentation, no?
>
No, it was.
Because there was a memset in that indentation, but I made it by
removing memset.
Thanks.
Joonwoo
-
To unsubscribe from this list: send the line "un
fib_hash: kmalloc + memset conversion to kzalloc
fix to avoid memset entirely.
Thanks.
Joonwoo
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
diff --git a/net/ipv4/fib_hash.c b/net/ipv4/fib_hash.c
index 527a6e0..9d0cee2 100644
--- a/net/ipv4/fib_hash.c
+++ b/net/ipv4/fib_hash.c
@@ -102,10 +
fib_semantics: kmalloc + memset conversion to kzalloc
fix to avoid memset entirely.
Thanks.
Joonwoo
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
index 1351a26..352f8c4 100644
--- a/net/ipv4/fib_semantics.c
+++ b/net/ipv4/fib
2007/11/26, Robert P. J. Day <[EMAIL PROTECTED]>:
> i'm not sure the above is a safe thing to do, as you're zeroing that
> area, then making a function call and assuming, upon entry to the
> function call, that the caller has done the right thing. i don't see
> how you can count on that, depending
2007/11/26, Patrick McHardy <[EMAIL PROTECTED]>:
> How about also switching vmalloc/get_free_pages to GFP_ZERO
> and getting rid of the memset entirely while you're at it?
>
xfrm_hash: kmalloc + memset conversion to kzalloc
fix to avoid memset entirely.
Thanks Patrick.
Thanks.
Joonwoo
Signed-o
On Mon, 26 Nov 2007, Joonwoo Park wrote:
> atm/ambassador: kmalloc + memset conversion to kzalloc
>
> Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
>
> Thanks.
> Joonwoo
>
> ---
> diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
> index b34b382..4f99ba3 100644
> --- a/drivers/atm
Joonwoo Park wrote:
diff --git a/net/xfrm/xfrm_hash.c b/net/xfrm/xfrm_hash.c
index 55ab579..37795bd 100644
--- a/net/xfrm/xfrm_hash.c
+++ b/net/xfrm/xfrm_hash.c
@@ -17,16 +17,17 @@ struct hlist_head *xfrm_hash_alloc(unsigned int sz)
struct hlist_head *n;
if (sz <= PAGE_SIZE)
-
On Mon, 26 Nov 2007, Joonwoo Park wrote:
> xfrm_hash: kmalloc + memset conversion to kzalloc
>
> Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
>
> Thanks.
> Joonwoo
>
> ---
> diff --git a/net/xfrm/xfrm_hash.c b/net/xfrm/xfrm_hash.c
> index 55ab579..37795bd 100644
> --- a/net/xfrm/xfrm_hash.c
> +
fib_semantics: kmalloc + memset conversion to kzalloc
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
Thanks.
Joonwoo
---
diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
index 1351a26..87a1e72 100644
--- a/net/ipv4/fib_semantics.c
+++ b/net/ipv4/fib_semantics.c
@@ -605,10 +605,1
fib_hash: kmalloc + memset conversion to kzalloc
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
Thanks.
Joonwoo
---
diff --git a/net/ipv4/fib_hash.c b/net/ipv4/fib_hash.c
index 527a6e0..2874fe7 100644
--- a/net/ipv4/fib_hash.c
+++ b/net/ipv4/fib_hash.c
@@ -102,10 +102,14 @@ static struct hlist_
atm/ambassador: kmalloc + memset conversion to kzalloc
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
Thanks.
Joonwoo
---
diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
index b34b382..4f99ba3 100644
--- a/drivers/atm/ambassador.c
+++ b/drivers/atm/ambassador.c
@@ -2163,7 +2163
xfrm_hash: kmalloc + memset conversion to kzalloc
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
Thanks.
Joonwoo
---
diff --git a/net/xfrm/xfrm_hash.c b/net/xfrm/xfrm_hash.c
index 55ab579..37795bd 100644
--- a/net/xfrm/xfrm_hash.c
+++ b/net/xfrm/xfrm_hash.c
@@ -17,16 +17,17 @@ struct hlist_head
Andrew Morton <[EMAIL PROTECTED]> writes:
> On Sun, 25 Nov 2007 16:12:57 +0100 Wagner Ferenc <[EMAIL PROTECTED]> wrote:
>
>> I propose it as a fix for trailing NULs and spaces like eg.
>>
>> $ od -c /sys/class/net/bond0/bonding/slaves
>> 000 e t h - l e f t e t h
1 - 100 of 104 matches
Mail list logo
