On Mon, Nov 26, 2007 at 04:56:01PM +0100, Patrick McHardy wrote: > > That should work as long as we keep the del_timer_sync to avoid > a use-after-free. It seems a bit fragile though.
Well we're relying on the del_timer_sync already to avoid the ref count on the timer. Otherwise if the admin deletes the SA while the timer is running it'll go up in smoke too. If you look in the history you'll find that the same patch that removed the ref count on the timer introduced the call to del_timer_sync :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
