Re: [RFC][BNX2X] .h files rewrite

2007-11-03 Thread Eliezer Tamir
On Fri, 2007-11-02 at 16:35 -0700, Max Asbock wrote: > I built the newest bnx2x code against the net-2.6 kernel and ran a > number of stress tests with netperf and pktgen. I did not encounter > any > errors. > > Max > > Thanks, Eliezer - To unsubscribe from this list: send the line "unsubscri

Re: [PATCH] net: Add 405EX support to new EMAC driver

2007-11-03 Thread Benjamin Herrenschmidt
On Fri, 2007-11-02 at 11:03 -0500, Olof Johansson wrote: > On Fri, Nov 02, 2007 at 08:14:43AM +0100, Stefan Roese wrote: > > This patch adds support for the 405EX to the new EMAC driver. Some as on > > AXON, the 405EX handles the MDIO via the RGMII bridge. > > Hi, > > This isn't feedback on your

Re: Endianness problem with u32 classifier hash masks

2007-11-03 Thread Jarek Poplawski
Jarek Poplawski wrote, On 11/04/2007 01:30 AM: > Jarek Poplawski wrote, On 11/04/2007 12:58 AM: ... > Other changes seem to be not needed. > >> But it needs more checking... But not much more: it's a piece of fshit! So, even if not full ntohl(), some byte moving seems to be necessary here. S

Re: [PATCH] INET : removes per bucket rwlock in tcp/dccp ehash table

2007-11-03 Thread Andi Kleen
> > Also the EHASH_LOCK_SZ == 0 special case is a little strange. Why did > > you add that? > > He explained this in another reply, because ifdefs are ugly. I meant why having it at all? > Any use that makes > "sense" is a case where the code should be rewritten to decrease the > lock hold ti

Re: Endianness problem with u32 classifier hash masks

2007-11-03 Thread Jarek Poplawski
Jarek Poplawski wrote, On 11/04/2007 12:58 AM: > Jarek Poplawski wrote, On 11/04/2007 12:39 AM: > ... > > OOPS!!! Went too early! I've tried to save not send. Probably my > bad pronunciation... > > But, it seems this could be something like this (instead of Radu's > change in u32_classify()). Th

Re: Endianness problem with u32 classifier hash masks

2007-11-03 Thread Jarek Poplawski
Jarek Poplawski wrote, On 11/04/2007 12:39 AM: ... OOPS!!! Went too early! I've tried to save not send. Probably my bad pronunciation... But, it seems this could be something like this (instead of Radu's change in u32_classify()). The change of hmask is needed. But it needs more checking... Ja

Re: Fwd: Problem accessing a Certain Remote IP with Kernel 2.6.24-rc1

2007-11-03 Thread Stephen Hemminger
On Sat, 3 Nov 2007 15:34:18 -0500 Sparkletone <[EMAIL PROTECTED]> wrote: > Forwarding this for someone who was getting bounces for some reason. > > Begin forwarded message: > > > From: Shlomi Fish <[EMAIL PROTECTED]> > > Date: November 3, 2007 3:31:56 PM CDT > > To: [EMAIL PROTECTED] > > Subject

[PATCH 11/11] netpoll: rx use RCU

2007-11-03 Thread Stephen Hemminger
Get rid of rx_lock and use Read-Copy-Update to make sure that netpoll info and rx handle are not used after free. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/include/linux/netpoll.h 2007-11-03 11:08:36.0 -0700 +++ b/include/linux/netpoll.h 2007-11-03 11:15:11.0

[PATCH 10/11] netpoll: rx optimization

2007-11-03 Thread Stephen Hemminger
This patch makes netpoll work for non-NAPI devices that call netif_receive_skb. Devices are allowed to call netif_receive_skb if they are receiving packets in softirq (ie in tasklet). One side effect of this is that received packets will be looked at twice for the non-NAPI case, but this is harmles

[PATCH 05/11] netpoll: dont need rx_flags

2007-11-03 Thread Stephen Hemminger
The rx_flags variable is redundant. Turning rx on/off is done via setting the rx_np pointer. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/include/linux/netpoll.h 2007-11-03 09:32:54.0 -0700 +++ b/include/linux/netpoll.h 2007-11-03 09:35:45.0 -0700 @@ -25,7 +25,6

[PATCH 07/11] netpoll: get rid of name parameter

2007-11-03 Thread Stephen Hemminger
The name was being stored and used only for error messages. The same effect can be had by just passing it in where needed during config. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/netconsole.c 2007-11-03 10:03:40.0 -0700 +++ b/drivers/net/netconsole.c 2007-1

[PATCH 09/11] netpoll: ethernet devices only

2007-11-03 Thread Stephen Hemminger
Netpoll only works on Ethernet devices, so check during setup rather than just failing silently later. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/core/netpoll.c2007-11-03 11:05:33.0 -0700 +++ b/net/core/netpoll.c2007-11-03 11:08:23.0 -0700 @@ -6

[PATCH 02/11] netpoll: netpoll_poll cleanup

2007-11-03 Thread Stephen Hemminger
Restructure code slightly to improve readability: * dereference device once * change obvious while() loop * let poll_napi() handle null list itself Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/core/netpoll.c2007-11-03 10:02:50.0 -0700 +++ b/net/core/netpol

[PATCH 06/11] netpoll: remove dev_name for npinfo

2007-11-03 Thread Stephen Hemminger
The device name was only in npinfo for netconsole target configuration, so move it to netconsole. Netconsole only needs the value during config, so no need to do all the device name tracking etc.. Make functions for common code for instantiation and start up. Signed-off-by: Stephen Hemminger <

[PATCH 03/11] netpoll: no need to store local_mac

2007-11-03 Thread Stephen Hemminger
The local_mac is managed by the network device, no need to keep a spare copy and all the management problems that could cause. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/include/linux/netpoll.h 2007-11-03 09:12:48.0 -0700 +++ b/include/linux/netpoll.h 2007-11-03 09:18:

[PATCH 08/11] netpoll: NETPOLL_TRAP configuration change

2007-11-03 Thread Stephen Hemminger
NETPOLL_TRAP is actually not used by any in-tree code. Rather than exposing it in kernel configuration, make it a selectable option and make sure API is stubbed properly. I.e: if not configured then netpoll_set_trap is not available. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- P.s:

[PATCH 00/11] netpoll cleanups

2007-11-03 Thread Stephen Hemminger
These patches simplify netpoll by better locking, reorganizing code etc. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 04/11] netpoll: alternative implementation of dropping

2007-11-03 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/core/netpoll.c2007-11-03 09:19:34.0 -0700 +++ b/net/core/netpoll.c2007-11-03 09:33:31.0 -0700 @@ -40,7 +40,6 @@ static atomic_t trapped; #define USEC_PER_POLL 50 #define NETPOLL_RX_ENABLED 1 -#defi

[PATCH 01/11] netpoll: use skb_queue_purge

2007-11-03 Thread Stephen Hemminger
Use standard route for flushing queue. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/core/netpoll.c2007-11-03 09:13:16.0 -0700 +++ b/net/core/netpoll.c2007-11-03 09:14:05.0 -0700 @@ -816,11 +812,7 @@ void netpoll_cleanup(struct netpoll *np)

Re: Endianness problem with u32 classifier hash masks

2007-11-03 Thread Jarek Poplawski
jamal wrote, On 11/03/2007 12:23 AM: > On Fri, 2007-02-11 at 18:31 +0100, Jarek Poplawski wrote: >> Radu Rendec wrote: >> >>> Hi, >>> >>> While trying to implement u32 hashes in my shaping machine I ran into a >>> possible bug in the u32 hash/bucket computing algorithm >>> (net/sched/cls_u32.c). >

Re: [PATCH] INET : removes per bucket rwlock in tcp/dccp ehash table

2007-11-03 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Sun, 4 Nov 2007 00:18:14 +0100 > On Thursday 01 November 2007 11:16:20 Eric Dumazet wrote: > > Some quick comments: > > > +#if defined(CONFIG_SMP) || defined(CONFIG_PROVE_LOCKING) > > +/* > > + * Instead of using one rwlock for each inet_ehash_bucket, w

Re: Problem accessing a Certain Remote IP with Kernel 2.6.24-rc1

2007-11-03 Thread Sparkletone
On Nov 3, 2007, at 6:05 PM, David Miller wrote: Please do not forward his postings here, thank you. I kind of figured something like that was the case, but decided to take the chance it was legit. Don't worry about it happening again! - To unsubscribe from this list: send the line "unsubsc

Re: [PATCH] INET : removes per bucket rwlock in tcp/dccp ehash table

2007-11-03 Thread Andi Kleen
On Thursday 01 November 2007 11:16:20 Eric Dumazet wrote: Looks good from a quick look. Thanks for doing that work. Some quick comments: > +#if defined(CONFIG_SMP) || defined(CONFIG_PROVE_LOCKING) > +/* > + * Instead of using one rwlock for each inet_ehash_bucket, we use a table of > locks > +

Re: Problem accessing a Certain Remote IP with Kernel 2.6.24-rc1

2007-11-03 Thread David Miller
From: Sparkletone <[EMAIL PROTECTED]> Date: Sat, 3 Nov 2007 15:34:18 -0500 > Forwarding this for someone who was getting bounces for some reason. He's permanently banned from vger.kernel.org for some absurd trolling behavior he exhibited some time ago. Now he's trying to make some bug reports or

[PATCH] [POWERPC] Fix fs_enet module build

2007-11-03 Thread Jochen Friedrich
If fs_enet is build as module, mii-fec/mii-bitbang should be build as module, as well. Otherwise some symbols remain undefined. Building modules, stage 2. MODPOST 5 modules ERROR: "fs_scc_ops" [drivers/net/fs_enet/fs_enet.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error

Fwd: Problem accessing a Certain Remote IP with Kernel 2.6.24-rc1

2007-11-03 Thread Sparkletone
Forwarding this for someone who was getting bounces for some reason. Begin forwarded message: From: Shlomi Fish <[EMAIL PROTECTED]> Date: November 3, 2007 3:31:56 PM CDT To: [EMAIL PROTECTED] Subject: Problem accessing a Certain Remote IP with Kernel 2.6.24-rc1 Hi all! I hope this mail gets t

Re: RFC: Reproducible oops with lockdep on count_matching_names()

2007-11-03 Thread Michael Buesch
On Saturday 03 November 2007 20:58:09 Luis R. Rodriguez wrote: > I was using SLAB and ran into other strange oops, as the one below, > but after switching to SLUB, after Michael Buesch's suggestion that > one went away... The lockdep segfault is still present, however. Who is responsible for slab

Re: RFC: Reproducible oops with lockdep on count_matching_names()

2007-11-03 Thread Luis R. Rodriguez
On 11/2/07, Peter Zijlstra <[EMAIL PROTECTED]> wrote: > On Thu, 2007-11-01 at 19:26 -0400, Michael Wu wrote: > > On Thursday 01 November 2007 15:17:16 Luis R. Rodriguez wrote: > > > [EMAIL PROTECTED]:~/devel/wireless-2.6$ git-describe > > > v2.6.24-rc1-146-g2280253 > > > > > > So I hit segfault wit

[PATCH] [POWERPC] Fix typo #ifdef -> #ifndef

2007-11-03 Thread Jochen Friedrich
fpi->cp_command should be overwritten only if CONFIG_PPC_CPM_NEW_BINDING is NOT set. Otherwise it is already set from the device tree. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- This can be pulled from git://git.bocc.de/dbox2.git for-2.6.24 drivers/net/fs_enet/mac-scc.c |2 +- 1

[PATCH2/2] [POWERPC] fs_enet: select PHYLIB as the driver needs it.

2007-11-03 Thread Jochen Friedrich
Add a select PHYLIB to config FS_ENET as the driver uses functions of libphy. LD .tmp_vmlinux1 drivers/built-in.o: In function `fs_ioctl': drivers/net/fs_enet/fs_enet-main.c:952: undefined reference to `phy_mii_ioctl' [...] make: *** [.tmp_vmlinux1] Error 1 Signed-off-by: Jochen Friedrich <

[PATCH0/2] [POWERPC] Two bug fixes for 2.6.24

2007-11-03 Thread Jochen Friedrich
Here is a series fixing some bugs for 8xx powerpc CPUs. 1. [POWERPC] Kill non-existant symbols from ksyms and commproc.h 2. [POWERPC] fs_enet: select PHYLIB as the driver needs it This series can be pulled from git://git.bocc.de/dbox2.git for-2.6.24 Thanks, Jochen - To unsubscribe from this l

via-rhine driver stalls with: PHY status 786d, resetting...

2007-11-03 Thread Martin J. Bligh
Linux 2.6.23 http://bugzilla.kernel.org/show_bug.cgi?id=9300 Under any sort of traffic load (recursive scp from another box of a bunch of mp3s, for instance), I get continuous stalls. Recovers every time, but is dog slow. NETDEV WATCHDOG: eth2: transmit timed out eth2: Transmit timed out, sta

Re: urgent! linux 2.6.16 network bridge crash

2007-11-03 Thread Jarek Poplawski
auther_bin wrote, On 11/03/2007 12:11 PM: > Hello friends, I have config my linux box works as a network bridge. and > up/down switch is both cisco 35xx works with vlan. but when i connect it > into the network the box crashed right now. Puzzled! > > btw, in the down(intranet) switch we connect 8

[VLAN]: Fix SET_VLAN_INGRESS_PRIORITY_CMD ioctl

2007-11-03 Thread Patrick McHardy
Fix a regression in 2.6.23. Candidate for -stable IMO. [VLAN]: Fix SET_VLAN_INGRESS_PRIORITY_CMD ioctl Based on report and patch by Doug Kehn <[EMAIL PROTECTED]>: vconfig returns the following error when attempting to execute the set_ingress_map command: vconfig: socket or ioctl error for set_

urgent! linux 2.6.16 network bridge crash

2007-11-03 Thread auther_bin
Hello friends, I have config my linux box works as a network bridge. and up/down switch is both cisco 35xx works with vlan. but when i connect it into the network the box crashed right now. Puzzled! btw, in the down(intranet) switch we connect 8 wireless AP. tcpdump gives many many broadcast pack