> > Also the EHASH_LOCK_SZ == 0 special case is a little strange. Why did > > you add that? > > He explained this in another reply, because ifdefs are ugly.
I meant why having it at all? > Any use that makes > "sense" is a case where the code should be rewritten to decrease the > lock hold time or convert to RCU. I don't think RCU would be really needed for single entry buckets (which are common) if they are special cased. After all it would be just a single pointer. Perhaps one could distingush this case e.g. by setting the low order bit of the hash bucket pointer. In fact to optimize for this case it might be an interesting experiment to go towards an closed hash table and allocate the sockets in page sized objects and then remap them directly into a virtual continuous table similar to the new vmemmap code (need to try this at some point). -Andi - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
