Re: TCP_DEFER_ACCEPT issues

2007-11-01 Thread Eric Dumazet
Felix von Leitner a écrit : I am trying to use TCP_DEFER_ACCEPT in my web server. There are some operational problems. First of all: timeout handling. I would like to be able to set a timeout in seconds (or better: milliseconds) for how long the socket is allowed to sit there without data comi

[PATCH] net: Add 405EX support to new EMAC driver

2007-11-01 Thread Stefan Roese
This patch adds support for the 405EX to the new EMAC driver. Some as on AXON, the 405EX handles the MDIO via the RGMII bridge. Tested on AMCC Kilauea. Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c |3 ++- drivers/net/ibm_newemac/rgmii.c | 16 +

Re: [PATCH] ehea: add kexec support

2007-11-01 Thread Michael Ellerman
On Wed, 2007-10-31 at 20:48 +0100, Christoph Raisch wrote: > Michael Ellerman <[EMAIL PROTECTED]> wrote on 30.10.2007 23:50:36: > > > > On Tue, 2007-10-30 at 09:39 +0100, Christoph Raisch wrote: > > > > > > Michael Ellerman <[EMAIL PROTECTED]> wrote on 28.10.2007 23:32:17: > > > Hope I didn't miss

Re: [patch 2/2] ipvs: Syncrhonise Closing of Connections

2007-11-01 Thread Simon Horman
On Fri, Nov 02, 2007 at 01:36:07AM +0200, Julian Anastasov wrote: > > Hello, > > On Thu, 1 Nov 2007, Simon Horman wrote: > > > --- net-2.6.orig/net/ipv4/ipvs/ip_vs_sync.c 2007-11-01 18:17:55.0 > > +0900 > > +++ net-2.6/net/ipv4/ipvs/ip_vs_sync.c 2007-11-01 18:20:30.0

Re: [2.6 patch] let USB_USBNET always select MII

2007-11-01 Thread David Brownell
On Thursday 01 November 2007, Adrian Bunk wrote: > All this USB_USBNET_MII trickery is simply not worth it considering how > few code it saves. Depends on what systems you're talking about. Forcing unused code into the kernel is not free, especially if that's made into a design policy and applie

Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':

2007-11-01 Thread Adrian Bunk
On Thu, Nov 01, 2007 at 04:32:18PM -0700, David Brownell wrote: > On Thursday 01 November 2007, Randy Dunlap wrote: > > The MII functions aren't available unless NET_ETHERNET=y. The setting of CONFIG_NET_ETHERNET doesn't matter for this bug. > > Howver, the MII functions aren't always needed... >

Re: [patch 2/2] ipvs: Syncrhonise Closing of Connections

2007-11-01 Thread Julian Anastasov
Hello, On Thu, 1 Nov 2007, Simon Horman wrote: > --- net-2.6.orig/net/ipv4/ipvs/ip_vs_sync.c 2007-11-01 18:17:55.0 > +0900 > +++ net-2.6/net/ipv4/ipvs/ip_vs_sync.c2007-11-01 18:20:30.0 > +0900 > @@ -332,7 +332,7 @@ static void ip_vs_process_message(const >

Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':

2007-11-01 Thread David Brownell
On Thursday 01 November 2007, Randy Dunlap wrote: > The MII functions aren't available unless NET_ETHERNET=y. > Howver, the MII functions aren't always needed... > > David, any ideas on this one? It's been several years since I looked at this. It used to behave just fine. Something must have ch

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?

2007-11-01 Thread Rick Jones
David Miller wrote: From: Rick Jones <[EMAIL PROTECTED]> I'll try to go pester folks in tcpdump-workers then. The thing to check is "TP_STATUS_CSUMNOTREADY". When using mmap(), it will be provided in the descriptor. When using recvmsg() it will be provided via a PACKET_AUXDATA control messa

Re: [Bugme-new] [Bug 9270] New: sunhme requires lower MTU to handle 802.1q frames

2007-11-01 Thread Chris Poon
Forgot to add that only changing BMAC_TXMAX & BMAC_RXMAX wouldn't work for me, until I changed 2 skb_put as well (which is in the patch that I submitted in bugzilla). Dug up some really old threads on the net and found out that this was reported before Quoting Andrew Morton <[EMAIL PROTECTED]>: >

[2.6 patch] let USB_USBNET always select MII

2007-11-01 Thread Adrian Bunk
All this USB_USBNET_MII trickery is simply not worth it considering how few code it saves. As a side effect, this also fixes the following compile error reported by Toralf Förster: <-- snip --> ... LD .tmp_vmlinux1 drivers/built-in.o: In function `usbnet_set_settings': (.text+0xf1876)

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?

2007-11-01 Thread David Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Thu, 01 Nov 2007 15:04:12 -0700 > David Miller wrote: > > From: Rick Jones <[EMAIL PROTECTED]> > > Date: Thu, 01 Nov 2007 14:48:45 -0700 > > > > > >>One could I suppose try to ammend the information passed to allow > >>tcpdump to say "oh, this was a tx

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?

2007-11-01 Thread Rick Jones
David Miller wrote: From: Rick Jones <[EMAIL PROTECTED]> Date: Thu, 01 Nov 2007 14:48:45 -0700 One could I suppose try to ammend the information passed to allow tcpdump to say "oh, this was a tx packet on the same machine on which I am tracing so don't worry about checksum mismatch" We do t

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?

2007-11-01 Thread David Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Thu, 01 Nov 2007 14:48:45 -0700 > One could I suppose try to ammend the information passed to allow > tcpdump to say "oh, this was a tx packet on the same machine on > which I am tracing so don't worry about checksum mismatch" We do this already! - To u

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?

2007-11-01 Thread David Miller
From: Dave Johnson <[EMAIL PROTECTED]> Date: Thu, 1 Nov 2007 17:36:22 -0400 > bad csum on tx packets as reported by tcpdump is also an issue. We provide a tag to userspace that tcpdump should use to see that the HW is going to checksum the packet, and therefore it should elide trying to verify th

Re: [PATCH] INET : removes per bucket rwlock in tcp/dccp ehash table

2007-11-01 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Thu, 01 Nov 2007 20:17:35 +0100 > But if it was an issue, the spinlock array used in IP route cache > would have the same problem and *someone* should already have > complained... I'd say that having a few MB less of rwlock cache lines to touch offsets

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?

2007-11-01 Thread Rick Jones
The code in AF_PACKET should fix the skb before passing to user space so that there is no difference between accel and non-accel hardware. Internal choices shouldn't leak to user space. Ditto, the receive checksum offload should be fixed up as well. yep. bad csum on tx packets as reported by

Re: [PATCH] INET : removes per bucket rwlock in tcp/dccp ehash table

2007-11-01 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Thu, 01 Nov 2007 18:54:24 +0100 > Stephen Hemminger a écrit : > > Longterm is there any chance of using rcu for this? Seems like > > it could be a big win. > > This was discussed in the past, and I even believe some patch was proposed, > but some guys

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?

2007-11-01 Thread Dave Johnson
Ben Greear writes: > We should also define what a NIC should do with VLANs it doesn't > explicitly know about. I think it should pass them up the stack > with VLAN tag intact, but again, perhaps there are reasons not to do > that? Unless the device also supports NETIF_F_HW_VLAN_FILTER, it has no

Re: [PATCH] - e1000_ethtool.c - convert macros to functions

2007-11-01 Thread Kok, Auke
Joe Perches wrote: > Minimal macro to function conversion in e1000_ethtool.c > > Adds functions reg_pattern_test and reg_set_and_check > Changes REG_PATTERN_TEST and REG_SET_AND_CHECK macros > to call these functions. > > Saves ~2.5KB > > Compiled x86, untested (no hardware) > > old: > > $ siz

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?

2007-11-01 Thread David Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Thu, 01 Nov 2007 08:04:31 -0700 > David Miller wrote: > > The hardware has stripped the VLAN header completely and has not > > provided it to us at all. > > > Do the NICs not save the QoS bits in the VLAN header anywhere that we could > use to reconsti

Re: [PATCH] net: Add 405EX support to new EMAC driver

2007-11-01 Thread Stefan Roese
On Thursday 01 November 2007, Josh Boyer wrote: > > > - if (dev->type != RGMII_AXON) > > > - return; > > > - > > > mutex_lock(&dev->lock); > > > > That will break 440GX boards that need to use the RGMII for data and the > > ZMII for MDIO. > > > > You may want to change the name RGMII_AXON

[PATCH] - e1000_ethtool.c - convert macros to functions

2007-11-01 Thread Joe Perches
Minimal macro to function conversion in e1000_ethtool.c Adds functions reg_pattern_test and reg_set_and_check Changes REG_PATTERN_TEST and REG_SET_AND_CHECK macros to call these functions. Saves ~2.5KB Compiled x86, untested (no hardware) old: $ size drivers/net/e1000/e1000_ethtool.o text

Re: [BUG] in inet6_create

2007-11-01 Thread Roel Kluin
Roel Kluin wrote: > I got this bug recently, I am not sure whether this is related to any > previously > reported ones. It was a recently pulled git kernel. Also I have been hacking > my > kernel a bit lately, but I think that I haven't got any changes in the > currently > running kernel. > >

Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':

2007-11-01 Thread Randy Dunlap
On Thu, 1 Nov 2007 20:24:54 +0100 Toralf Förster wrote: [adding netdev] > Hello, > > the build with the attached .config failed, make ends with: > ... > CC arch/x86/lib/usercopy_32.o > AR arch/x86/lib/lib.a > GEN .version > CHK include/linux/compile.h > UPD includ

Re: [PATCH] net: Add 405EX support to new EMAC driver

2007-11-01 Thread Josh Boyer
On Fri, 02 Nov 2007 07:37:01 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > On Thu, 2007-11-01 at 15:54 +0100, Stefan Roese wrote: > > This patch adds support for the 405EX to the new EMAC driver. > > > > Tested on AMCC Kilauea. > > .../... > > > diff --git a/drivers/net/ibm_newe

Re: [PATCH] net: Add 405EX support to new EMAC driver

2007-11-01 Thread Benjamin Herrenschmidt
On Thu, 2007-11-01 at 15:54 +0100, Stefan Roese wrote: > This patch adds support for the 405EX to the new EMAC driver. > > Tested on AMCC Kilauea. .../... > diff --git a/drivers/net/ibm_newemac/rgmii.c b/drivers/net/ibm_newemac/rgmii.c > index de41695..e393f68 100644 > --- a/drivers/net/ibm_ne

[BUG] in inet6_create

2007-11-01 Thread Roel Kluin
I got this bug recently, I am not sure whether this is related to any previously reported ones. It was a recently pulled git kernel. Also I have been hacking my kernel a bit lately, but I think that I haven't got any changes in the currently running kernel. FYI: my network card was not running (

[git patches] net driver fixes

2007-11-01 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/Kconfig |4 +--- drivers/net/fec_mpc52xx.c |4 ++-- drivers/net/myri10ge/myri10ge.c |6 +++--

Re: [PATCH] e1000, e1000e valid-addr fixes

2007-11-01 Thread Jeff Garzik
Stephen Hemminger wrote: How about: static int eth_validate_addr(const struct net_device *dev) { return is_valid_ether_addr(dev->dev_addr) ? 0 : -EINVAL; } hmmm -- its a slow path, so I don't see the value of marking the argument 'const' -- right now this implementation merely reads t

Re: [PATCH] INET : removes per bucket rwlock in tcp/dccp ehash table

2007-11-01 Thread Eric Dumazet
Rick Jones a écrit : Something is telling me finding a 64 core system with a suitable workload to try this could be a good thing. Wish I had one at my disposal. Maybe on big NUMA machines, we might prefer to spread the rwlock array on multiple nodes (ie using vmalloc() instead of kmalloc()

Re: [Bugme-new] [Bug 9270] New: sunhme requires lower MTU to handle 802.1q frames

2007-11-01 Thread Andrew Morton
On Wed, 31 Oct 2007 16:35:57 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Wed, 31 Oct 2007 15:43:01 -0700 > > > > sunhme requires lower MTU to handle 802.1q frames - even though the PCI > > > driver supported VLAN tagging, you cannot do ful

Re: [PATCH] INET : removes per bucket rwlock in tcp/dccp ehash table

2007-11-01 Thread Eric Dumazet
Rick Jones a écrit : Eric Dumazet wrote: Stephen Hemminger a écrit : On Thu, 01 Nov 2007 11:16:20 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: As done two years ago on IP route cache table (commit 22c047ccbc68fa8f3fa57f0e8f906479a062c426) , we can avoid using one lock per hash bucket for t

Re: [PATCH] INET : removes per bucket rwlock in tcp/dccp ehash table

2007-11-01 Thread Rick Jones
Eric Dumazet wrote: Stephen Hemminger a écrit : On Thu, 01 Nov 2007 11:16:20 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: As done two years ago on IP route cache table (commit 22c047ccbc68fa8f3fa57f0e8f906479a062c426) , we can avoid using one lock per hash bucket for the huge TCP/DCCP hash

Re: [PATCH] e1000, e1000e valid-addr fixes

2007-11-01 Thread Jeff Garzik
Kok, Auke wrote: David Miller wrote: From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 22:20:30 -0400 David Miller wrote: From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 21:03:36 -0400 I'm wondering if there is a way to avoid adding if (!is_valid_ether_addr(

Re: [PATCH 2/2] [POWERPC] Fix region size check in mpc5200 FEC driver

2007-11-01 Thread Grant Likely
On 11/1/07, Ingo Oeser <[EMAIL PROTECTED]> wrote: > Hi Grant, > > Grant Likely schrieb: > > From: Grant Likely <[EMAIL PROTECTED]> > > > > Driver shouldn't complain if the register range is larger than what > > it expects. This works around failures with some device trees. > > > > But maybe the fi

Re: [PATCH 2/2] [POWERPC] Fix region size check in mpc5200 FEC driver

2007-11-01 Thread Ingo Oeser
Hi Grant, Grant Likely schrieb: > From: Grant Likely <[EMAIL PROTECTED]> > > Driver shouldn't complain if the register range is larger than what > it expects. This works around failures with some device trees. > But maybe the firmware guys like to know about it? May I suggest putting this in f

Re: [PATCH] e1000, e1000e valid-addr fixes

2007-11-01 Thread Stephen Hemminger
How about: static int eth_validate_addr(const struct net_device *dev) { return is_valid_ether_addr(dev->dev_addr) ? 0 : -EINVAL; } -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] Mo

Endianness problem with u32 classifier hash masks

2007-11-01 Thread Radu Rendec
Hi, While trying to implement u32 hashes in my shaping machine I ran into a possible bug in the u32 hash/bucket computing algorithm (net/sched/cls_u32.c). The problem occurs only with hash masks that extend over the octet boundary, on little endian machines (where htonl() actually does something)

Re: [PATCH] e1000, e1000e valid-addr fixes

2007-11-01 Thread Kok, Auke
David Miller wrote: > From: Jeff Garzik <[EMAIL PROTECTED]> > Date: Tue, 23 Oct 2007 22:20:30 -0400 > >> David Miller wrote: >>> From: Jeff Garzik <[EMAIL PROTECTED]> >>> Date: Tue, 23 Oct 2007 21:03:36 -0400 >>> I'm wondering if there is a way to avoid adding if (!is_valid_ether

Re: [PATCH] INET : removes per bucket rwlock in tcp/dccp ehash table

2007-11-01 Thread Eric Dumazet
Jarek Poplawski a écrit : Hi, A few doubts below: +#if defined(CONFIG_SMP) || defined(CONFIG_PROVE_LOCKING) Probably "|| defined(CONFIG_DEBUG_SPINLOCK)" is needed here. Not sure, because DEBUG_SPINLOCK only applies to spinlocks. Here we deal with rwlocks. +/* + * Instead of using one

Re: [PATCH] INET : removes per bucket rwlock in tcp/dccp ehash table

2007-11-01 Thread Eric Dumazet
Stephen Hemminger a écrit : On Thu, 01 Nov 2007 11:16:20 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: As done two years ago on IP route cache table (commit 22c047ccbc68fa8f3fa57f0e8f906479a062c426) , we can avoid using one lock per hash bucket for the huge TCP/DCCP hash tables. On a typical

Re: [PATCH] - e1000e/ethtool.c - convert macros to functions

2007-11-01 Thread Kok, Auke
Joe Perches wrote: > Add functions for reg_pattern_test and reg_set_and check > Changed macros to use these functions > > Compiled x86, untested > > Size decreased ~2K > > old: > > $ size drivers/net/e1000e/ethtool.o >textdata bss dec hex filename > 14461 0 0

Re: [PATCH] decnet: "addr" module param can't be __initdata

2007-11-01 Thread Steven Whitehouse
Hi, Looks good, Feel free to add: Acked-by: Steven Whitehouse <[EMAIL PROTECTED]> Steve. On Thu, Nov 01, 2007 at 06:36:29PM +0300, Alexey Dobriyan wrote: > sysfs keeps references to module parameters via /sys/module/*/parameters, > so marking them as __initdata can't work. > > Steps to reprodu

Re: [PATCH] Clean the ip_sockglue.c from some ugly ifdefs

2007-11-01 Thread Pavel Emelyanov
Arnaldo Carvalho de Melo wrote: > Em Thu, Nov 01, 2007 at 06:52:34PM +0300, Pavel Emelyanov escreveu: >> The #idfed CONFIG_IP_MROUTE is sometimes places inside the if-s, >> which looks completely bad. Similar ifdefs inside the functions >> looks a bit better, but they are also not recommended to be

Re: [PATCH] Clean the ip_sockglue.c from some ugly ifdefs

2007-11-01 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 01, 2007 at 06:52:34PM +0300, Pavel Emelyanov escreveu: > The #idfed CONFIG_IP_MROUTE is sometimes places inside the if-s, > which looks completely bad. Similar ifdefs inside the functions > looks a bit better, but they are also not recommended to be used. > > Provide an ifdef-ed ip_mr

Re: af_packet.c flush_dcache_page

2007-11-01 Thread Evgeniy Polyakov
On Thu, Nov 01, 2007 at 05:10:32PM +0100, Patrick McHardy ([EMAIL PROTECTED]) wrote: > David Miller wrote: > >Instead of answering your questions, I'm going to show you > >how to avoid having to do any of this cache flushing crap :-) > > > >You can avoid having to flush anything as long as the vir

Re: [PATCH] INET : removes per bucket rwlock in tcp/dccp ehash table

2007-11-01 Thread Stephen Hemminger
On Thu, 01 Nov 2007 11:16:20 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > As done two years ago on IP route cache table (commit > 22c047ccbc68fa8f3fa57f0e8f906479a062c426) , we can avoid using one lock per > hash bucket for the huge TCP/DCCP hash tables. > > On a typical x86_64 platform, thi

Re: af_packet.c flush_dcache_page

2007-11-01 Thread Patrick McHardy
David Miller wrote: Instead of answering your questions, I'm going to show you how to avoid having to do any of this cache flushing crap :-) You can avoid having to flush anything as long as the virtual addresses on the kernel side are modulo SHMLBA the virtual addresses on the userland side. W

Re: [PATCH] INET : removes per bucket rwlock in tcp/dccp ehash table

2007-11-01 Thread Jarek Poplawski
Hi, A few doubts below: Eric Dumazet wrote: > As done two years ago on IP route cache table (commit > 22c047ccbc68fa8f3fa57f0e8f906479a062c426) , we can avoid using one lock per > hash bucket for the huge TCP/DCCP hash tables. ... > diff --git a/include/net/inet_hashtables.h b/include/net/inet

[PATCH 2/2][NETFILTER] Use the list_for_each_entry in nf_sockopt.c

2007-11-01 Thread Pavel Emelyanov
The list_head pointer, used to iterate over the list, is not used at all, but to get the struct nf_sockopt_ops pointer (and actually not in the 100% clean way). So use the list_for_each_entry, removing one unneeded variable from each place of use. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]

[PATCH 1/2][NETFILTER] Consolidate nf_sockopt and compat_nf_sockopt

2007-11-01 Thread Pavel Emelyanov
Both lookup the nf_sockopt_ops object to call the get/set callbacks from, but they perform it in a completely similar way. Introduce the helper for finding the ops. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/net/netfilter/nf_sockopt.c b/net/netfilter/nf_sockopt.c index

[PATCH] Clean the ip_sockglue.c from some ugly ifdefs

2007-11-01 Thread Pavel Emelyanov
The #idfed CONFIG_IP_MROUTE is sometimes places inside the if-s, which looks completely bad. Similar ifdefs inside the functions looks a bit better, but they are also not recommended to be used. Provide an ifdef-ed ip_mroute_opt() helper to cleanup the code. Signed-off-by: Pavel Emelyanov <[EMAIL

[PATCH] decnet: "addr" module param can't be __initdata

2007-11-01 Thread Alexey Dobriyan
sysfs keeps references to module parameters via /sys/module/*/parameters, so marking them as __initdata can't work. Steps to reproduce: modprobe decnet cat /sys/module/decnet/parameters/addr BUG: unable to handle kernel paging request at virtual address f88cd410 printing eip: c04

Re: [PATCH] [IPv6] SNMP: Restore Udp6InErrors incrementation

2007-11-01 Thread Herbert Xu
On Thu, Nov 01, 2007 at 10:46:38PM +0900, Mitsuru Chinen wrote: > As the checksum verification is postponed till user calls recv or poll, > the inrementation of Udp6InErrors counter should be also postponed. > Currently, it is postponed in non-blocking operation case. However it > should be postpon

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?

2007-11-01 Thread Ben Greear
David Miller wrote: From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 18:23:37 -0700 The code in AF_PACKET should fix the skb before passing to user space so that there is no difference between accel and non-accel hardware. Internal choices shouldn't leak to user space. Di

[PATCH] net: Add 405EX support to new EMAC driver

2007-11-01 Thread Stefan Roese
This patch adds support for the 405EX to the new EMAC driver. Tested on AMCC Kilauea. Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c |3 ++- drivers/net/ibm_newemac/rgmii.c |6 -- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/driv

[PATCH 2/2] [POWERPC] Fix region size check in mpc5200 FEC driver

2007-11-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Driver shouldn't complain if the register range is larger than what it expects. This works around failures with some device trees. Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- drivers/net/fec_mpc52xx.c |4 ++-- 1 files changed, 2 insertions(+),

[PATCH 1/2] [POWERPC] mpc5200: Fix Kconfig dependancies on MPC5200 FEC device driver

2007-11-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> When not building an arch/powerpc kernel, the mpc5200 FEC driver depends on some symbols which are not defined (BESTCOMM & BESTCOMM_FEC). This patch flips around the dependancy logic so that it cannot be selected unless BESTCOMM_FEC is selected first. Kconf

[PATCH 0/2] Fixes to MPC5200 FEC driver

2007-11-01 Thread Grant Likely
Oops, send this series yesterday but forgot to include jgarzik, domen and netdev to the 'to:' list. These are fixes which should go in for .24 Cheers, g. -- Grant Likely, B.Sc. P.Eng. Secret Lab Technologies Ltd. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

[PATCH] Remove /proc/net/stat/*_arp_cache upon module removal

2007-11-01 Thread Alexey Dobriyan
neigh_table_init_no_netlink() creates them, but they aren't removed anywhere. Steps to reproduce: modprobe clip rmmod clip cat /proc/net/stat/clip_arp_cache BUG: unable to handle kernel paging request at virtual address f89d7758 printing eip: c05a99da *pdpt =

[PATCH] [IPv6] SNMP: Restore Udp6InErrors incrementation

2007-11-01 Thread Mitsuru Chinen
As the checksum verification is postponed till user calls recv or poll, the inrementation of Udp6InErrors counter should be also postponed. Currently, it is postponed in non-blocking operation case. However it should be postponed in all case like the IPv4 code. Signed-off-by: Mitsuru Chinen <[EMAI

Re: [UDP6]: Restore sk_filter optimisation

2007-11-01 Thread Mitsuru Chinen
On Wed, 31 Oct 2007 22:42:57 +0800 Herbert Xu <[EMAIL PROTECTED]> wrote: > On Wed, Oct 31, 2007 at 11:05:45PM +0900, Mitsuru Chinen wrote: > > > > > > 1. udp6InDatagrams is incremented instead of udpInErrors > > > > 2. In userland, recvfrom() replies an error with EAGAIN. > > > > recvfrom()

Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

2007-11-01 Thread tnt
> + while (bcom_buffer_done(priv->tx_dmatsk)) { > + struct sk_buff *skb; > + skb = bcom_retrieve_buffer(priv->tx_dmatsk, NULL, NULL); > + /* Here (and in rx routines) would be a good place for > + * dma_unmap_single(), but bcom doesn't return bco

Re: [PATCH] INET : removes per bucket rwlock in tcp/dccp ehash table

2007-11-01 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 01, 2007 at 04:03:40AM -0700, David Miller escreveu: > From: Eric Dumazet <[EMAIL PROTECTED]> > Date: Thu, 01 Nov 2007 11:16:20 +0100 > > > As done two years ago on IP route cache table (commit > > 22c047ccbc68fa8f3fa57f0e8f906479a062c426) , we can avoid using one lock per > > hash b

Re: [PATCH] INET : removes per bucket rwlock in tcp/dccp ehash table

2007-11-01 Thread Ilpo Järvinen
On Thu, 1 Nov 2007, Eric Dumazet wrote: > @@ -134,6 +156,13 @@ static inline struct inet_ehash_bucket > *inet_ehash_bucket( > return &hashinfo->ehash[hash & (hashinfo->ehash_size - 1)]; > } > > +static inline rwlock_t *inet_ehash_lockp( > + struct inet_hashinfo *hashinfo, ...These t

Re: [PATCH] INET : removes per bucket rwlock in tcp/dccp ehash table

2007-11-01 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Thu, 01 Nov 2007 11:16:20 +0100 > As done two years ago on IP route cache table (commit > 22c047ccbc68fa8f3fa57f0e8f906479a062c426) , we can avoid using one lock per > hash bucket for the huge TCP/DCCP hash tables. > > On a typical x86_64 platform, t

[PATCH] INET : removes per bucket rwlock in tcp/dccp ehash table

2007-11-01 Thread Eric Dumazet
As done two years ago on IP route cache table (commit 22c047ccbc68fa8f3fa57f0e8f906479a062c426) , we can avoid using one lock per hash bucket for the huge TCP/DCCP hash tables. On a typical x86_64 platform, this saves about 2MB or 4MB of ram, for litle performance differences. (we hit a differ

Re: [PATCH] ucc_geth: add support for netpoll

2007-11-01 Thread Anton Vorontsov
On Thu, Nov 01, 2007 at 10:33:24AM +0800, Li Yang-r58472 wrote: > > -Original Message- > > From: Anton Vorontsov [mailto:[EMAIL PROTECTED] > > Sent: Thursday, November 01, 2007 5:59 AM > > To: Li Yang-r58472 > > Cc: netdev@vger.kernel.org; [EMAIL PROTECTED]; > > [EMAIL PROTECTED] > > Subj

Re: [PATCH][BNX2X] added register coments - bnx2x_init.h

2007-11-01 Thread Eliezer Tamir
On Thu, 2007-11-01 at 02:56 -0700, David Miller wrote: > From: "Eliezer Tamir" <[EMAIL PROTECTED]> > Date: Thu, 01 Nov 2007 11:56:17 +0200 > > > posting individual files for comments. > > > > --- > > #ifndef __BNX2X_NEW_INIT_H__ > > #define __BNX2X_NEW_INIT_H__ > > Too big for the mailing lists.

Re: [PATCH][BNX2X] added register coments - bnx2x_init.h

2007-11-01 Thread David Miller
From: "Eliezer Tamir" <[EMAIL PROTECTED]> Date: Thu, 01 Nov 2007 11:56:17 +0200 > posting individual files for comments. > > --- > #ifndef __BNX2X_NEW_INIT_H__ > #define __BNX2X_NEW_INIT_H__ Too big for the mailing lists. - To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH][BNX2X] added register coments - bnx2x_init.h

2007-11-01 Thread Eliezer Tamir
posting individual files for comments. --- /* bnx2x_init.h: Broadcom Everest network driver. * * Copyright (c) 2007 Broadcom Corporation * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free

Re: [PATCH][BNX2X] added register coments - bnx2x_fw_defs.h

2007-11-01 Thread Eliezer Tamir
posting individual files for comments. --- /* bnx2x_fw_defs.h: Broadcom Everest network driver. * * Copyright (c) 2007 Broadcom Corporation * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Fr

Re: [PATCH][BNX2X] added register coments - bnx2x.h

2007-11-01 Thread Eliezer Tamir
posting individual files for comments. --- /* bnx2x.h: Broadcom Everest network driver. * * Copyright (c) 2007 Broadcom Corporation * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Softw

Re: [PATCH][BNX2X] added register coments

2007-11-01 Thread Eliezer Tamir
On Thu, 2007-11-01 at 02:28 -0700, David Miller wrote: > From: "Eliezer Tamir" <[EMAIL PROTECTED]> > Date: Thu, 01 Nov 2007 11:28:25 +0200 > > > Here is the version with added register comments. > > Please consider applying. > > The 2.6.24 merge window is closed, so even if I thought > the driver

[patch 2/2] ipvs: Syncrhonise Closing of Connections

2007-11-01 Thread Simon Horman
From: Rumen G. Bogdanovski <[EMAIL PROTECTED]> This patch makes the master daemon to sync the connection when it is about to close. This makes the connections on the backup to close or timeout according their state. Before the sync was performed only if the connection is in ESTABLISHED state whi

[patch 1/2] ipvs: Bind connections on stanby if the destination exists

2007-11-01 Thread Simon Horman
From: Rumen G. Bogdanovski <[EMAIL PROTECTED]> This patch fixes the problem with node overload on director fail-over. Given the scenario: 2 nodes each accepting 3 connections at a time and 2 directors, director failover occurs when the nodes are fully loaded (6 connections to the cluster) in this

[patch 0/2] ipvs: avoid overcommit on the standby, take II

2007-11-01 Thread Simon Horman
Two related patches from Rumen G. Bogdanovski to help prevent overcommit on the standby. After sending the last patchset I discovered scripts/checkpatch.pl and found that it didn't like quite a few things. I've fixed those problems and here is the result. -- Horms H: http://www.vergenet.net/~h

Re: [PATCH][BNX2X] added register coments

2007-11-01 Thread David Miller
From: "Eliezer Tamir" <[EMAIL PROTECTED]> Date: Thu, 01 Nov 2007 11:28:25 +0200 > Here is the version with added register comments. > Please consider applying. The 2.6.24 merge window is closed, so even if I thought the driver is perfect it cannot be included right now. It will need to be resubm

[PATCH][BNX2X] added register coments

2007-11-01 Thread Eliezer Tamir
Dave, Here is the version with added register comments. Please consider applying. ftp link: ftp://[EMAIL PROTECTED]/0001-bnx2x-0.4.12-with-reg-remarks.txt gzipped: ftp://[EMAIL PROTECTED]/0001-bnx2x-0.4.12-with-reg-remarks.txt.gz (I will also post each individual file for review as a reply to t

Re: [PATCH] net: docbook fixes for netif_ functions

2007-11-01 Thread David Miller
From: Randy Dunlap <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 15:36:20 -0700 > > + * return values (usually ignored). > > + * NET_RX_SUCCESS (no congestion) > > + * NET_RX_DROP (packet was dropped) > > For the 3 lines above, how about: > > *Return values (usually ignored): > *NET_