Arnaldo Carvalho de Melo wrote: > Em Thu, Nov 01, 2007 at 06:52:34PM +0300, Pavel Emelyanov escreveu: >> The #idfed CONFIG_IP_MROUTE is sometimes places inside the if-s, >> which looks completely bad. Similar ifdefs inside the functions >> looks a bit better, but they are also not recommended to be used. >> >> Provide an ifdef-ed ip_mroute_opt() helper to cleanup the code. >> >> Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> > > Perhaps a better name would be ip_mroute_valid_opt()?
No :) The _valid_ mrote opts are from 0 to 8, according to MRT_XXX macros, not from 0 to 10 as checked. I suspect this was a kind of reserve for future use and thus do not change this. Correct me if I am wrong. > - Arnaldo Thanks, Pavel - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
