Re: [PATCH] napi: use non-interruptible sleep in napi_disable

Benjamin Herrenschmidt wrote: The current napi_disable() uses msleep_interruptible() but doesn't (and can't) exit in case there's a signal, thus ending up doing a hot spin without a cpu_relax. Use uninterruptible sleep instead. Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- incl

QUESTION: How to fix race between .suspend routine and watchdog timer

Hi, Recently, trying to fix saa7134 suspend/resume problems I found that there is a race between IRQ handler and .suspend , and that I cant let driver access the device while its in D3 since it can lock up some systems. Now I am looking to fix those issues in two drivers that have my .suspend/

[PATCH] napi: use non-interruptible sleep in napi_disable

The current napi_disable() uses msleep_interruptible() but doesn't (and can't) exit in case there's a signal, thus ending up doing a hot spin without a cpu_relax. Use uninterruptible sleep instead. Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- include/linux/netdevice.h |2 +-

Re: stateless 1:1 NAT

Florin Andrei <[EMAIL PROTECTED]> wrote: > > OK, if I download 2.6.24-rc1, will it have this feature already? Yes. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.o

Re: [PATCH 1/3] [IPSEC]: Forbid BEET + ipcomp for now

On Wed, Oct 24, 2007 at 05:41:34PM +0200, Nicolas Dichtel wrote: > > >+x->props.header_len = 0; > >+switch (x->props.mode) { > >+case XFRM_MODE_TRANSPORT: > >+break; > >+case XFRM_MODE_TUNNEL: > >+x->props.header_len += sizeof(struct iphdr); > I think, the br

Re: [2.6 patch] bonding/bond_main.c: fix cut'n'paste error

Adrian Bunk <[EMAIL PROTECTED]> wrote: >This patch fixes a cut'n'paste error in >commit 1b76b31693d4a6088dec104ff6a6ead54081a3c2. > >Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Please apply. -J Acked-by: Jay Vosburgh <[EMAIL PROTECTED]> >--- >4888742f8d7fe3b97fbc2911aa4637

Re: [PATCH 13/13] r8169: more phy init for the 8168

Glen Gray <[EMAIL PROTECTED]> : > Are any of these likely to fix the Ethernet multicast issues a few of us > have seen with 8110sc cards ? No, this serie is not expected to. I have planned to work on it again during the bugfix phase of 2.6.24-rc. Is it still an option for you to use the old rea

Re: [2.6 patch] make tcp_match_skb_to_sack() static

On Wed, 24 Oct 2007, Adrian Bunk wrote: > tcp_match_skb_to_sack() can become static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > [...snip...] Thanks, I should have noticed that right from the beginning... Added DaveM to recipients. -- i. - To unsubscribe from this list: send the lin

Re: [2.6 patch] unexport icmpmsg_statistics

David Stevens wrote: > My bad -- I see what it's doing, and it looks ok after all. > > I thought I saw an INMSGS (but didn't). These are ICMP errors that > went through icmp_rcv() and were counted correctly before getting > to the protocol error handlers. These are failures due mostly to not > ha

Re: [2.6 patch] unexport icmpmsg_statistics

David Stevens wrote: > My bad -- I see what it's doing, and it looks ok after all. > jinx, crossed in flight. ;) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [2.6 patch] unexport icmpmsg_statistics

David Stevens wrote: > I took a look at the DCCP references, and I think they're just > incrementing the wrong MIB variable -- e.g., it's incrementing > ICMP_MIB_INERRORS when the skb length is less than the > header indicates. That's not an ICMP_MIB_INERRORS error, > that's an IPSTATS_MIB_INHDRERR

Re: [2.6 patch] unexport icmpmsg_statistics

My bad -- I see what it's doing, and it looks ok after all. I thought I saw an INMSGS (but didn't). These are ICMP errors that went through icmp_rcv() and were counted correctly before getting to the protocol error handlers. These are failures due mostly to not having enough, or the right protoco

Re: [2.6 patch] #if 0 sctp_update_copy_cksum()

Adrian Bunk wrote: > sctp_update_copy_cksum() is no longer used. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> ACK. -vlad > > --- > > include/net/sctp/sctp.h |1 - > net/sctp/crc32c.c |2 ++ > 2 files changed, 2 insertions(+), 1 deletion(-) > > fc6646f84c07666228166c678ff

Re: [2.6 patch] net/sctp/auth.c: make 3 functions static

Adrian Bunk wrote: > This patch makes three needlessly global functions static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> ACK. Thanks for catching these.. -vlad - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majord

Re: [2.6 patch] unexport icmpmsg_statistics

David Stevens wrote: > I took a look at the DCCP references, and I think they're just > incrementing the wrong MIB variable -- e.g., it's incrementing > ICMP_MIB_INERRORS when the skb length is less than the > header indicates. That's not an ICMP_MIB_INERRORS error, > that's an IPSTATS_MIB_INHDRERR

Re: [2.6 patch] unexport icmpmsg_statistics

I took a look at the DCCP references, and I think they're just incrementing the wrong MIB variable -- e.g., it's incrementing ICMP_MIB_INERRORS when the skb length is less than the header indicates. That's not an ICMP_MIB_INERRORS error, that's an IPSTATS_MIB_INHDRERRORS error. ICMP_MIB_INERRORS is

Re: [2.6 patch] unexport icmpmsg_statistics

[EMAIL PROTECTED] wrote on 10/24/2007 12:14:37 PM: > On Wed, Oct 24, 2007 at 12:07:45PM -0700, David Stevens wrote: > > [EMAIL PROTECTED] wrote on 10/24/2007 09:24:10 AM: > > > > > This patch removes the unused EXPORT_SYMBOL(icmpmsg_statistics). > > > > > > Signed-off-by: Adrian Bunk <[EMAIL PRO

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

Benjamin Herrenschmidt wrote: On Tue, 2007-10-23 at 20:57 -0500, Valentine Barshak wrote: +static int m88e_init(struct mii_phy *phy) +{ + printk("%s: Marvell 88E Ethernet\n", __FUNCTION__); + phy_write(phy, 0x14, 0x0ce3); + phy_write(phy, 0x18, 0x4101); + phy_wri

Re: [PATCH 1/2] NFS: change the ip_map cache code to handle IPv6 addresses

Hi Aurelien, I think you're almost there, at least with my comments :) linux-2.6.23-ipmap/include/net/ipv6.h --- linux-2.6.23-haley/include/net/ipv6.h2007-10-22 09:42:58.0 +0200 +++ linux-2.6.23-ipmap/include/net/ipv6.h2007-10-22 10:10:59.0 +0200 @@ -21,6 +21,7 @@ #in

Re: [PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

Hi Aurelien, Again, a few more comments. I might just modify these in my own tree and send out a patch that combines both into one, it might be less work. @@ -229,9 +229,20 @@ static ssize_t write_getfs(struct file * return -EINVAL; data = (struct nfsctl_fsparm*)buf;

Re: stateless 1:1 NAT

Herbert Xu wrote: Florin Andrei <[EMAIL PROTECTED]> wrote: I've heard that stateless 1:1 NAT will be possible with the upcoming 2.6.24 kernel. I'd like to test that feature, but I'm not sure when it will actually be included. Will it be present in the release candidates for 2.6.24? I just need

Re: [2.6 patch] unexport icmpmsg_statistics

On Wed, Oct 24, 2007 at 12:07:45PM -0700, David Stevens wrote: > [EMAIL PROTECTED] wrote on 10/24/2007 09:24:10 AM: > > > This patch removes the unused EXPORT_SYMBOL(icmpmsg_statistics). > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > > > --- > > 4ce74657ac0b1bdcb4c7bc359d05643f8cc4a0

Re: [2.6 patch] unexport icmpmsg_statistics

[EMAIL PROTECTED] wrote on 10/24/2007 09:24:10 AM: > This patch removes the unused EXPORT_SYMBOL(icmpmsg_statistics). > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- > 4ce74657ac0b1bdcb4c7bc359d05643f8cc4a08b > diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c > index 272c69e..233de06 1

Re: [2.6 patch] make sunrpc/xprtsock.c:xs_setup_{udp,tcp}() static

Adrian Bunk wrote: xs_setup_{udp,tcp}() can now become static. ACK. Sorry this was overlooked. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- include/linux/sunrpc/xprtsock.h |6 -- net/sunrpc/xprtsock.c |4 ++-- 2 files changed, 2 insertions(+), 8 deletions(-) 8

[PATCH 2/2] forcedeth new device ids

This patch adds new device ids and features for mcp77 devices into the forcedeth driver. Signed-off-by: Ayaz Abdulla <[EMAIL PROTECTED]> --- old/drivers/net/forcedeth.c 2007-10-23 16:47:08.0 -0400 +++ new/drivers/net/forcedeth.c 2007-10-23 16:47:11.0 -0400 @@ -5597,6 +5597,22 @@

[PATCH 1/2] forcedeth new device ids

This patch adds new device ids for mcp77 devices. Signed-off-by: Ayaz Abdulla <[EMAIL PROTECTED]> --- old/include/linux/pci_ids.h 2007-10-23 16:49:46.0 -0400 +++ new/include/linux/pci_ids.h 2007-10-23 16:50:50.0 -0400 @@ -1236,6 +1236,10 @@ #define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP

[2.6 patch] bonding/bond_main.c: fix cut'n'paste error

This patch fixes a cut'n'paste error in commit 1b76b31693d4a6088dec104ff6a6ead54081a3c2. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 4888742f8d7fe3b97fbc2911aa46375048173d01 diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index e5fab4b..6937ef0 100644 --- a/

[2.6 patch] remove Documentation/networking/net-modules.txt

According to git, the only one who touched this file during the last 5 years was me when removing drivers... modinfo offers less ancient information. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Geert Uytterhoeven <[EMAIL PROTECTED]> Acked-by: Paul Gortmaker <[EMAIL PROTECTED]> ---

[2.6 patch] unexport softnet_data

The EXPORT_PER_CPU_SYMBOL(softnet_data) is no longer used. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 6bf19ad197b0076e48be8720659d38413d438e26 diff --git a/net/core/dev.c b/net/core/dev.c index 38b03da..113d216 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -4469,4 +4469,3 @@ EXPORT

[2.6 patch] net/sctp/auth.c: make 3 functions static

This patch makes three needlessly global functions static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- include/net/sctp/auth.h |1 - net/sctp/auth.c |6 +++--- 2 files changed, 3 insertions(+), 4 deletions(-) 102a72ca5278d3c502bee6af4c4d11c9876d5a2d diff --git a/include

[2.6 patch] unexport icmpmsg_statistics

This patch removes the unused EXPORT_SYMBOL(icmpmsg_statistics). Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 4ce74657ac0b1bdcb4c7bc359d05643f8cc4a08b diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c index 272c69e..233de06 100644 --- a/net/ipv4/icmp.c +++ b/net/ipv4/icmp.c @@ -1104,5 +1104,4

[2.6 patch] #if 0 sctp_update_copy_cksum()

sctp_update_copy_cksum() is no longer used. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- include/net/sctp/sctp.h |1 - net/sctp/crc32c.c |2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) fc6646f84c07666228166c678ff2b5916db925ed diff --git a/include/net/sctp/sctp.h b/i

[2.6 patch] unexport sock_enable_timestamp

sock_enable_timestamp() no longer has any modular users. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- c207a1b7709635c74b953324e60ab5a732ea279c diff --git a/net/core/sock.c b/net/core/sock.c index febbcbc..bba9949 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -1649,7 +1649,6 @@ void

[2.6 patch] make tcp_match_skb_to_sack() static

tcp_match_skb_to_sack() can become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- b734b439219a6251b7deb65dad2307f9c891f680 diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 9288220..603400d 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -1204,8 +1204,8 @

[2.6 patch] make sunrpc/xprtsock.c:xs_setup_{udp,tcp}() static

xs_setup_{udp,tcp}() can now become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- include/linux/sunrpc/xprtsock.h |6 -- net/sunrpc/xprtsock.c |4 ++-- 2 files changed, 2 insertions(+), 8 deletions(-) 833a31c8caef70589f33be8e3a1fc9d8e01ce3c2 diff --git a/inc

[2.6 patch] make ircomm_tty static

ircomm_tty can now become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- include/net/irda/ircomm_tty.h |1 - net/irda/ircomm/ircomm_tty.c |2 +- 2 files changed, 1 insertion(+), 2 deletions(-) 487bdc857155e7346cbb80b07d2ec3df150fc9d2 diff --git a/include/net/irda/ircomm_t

[2.6 patch] drivers/net/ipg.c: cleanups

This patch contains the following cleanups: - make ipg_nic_get_stats() static - move DefaultPhyParam[] from ipg.h to ipg.c and make it static Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/ipg.c | 22 +- drivers/net/ipg.h | 20 2 file

[2.6 patch] make bonding/bond_main.c:bond_deinit() static

bond_deinit() can now become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/bonding/bond_main.c |3 ++- drivers/net/bonding/bonding.h |1 - 2 files changed, 2 insertions(+), 2 deletions(-) 5e5d2537b927f55a2199a0d9a073f41bb71290f6 diff --git a/drivers/net/bond

[PATCH 3/3] [IPSEC]: Separate inner/outer mode processing on output

[IPSEC]: Separate inner/outer mode processing on output With inter-family transforms the inner mode differs from the outer mode. Attempting to handle both sides from the same function means that it needs to handle both IPv4 and IPv6 which creates duplication and confusion. This patch separates th

[0/3] [IPSEC]: Separate inner/outer family processing on output

Hi Dave: These three patches are the first step in fixing inter-family support on the data path (the previous series should've solved it for the control path). I still need to fix the continuation on the output path and repeat this process for the input path. Cheers, -- Visit Openswan at http:/

[PATCH 1/3] [IPSEC]: Forbid BEET + ipcomp for now

[IPSEC]: Forbid BEET + ipcomp for now While BEET can theoretically work with IPComp the current code can't do that because it tries to construct a BEET mode tunnel type which doesn't (and cannot) exist. In fact as it is it won't even attach a tunnel object at all for BEET which is bogus. To supp

[PATCH 2/3] [IPSEC]: Move x->outer_mode->output out of locked section

[IPSEC]: Move x->outer_mode->output out of locked section RO mode is the only one that requires a locked output function. So it's easier to move the lock into that function rather than requiring everyone else to run under the lock. In particular, this allows us to move the size check into the ou

Re: [PATCH] NET: Validate device addr prior to interface-up

> diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c > index ed8a3d4..5471cd2 100644 > --- a/net/ethernet/eth.c > +++ b/net/ethernet/eth.c > @@ -298,6 +298,14 @@ static int eth_change_mtu(struct net_device *dev, int > new_mtu) > return 0; > } > > +static int eth_validate_addr(struct ne

[PATCH] dev_change_name: ignore changes to same name

Prevent error/backtrace from dev_rename() when changing name of network device to the same name. This is a common situation with udev and other scripts that bind addr to device. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/core/dev.c2007-10-24 06:01:31.0 -0700 +++ b/

[PATCH] small memory leak with FIB rules

This patch fixes a small memory leak. Default fib rules can be deleted by the user if the rule does not carry FIB_RULE_PERMANENT flag, f.e. by ip rule flush Such a rule will not be freed as the ref-counter has 2 on start and becomes clearly unreachable after removal. Signed-off-by: Denis

Re: [RFC][PATCH 0/3][XFRM]: Support packet processing error statistics.

On Wed, 2007-24-10 at 12:59 +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: > In article <[EMAIL PROTECTED]> (at Tue, 23 Oct 2007 16:08:34 +0900), Masahide > NAKAMURA <[EMAIL PROTECTED]> says: > > > Now we have the following candidates: > > > > (1) my patchXFRM_MIB_INHDRERROR > > (2) som

Re: [RFC][PATCH 0/3][XFRM]: Support packet processing error statistics.

On Wed, 2007-24-10 at 12:30 +0900, Masahide NAKAMURA wrote: > At IPsec point of view, actually "SPI mismatch" caused by user configuration > cannot be identified easily since identify of SAD is consist of SPI, address > and > protocol(ESP/AH...) and linux SAD uses hash database. It is database id

Re: [PATCH] USB: net: Fix asix read transfer buffer allocations.

On Wed, 2007-10-24 at 15:33 +0400, Valentine Barshak wrote: > On systems with noncoherent cache, allocating dma buffers > on the stack for USB IN transfers causes kernel crash, > because usb map_urb_for_dma() code calls dma_map_single(), > that invalidates data cache for DMA_FROM_DEVICE transfer d

Re: [BUG] 2.6.23-git19 - S390x: Kernel panic while bringing up the network interface

Heiko Carstens wrote: > On Wed, Oct 24, 2007 at 08:59:06AM +0530, Kamalesh Babulal wrote: >> Hi, >> >> Kernel panic's while bringing up the network interface with the 2.6.23-git19 >> >> Setting network parameters: Ý OK ¨ >> Bringing up loopback interface: Ý OK ¨ >> Bringing up interface eth0:

[PATCH] USB: net: Fix asix read transfer buffer allocations.

On systems with noncoherent cache, allocating dma buffers on the stack for USB IN transfers causes kernel crash, because usb map_urb_for_dma() code calls dma_map_single(), that invalidates data cache for DMA_FROM_DEVICE transfer direction and causes stack data loss if transfer size is less than cac

Re: [linux-usb-devel] [PATCH] USB: net: Fix asix read transfer buffer allocations.

Sorry, CC'ed Dave Brownell instead of Dave Hollis :) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] USB: net: Fix asix read transfer buffer allocations.

On systems with noncoherent cache, allocating dma buffers on the stack for USB IN transfers causes kernel crash, because usb map_urb_for_dma() code calls dma_map_single(), that invalidates data cache for DMA_FROM_DEVICE transfer direction and causes stack data loss if transfer size is less than cac

Re: [PATCH RESEND] ip_gre: sendto/recvfrom NBMA address

Hello! > I was able to set a nbma gre tunnel, add routes to it and it worked > perfectly ok. > > Link-level next hop worked: > ip route add via dev onlink This can work if you use gre0. By plain luck it has all-zero dev_addr. It will break on nbma devices set with: ip tunnel add XXX mode gr

Re: [PATCH 13/13] r8169: more phy init for the 8168

Are any of these likely to fix the Ethernet multicast issues a few of us have seen with 8110sc cards ? Francois Romieu wrote: Realtek's r8168 driver version 8.003.00 adds new init sequences (they do not appear in version 8.002.00). Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward

Re: on the topic of alternate MAC addresses

On Tue, 2007-10-23 at 20:22 -0700, David Miller wrote: > However, it's not the virt clients that do this, it's the control > node (aka: domain 0) which has to manage these things. > > It has to manage all of the global hardware resources and allocate > them out to itself and the clients anyways.

Re: [PATCH 0/5] Diet struct net_device a bit

On Mon, 2007-10-22 at 16:31 +0400, Pavel Emelyanov wrote: > * ieee80211_ptr is used in many wireless drivers. Need time >to check for the config dependencies. Depending on CFG80211 should be fine, if not that's a bug elsewhere. johannes signature.asc Description: This is a digitally signe