Re: [PATCH] rtnl: Simplify ASSERT_RTNL

2007-10-10 Thread Eric W. Biederman
David Miller <[EMAIL PROTECTED]> writes: > From: [EMAIL PROTECTED] (Eric W. Biederman) > Date: Fri, 28 Sep 2007 18:59:08 -0600 > >> >> Currently we have the call path: >> macvlan_open -> dev_unicast_add -> __dev_set_rx_mode -> >> __dev_set_promiscuity -> ASSERT_RTNL -> mutex_trylock >> >> W

Re: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use batching

2007-10-10 Thread Krishna Kumar2
Hi Dave, David Miller wrote on 10/10/2007 02:13:31 AM: > > Hopefully that new qdisc will just use the TX rings of the hardware > > directly. They are typically large enough these days. That might avoid > > some locking in this critical path. > > Indeed, I also realized last night that for the def

Re: [PATCH][IPv6] Export userland ND options through netlink (RDNSS support)

2007-10-10 Thread David Miller
From: Pierre Ynard <[EMAIL PROTECTED]> Date: Fri, 5 Oct 2007 08:09:30 +0200 > As discussed before, this patch provides userland with a way to access > relevant options in Router Advertisements, after they are processed and > validated by the kernel. Extra options are processed in a generic way; >

Re: [PATCH 1/1][NET] : Fix dev_put() and dev_hold() comments

2007-10-10 Thread David Miller
From: Benjamin Thery <[EMAIL PROTECTED]> Date: Tue, 02 Oct 2007 16:37:34 +0200 > Trivial fix: Swap comments for dev_put() and dev_hold() to get them > at the right place. > Typo introduced by 4fa57c9ea9f36f9ca852f3a88ca5d2f1aebbc960. > > Signed-of-by: Benjamin Thery <[EMAIL PROTECTED]> Applied,

Re: [PATCH] rtnl: Simplify ASSERT_RTNL

2007-10-10 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Fri, 28 Sep 2007 18:59:08 -0600 > > Currently we have the call path: > macvlan_open -> dev_unicast_add -> __dev_set_rx_mode -> > __dev_set_promiscuity -> ASSERT_RTNL -> mutex_trylock > > When mutex debugging is on taking a mutex complains i

Re: [PATCH 5/5] make netlink user -> kernel interface synchronious

2007-10-10 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Fri, 5 Oct 2007 18:48:44 +0400 > This patch make processing netlink user -> kernel messages synchronious. > This change was inspired by the talk with Alexey Kuznetsov about current > netlink messages processing. He says that he was badly wrong when

[PATCH 5/6] Convert more locks to _bh, acquire rtnl, for new locking

2007-10-10 Thread Jay Vosburgh
Convert more lock acquisitions to _bh flavor to avoid deadlock with workqueue activity and add acquisition of RTNL in appropriate places. Affects ALB mode, as well as core bonding functions and sysfs. Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]> Signed-off-by: Jay Vosburgh <[EMAIL PR

Re: [PATCH 4/5] unify netlink kernel socket recognition

2007-10-10 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Fri, 5 Oct 2007 18:47:43 +0400 > There are currently two ways to determine whether the netlink socket is a > kernel one or a user one. This patch creates a single inline call for > this purpose and unifies all the calls in the af_netlink.c > > No s

[PATCH 3/6] Convert miimon to new locking

2007-10-10 Thread Jay Vosburgh
Convert mii (link state) monitor to acquire correct locks for failover events. In particular, failovers generally require RTNL at a low level (when manipulating device MAC addresses, for example) and no other locks. The high level monitor is responsible for acquiring a known set of locks,

[PATCH 6/6] Acquire correct locks in alb for promisc change

2007-10-10 Thread Jay Vosburgh
Update ALB mode monitor to hold correct locks (RTNL and nothing else) when calling dev_set_promiscuity. Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]> Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]> --- drivers/net/bonding/bond_alb.c | 19 ++- 1 files changed, 10 ins

[PATCH 1/6] Convert bonding timers to workqueues

2007-10-10 Thread Jay Vosburgh
Convert bonding timers to workqueues. This converts the various monitor functions to run in periodic work queues instead of timers. This patch introduces the framework and convers the calls, but does not resolve various locking issues, and does not stand alone. Signed-off-by: Andy Gospod

[PATCH 4/6] Convert locks to _bh, rework alb locking for new locking

2007-10-10 Thread Jay Vosburgh
Convert locking-related activity to new & improved system. Convert some lock acquisitions to _bh and rework parts of ALB mode, both to avoid deadlocks with workqueue activity. Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]> Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]> --- drivers/ne

[PATCH 2/6] Convert balance-rr transmit to new locking

2007-10-10 Thread Jay Vosburgh
Change locking in balance-rr transmit processing to use a free running counter to determine which slave to transmit on. Instead, a free-running counter is maintained, and modulo arithmetic used to select a slave for transmit. This removes lock operations from the TX path, and elim

Re: [PATCH 3/5] cleanup 3rd argument in netlink_sendskb

2007-10-10 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Fri, 5 Oct 2007 18:46:23 +0400 > netlink_sendskb does not use third argument. Clean it and save a couple of > bytes. > > Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> > Acked-by: Alexey Kuznetsov <[EMAIL PROTECTED]> Applied. - To unsubscribe f

[PATCH 0/6] bonding workqueue and lock rework

2007-10-10 Thread Jay Vosburgh
Following are patches to update the locking used in the bonding driver. This involves two basic changes: conversion from timers to workqueues for the various periodic monitor functions, and conversion of locking. These patches should resolve the majority of locking and might sleep related

Re: [PATCH 2/5] make netlink processing routines semi-synchronious (inspired by rtnl) v2

2007-10-10 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Fri, 5 Oct 2007 18:45:10 +0400 > The code in netfilter/nfnetlink.c and in ./net/netlink/genetlink.c looks > like outdated copy/paste from rtnetlink.c. Push them into sync with the > original. > > Changes from v1: > - deleted comment in nfnetlink_rc

Re: [PATCH 1/5] rtnl_unlock cleanups

2007-10-10 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Fri, 5 Oct 2007 18:44:14 +0400 > There is no need to process outstanding netlink user->kernel packets > during rtnl_unlock now. There is no rtnl_trylock in the rtnetlink_rcv > anymore. > > Normal code path is the following: > netlink_sendmsg >n

Re: [PATCH] Fix typos in comments in netlink.h

2007-10-10 Thread David Miller
From: Pierre Ynard <[EMAIL PROTECTED]> Date: Fri, 5 Oct 2007 08:09:40 +0200 > This patch fixes a few typos in comments in include/net/netlink.h > > Signed-off-by: Pierre Ynard <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: authenc compile warnings in current net-2.6.24

2007-10-10 Thread Herbert Xu
On Thu, Oct 11, 2007 at 11:23:30AM +0800, Herbert Xu wrote: > > Yeah I've added a fix in the cryptodev tree. Oh and here's the actual patch. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP

Re: authenc compile warnings in current net-2.6.24

2007-10-10 Thread Herbert Xu
On Wed, Oct 10, 2007 at 04:25:28PM -0700, David Miller wrote: > > It's just not smart enough to see that cryptlen's initialization > and it's use in the auth_unlock label path are both protected > by 'err' being non-zero. > > To be honest I don't know of any compiler which commits enough > flow va

Re: PROBLEM: skb_clone SMP race?

2007-10-10 Thread Herbert Xu
Santiago Font Arquer <[EMAIL PROTECTED]> wrote: > > If an skb with fast clone available (first "if" true) has > references in different CPUs (skb->users>1) (I do not find explicit > checks for this to be impossible), if skb_clone is called > simultaneously over that skb, both callers can get the

Re: [PATCH][BNX2X] round three - sparse warnings.

2007-10-10 Thread Stephen Hemminger
Please fix these... CHECK drivers/net/bnx2x.c drivers/net/bnx2x_asm.h:62:2: warning: cast removes address space of expression drivers/net/bnx2x_asm.h:62:2: warning: incorrect type in argument 2 (different address spaces) drivers/net/bnx2x_asm.h:62:2:expected void volatile [noderef] *addr

Re: [RFC PATCH] [TCP]: Fix lost_retrans loop vs fastpath problems

2007-10-10 Thread TAKANO Ryousei
From: "Ilpo Järvinen" <[EMAIL PROTECTED]> Subject: [RFC PATCH] [TCP]: Fix lost_retrans loop vs fastpath problems Date: Tue, 9 Oct 2007 15:20:01 +0300 > Detection implemented with lost_retrans must work also when > fastpath is taken, yet most of the queue is skipped including > (very likely) those

RE: [PATCH net-2.6.24] s2io: sparse warnings fix (rev2)

2007-10-10 Thread Ramkrishna Vepa
Stephen, > Fix warnings from sparse checker about shadowed definition and improperly > formatted ethtool_strings. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> > > --- > CHECK drivers/net/s2io.c > - * lro: Specifies whether to enable Large Receive Offload (LRO) or not. > + * lro_e

Re: [PATCH][BNX2X] round three

2007-10-10 Thread Stephen Hemminger
Minor formatting nits reported by checkpatch.pl script: WARNING: braces {} are not necessary for single statement blocks #506: FILE: drivers/net/bnx2x.c:451: + if (REG_RD(bp, GRCBASE_HC, addr) != val) { + BNX2X_ERR("BUG! proper val not read from IGU!\n"); + } WARNING: br

Re: e100 problems in .23rc8 ?

2007-10-10 Thread Herbert Xu
On Wed, Oct 10, 2007 at 08:36:38PM -0400, Dave Jones wrote: > > The e1000 changes you reference above, is this the changeset you mean? > > commit 416b5d10afdc797c21c457ade3714e8f2f75edd9 > Author: Auke Kok <[EMAIL PROTECTED]> > Date: Fri Jun 1 10:22:39 2007 -0700 > > e1000: disable polling

Re: [PATCH 0/5] tg3: Add 5761 support

2007-10-10 Thread David Miller
From: "Matt Carlson" <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 17:45:16 -0700 > The following patchset adds support for the 5761 device and enables WOL > by default if out-of-box WOL is enabled in the NVRAM. The 5761 patches > were tested against preproduction hardware. All applied, thanks Matt

Re: [PATCH][MIPS][6/6] AR7: leds driver

2007-10-10 Thread Matteo Croce
The new led driver, uses leds-gpio now Signed-off-by: Matteo Croce <[EMAIL PROTECTED]> Signed-off-by: Nicolas Thill <[EMAIL PROTECTED]> diff --git a/drivers/leds/leds-ar7.c b/drivers/leds/leds-ar7.c new file mode 100644 index 000..72b958a --- /dev/null +++ b/drivers/leds/leds-ar7.c @@ -0,0 +1

Re: [PATCH][BNX2X] round three

2007-10-10 Thread David Miller
From: "Eliezer Tamir" <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 21:52:30 +0200 > Eliezer Tamir wrote: > > The full patch is available at: > > [EMAIL PROTECTED]://ftp1.broadcom.com/0001-BNX2X-0.40.10a-net-2.6.24.patch > > Just when I thought I have beaten the line beast. > (or maybe it's just too

[PATCH 2/5] tg3: Add 5761 APE support

2007-10-10 Thread Matt Carlson
This patch adds support for the new APE block, present in 5761 chips. APE stands for Application Processing Engine. The primary function of the APE is to process manageability traffic, such as ASF. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> di

[PATCH 1/5] tg3: Add new 5761 NVRAM decode routines

2007-10-10 Thread Matt Carlson
This patch adds a new 5761-specific NVRAM strapping decode routine. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 1e0c9e0..3200c9c 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -

[PATCH 4/5] tg3: WOL defaults

2007-10-10 Thread Matt Carlson
This patch enables WOL by default if out-of-box WOL is enabled in the NVRAM. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 3af93b5..8967bc3 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/t

[PATCH 3/5] tg3: Add 5761 support

2007-10-10 Thread Matt Carlson
This patch adds rest of the miscellaneous code required to support the 5761. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 5b6c1b2..3af93b5 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/t

[PATCH 0/5] tg3: Add 5761 support

2007-10-10 Thread Matt Carlson
The following patchset adds support for the 5761 device and enables WOL by default if out-of-box WOL is enabled in the NVRAM. The 5761 patches were tested against preproduction hardware. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECT

[PATCH 5/5] tg3: Update version to 3.83

2007-10-10 Thread Matt Carlson
Update to version 3.83. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 8967bc3..fa8f6c0 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -64,8 +64,8 @@ #define DRV_MODULE_NAME

Re: [PATCH 2/2] ip: local port range robustness

2007-10-10 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 17:00:22 -0700 > Expansion of original idea from Denis V. Lunev <[EMAIL PROTECTED]> > > Add robustness and locking to the local_port_range sysctl. > 1. Enforce that low < high when setting. > 2. Use seqlock to ensure atomic update

Re: [PATCH 1/2] SCTP: port randomization

2007-10-10 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 17:00:21 -0700 > Add port randomization rather than a simple fixed rover > for use with SCTP. This makes it act similar to TCP, UDP, DCCP > when allocating ports. > > No longer need port_alloc_lock as well (suggestion by Brian Ha

net-2.6.24 --> net-2.6

2007-10-10 Thread David Miller
In preparation for a merge with Linus I've moved the net-2.6.24 over to net-2.6 and did one last rebase with linux-2.6.23 Please do not reference the net-2.6.24 tree any longer, for reference it sits in my directory as bak-net-2.6.24.git Just FYI. - To unsubscribe from this list: send the line "

Re: e100 problems in .23rc8 ?

2007-10-10 Thread Dave Jones
On Thu, Sep 27, 2007 at 02:58:27PM +0800, Herbert Xu wrote: > Kok, Auke <[EMAIL PROTECTED]> wrote: > > Dave Jones wrote: > >> Last night, I hit this bug during boot up.. > >> http://www.codemonkey.org.uk/junk/e100-2.jpg > >> > >> This morning, I got a mail from a Fedora user of the same > >

Re: [IPv6] Update setsockopt(IPV6_MULTICAST_IF) to support RFC 3493

2007-10-10 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 10 Oct 2007 16:42:56 -0700 (PDT)), David Miller <[EMAIL PROTECTED]> says: > From: David Stevens <[EMAIL PROTECTED]> > Date: Wed, 10 Oct 2007 14:48:38 -0700 > > > But anyway, I made the comment; I think some form of it > > should go in. :-) If you like the

[PATCH 1/2] SCTP: port randomization

2007-10-10 Thread Stephen Hemminger
Add port randomization rather than a simple fixed rover for use with SCTP. This makes it act similar to TCP, UDP, DCCP when allocating ports. No longer need port_alloc_lock as well (suggestion by Brian Haley). Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- include/net/sctp/structs.h

[PATCH 2/2] ip: local port range robustness

2007-10-10 Thread Stephen Hemminger
Expansion of original idea from Denis V. Lunev <[EMAIL PROTECTED]> Add robustness and locking to the local_port_range sysctl. 1. Enforce that low < high when setting. 2. Use seqlock to ensure atomic update. The locking might seem like overkill, but there are cases where sysadmin might want to cha

Re: [IPv6] Update setsockopt(IPV6_MULTICAST_IF) to support RFC 3493

2007-10-10 Thread David Miller
From: David Stevens <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 14:48:38 -0700 > But anyway, I made the comment; I think some form of it > should go in. :-) If you like the original better, that's > ok with me, too. Brian, please submit a new patch or resubmit the original one, the choice is your'

Re: [RFC] more robust inet range checking

2007-10-10 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 16:33:47 -0700 > I split them into two patches: 1 is the SCTP stuff, 2 is the range stuff. > Retesting tonight. Thank you. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROT

Re: [RFC] more robust inet range checking

2007-10-10 Thread Stephen Hemminger
On Wed, 10 Oct 2007 16:31:08 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Brian Haley <[EMAIL PROTECTED]> > Date: Wed, 10 Oct 2007 15:24:20 -0400 > > > Stephen Hemminger wrote: > > > --- a/net/ipv4/udp.c 2007-10-10 08:27:00.0 -0700 > > > +++ b/net/ipv4/udp.c 2007-

Re: [NET_SCHED]: Show timer resolution instead of clock resolution in /proc/net/psched

2007-10-10 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 16:34:24 +0200 > [NET_SCHED]: Show timer resolution instead of clock resolution in > /proc/net/psched > > The fourth parameter of /proc/net/psched is supposed to show the timer > resultion > and is used by HTB userspace to calcula

Re: [PATCH] Evict tmp variable from the stack in ip6_evictor

2007-10-10 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 17:06:07 +0200 > Pavel Emelyanov wrote: > > Patrick McHardy wrote: > >> Pavel Emelyanov wrote: > >>> The list_head *tmp is used to help getting the first entry in > >>> the ip6_frag_lru_list list. There is a simpler way to do it > >>

Re: [RFC] more robust inet range checking

2007-10-10 Thread David Miller
From: Brian Haley <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 15:24:20 -0400 > Stephen Hemminger wrote: > > --- a/net/ipv4/udp.c2007-10-10 08:27:00.0 -0700 > > +++ b/net/ipv4/udp.c2007-10-10 09:44:35.0 -0700 > > @@ -147,13 +147,13 @@ int __udp_lib_get_port(struct soc

Re: authenc compile warnings in current net-2.6.24

2007-10-10 Thread David Miller
From: Sebastian Siewior <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 21:53:37 +0200 > * Oliver Hartkopp | 2007-10-10 19:53:53 [+0200]: > > > CC [M] crypto/authenc.o > > crypto/authenc.c: In function ?crypto_authenc_hash?: > > crypto/authenc.c:88: warning: ?cryptlen? may be used uninitialized in thi

Re: [PATCH 2/3][BNX2]: Fix default WoL setting.

2007-10-10 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 17:01:59 -0700 > [BNX2]: Fix default WoL setting. > > Change the default WoL setting to match the NVRAM's setting. It > always defaulted to WoL disabled before and caused a lot of confusion > for users. > > Signed-off-by: Michael C

Re: [PATCH 3/3][BNX2]: Update version to 1.6.7.

2007-10-10 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 17:02:10 -0700 > [BNX2]: Update version to 1.6.7. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More ma

Re: [PATCH 1/3][BNX2]: Fix remote PHY media detection problems.

2007-10-10 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 17:01:32 -0700 > [BNX2]: Fix remote PHY media detection problems. > > The remote PHY media type and link status can change between > ->probe() and ->open(). For correct operation, we need to get the > new status again during ->open(

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-10-10 Thread David Miller
From: Sean Hefty <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 14:01:07 -0700 > > The hack to use a socket and bind it to claim the port was just for > > demostrating the idea. The correct solution, IMO, is to enhance the > > core low level 4-tuple allocation services to be more generic (eg: not

[PATCH 3/3][BNX2]: Update version to 1.6.7.

2007-10-10 Thread Michael Chan
[BNX2]: Update version to 1.6.7. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 574d043..bbfbdaf 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -56,8 +56,8 @@ #define DRV_MODULE_NAME"bnx2" #define PFX DRV

[PATCH 1/3][BNX2]: Fix remote PHY media detection problems.

2007-10-10 Thread Michael Chan
[BNX2]: Fix remote PHY media detection problems. The remote PHY media type and link status can change between ->probe() and ->open(). For correct operation, we need to get the new status again during ->open(). The ethtool link test and loopback test are also fixed to work with remote PHY. PHY l

[PATCH 2/3][BNX2]: Fix default WoL setting.

2007-10-10 Thread Michael Chan
[BNX2]: Fix default WoL setting. Change the default WoL setting to match the NVRAM's setting. It always defaulted to WoL disabled before and caused a lot of confusion for users. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 21493e0..5

Re: [PATCH] do not give access to 1-1024 ports for autobinding

2007-10-10 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 20:59:13 +0400 > They have sense for the case of multiple network namespaces, where root > in the other namespace can be treated as a user to initial namespace. This is a silly limitation to impose just for the sake of namespaces,

Re: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use batching

2007-10-10 Thread David Miller
From: Bill Fink <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 12:02:15 -0400 > On Tue, 09 Oct 2007, David Miller wrote: > > > We have to keep in mind, however, that the sw queue right now is 1000 > > packets. I heavily discourage any driver author to try and use any > > single TX queue of that size

Re: [PATCH] do not give access to 1-1024 ports for autobinding

2007-10-10 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 18:34:49 +0400 > This patch prevents possibility to give 1-1024 port range for autobinding. > {1, 1} may only takes some sense for deep embedded people. > > Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Administrators can conf

Re: [PATCH] do not give access to 1-1024 ports for autobinding

2007-10-10 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 08:41:37 -0700 > On Wed, 10 Oct 2007 18:34:49 +0400 > "Denis V. Lunev" <[EMAIL PROTECTED]> wrote: > > > This patch prevents possibility to give 1-1024 port range for autobinding. > > {1, 1} may only takes some sense for deep embed

Re: [PATCH 7/7] [IPSEC]: Move IP protocol setting from transforms into xfrm4_input.c

2007-10-10 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 22:40:16 +0800 > [IPSEC]: Move IP protocol setting from transforms into xfrm4_input.c > > This patch makes the IPv4 x->type->input functions return the next protocol > instead of setting it directly. This is identical to how we do thing

Re: [PATCH 6/7] [IPSEC]: Move IP length/checksum setting out of transforms

2007-10-10 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 22:40:15 +0800 > [IPSEC]: Move IP length/checksum setting out of transforms > > This patch moves the setting of the IP length and checksum fields out of > the transforms and into the xfrmX_output functions. This would help future > effo

Re: [PATCH 5/7] [IPSEC]: Get rid of ipv6_{auth,esp,comp}_hdr

2007-10-10 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 22:40:14 +0800 > [IPSEC]: Get rid of ipv6_{auth,esp,comp}_hdr > > This patch removes the duplicate ipv6_{auth,esp,comp}_hdr structures since > they're identical to the IPv4 versions. Duplicating them would only create > problems for our

Re: [PATCH 4/7] [IPSEC]: Use IPv6 calling convention as the convention for x->mode->output

2007-10-10 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 22:40:13 +0800 > [IPSEC]: Use IPv6 calling convention as the convention for x->mode->output > > The IPv6 calling convention for x->mode->output is more general and could > help an eventual protocol-generic x->type->output implementation.

Re: [PATCH 3/7] [IPSEC]: Set skb->data to payload in x->mode->output

2007-10-10 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 22:40:12 +0800 > [IPSEC]: Set skb->data to payload in x->mode->output > > This patch changes the calling convention so that on entry from > x->mode->output and before entry into x->type->output skb->data > will point to the payload inste

Re: [PATCH 2/7] [IPSEC] beet: Fix extension header support on output

2007-10-10 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 22:40:11 +0800 > [IPSEC] beet: Fix extension header support on output > > The beet output function completely kills any extension headers by replacing > them with the IPv6 header. This is because it essentially ignores the > result of i

Re: [PATCH 1/7] [IPSEC] esp: Remove NAT-T checksum invalidation for BEET

2007-10-10 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 22:40:10 +0800 > [IPSEC] esp: Remove NAT-T checksum invalidation for BEET > > I pointed this out back when this patch was first proposed but it looks like > it got lost along the way. > > The checksum only needs to be ignored for NAT-T

[PATCH 1/2] qe: add function qe_clock_source

2007-10-10 Thread Timur Tabi
Add function qe_clock_source() which takes a string containing the name of a QE clock source (as is typically found in device trees) and returns the matching enum qe_clock value. Update booting-without-of.txt to indicate that the UCC properties rx-clock and tx-clock are deprecated and replaced wit

[PATCH 2/2] ucc_geth: use rx-clock-name and tx-clock-name device tree properties

2007-10-10 Thread Timur Tabi
This patch updates the ucc_geth device driver to check the new rx-clock-name and tx-clock-name properties first. If present, it uses the new function qe_clock_source() to obtain the clock source. Otherwise, it checks the deprecated rx-clock and tx-clock properties. The device trees for 832x, 836

Re: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use batching

2007-10-10 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 09:08:48 -0400 > On Wed, 2007-10-10 at 03:44 -0700, David Miller wrote: > > > I've always gotten very poor results when increasing the TX queue a > > lot, for example with NIU the point of diminishing returns seems to > > be in the range of 2

[PATCH 0/2] QE clock source improvements

2007-10-10 Thread Timur Tabi
(Replaces all previous versions of this patch) This patch set adds a new property to make specifying QE clock sources easier, adds a function to help parse the property, updates some other functions to use an enum instead of an integer, and updates the ucc_geth driver to take advantage of all thi

Re: [PATCH 0/2] QE clock source improvements

2007-10-10 Thread Timur Tabi
Sorry, please ignore this set. Something got screwed up with the patches. I'm going to resend. Timur Tabi wrote: This patch set adds a new property to make specifying QE clock sources easier, adds a function to help parse the property, updates some other functions to use an enum instead of an

[PATCH 2/2] ucc_geth: use rx-clock-name and tx-clock-name device tree properties

2007-10-10 Thread Timur Tabi
This patch updates the ucc_geth device driver to check the new rx-clock-name and tx-clock-name properties first. If present, it uses the new function qe_clock_source() to obtain the clock source. Otherwise, it checks the deprecated rx-clock and tx-clock properties. The device trees for 832x, 836

[PATCH 0/2] QE clock source improvements

2007-10-10 Thread Timur Tabi
This patch set adds a new property to make specifying QE clock sources easier, adds a function to help parse the property, updates some other functions to use an enum instead of an integer, and updates the ucc_geth driver to take advantage of all this. - To unsubscribe from this list: send the li

[PATCH 1/2] qe: add function qe_clock_source

2007-10-10 Thread Timur Tabi
Add function qe_clock_source() which takes a string containing the name of a QE clock source (as is typically found in device trees) and returns the matching enum qe_clock value. Update booting-without-of.txt to indicate that the UCC properties rx-clock and tx-clock are deprecated and replaced wit

Re: [IPv6] Update setsockopt(IPV6_MULTICAST_IF) to support RFC 3493

2007-10-10 Thread David Stevens
Brian Haley <[EMAIL PROTECTED]> wrote on 10/10/2007 02:20:45 PM: > David Stevens wrote: > > What about just checking for 0 in the later test? > > > > if (val && __dev_get_by_index(val) == NULL) { > > We could fail the next check right before that though: Right, the semantics the

Re: [IPv6] Update setsockopt(IPV6_MULTICAST_IF) to support RFC 3493

2007-10-10 Thread Brian Haley
David Stevens wrote: What about just checking for 0 in the later test? if (val && __dev_get_by_index(val) == NULL) { We could fail the next check right before that though: if (sk->sk_bound_dev_if && sk->sk_bound_dev_if != val) goto e_inval; I just mimicked

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-10-10 Thread Sean Hefty
The hack to use a socket and bind it to claim the port was just for demostrating the idea. The correct solution, IMO, is to enhance the core low level 4-tuple allocation services to be more generic (eg: not be tied to a struct sock). Then the host tcp stack and the host rdma stack can allocat

Re: [IPv6] Update setsockopt(IPV6_MULTICAST_IF) to support RFC 3493

2007-10-10 Thread David Stevens
What about just checking for 0 in the later test? if (val && __dev_get_by_index(val) == NULL) { ... +-DLS - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at htt

Re: [PATCH][NETNS] Make ifindex generation per-namespace

2007-10-10 Thread Eric W. Biederman
Johannes Berg <[EMAIL PROTECTED]> writes: > On Tue, 2007-10-09 at 11:41 -0600, Eric W. Biederman wrote: > >> So please hold off on this until the kernel has been audited and >> we have removed all of the uses of ifindex that assume ifindex is >> global, that we can find. > > I certainly have this

Re: authenc compile warnings in current net-2.6.24

2007-10-10 Thread Sebastian Siewior
* Oliver Hartkopp | 2007-10-10 19:53:53 [+0200]: > CC [M] crypto/authenc.o > crypto/authenc.c: In function ?crypto_authenc_hash?: > crypto/authenc.c:88: warning: ?cryptlen? may be used uninitialized in this > function > crypto/authenc.c:87: warning: ?dst? may be used uninitialized in this > func

Re: [PATCH][BNX2X] round three

2007-10-10 Thread Eliezer Tamir
Eliezer Tamir wrote: The full patch is available at: [EMAIL PROTECTED]://ftp1.broadcom.com/0001-BNX2X-0.40.10a-net-2.6.24.patch Just when I thought I have beaten the line beast. (or maybe it's just too much work and not enough sleep.) the right links are of course: ftp://[EMAIL PROTECTED]/0001

Re: [Devel] [PATCH 1/5] net: Modify all rtnetlink methods to only work in the initial namespace

2007-10-10 Thread Eric W. Biederman
"Denis V. Lunev" <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >> Before I can enable rtnetlink to work in all network namespaces >> I need to be certain that something won't break. So this >> patch deliberately disables all of the rtnletlink methods in everything >> except the initial n

Re: [RFC] more robust inet range checking

2007-10-10 Thread Brian Haley
Stephen Hemminger wrote: int inet_csk_bind_conflict(const struct sock *sk, const struct inet_bind_bucket *tb) @@ -77,10 +90,11 @@ int inet_csk_get_port(struct inet_hashin local_bh_disable(); if (!snum) { - int low = sysctl_local_port_range[0]

Re: [PATCH][NETNS] Make ifindex generation per-namespace

2007-10-10 Thread Johannes Berg
On Tue, 2007-10-09 at 11:41 -0600, Eric W. Biederman wrote: > So please hold off on this until the kernel has been audited and > we have removed all of the uses of ifindex that assume ifindex is > global, that we can find. I certainly have this assumption in the wireless code (cfg80211). How woul

Re: [PATCH] IB/ipoib: Bound the net device to the ipoib_neigh structue

2007-10-10 Thread Roland Dreier
> I also ran a test for the code in the branch of 2.6.24 and found a problem. > I see that ifconfig down doesn't return (for IPoIB interfaces) and it's > stuck in napi_disable() in the kernel (any idea why?) For what it's worth, I took the upstream 2.6.23 git tree and merged in Dave's latest n

Re: [PATCH][NETNS] Make ifindex generation per-namespace

2007-10-10 Thread Eric W. Biederman
Pavel Emelyanov <[EMAIL PROTECTED]> writes: >> I know there are several data structures internal to the kernel that >> are indexed by ifindex, and not struct net_device *. There is the >> iflink field in struct net_device. We need a way to refer to network >> devices in other namespaces in rtnet

authenc compile warnings in current net-2.6.24

2007-10-10 Thread Oliver Hartkopp
Hi Herbert, CC [M] crypto/authenc.o crypto/authenc.c: In function ‘crypto_authenc_hash’: crypto/authenc.c:88: warning: ‘cryptlen’ may be used uninitialized in this function crypto/authenc.c:87: warning: ‘dst’ may be used uninitialized in this function crypto/authenc.c: In function ‘crypto_auth

Re: [RFC] more robust inet range checking

2007-10-10 Thread Vlad Yasevich
Stephen Hemminger wrote: > More complete version of local port range checking. > > 1. Enforce that low < high when setting. > 2. Use seqlock to ensure atomic update. > 3. Add port randomization to SCTP. This is a new feature but >easier than maintaining old code that was broken if range >c

Re: net-2.6.24 rebased...

2007-10-10 Thread Oliver Hartkopp
David Miller wrote: From: Urs Thuermann <[EMAIL PROTECTED]> Date: 09 Oct 2007 23:13:42 +0200 Last week I have sent another version of our patch series for PF_CAN. The changes after the last review feedback were only cosmetics. Do you have any plans with that code for this or the next releas

Re: [PATCH] do not give access to 1-1024 ports for autobinding

2007-10-10 Thread Stephen Hemminger
On Wed, 10 Oct 2007 20:59:13 +0400 "Denis V. Lunev" <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > On Wed, 10 Oct 2007 18:34:49 +0400 > > "Denis V. Lunev" <[EMAIL PROTECTED]> wrote: > > > >> This patch prevents possibility to give 1-1024 port range for autobinding. > >> {1, 1} may only

[RFC] more robust inet range checking

2007-10-10 Thread Stephen Hemminger
More complete version of local port range checking. 1. Enforce that low < high when setting. 2. Use seqlock to ensure atomic update. 3. Add port randomization to SCTP. This is a new feature but easier than maintaining old code that was broken if range changed. Signed-off-by: Stephen Hemming

Re: [PATCH] do not give access to 1-1024 ports for autobinding

2007-10-10 Thread Denis V. Lunev
Stephen Hemminger wrote: > On Wed, 10 Oct 2007 18:34:49 +0400 > "Denis V. Lunev" <[EMAIL PROTECTED]> wrote: > >> This patch prevents possibility to give 1-1024 port range for autobinding. >> {1, 1} may only takes some sense for deep embedded people. >> >> Signed-off-by: Denis V. Lunev <[EMAIL PROT

RE: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use batching

2007-10-10 Thread Waskiewicz Jr, Peter P
> -Original Message- > From: Andi Kleen [mailto:[EMAIL PROTECTED] > Sent: Wednesday, October 10, 2007 9:02 AM > To: Waskiewicz Jr, Peter P > Cc: David Miller; [EMAIL PROTECTED]; [EMAIL PROTECTED]; > [EMAIL PROTECTED]; [EMAIL PROTECTED]; > [EMAIL PROTECTED]; [EMAIL PROTECTED]; > [EMAIL P

[PATCH] natsemi: Check return value for pci_enable_device()

2007-10-10 Thread Mark Brown
pci_enable_device() is __must_check so do that in natsemi_resume(). Signed-off-by: Mark Brown <[EMAIL PROTECTED]> --- drivers/net/natsemi.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c index b881786..50e1ec6 100644

Re: [PATCH] IB/ipoib: Bound the net device to the ipoib_neigh structue

2007-10-10 Thread Moni Shoua
Jay Vosburgh wrote: > David Miller <[EMAIL PROTECTED]> wrote: > >> From: Jeff Garzik <[EMAIL PROTECTED]> >> Date: Tue, 09 Oct 2007 20:56:35 -0400 >> >>> Jeff Garzik wrote: applied patches 1-9 the only thing that was a hiccup during submission is that your email subject lines d

Re: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use batching

2007-10-10 Thread Bill Fink
On Tue, 09 Oct 2007, David Miller wrote: > From: jamal <[EMAIL PROTECTED]> > Date: Tue, 09 Oct 2007 17:56:46 -0400 > > > if the h/ware queues are full because of link pressure etc, you drop. We > > drop today when the s/ware queues are full. The driver txmit lock takes > > place of the qdisc queu

Re: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use batching

2007-10-10 Thread Andi Kleen
> We've done similar testing with ixgbe to push maximum descriptor counts, > and we lost performance very quickly in the same range you're quoting on > NIU. Did you try it with WC writes to the ring or CLFLUSH? -Andi - To unsubscribe from this list: send the line "unsubscribe netdev" in the body

Re: [PATCH] do not give access to 1-1024 ports for autobinding

2007-10-10 Thread Stephen Hemminger
On Wed, 10 Oct 2007 18:34:49 +0400 "Denis V. Lunev" <[EMAIL PROTECTED]> wrote: > This patch prevents possibility to give 1-1024 port range for autobinding. > {1, 1} may only takes some sense for deep embedded people. > > Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> > > --- ./net/ipv4/sysctl

RE: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use batching

2007-10-10 Thread Waskiewicz Jr, Peter P
> From: Andi Kleen <[EMAIL PROTECTED]> > Date: Wed, 10 Oct 2007 12:23:31 +0200 > > > On Wed, Oct 10, 2007 at 02:25:50AM -0700, David Miller wrote: > > > The chip I was working with at the time (UltraSPARC-IIi) > compressed > > > all the linear stores into 64-byte full cacheline > transactions v

  1   2   >