[PATCH - net-2.6.24 2/2] Introduce and use print_ipv6

2007-09-19 Thread Joe Perches
This removes the uses of NIP6_FMT and NIP6_SEQFMT in net IPV6 uses 2 different formats, colon separated and contiguous. The contiguous form is used in seq_print "%04x:%04x:%04x:%04x:%04x:%04x:%04x:%04x" "%04x%04x%04x%04x%04x%04x%04x%04x" IPV6 use: DECLARE_

[PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-19 Thread Joe Perches
In the same vein as print_mac, the implementations introduce declaration macros: DECLARE_IP_BUF(var) DECLARE_IPV6_BUF(var) and functions: print_ip print_ipv6 print_ipv6_nofmt IPV4 Use: DECLARE_IP_BUF(ipbuf); __be32 addr; print_ip(ipb

[PATCH - net-2.6.24 1/2] Introduce and use print_ip

2007-09-19 Thread Joe Perches
This removes the uses of NIPQUAD and HIPQUAD in drivers/net and net IPV4 Use: DECLARE_IP_BUF(ipbuf); __be32 addr; print_ip(ipbuf, addr) Signed-off-by: Joe Perches <[EMAIL PROTECTED]> please pull from: git pull http://repo.or.cz/r/linux-2.6/trivial-mods.git print_ipv4 s

Re: [PATCH] pci: Fix e100 interrupt quirk

2007-09-19 Thread Andrew Morton
On Tue, 18 Sep 2007 15:17:37 +0400 Valentine Barshak <[EMAIL PROTECTED]> wrote: > PCI memory space may have a 64-bit offset on some architectures > (for example, PowerPC 440) and the actual PCI memory address > has to fixed up (an offset to PCI mem space shuld be added) > before remapping. So, pci

Re: [PATCH] phy: export phy_mii_ioctl

2007-09-19 Thread Jeff Garzik
Domen Puncer wrote: Export phy_mii_ioctl, so network drivers can use it when built as modules too. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] ethtool: marvell register update

2007-09-19 Thread Jeff Garzik
Stephen Hemminger wrote: Update the decode of sky2 registers. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-19 Thread Eric Dumazet
Nagendra Tomar a écrit : --- Davide Libenzi <[EMAIL PROTECTED]> wrote: On Wed, 19 Sep 2007, David Miller wrote: From: Nagendra Tomar <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 15:37:09 -0700 (PDT) With the SOCK_NOSPACE check in tcp_check_space(), this epoll_wait call will not return, even w

Re: [Bug, PATCH and another Bug] Was: Fix refcounting problem with netif_rx_reschedule()

2007-09-19 Thread Krishna Kumar2
Ran 4/16/64 thread iperf on latest bits with this patch and no issues after 30 mins. I used to consistently get the bug within 1-2 mins with just 4 threads prior to this patch. Tested-by: Krishna Kumar <[EMAIL PROTECTED]> (if any value in that) thanks, - KK David Miller <[EMAIL PROTECTED]> wrot

Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-19 Thread Davide Libenzi
On Wed, 19 Sep 2007, Nagendra Tomar wrote: > Definitely not ! > > The point is that the "tcp write space available" > wakeup does not get called if SOCK_NOSPACE bit is not set. This was > fine when the wakeup was merely a wakeup (since SOCK_NOSPACE bit > indicated that someone really cared abt

Re: [Bug, PATCH and another Bug] Was: Fix refcounting problem with netif_rx_reschedule()

2007-09-19 Thread Krishna Kumar2
Hi Dave, David Miller <[EMAIL PROTECTED]> wrote on 09/19/2007 09:35:57 PM: > The NAPI_STATE_SCHED flag bit should provide all of the necessary > synchornization. > > Only the setter of that bit should add the NAPI instance to the > polling list. > > The polling loop runs atomically on the cpu whe

Re: [Bug, PATCH and another Bug] Was: Fix refcounting problem with netif_rx_reschedule()

2007-09-19 Thread David Miller
From: Krishna Kumar2 <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 10:40:33 +0530 > I like the clean changes made by Dave to fix this, and will test it > today (if I can get my crashed system to come up). I would very much appreciate this testing, as I'm rather sure we've plugged up the most serious

Re: [Bug, PATCH and another Bug] Was: Fix refcounting problem with netif_rx_reschedule()

2007-09-19 Thread Krishna Kumar2
Hi Jan-Bernd, Jan-Bernd Themann <[EMAIL PROTECTED]> wrote on 09/19/2007 06:53:48 PM: > If I understood it right the problem you describe (quota update in > __napi_schdule) can cause further problems when you choose the > following numbers: > > CPU1: A. process 99 pkts > CPU1: B. netif_rx_complete

[PATCH 1/6] sky2: fix VLAN receive processing

2007-09-19 Thread Stephen Hemminger
The length check for truncated frames was not correctly handling the case where VLAN acceleration had already read the tag. Also, the Yukon EX has some features that use high bit of status as security tag. Signed-off-by: Pierre-Yves Ritschard <[EMAIL PROTECTED]> Signed-off-by: Stephen Hemminger <[

[PATCH 3/6] sky2: reorganize chip revision features

2007-09-19 Thread Stephen Hemminger
This patch should cause no functional changes in driver behaviour. There are (too) many revisions of the Yukon 2 chip now. Instead of adding more conditionals based on chip revision; rerganize into a set of feature flags so adding new versions is less problematic. Signed-off-by: Stephen Hemminger

[PATCH 4/6] sky2: fe+ chip support

2007-09-19 Thread Stephen Hemminger
Modifications to support for Yukon FE plus chip. Earlier code was speculative, this is tested on hardware evaluation boards. This version of the patch is for 2.6.23. It supersedes the two previous patches that are sitting in netdev-2.6 (upstream branch). Signed-off-by: Stephen Hemminger <[EMAIL P

[PATCH 6/6] sky2: version 1.18

2007-09-19 Thread Stephen Hemminger
Update version number Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c2007-09-19 21:58:09.0 -0700 +++ b/drivers/net/sky2.c2007-09-19 21:58:09.0 -0700 @@ -52,7 +52,7 @@ #include "sky2.h" #define DRV_NAME "sky2" -#define

[PATCH 5/6] sky2: receive FIFO checking

2007-09-19 Thread Stephen Hemminger
A driver writer from another operating system hinted that the versions of Yukon 2 chip with rambuffer (EC and XL) have a hardware bug that if the FIFO ever gets completely full it will hang. Sounds like a classic ring full vs ring empty wrap around bug. As a workaround, use the existing watchdog t

[PATCH 0/6] sky2: merged for netdev-2.6 upstream

2007-09-19 Thread Stephen Hemminger
Basically, same patches as earlier, but these are for 2.6.24 (via netdev-2.6 upstream branch). -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

[PATCH 2/6] sky2: ethtool speed report bug

2007-09-19 Thread Stephen Hemminger
On 100mbit versions, the driver always reports gigabit speed available. The correct modes are already computed, then overwritten. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c2007-09-19 21:35:53.0 -0700 +++ b/drivers/net/sky2.c2007-09-19 21

Re: e1000 driver and samba

2007-09-19 Thread Bill Fink
On Wed, 19 Sep 2007, L F wrote: > Well, > the issue seems to have gone away as of this morning, but I am > somewhat unsure as to why. > Placement of some things were modified so as to allow shorter cables. > Now there are 3' CAT6 cables everywhere except for the 15' cable > between the two switche

Re: [PATCH 1/2] [FS_ENET] TX stuff should use fep->tx_lock, instead of fep->lock.

2007-09-19 Thread Jeff Garzik
Vitaly Bordug wrote: Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- drivers/net/fs_enet/fs_enet-main.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) applied 1-2, after hand-editing the subject line to remove brackets from around "[FS_ENET]" everything within [ and

Re: [patch 1/1] From: Ursula Braun <[EMAIL PROTECTED]>

2007-09-19 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: netif_rx will not free skb when I use ftp in kernel 2.6.22/2.6.21

2007-09-19 Thread Chris Snook
wrote: Dear netdev, I have one problem with my NIC driver: whenever I use netif_receive_skb(skb) or netif_rx(skb) to indicate received packet, iperf does work, but ftp does not work, because the kernel seemes not kfree_skb(skb) when I use ftp. What??s wrong with my NIC driver? Any

Re: [PATCH] NET_SB1250_MAC: Rename to SB1250_MAC

2007-09-19 Thread Jeff Garzik
Maciej W. Rozycki wrote: Rename NET_SB1250_MAC to SB1250_MAC to follow the convention. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- The NET prefix seems to be used mainly for device groups (NET_ISA, NET_VENDOR_*, etc.) rather than single drivers and adds no information. I sugges

Re: [PATCH] sb1250-mac.c: Fix "stats" references

2007-09-19 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] NET_SB1250_MAC: Update Kconfig entry

2007-09-19 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-19 Thread Jeff Garzik
Maciej W. Rozycki wrote: Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- On Thu, 13 Sep 2007, Jeff Garzik wrote: Net driver patches should apply on top of netdev-2.6.

Re: [PATCH 1/6] sky2: fix VLAN receive processing (resend)

2007-09-19 Thread Jeff Garzik
ACK patches 1-6 applied 1-2 and 6 patch #3 failed to apply to netdev-2.6.git#upstream (which is built on top of net-2.6.24) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordo

Re: e1000 driver and samba

2007-09-19 Thread Bill Fink
On Wed, 19 Sep 2007, L F wrote: > I have one further question: what should I be doing with the TSO and > flow control? As of now, TSO is on but flow control is off. > I'd like to thank everyone who helped and I'll be trying to see if the > realtek integrated NIC works next. Just my personal opini

Re: [RFC][NET_SCHED] explict hold dev tx lock

2007-09-19 Thread jamal
Ok, this is from the net-2.6.24 of about an hour ago. cheers, jamal [NET_SCHED] explict hold dev tx lock For N cpus, with full throttle traffic on all N CPUs, funneling traffic to the same ethernet device, the devices queue lock is contended by all N CPUs constantly. The TX lock is only conte

Re: [RFC][NET_SCHED] explict hold dev tx lock

2007-09-19 Thread jamal
On Wed, 2007-19-09 at 09:09 -0700, David Miller wrote: > Sure, along with a description as to why you want to make this > change. Will do. And if you feel that i should sit on it a little more i can do that too. The good news is it doesnt make things any worse than they already are and infact sho

[PATCH 1/2] David Miller's rbtree patches for 2.6.22.6

2007-09-19 Thread Tom Quetchenbach
Patch 1: David Miller's red-black tree code, tweaked for 2.6.22.6, with some bugfixes -Tom --- diff -ur linux-2.6.22.6/include/linux/skbuff.h linux-2.6.22.6-rbtree-davem-fixed/include/linux/skbuff.h --- linux-2.6.22.6/include/linux/skbuff.h 2007-08-30 23:21:01.0 -0700 +++ linux-2.

[PATCH 0/2] David Miller's rbtree patches for 2.6.22.6

2007-09-19 Thread Tom Quetchenbach
Hello, I've been experimenting with David Miller's red-black tree patch for SACK processing. We're sending TCP traffic between two machines with 10Gbps cards over a 1Gbps bottleneck link and were getting very high CPU load with large windows. With a few tweaks, this patch seems to provide a pretty

[PATCH 2/2] David Miller's rbtree patches for 2.6.22.6

2007-09-19 Thread Tom Quetchenbach
Patch 2: fixes to fack_counts and enhancement of SACK fast path -Tom --- diff -ur linux-2.6.22.6-rbtree-davem-fixed/include/net/tcp.h linux-2.6.22.6-rbtree-tomq/include/net/tcp.h --- linux-2.6.22.6-rbtree-davem-fixed/include/net/tcp.h 2007-09-19 17:36:07.0 -0700 +++ linux-2.6.22.6-rbtre

Re: net-2.6.24 - build failure

2007-09-19 Thread David Miller
From: Larry Finger <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 19:11:19 -0500 > The patch below was sent to John Linville yesterday. Obviously, it > didn't get included before he pushed to you. With this patch, all > the debugfs names become static, and avoid the namespace clash with > b43. In addi

Re: net-2.6.24 - build failure

2007-09-19 Thread Larry Finger
David Miller wrote: > From: Joe Perches <[EMAIL PROTECTED]> > Date: Wed, 19 Sep 2007 14:53:22 -0700 > >> drivers/net/wireless/b43legacy/built-in.o: In function `tsf_read_file': >> drivers/net/wireless/b43legacy/debugfs.c:80: multiple definition of >> `tsf_read_file' > > Can one of the wireless f

RE: [ofa-general] [PATCH] RDMA/CMA: Implement rdma_resolve_ip retry enhancement.

2007-09-19 Thread Glenn Grundstrom
> > If an application is calling rdma_resolve_ip() and a status > of -ENODATA is returned from addr_resolve_local/remote(), the > timeout mechanism waits until the application's timeout > occurs before rechecking the address resolution status; the > application will wait until it's full timeout

Re: [PATCH]: Preliminary release of Sun Neptune driver

2007-09-19 Thread David Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 16:20:39 -0700 > so why "niu?" To what does niu translate anyway? Network Interface Unit. This is what the Niagara-2 programmers manual refers to the chip as. I try to name the files for most drivers I write as a 2 or 3 letter acronym

Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-19 Thread Nagendra Tomar
--- Davide Libenzi <[EMAIL PROTECTED]> wrote: > On Wed, 19 Sep 2007, David Miller wrote: > > > From: Nagendra Tomar <[EMAIL PROTECTED]> > > Date: Wed, 19 Sep 2007 15:37:09 -0700 (PDT) > > > > > With the SOCK_NOSPACE check in tcp_check_space(), this epoll_wait call > > > will > > > not return,

Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-19 Thread Nagendra Tomar
--- David Miller <[EMAIL PROTECTED]> wrote: > From: Nagendra Tomar <[EMAIL PROTECTED]> > Date: Wed, 19 Sep 2007 15:55:58 -0700 (PDT) > > > I agree that setting SOCK_NOSPACE would have been a more elegant > > fix. Infact I thought a lot about that before deciding on this fix. > > I guess th

Re: [PATCH 3/6] sky2: reorganize chip revision features

2007-09-19 Thread Rick Jones
Stephen Hemminger wrote: This patch should cause no functional changes in driver behaviour. There are (too) many revisions of the Yukon 2 chip now. Instead of adding more conditionals based on chip revision; rerganize into a set of feature flags so adding new versions is less problematic. @@

Re: [PATCH]: Preliminary release of Sun Neptune driver

2007-09-19 Thread Rick Jones
+#define DRV_MODULE_NAME"niu" +#define PFX DRV_MODULE_NAME": " +#define DRV_MODULE_VERSION "0.06" +#define DRV_MODULE_RELDATE "September 18, 2007" + +static char version[] __devinitdata = + DRV_MODULE_NAME ".c:v" DRV_MODULE_VERSION " (" DRV_MODULE_RELDATE ")\n"; +

[PATCH 2/6] sky2: ethtool speed report bug

2007-09-19 Thread Stephen Hemminger
On 100mbit versions, the driver always reports gigabit speed available. The correct modes are already computed, then overwritten. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c2007-09-19 09:18:50.0 -0700 +++ b/drivers/net/sky2.c2007-09-19 09

Re: [PATCH]: Preliminary release of Sun Neptune driver

2007-09-19 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 16:05:20 -0700 > GCC is not as smart as you think... Try the following test: Indeed, thanks for pointing that out. I'll have to macroize it like this to get the check: static int __niu_wait_bits_clear_mac(void *np, unsigned long

[PATCH 1/6] sky2: fix VLAN receive processing (resend)

2007-09-19 Thread Stephen Hemminger
The length check for truncated frames was not correctly handling the case where VLAN acceleration had already read the tag. Also, the Yukon EX has some features that use high bit of status as security tag. Signed-off-by: Pierre-Yves Ritschard <[EMAIL PROTECTED]> Signed-off-by: Stephen Hemminger <[

[PATCH 4/6] sky2: fe+ chip support

2007-09-19 Thread Stephen Hemminger
Add support for newest Marvell chips. The Yukon FE plus chip is found in some not yet released laptops. Tested on hardware evaluation boards. This version of the patch is for 2.6.23. It supersedes the two previous patches that are sitting in netdev-2.6 (upstream branch). Signed-off-by: Stephen He

[PATCH 3/6] sky2: reorganize chip revision features

2007-09-19 Thread Stephen Hemminger
This patch should cause no functional changes in driver behaviour. There are (too) many revisions of the Yukon 2 chip now. Instead of adding more conditionals based on chip revision; rerganize into a set of feature flags so adding new versions is less problematic. Signed-off-by: Stephen Hemminger

[PATCH 6/6] sky2: version 1.18

2007-09-19 Thread Stephen Hemminger
Update version number Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c2007-09-19 10:05:28.0 -0700 +++ b/drivers/net/sky2.c2007-09-19 10:05:33.0 -0700 @@ -51,7 +51,7 @@ #include "sky2.h" #define DRV_NAME "sky2" -#define

[PATCH 0/6] sky2: version 1.18 (rev2)

2007-09-19 Thread Stephen Hemminger
Patches against 2.6.23 to fix bugs and support newest FE+ chip. These patches conflict with those in netdev-2.6 upstream branch, Jeff how do you want to resolve that? -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a me

[PATCH 5/6] sky2: receive FIFO checking

2007-09-19 Thread Stephen Hemminger
A driver writer from another operating system hinted that the versions of Yukon 2 chip with rambuffer (EC and XL) have a hardware bug that if the FIFO ever gets completely full it will hang. Sounds like a classic ring full vs ring empty wrap around bug. As a workaround, use the existing watchdog t

Re: [PATCH 3/3] [PPP] L2TP: Fix skb handling in pppol2tp_xmit

2007-09-19 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 01:11:14 +0200 > On Wed, Sep 19, 2007 at 10:45:13AM -0700, David Miller wrote: > > From: Herbert Xu <[EMAIL PROTECTED]> > > Date: Wed, 19 Sep 2007 09:30:18 +0800 > > > > > [PPP] pppoe: Fix double-free on skb after transmit failure > > >

Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-19 Thread Davide Libenzi
On Wed, 19 Sep 2007, David Miller wrote: > From: Nagendra Tomar <[EMAIL PROTECTED]> > Date: Wed, 19 Sep 2007 15:37:09 -0700 (PDT) > > > With the SOCK_NOSPACE check in tcp_check_space(), this epoll_wait call will > > not return, even when the incoming acks free the buffers. > > Note that

Re: [PATCH 3/3] [PPP] L2TP: Fix skb handling in pppol2tp_xmit

2007-09-19 Thread Adrian Bunk
On Wed, Sep 19, 2007 at 10:45:13AM -0700, David Miller wrote: > From: Herbert Xu <[EMAIL PROTECTED]> > Date: Wed, 19 Sep 2007 09:30:18 +0800 > > > [PPP] pppoe: Fix double-free on skb after transmit failure > > > > When I got rid of the second packet in __pppoe_xmit I created > > a double-free on

Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-19 Thread David Miller
From: Nagendra Tomar <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 15:55:58 -0700 (PDT) > I agree that setting SOCK_NOSPACE would have been a more elegant > fix. Infact I thought a lot about that before deciding on this fix. I guess this means you also noticed that you are removing the one and

Re: [PATCH]: Preliminary release of Sun Neptune driver

2007-09-19 Thread Stephen Hemminger
On Wed, 19 Sep 2007 15:07:55 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Wed, 19 Sep 2007 14:59:00 -0700 > ... > > > +static int niu_wait_bits_clear_mac(struct niu *np, unsigned long reg, > > > u64 bits, > > > +

Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-19 Thread Nagendra Tomar
--- David Miller <[EMAIL PROTECTED]> wrote: > From: Nagendra Tomar <[EMAIL PROTECTED]> > Date: Wed, 19 Sep 2007 15:37:09 -0700 (PDT) > > > With the SOCK_NOSPACE check in tcp_check_space(), this epoll_wait call will > > not return, even when the incoming acks free the buffers. > > Note t

Re: Please pull 'z1211' branch of wireless-2.6

2007-09-19 Thread Daniel Drake
John W. Linville wrote: The maintainers have identified some (IMHO minor) issues with the mac80211 port of this driver. Some of them are summarized here: http://linuxwireless.org/en/users/Drivers/zd1211rw/mac80211Issues Still, I think we would be better-off having this driver upstream.

Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-19 Thread David Miller
From: Nagendra Tomar <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 15:37:09 -0700 (PDT) > With the SOCK_NOSPACE check in tcp_check_space(), this epoll_wait call will > not return, even when the incoming acks free the buffers. > Note that this patch assumes that the SOCK_NOSPACE check in > tc

Re: [PATCH]: Preliminary release of Sun Neptune driver

2007-09-19 Thread Jeff Garzik
David Miller wrote: Macro's that make assumptions about context (ie variable name np) are evil and bad style. Too bad, it saves developers who write 20,000 line drivers from carpel tunnel symdrome. It's so repetitive to state things over and over again, and this macro scheme is 1) established

[PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-19 Thread Nagendra Tomar
The tcp_check_space() function calls tcp_new_space() only if the SOCK_NOSPACE bit is set in the socket flags. This is causing Edge Triggered EPOLLOUT events to be missed for TCP sockets, as the ep_poll_callback() is not called from the wakeup routine. The SOCK_NOSPACE bit indicates the us

Re: [PATCH]: Preliminary release of Sun Neptune driver

2007-09-19 Thread Jeff Garzik
David Miller wrote: From: Jeff Garzik <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 18:05:25 -0400 That said, the 2-arg macro arg order is wrong. It should be (reg,val) like tg3 and other drivers. I actually wanted to mirror the ordering that writel() uses. So the choice is arbitrary, either b

Re: Please pull 'z1211' branch of wireless-2.6

2007-09-19 Thread Daniel Drake
John W. Linville wrote: Jeff & Dave, This patch adds z1211 (previously known as zd1211rw-mac80211), a driver for Zydas ZD1211 hardware. This driver has proven very robust -- Fedora 7 uses this driver and I don't think I have any open bugzillas for it. BTW: I fairly regularly get email from

Re: Please pull 'z1211' branch of wireless-2.6

2007-09-19 Thread David Miller
From: Daniel Drake <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 23:27:09 +0100 > zd1211rw-mac80211 does not currently add anything to the user experience > over the existing driver, other than automatic rate adaption which is > nice but hasn't proven itself to be of much importance given that the

Re: Please pull 'z1211' branch of wireless-2.6

2007-09-19 Thread Daniel Drake
David Miller wrote: From: Daniel Drake <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 23:08:16 +0100 John, thanks a lot for your efforts, I hope you don't mind waiting one extra release cycle for me to sort a few things out. Having "a driver" is always better for users than having "no driver". Pl

Re: [PATCH] iproute2: enable setting rto_min, rtt and rttvar in tc-esque units

2007-09-19 Thread Rick Jones
Enable users of ip to specify the times for rtt, rttvar and rto_min in human-friendly terms a la "tc" while maintaining backwards compatability with the previous "raw" mechanism. Builds upon David Miller's uncommited patch to set rto_min. Signed-off-by: Rick Jones <[EMAIL PROTECTED]> Thanks,

Re: net-2.6.24 - build failure

2007-09-19 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 14:53:22 -0700 > drivers/net/wireless/b43legacy/built-in.o: In function `tsf_read_file': > drivers/net/wireless/b43legacy/debugfs.c:80: multiple definition of > `tsf_read_file' Can one of the wireless folks fix b43legacy to not use the

Re: net-2.6.24 plans

2007-09-19 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 17:07:00 -0400 > And the latest incarnation: > > > http://www.kernel.org/pub/linux/kernel/people/linville/git-wireless-2007-09-19-16-57-43-0500.patch > > And is even smaller...down an additional 30%, or almost 1/6th of th

Re: Please pull 'z1211' branch of wireless-2.6

2007-09-19 Thread David Miller
From: Daniel Drake <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 23:08:16 +0100 > John, thanks a lot for your efforts, I hope you don't mind waiting one > extra release cycle for me to sort a few things out. Having "a driver" is always better for users than having "no driver". Please I ask you not

Re: new NAPI quota synchronization issue

2007-09-19 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 15:01:29 -0700 > There might be a future problem if some driver decided to change > weight often on the fly? Perhaps you need to sample it once in > start of napi_schedule. Fair enough, I checked the following into net-2.6.24 co

Re: [PATCH]: Preliminary release of Sun Neptune driver

2007-09-19 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 18:05:25 -0400 > That said, the 2-arg macro arg order is wrong. It should be (reg,val) > like tg3 and other drivers. I actually wanted to mirror the ordering that writel() uses. So the choice is arbitrary, either be consistent with o

Re: Please pull 'p54' branch of wireless-2.6

2007-09-19 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 18:01:32 -0400 > There were complaints about the nonsensical wireless/mac80211 > directory. But if there are enough files, a driver should > definitely get its own directory. Like life, it's a balance. If > it's just one or two C file

Re: [PATCH]: Preliminary release of Sun Neptune driver

2007-09-19 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 14:59:00 -0700 > > +#ifndef PCI_DEVICE_ID_SUN_NEPTUNE > > +#define PCI_DEVICE_ID_SUN_NEPTUNE 0xabcd > > +#endif > > Why bother defining the ID, and what good does driver_data do you? Good point, I'll put this 0xabcd thing direct

Re: [PATCH]: Preliminary release of Sun Neptune driver

2007-09-19 Thread Jeff Garzik
Stephen Hemminger wrote: O +#define DRV_MODULE_NAME"niu" +#define PFX DRV_MODULE_NAME": " +#define DRV_MODULE_VERSION "0.06" +#define DRV_MODULE_RELDATE "September 18, 2007" + +static char version[] __devinitdata = + DRV_MODULE_NAME ".c:v" DRV_MODULE_VERSION " (

Re: Please pull 'p54' branch of wireless-2.6

2007-09-19 Thread Jeff Garzik
John W. Linville wrote: On Wed, Sep 19, 2007 at 02:12:00PM -0700, David Miller wrote: From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 22:04:05 +0100 PLease put it into a separate subdirectory, thanks. Also net2280.h seems rather oddly named. The next time I rebase I'll try

Re: [PATCH] iproute2: enable setting rto_min, rtt and rttvar in tc-esque units

2007-09-19 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 14:51:33 -0700 > On Tue, 18 Sep 2007 13:15:26 -0700 (PDT) > Rick Jones <[EMAIL PROTECTED]> wrote: > > > Enable users of ip to specify the times for rtt, rttvar and rto_min > > in human-friendly terms a la "tc" while maintaining ba

Re: new NAPI quota synchronization issue

2007-09-19 Thread Stephen Hemminger
On Wed, 19 Sep 2007 10:35:08 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: David Miller <[EMAIL PROTECTED]> > Date: Wed, 19 Sep 2007 09:58:25 -0700 (PDT) > > > Probably a good way to deal with this is to simply make the quota > > handling stateless. > > > > The only reason we handl

Re: [PATCH]: Preliminary release of Sun Neptune driver

2007-09-19 Thread Stephen Hemminger
O > +#define DRV_MODULE_NAME "niu" > +#define PFX DRV_MODULE_NAME ": " > +#define DRV_MODULE_VERSION "0.06" > +#define DRV_MODULE_RELDATE "September 18, 2007" > + > +static char version[] __devinitdata = > + DRV_MODULE_NAME ".c:v" DRV_MODULE_VERSION " (" DRV_MODULE_RELDATE ")\

net-2.6.24 - build failure

2007-09-19 Thread Joe Perches
allyesconfig CC drivers/net/wireless/p54pci.o LD drivers/net/wireless/built-in.o drivers/net/wireless/b43legacy/built-in.o: In function `tsf_read_file': drivers/net/wireless/b43legacy/debugfs.c:80: multiple definition of `tsf_read_file' drivers/net/wireless/b43/built-in.o:net-2.6.24

Re: [PATCH] iproute2: enable setting rto_min, rtt and rttvar in tc-esque units

2007-09-19 Thread Stephen Hemminger
On Tue, 18 Sep 2007 13:15:26 -0700 (PDT) Rick Jones <[EMAIL PROTECTED]> wrote: > Enable users of ip to specify the times for rtt, rttvar and rto_min > in human-friendly terms a la "tc" while maintaining backwards > compatability with the previous "raw" mechanism. Builds upon > David Miller's unc

Re: Please pull 'p54' branch of wireless-2.6

2007-09-19 Thread John W. Linville
On Wed, Sep 19, 2007 at 02:12:00PM -0700, David Miller wrote: > From: Christoph Hellwig <[EMAIL PROTECTED]> > Date: Wed, 19 Sep 2007 22:04:05 +0100 > > > PLease put it into a separate subdirectory, thanks. > > > > Also net2280.h seems rather oddly named. > > The next time I rebase I'll try to ta

Re: Please pull 'ssb-drivers' branch of wireless-2.6

2007-09-19 Thread John W. Linville
On Wed, Sep 19, 2007 at 02:25:29PM -0700, David Miller wrote: > From: "John W. Linville" <[EMAIL PROTECTED]> > Date: Wed, 19 Sep 2007 16:44:28 -0400 > > The second patch adds a driver for a USB OHCI device which lives on > > the SSB bus. Again, this is found on a number of SoC devices used > > es

Re: net-2.6.24 plans

2007-09-19 Thread John W. Linville
On Tue, Sep 18, 2007 at 09:27:52PM -0400, John W. Linville wrote: > On Mon, Sep 17, 2007 at 11:23:28PM -0400, John W. Linville wrote: > > On Mon, Sep 17, 2007 at 04:49:29PM -0700, Andrew Morton wrote: > > > On Mon, 17 Sep 2007 19:18:30 -0400 > > > "John W. Linville" <[EMAIL PROTECTED]> wrote: > > >

Re: Please pull 'ssb-drivers' branch of wireless-2.6

2007-09-19 Thread Greg KH
On Wed, Sep 19, 2007 at 04:44:28PM -0400, John W. Linville wrote: > Jeff, Greg, Gary, and Dave, > > These patches build upon the SSB bus support added to net-2.6.24 to > support the b43 wireless driver. Since Dave has that support in his > tree, I'm asking him to merge these patches as well. > >

Re: Please pull 'ssb-drivers' branch of wireless-2.6

2007-09-19 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 16:44:28 -0400 > Jeff, Greg, Gary, and Dave, > > These patches build upon the SSB bus support added to net-2.6.24 to > support the b43 wireless driver. Since Dave has that support in his > tree, I'm asking him to merge these pat

Re: [PATCH] phy: export phy_mii_ioctl

2007-09-19 Thread Jon Smirl
On 9/19/07, Jon Smirl <[EMAIL PROTECTED]> wrote: > This needs a cleanup too, but it is unrelated Another set of related warnings that need clean up CC drivers/spi/mpc52xx_psc_spi.o drivers/spi/mpc52xx_psc_spi.c: In function 'mpc52xx_psc_spi_activate_cs': drivers/spi/mpc52xx_psc_spi

Re: Please pull 'p54' branch of wireless-2.6

2007-09-19 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 22:04:05 +0100 > PLease put it into a separate subdirectory, thanks. > > Also net2280.h seems rather oddly named. The next time I rebase I'll try to take care of this for both this driver and the iwlwifi stuff. - To unsubscribe f

Please pull 'ssb-drivers' branch of wireless-2.6

2007-09-19 Thread John W. Linville
Jeff, Greg, Gary, and Dave, These patches build upon the SSB bus support added to net-2.6.24 to support the b43 wireless driver. Since Dave has that support in his tree, I'm asking him to merge these patches as well. The first patch changes b44 from being a PCI (i.e. SSB-in-drag) device to being

Re: Please pull 'p54' branch of wireless-2.6

2007-09-19 Thread Christoph Hellwig
On Wed, Sep 19, 2007 at 03:55:27PM -0400, John W. Linville wrote: > drivers/net/wireless/Kconfig | 13 + > drivers/net/wireless/Makefile|4 + > drivers/net/wireless/net2280.h | 452 + > drivers/net/wireless/p54.h | 80 +++ > drivers/net/wireless/p54common.c

Re: BUG: skge ethernet breakage (PCI: Unable to reserve mem region)

2007-09-19 Thread Jan Gukelberger
Hi, seems as if there are currently no more ideas? So shall I perhaps open a bug in Kernel Bugzilla? Thanks, Jan On Tue, 2007-09-11 at 15:39 +0200, Jan Gukelberger wrote: > On Tue, 2007-09-11 at 14:37 +0200, Stephen Hemminger wrote: > > On Tue, 11 Sep 2007 12:58:24 +0200 > > Jan Gukelberger <[E

Re: Please pull 'rt2x00' branch of wireless-2.6

2007-09-19 Thread Ivo van Doorn
On Wednesday 19 September 2007, John W. Linville wrote: > On Wed, Sep 19, 2007 at 08:31:19PM +0200, Ivo van Doorn wrote: > > > > Ivo and his team may feel I am jumping the gun a bit -- they have > > > a few more random bugs they wanted to squash before going upstream. > > > But since they are bugs

Re: bnx2 dirver's firmware images

2007-09-19 Thread Michael Chan
On Wed, 2007-09-19 at 21:29 +0100, Denys Vlasenko wrote: > Are you saying that you successfully run-tested it? I've only reviewed the code. Let's resolve these issues first before testing the code. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [

Re: follow-up: discrepancy with POSIX

2007-09-19 Thread Valdis . Kletnieks
On Wed, 19 Sep 2007 11:38:57 PDT, Rick Jones said: > One has to set their way-back machine pretty far back to find the *BSD > bits which used 0.0.0.0 as the "all nets, all subnets" (to mis-use a > term) broadcast IPv4 address when sending. Perhaps as far back as the > time before HP-UX 7 or Su

Re: bnx2 dirver's firmware images

2007-09-19 Thread Denys Vlasenko
On Wednesday 19 September 2007 22:00, Michael Chan wrote: > On Wed, 2007-09-19 at 09:30 +0100, Denys Vlasenko wrote: > + /* gzip header (1f,8b,08... 10 bytes total + possible asciz filename) > +* is stripped, 32-bit unpacked size (LE) is prepended instead */ > + sz = *zbuf++; >

Re: follow-up: discrepancy with POSIX

2007-09-19 Thread Ulrich Drepper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 David Miller wrote: > It just occured to me that AF_UNSPEC might be used simply > because "all zeros" might be a valid real bindable address > for some address family. And using AF_UNSPEC avoids that > problem entirely. Yes, but for IPv4/6 it's not a

Re: Please pull 'p54' branch of wireless-2.6

2007-09-19 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 15:55:27 -0400 > This patch adds the p54 driver for prism54 hardware using the "soft > MAC" firmware. It includes modules for both PCI and USB drivers. > > This driver has been in Fedora (both F7 and rawhide) for some time > and

Re: Please pull 'z1211' branch of wireless-2.6

2007-09-19 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 12:56:41 -0700 (PDT) > I agreed with John to merge this in myself, but this patch > applied to the old driver aparently, not the new z1211 one. > > Can you resend this patch against the new driver so I can > add it to net-2.6.24? Neve

Please pull 'p54' branch of wireless-2.6

2007-09-19 Thread John W. Linville
Jeff & Dave, This patch adds the p54 driver for prism54 hardware using the "soft MAC" firmware. It includes modules for both PCI and USB drivers. This driver has been in Fedora (both F7 and rawhide) for some time and has generally performed well. No doubt there are some problems with the code,

Re: bnx2 dirver's firmware images

2007-09-19 Thread Michael Chan
On Wed, 2007-09-19 at 09:30 +0100, Denys Vlasenko wrote: + /* gzip header (1f,8b,08... 10 bytes total + possible asciz filename) +* is stripped, 32-bit unpacked size (LE) is prepended instead */ + sz = *zbuf++; + sz = (sz << 8) + *zbuf++; + sz = (sz << 8) + *zbuf++;

Pull request for 'r8169-for-jeff-20070919' branch

2007-09-19 Thread Francois Romieu
Please pull from branch 'r8169-for-jeff-20070919' in repository git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git r8169-for-jeff-20070919 to get the fixes below. Distance from 'linux-2.6.git' (a88a8eff1e6e32d32889

Re: Please pull 'z1211' branch of wireless-2.6

2007-09-19 Thread David Miller
From: Michael Buesch <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 21:23:16 +0200 > John, please also note that the following patch is not merged, yet. > http://bu3sch.de/patches/wireless-dev/20070915-1740/patches/006-zd-fix-tx-status.patch > Without it ratecontrol does not work. It does neither scal

  1   2   3   >