Re: NetXen driver causing slab corruption in -RT kernels

2007-09-18 Thread Dhananjay Phadke
That "00 0e 1e ..." is netxen's mac address, so sounds like the NIC is dumping a frame in the skb already freed (and poisoned) by the stack. I suppose -RT kernels preempt the softirq, giving a chance for this race. The netxen driver doesn't seem to clear the mapped address of the skb in rx descrip

Re: [PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-18 Thread Oliver Hartkopp
Urs Thuermann wrote: > Now I think we should consider removing the loopback code from > can_send() and demand from each CAN driver that it *has to* implement > this itself. > I also thought about this solution, which would remove the 'loopback' parameter in vcan.c and some loopback code in can_

Re: InfiniBand/RDMA merge plans for 2.6.24

2007-09-18 Thread Michael S. Tsirkin
> Missing from this list (IMPORTANT patch!): > [ofa-general] [PATCH 2 of 2] IB/mlx4: Handle new FW requirement for send > request prefetching, for WQE sg lists > (Posted by me to list on Sept 4) > {patch header: > This is an addendum to Roland's commit > 0e6e74162164d908edf7889ac66dca09e7505745

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

2007-09-18 Thread Joe Perches
On Mon, 2007-09-17 at 19:14 -0700, Joe Perches wrote: > On Mon, 2007-09-17 at 19:05 -0700, David Miller wrote: > > Anyways, it would indeed help if you could rebase the patch > > against net-2.6.24 It would save me a ton of time. > > I'll rebase it tomorrow against whatever's in > your current ne

Re: [PATCH 1/2] IPoIB: Fix unregister_netdev hang

2007-09-18 Thread Krishna Kumar2
Hi Roland, > Please double check your tree. I just very carefully looked at my > trees, and the poll_more: label is added in commit 6b460a71 ("[NET]: > Make NAPI polling independent of struct net_device objects.") which is > only in the net-2.6.24 tree. Of course Dave did not change the > versio

[RESEND][PATCH 4/4 Rev-3] Initialize and fill IPv6 route age

2007-09-18 Thread Varun Chandramohan
The age field of the ipv6 route structures are initilized with the current timeval at the time of route creation. When the route dump is called the route age value stored in the structure is subtracted from the present timeval and the difference is passed on as the route age. Signed-off-by: Varu

[RESEND][PATCH 2/4 Rev-3] Add new timeval_to_sec function

2007-09-18 Thread Varun Chandramohan
A new function for converting timeval to time_t is added in netlink.h. Its a common function used in differentplaces. The reason for adding this function in netlink.h is that its used by netlink for stats purpose. Signed-off-by: Varun Chandramohan <[EMAIL PROTECTED]> --- include/net/netlink.h |

[RESEND][PATCH 3/4 Rev-3] Initilize and populate age field

2007-09-18 Thread Varun Chandramohan
The age field is filled with the current time at the time of creation of the route. When the routes are dumped then the age value stored in the route structure is subtracted from the current time value and the difference is the age expressed in secs. Signed-off-by: Varun Chandramohan <[EMAIL PRO

[RESEND][PATCH 1/4 Rev-3] New attribute RTA_AGE

2007-09-18 Thread Varun Chandramohan
A new attribute RTA_AGE is added for the age value to be exported to userlevel using netlink Signed-off-by: Varun Chandramohan <[EMAIL PROTECTED]> --- include/linux/rtnetlink.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/rtnetlink.h b/include/linux/rtne

[RESEND][PATCH 0/4 Rev-3] Age Entry For IPv4 & IPv6 Route Table

2007-09-18 Thread Varun Chandramohan
Hi Dave, Iam resending the patch set again. Let me know if you need anything else. Regards, Varun Original Comment: According to the RFC 4292 (IP Forwarding Table MIB) there is a need for an age entry for all the routes in therouting table. The entry in the RFC is inetCidrRouteAge and

Re: [PATCH 1/2] IPoIB: Fix unregister_netdev hang

2007-09-18 Thread Roland Dreier
> > and I think that is only in Dave's net-2.6.24 tree now, right? > > Nope, that was what I downloaded yesterday: > > VERSION = 2 > PATCHLEVEL = 6 > SUBLEVEL = 23 > EXTRAVERSION =-rc6 > NAME = Pink Farting Weasel Please double check your tree. I just very carefully looked at my trees,

Re: [PATCH 1/2] IPoIB: Fix unregister_netdev hang

2007-09-18 Thread Krishna Kumar2
Hi Roland, Roland Dreier <[EMAIL PROTECTED]> wrote on 09/18/2007 07:57:24 PM: > > While using IPoIB over EHCA (rc6 bits), unregister_netdev hangs with > > I don't think you're actually using rc6 bits, since in your patch you have: > > > -poll_more: > > and I think that is only in Dave's net-2.6

Re: net-2.6.24 plans

2007-09-18 Thread John W. Linville
On Mon, Sep 17, 2007 at 11:23:28PM -0400, John W. Linville wrote: > On Mon, Sep 17, 2007 at 04:49:29PM -0700, Andrew Morton wrote: > > On Mon, 17 Sep 2007 19:18:30 -0400 > > "John W. Linville" <[EMAIL PROTECTED]> wrote: > > > > > P.S. Andrew, I'll send you a link to a new git-wireless.patch -- >

Re: [PATCH net-2.6.24] [L2TP] Fix lockup introduced by recent changes

2007-09-18 Thread Herbert Xu
On Tue, Sep 18, 2007 at 02:51:06PM -0700, David Miller wrote: > > Herbert, please take a quick look, thanks. Yep it looks good. I should've read my emails from the bottom up :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: htt

Re: [PATCH 3/3] [PPP] L2TP: Fix skb handling in pppol2tp_xmit

2007-09-18 Thread Herbert Xu
On Tue, Sep 18, 2007 at 01:32:40PM -0700, David Miller wrote: > > I'll make sure not to push this until we figure out what's > wrong, thanks for checking James. I think it was because of a double-free that I created after transmitting the packet. In fact I had the same bug in PPPOE too. [PPP] p

Re: [PATCH 3/3] [PPP] L2TP: Fix skb handling in pppol2tp_xmit

2007-09-18 Thread Herbert Xu
On Tue, Sep 18, 2007 at 09:19:33PM +0100, James Chapman wrote: > > This one causes my test system to lock up. I'll investigate. Please > don't apply this patch for now. Sorry, I added a double-free on the skb after ip_queue_xmit. Please try this one instead. [PPP] L2TP: Fix skb handling in pppo

Re: [PATCH net-2.6.24] Fix refcounting problem with netif_rx_reschedule()

2007-09-18 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 15:46:36 -0700 > OK, I actually have a system with a ppc 440 SoC that uses this driver, > so I'll try to get things to the stage where I can boot net-2.6.24 on > it and see if I can get the driver working... Thanks a lot Roland. - To

Re: [PATCH net-2.6.24] Fix refcounting problem with netif_rx_reschedule()

2007-09-18 Thread Roland Dreier
> Further complicating things is that you need to setup a ppc32 > cross-build environment to even build test a conversion, and I'm not > comfortable doing the surgery until I can test build the thing. OK, I actually have a system with a ppc 440 SoC that uses this driver, so I'll try to get thin

Re: Please pull 'rt2x00' branch of wireless-2.6

2007-09-18 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 17:32:02 -0400 > This patch adds the rt2x00 drivers for Ralink wireless hardware. > This collection of drivers has seen lots of action in Fedora (both > F7 and rawhide) and many people are using them with good results > (although

Re: [PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-18 Thread Urs Thuermann
Patrick McHardy <[EMAIL PROTECTED]> writes: > > +static int loopback; /* loopback testing. Default: 0 (Off) */ > > +module_param(loopback, int, S_IRUGO); > > +MODULE_PARM_DESC(loopback, "Loop back frames (for testing). Default: 0 > > (Off)"); > > > I would still prefer to have this on a per-dev

Re: bnx2 dirver's firmware images

2007-09-18 Thread Michael Chan
On Tue, 2007-09-18 at 23:37 +0200, Willy Tarreau wrote: > > > Michael, doesn't a functional-yet-suboptimal firmware exist ? I mean, > > > just the same principle as we all have kernels, boot CDs, statically > > > built tools, etc... which run everywhere. If you have such a beast, > > > maybe it wo

Please pull 'rt2x00' branch of wireless-2.6

2007-09-18 Thread John W. Linville
Jeff & Dave, This patch adds the rt2x00 drivers for Ralink wireless hardware. This collection of drivers has seen lots of action in Fedora (both F7 and rawhide) and many people are using them with good results (although some problems do remain). Ivo in particular has been very helpful in respondi

Re: bnx2 dirver's firmware images

2007-09-18 Thread David Miller
From: Willy Tarreau <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 23:30:25 +0200 > On Tue, Sep 18, 2007 at 12:21:50PM -0700, David Miller wrote: > > From: "Michael Chan" <[EMAIL PROTECTED]> > > Date: Tue, 18 Sep 2007 13:05:51 -0700 > > > > > The bnx2 firmware changes quite frequently. A new driver

Re: [PATCH 1/3] Blackfin EMAC driver: add function to change the MAC address

2007-09-18 Thread Jeff Garzik
Bryan Wu wrote: From 157dfddae50708a716c2a42a314eccb9621d8793 Mon Sep 17 00:00:00 2001 From: Alex Landau <[EMAIL PROTECTED]> Date: Sun, 5 Aug 2007 15:58:03 +0800 Subject: [PATCH] Blackfin Ethernet MAC driver: add function to change the MAC address Alex Landau writes in the forums: Previously

Re: Pull request for 'r8169-for-jeff-20070914' branch

2007-09-18 Thread Jeff Garzik
Francois Romieu wrote: Please pull from branch 'r8169-for-jeff-20070914' in repository git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git r8169-for-jeff-20070914 to get the fixes below. Distance from 'netdev-2.6/upstream' (18d256761aa268fd2fb113c4fd26c400431f1dc1)

Re: Pull request for 'r8169-for-jeff-20070914' branch

2007-09-18 Thread Jeff Garzik
Francois Romieu wrote: Please pull from branch 'r8169-for-jeff-20070914' in repository git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git r8169-for-jeff-20070914 to get the fixes below. Distance from 'netdev-2.6/upstream' (18d256761aa268fd2fb113c4fd26c400431f1dc1)

Re: [PATCH net-2.6.24] [L2TP] Fix lockup introduced by recent changes

2007-09-18 Thread David Miller
From: James Chapman <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 22:44:33 +0100 > [L2TP] Fix double skb free problem introduced by recent changes > > This patch is to be applied on top of Herbert's recent patch set: > "[PPP 3/3] L2TP: Fix skb handling in pppol2tp_xmit" > > It fixes a double kfree

Re: [FIX NETLINK] properly check arguments to netlink_bind()

2007-09-18 Thread David Miller
From: Holger Eitzenberger <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 23:05:52 +0200 > Holger Eitzenberger <[EMAIL PROTECTED]> writes: > > > while going through going netlink code I found out that netlink_bind() > > does not properly check bind parameters. I checked both 2.6.23-rc1 as > > well as

Re: [PATCH 3/7] CAN: Add raw protocol

2007-09-18 Thread Urs Thuermann
Patrick McHardy <[EMAIL PROTECTED]> writes: > > +config CAN_RAW_USER > > + bool "Allow non-root users to access Raw CAN Protocol sockets" > > + depends on CAN_RAW > > + default N > > + ---help--- > > + The Controller Area Network is a local field bus transmitting only > > + broadca

[PATCH net-2.6.24] [L2TP] Fix lockup introduced by recent changes

2007-09-18 Thread James Chapman
[L2TP] Fix double skb free problem introduced by recent changes This patch is to be applied on top of Herbert's recent patch set: "[PPP 3/3] L2TP: Fix skb handling in pppol2tp_xmit" It fixes a double kfree_skb() issue introduced by that patch. Also return 0 on error, allowing PPP to requeue the

Re: bnx2 dirver's firmware images

2007-09-18 Thread Willy Tarreau
On Tue, Sep 18, 2007 at 02:31:34PM -0700, David Miller wrote: > From: Willy Tarreau <[EMAIL PROTECTED]> > Date: Tue, 18 Sep 2007 23:30:25 +0200 > > > On Tue, Sep 18, 2007 at 12:21:50PM -0700, David Miller wrote: > > > From: "Michael Chan" <[EMAIL PROTECTED]> > > > Date: Tue, 18 Sep 2007 13:05:51 -

Re: Please pull 'b43' branch of wireless-2.6

2007-09-18 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 16:28:19 -0400 > This series adds the b43 and b43legacy drivers, as well as the ssb > bus infrastructure upon which they depend. > > These drivers support the BCM43xx wireless hardware from Broadcom. > The b43 driver supports mod

Re: bnx2 dirver's firmware images

2007-09-18 Thread Willy Tarreau
On Tue, Sep 18, 2007 at 12:21:50PM -0700, David Miller wrote: > From: "Michael Chan" <[EMAIL PROTECTED]> > Date: Tue, 18 Sep 2007 13:05:51 -0700 > > > The bnx2 firmware changes quite frequently. A new driver quite often > > requires new firmware to work correctly. Splitting them up makes things

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-18 Thread Urs Thuermann
Patrick McHardy <[EMAIL PROTECTED]> writes: > > +++ net-2.6.24/include/linux/can.h 2007-09-17 10:27:09.0 +0200 > Is this file used only from within the kernel? If so you could use > the nicer-to-look-at u8/u16/u32 types instead of the double underscored > ones. No, this file contains th

Re: [FIX NETLINK] properly check arguments to netlink_bind()

2007-09-18 Thread Holger Eitzenberger
The previous patchlet wasn't correct, please apply this one. Sorry for the noise. /holger [NETLINK] Check for correct bind parameters Before this change it was possible to pass less than sockaddr_nl bytes, which might lead to arbitrary data being accessed in netlink_bind(). Take two. Signed

Re: [FIX NETLINK] properly check arguments to netlink_bind()

2007-09-18 Thread Holger Eitzenberger
Holger Eitzenberger <[EMAIL PROTECTED]> writes: > while going through going netlink code I found out that netlink_bind() > does not properly check bind parameters. I checked both 2.6.23-rc1 as > well as 2.6.16.53, both are affected. > > With a small test prog I wasn't able to crash my maschine th

[FIX NETLINK] properly check arguments to netlink_bind()

2007-09-18 Thread Holger Eitzenberger
Hi, while going through going netlink code I found out that netlink_bind() does not properly check bind parameters. I checked both 2.6.23-rc1 as well as 2.6.16.53, both are affected. With a small test prog I wasn't able to crash my maschine though, but data was accessed out of bounds. Please ap

Re: bnx2 dirver's firmware images

2007-09-18 Thread H. Peter Anvin
Sam Ravnborg wrote: > > Except there seems to be great resistance to include userland code in the > kernel as demonstrated at last KS. Or this is maybe just a single vocal > person and the topic were brought up late? > > Anyway - if we again consider klibc I will do my best to make the > build st

Please pull 'b43' branch of wireless-2.6

2007-09-18 Thread John W. Linville
Jeff & Dave, This series adds the b43 and b43legacy drivers, as well as the ssb bus infrastructure upon which they depend. These drivers support the BCM43xx wireless hardware from Broadcom. The b43 driver supports modern hardware using the "version 4" firmware, while the b43legacy driver uses the

Re: bnx2 dirver's firmware images

2007-09-18 Thread Sam Ravnborg
On Tue, Sep 18, 2007 at 01:08:10PM -0700, David Miller wrote: > From: "H. Peter Anvin" <[EMAIL PROTECTED]> > Date: Tue, 18 Sep 2007 12:27:04 -0700 > > > Well, what I was referring to here, of course, was the initramfs > > integrated in the kernel image, so it all comes out of the kernel build > >

Re: [PATCH 3/3] [PPP] L2TP: Fix skb handling in pppol2tp_xmit

2007-09-18 Thread David Miller
From: James Chapman <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 21:19:33 +0100 > This one causes my test system to lock up. I'll investigate. Please > don't apply this patch for now. I'll make sure not to push this until we figure out what's wrong, thanks for checking James. - To unsubscribe from

Re: [PATCH] return useful listenq info in tcp_info and INET_DIAG_INFO

2007-09-18 Thread David Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 12:54:31 -0700 (PDT) > Return some useful information such as the maximum listen backlog and the > current listen backlog in the tcp_info structure and INET_DIAG_INFO. > > Signed-off-by: Rick Jones <[EMAIL PROTECTED]> > Signed-off-by: Er

Re: [PATCH][NETNS] Cleanup list walking in setup_net and cleanup_net

2007-09-18 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 12:06:53 +0400 > I proposed introducing a list_for_each_entry_continue_reverse macro > to be used in setup_net() when unrolling the failed ->init callback. > > Here is the macro and some more cleanup in the setup_net() itself > to r

Re: [PATCH 3/3] [PPP] L2TP: Fix skb handling in pppol2tp_xmit

2007-09-18 Thread James Chapman
Herbert Xu wrote: [PPP] L2TP: Fix skb handling in pppol2tp_xmit This patch makes pppol2tp_xmit call skb_cow_head so that we don't modify cloned skb data. It also gets rid of skb2 we only need to preserve the original skb for congestion notification, which is only applicable for ppp_async and pp

Re: [0/3] [PPP]: Fix pppol2tp skb bugs

2007-09-18 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 20:04:38 +0800 > On Fri, Aug 31, 2007 at 05:06:25PM +0800, Herbert Xu wrote: > > > > I've audited ppp_generic.c and pppoe.c. I'll do pppol2tp > > tomorrow. > > Tomrrow took a while to come :) It took me two weeks to apply the original

Re: [PATCH 2/3] [PPP] L2TP: Fix skb handling in pppol2tp_recv_core

2007-09-18 Thread James Chapman
Herbert Xu wrote: [PPP] L2TP: Fix skb handling in pppol2tp_recv_core The function pppol2tp_recv_core doesn't handle non-linear packets properly. It also fails to check the remote offset field. This patch fixes these problems. It also removes an unnecessary check on the UDP header which has alr

Re: [PATCH net-2.6.24] Fix documentation for dev_put()/dev_hold()

2007-09-18 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 11:04:22 -0700 > It looks like the comments for dev_put() and dev_hold() got reversed somehow. > > Signed-off-by: Roland Dreier <[EMAIL PROTECTED]> Applied, thanks Roland. - To unsubscribe from this list: send the line "unsubscribe n

Re: [PATCH 1/3] [PPP] L2TP: Disallow non-UDP datagram sockets

2007-09-18 Thread James Chapman
Herbert Xu wrote: [PPP] L2TP: Disallow non-UDP datagram sockets With the addition of UDP-Lite we need to refine the socket check so that only genuine UDP sockets are allowed through. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Acked-by: James Chapman <[EMAIL PROTECTED]> - To unsubscribe fr

Re: [PATCH net-2.6.24] Fix refcounting problem with netif_rx_reschedule()

2007-09-18 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 10:58:37 -0700 > netif_rx_complete() takes a netdev parameter and does dev_put() on > that netdev, so netif_rx_reschedule() needs to also take a netdev > parameter and do dev_hold() on it to avoid reference counts from > getting becomi

[PATCH] iproute2: enable setting rto_min, rtt and rttvar in tc-esque units

2007-09-18 Thread Rick Jones
Enable users of ip to specify the times for rtt, rttvar and rto_min in human-friendly terms a la "tc" while maintaining backwards compatability with the previous "raw" mechanism. Builds upon David Miller's uncommited patch to set rto_min. Signed-off-by: Rick Jones <[EMAIL PROTECTED]> --- inclu

Re: SFQ qdisc crashes with limit of 2 packets

2007-09-18 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 21:15:28 +0200 > OK the off-by-one prevents an out-of-bounds array access, which > would cause a crash itself. Despite what I said above, sfq does > try to handle dequeues while empty, but forgets to update q->tail > when dropping th

Re: bnx2 dirver's firmware images

2007-09-18 Thread David Miller
From: "H. Peter Anvin" <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 12:27:04 -0700 > Well, what I was referring to here, of course, was the initramfs > integrated in the kernel image, so it all comes out of the kernel build > tree and produces a single bootable image. The fact that part of it > con

[PATCH] return useful listenq info in tcp_info and INET_DIAG_INFO

2007-09-18 Thread Rick Jones
Return some useful information such as the maximum listen backlog and the current listen backlog in the tcp_info structure and INET_DIAG_INFO. Signed-off-by: Rick Jones <[EMAIL PROTECTED]> Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> --- diff -r bdcdd0e1ee9d net/ipv4/tcp.c --- a/net/ipv4/tcp.c

Re: [PATCH] phy: export phy_mii_ioctl

2007-09-18 Thread Jon Smirl
On 9/18/07, Domen Puncer <[EMAIL PROTECTED]> wrote: > More testing and getting it to work properly on Phytec pcm030 would > be great. Do we want to do anything about this? [1.569657] net eth0: attached phy 0 to driver Generic PHY [2.576013] Sending DHCP requests .<6>PHY: f0003000:00 - Lin

Re: bnx2 dirver's firmware images

2007-09-18 Thread H. Peter Anvin
David Miller wrote: > From: "H. Peter Anvin" <[EMAIL PROTECTED]> > Date: Tue, 18 Sep 2007 11:41:34 -0700 > >> David Miller wrote: >>> I don't like it because it means people have to setup full initrd's >>> in order to do network booting with such network cards. >>> >> klibc could help with that, i

Re: Please pull 'iwlwifi' branch of wireless-2.6

2007-09-18 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 14:50:40 -0400 > Jeff & Dave, > > Here it is -- it's big, it's...well...beautiful in its own way...well, > at least it seems to work... :-) > > There are some outstanding issues. The driver does more than it > probably should u

Re: SFQ qdisc crashes with limit of 2 packets

2007-09-18 Thread Patrick McHardy
Patrick McHardy wrote: > Never mind, I found the reason. When enqueuing the packet, sfq_enqueue > contains an off-by-one in the limit check (which IIRC is there for a > reason, but I can't remember right now) and drops the packet again. > dev_queue_xmit() calls qdisc_run() anyway and the empty qdis

Re: bnx2 dirver's firmware images

2007-09-18 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 13:05:51 -0700 > The bnx2 firmware changes quite frequently. A new driver quite often > requires new firmware to work correctly. Splitting them up makes things > difficult for the user. > > The firmware in tg3 is a lot more mature

Re: bnx2 dirver's firmware images

2007-09-18 Thread David Miller
From: "H. Peter Anvin" <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 11:41:34 -0700 > David Miller wrote: > > > > I don't like it because it means people have to setup full initrd's > > in order to do network booting with such network cards. > > > > klibc could help with that, if there is interest

Re: [PATCH] phy: export phy_mii_ioctl

2007-09-18 Thread Jon Smirl
On 9/18/07, Domen Puncer <[EMAIL PROTECTED]> wrote: > More testing and getting it to work properly on Phytec pcm030 would > be great. I compiled it as a module: CC [M] drivers/net/fec_mpc52xx/fec.o drivers/net/fec_mpc52xx/fec.c:613: warning: 'mpc52xx_fec_mac_setup' defined but not used This co

Please pull 'iwlwifi' branch of wireless-2.6

2007-09-18 Thread John W. Linville
Jeff & Dave, Here it is -- it's big, it's...well...beautiful in its own way...well, at least it seems to work... :-) There are some outstanding issues. The driver does more than it probably should under the covers instead of in the stack, and the issue of including headers with a "../../mac80211

Re: new NAPI interface broken

2007-09-18 Thread David Miller
From: Jan-Bernd Themann <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 18:15:45 +0200 > One other thing I observed is that I can not unload the module as the > ref counter of the eth device is too low. I haven't tracked down the > source of this problem yet. This is probably because of the resched d

Re: bnx2 dirver's firmware images

2007-09-18 Thread Michael Chan
On Tue, 2007-09-18 at 11:23 -0700, David Miller wrote: > I don't like it because it means people have to setup full initrd's > in order to do network booting with such network cards. > > But the days of my opinion mattering on that issue are long gone, > the momentum is just too greatly behind us

Re: bnx2 dirver's firmware images

2007-09-18 Thread H. Peter Anvin
David Miller wrote: > > I don't like it because it means people have to setup full initrd's > in order to do network booting with such network cards. > klibc could help with that, if there is interest in exploring that avenue again. -hpa - To unsubscribe from this list: send the line "u

Re: wrt Age Entry For IPv4 & IPv6 Route Table

2007-09-18 Thread David Miller
From: Varun Chandramohan <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 13:30:40 +0530 > Sorry for bothering you. I see that you are currently > very busy. I just wanted to remind you that iam waiting for your > feedback on the patch set. Just incase you want me to resend , please >

Re: bnx2 dirver's firmware images

2007-09-18 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 11:45:14 -0700 > On Tue, 2007-09-18 at 18:23 +0100, Denys Vlasenko wrote: > > Do you have any plans to switch to request_firmware() interface, > > which will allow you to avoid keeping firmware in unswappable kernel > > memory and thu

NetXen driver causing slab corruption in -RT kernels

2007-09-18 Thread Vernon Mauery
In doing some stress testing of the NetXen driver, I found that my machine was dying in all sorts of weird ways. I saw several different crashes, BUG messages in the TCP stack and some assert messages in the TCP stack as well. I really didn't think that there could be six different bugs all at

Re: bnx2 dirver's firmware images

2007-09-18 Thread Michael Chan
On Tue, 2007-09-18 at 18:55 +0100, Denys Vlasenko wrote: > On Tuesday 18 September 2007 19:45, Michael Chan wrote: > > We can compress all the different sections of the firmware. Currently, > > we only compress the biggest chunks and the rest are uncompressed. > > > These zeros should compress to

[PATCH net-2.6.24] Fix documentation for dev_put()/dev_hold()

2007-09-18 Thread Roland Dreier
It looks like the comments for dev_put() and dev_hold() got reversed somehow. Signed-off-by: Roland Dreier <[EMAIL PROTECTED]> --- include/linux/netdevice.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index be5f

Re: SFQ qdisc crashes with limit of 2 packets

2007-09-18 Thread Patrick McHardy
Patrick McHardy wrote: > Chuck Ebbert wrote: > >>Limit of 1 is forbidden, crashes with 2, works with 3: >> >>>From disassembling sch_sfq.ko it seems that it is on line 360 of sch_sfq.c: >>sch->qstats.backlog -= skb->len; >>where "skb" is an invalid pointer: > > > > Is it a NULL pointer or s

[PATCH net-2.6.24] Fix refcounting problem with netif_rx_reschedule()

2007-09-18 Thread Roland Dreier
netif_rx_complete() takes a netdev parameter and does dev_put() on that netdev, so netif_rx_reschedule() needs to also take a netdev parameter and do dev_hold() on it to avoid reference counts from getting becoming negative because of unbalanced dev_put()s. This should fix the problem reported by

Re: bnx2 dirver's firmware images

2007-09-18 Thread Denys Vlasenko
On Tuesday 18 September 2007 19:45, Michael Chan wrote: > We can compress all the different sections of the firmware. Currently, > we only compress the biggest chunks and the rest are uncompressed. > These zeros should compress to almost nothing. But I agree that the > firmware is still big. Yo

Re: bnx2 dirver's firmware images

2007-09-18 Thread Michael Chan
On Tue, 2007-09-18 at 18:23 +0100, Denys Vlasenko wrote: > Hi Michael, > > In bnx2_fw.h I see the following: > > static u32 bnx2_RXP_b06FwBss[(0x13dc/4) + 1] = { 0x0 }; > > static struct fw_info bnx2_rxp_fw_06 = { > ... > .bss= bnx2_RXP_b06FwBss, > ... > }; >

Re: [ofa-general] Re: [PATCH 02/11] IB/ipoib: Notify the world before doing unregister

2007-09-18 Thread Roland Dreier
> Maybe this new notification function should be in net/core/dev.c > instead of exporting call_netdevice_notifiers()? Or actually, does it work to add the call to the notifiers directly in unregister_netdev() so that device drivers don't have to worry about it? (And is the existing patch missin

Re: SFQ qdisc crashes with limit of 2 packets

2007-09-18 Thread Patrick McHardy
Chuck Ebbert wrote: > Limit of 1 is forbidden, crashes with 2, works with 3: > >>From disassembling sch_sfq.ko it seems that it is on line 360 of sch_sfq.c: > sch->qstats.backlog -= skb->len; > where "skb" is an invalid pointer: Is it a NULL pointer or something random? - To unsubscribe from

Re: [PATCH] RDMA/CMA: Use neigh_event_send() to initiate neighbour discovery.

2007-09-18 Thread Steve Wise
Once this is applied upstream, I can pull it back in to ofed-1.2.5 and ofed-1.3. Steve. Sean Hefty wrote: RDMA/CMA: Use neigh_event_send() to initiate neighbour discovery. Calling arp_send() to initiate neighbour discovery (ND) doesn't do the full ND protocol. Namely, it doesn't handle retra

Re: InfiniBand/RDMA merge plans for 2.6.24

2007-09-18 Thread Michael S. Tsirkin
> Quoting Roland Dreier <[EMAIL PROTECTED]>: > Subject: Re: InfiniBand/RDMA merge plans for 2.6.24 > > > Roland, could you merge the common TX CQ patch please? > > It actually fixes a real problem. > > Yes, I will, but it collides with the net-2.6.24 NAPI rework I think, > so it may not go in u

SFQ qdisc crashes with limit of 2 packets

2007-09-18 Thread Chuck Ebbert
Limit of 1 is forbidden, crashes with 2, works with 3: https://bugzilla.redhat.com/show_bug.cgi?id=219895 = If the defect is produced at a console (as in ctrl-alt-f<0-6>) a kernel stack trace can be seen the moment "ping" is invoked. Since the stack trace is not written to the /var/log

Re: [PATCH]: New SO_BINDTODEVICE fix.

2007-09-18 Thread Ben Greear
David Miller wrote: Ok, I changed my mind and decided to retain the optlen==0 intended behavior. It fell out of fixing the small string length case. This is likely what I'll push to Linus and later -stable as a fix for this stuff. I manually patched this into 2.6.20 and ran some tests. My te

Re: InfiniBand/RDMA merge plans for 2.6.24

2007-09-18 Thread Roland Dreier
> Roland, could you merge the common TX CQ patch please? > It actually fixes a real problem. Yes, I will, but it collides with the net-2.6.24 NAPI rework I think, so it may not go in until a few days after the merge window. Have you verified that the patch cures the interrupt overload issues? -

Re: why does tcp_v[46]_conn_request not inc MIB stats

2007-09-18 Thread Rick Jones
Andi Kleen wrote: David Miller <[EMAIL PROTECTED]> writes: This is limiting embryonic mini-socket creation. The listen overflow should only increment when the 3-way handshake completion is aborted because the listening socket limit is exceeded, which is entirely different from the embryonic l

RE: e1000 driver and samba

2007-09-18 Thread Tantilov, Emil S
I ran a test here in the lab and was not able to reproduce the issue you're describing. My setup is with 2 systems connected through a 100Mbit switch. Client runs Windows XP and the server is Linux RHEL5 with updated samba 3.0.26a (latest I could download from samba.org). I was able to copy 1GB zi

[PATCH] forcedeth: "no link" is informational

2007-09-18 Thread Ed Swierk
Log "no link during initialization" at KERN_INFO as it's not an error, and occurs every time the interface comes up (when the forcedeth-phy-power-down patch is applied). Signed-off-by: Ed Swierk <[EMAIL PROTECTED]> forcedeth-open-no-link-printk.patch Description: Binary data

[PATCH] forcedeth: power down phy when interface is down

2007-09-18 Thread Ed Swierk
Bring the physical link down when the interface is down, by placing the PHY in power-down state. This mirrors the behavior of other drivers including e1000 and tg3. Signed-off-by: Ed Swierk <[EMAIL PROTECTED]> forcedeth-phy-power-down.patch Description: Binary data

Re: e1000 driver and samba

2007-09-18 Thread Bill Fink
On Tue, 18 Sep 2007, Florian Weimer wrote: > * Urs Thuermann: > > > How can a corrupted frame pass the TCP checksum check? > > The TCP/IP checksums are extremely weak. If the corruption is due to > defective SRAM or something like that, it's likely that it causes an > error pattern which is 16-

Re: 2.6.23-rc6-mm1: Build failure on ppc64 drivers/net/ehea/ehea_main.c

2007-09-18 Thread Mel Gorman
My apologies for the repost, this should have gone to netdev and Dave Miller as well. On (18/09/07 17:20), Mel Gorman didst pronounce: > Hi Andrew, > > PPC64 failed to build with the driver drivers/net/ehea with the > following error > > CC [M] drivers/net/ehea/ehea_main.o > drivers/net/ehea/

Re: InfiniBand/RDMA merge plans for 2.6.24

2007-09-18 Thread Michael S. Tsirkin
> Quoting Roland Dreier <[EMAIL PROTECTED]>: > Subject: InfiniBand/RDMA merge plans for 2.6.24 > > With 2.6.24 probably opening in the not-too-distant future, it's > probably a good time to review what my plans are for when the merge > window opens. Roland, could you merge the common TX CQ patch

Re: e1000 driver and samba

2007-09-18 Thread L F
This is the latest ethtool -S : beehive:~# ethtool -S eth4 NIC statistics: rx_packets: 33491526 tx_packets: 41410384 rx_bytes: 28384277429 tx_bytes: 46178788616 rx_broadcast: 3144 tx_broadcast: 2068 rx_multicast: 79 tx_multicast: 0 rx_errors: 0 tx_e

Re: new NAPI interface broken

2007-09-18 Thread Jan-Bernd Themann
Hi, On Saturday 15 September 2007 00:12, David Miller wrote: > Ok, for now I'm going to try and deal with this by reverting > the list handling to something approximating the old NAPI > code, as per the patch below. > > I've only quickly test booted into this kernel on my workstation. > So take c

[PATCH 1/2] [FS_ENET] TX stuff should use fep->tx_lock, instead of fep->lock.

2007-09-18 Thread Vitaly Bordug
Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- drivers/net/fs_enet/fs_enet-main.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c index a4a2a0e..927cd9e 100644 --- a/drivers/net/fs_enet

[PATCH 2/2] [FS_ENET] Add polling support

2007-09-18 Thread Vitaly Bordug
Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- drivers/net/fs_enet/fs_enet-main.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c index 927cd9e..0e2d2b2 100644 --- a/drivers/

Re: [PATCH] phy: export phy_mii_ioctl

2007-09-18 Thread Domen Puncer
(I edited Cc: -jeff, +sven, hope you don't mind) On 17/09/07 18:08 -0400, Jon Smirl wrote: > On 9/17/07, Domen Puncer <[EMAIL PROTECTED]> wrote: > > Export phy_mii_ioctl, so network drivers can use it when built > > as modules too. > > Domen, do you want to collect all of these changes for MPC520

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-18 Thread Patrick McHardy
Urs Thuermann wrote: > Patrick McHardy <[EMAIL PROTECTED]> writes: > > >>Looks pretty good, please see below for a few comments (mostly minor >>nitpicking, a few things that look like real bugs). Nothing that >>couldn't be fixed after merging though. > > > Thank you for your review. I'll go th

Re: [PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-18 Thread Patrick McHardy
Urs Thuermann wrote: > This patch adds the virtual CAN bus (vcan) network driver. > The vcan device is just a loopback device for CAN frames, no > real CAN hardware is involved. > > Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> > Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> > Also looks

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-18 Thread Urs Thuermann
Patrick McHardy <[EMAIL PROTECTED]> writes: > Looks pretty good, please see below for a few comments (mostly minor > nitpicking, a few things that look like real bugs). Nothing that > couldn't be fixed after merging though. Thank you for your review. I'll go through it and your other mail this e

[PATCH] PHYLIB: Spinlock fixes for softirqs

2007-09-18 Thread Maciej W. Rozycki
Use spin_lock_bh()/spin_unlock_bh() for the phydev lock throughout as it is used in phy_timer() that is called as a softirq and all the other operations may happen in the user context. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- There has been a change recently that did such a con

Re: [PATCH] 2.6.22.6 NETWORKING [IPV4]: Always use source addr in skb to reply packet

2007-09-18 Thread Bill Davidsen
David Miller wrote: From: lepton <[EMAIL PROTECTED]> Date: Tue, 18 Sep 2007 10:16:17 +0800 Hi, In some situation, icmp_reply and ip_send_reply will send out packet with the wrong source addr, the following patch will fix this. I don't understand why we must use rt->rt_src in the curren

Re: [2/3] 2.6.23-rc6: known regressions v2

2007-09-18 Thread Oliver Neukum
Am Dienstag 18 September 2007 schrieb Jan Kara: > > Subject         : umount triggers a warning in jfs and takes almost a minute > > References      : http://lkml.org/lkml/2007/9/4/73 > > Last known good : ? > > Submitter       : Oliver Neukum <[EMAIL PROTECTED]> > > Caused-By       : ? > > Handled

Re: [2/3] 2.6.23-rc6: known regressions v2

2007-09-18 Thread Dave Kleikamp
On Tue, 2007-09-18 at 16:24 +0200, Jan Kara wrote: > > Subject : umount triggers a warning in jfs and takes almost a minute > > References : http://lkml.org/lkml/2007/9/4/73 > > Last known good : ? > > Submitter : Oliver Neukum <[EMAIL PROTECTED]> > > Caused-By : ? > > Han

Re: [PATCH 1/2] IPoIB: Fix unregister_netdev hang

2007-09-18 Thread Roland Dreier
Thanks for testing on ehca... > While using IPoIB over EHCA (rc6 bits), unregister_netdev hangs with I don't think you're actually using rc6 bits, since in your patch you have: > -poll_more: and I think that is only in Dave's net-2.6.24 tree now, right? > The problem is that the poll handle

  1   2   >