> > and I think that is only in Dave's net-2.6.24 tree now, right?
>
> Nope, that was what I downloaded yesterday:
>
> VERSION = 2
> PATCHLEVEL = 6
> SUBLEVEL = 23
> EXTRAVERSION =-rc6
> NAME = Pink Farting Weasel
Please double check your tree. I just very carefully looked at my
trees, and the poll_more: label is added in commit 6b460a71 ("[NET]:
Make NAPI polling independent of struct net_device objects.") which is
only in the net-2.6.24 tree. Of course Dave did not change the
version information in the Makefile since he wouldn't want Linus to
pick up any extra strange changes when he pulls, so a net-2.6.24 tree
will look like 2.6.23-rc6 as you quoted.
And the refcounting bug I fixed is only in net-2.6.24.
> To be clear, netif_rx_schedule while we are still in the poll list will not
> do any harm as it does nothing since NAPI_STATE_SCHED is still set (cleared
> by netif_rx_complete which has not yet run). Effectively we lost/delayed
> processing an interrupt, if I understood the code right.
Right, we lose an interrupt, and since the CQ events are one-shot, we
never get another one, and the interface is effectively dead.
- R.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
