Re: Network Namespace status

2007-09-13 Thread Oliver Hartkopp
Eric W. Biederman wrote: > Looking into my patch queue I have: > 5 patches for cleaning up and making a per network namespace loopback device. > 4 patches for making rtnetlink message processing per network namespace > 1 patch for making AF_UNIX per network namespace > 1 patch for making AF_PACKET

Re: 2.6.23-rc4-mm1 OOPS in forcedeth?

2007-09-13 Thread Andrew James Wade
I have an Oops that may be related: BUG: unable to handle kernel NULL pointer dereference at virtual address 0025 printing eip: c037d81b *pde = Oops: [#1] last sysfs file: /devices/pci:00/:00:01.0/:01:00.0/class Pid: 0, comm: swapper Not tainted (2.6.23-rc4-mm1-conf

e1000 driver and samba

2007-09-13 Thread L F
Folks, I've been playing with multiple gigabit ethernet drivers to get samba 3.0.25+ to work reliably. The situation is as follows. I have a network, one of the machines on the network is a server/firewall. It contains an Intel PRO1000 dual port PCI Express card and runs Debian-testing. The machine

Re: r8169: slow samba performance

2007-09-13 Thread David Madsen
> > I noticed a somewhat significant difference between patch #0002 and a > > busy wait loop with ndelay(10). Write performance was equivalent in > > both cases as should be the case. Read perfomance for me maxed out > > Do you have some (gross) figure for the write performance ? Write performanc

[PATCH 1/1] myri10ge: Add support for PCI device id 9

2007-09-13 Thread Brice Goglin
Add support for new Myri-10G boards with PCI device id 9. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c |3 +++ 1 file changed, 3 insertions(+) Index: linux-rc/drivers/net/myri10ge/myri10ge.c ==

[PATCH 0/1] myri10ge update for 2.6.23

2007-09-13 Thread Brice Goglin
Hi Jeff, The following patch adds support for a new PCI device id. Please apply for 2.6.23. Thanks, Brice - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.24

2007-09-13 Thread Michael Chan
On Thu, 2007-09-13 at 14:11 -0700, Roland Dreier wrote: > > I've been meaning to track down the bnx2 iscsi offload patch to look > and see if this issue is addressed, since the same problem seems to > exist: it seems an iscsi connection and a main stack tcp connection > might share the same 4-tup

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.24

2007-09-13 Thread Roland Dreier
> Well, if it involves /sharing/ port space with the native stack, > i.e. where port 1234 is IB but 1235 is Linux, pretty much all the > networking devs have NAK'd that approach AFAICS. Just to be clear, InfiniBand has no problem; the issue is port collisions involving iWARP connections. - R.

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.24

2007-09-13 Thread Roland Dreier
> I was about to post v2 of my patch to avoid port space collisions with > the native stack. Can we get that 2.6.24? It is high priority > IMO. I've tried to solicit review on it, but I think folks are > reluctant... ;-) I would like to get this in, but I'm still at least a little reluctant,

[PATCH for 2.6.24] SCTP: Move sysctl_sctp_[rw]mem definitions to protocol.c

2007-09-13 Thread Vlad Yasevich
The sctp_[rw]mem definitions should really be in protocol.c since that is where they are initialized. This also allows one to build a kernel without sysctl support. Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]> --- net/sctp/protocol.c |6 +++--- net/sctp/sysctl.c | 11 +++ 2 f

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.24

2007-09-13 Thread Roland Dreier
> > - My user_mad P_Key index support patch. I'll test the ioctl to > > change to the new mode and merge this I guess, since Hal and Sean > > have tested this out. > > I can give this patch a reviewed-by: too, and I will also try to review a > couple > of the pending ipoib patches. T

Re: InfiniBand/RDMA merge plans for 2.6.24

2007-09-13 Thread Roland Dreier
> Since ehca can support 4K MTU, we would like to see a patch in > IPoIB to allow link MTU to be up to 4K instead of current 2K for 2.6.24 > kernel. The idea is IPoIB link MTU will pick up a return value from SM's > default broadcast MTU. This patch should be a small patch, I hope yo

Re: [Lksctp-developers] [RFC v3 PATCH 2/21] SCTP: Convert bind_addr_list locking to RCU

2007-09-13 Thread Vlad Yasevich
Sridhar Samudrala wrote: > On Thu, 2007-09-13 at 15:33 -0400, Vlad Yasevich wrote: >> Hi Sridhar >> >> Sridhar Samudrala wrote: >>> On Wed, 2007-09-12 at 15:33 -0700, Paul E. McKenney wrote: On Wed, Sep 12, 2007 at 05:03:42PM -0400, Vlad Yasevich wrote: > [... and here is the updated versi

Re: [v3 PATCH 2/2] SCTP: Convert bind_addr_list locking to RCU

2007-09-13 Thread Sridhar Samudrala
On Thu, 2007-09-13 at 15:34 -0400, Vlad Yasevich wrote: > Since the sctp_sockaddr_entry is now RCU enabled as part of > the patch to synchronize sctp_localaddr_list, it makes sense to > change all handling of these entries to RCU. This includes the > sctp_bind_addrs structure and it's list of boun

Re: [v3 PATCH 1/2] SCTP: Add RCU synchronization around sctp_localaddr_list

2007-09-13 Thread Sridhar Samudrala
On Thu, 2007-09-13 at 15:34 -0400, Vlad Yasevich wrote: > sctp_localaddr_list is modified dynamically via NETDEV_UP > and NETDEV_DOWN events, but there is not synchronization > between writer (even handler) and readers. As a result, > the readers can access an entry that has been freed and > crash

Re: [Lksctp-developers] [RFC v3 PATCH 2/21] SCTP: Convert bind_addr_list locking to RCU

2007-09-13 Thread Sridhar Samudrala
On Thu, 2007-09-13 at 15:33 -0400, Vlad Yasevich wrote: > Hi Sridhar > > Sridhar Samudrala wrote: > > On Wed, 2007-09-12 at 15:33 -0700, Paul E. McKenney wrote: > >> On Wed, Sep 12, 2007 at 05:03:42PM -0400, Vlad Yasevich wrote: > >>> [... and here is the updated version as promissed ...] > >>> >

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.24

2007-09-13 Thread Jeff Garzik
Steve Wise wrote: Jeff Garzik wrote: Steve Wise wrote: I was about to post v2 of my patch to avoid port space collisions with the native stack. Can we get that 2.6.24? It is high priority IMO. I've tried to solicit review on it, but I think folks are reluctant... ;-) Well, if it involves

Re: [ofa-general] [PATCH v2] iw_cxgb3: Support "iwarp-only" interfaces to avoid 4-tuple conflicts.

2007-09-13 Thread Sean Hefty
The iWARP driver must translate all listens on address 0.0.0.0 to the set of rdma-only ip addresses for the device in question. This prevents incoming connect requests to the TCP ipaddresses from going up the rdma stack. I've only given this a high level review at this point, and while the pat

Re: [BUG] tg3 cannot do PXE (loses MAC address) after soft reboot

2007-09-13 Thread Michael Chan
On Thu, 2007-09-13 at 21:28 +0200, Lucas Nussbaum wrote: > Erm, Wouldn't it be possible to print a warning when the driver loads, > saying that the firmware is outdated ? It's possible, but would require the driver to parse the version string. The driver currently reports the version string for i

[v3 PATCH 2/2] SCTP: Convert bind_addr_list locking to RCU

2007-09-13 Thread Vlad Yasevich
Since the sctp_sockaddr_entry is now RCU enabled as part of the patch to synchronize sctp_localaddr_list, it makes sense to change all handling of these entries to RCU. This includes the sctp_bind_addrs structure and it's list of bound addresses. This list is currently protected by an external rw

[v3 PATCH 0/2] Add RCU locking to SCTPaddress management

2007-09-13 Thread Vlad Yasevich
Hi All Thanks to Sridhar Samudral and Paul McKenney for all the help and comments. I think this is a final version, unless someone else can spot more problems. I've ran this under heavy load and it the patches behaves well. I think patch 1 is a candidate for 2.6.23 since it fixes a bug, but split

[v3 PATCH 1/2] SCTP: Add RCU synchronization around sctp_localaddr_list

2007-09-13 Thread Vlad Yasevich
sctp_localaddr_list is modified dynamically via NETDEV_UP and NETDEV_DOWN events, but there is not synchronization between writer (even handler) and readers. As a result, the readers can access an entry that has been freed and crash the sytem. Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]> Acke

Re: [Lksctp-developers] [RFC v3 PATCH 2/21] SCTP: Convert bind_addr_list locking to RCU

2007-09-13 Thread Vlad Yasevich
Hi Sridhar Sridhar Samudrala wrote: > On Wed, 2007-09-12 at 15:33 -0700, Paul E. McKenney wrote: >> On Wed, Sep 12, 2007 at 05:03:42PM -0400, Vlad Yasevich wrote: >>> [... and here is the updated version as promissed ...] >>> >>> Since the sctp_sockaddr_entry is now RCU enabled as part of >>> the

Re: [BUG] tg3 cannot do PXE (loses MAC address) after soft reboot

2007-09-13 Thread Lucas Nussbaum
On 13/09/07 at 11:05 -0700, Michael Chan wrote: > On Thu, 2007-09-13 at 17:41 +0200, Lucas Nussbaum wrote: > > > # ethtool -i eth0 > > driver: tg3 > > version: 3.65 > > firmware-version: 5703-v2.21a > > bus-info: :02:02.0 > > The firmware is quite old and needs to be upgraded to fix the probl

[PATCH v2] iw_cxgb3: Support "iwarp-only" interfaces to avoid 4-tuple conflicts.

2007-09-13 Thread Steve Wise
iw_cxgb3: Support "iwarp-only" interfaces to avoid 4-tuple conflicts. Version 2: - added a per-device mutex for the address and listening endpoints lists. - wait for all replies if sending multiple passive_open requests to rnic. - log warning if no addresses are available when a listen is issu

Network Namespace status

2007-09-13 Thread Eric W. Biederman
Now that the network namespace work is partly merged I figure a short status summary of where everything is at is in order. David Miller has merged the core of the network namespace work and that probably needs to sit just a little while to make certain we don't have unexpected breakage. Before

Re: [PATCH] Add IP1000A Driver

2007-09-13 Thread Francois Romieu
?-Jesse <[EMAIL PROTECTED]> : [...] > I wish to list three people you, me and, my leader Sorbica in this file. Yes. -- Ueimor - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/m

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.24

2007-09-13 Thread Steve Wise
Jeff Garzik wrote: Steve Wise wrote: I was about to post v2 of my patch to avoid port space collisions with the native stack. Can we get that 2.6.24? It is high priority IMO. I've tried to solicit review on it, but I think folks are reluctant... ;-) Well, if it involves /sharing/ port sp

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.24

2007-09-13 Thread Jeff Garzik
Steve Wise wrote: I was about to post v2 of my patch to avoid port space collisions with the native stack. Can we get that 2.6.24? It is high priority IMO. I've tried to solicit review on it, but I think folks are reluctant... ;-) Well, if it involves /sharing/ port space with the native sta

[v2 PATCH for 2.6.24] SCTP: Implement the Supported Extensions Parameter

2007-09-13 Thread Vlad Yasevich
[... i can't seem to spell to save my life lately...] SCTP Supported Extenions parameter is specified in Section 4.2.7 of the ADD-IP draft (soon to be RFC). The parameter is encoded as: 0 1 2 3 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7

[PATCH for 2.6.24] SCTP: Implete the Supported Extensions Parameter

2007-09-13 Thread Vlad Yasevich
SCTP Supported Extenions parameter is specified in Section 4.2.7 of the ADD-IP draft (soon to be RFC). The parameter is encoded as: 0 1 2 3 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 +-+-+-+-+-+-+-+-+-+-+-

incorrect cksum with tcp/udp on lo with 2.6.20/2.6.21/2.6.22

2007-09-13 Thread Krzysztof Oledzki
Hello, It seems that after some not very recent changes udp and tcp packes carring data send by a loopback have incorrect cksum: UDP: # echo test|nc -u 127.0.0.1 # tcpdump -i lo -n -v -v port tcpdump: listening on lo, link-type EN10MB (Ethernet), capture size 96 bytes 19:43:39.34057

Re: InfiniBand/RDMA merge plans for 2.6.24

2007-09-13 Thread Shirley Ma
Hello Roland, Since ehca can support 4K MTU, we would like to see a patch in IPoIB to allow link MTU to be up to 4K instead of current 2K for 2.6.24 kernel. The idea is IPoIB link MTU will pick up a return value from SM's default broadcast MTU. This patch should be a small patch, I hop

RE: [ofa-general] InfiniBand/RDMA merge plans for 2.6.24

2007-09-13 Thread Sean Hefty
> - My user_mad P_Key index support patch. I'll test the ioctl to > change to the new mode and merge this I guess, since Hal and Sean > have tested this out. I can give this patch a reviewed-by: too, and I will also try to review a couple of the pending ipoib patches. > - Sean's QoS changes.

Re: [RFC v3 PATCH 2/21] SCTP: Convert bind_addr_list locking to RCU

2007-09-13 Thread Vlad Yasevich
Hi Sridhar Sridhar Samudrala wrote: > > looks good to me too. some minor typos and some comments on > RCU usage comments inline. > > Also, I guess we can remove the sctp_[read/write]_[un]lock macros > from sctp.h now that you removed the all the users of rwlocks > in SCTP Ok. I guess I pull th

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.24

2007-09-13 Thread Steve Wise
Hey Roland, I was about to post v2 of my patch to avoid port space collisions with the native stack. Can we get that 2.6.24? It is high priority IMO. I've tried to solicit review on it, but I think folks are reluctant... ;-) Steve. Roland Dreier wrote: With 2.6.24 probably opening in th

Re: [RFC v3 PATCH 2/21] SCTP: Convert bind_addr_list locking to RCU

2007-09-13 Thread Sridhar Samudrala
On Wed, 2007-09-12 at 15:33 -0700, Paul E. McKenney wrote: > On Wed, Sep 12, 2007 at 05:03:42PM -0400, Vlad Yasevich wrote: > > [... and here is the updated version as promissed ...] > > > > Since the sctp_sockaddr_entry is now RCU enabled as part of > > the patch to synchronize sctp_localaddr_lis

InfiniBand/RDMA merge plans for 2.6.24

2007-09-13 Thread Roland Dreier
With 2.6.24 probably opening in the not-too-distant future, it's probably a good time to review what my plans are for when the merge window opens. At the kernel summit, we discussed patch review (doing a web search for "kernel summit" "reviewed-by:" should turn up lots of info on this). Due to an

Re: [BUG] tg3 cannot do PXE (loses MAC address) after soft reboot

2007-09-13 Thread Michael Chan
On Thu, 2007-09-13 at 17:41 +0200, Lucas Nussbaum wrote: > # ethtool -i eth0 > driver: tg3 > version: 3.65 > firmware-version: 5703-v2.21a > bus-info: :02:02.0 The firmware is quite old and needs to be upgraded to fix the problem. I'll have someone contact you to get it upgraded. > > What d

Re: [PATCH] [RFC] allow admin/users to specify rto_min in milliseconds rather than jiffies

2007-09-13 Thread Rick Jones
Your observations are correct. rtnetlink can't/shouldn't be doing conversions itself. The 'ip' command should use a consistent unit for all values and do conversions if necessary. That being the case I'll start looking to see what is involved in "leveraging" the time conversion stuff in tc for

[PATCH] net: Fix the prototype of call_netdevice_notifiers

2007-09-13 Thread Eric W. Biederman
This replaces the void * parameter with a struct net_device * which is what is actually required. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- include/linux/netdevice.h |2 +- net/core/dev.c|4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/in

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-13 Thread Jeff Garzik
Ralf Baechle wrote: On Thu, Sep 13, 2007 at 03:13:06PM +0100, Maciej W. Rozycki wrote: Hmm, works fine with linux-2.6.git#master. I do not recall any recent activity with this driver -- I wonder what the difference is. Let me see... Hmm... HEAD du jour has no differences for the sb1250-m

Re: [BUG] tg3 cannot do PXE (loses MAC address) after soft reboot

2007-09-13 Thread Lucas Nussbaum
On 13/09/07 at 08:15 -0700, Michael Chan wrote: > Lucas Nussbaum wrote: > > > This used to work, and broke between 2.6.16 and 2.6.17. Using > > git bissect, > > I could trace this back to that commit: > > commit bc1c756741b065cfebf850e4164c0e2aae9d527f > > Author: Michael Chan <[EMAIL PROTECTED]>

[PATCH] ucc_geth: fix compilation

2007-09-13 Thread Anton Vorontsov
Currently qe_bd_t is used in the macro call -- dma_unmap_single, which is a no-op on PPC32, thus error is hidden today. Starting with 2.6.24, macro will be replaced by the empty static function, and erroneous use of qe_bd_t will trigger compilation error. Signed-off-by: Anton Vorontsov <[EMAIL PRO

Re: [BUG] tg3 cannot do PXE (loses MAC address) after soft reboot

2007-09-13 Thread Michael Chan
Lucas Nussbaum wrote: > This used to work, and broke between 2.6.16 and 2.6.17. Using > git bissect, > I could trace this back to that commit: > commit bc1c756741b065cfebf850e4164c0e2aae9d527f > Author: Michael Chan <[EMAIL PROTECTED]> > Date: Mon Mar 20 17:48:03 2006 -0800 > [TG3]: Support

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-13 Thread Ralf Baechle
On Thu, Sep 13, 2007 at 03:13:06PM +0100, Maciej W. Rozycki wrote: > Hmm, works fine with linux-2.6.git#master. I do not recall any recent > activity with this driver -- I wonder what the difference is. Let me > see... Hmm... HEAD du jour has no differences for the sb1250-mac between lmo an

Re: Distributed storage. Security attributes and ducumentation update.

2007-09-13 Thread Paul E. McKenney
On Thu, Sep 13, 2007 at 04:22:59PM +0400, Evgeniy Polyakov wrote: > Hi Paul. > > On Mon, Sep 10, 2007 at 03:14:45PM -0700, Paul E. McKenney ([EMAIL > PROTECTED]) wrote: > > > Further TODO list includes: > > > * implement optional saving of mirroring/linear information on the remote > > > nodes

RE: [PATCH v3] Make the pr_*() family of macros in kernel.hcomplete

2007-09-13 Thread Medve Emilian-EMMEDVE1
Hello Joe, > I expect all the kernel logging functions to be > overhauled eventually. > > I'd prefer a mechanism that somehow supports > identifying complete messages. I think the new > pr_ functions are not particularly useful > without a mechanism to avoid or identify multiple > processors or

Re: [CORRECTION][PATCH] Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c

2007-09-13 Thread Jeff Garzik
Andrew Morton wrote: --- a/drivers/net/tulip/uli526x.c~fix-a-potential-null-pointer-dereference-in-uli526x_interrupt +++ a/drivers/net/tulip/uli526x.c @@ -666,11 +666,6 @@ static irqreturn_t uli526x_interrupt(int unsigned long ioaddr = dev->base_addr; unsigned long flags; - if

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-13 Thread Maciej W. Rozycki
On Wed, 12 Sep 2007, Jeff Garzik wrote: > > Remove typedefs, volatiles and convert kmalloc()/memset() pairs to > > kcalloc(). Also reformat the surrounding clutter. > > > > Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> > > --- > > ACK, but patch does not apply cleanly to netdev-2.6.git#u

Re: [RFC v2 PATCH 1/2] SCTP: Add RCU synchronization around sctp_localaddr_list

2007-09-13 Thread Vlad Yasevich
Hi Sridhar Sridhar Samudrala wrote: > Vlad, > > few minor comments inline. > otherwise, looks good. > > Thanks > Sridhar > >> diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c >> index f8aa23d..54ff472 100644 >> --- a/net/sctp/ipv6.c >> +++ b/net/sctp/ipv6.c >> @@ -77,13 +77,18 @@ >> >> #include

Re: [RFC] af_packet: allow disabling timestamps

2007-09-13 Thread Eric Dumazet
On Thu, 13 Sep 2007 12:42:53 +0200 Stephen Hemminger <[EMAIL PROTECTED]> wrote: > Currently, af_packet does not allow disabling timestamps. This patch changes > that but doesn't force global timestamps on. > > This shows up in bugzilla as: > http://bugzilla.kernel.org/show_bug.cgi?id=4809 >

Re: Distributed storage. Security attributes and ducumentation update.

2007-09-13 Thread Evgeniy Polyakov
Hi Paul. On Mon, Sep 10, 2007 at 03:14:45PM -0700, Paul E. McKenney ([EMAIL PROTECTED]) wrote: > > Further TODO list includes: > > * implement optional saving of mirroring/linear information on the remote > > nodes (simple) > > * implement netlink based setup (simple) > > * new redundancy alg

Re: [PATCH][MIPS][7/7] AR7: ethernet

2007-09-13 Thread Ralf Baechle
On Thu, Sep 13, 2007 at 02:42:46AM +0100, Thiemo Seufer wrote: > > All struct members here are sized such that there is no padding needed, so > > the packed attribute doesn't buy you anything - unless of course the > > entire structure is missaligned but I don't see how that would be possible > >

[RFC] af_packet: allow disabling timestamps

2007-09-13 Thread Stephen Hemminger
Currently, af_packet does not allow disabling timestamps. This patch changes that but doesn't force global timestamps on. This shows up in bugzilla as: http://bugzilla.kernel.org/show_bug.cgi?id=4809 Patch against net-2.6.24 tree. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> ---

Re: [PATCH 4/4] [IPROUTE2] iproute2: link_veth support bug fixes.

2007-09-13 Thread Stephen Hemminger
On Wed, 12 Sep 2007 09:13:02 -0600 [EMAIL PROTECTED] (Eric W. Biederman) wrote: > Pavel Emelyanov <[EMAIL PROTECTED]> writes: > > > [snip] > > > >> @@ -25,6 +26,3 @@ clean: > >> > >> LDLIBS+= -ldl > >> LDFLAGS += -Wl,-export-dynamic > >> - > >> -%.so: %.c > >> - $(CC) $(CFLAGS) -shared

[PATCH 1/1] ipv6: remove redundant RTM_DELLINK message

2007-09-13 Thread Milan Kocian
remove useless message. We get right message from other subsystem. --- --- a/net/ipv6/addrconf.c 2007-09-13 11:22:31.087494976 +0200 +++ b/net/ipv6/addrconf.c 2007-09-13 11:25:56.056225711 +0200 @@ -2486,9 +2486,7 @@ static int addrconf_ifdown(struct net_de else

Re: [PATCH] Fix a lock problem in generic phy code

2007-09-13 Thread Hans-Jürgen Koch
Am Donnerstag 13 September 2007 schrieb Jeff Garzik: > Hans-Jürgen Koch wrote: > > Lock debugging finds a problem in phy.c and phy_device.c, > > this patch fixes it. Tested on an AT91SAM9263-EK board, > > kernel 2.6.23-rc4. > > > > Signed-off-by: Hans J. Koch <[EMAIL PROTECTED]> > > applied Thanks

Re: [CORRECTION][PATCH] Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c

2007-09-13 Thread Kyle McMartin
On Thu, Sep 13, 2007 at 02:03:46AM -0700, Andrew Morton wrote: > I suspect the fix we want is: > ack. The trend seems to be to avoid this redundant check in the interrupt handler. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] Mor

Re: bridge problem

2007-09-13 Thread Stephen Hemminger
On Thu, 13 Sep 2007 15:03:24 +0800 "潘炳宇" <[EMAIL PROTECTED]> wrote: > i get a bridge problem when patch my kernel 2.4.32 You need to describe the problem more fully to get assistance. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMA

Re: [PATCH] veth: Cleanly handle a missing peer_tb argument on creation.

2007-09-13 Thread Pavel Emelyanov
Eric W. Biederman wrote: > Pavel Emelyanov <[EMAIL PROTECTED]> writes: > >> Eric W. Biederman wrote: >>> Pavel Emelyanov <[EMAIL PROTECTED]> writes: >>> > + } > > - tbp = peer_tb; > - } else > - tbp = tb; The intention of this part was to get the same par

Re: [CORRECTION][PATCH] Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c

2007-09-13 Thread Andrew Morton
On Tue, 04 Sep 2007 16:14:06 +0800 Micah Gruber <[EMAIL PROTECTED]> wrote: > This patch fixes a potential null dereference bug where we dereference dev > before a null check. This patch simply moves the dereferencing after the null > check. > > Signed-off-by: Micah Gruber <[EMAIL PROTECTED]> >

[BUG] tg3 cannot do PXE (loses MAC address) after soft reboot

2007-09-13 Thread Lucas Nussbaum
Hi, We use PXE with Broadcom NetXtreme cards. After a soft reboot (using the "reboot" command), the system cannot get an IP address using DHCP. On the console, a MAC address of 00 00 00 00 00 00 is shown. When rebooting with "reboot -f" or with the reset button, everything works as expected. This

Re: [PATCH] [RFC] allow admin/users to specify rto_min in milliseconds rather than jiffies

2007-09-13 Thread Stephen Hemminger
On Wed, 12 Sep 2007 13:28:42 -0700 Rick Jones <[EMAIL PROTECTED]> wrote: > >> The api in netlink should be in milliseconds rather than compensating > >> in the application (iproute2). > > > > > > My understanding of the in-kernel rtnetlink code is far from complete, > > but it doesn't seem to h

Re: [PATCH 1/4] [IPV6]: Fix unbalanced socket reference with MSG_CONFIRM.

2007-09-13 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Thu, 13 Sep 2007 09:35:28 +0900 (JST) > | [PATCH 1/4] [IPV6]: Fix unbalanced socket reference with MSG_CONFIRM. > > Ah, I should say, socket locking, probably... > Anyway, lock_sock() and release_sock() are not paired approriately. Thanks

Re: [PATCH 3/3 v4] rfkill: Add rfkill documentation

2007-09-13 Thread David Miller
From: Ivo van Doorn <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 20:14:39 +0200 > Add a documentation file which contains > a short description about rfkill with some > notes about drivers and the userspace interface. > > Changes since v1 and v2: >  - Spellchecking > > Signed-off-by: Ivo van Doorn

Re: [PATCH 1/3 v4] rfkill: Remove IRDA

2007-09-13 Thread David Miller
From: Ivo van Doorn <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 20:14:26 +0200 > As Dmitry pointed out earlier, rfkill-input.c > doesn't support irda because there are no users > and we shouldn't add unrequired KEY_ defines. > > However, RFKILL_TYPE_IRDA was defined in the > rfkill.h header file a

Re: [PATCH 2/3 v4] rfkill: Add support for ultrawideband

2007-09-13 Thread David Miller
From: Ivo van Doorn <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 20:14:29 +0200 > This patch will add support for UWB keys to rfkill, > support for this has been requested by Inaky. > > Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> > CC: Dmitry Torokhov <[EMAIL PROTECTED]> > CC: Inaky Perez-Gonz

Re: [PATCH] net: Fix race when opening a proc file while a network namespace is exiting.

2007-09-13 Thread David Miller
From: "Paul E. McKenney" <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 15:46:53 -0700 > Looks much better! > > Acked-by: Paul E. McKenney <[EMAIL PROTECTED]> Applied, thanks everyone. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] M

Re: [net-2.6.24][NETNS][patch 1/1] fix allnoconfig compilation error

2007-09-13 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 13 Sep 2007 08:01:52 +0200 > From: Daniel Lezcano <[EMAIL PROTECTED]> > > When CONFIG_NET=no, init_net is unresolved because net_namespace.c > is not compiled and the include pull init_net definition. > > This problem was very similar with the ipc namespace whe

Re: BUG: scheduling while atomic: ifconfig/0x00000002/4170

2007-09-13 Thread Johannes Berg
On Wed, 2007-09-12 at 05:34 -0700, David Miller wrote: > From: Johannes Berg <[EMAIL PROTECTED]> > Date: Thu, 06 Sep 2007 17:19:55 +0200 > > > > > Oh btw. Can we stick a might_sleep() into dev_close() *before* the test > > whether the device is up? That way, we'd have seen the bug, but > > appare

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-13 Thread David Miller
From: "Mandeep Baines" <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 09:47:46 -0700 > Why would disabling IRQ's be expensive on non-MSI PCI devices? > Wouldn't it just require a single MMIO write to clear the interrupt > mask of the device. MMIO's are the most expensive part of the whole interrupt s