Manual code check. The similar fixes are present in almost all drivers,
f.e. tg3 one. I have an unrelated deadlock with rtnl.
Regards,
Den
Valerie Henson wrote:
(No longer maintainer, btw.)
What situation have you tested this under? Thanks,
-VAL
On Tue, Jul 24, 2007 at 11:49:08AM +0400
David Miller wrote:
From: Ben Greear <[EMAIL PROTECTED]>
Date: Mon, 30 Jul 2007 21:30:19 -0700
So, shall we add a new field to the skb in order to get the info out of cb?
Looks like a single 32-bit field would be sufficient.
I'm trying to brainstorm how to avoid consuming new space i
On Mon, 30 Jul 2007, David Miller wrote:
> From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
> Date: Mon, 30 Jul 2007 20:19:40 +0300 (EEST)
>
> > I'm not completely pleased with this solution because readability
> > of the code is somewhat questionable as 'is_dupack' in SACK case
> > is no longer about d
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Tue, 31 Jul 2007 07:59:10 +0300 (EEST)
> I think it's probably good to add tp->snd_una != prior_snd_una
> check there too... It's not going to make a large difference,
> mostly just to be conservative when skb collapse stuff got done
> (and maybe to
From: Ben Greear <[EMAIL PROTECTED]>
Date: Mon, 30 Jul 2007 21:30:19 -0700
> So, shall we add a new field to the skb in order to get the info out of cb?
>
> Looks like a single 32-bit field would be sufficient.
I'm trying to brainstorm how to avoid consuming new space in
sk_buff and I'd like oth
I've been able to capture a tcpdump from both ends during the problem
and its my belief there is a bug in 2.6.20.1 (at the client side) in
that it issues a SACK option for an old sequence which the current
window being advertised is beyond it. This is the most concerning issue
as the integri
On Mon, 30 Jul 2007, David Miller wrote:
> From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
> Date: Mon, 30 Jul 2007 20:18:45 +0300 (EEST)
>
> > Actually, the ratehalving seems to work too well, as cwnd is
> > reduced on every second ACK even though the packets in flight
> > remains unchanged. Recoverie
If SCTP data sender received a SACK which contains Cumulative TSN Ack is
not less than the Cumulative TSN Ack Point, and if this Cumulative TSN
Ack is not used by the data sender, SCTP data sender still accept this
SACK , and next SACK which send correctly to DATA sender be dropped,
because it
David Miller wrote:
From: jamal <[EMAIL PROTECTED]>
Date: Mon, 30 Jul 2007 22:02:04 -0400
I came across the issue because i used cb in batching to store transient
state which is used between qdisc dequeueing and hardware enqueueing
(looked and smelled legit to me).
Right, dequeue->dev
> -Original Message-
> From: [EMAIL PROTECTED] [mailto:netdev-
> [EMAIL PROTECTED] On Behalf Of Andrew Gallatin
> Sent: Monday, July 30, 2007 10:43 AM
> To: Linas Vepstas
> Cc: Jan-Bernd Themann; netdev; Thomas Klein; Jeff Garzik; Jan-Bernd
> Themann; linux-kernel; linux-ppc; Christoph Ra
On 7/30/07, David Miller <[EMAIL PROTECTED]> wrote:
> From: Flavio Leitner <[EMAIL PROTECTED]>
> Date: Mon, 30 Jul 2007 13:04:48 -0300
>
> >
> > The sock_copy() function uses memcpy() to clone the socket
> > including the struct ip_mc_socklist *mc_list pointer.
> >
> > The ip_mc_drop_socket() funct
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Mon, 30 Jul 2007 20:19:40 +0300 (EEST)
> It's possible that new SACK blocks that should trigger new LOST
> markings arrive with new data (which previously made is_dupack
> false). In addition, I think this fixes a case where we get
> a cumulative ACK
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Mon, 30 Jul 2007 20:16:54 +0300 (EEST)
> These will generate you some hassle when you rebase tcp-2.6. Btw, you
> forgot to push tcp-2.6 out last time though I could assume it's
> state... :-) In case you're going to now push it out, could you please
On Mon, 30 Jul 2007, Valerie Henson wrote:
On Mon, Jul 30, 2007 at 03:31:58PM -0400, Kyle McMartin wrote:
On Mon, Jul 30, 2007 at 01:04:13PM -0600, Valerie Henson wrote:
The Tulip network driver needs a new maintainer! I no longer have
time to maintain the Tulip network driver and I'm steppin
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Mon, 30 Jul 2007 20:18:45 +0300 (EEST)
> Actually, the ratehalving seems to work too well, as cwnd is
> reduced on every second ACK even though the packets in flight
> remains unchanged. Recoveries in a bidirectional flows suffer
> quite badly becaus
On Mon, 2007-30-07 at 18:37 -0700, David Miller wrote:
> Relatively speaking, the acpi_pm numbers are at least consistent and
> about as much as so as jiffies. Jiffies numbers are also possibly
> better, at least in part, because of the decreased accuracy and errors
> propagating.
I am not sure
On Mon, 2007-07-30 at 21:23 -0400, jamal wrote:
> On Mon, 2007-30-07 at 21:17 -0400, jamal wrote:
>
> > Actually iirc, hpet is not even enabled in the
> > kernel -
>
> Sorry, i lied - the config file is on my laptop - it is enabled.
is it also on in the bios? (and if not, can you grab the patch
On Mon, 2007-07-30 at 18:37 -0700, David Miller wrote:
> There really isn't much that can be done by any of this. These issues
> exist because of hardware limitations, nobody bothered to build
> x86/x86_64 systems with a system wide TICK register that is both
> impervious to cpu frequence scaling
From: jamal <[EMAIL PROTECTED]>
Date: Mon, 30 Jul 2007 22:02:04 -0400
> I came across the issue because i used cb in batching to store transient
> state which is used between qdisc dequeueing and hardware enqueueing
> (looked and smelled legit to me).
Right, dequeue->device should be OK and doesn
From: Roland Dreier <[EMAIL PROTECTED]>
Date: Mon, 30 Jul 2007 19:01:55 -0700
> Are you saying that netif_rx_reschedule() itself is racy?
Nevermind, you're right.
I'll see if I can resurrect something akin to netif_rx_reschedule()
when I get back to the NAPI patches. Probably what I'll do is le
On Mon, 2007-30-07 at 18:33 -0700, David Miller wrote:
> I understand the concern, but how much qdisc stuff can possibly
> happen between those two ->hard_start_xmit() calls and do we
> want to support that in any way anyways?
>From a quick glance only netem seems to use it in the fast path (in a
From: Flavio Leitner <[EMAIL PROTECTED]>
Date: Mon, 30 Jul 2007 13:04:48 -0300
>
> The sock_copy() function uses memcpy() to clone the socket
> including the struct ip_mc_socklist *mc_list pointer.
>
> The ip_mc_drop_socket() function is called when socket is closed
> to free these objects leavi
> It is not a feature of these changes.
> These races exist in the current code, it is a bug fix.
Not sure I follow. What is the race in the current code? Are you
saying that netif_rx_reschedule() itself is racy? Otherwise the code
in ipoib looks OK to me.
- R.
-
To unsubscribe from this l
On Mon, Jul 30, 2007 at 03:31:58PM -0400, Kyle McMartin wrote:
> On Mon, Jul 30, 2007 at 01:04:13PM -0600, Valerie Henson wrote:
> > The Tulip network driver needs a new maintainer! I no longer have
> > time to maintain the Tulip network driver and I'm stepping down. Jeff
> > Garzik would be happ
From: James Chapman <[EMAIL PROTECTED]>
Date: Mon, 30 Jul 2007 13:05:39 +0100
> [PPPOL2TP]: Add CONFIG_INET Kconfig dependency.
>
> PPPOL2TP uses UDP so it obviously depends on CONFIG_INET.
>
> Signed-off-by: James Chapman <[EMAIL PROTECTED]>
Fair enough, applied, thanks James.
-
To unsubscrib
Stephen Rothwell pointed out to me that the skb_frag_struct
is broken on platforms using 64K or larger page sizes, it
even generates warnings when (for example) the myri10ge driver
tries to assign PAGE_SIZE into frag->size.
I've thus increased page offset and size to __u32 in the patch below.
I
From: jamal <[EMAIL PROTECTED]>
Date: Mon, 30 Jul 2007 21:10:39 -0400
> acpi_pm: 108, 110, 111, 91, 108
> tsc: 143, 108, 161, 129, 108
> jiffies: 132, 138, 132, 146, 150
>
> jiffies produces better results than tsc which produces better results
> than acpi_pm.
Relatively speaking, the acpi
From: jamal <[EMAIL PROTECTED]>
Date: Mon, 30 Jul 2007 20:59:16 -0400
> This seems like a bad use since there can be a lot of things between
> a real hardware driver and something that sets a vlan tag (qdiscs come
> to mind).
I understand the concern, but how much qdisc stuff can possibly
happen
Patrick McHardy wrote:
-static int
-sfq_enqueue(struct sk_buff *skb, struct Qdisc* sch)
+static void sfq_q_enqueue(struct sk_buff *skb, struct sfq_sched_data *q,
unsigned int end)
Please make sure to break at 80 chars and to keep the style
in this file consistent (newline before function name
On Mon, 2007-30-07 at 21:17 -0400, jamal wrote:
> Actually iirc, hpet is not even enabled in the
> kernel -
Sorry, i lied - the config file is on my laptop - it is enabled.
cheers,
jamal
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROT
On Mon, 2007-30-07 at 18:10 -0700, Arjan van de Ven wrote:
> can you make sure hpet is enabled as well?
Will do next opportunity. Actually iirc, hpet is not even enabled in the
kernel - What are you expecting to see?
cheers,
jamal
-
To unsubscribe from this list: send the line "unsubscribe net
On Mon, 2007-07-30 at 21:10 -0400, jamal wrote:
> Folks,
>
> I have posted this before but got no good response and i havent had time
> to chase it.
> While doing some batching tests with pktgen and then with a simple
> client server app with udp, it does appear that the clock source used
> matte
Folks,
I have posted this before but got no good response and i havent had time
to chase it.
While doing some batching tests with pktgen and then with a simple
client server app with udp, it does appear that the clock source used
matters. Here are some basic runs with plain vanilla 2.6.22-rc4 run
From: Adrian Bunk <[EMAIL PROTECTED]>
Date: Sun, 29 Jul 2007 16:58:52 +0200
> The following code can now become static:
> - struct unix_socket_table
> - unix_table_lock
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Also applied, thanks a lot.
-
To unsubscribe from this list: send the line "
From: Adrian Bunk <[EMAIL PROTECTED]>
Date: Sun, 29 Jul 2007 16:58:46 +0200
> nf_ct_ipv6_skip_exthdr() can now become static.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Applied.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECT
From: Adrian Bunk <[EMAIL PROTECTED]>
Date: Sun, 29 Jul 2007 16:58:40 +0200
> Non-static inline code usually doesn't makes sense.
>
> In this case making is static and non-inline is the correct solution.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Applied, thanks Adrian.
-
To unsubscribe
I was going to forget this, but its been playing in the back of my head
and wont go away
Matt Carlson recently (while fixing the tg3 driver in my batching
patches) pointed to me that skb->cb[] was being used to pass around vlan
data.
This seems like a bad use since there can be a lot of thing
From: Florian Zumbiehl <[EMAIL PROTECTED]>
Date: Sun, 29 Jul 2007 08:04:46 +0200
> and the last one for now: Acquire the sock lock in pppoe_sendmsg()
> before accessing the sock - and in particular avoid releasing the lock
> even though it hasn't been acquired.
>
> Signed-off-by: Florian Zumbiehl
From: Florian Zumbiehl <[EMAIL PROTECTED]>
Date: Sun, 29 Jul 2007 08:04:36 +0200
> here another patch for the PPPoX/E code that makes sure that ENOTTY is
> returned for unknown ioctl requests rather than 0 (and removes another
> unneeded initializer which I didn't bother creating a separate patch
From: Florian Zumbiehl <[EMAIL PROTECTED]>
Date: Sun, 29 Jul 2007 08:04:23 +0200
> Hi,
>
> I'm not sure whether this is really worth it, but it looked so
> extremely inefficient that I couldn't resist - so let's hope providers
> will keep PPPoE around for a while, at least until terabit dsl ;-)
>
On Mon, 30 Jul 2007, Andrew Morton wrote:
> On Mon, 30 Jul 2007 08:19:10 +0530
> Satyam Sharma <[EMAIL PROTECTED]> wrote:
>
> > +/*
> > + * Wrapper over simple_strtol (base 10) with sanity and range checking.
> > + * We return (signed) long only because we may want to return errors.
> > + * Do
From: "Michael Chan" <[EMAIL PROTECTED]>
Date: Thu, 26 Jul 2007 14:38:09 -0700
> If the driver wants a simple solution, it can do what you did in the
> patch: wrap the tx cleanup code with netif_tx_lock() and
> netif_tx_unlock().
>
> If a NAPI driver wants to be more clever, it can do something
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]>
Date: Thu, 26 Jul 2007 13:34:52 -0500 (CDT)
> In article <[EMAIL PROTECTED]> (at Wed, 25 Jul 2007 19:49:09 -0400), Dave
> Johnson <[EMAIL PROTECTED]> says:
>
> > ipv6_addr_type() doesn't check for 'Unique Local IPv6 Unicast
> > Addresses' (RFC41
On Mon, 30 Jul 2007, Andrew Morton wrote:
> On Mon, 30 Jul 2007 08:17:41 +0530
> Satyam Sharma <[EMAIL PROTECTED]> wrote:
>
> > [0/9] netconsole: Multiple targets and dynamic reconfigurability
> >
> > This is v3 of the patchset
>
> That all looks pretty reasonable, thanks.
>
> Are we all com
> -Original Message-
> From: David Miller [mailto:[EMAIL PROTECTED]
> Sent: Monday, July 30, 2007 5:14 PM
> To: Waskiewicz Jr, Peter P
> Cc: netdev@vger.kernel.org; [EMAIL PROTECTED]
> Subject: Re: [FIX] NET: Fix sch_api and sch_prio to properly
> set and detect the root qdisc
>
> From:
From: "Waskiewicz Jr, Peter P" <[EMAIL PROTECTED]>
Date: Fri, 27 Jul 2007 09:22:11 -0700
> Are these queued for 2.6.24, or are they going to make it into
> 2.6.23? I know you're busy with patches and NAPI, but I was
> curious. Thanks!
I've applied both fixes and will push them into 2.6.23
On Mon, 30 Jul 2007 08:19:10 +0530
Satyam Sharma <[EMAIL PROTECTED]> wrote:
> +/*
> + * Wrapper over simple_strtol (base 10) with sanity and range checking.
> + * We return (signed) long only because we may want to return errors.
> + * Do not use this to convert numbers that are allowed to be nega
On Mon, 30 Jul 2007 08:17:41 +0530
Satyam Sharma <[EMAIL PROTECTED]> wrote:
> [0/9] netconsole: Multiple targets and dynamic reconfigurability
>
> This is v3 of the patchset
That all looks pretty reasonable, thanks.
Are we all comfortable with the attributions? As I have it now, everything
wil
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 26 Jul 2007 17:09:40 +0800
> [IPV6]: Remove circular dependency on if_inet6.h
>
> net/if_inet6.h includes linux/ipv6.h which also tries to include
> net/if_inet6.h. Since the latter only needs it for forward
> declarations, we can fix this by addin
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 26 Jul 2007 17:09:38 +0800
> [IPV4/IPV6]: Fail registration if inet device construction fails
>
> Now that netdev notifications can fail, we can use this to signal
> errors during registration for IPv4/IPv6. In particular, if we
> fail to allocate
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 26 Jul 2007 17:09:36 +0800
> [NET]: Allow netdev REGISTER/CHANGENAME events to fail
>
> This patch adds code to allow errors to be passed up from event
> handlers of NETDEV_REGISTER and NETDEV_CHANGENAME. It also adds
> the notifier_from_errno/noti
David Miller wrote:
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Mon, 30 Jul 2007 12:17:58 -0400
David, thoughts on merging? I'm not We could stick this into your tree
or mine. Whether yours or mine, I would like to keep the driver and
net-core patches together in the same git tree.
No obje
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 26 Jul 2007 17:09:33 +0800
> [NET] loopback: Panic if registration fails
>
> Because IPv4 and IPv6 both depend on the presence of the loopback device
> to function, failure in registration the loopback device should be fatal.
>
> Signed-off-by: Her
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 26 Jul 2007 17:09:30 +0800
> [NET]: Take dev_base_lock when moving device name hash list entry
>
> When we added name-based hashing the dev_base_lock was designated as the
> lock to take when changing the name hash list. Unfortunately, because
> it
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 26 Jul 2007 17:09:08 +0800
> [NET]: Call uninit if necessary in register_netdevice
>
> This patch makes register_netdevice call dev->uninit if the regsitration
> fails after dev->init has completed successfully. Very few drivers use
> the init/unin
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 26 Jul 2007 16:59:39 +0800
> [IPVS]: Use skb_forward_csum
>
> As a path that forwards packets, IPVS should be using
> skb_forward_csum instead of directly setting ip_summed
> to CHECKSUM_NONE.
>
> Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
Patc
From: Joe Perches <[EMAIL PROTECTED]>
Date: Wed, 18 Jul 2007 16:21:00 -0700
> On Wed, 2007-07-18 at 15:49 -0700, David Miller wrote:
> > From: Joe Perches <[EMAIL PROTECTED]>
> > Date: Wed, 18 Jul 2007 15:14:13 -0700
> >
> > > -#define VERSION "pktgen v2.68: Packet Generator for packet performan
From: Roland Dreier <[EMAIL PROTECTED]>
Date: Mon, 30 Jul 2007 08:04:24 -0700
> IPoIB can cope but it really seems like an unfortunate feature of
> these changes that we can't do something like what we have today,
> which imposes no overhead unless an event actually lands in the race
> window.
It
On Mon, 30 Jul 2007, Jeff Garzik wrote:
> true, we should just remove the dev==NULL check
Patch below:
[PATCH] nmclan_cs: Remove bogus (dev==NULL) check in mace_interrupt()
The (dev == NULL) check in drivers/net/pcmcia/nmclan_cs.c:mace_interrupt()
handler is always false, so let's remove it.
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Mon, 30 Jul 2007 12:17:58 -0400
> David, thoughts on merging? I'm not We could stick this into your tree
> or mine. Whether yours or mine, I would like to keep the driver and
> net-core patches together in the same git tree.
No objections and I'll s
true, we should just remove the dev==NULL check
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jeff,
On Mon, 30 Jul 2007, Jeff Garzik wrote:
> Fix a potential NULL pointer dereference in mace_interrupt() in
> drivers/net/pcmcia/nmclan_cs.c
This oops is _programmatically_ impossible (the only way it can occur
is if the kernel has gone bazooka already anyway ...)
[ BTW even if i
Sasa Ostrouska wrote:
[ added netdev to CC ]
> Hi people,
>
> I'm using this on a x86-64 amd machine. During boot of the last
> 2.6.22.1 kernel I get this error:
>
> fb0: VESA VGA frame buffer device
> Linux agpgart interface v0.102 (c) Dave Jones
> Serial: 8250/16550 driver $Revision: 1.90 $ 4 p
All are fixes except the two "S2IO: Remove ...from the driver" patches,
which remove two unused features, and a couple doc patches.
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-linus
to receive the following updates:
MA
> 1. When bonding enslaves an IPoIB device the bonding neighbor holds a
> reference to a cleanup function in the IPoIB drives. This makes it unsafe to
> unload the IPoIB module if there are bonding neighbors in the air. So, to
> avoid this race one must unload bonding before unloading IPoIB.
On Mon, 30 Jul 2007 13:37:20 -0700
"Javier Cardona" <[EMAIL PROTECTED]> wrote:
> Hi Stephen,
>
> On 7/27/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote:
> > In this case perhaps you can have a table that maps skb->priority to
> > mesh ttl? priorty can already by handled by existing setsockopt ca
> On 7/26/07, David Miller <[EMAIL PROTECTED]> wrote:
> > From: Shannon Nelson <[EMAIL PROTECTED]>
> > Date: Tue, 24 Jul 2007 17:36:06 -0700
> >
> > > (repost - original eaten by vger?)
> > >
> > > Al Viro pointed out that dma_memcpy_to_kernel_iovec() really was
> > > unreachable and thus unused.
Jan-Bernd Themann wrote:
Hi,
this patch set contains the latest generic LRO code, a Kconfig / Makefile
and an eHEA patch demonstrating how the "aggregate SKB" interface has to
to be used.
Drew, could you provide a patch for the myri10ge driver to show how the
"receive in page" interface works?
Hi Stephen,
On 7/27/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote:
> In this case perhaps you can have a table that maps skb->priority to
> mesh ttl? priorty can already by handled by existing setsockopt calls,
> and modified by netfilter and QoS managements.
Thanks for the feedback. IMHO over
Moni Shoua <[EMAIL PROTECTED]> wrote:
>Delay sending a gratuitous_arp when LINK_STATE_LINKWATCH_PENDING bit
>in dev->state field is on. This improves the chances for the arp packet to
>be transmitted.
Under what circumstances were you seeing problems that delaying
the gratuitous ARP unti
ugh, missed these before my last merge...
anyway:
why do we want to parameters writable? a good changelog tells me
what, why and how, and this changelog just covered the "what". Also,
I assume you've checked that it's OK for these variables to change at
any time?
-
To unsubscribe from this list
Ralf Baechle wrote:
Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]>
applied to #upstream (2.6.24)
I've previously sent out this patch a long time ago. At that time I was
told NETIF_F_IP_CSUM wouldn't make any sense without NETIF_F_SG. IOC3's
S/G abilities are very limited; it can do upto t
Denis Cheng wrote:
Cc: [EMAIL PROTECTED]
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/cxgb3_main.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
applied
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [
Could someone add this to:
http://linux-net.osdl.org Wiki?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Micah Gruber wrote:
This patch fixes a potential null dereference bug where we dereference
DEV before a null check. This patch simply moves the dereferencing after
the null check.
Signed-off-by: Micah Gruber <[EMAIL PROTECTED]>
applied (git-am worked!)
-
To unsubscribe from this list: send
Ramkrishna Vepa wrote:
- Mask single and double bit ETQ ecc errors to inhibit spurious interrupts.
(Resending; Removed HTML sections in the patch)
Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]>
applied 1-3
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body
Veena Parat wrote:
- Removed 3 buffer mode support from driver - unused feature
- Incorporated Jeff Garzik's comments on elimination of inline typecasting
- Code cleanup : Removed a few extra spaces
Signed-off-by: Veena Parat <[EMAIL PROTECTED]>
applied 1-4
-
To unsubscribe from this list
Dhananjay Phadke wrote:
Some leftover code that makes use of adapter->lock in tx_timeout function,
which resets the interface under this lock. In close() when the workqueue
is flushed, prints the warning about sleeping with interrupts disabled
(when spinlock debug is enabled). The lock was requir
[EMAIL PROTECTED] wrote:
This is a workaround for firmware bug with 2nd port of multiport adapter,
where MAC address is reset. Driver just needs to overwrite it with the
value read from PROM.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
applied 1-2
-
To unsubscribe from this list: sen
Ayaz Abdulla wrote:
Resending:
In older chipsets, the mac address was stored in reversed order.
However, in newer chipsets, the mac address is in correct order. This
patch takes those newer chipsets into account and does not rely on a
special bit setup by BIOS'.
Signed-Off-By: Ayaz Abdulla <[EM
Valerie Henson wrote:
Remove Val Henson as tulip maintainer and let her roam free, FREE!
Signed-off-by: Val Henson <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger
Jarek Poplawski wrote:
Hi,
Very below is my patch proposal with a comment, which in my opinion
is precious enough to save it for future help in reading and
understanding the code.
I hope Alan will not blame me I've not asked for his permission before
sending, and he would ack this patch as it i
Kumar Gala wrote:
Fix the following modpost warning:
WARNING: vmlinux.o(.init.text+0x1aa6c): Section mismatch: reference to
.exit.text:gfar_mdio_exit (between 'gfar_init' and 'gfar_mdio_init')
Signed-off-by: Kumar Gala <[EMAIL PROTECTED]>
---
drivers/net/gianfar_mii.c |2 +-
drivers/net/g
Micah Gruber wrote:
This patch fixes a potential null dereference bug where we dereference
pegasus before a null check. This patch simply moves the dereferencing
after the null check.
Signed-off-by: Micah Gruber <[EMAIL PROTECTED]>
---
--- a/drivers/net/usb/pegasus.c
+++ b/drivers/net/usb/pe
On Mon, Jul 30, 2007 at 01:04:13PM -0600, Valerie Henson wrote:
> The Tulip network driver needs a new maintainer! I no longer have
> time to maintain the Tulip network driver and I'm stepping down. Jeff
> Garzik would be happy to get volunteers.
>
Since I already take care of a major consumer
(No longer maintainer, btw.)
What situation have you tested this under? Thanks,
-VAL
On Tue, Jul 24, 2007 at 11:49:08AM +0400, Denis V. Lunev wrote:
> Calling flush_scheduled_work() may deadlock if called under rtnl_lock
> (from dev->stop) as linkwatch_event() may be on the workqueue and it wil
Remove Val Henson as tulip maintainer and let her roam free, FREE!
Signed-off-by: Val Henson <[EMAIL PROTECTED]>
--- linux-2.6.orig/MAINTAINERS
+++ linux-2.6/MAINTAINERS
@@ -3569,11 +3569,9 @@ W: http://www.auk.cx/tms380tr/
S: Maintained
TULIP NETWORK DRIVER
-P: Valerie Henson
-
The Tulip network driver needs a new maintainer! I no longer have
time to maintain the Tulip network driver and I'm stepping down. Jeff
Garzik would be happy to get volunteers.
The only current major outstanding patch I know of is Grant's shutdown
race patch, which was incorrectly dropped as obs
On Mon, 2007-07-30 at 11:27 +0200, Erik Slagter wrote:
> They are either garbled are they are not passed on the wire. The
> transmitted packets are shown by tshark, but a tshark run on "the other
> end of the line" does not show them.
>
> Platform is indeed x86, to be precise: fedora 7, kernel 2.
Hi Peter,
> What's the problem with Dustin's driver? It seems to work fine here
> with a lan9117. Why not just add lan921x support to the existing
> driver?
I have heard Dustin's driver works very well on PXA, but on others it
doesn't even compile (hence why it depends on ARCH_PXA).
Dustin's dr
On Mon, Jul 30, 2007 at 08:09:53PM +0530, pravin wrote:
> comments?
please avoid using plain sendmsg/recvmsg from kernelspace. Adding these
segment checks is more than a bad hack and not something that should
clutter up fasthpathes. Add to that problems with kthreads vs blocking
recvmsg and you
Here is a quick reply before something more official can
be written up:
Linas Vepstas wrote:
> -- what is LRO?
Large Receive Offload
> -- Basic principles of operation?
LRO is analogous to a receive side version of TSO. The NIC (or
driver) merges several consecutive segments from the same c
It's possible that new SACK blocks that should trigger new LOST
markings arrive with new data (which previously made is_dupack
false). In addition, I think this fixes a case where we get
a cumulative ACK with enough SACK blocks to trigger the fast
recovery (is_dupack would be false there too).
I'
Hi Dave,
While testing frto with bidirection TCP a while (months) ago, I
encountered time-seq graphs which made absolutely no sense as if
recoveries only completed after RTO. As a result, I noticed that
rate-halving has problem when a flow is bidirection but testing the
patch has been on my tod
Actually, the ratehalving seems to work too well, as cwnd is
reduced on every second ACK even though the packets in flight
remains unchanged. Recoveries in a bidirectional flows suffer
quite badly because of this, both NewReno and SACK are affected.
After this patch, rate halving is performed for
On Thu, Jul 26, 2007 at 09:56:30PM -0700, Andrew Morton wrote:
> On Thu, 26 Jul 2007 08:44:21 -0700 "Paul E. McKenney" <[EMAIL PROTECTED]>
> wrote:
>
> > On Thu, Jul 26, 2007 at 11:49:42AM +0100, Stephen Hemminger wrote:
> > > Whitespace cleanup run code through lindent then cleanup results.
> >
Jeff Garzik wrote:
Stephen Hemminger wrote:
Why make this a user selectable option at all? Unless you want
to deal with out of tree drivers (not my problem), it should be hidden
to avoid having to explain an support it.
In this case it's an optional library kernel module. That seems to be a
On Mon, Jul 30, 2007 at 05:24:33PM +0200, Jan-Bernd Themann wrote:
>
> Changes to http://www.spinics.net/lists/netdev/msg36912.html
>
> 1) A new field called "features" has been added to the net_lro_mgr struct.
>It is set by the driver to indicate:
>- LRO_F_NAPI:Use NAPI / net
Jan-Bernd Themann wrote:
Added LRO support using the "SKB aggregate" interface
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]>
---
drivers/net/ehea/ehea.h |9 -
drivers/net/ehea/ehea_ethtool.c | 15 +++
drivers/net/ehea/ehea_main.c| 82 +
Stephen Hemminger wrote:
Why make this a user selectable option at all? Unless you want
to deal with out of tree drivers (not my problem), it should be hidden
to avoid having to explain an support it.
In this case it's an optional library kernel module. That seems to be a
common setup for li
1 - 100 of 138 matches
Mail list logo
