On Mon, 30 Jul 2007, David Miller wrote: > From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> > Date: Mon, 30 Jul 2007 20:18:45 +0300 (EEST) > > > Actually, the ratehalving seems to work too well, as cwnd is > > reduced on every second ACK even though the packets in flight > > remains unchanged. Recoveries in a bidirectional flows suffer > > quite badly because of this, both NewReno and SACK are affected. > > > > After this patch, rate halving is performed for ACK only if > > packets in flight was supposedly changed too. > > > > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> > > This fix looks great, and I see no potential problems with > Reno after doing a bit of auditing. > > Applied and I'll push to -stable too.
I think it's probably good to add tp->snd_una != prior_snd_una check there too... It's not going to make a large difference, mostly just to be conservative when skb collapse stuff got done (and maybe to annoy cheaters too though I couldn't at this point figure out how they could abuse it)... ...I think I can come up with that on Wednesday, so please hold stable push until that. -- i.
