Re: drivers/net/xen-netfront.c: bogus code

Adrian Bunk wrote: > The Coverity checker spotted the following bogus code > in drivers/net/xen-netfront.c: > > <-- snip --> > > ... > static void xennet_alloc_rx_buffers(struct net_device *dev) > { > ... > for (nr_flips = i = 0; ; i++) { > skb = __skb_dequeue(&np->rx_batc

[PATCH 2.6.22 4/4]S2IO: Implementing review comments from old patches

- Incorporated Jeff Garzik's comments on coding standards Signed-off-by: Veena Parat <[EMAIL PROTECTED]> --- diff -urpN patch_3/drivers/net/s2io.c patch_4/drivers/net/s2io.c --- patch_3/drivers/net/s2io.c 2007-07-19 17:44:54.0 +0530 +++ patch_4/drivers/net/s2io.c 2007-07-19 17:45:41.000

[PATCH 2.6.22 3/4]S2IO: Checking for the return value of pci map function

- Checking for the return value of pci map function - Implemented Francois Romieu's comments on eliminating code duplication using goto - Implemented Francois Romieu's comments on using a temporary variable for accessing statistics structure Signed-off-by: Veena Parat <[EMAIL PROTECTED]>

RE: [PATCH 2.6.22 1/4]S2IO: Removing MSI support from driver

Hi, The patch number is incorrect in the below mail. It should be [PATCH 2.6.22 2/4] instead of [PATCH 2.6.22 1/4]. Pls consider it as the second patch in this series. Sorry for the inconvenience. Regards Veena -Original Message- From: Veena Parat [mailto:[EMAIL PROTECTED] Sent: Monday

Re: [PATCH 02/10] Networking include file changes.

Hi Sridhar, Sridhar Samudrala <[EMAIL PROTECTED]> wrote on 07/23/2007 11:29:39 AM: > Krishna Kumar2 wrote: > > Hi Sridhar, > > > > Sridhar Samudrala <[EMAIL PROTECTED]> wrote on 07/20/2007 10:55:05 PM: > >>> diff -ruNp org/include/net/pkt_sched.h new/include/net/pkt_sched.h > >>> --- org/include/

[PATCH 2.6.22 1/4]S2IO: Removing MSI support from driver

- Removed MSI support from driver - unused feature - Replaced request_mem_region with pci_request_regions Signed-off-by: Veena Parat <[EMAIL PROTECTED]> --- diff -urpN patch_1/drivers/net/s2io.c patch_2/drivers/net/s2io.c --- patch_1/drivers/net/s2io.c 2007-07-19 14:20:53.0 +0530 +++ p

[PATCH 2.6.22 1/4]S2IO: Removing 3 buffer mode support from the driver

- Removed 3 buffer mode support from driver - unused feature - Incorporated Jeff Garzik's comments on elimination of inline typecasting - Code cleanup : Removed a few extra spaces Signed-off-by: Veena Parat <[EMAIL PROTECTED]> --- diff -urpN org/drivers/net/s2io.c patch_1/drivers/net/s2io.c ---

Re: [PATCH 02/10] Networking include file changes.

Krishna Kumar2 wrote: Hi Sridhar, Sridhar Samudrala <[EMAIL PROTECTED]> wrote on 07/20/2007 10:55:05 PM: diff -ruNp org/include/net/pkt_sched.h new/include/net/pkt_sched.h --- org/include/net/pkt_sched.h 2007-07-20 07:49:28.0 +0530 +++ new/include/net/pkt_sched.h 2007-07-20 08:30:22

Re: 2.6.20->2.6.21 - networking dies after random time

Ok, I've bisected this problem and found that this patch broke my NIC: 76d2160147f43f982dfe881404cfde9fd0a9da21 is first bad commit commit 76d2160147f43f982dfe881404cfde9fd0a9da21 Author: Ingo Molnar <[EMAIL PROTECTED]> Date: Fri Feb 16 01:28:24 2007 -0800 [PATCH] genirq: do not mask interr

Re: [PATCH 00/10] Implement batching skb API

Hi Jamal, J Hadi Salim <[EMAIL PROTECTED]> wrote on 07/22/2007 06:21:09 PM: > My concern is there is no consistency in results. I see improvements on > something which you say dont. You see improvement in something that > Evgeniy doesnt etc. Hmmm ? Evgeniy has not even tested my code to find som

[PATCH 4/4] Initialize and fill IPv6 route age

The age field of the ipv6 route structures are initilized with the current timeval at the time of route creation. When the route dump is called the route age value stored in the structure is subtracted from the present timeval and the difference is passed on as the route age. Signed-o

[PATCH 3/4] Initilize and populate age field

The age field is filled with the current time at the time of creation of the route. When the routes are dumped then the age value stored in the route structure is subtracted from the current time value and the difference is the age expressed in secs. Signed-off-by: Varun Chandramohan <[EMAIL PRO

[PATCH 2/4] Add new timeval_to_sec function

A new function for converting timeval to time_t is added in time.h. Its a common function used in different places. Signed-off-by: Varun Chandramohan <[EMAIL PROTECTED]> --- include/linux/time.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/include/linux/tim

[PATCH 1/4] New attribute RTA_AGE

A new attribute RTA_AGE is added for the age value to be exported to userlevel using netlink Signed-off-by: Varun Chandramohan <[EMAIL PROTECTED]> --- include/linux/rtnetlink.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/rtnetlink.h b/include/linux/rtne

[PATCH 0/4] Age Entry For IPv4 & IPv6 Route Table

Hi, According to the RFC 4292 (IP Forwarding Table MIB) there is a need for an age entry for all the routes in therouting table. The entry in the RFC is inetCidrRouteAge and oid is inetCidrRouteAge.1.10. Many snmp application require this age entry. So iam adding the age field in the routing ta

Re: [PATCH 00/10] Implement batching skb API

Hi Evgeniy, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote on 07/20/2007 06:24:23 PM: > Hi Krishna. > > On Fri, Jul 20, 2007 at 12:01:49PM +0530, Krishna Kumar ([EMAIL PROTECTED]) wrote: > > After fine-tuning qdisc and other changes, I modified IPoIB to use this API, > > and now get good gains. Summa

Re: [PATCH 02/12 -Rev2] Changes to netdevice.h

Hi Patrick, Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/22/2007 10:36:51 PM: > Krishna Kumar wrote: > > @@ -472,6 +474,9 @@ struct net_device > > void *priv; /* pointer to private data */ > > int (*hard_start_xmit) (struct sk_buff *skb, > >s

Re: [PATCH 06/12 -Rev2] rtnetlink changes.

Hi Patrick, Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/22/2007 10:40:37 PM: > Krishna Kumar wrote: > > diff -ruNp org/include/linux/if_link.h rev2/include/linux/if_link.h > > --- org/include/linux/if_link.h 2007-07-20 16:33:35.0 +0530 > > +++ rev2/include/linux/if_link.h 2007-07-

Re: [PATCH 11/12 -Rev2] IPoIB xmit API addition

Hi Micheal, "Michael S. Tsirkin" <[EMAIL PROTECTED]> wrote on 07/22/2007 03:11:36 PM: > > + /* > > +* Handle skbs completion from tx_tail to wr_id. It is possible to > > +* handle WC's from earlier post_sends (possible multiple) in this > > +* iteration as we move from tx_tail to wr

Re: [PATCH] [IrDA] KS959 USB IrDA dongle support

From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Mon, 23 Jul 2007 00:32:17 +0300 > Last IrDA patch for 2.6.23-rc1, if it's not too late... Too late, Linus just closed the merge window, you had two weeks to submit this :-) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body

net/bluetooth/rfcomm/tty.c: use-after-free

Commit 8de0a15483b357d0f0b821330ec84d1660cadc4e added the following use-after-free in net/bluetooth/rfcomm/tty.c: <-- snip --> ... static int rfcomm_dev_add(struct rfcomm_dev_req *req, struct rfcomm_dlc *dlc) { ... if (IS_ERR(dev->tty_dev)) { list_del(&dev->list);

net/9p/mux.c: use-after-free

The Coverity checker spotted the following use-after-free in net/9p/mux.c: <-- snip --> ... struct p9_conn *p9_conn_create(struct p9_transport *trans, int msize, unsigned char *extended) { ... if (!m->tagpool) { kfree(m);

drivers/net/xen-netfront.c: bogus code

The Coverity checker spotted the following bogus code in drivers/net/xen-netfront.c: <-- snip --> ... static void xennet_alloc_rx_buffers(struct net_device *dev) { ... for (nr_flips = i = 0; ; i++) { skb = __skb_dequeue(&np->rx_batch); if (skb == NULL)

Re: NFS mount gives ENETDOWN in -git15

On 7/21/07, Andi Kleen <[EMAIL PROTECTED]> wrote: I tried to mount another nfs mount on a system running with nfsroot. But I get # mount basil:/home /basil/home/ mount: Network is down The network is not down of course, the system is happily running with nfs root from that server. Userland is

[PATCH] [IrDA] KS959 USB IrDA dongle support

Hi Dave, Last IrDA patch for 2.6.23-rc1, if it's not too late... This patch adds support for the KingSun KS-959 USB IrDA dongle. This dongle does not follow the usb-irda specification, so it needs its own special driver. First, it uses control URBs for data transfer, instead of bulk or interrupt

RE: [PATCH] NET: Fix sch_prio to detect the root qdisc loading

> As explained in my last mail, sch->parent is an integer. And > it is set when grafting the qdisc, not on initilization, so > it is always 0 here when coming from prio_init. > > This untested patch should make sure its always set correctly. Yes, I'm using NULL and 0 interchangeably here, sinc

bug in tcp/ip stack

I tracked down something that appears to be a small bug in networking code. The way in witch i can reproduce it a complex one but it works 100%, so here comes the details: I noticed strange packets on my fw coming from mail server with RST/ACK flags set coming from source port with no one list

netlink messages on 'ip l s down' event

hello, I noticed that ipv4 subsystem sends RTM_NEWLINK message with new flags on 'ip l s down' event, but ipv6 subsystem sends RTM_DELLINK message. Is it inconsistency or feature? If it is inconsistency, which approach will be used in future? (tested kernels 2.6.20,21,22) Thanks for reply. regar

Re: NFS mount gives ENETDOWN in -git15

On Sat, 2007-07-21 at 15:31 +0200, Andi Kleen wrote: > I tried to mount another nfs mount on a system running with nfsroot. > But I get > > # mount basil:/home /basil/home/ > mount: Network is down > > The network is not down of course, the system is happily running with nfs > root from that > s

Re: [PATCH 06/12 -Rev2] rtnetlink changes.

Krishna Kumar wrote: > diff -ruNp org/include/linux/if_link.h rev2/include/linux/if_link.h > --- org/include/linux/if_link.h 2007-07-20 16:33:35.0 +0530 > +++ rev2/include/linux/if_link.h 2007-07-20 16:35:08.0 +0530 > @@ -78,6 +78,8 @@ enum > IFLA_LINKMODE, >

Re: [PATCH 02/12 -Rev2] Changes to netdevice.h

Krishna Kumar wrote: > @@ -472,6 +474,9 @@ struct net_device > void*priv; /* pointer to private data */ > int (*hard_start_xmit) (struct sk_buff *skb, > struct net_device *dev); > + int

Re: [ofa-general] Re: [PATCH 05/10] sch_generic.c changes.

Krishna Kumar2 wrote: > Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 11:46:36 PM: > >>The check for tx_queue_len is wrong though, >>its only a default which can be overriden and some qdiscs don't >>care for it at all. > > > I think it should not matter whether qdiscs use this or not,

[PATCH] Fix irlan_eth.c - unused variable 'in_dev' warning

Hi, I got this warning on current git: ... net/irda/irlan/irlan_eth.c: In function 'irlan_eth_send_gratuitous_arp': net/irda/irlan/irlan_eth.c:301: warning: unused variable 'in_dev' ... This is because CONFIG_INET is not set in my config. Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTED]

Re: [PATCH] NET: Fix sch_prio to detect the root qdisc loading

PJ Waskiewicz wrote: > The sch->parent handle will be NULL for the scheduler that is TC_H_ROOT. > Change this check in prio_tune() so that only the root qdisc can be > multiqueue-enabled. > > Signed-off-by: Peter P Waskiewicz Jr <[EMAIL PROTECTED]> > --- > > net/sched/sch_prio.c |6 -- >

Re: Question: how to detect if a qdisc is root or not?

Waskiewicz Jr, Peter P wrote: >>I dont think I understand. Whats the problem with setting >>sch->parent on initialization instead on grafting as I did in >>my example patch? >>Please explain the problems arrising on unload in detail. > > > sch->parent is getting set on initialization, and for t

Re: checksum of lsrr

Hello, From: Ken-ichirou MATSUZAWA <[EMAIL PROTECTED]> Subject: checksum of lsrr Date: Wed, 04 Jul 2007 22:28:24 +0900 (JST) > if we change destination address, we need recompute not only ip > checksum but also tcp's, don't we? I was ashamed of myself for much confused. My simple story is:

Re: [PATCH 00/10] Implement batching skb API

KK, On Sun, 2007-22-07 at 11:57 +0530, Krishna Kumar2 wrote: > Batching need not be useful for every hardware. My concern is there is no consistency in results. I see improvements on something which you say dont. You see improvement in something that Evgeniy doesnt etc. There are many knobs an

Re: tg3 issues

patric wrote: Hi, Think i got something working for me at least, and the fix is quite minimal and only downside that i could see from it was that you might get a small delay when bringing up the interface, but that's probably better than getting a non-functional interface that reports that i

[RTNETLINK]: Fix warning if !CONFIG_KMOD

replay label is unused otherwise. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6/net/core/rtnetlink.c === --- net-2.6.orig/net/core/rtnetlink.c 2007-07-22 11:41:46.0 +0200 +++ net-2.6/net/core/rtnetlink.c

[NEIGH]: Combine neighbour cleanup and release

Introduces neigh_cleanup_and_release() to be used after a neighbour has been removed from its neighbour table. Serves as preparation to add event notifications. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6/net/core/neighbour.c =

[NEIGH]: Netlink notifications

Currently neighbour event notifications are limited to update notifications and only sent if the ARP daemon is enabled. This patch extends the existing notification code by also reporting neighbours being removed due to gc or administratively and removes the dependency on the ARP daemon. This allow

Re: [PATCH] CONFIG_NET=n - lots of link time errors

On Jul 21 2007 19:12, David Miller wrote: >> Enabling drivers from "Devices > Networking" (in menuconfig), for >> example SLIP and/or PLIP, throws link time errors when CONFIG_NET itself >> is =n. Have CONFIG_NETDEVICES depend on CONFIG_NET. >> >> Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED

Re: [PATCH 11/12 -Rev2] IPoIB xmit API addition

> + /* > + * Handle skbs completion from tx_tail to wr_id. It is possible to > + * handle WC's from earlier post_sends (possible multiple) in this > + * iteration as we move from tx_tail to wr_id, since if the last > + * WR (which is the one which had a completion request) f

[PATCH 12/12 -Rev2] IPoIB xmit internals changes (ipoib_ib.c)

diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib_main.c rev2/drivers/infiniband/ulp/ipoib/ipoib_main.c --- org/drivers/infiniband/ulp/ipoib/ipoib_main.c 2007-07-20 07:49:28.0 +0530 +++ rev2/drivers/infiniband/ulp/ipoib/ipoib_main.c 2007-07-22 00:08:28.0 +0530 @@ -558,

[PATCH 09/12 -Rev2] IPoIB verbs changes

diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib_verbs.c rev2/drivers/infiniband/ulp/ipoib/ipoib_verbs.c --- org/drivers/infiniband/ulp/ipoib/ipoib_verbs.c 2007-07-20 07:49:28.0 +0530 +++ rev2/drivers/infiniband/ulp/ipoib/ipoib_verbs.c 2007-07-20 16:09:45.0 +0530 @@ -15

[PATCH 10/12 -Rev2] IPoIB multicast, CM changes

diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib_cm.c rev2/drivers/infiniband/ulp/ipoib/ipoib_cm.c --- org/drivers/infiniband/ulp/ipoib/ipoib_cm.c 2007-07-20 07:49:28.0 +0530 +++ rev2/drivers/infiniband/ulp/ipoib/ipoib_cm.c2007-07-20 16:09:45.0 +0530 @@ -493,14 +493,19 @

[PATCH 11/12 -Rev2] IPoIB xmit API addition

diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib_ib.c rev2/drivers/infiniband/ulp/ipoib/ipoib_ib.c --- org/drivers/infiniband/ulp/ipoib/ipoib_ib.c 2007-07-20 07:49:28.0 +0530 +++ rev2/drivers/infiniband/ulp/ipoib/ipoib_ib.c2007-07-22 00:08:37.0 +0530 @@ -242,8 +242,9 @@

[PATCH 08/12 -Rev2] IPoIB include file changes.

diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib.h rev2/drivers/infiniband/ulp/ipoib/ipoib.h --- org/drivers/infiniband/ulp/ipoib/ipoib.h2007-07-20 07:49:28.0 +0530 +++ rev2/drivers/infiniband/ulp/ipoib/ipoib.h 2007-07-20 16:09:45.0 +0530 @@ -269,8 +269,8 @@ struct ipoib_d

[PATCH 06/12 -Rev2] rtnetlink changes.

diff -ruNp org/include/linux/if_link.h rev2/include/linux/if_link.h --- org/include/linux/if_link.h 2007-07-20 16:33:35.0 +0530 +++ rev2/include/linux/if_link.h2007-07-20 16:35:08.0 +0530 @@ -78,6 +78,8 @@ enum IFLA_LINKMODE, IFLA_LINKINFO, #define IFLA_LINK

[PATCH 07/12 -Rev2] Change qdisc_run & qdisc_restart API, callers

diff -ruNp org/include/net/pkt_sched.h rev2/include/net/pkt_sched.h --- org/include/net/pkt_sched.h 2007-07-20 07:49:28.0 +0530 +++ rev2/include/net/pkt_sched.h2007-07-20 16:09:45.0 +0530 @@ -80,13 +80,13 @@ extern struct qdisc_rate_table *qdisc_ge struct rta

[PATCH 03/12 -Rev2] dev.c changes.

diff -ruNp org/net/core/dev.c rev2/net/core/dev.c --- org/net/core/dev.c 2007-07-20 07:49:28.0 +0530 +++ rev2/net/core/dev.c 2007-07-21 23:08:33.0 +0530 @@ -875,6 +875,48 @@ void netdev_state_change(struct net_devi } } +/* + * dev_change_tx_batching - Enable or disable b

[PATCH 04/12 -Rev2] Ethtool changes

diff -ruNp org/include/linux/ethtool.h rev2/include/linux/ethtool.h --- org/include/linux/ethtool.h 2007-07-21 13:39:50.0 +0530 +++ rev2/include/linux/ethtool.h2007-07-21 13:40:57.0 +0530 @@ -414,6 +414,8 @@ struct ethtool_ops { #define ETHTOOL_SUFO 0x0022 /*

[PATCH 05/12 -Rev2] sysfs changes.

diff -ruNp org/net/core/net-sysfs.c rev2/net/core/net-sysfs.c --- org/net/core/net-sysfs.c2007-07-20 07:49:28.0 +0530 +++ rev2/net/core/net-sysfs.c 2007-07-21 22:56:32.0 +0530 @@ -230,6 +230,21 @@ static ssize_t store_weight(struct devic return netdev_store(dev, attr,

[PATCH 01/12 -Rev2] HOWTO documentation for Batching SKB.

diff -ruNp org/Documentation/networking/Batching_skb_API.txt rev2/Documentation/networking/Batching_skb_API.txt --- org/Documentation/networking/Batching_skb_API.txt 1970-01-01 05:30:00.0 +0530 +++ rev2/Documentation/networking/Batching_skb_API.txt 2007-07-20 16:09:45.0 +0530

[PATCH 02/12 -Rev2] Changes to netdevice.h

diff -ruNp org/include/linux/netdevice.h rev2/include/linux/netdevice.h --- org/include/linux/netdevice.h 2007-07-20 07:49:28.0 +0530 +++ rev2/include/linux/netdevice.h 2007-07-22 13:20:16.0 +0530 @@ -340,6 +340,7 @@ struct net_device #define NETIF_F_VLAN_CHALLENGED

[PATCH 00/12 -Rev2] Implement batching skb API

This set of patches implements the batching API, and makes the following changes resulting from the review of the first set: Changes : - 1. Changed skb_blist from pointer to static as it saves only 12 bytes (i386), but bloats the code. 2. Removed requirement for driver to set "featur

Re: [PATCH]: Resurrect napi_poll patch.

From: Rusty Russell <[EMAIL PROTECTED]> Date: Sun, 22 Jul 2007 17:51:52 +1000 > On Sun, 2007-07-22 at 00:18 -0700, David Miller wrote: > > --- a/net/core/dev.c > > +++ b/net/core/dev.c > > @@ -220,7 +220,8 @@ static RAW_NOTIFIER_HEAD(netdev_chain); > > * Device drivers call our routines to queue

Re: [PATCH]: Resurrect napi_poll patch.

On Sun, 2007-07-22 at 00:18 -0700, David Miller wrote: > Rusty, how does it look otherwise? I like it. For a start, the simplification of the NAPI api was long overdue, and the damage done by separating the napi_struct is really minimal. Overall the tg3 driver just looks a little nicer now, and

Re: [PATCH]: Resurrect napi_poll patch.

From: David Miller <[EMAIL PROTECTED]> Date: Sun, 22 Jul 2007 00:18:18 -0700 (PDT) > To facilitate discussion I converted the core and tg3, and include > just that part of the patch below. And for those for whom it makes it easier to play around with these changes, here is the updated e1000 conve

Re: [PATCH]: Resurrect napi_poll patch.

From: David Miller <[EMAIL PROTECTED]> Date: Sat, 21 Jul 2007 20:54:25 -0700 (PDT) > Ok, I'll put the napi_struct info the driver private and respin > the patch. To facilitate discussion I converted the core and tg3, and include just that part of the patch below. Consequences: 1) rtnetlink and

Re: Races in net_rx_action vs netpoll?

From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 17:27:47 +0100 > Please revisit the requirements that netconsole needs and redesign > it from scratch. The existing code is causing too much breakage. > > Can it be done without breaking the semantics of network devices, or > shou