On Sun, 2007-07-22 at 00:18 -0700, David Miller wrote:
> Rusty, how does it look otherwise?
I like it. For a start, the simplification of the NAPI api was long
overdue, and the damage done by separating the napi_struct is really
minimal. Overall the tg3 driver just looks a little nicer now, and
that's sweet.
Unfortunately my complete ignorance of netpoll prevents me from making
sensible comment there. This seems to have slipped in tho:
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -220,7 +220,8 @@ static RAW_NOTIFIER_HEAD(netdev_chain);
> * Device drivers call our routines to queue packets here. We empty the
> * queue in the local softnet handler.
> */
> -DEFINE_PER_CPU(struct softnet_data, softnet_data) = { NULL };
> +
> +DEFINE_PER_CPU(struct softnet_data, softnet_data) = { NULL, };
>
> #ifdef CONFIG_SYSFS
> extern int netdev_sysfs_init(void);
ISTR that noone is using buggy compilers which required per-cpu
initializations now, so this can simply be dropped.
(The new scheduler code doesn't initialize per-cpu, so if this is a
problem it should be noticed).
Thanks!
Rusty.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
