Hi,
Replacing alloc_pages(gfp,0) with alloc_page(gfp) in net/ipv6/ip6_output.c
Signed-off-by: Shani Moideen <[EMAIL PROTECTED]>
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
index f508171..1d27779 100644
--- a/net/ipv6/ip6_output.c
+++ b/net/ipv6/ip6_output.c
@@ -1291,7 +1291,7
Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2
Signed-off-by: vignesh babu <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
index 1b20f40..a124b33 100644
--- a/drivers/net/cxgb3/cxgb3_main.c
+++ b/drivers/net/cxgb3
Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2
Signed-off-by: vignesh babu <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
index b53b7ad..89da958 100644
--- a/drivers/net/myri10ge/myri10ge.c
+++ b/drivers/net/my
Hi,
Replacing alloc_pages(gfp,0) with alloc_page(gfp) in
net/ipv4/ip_output.c.
Signed-off-by: Shani Moideen <[EMAIL PROTECTED]>
diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
index d6427d9..f9a87f6 100644
--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c
@@ -1003,7 +1003,7 @@ a
Sorry - i was distracted elsewhere and didnt respond to your
earlier email; this one seems a superset.
On Tue, 2007-12-06 at 02:58 +0200, Patrick McHardy wrote:
> jamal wrote:
> > On Mon, 2007-11-06 at 17:44 +0200, Patrick McHardy wrote:
[use case abbreviated..]
the use case is sensible.
> the q
On Mon, 2007-06-11 at 13:14 -0500, Linas Vepstas wrote:
> On Fri, Jun 08, 2007 at 01:20:20PM -0400, Jeff Garzik wrote:
> > On Fri, Jun 08, 2007 at 12:06:08PM -0500, Linas Vepstas wrote:
> > > On Fri, Jun 08, 2007 at 11:12:31AM +1000, Michael Ellerman wrote:
> > > > On Thu, 2007-06-07 at 14:17 -0500
From: Mattias Nissler <[EMAIL PROTECTED]>
mac80211 stops the tx queues during scans. This is wrong with respect
to the master deivce tx queue, since stopping it prevents any probes
from being sent during the scan. Instead, they accumulate in the queue
and are only sent after the scan is finished,
From: Larry Finger <[EMAIL PROTECTED]>
The initial rate for STA's using rc80211_simple is set to the last
rate in the rate table. For situations for which the signal is weak,
the rate may be too high for authentication and association. Although
the rc80211_simple module will adjust the speed, the
From: Larry Finger <[EMAIL PROTECTED]>
At present, transmission rate information for mac80211 is available only
if verbose debugging is turned on, and then only in the logs. This patch
implements the SIOCGIWRATE ioctl, which adds the current transmission rate to
the output of iwconfig.
Signed-off
From: Johannes Berg <[EMAIL PROTECTED]>
This patch fixes a typo in mac80211's debugfs.c.
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
Signed-off-by: John W. Linville <[EMAIL PROTECTED]>
---
net/mac80211/debugfs.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/m
From: David Lamparter <[EMAIL PROTECTED]>
Fix signedness mixup making mac addresses show up strangely
(like 00:11:22:33:44:ffaa) in /sys/class/ieee80211/*/macaddress.
Signed-off-by: David Lamparter <[EMAIL PROTECTED]>
Acked-by: Johannes Berg <[EMAIL PROTECTED]>
Signed-off-by: John W. Linville
Dave,
Here are a few mac80211 patches appropriate for 2.6.22.
Individual patches to follow, or you can pull at your leisure...
John
---
The following changes since commit 5ecd3100e695228ac5e0ce0e325e252c0f11806f:
Linus Torvalds (1):
Linux 2.6.22-rc4
are found in the git repository a
Dave,
Here are a few mac80211 patches appropriate for 2.6.23.
Individual patches to follow, or you can pull at your leisure...
John
---
The following changes since commit 5ecd3100e695228ac5e0ce0e325e252c0f11806f:
Linus Torvalds (1):
Linux 2.6.22-rc4
are found in the git repository a
jamal wrote:
> On Mon, 2007-11-06 at 17:44 +0200, Patrick McHardy wrote:
>
>>At this point the qdisc might send new packets. What do you do when a
>>packet for a full ring arrives?
>>
>
>
> Hrm... ok, is this a trick question or i am missing the obvious?;->
> What is wrong with what any driver w
A lot of netdevices implement their own variant of printk and use
use variations of dev_printk, printk or others that use msg_enable,
which has been an eyesore with countless variations across drivers.
This patch implements a standard ndev_printk and derivatives
such as ndev_err, ndev_info, ndev_w
A small update on the e1000
On Mon, 2007-11-06 at 09:52 -0400, jamal wrote:
> I have started writting a small howto for drivers. Hoping to get a wider
> testing with more drivers.
> So far i have changed e1000 and tun drivers as well as modified the
> packetgen tool to do batching.
>
> I wil
jamal wrote:
> On Mon, 2007-11-06 at 17:44 +0200, Patrick McHardy wrote:
>
>>jamal wrote:
>
> [..]
>
>>>- let the driver shutdown whenever a ring is full. Remember which ring X
>>>shut it down.
>>>- when you get a tx interupt or prun tx descriptors, if a ring <= X has
>>>transmitted a packet (or
Stephen Hemminger wrote:
On Mon, 11 Jun 2007 14:37:21 -0700
Auke Kok <[EMAIL PROTECTED]> wrote:
A lot of netdevices implement their own variant of printk and use
use variations of dev_printk, printk or others that use msg_enable,
which has been an eyesore with countless variations across driver
On Mon, 2007-06-11 at 15:01 -0700, Kok, Auke wrote:
> > msg_enable is more frequently defined in drivers/net as u32 not int.
> yes, we're only using the bottom 15 bits anyway, but the net_device struct
> consistently uses 'int' style members, leaving it up to the compiler to pick
> an
> appropri
On Mon, 11 Jun 2007 12:05:02 -0700 (PDT)
Philip Romanov <[EMAIL PROTECTED]> wrote:
>
>
> > > We are doing pure IPv4 forwarding between two
> > Ethernet
> > > interfaces:
> > >
> > > IXIA port A<--->System Under Test<--->IXIA Port B
> > >
> > > Traffic has two IP destinations for each directio
On Mon, 2007-11-06 at 18:34 +0300, Cohen, Guy wrote:
> jamal wrote:
[..]
> > WMM is a strict prio mechanism.
> > The parametrization very much favors the high prio packets when the
> > tx opportunity to send shows up.
>
> Sorry, but this not as simple as you describe it. WMM is much more
> compl
On Mon, 11 Jun 2007 14:37:21 -0700
Auke Kok <[EMAIL PROTECTED]> wrote:
> A lot of netdevices implement their own variant of printk and use
> use variations of dev_printk, printk or others that use msg_enable,
> which has been an eyesore with countless variations across drivers.
>
> This patch imp
Randy Dunlap wrote:
On Mon, 11 Jun 2007 14:37:21 -0700 Auke Kok wrote:
include/linux/netdevice.h | 38 ++
net/core/dev.c|5 +
net/core/ethtool.c| 14 +++---
3 files changed, 50 insertions(+), 7 deletions(-)
diff --git
Joe Perches wrote:
On Mon, 2007-06-11 at 14:37 -0700, Auke Kok wrote:
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 3a70f55..d185f41 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -540,6 +540,8 @@ struct net_device
struct device
On Mon, 11 Jun 2007 14:37:21 -0700 Auke Kok wrote:
> include/linux/netdevice.h | 38 ++
> net/core/dev.c|5 +
> net/core/ethtool.c| 14 +++---
> 3 files changed, 50 insertions(+), 7 deletions(-)
>
> diff --git a/include/
On Mon, 2007-06-11 at 14:37 -0700, Auke Kok wrote:
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 3a70f55..d185f41 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -540,6 +540,8 @@ struct net_device
> struct device dev;
>
Auke Kok wrote:
A lot of netdevices implement their own variant of printk and use
use variations of dev_printk, printk or others that use msg_enable,
which has been an eyesore with countless variations across drivers.
+#define ndev_err(netdev, level, format, arg...) \
+ do { if ((netde
With the generic ndev_printk macros, we can now convert network
drivers to use this generic printk family for netdevices.
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
---
drivers/net/e100.c| 135 -
drivers/net/e1000/e1000.h | 15
A lot of netdevices implement their own variant of printk and use
use variations of dev_printk, printk or others that use msg_enable,
which has been an eyesore with countless variations across drivers.
This patch implements a standard ndev_printk and derivatives
such as ndev_err, ndev_info, ndev_w
On Mon, 2007-11-06 at 17:44 +0200, Patrick McHardy wrote:
> jamal wrote:
[..]
> > - let the driver shutdown whenever a ring is full. Remember which ring X
> > shut it down.
> > - when you get a tx interupt or prun tx descriptors, if a ring <= X has
> > transmitted a packet (or threshold of packets)
David Miller wrote:
> From: Patrick McHardy <[EMAIL PROTECTED]>
> Date: Mon, 11 Jun 2007 13:12:08 +0200
>
>
>>I hope this still gives me the chance to submit updated patches
>>since I've changed a few things since the last submission and
>>a single incremental update would mix things that don't r
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Mon, 11 Jun 2007 13:12:08 +0200
> I hope this still gives me the chance to submit updated patches
> since I've changed a few things since the last submission and
> a single incremental update would mix things that don't really
> belong together.
>
>
Joe Perches wrote:
I like the ndev_printk idea.
I think a ndev_ printks should take a const netdev*
as the first argument.
Also, better for the non-debug use of ndev_dbg is to have a
static inline function so printf args are verified.
For instance, dev_dbg does:
static inline int __attribute_
> > We are doing pure IPv4 forwarding between two
> Ethernet
> > interfaces:
> >
> > IXIA port A<--->System Under Test<--->IXIA Port B
> >
> > Traffic has two IP destinations for each direction
> and
> > L4 protocol is UDP. There are two static ARP
> entries
> > and only interface routes. Two
I like the ndev_printk idea.
I think a ndev_ printks should take a const netdev*
as the first argument.
Also, better for the non-debug use of ndev_dbg is to have a
static inline function so printf args are verified.
For instance, dev_dbg does:
static inline int __attribute__ ((format (printf, 2
Documentation for the spidernet driver.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
Documentation/networking/spider_net.txt | 204
1 file changed, 204 insertions(+)
Index: linux-2.6.22-rc1/Documentation/networking/spider_net.txt
=
The transmit frame tail bit is stranglely misnamed as
"no checksum". Fix the name to what it should be:
"transmit frame tail". No functional change,
just a name change.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c |2 +-
drivers/net/spider_net.h |2 +-
Put the enable and disable routines next to one-another,
as this makes verifying thier symmetry that much easier.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
Index: linux
Another way of minimizing the likelyhood of RX ram from overflowing
is to empty out the entire rx ring every chance we get. Change
the crazy watchdog timeout from 50 seconds to 3 seconds, while
we're here.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.h |9 +++
On Mon, Jun 11, 2007 at 03:53:37PM +0800, Mark Zhan wrote:
> Current MII bitbang bus driver hard-codes the phy mask of mii_bus to
> ~0x09, which is actually specific to the FSL boards. This patch will
> make the bitbang driver to generate MII bus phy_mask dynamically, by the
> PHY irq info provided
When entering the netdev poll routine, empty out the RX
chain first, before cleaning up the TX chain. This should
help avoid RX buffer overflows.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: li
On Mon, Jun 11, 2007 at 03:53:37PM +0800, Mark Zhan wrote:
> Current MII bitbang bus driver hard-codes the phy mask of mii_bus to
> ~0x09, which is actually specific to the FSL boards. This patch will
> make the bitbang driver to generate MII bus phy_mask dynamically, by the
> PHY irq info provided
On Jun 11, 2007, at 02:53, Mark Zhan wrote:
Current MII bitbang bus driver hard-codes the phy mask of mii_bus to
~0x09, which is actually specific to the FSL boards. This patch will
make the bitbang driver to generate MII bus phy_mask dynamically,
by the
PHY irq info provided by the platform
Invalidate a pointer as its pci_unmap'ed; this is a bit of
paranoia to make sure hardware doesn't continue trying to
DMA to it.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
Index: linux-2.6.22-
Crazy device problems are hard to debug, when one does not have
good trace info. This patch makes a major enhancement to the
device dump routine.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c | 78 ++-
1 file changed
Use dev_err() to print device error messages.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c | 64 ---
1 file changed, 34 insertions(+), 30 deletions(-)
Index: linux-2.6.22-rc1/drivers/net/spider_net.c
==
From: Stephen Hemminger <[EMAIL PROTECTED]>
It doesn't look like spidernet hardware can really checksum all protocols,
the code looks like it does IPV4 only. If so, it should use NETIF_F_IP_CSUM
instead of NETIF_F_HW_CSUM.
The driver doesn't need it's own get/set for ethtool tx csum, and it
sho
From: Florin Malita <[EMAIL PROTECTED]>
The stats update code in spider_net_pass_skb_up() is touching the skb
after it's been passed up to the stack. To avoid that, just update the
stats first.
Signed-off-by: Florin Malita <[EMAIL PROTECTED]>
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
-
This patch fixes a rare deadlock that can occur when the kernel
is not able to empty out the RX ring quickly enough. Below follows
a detailed description of the bug and the fix.
As long as the OS can empty out the RX buffers at a rate faster than
the hardware can fill them, there is no problem. I
At some point, the transmit descriptor chain end interrupt (TXDCEINT)
was turned on. This is a mistake; and it damages small packet
transmit performance, as it results in a huge storm of interrupts.
Turn it off.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.h |
Although the previous patch resolved issues with hangs when the
RX ram full interrupt is encountered, there are still situations
where lots of RX ramfull interrupts arrive, resulting in a noisy
log in syslog. There is no need for this.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drive
Update myri10ge driver version to 1.3.1-1.248.
Signed-off-by: Brice Goglin <[EMAIL PROTECTED]>
---
drivers/net/myri10ge/myri10ge.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
Waskiewicz Jr, Peter P wrote:
>>Another question is what to do about other hard_start_xmit callers.
>>Independant of which field is used, should the classification
>>that may have happend on a different device be retained (TC
>>actions again)?
>
>
> [...] Either way, before it gets enqueued thr
Since Myri-10G boards may also run in Myrinet mode instead of Ethernet,
add a message when we detect that the link partner is not running in the
right mode.
Signed-off-by: Brice Goglin <[EMAIL PROTECTED]>
---
drivers/net/myri10ge/myri10ge.c | 15 ++-
1 file changed, 10 insertions(+)
Limit the number of recoveries from a NIC hw watchdog reset to 1 by default.
It enables detection of defective NICs immediately since these memory parity
errors are expected to happen very rarely (less than once per century*NIC).
Signed-off-by: Brice Goglin <[EMAIL PROTECTED]>
---
drivers/net/myr
The terminated RX ring will cause trouble during the RX ram full
conditions, leading to a hung driver, as the hardware can't find
the next descr. There is no real reason to terminate the RX ring;
it doesn't make the operation any smooother, and it does
require an extra sync. So don't do it.
Si
Hi Jeff,
Here are 3 minor updates of myri10ge for 2.6.22. The first one is a
reduced version of the earlier nacked patch, it now limits the number of
recoveries (to detect bad nics) without making the limit tunable.
1. limit the number of recoveries
2. report when the link partner is running in M
Avoid kernel crash in mm/slab.c due to double-free of pointer.
If the ethernet interface is brought down while there is still
RX traffic in flight, the device shutdown routine can end up
trying to double-free an skb, leading to a crash in mm/slab.c
Avoid the double-free by nulling out the skb poi
> I think grepping will help more than testing :)
>
> The only issue I can see is that packets going to a
> multiqueue device that doesn't have a multiqueue aware qdisc
> attached will get a random value. So you would have to
> conditionally reset it before ->enqueue.
I currently clear queue_m
On Fri, Jun 08, 2007 at 01:20:20PM -0400, Jeff Garzik wrote:
> On Fri, Jun 08, 2007 at 12:06:08PM -0500, Linas Vepstas wrote:
> > On Fri, Jun 08, 2007 at 11:12:31AM +1000, Michael Ellerman wrote:
> > > On Thu, 2007-06-07 at 14:17 -0500, Linas Vepstas wrote:
> > > >
> > > > The major bug fixes are:
Waskiewicz Jr, Peter P wrote:
>>BTW, I couldn't find anything but a single
>>netif_wake_subqueue in your (old) e1000 patch. Why doesn't it
>>stop subqueues?
>
>
> A previous e1000 patch stopped subqueues. The last e1000 patch I sent
> to the list doesn't stop them, and that's a problem with th
Waskiewicz Jr, Peter P wrote:
>>I think we can reuse skb->priority. Assuming only real
>>hardware devices use multiqueue support, there should be no user of
>>skb->priority after egress qdisc classification. The only reason
>>to preserve it in the qdisc layer is for software devices.
>
>
> That
> PJ Waskiewicz wrote:
> > diff --git a/net/sched/sch_generic.c
> b/net/sched/sch_generic.c index
> > f28bb2d..b9dc2a6 100644
> > --- a/net/sched/sch_generic.c
> > +++ b/net/sched/sch_generic.c
> > @@ -123,7 +123,8 @@ static inline int qdisc_restart(struct
> net_device *dev)
> >
> PJ Waskiewicz wrote:
> > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index
> > e7367c7..8bcd870 100644
> > --- a/include/linux/skbuff.h
> > +++ b/include/linux/skbuff.h
> > @@ -215,6 +215,7 @@ typedef unsigned char *sk_buff_data_t;
> > * @pkt_type: Packet class
> > * @fclone
PJ Waskiewicz wrote:
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index e7367c7..8bcd870 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -215,6 +215,7 @@ typedef unsigned char *sk_buff_data_t;
> * @pkt_type: Packet class
> * @fclone: skbuff clon
On Mon, 11 Jun 2007 10:30:26 -0700
"Kok, Auke" <[EMAIL PROTECTED]> wrote:
> Stephen Hemminger wrote:
> > On Fri, 08 Jun 2007 16:42:31 -0700
> > "Kok, Auke" <[EMAIL PROTECTED]> wrote:
> >
> >> Stephen Hemminger wrote:
>
> +#define ndev_printk(kern_level, netif_level, netdev, format, ar
PJ Waskiewicz wrote:
> diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
> index f28bb2d..b9dc2a6 100644
> --- a/net/sched/sch_generic.c
> +++ b/net/sched/sch_generic.c
> @@ -123,7 +123,8 @@ static inline int qdisc_restart(struct net_device *dev)
> /* And release
Stephen Hemminger wrote:
On Fri, 08 Jun 2007 16:42:31 -0700
"Kok, Auke" <[EMAIL PROTECTED]> wrote:
Stephen Hemminger wrote:
+#define ndev_printk(kern_level, netif_level, netdev, format, arg...) \
+ do { if ((netdev)->msg_enable & NETIF_MSG_##netif_level) { \
+ printk(kern
Ben Greear wrote:
> Patrick McHardy wrote:
>
>> I would really prefer to simply make the prio 0 "lookup local"
>> rule deletable so you can rules with higher priority. That
>> allows to do send to self without any further code changes
>> and avoids the need to bind applications to a device.
>>
On Jun 6, 2007, at 4:28 AM, Milton Miller wrote:
On Jun 5, 2007, at 9:26 PM, Kok, Auke wrote:
Kok, Auke wrote:
Hmm git-revert seems to do the job right. I checked it with git-show
| patch -p1 -R and the results look OK. The two patches on top of
the one we want to revert are unrelated en
Patrick McHardy wrote:
Ben Greear wrote:
This should also be useful with the pending 'veth' driver, as it
emulates two ethernet ports connected with a cross-over cable.
To make this work, you have to enable the sysctl (look Dave,
no IOCTLS, there might be hope for me yet!! :)), and in your
a
jamal wrote:
> On Mon, 2007-11-06 at 17:12 +0200, Patrick McHardy wrote:
>
>>Worst cast is (n - 2) * (m - 1) + 1 full sized packet transmission
>>times.
>>
>>You can do the math yourself, but we're talking about potentially
>>a lot of packets.
>
>
> I agree if you use the strategy of "a ring shu
Some more details inside regarding wireless QoS.
jamal wrote:
> On Mon, 2007-11-06 at 17:30 +0300, Cohen, Guy wrote:
>
> >
> > For WiFi devices the HW often implements the scheduling, especially
when
> > QoS (WMM/11e/11n) is implemented. There are few traffic queues
defined
> > by the specs and t
On Sat, 2007-05-05 at 00:52 +0200, matthieu castet wrote:
> Hi,
>
> I attach a diff against 2.6.21 for adding wpa support for airo driver.
> In then end of 2005 I manage to make work wpa but the code was really
> ugly. I manage to find some time to clean it.
>
>
> To support wpa, a new interfa
On Mon, 2007-11-06 at 17:12 +0200, Patrick McHardy wrote:
> > Ok, so let me revert that; 0 is higher prio than n-1.
>
>
> Yes.
>
Ok, gotcha.
> > "possibly long time" is where we diverge ;->
>
> Worst cast is (n - 2) * (m - 1) + 1 full sized packet transmission
> times.
>
> You can do the
jamal wrote:
> On Mon, 2007-11-06 at 16:49 +0200, Patrick McHardy wrote:
>
>>We have n empty HW queues with a maximum length of m packets per queue:
>>
>>[0] empty
>>[1] empty
>>[2] empty
>>..
>>[n-1] empty
>
>
> Asumming 0 i take it is higher prio than n-1.
Yes.
>>Now we receive m - 1 packets
On Mon, 2007-11-06 at 18:00 +0300, Tomas Winkler wrote:
> On 6/11/07, jamal <[EMAIL PROTECTED]> wrote:
> > On Mon, 2007-11-06 at 17:30 +0300, Cohen, Guy wrote:
> >
> > >
> > > For WiFi devices the HW often implements the scheduling, especially when
> > > QoS (WMM/11e/11n) is implemented. There are
On Mon, 2007-11-06 at 16:49 +0200, Patrick McHardy wrote:
> Let me explain with some ASCII art :)
Ok ;->
> We have n empty HW queues with a maximum length of m packets per queue:
>
> [0] empty
> [1] empty
> [2] empty
> ..
> [n-1] empty
>
Asumming 0 i take it is higher prio than n-1.
> Now w
On 6/11/07, jamal <[EMAIL PROTECTED]> wrote:
On Mon, 2007-11-06 at 17:30 +0300, Cohen, Guy wrote:
>
> For WiFi devices the HW often implements the scheduling, especially when
> QoS (WMM/11e/11n) is implemented. There are few traffic queues defined
> by the specs and the selection of the next que
jamal wrote:
> On Mon, 2007-11-06 at 16:03 +0200, Patrick McHardy wrote:
>
>>Read again what I wrote about the n > 2 case. Low priority queues might
>>starve high priority queues when using a single queue state for a
>>maximum of the time it takes to service n - 2 queues with max_qlen - 1
>>packet
On Mon, 2007-11-06 at 17:30 +0300, Cohen, Guy wrote:
>
> For WiFi devices the HW often implements the scheduling, especially when
> QoS (WMM/11e/11n) is implemented. There are few traffic queues defined
> by the specs and the selection of the next queue to transmit a packet
> from, is determined
Cohen, Guy wrote:
> Patrick McHardy wrote:
>
>>jamal wrote:
>>
>>>Sure - but what is wrong with that?
>>
>>
>>Nothing, this was just to illustrate why I disagree with the
>
> assumption
>
>>that the packet has hit the wire. On second thought I do agree with
>
> your
>
>>assumption for the sing
On Mon, 2007-11-06 at 16:03 +0200, Patrick McHardy wrote:
> jamal wrote:
> > Sure - but what is wrong with that?
>
> Nothing, this was just to illustrate why I disagree with the assumption
> that the packet has hit the wire.
fair enough.
> On second thought I do agree with your
> assumption fo
Patrick McHardy wrote:
> jamal wrote:
> > Sure - but what is wrong with that?
>
>
> Nothing, this was just to illustrate why I disagree with the
assumption
> that the packet has hit the wire. On second thought I do agree with
your
> assumption for the single HW queue case, at the point we hand t
jamal wrote:
> On Mon, 2007-11-06 at 15:03 +0200, Patrick McHardy wrote:
>
>>>Take a step back:
>>>When you put a packet on the DMA ring, are you ever going to take it
>>>away at some point before it goes to the wire?
>>
>>
>>No, but its nevertheless not on the wire yet and the HW scheduler
>>con
I have started writting a small howto for drivers. Hoping to get a wider
testing with more drivers.
So far i have changed e1000 and tun drivers as well as modified the
packetgen tool to do batching.
I will update this document as needed if something is unclear.
Please contribute by asking questi
On Mon, 2007-11-06 at 15:03 +0200, Patrick McHardy wrote:
> jamal wrote:
> Well, its not.
I dont wanna go into those old style debates again; so lets drop this
point.
> > Take a step back:
> > When you put a packet on the DMA ring, are you ever going to take it
> > away at some point before it
jamal wrote:
> On Mon, 2007-11-06 at 14:39 +0200, Patrick McHardy wrote:
>
>>>Sure. Packets stashed on the any DMA ring are considered "gone to the
>>>wire". That is a very valid assumption to make.
>>
>>
>>I disagree, its obviously not true
>
>
> Patrick, you are making too strong a statement.
On Mon, 2007-11-06 at 14:39 +0200, Patrick McHardy wrote:
> jamal wrote:
> > On Mon, 2007-11-06 at 13:58 +0200, Patrick McHardy wrote:
> >
> > Sure. Packets stashed on the any DMA ring are considered "gone to the
> > wire". That is a very valid assumption to make.
>
>
> I disagree, its obviousl
jamal wrote:
> On Mon, 2007-11-06 at 13:58 +0200, Patrick McHardy wrote:
>
>
>>Thats not true. Assume PSL has lots of packets, PSH is empty. We
>>fill the PHL queue until their is no room left, so the driver
>>has to stop the queue.
>
>
> Sure. Packets stashed on the any DMA ring are considere
Ben Greear wrote:
> This should also be useful with the pending 'veth' driver, as it
> emulates two ethernet ports connected with a cross-over cable.
>
> To make this work, you have to enable the sysctl (look Dave,
> no IOCTLS, there might be hope for me yet!! :)), and in your
> application you wi
On Mon, Jun 11, 2007 at 02:26:58PM +0200, Patrick McHardy wrote:
>
> I noticed a few more side-effects from the original change that
> seem to be undesired. Some code assumes that dev->ip_ptr != NULL
> implies existance of IP addresses on the device. For example
> fib_check_nh used to allow to add
Herbert Xu wrote:
> [IPV4]: Add default config support after inetdev_init
>
> Previously once inetdev_init has been called on a device any changes made
> to ipv4_devconf_dflt would have no effect on that device's configuration.
I noticed a few more side-effects from the original change that
seem
On Mon, 2007-11-06 at 13:58 +0200, Patrick McHardy wrote:
> Thats not true. Assume PSL has lots of packets, PSH is empty. We
> fill the PHL queue until their is no room left, so the driver
> has to stop the queue.
Sure. Packets stashed on the any DMA ring are considered "gone to the
wire". That
Waskiewicz Jr, Peter P wrote:
>>>If they have multiple TX queues, independantly programmable, that
>>>single lock is stupid.
>>>
>>>We could use per-queue TX locks for such hardware, but we can't
>>>support that currently.
>>
>>There could be bad packet reordering with this (like some SMP
>>rout
jamal wrote:
> On Wed, 2007-06-06 at 15:35 -0700, David Miller wrote:
>
>>The problem with this line of thinking is that it ignores the fact
>>that it is bad to not queue to the device when there is space
>>available, _even_ for lower priority packets.
>
>
> So use a different scheduler. Dont us
Hi,
Here's an updated implementation of tcp network splice receive support.
It actually works for me now, no data corruption seen.
For the original announcement and how to test it, see:
http://marc.info/?l=linux-netdev&m=118103093400770&w=2
I hang on to the original skb by creating a clone of i
jamal wrote:
> On Wed, 2007-06-06 at 17:11 +0200, Patrick McHardy wrote:
>
>
>>[...]
> The problem is the premise is _innacurate_.
> Since you havent followed the discussion, i will try to be brief (which
> is hard).
> If you want verbosity it is in my previous emails:
>
> Consider a simple exam
Ben Greear wrote:
> Pavel Emelianov wrote:
>
>>> I would also like some way to identify veth from other device types,
>>> preferably
>>> something like a value in sysfs. However, that should not hold up
>>>
>>
>>
>> We can do this with ethtool. It can get and print the driver name of
>> the
Pavel Emelianov wrote:
> Patrick McHardy wrote:
>
>>>+skb->pkt_type = PACKET_HOST;
>>>+skb->protocol = eth_type_trans(skb, rcv);
>>>+if (dev->features & NETIF_F_NO_CSUM)
>>>+skb->ip_summed = rcv_priv->ip_summed;
>>>+
>>>+dst_release(skb->dst);
>>>+skb->dst = NULL;
1 - 100 of 108 matches
Mail list logo
