Joe Perches wrote:
I like the ndev_printk idea.I think a ndev_<level> printks should take a const netdev* as the first argument. Also, better for the non-debug use of ndev_dbg is to have a static inline function so printf args are verified. For instance, dev_dbg does: static inline int __attribute__ ((format (printf, 2, 3))) dev_dbg(struct device * dev, const char * fmt, ...) { return 0; } Perhaps ndev_dbg should look like this: static inline int __attribute ((format (printf, 3, 4))) __ndev_dbg(const struct net_device *netdev, u32 level, const char *format, ...) { return 0; } #define ndev_dbg(netdev, level, fmt, args...) \ __ndev_dbg(netdev, NETIF_MSG_##level, fmt, ##args)
I'll take both of these comments into consideration and post a new version in a bit...
Thanks. Auke - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
