Patrick McHardy wrote:
> Oliver Hartkopp wrote:
>
>> Btw. it's really worth to look at it again. I just had the idea to
>> access the loopback flag via skb->sk->opt->loopback (argpfl!) on the TX
>> path and skb->sk on the RX path. This would avoid skb->sk to be set to
>> NULL but need to have th
On Wed, May 30, 2007 at 09:51:14PM -0700, Kok, Auke wrote:
>
> this has been an age-old confusion that I never grasped either, so I
> perfectly understand why you added the explicit e1000_disable_irq call in
> the other patch (and think thats a great idea). But really, there should be
> a way f
Herbert Xu wrote:
On Wed, May 30, 2007 at 03:57:13PM -0700, Kok, Auke wrote:
Hmm, we're making a mess of it.
Indeed :)
Herbert, wouldn't it just have been a lot easier to do just add a
netif_poll_disable in e1000_probe, so that any and all other poll
enable/disables are symmetric ? Somethin
From: Divy Le Ray <[EMAIL PROTECTED]>
The chip executes microcode present in internal RAM,
whose content is loaded from EEPROM on power cycle.
This patch allows an update of the microcode through PIO
without forcing a power cycle.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
---
drivers/net
From: Divy Le Ray <[EMAIL PROTECTED]>
Streamline sge page management.
Fix dma mappings when buffers are recycled.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/adapter.h | 38 ++--
drivers/net/cxgb3/sge.c | 423 ++-
2 files c
From: Divy Le Ray <[EMAIL PROTECTED]>
Update FW to 4.1.
Proceed to subsequent HW tuning to improve RDMA perfs..
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/regs.h|4
drivers/net/cxgb3/t3_hw.c | 42 +++---
drivers/net
Hi Jeff,
I'm submitting a patch series for inclusion in netdev#upstream.
Here is a brief description:
- update page management in the SGE code,
- update FW to 4.1 and proceed to subsequent HW tuning,
- allow microcode update without a power cycle.
Cheers,
Divy
-
To unsubscribe from this list: s
Jeff Garzik wrote:
[EMAIL PROTECTED] wrote:
From: Divy Le Ray <[EMAIL PROTECTED]>
Streamline page management on RX.
Fix dma mappings.
NAK #2: You should use the page_address(page) accessor rather than
creating a struct member in the same struct as your page, solely to
contain the virtual
From: Divy Le Ray <[EMAIL PROTECTED]>
Rx traffic needs to be halted when the MTU is changed
to avoid a potential chip hang.
Reset/restore MAC filters around a MTU change.
Also fix the pause frames high materwark setting.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/regs.
[EMAIL PROTECTED] wrote:
From: Divy Le Ray <[EMAIL PROTECTED]>
Rx traffic needs to be halted when the MTU is changed
to avoid a potential chip hang.
Reset/restore MAC filters around a MTU change.
Also fix the pause frames high materwark setting.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
I was doing some suspend-to-ram testing on the Vaio with the 2.6.22-rc3-mm1
lineup. After 10 or 15 cycles a resume failed:
[ 357.119436] Suspending device full
[ 357.120450] Suspending device zero
[ 358.084978] Suspending device port
[ 358.085664] Suspending device null
[ 358.086432] Suspen
Please stop sending your patche emails twice every time.
I got the first copy!
Thank you :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mr. David
I have modified my patch according to you advice. I think -
EHOSTUNREACH is only for "input path". In "output" path, we can just
simply check-ENETUNREACH (^_^), the patch is shown in the end of this mail.
I send this patch to you several weeks ago, but you have not replied to me.
Hi Mr. David
I have modified my patch according to you advice. I think -
EHOSTUNREACH is only for "input path". In "output" path, we can just
simply check-ENETUNREACH (^_^), the patch is shown in the end of this mail.
I send this patch to you several weeks ago, but you have not replied to me.
On Wed, May 30, 2007 at 05:22:30PM -0400, Doug Chapman wrote:
>
> but once again broken just yesterday by the following commit. I have
> backed just this commit out and verified I no longer panic.
Hmm, the only way I can see this happening is if the hardware signals
an interrupt even though we'v
On Wed, May 30, 2007 at 03:57:13PM -0700, Kok, Auke wrote:
>
> Hmm, we're making a mess of it.
Indeed :)
> Herbert, wouldn't it just have been a lot easier to do just add a
> netif_poll_disable in e1000_probe, so that any and all other poll
> enable/disables are symmetric ? Something like this
Hello,
On Wed, 30 May 2007, KOVACS Krisztian wrote:
> I'm just about to publish the next round of tproxy patches (with the
> routing code modifications completely removed), but this issue is still
> present.
>
> I've posted a few patches making omitting this check possible
> sele
On Wed, 2007-05-30 at 15:57 -0700, Kok, Auke wrote:
> Doug Chapman wrote:
> > All,
> >
> > I reported this a few weeks ago and it was fixed but it appears the
> > offending code was again re-submitted. This causes a panic on HP
> > Integrity servers and from what I hear many other platforms using
From: Matt Mackall <[EMAIL PROTECTED]>
Date: Wed, 30 May 2007 17:36:12 -0500
> On Wed, May 30, 2007 at 03:29:39PM -0700, David Miller wrote:
> > From: Matt Mackall <[EMAIL PROTECTED]>
> > Date: Wed, 30 May 2007 17:10:39 -0500
> >
> > > Are you agreeing that "it seems wasteful to add per-packet ov
Doug Chapman wrote:
All,
I reported this a few weeks ago and it was fixed but it appears the
offending code was again re-submitted. This causes a panic on HP
Integrity servers and from what I hear many other platforms using e1000
as well.
My original report was via kernel.org BZ:
http://bugzil
On Wed, May 30, 2007 at 03:29:39PM -0700, David Miller wrote:
> From: Matt Mackall <[EMAIL PROTECTED]>
> Date: Wed, 30 May 2007 17:10:39 -0500
>
> > Are you agreeing that "it seems wasteful to add per-packet overhead"?
> > This patch is not doing that.
>
> Yes, and I know that :-)
Is there a rea
From: Matt Mackall <[EMAIL PROTECTED]>
Date: Wed, 30 May 2007 17:10:39 -0500
> Are you agreeing that "it seems wasteful to add per-packet overhead"?
> This patch is not doing that.
Yes, and I know that :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a messag
On Wed, May 30, 2007 at 12:55:51PM -0700, David Miller wrote:
> From: Patrick McHardy <[EMAIL PROTECTED]>
> Date: Wed, 30 May 2007 20:42:32 +0200
>
> > Stephen Hemminger wrote:
> > >>>Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c
> > >>>=
On Wed, May 30, 2007 at 06:47:11AM -0500, Jay Cliburn wrote:
> On Wed, 30 May 2007 02:00:25 +0200
> Jose Alberto Reguero <[EMAIL PROTECTED]> wrote:
>
> > I have problems with a M2V motherboard and atl1 driver with msi and
> > kernel 2.6.22-rc3. With kernel 2.6.21 I had no problems.
> > I must add
* Johannes Berg <[EMAIL PROTECTED]> 2007-05-27 15:24
> On Sat, 2007-05-26 at 00:18 +0200, Thomas Graf wrote:
>
> > This area is still work in progress but the basic idea is that
> > like in kernel context, the application defines its set of
> > commands and assigns message parsers for each command
* Jason Lunz <[EMAIL PROTECTED]> 2007-05-30 12:17
>
> I recall mention of a tool that could dynamically monitor kernel packet
> queues in linux using netlink, but I can't remember a unique enough name
> for good googling. Does this sound familiar to anyone? iirc it was
> written by Thomas Graf?
Y
On Wed, May 30, 2007 at 01:30:39PM -0700, Stephen Hemminger wrote:
> On Wed, 30 May 2007 12:55:51 -0700 (PDT)
> David Miller <[EMAIL PROTECTED]> wrote:
>
> > From: Patrick McHardy <[EMAIL PROTECTED]>
> > Date: Wed, 30 May 2007 20:42:32 +0200
> >
> > > Stephen Hemminger wrote:
> > > >>>Index: linu
Reading the code for ql_hw_csum_setup(), it is obvious that
this driver is broken for IPV6. The driver sets the NETIF_F_HW_SUM
flag, but the code for checksum setup only deals with IPV4.
Compile tested only, no hardware available.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
drivers
Add the ability to control scatter/gather and checksumming
via ethtool.
Compile tested only, no hardware available.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
drivers/net/qla3xxx.c | 33 +
1 file changed, 33 insertions(+)
--- a/drivers/net/qla3xx
Found while looking at drivers that are doing NETIF_F_HW_CSUM
incorrectly.
The first is a bug fix. Second is cleanup, Third is an enhancement.
--
Stephen Hemminger <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED
The code for checksum is more complex than needed when dealing with VLAN's;
the higher layers already pass down the location of the IP header.
Compile tested only, no hardware available.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
drivers/net/qla3xxx.c | 37 +++---
All,
I reported this a few weeks ago and it was fixed but it appears the
offending code was again re-submitted. This causes a panic on HP
Integrity servers and from what I hear many other platforms using e1000
as well.
My original report was via kernel.org BZ:
http://bugzilla.kernel.org/show_bug
On Wed, May 30, 2007 at 12:55:51PM -0700, David Miller wrote:
> From: Patrick McHardy <[EMAIL PROTECTED]>
> Date: Wed, 30 May 2007 20:42:32 +0200
>
> > Stephen Hemminger wrote:
> > >>>Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c
> > >>>=
This is better.
There is still a possiblity when a device allows IPV6 and not IPV4
checksumming, that the checksum will be done in the fixup code in
dev_queue_xmit.
The existing model for checksum offload does not correctly handle
devices that can offload IPV4 and IPV6 only. The NETIF_F_HW_CSUM f
On Wed, 30 May 2007 12:55:51 -0700 (PDT)
David Miller <[EMAIL PROTECTED]> wrote:
> From: Patrick McHardy <[EMAIL PROTECTED]>
> Date: Wed, 30 May 2007 20:42:32 +0200
>
> > Stephen Hemminger wrote:
> > >>>Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c
> > >>>=
Divy Le Ray wrote:
Hi Jeff,
I'm submitting a set of bug fixes for inclusion in 2.6.22.
The patches are built against Linus'git tree.
The mail title was incomplete. sorry about that.
Cheers,
Divy
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
Oliver Hartkopp wrote:
> Patrick McHardy wrote:
>
>>skb->sk should work here as well since you detect these frames
>>before queueing to the receiving socket.
>>
>
>
> Hm - this would indeed be much nicer than using skb->cb.
>
> I think we just had some concerns to use skb->sk for our own
> fu
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed, 30 May 2007 20:42:32 +0200
> Stephen Hemminger wrote:
> >>>Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c
> >>>===
> >>>--- linux-2.6.22-rc-mm.orig/net/sched/sch_generic.c
Patch looks good. Yes, please add a comment as to reason for cast.
Ram
> -Original Message-
> From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]
> On Behalf Of Michael Buesch
> Sent: Saturday, May 26, 2007 10:04 AM
> To: Andreas Schwab
> Cc: netdev@vger.kernel.org
> Subject: Re: [PATCH] Av
Patrick McHardy wrote:
>
>>> (..)
>>> Qdiscs might change skb->cb. Maybe use skb->sk?
>>>
>>>
>> The loopback functionality in CAN is a bit tricky (maybe you can take a
>> look into the Documentation patch [7/7] at chapter 3.2 and 4.1.4).
>>
>> The problem is, that we need a per socket(!) op
I recall mention of a tool that could dynamically monitor kernel packet
queues in linux using netlink, but I can't remember a unique enough name
for good googling. Does this sound familiar to anyone? iirc it was
written by Thomas Graf?
Jason
-
To unsubscribe from this list: send the line "unsubsc
Venki Pallipadi wrote:
> On Wed, May 30, 2007 at 08:42:32PM +0200, Patrick McHardy wrote:
>
>>
>>It seems wasteful to add per-packet overhead for tx timeouts, which
>>should be an exception. Do drivers really care about the exact
>>timeout value? Compared to a packet transmission time its incredib
The bridge cleanup timer is fired 10 times a second for timers that are
at least 15 seconds ahead in time and that are not critical to be
cleaned asap.
This patch calculates the next time to run the timer as the minimum of
all timers or a minimum based on the current state.
Signed-off-by: Baruch
Peroidic STP timers don't have to be exact.
The hold timer runs at 1HZ, and the hello timer normally runs
at 2HZ; save power by aligning it them to next second.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
net/bridge/br_stp.c |3 ++-
net/bridge/br_stp_timer.c |2 +-
2 f
Stephen Hemminger wrote:
> On Wed, 30 May 2007 20:57:33 +0200
> Oliver Hartkopp <[EMAIL PROTECTED]> wrote:
>
>
>> Does 'unneeded' belong to always the last line of the quoted code snippet?
>>
>>
>
> They are all places where you assign zero (or NULL) to something that is
> already initializ
On Wed, May 30, 2007 at 08:42:32PM +0200, Patrick McHardy wrote:
> Stephen Hemminger wrote:
> >>>Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c
> >>>===
> >>>--- linux-2.6.22-rc-mm.orig/net/sched/sch_generic.c2007-05-24
> >
Oliver Hartkopp wrote:
> Patrick McHardy wrote:
>
>>I have a set of patches coming up that introduce a rtnetlink API
>>for adding/modifying/deleting software network devices. I would
>>prefer if you could switch this driver over instead of doing the
>>"create N devices during loading" that many cu
Update driver version to 1.3.1-1.245.
Signed-off-by: Brice Goglin <[EMAIL PROTECTED]>
---
drivers/net/myri10ge/myri10ge.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
===
-
Limit the number of recoveries from a NIC hw watchdog reset to 1 by default.
It enables detection of defective NICs immediately since these memory parity
errors are expected to happen very rarely (less than once per century*NIC).
However, a defective NIC (very rare, fortunately) can see such an err
Hi Jeff,
Here's a small patchset for myri10ge in 2.6.22:
1) report link up/down in standard ethtool way
2) limit the number of recoveries
3) update driver version
Please apply.
Thanks!
Brice
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL P
On Wed, 30 May 2007 20:57:33 +0200
Oliver Hartkopp <[EMAIL PROTECTED]> wrote:
>
>
> Does 'unneeded' belong to always the last line of the quoted code snippet?
>
They are all places where you assign zero (or NULL) to something that is
already initialized to zero by alloc_netdev.
--
Stephen Hem
Report link up/down in standard ethtool way
Signed-off-by: Brice Goglin <[EMAIL PROTECTED]>
---
drivers/net/myri10ge/myri10ge.c |1 +
1 file changed, 1 insertion(+)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
===
--- linux-r
From: John W. Linville <[EMAIL PROTECTED]>
avoid sdata null pointer dereference in ieee80211_ibss_add_sta.
Signed-off-by: John W. Linville <[EMAIL PROTECTED]>
---
net/mac80211/ieee80211_sta.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/mac80211/ieee80211_sta.c b
From: Zhu Yi <[EMAIL PROTECTED]>
Some APs have strict checking between associate and reassociate. In
a case when an AP is restarted during a connection, it denies the
mac80211 reassoc request since this is a new association for the AP.
To fix this problem, we need to check the status code against
From: Michael Wu <[EMAIL PROTECTED]>
ieee80211_open should always set the carrier status since we may have set
it to off before.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
Signed-off-by: John W. Linville <[EMAIL PROTECTED]>
---
net/mac80211/ieee80211.c |2 ++
1 files changed, 2 insertions
Some bug fixes that should be applied to 2.6.22:
mac80211: fail back to use associate from reassociate
mac80211: fix memory leak when defrag fragments
mac80211: always set carrier status on open
mac80211: avoid null ptr deref in ieee80211_ibss_add_sta
These are also availa
From: Hong Liu <[EMAIL PROTECTED]>
We forget to free all the fragments when defraging them into one packet.
Signed-off-by: Hong Liu <[EMAIL PROTECTED]>
Signed-off-by: John W. Linville <[EMAIL PROTECTED]>
---
net/mac80211/ieee80211.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
Stephen Hemminger wrote:
> In addition to Patrick's comments.
>
>
>> +
>> +static void vcan_init(struct net_device *dev)
>> +{
>> +DBG("dev %s\n", dev->name);
>> +
>> +ether_setup(dev);
>>
>
> Do really want to do this?
> - you set different flags/type after this.
> - do you rea
On Wed, 30 May 2007, Stephen Hemminger wrote:
> On Wed, 30 May 2007 10:49:54 +0300 (EEST)
> "Ilpo Järvinen" <[EMAIL PROTECTED]> wrote:
>
> > I think the code did a right thing before your api merge, since it called
> > rtt callback only if FLAG_RETRANS_DATA_ACKED was not set (and pkts_acked
> >
Hi,
Here is the patch for the net-2.6 (22-rc2) BEET (Bound End-to-End
Tunnel) mode implementation to support ipv4/ipv6 interfamily
addressing, as specified by the ietf draft found at:
http://www.ietf.org/internet-drafts/draft-nikander-esp-beet-mode-07.txt
The previous implementation required tha
Stephen Hemminger wrote:
>>>Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c
>>>===
>>>--- linux-2.6.22-rc-mm.orig/net/sched/sch_generic.c 2007-05-24
>>>11:16:03.0 -0700
>>>+++ linux-2.6.22-rc-mm/net/sched/sch_generic.c
Patrick McHardy wrote:
> I have a set of patches coming up that introduce a rtnetlink API
> for adding/modifying/deleting software network devices. I would
> prefer if you could switch this driver over instead of doing the
> "create N devices during loading" that many current drivers do,
> leaving
On Wed, 30 May 2007 10:59:36 -0700
Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Tue, 29 May 2007 11:01:13 -0700
> Venki Pallipadi <[EMAIL PROTECTED]> wrote:
>
> > round_jiffies for net dev watchdog timer.
> >
> > Signed-off-by: Venkatesh Pallipadi <[EMAIL PROTECTED]>
> >
> > Index: linux-2.6.2
On Tue, 29 May 2007 11:01:13 -0700
Venki Pallipadi <[EMAIL PROTECTED]> wrote:
> round_jiffies for net dev watchdog timer.
>
> Signed-off-by: Venkatesh Pallipadi <[EMAIL PROTECTED]>
>
> Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c
> ===
On Wed, 30 May 2007 09:56:18 -0400
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Stephen Hemminger wrote:
> > Some chips need to have internal clocks enabled (via PCI config)
> > before the PCI space is readable.
> >
> > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
> >
> > ---
> > drivers/ne
In addition to Patrick's comments.
> +
> +static void vcan_init(struct net_device *dev)
> +{
> + DBG("dev %s\n", dev->name);
> +
> + ether_setup(dev);
Do really want to do this?
- you set different flags/type after this.
- do you really want change_mtu to call eth_change_mtu
Better of
On Wed, 30 May 2007 09:58:38 -0700
"Laurent Chavey" <[EMAIL PROTECTED]> wrote:
> should we then move/integrate that code as part of the bonding driver ?
>
>
> On 5/30/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote:
> > On Tue, 29 May 2007 17:41:45 -0700
> > "Laurent Chavey" <[EMAIL PROTECTED]>
Urs Thuermann wrote:
> +static int numdev = 4; /* default number of virtual CAN interfaces */
> +module_param(numdev, int, S_IRUGO);
> +MODULE_PARM_DESC(numdev, "Number of virtual CAN devices");
I have a set of patches coming up that introduce a rtnetlink API
for adding/modifying/deleting softwar
From: Divy Le Ray <[EMAIL PROTECTED]>
Fix variables initialization and usage in the MAC watchdog.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/xgmac.c | 31 +--
1 files changed, 21 insertions(+), 10 deletions(-)
diff --git a/drivers/net/cxg
On Wed, 2007-30-05 at 18:55 +0200, Patrick McHardy wrote:
> I could do that, but I'm perfectly happy with the qdisc part of SFQ.
> Without the classifier SFQ is of course simply a FQ qdisc, all it
> cares about is serving queues equally.
Sure. You are writting the code - your call.
cheers,
jamal
From: Divy Le Ray <[EMAIL PROTECTED]>
Check all lanes for link status on direct XAUI cards.
Don't assume that direct XAUI always uses XGMAC 1.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/ael1002.c | 10 --
drivers/net/cxgb3/regs.h|2 ++
2 files changed
From: Divy Le Ray <[EMAIL PROTECTED]>
Rx traffic needs to be halted when the MTU is changed
to avoid a potential chip hang.
Reset/restore MAC filters around a MTU change.
Also fix the pause frames high materwark setting.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/regs.
From: Divy Le Ray <[EMAIL PROTECTED]>
Fix netpoll handler to work with line interrupt, msi and msi-x.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/cxgb3_main.c | 16 +---
drivers/net/cxgb3/sge.c|1 -
2 files changed, 13 insertions(+), 4 deletion
From: Divy Le Ray <[EMAIL PROTECTED]>
eth_type_trans() now sets skb->dev.
References to skb->dev should happen after it is called.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/sge.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/cx
Hi Jeff,
I'm submitting a set of bug fixes for inclusion in 2.6.22.
The patches are built against Linus'git tree.
Here is a brief description:
- Fix skb->dev dereference in,
- Fix netpoll handler,
- Fix link status detection for direct XAUI adapters,
- Work around potential hang on MTU change,
-
should we then move/integrate that code as part of the bonding driver ?
On 5/30/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote:
On Tue, 29 May 2007 17:41:45 -0700
"Laurent Chavey" <[EMAIL PROTECTED]> wrote:
> kernel version <= 2.6.20.1
> file drivers/net/bonding/bonding_main.c
> function bond
Patrick McHardy wrote:
My classifier uses jhash,
Ahh that's OK - I thought it still used the old sfq hash, which collided
alot with a low number of consecutive addresses.
Andy.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
Mo
jamal wrote:
> On Wed, 2007-30-05 at 18:23 +0200, Patrick McHardy wrote:
>
>>My classifier seperates them entirely. The only thing it keeps
>>in SFQ is the old classifier for compatibility, besides that its
>>exactly what you say. It should be easily possible to remove it
>>entirely and use my cla
On Wed, 30 May 2007 10:49:54 +0300 (EEST)
"Ilpo Järvinen" <[EMAIL PROTECTED]> wrote:
> On Tue, 29 May 2007, Stephen Hemminger wrote:
>
> > On Tue, 29 May 2007 20:23:45 +0200
> > "Lior Dotan" <[EMAIL PROTECTED]> wrote:
> >
> > > NTP was not running. I'm not sure what do you mean by fixing the -1.
On Tue, 29 May 2007 17:41:45 -0700
"Laurent Chavey" <[EMAIL PROTECTED]> wrote:
> kernel version <= 2.6.20.1
> file drivers/net/bonding/bonding_main.c
> function bond_compute_features()
>
> ---
> Given a system with two different NIC. One driver sets
> dev->features |= NETIF_F_H
On Wed, 2007-30-05 at 18:23 +0200, Patrick McHardy wrote:
> I think exposing SFQ's queues as classes is a good thing, it allows
> you to do whatever classification you want. In fact I'm probably
> going to add patch on top to also dump them to userspace.
Yes, that would be useful.
> What
> rema
It isn't worth inlining qdisc_run, into two parts. The code is
cleaner (and smaller) to just have it as one routine.
--- a/include/net/pkt_sched.h 2007-05-02 12:26:34.0 -0700
+++ b/include/net/pkt_sched.h 2007-05-30 09:12:22.0 -0700
@@ -80,14 +80,7 @@ extern struct qdisc_rate_t
jamal wrote:
> On Wed, 2007-30-05 at 17:27 +0200, Patrick McHardy wrote:
>
>>>Another alternative is to create a brand new FQ qdisc and leave the
>>>classification to the classifiers.
>>
>>I created a new classifier to leave classification to the classifiers ..
>>Not sure exactly why I would need
Stephen Hemminger wrote:
> Here is a proposed change to address hardware that can do IPV6 checksum
> offload, but doesn't truly do generic hw checksumming. The bnx2 and tg3
> are like this for some revisions, and upcoming Marvell 88e8071 is similar.
>
>
> --- a/include/linux/netdevice.h 20
On Wed, 2007-30-05 at 17:27 +0200, Patrick McHardy wrote:
> jamal wrote:
> Sure. The thing I don't like about the predefined hash functions is
> that its unflexible.
>
agreed.
> > skb->prio as a selector. I think if you removed that it should be fine.
>
> I don't think thats a problem, it needs
Jeff Garzik wrote:
> Look at the function argument...
Yes, it's void *. But my point is that C requires the ?: to evaluate to
some specific type, so if you have different types on each side of the :
the compiler can be legitimately upset. The fact that the whole thing
gets cast to void * is som
Here is a proposed change to address hardware that can do IPV6 checksum
offload, but doesn't truly do generic hw checksumming. The bnx2 and tg3
are like this for some revisions, and upcoming Marvell 88e8071 is similar.
--- a/drivers/net/bnx2.c2007-05-30 08:26:18.0 -0700
+++ b/dri
Andy Furniss wrote:
> Patrick McHardy wrote:
>
>> It currently does not support perturbation, I didn't want to move this
>> into
>> the classifier, so I need to think about a way to handle it within SFQ.
>>
>
> Cool, but isn't this going to show the same collision problems that the
> pre jhash es
jamal wrote:
> On Wed, 2007-30-05 at 11:40 +0200, Patrick McHardy wrote:
>
>>One good thing about ESFQ is the more flexible flow classification, but
>>I don't like the concept of having a set of selectable hash functions
>>very much.
>>
>
>
> In the spirit of SFQ it is probably ok to do that;
>
On Wed, 2007-05-30 at 10:07 -0400, Jeff Garzik wrote:
> John W. Linville wrote:
> > Lots of stuff here...probably best for 2.6.23...
>
> Is this best for Linux users... or just easy for developers?
>
> Won't putting off all these fixes until 2.6.23 leave the driver released
> in 2.6.22 in shoddy
corrected diff.
--- 2.6.20/drivers/net/bonding/bond_main.c 2007-05-29
19:43:39.010565000 -0700
+++ 2.6.20.fix/drivers/net/bonding/bond_main.c 2007-05-30
08:18:24.018322000 -0700
@@ -1227,7 +1227,14 @@
int i;
bond_for_each_slave(bond, slave, i) {
- features &= (s
features = features & (dev_features & BOND_INTERSECT_FEATURES);
On 5/30/07, Michael Buesch <[EMAIL PROTECTED]> wrote:
On Wednesday 30 May 2007 04:47:09 Laurent Chavey wrote:
> proposed change.
>
> --- 2.6.20/drivers/net/bonding/bond_main.c 2007-05-29
> 19:43:39.010565000 -0700
> +++ 2.6.20.
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-linus
to receive the following updates:
drivers/net/defxx.c |1 +
drivers/net/e1000/e1000_main.c |9 +++-
drivers/net
On Wed, 2007-30-05 at 11:40 +0200, Patrick McHardy wrote:
> One good thing about ESFQ is the more flexible flow classification, but
> I don't like the concept of having a set of selectable hash functions
> very much.
>
In the spirit of SFQ it is probably ok to do that;
i.e iirc, the idea for j
Jeff Garzik wrote:
Stephen Hemminger wrote:
Some chips need to have internal clocks enabled (via PCI config)
before the PCI space is readable.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
drivers/net/sky2.c | 102
++---
drivers/ne
John W. Linville wrote:
Lots of stuff here...probably best for 2.6.23...
Is this best for Linux users... or just easy for developers?
Won't putting off all these fixes until 2.6.23 leave the driver released
in 2.6.22 in shoddy shape?
libertas is upstream now, so we cannot pretend that the d
John W. Linville wrote:
The following changes since commit d7ea3be56adc95b17351221fd95e78115f3b01f4:
Brandon Craig Rhodes (1):
hostap: Allocate enough tailroom for TKIP
are found in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git
upstr
Thomas Klein wrote:
Must access the respective queue's dummy netdev instead of the port's netdev.
Signed-off-by: Thomas Klein <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Stephen Hemminger wrote:
Several of the PHY registers are multiplexed; access to
register must be proceeded by setting page register.
The driver setup is safer if this is done before the access
rather than depending on the last value.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
NAK f
Stephen Hemminger wrote:
Some chips need to have internal clocks enabled (via PCI config)
before the PCI space is readable.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
drivers/net/sky2.c | 102 ++---
drivers/net/sky2.h | 19 ++
1 - 100 of 131 matches
Mail list logo
