Re: [PATCH][SOCK]: shrink struct sock

2007-05-03 Thread Eric Dumazet
Arnaldo Carvalho de Melo a écrit : [EMAIL PROTECTED] linux-2.6]$ pahole -C sk_buff_head net/core/sock.o struct sk_buff_head { struct sk_buff * next; /* 0 8 */ struct sk_buff * prev; /* 8 8 */ __u32

Re: [PATCH 0/2] natsemi: Improve DspCfg workaround

2007-05-03 Thread Rafał Bilski
> The natsemi driver contains a workaround for broken hardware which can > on some boards cause more problems than it solves. The following patch > series improves this by making the diagnostic more obvious and allowing > users to disable the workaround if it causes them problems. Works great. Th

Re: [PATCH][SOCK]: shrink struct sock

2007-05-03 Thread David Miller
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Date: Fri, 4 May 2007 01:11:01 -0300 > > This saves 8 bytes out of struct sock in 64bit arches, tested on x86_64. Thanks I'll apply this. > Now struct sock has this layout, where we waste more 20 bytes, in four 4 byte > paddings in struct

[PATCH][SOCK]: shrink struct sock

2007-05-03 Thread Arnaldo Carvalho de Melo
Hi David, This saves 8 bytes out of struct sock in 64bit arches, tested on x86_64. [EMAIL PROTECTED] linux-2.6]$ codiff sock.o.before net/core/sock.o /home/acme/git/linux-2.6/net/core/sock.c: struct sock | -8 1 struct changed [EMAIL PROTECTED] linux-2.6]$ Now struct sock has this la

Re: [PATCH] [TCP] Highspeed: Limited slow-start is nowadays in tcp_slow_start

2007-05-03 Thread SANGTAE HA
Hi David, I ran couple of testing to see the limited slow start for HSTCP. For this testing, I set max_ssthresh value to 100. With the slow start, it takes around 4sec to hit the cwnd of 21862 (more than 6000 packet drops for one rtt). With the limited slow start, it takes 108sec to hit the cwnd

Re: [RESEND][PATCH][XFRM] SAD info TLV aggregation

2007-05-03 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 21:44:56 -0400 > Canucks going to survive tonight? ;-> We'll they're going to overtime right now. Harry Neale, who does all the Toronto regular season broadcasts, keeps calling Vancouver "The leafs". He does it about 3 times per game during

[PATCH] Stop ignoring argument in drivers/network/b44.c

2007-05-03 Thread Matthew Martin
This patch uses the phy_id variable in b44_readphy and b44_writephy. Signed-off-by: Matthew Martin <[EMAIL PROTECTED]> --- --- vanilla-linux-2.6.21-git4/drivers/net/b44.c 2007-05-03 11:16:21.0 -0500 +++ linux-2.6.21-git4/drivers/net/b44.c 2007-05-03 17:02:39.0 -0500 @@ -327,45 +

Re: [RESEND][PATCH][XFRM] SAD info TLV aggregation

2007-05-03 Thread jamal
On Thu, 2007-03-05 at 21:01 -0400, jamal wrote: > On Thu, 2007-03-05 at 17:52 -0700, David Miller wrote: > > > I'll sit tight and wait for the next version, whoever > > creates it :-) > > I could send you an incremental patch if that would work > ( a 4+/- liner on the include). > i.e something

Re: [RESEND][PATCH][XFRM] SAD info TLV aggregation

2007-05-03 Thread jamal
On Thu, 2007-03-05 at 17:52 -0700, David Miller wrote: > I'll sit tight and wait for the next version, whoever > creates it :-) I could send you an incremental patch if that would work ( a 4+/- liner on the include). cheers, jamal - To unsubscribe from this list: send the line "unsubscribe n

Re: [RESEND][PATCH][XFRM] SAD info TLV aggregation

2007-05-03 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 20:50:28 -0400 > On Fri, 2007-04-05 at 02:19 +0200, Patrick McHardy wrote: > > > If you dont mind I'm just going to resend myself with fixed > > names tomorrow so you don't have to bother doing this again. > > If you have the cycles please g

Re: [RESEND][PATCH][XFRM] SAD info TLV aggregation

2007-05-03 Thread jamal
On Fri, 2007-04-05 at 02:19 +0200, Patrick McHardy wrote: > If you dont mind I'm just going to resend myself with fixed > names tomorrow so you don't have to bother doing this again. If you have the cycles please go ahead. Otherwise i could do it in a couple of days. cheers, jamal - To unsubscr

Re: [PATCH] IPV6 : Some cleanups in include/net/ipv6.h

2007-05-03 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Thu, 3 May 2007 18:32:08 +0200 > 1) struct ip6_flowlabel : moves 'users' field to avoid two 32bits holes for > 64bit arches. Shrinks by 8 bytes sizeof(struct ip6_flowlabel) > > 2) ipv6_addr_cmp() and ipv6_addr_copy() dont need (void *) casts : > Compi

Re: [PATCH] TCP: zero out rx_opt in tcp_disconnect()

2007-05-03 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 3 May 2007 11:53:36 -0700 > When the server drops its connection, NFS client reconnects using the > same socket after disconnecting. If the new connection's SYN,ACK > doesn't contain the TCP timestamp option and the old connection's did, > tp->tcp_header_len is r

Re: 2.6.20.7 mss negotiation and path mtu discovery mostly broken?

2007-05-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 16:24:20 -0700 > [BNX2]: Fix TSO problem with small MSS. > > Remove the check for skb->len greater than MTU when doing TSO. When > the destination has a smaller MSS than the source, a TSO packet may > be smaller than the MTU at the

Re: [RESEND][PATCH][XFRM] SAD info TLV aggregation

2007-05-03 Thread Patrick McHardy
jamal wrote: > enum xfrm_sadattr_type_t { > - XFRMA_SAD_UNSPEC, > - XFRMA_SADHMASK, > - XFRMA_SADHMAX, > + XFRMA_SADUNSPEC, > XFRMA_SADCNT, > + XFRMA_SADHINFO, > __XFRMA_SAD_MAX > > #define XFRMA_SAD_MAX (__XFRMA_SAD_MAX - 1) I don't want to annoy you unnecessa

Re: [PATCH] Rework dev_base via list_head (v3)

2007-05-03 Thread David Miller
From: Pavel Emelianov <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 19:32:54 +0400 > Netdev tree was updated today soon after I sent a patch for it, > so this version applies to it and the fs/afs/netdevices.c file > is added. Hope I am not late yet again :) > > Cleanup of dev_base list use, with the

Re: [PATCH] Fix ppp_deflate issues with recent zlib_inflate changes

2007-05-03 Thread Andrew Morton
On Thu, 03 May 2007 23:18:09 +0100 Richard Purdie <[EMAIL PROTECTED]> wrote: > The last zlib_inflate update broke certain corner cases for ppp_deflate > decompression handling. This patch fixes some logic to make things work > properly again. Users other than ppp_deflate (the only Z_PACKET_FLUSH >

Re: Routing 600+ vlan's via linux problems (looks like arp problems)

2007-05-03 Thread jamal
On Thu, 2007-03-05 at 14:38 -0700, Stephen Hemminger wrote: > What kernel version? Are you on a recent 2.6 kernel or stuck on some > old "vendor stable" 2.4 kernel? VendorStable(tm)?;-> Sounds to me like an ARP gc challenge to me. If it is, it would help incrementing the values in /proc/sys/

RE: [PATCH] IPROUTE: Modify tc for new PRIO multiqueue behavior

2007-05-03 Thread jamal
On Thu, 2007-03-05 at 14:03 -0700, Waskiewicz Jr, Peter P wrote: > Here is a paper that describes what exactly we're trying to do: > http://www.ieee802.org/3/ar/public/0503/wadekar_1_0503.pdf. Basically > we need the ability to pause a queue independantly of another queue. Ok, this is useful inf

Re: [ofa-general] Re: IPoIB forwarding

2007-05-03 Thread Bryan Lawver
I have been able to install and use the 1.3.0 myricom driver and everything works as I expected and performance is pretty decent. Interesting little side tour through various drivers...The router node sees almost no load which is really encouraging. Thanks, bryan At 03:05 PM 5/1/2007, Loic P

[RESEND][PATCH][IPROUTE2] see SPD info

2007-05-03 Thread jamal
and heres the SPD version ... cheers, jamal [XFRM] see SPD info i.e instead of something like ip xfrm policy ls | grep -i src | wc -l do: ip xfrm policy count And you get the count; you can also pass -s or -s -s to see more details Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]> --- commi

[RESEND] [PATCH][XFRM] SPD info TLV aggregation

2007-05-03 Thread jamal
And heres the SPD version cheers, jamal [XFRM] SPD info TLV aggregation Aggregate the SPD info TLVs. Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]> --- commit bbf6e8386c92047459854427e2f936c58f87d1c1 tree 775125c5526162f9aa1de5105ecc362bdd804817 parent c157d47586129bc4cb8320217df9f80a4dea8

[RESEND][PATCH][IPROUTE2] see SAD info

2007-05-03 Thread jamal
Stephen, Use this patch instead of the one i sent yesterday. As before, you will need to pull include/linux/xfrm.h from net-2.6 once Dave applies the kernel patch. cheers, jamal [XFRM] see SAD info i.e instead of something like ip xfrm state ls | grep -i src | wc -l do: ip xfrm state count And

[RESEND][PATCH][XFRM] SAD info TLV aggregation

2007-05-03 Thread jamal
Ok, heres a resend of the SAD details with IPSEC and HASH info separated. Against net-2.6 Dave, please apply. cheers, jamal [XFRM] SAD info TLV aggregationx Aggregate the SAD info TLVs. Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]> --- commit c157d47586129bc4cb8320217df9f80a4dea8b6f tree

Re: 2.6.20.7 mss negotiation and path mtu discovery mostly broken?

2007-05-03 Thread Michael Chan
On Wed, 2007-04-25 at 13:16 -0700, David Miller wrote: > From: "Ristuccia, Brian" <[EMAIL PROTECTED]> > Date: Wed, 25 Apr 2007 16:11:51 -0400 > > > > I'm seeing a > > > problem where the kernel attempts to send packets with a MSS > > > larger than the one negotiated when the TCP connection is >

[PATCH] Fix ppp_deflate issues with recent zlib_inflate changes

2007-05-03 Thread Richard Purdie
The last zlib_inflate update broke certain corner cases for ppp_deflate decompression handling. This patch fixes some logic to make things work properly again. Users other than ppp_deflate (the only Z_PACKET_FLUSH user) should be unaffected. Fixes bug 8405 (confirmed by the reporter). Signed-off-

Re: Routing 600+ vlan's via linux problems (looks like arp problems)

2007-05-03 Thread Stephen Hemminger
On Thu, 3 May 2007 22:53:46 +0200 Sam Ravnborg <[EMAIL PROTECTED]> wrote: > On Thu, May 03, 2007 at 10:25:48PM +0200, Øyvind Vågen Jægtnes wrote: > > Hi, > Hi Øyvind. > > Forwarding your mail to netdev where the networking people are > hanging out. Maybe they can help you. > > Sam > > >

RE: [PATCH] IPROUTE: Modify tc for new PRIO multiqueue behavior

2007-05-03 Thread Waskiewicz Jr, Peter P
> Lets come up with some terminology; lets call multiqueue what > the qdiscs do; lets call what the NICs do multi-ring. > Note, i have thus far said you need to have both and they > must be in sync. I agree with the terminology. > This maybe _the_ main difference we have in opinion. > Like i sa

Re: Routing 600+ vlan's via linux problems (looks like arp problems)

2007-05-03 Thread Sam Ravnborg
On Thu, May 03, 2007 at 10:25:48PM +0200, Øyvind Vågen Jægtnes wrote: > Hi, Hi Øyvind. Forwarding your mail to netdev where the networking people are hanging out. Maybe they can help you. Sam > > We have a one gigabit internet connection that is normally > routed by a hardware juniper r

Re: [PATCH] [TCP] Highspeed: Limited slow-start is nowadays in tcp_slow_start

2007-05-03 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 3 May 2007 15:34:25 +0300 (EEST) > Reuse limited slow-start (RFC3742) included into tcp_cong instead > of having another implementation in High Speed TCP. > > Compile tested only. > > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> Thanks fo

Re: [PATCH v2 16/16][BNX2]: Update version and reldate.

2007-05-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 00:32:02 -0700 > [BNX2]: Update version and reldate. > > Update version to 1.5.10. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a me

Re: [PATCH v2 13/16][BNX2]: Restructure PHY event handling.

2007-05-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 00:31:06 -0700 > [BNX2]: Restructure PHY event handling. > > Restructure by adding bnx2_phy_event_is_set() to make code cleaner > and easier to understand. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. - To unsubscri

Re: [PATCH v2 14/16][BNX2]: Add 1-shot MSI handler for 5709.

2007-05-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 00:31:38 -0700 > [BNX2]: Add 1-shot MSI handler for 5709. > > The 5709 supports the one-shot MSI handler similar to some of the tg3 > chips. In this mode, the MSI disables itself automatically until it > is re-enabled at the end of

Re: [PATCH v2 15/16][BNX2]: Print bus information for PCIE devices.

2007-05-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 00:31:49 -0700 > [BNX2]: Print bus information for PCIE devices. > > Fix the code to print PCI or PCIE bus information for all devices. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: s

Re: [PATCH v2 10/16][BNX2]: Re-structure the 2.5G Serdes code.

2007-05-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 00:30:20 -0700 > [BNX2]: Re-structure the 2.5G Serdes code. > > Add some common procedures to handle enabling and disabling 2.5G. > Add some missing code to resolve flow control. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]>

Re: [PATCH v2 11/16][BNX2]: Add support for 5709 Serdes.

2007-05-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 00:30:37 -0700 > [BNX2]: Add support for 5709 Serdes. > > Add PCI ID and code to support the 5709 Serdes PHY. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v2 12/16][BNX2]: Add indirect spinlock.

2007-05-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 00:30:48 -0700 > [BNX2]: Add indirect spinlock. > > The indirect register access method will be used by more than one > caller in BH context (NAPI poll and timer), so a spinlock is required. > > Signed-off-by: Michael Chan <[EMAIL P

Re: [PATCH v2 8/16][BNX2]: Add ipv6 TSO and checksum for 5709.

2007-05-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 00:29:53 -0700 > [BNX2]: Add ipv6 TSO and checksum for 5709. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECT

Re: [PATCH v2 9/16][BNX2]: Put MII register offsets in the bnx2 struct.

2007-05-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 00:30:06 -0700 > [BNX2]: Put MII register offsets in the bnx2 struct. > > The 5709 Serdes device uses non-standard MII register offsets. This > re-structuring will make it easier to support 5709 Serdes. > > Signed-off-by: Michael C

Re: [PATCH v2 7/16][BNX2]: Update 5709 firmware.

2007-05-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 00:32:44 -0700 > [BNX2]: Update 5709 firmware. > > Add ipv6 TSO support in firmware. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [PATCH v2 6/16][BNX2]: Update 5708 firmware.

2007-05-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 00:29:36 -0700 > [BNX2]: Update 5708 firmware. > > This fixes the problem of not counting all dropped multicast packets. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "u

Re: [PATCH v2 4/16][BNX2]: Fix race conditions when calling register_netdev().

2007-05-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 00:29:06 -0700 > [BNX2]: Fix race conditions when calling register_netdev(). > > Hot-plug scripts can call bnx2_open() as soon as register_netdev() is > called in bnx2_init_one(). We need to call pci_set_drvdata() and > setup ev

Re: [PATCH v2 5/16][BNX2]: Save PCI state during suspend.

2007-05-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 00:29:19 -0700 > [BNX2]: Save PCI state during suspend. > > This is needed to save the MSI state which will be lost during > suspend. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: sen

Re: [PATCH v2 1/16][BNX2]: Block MII access when ifdown.

2007-05-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 00:28:06 -0700 > [BNX2]: Block MII access when ifdown. > > The device may be in D3hot state and should not allow MII register > access. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: s

Re: [PATCH v2 2/16][BNX2]: Fix register and memory test on 5709.

2007-05-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 00:28:29 -0700 > [BNX2]: Fix register and memory test on 5709. > > Tweak registers and memory test range for 5709. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubsc

Re: [PATCH v2 3/16][BNX2]: Add 40-bit DMA workaround for 5708.

2007-05-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 00:28:50 -0700 > [BNX2]: Add 40-bit DMA workaround for 5708. > > The internal PCIE-to-PCIX bridge of the 5708 has the same 40-bit DMA > limitation as some of the tg3 chips. Set dma_mask and persistent DMA > mask to 40-bit to workaro

Re: [ETHTOOL]: Add 2.5G bit definitions.

2007-05-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 00:25:51 -0700 > [ETHTOOL]: Add 2.5G bit definitions. > > Add 2.5G supported and advertising bit definitions. 2.5G is supported > by the bnx2 driver. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. - To unsubscribe fr

Re: [PATCH][XFRM] SAD info TLV aggregation

2007-05-03 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 09:01:56 -0400 > > In any case consistent naming here would be nice (SAD_ vs. SADXXX). > > yes, i need to make this change on the SPD as well. Dave hold onto both > patches - i will resend. Okie dokie. - To unsubscribe from this list: send t

[PATCH] gianfar: add support for SGMII

2007-05-03 Thread Kim Phillips
From: Kapil Juneja <[EMAIL PROTECTED]> Add code for initialising and configuring TBI interface and programming it for connecting to on-chip SERDES (Lynx PHY) in case of SGMII mode selected through HRCW at reset. also add defines for TBI register configuration. TBI interface is programmed towards

Re: [PATCH 1/5] [NETLINK]: Fix use after free in netlink_recvmsg

2007-05-03 Thread David Miller
From: Marcel Holtmann <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 14:27:16 +0200 > Hi Dave, > > > > When the user passes in MSG_TRUNC the skb is used after getting freed. > > > > > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> > > > Signed-off-by: David Howells <[EMAIL PROTECTED]> > > > >

[PATCH] phylib: m88e1111: enable SGMII mode

2007-05-03 Thread Kim Phillips
From: Kapil Juneja <[EMAIL PROTECTED]> If connected via SGMII, initialize with SGMII mode configured. Signed-off-by: Kapil Juneja <[EMAIL PROTECTED]> Signed-off-by: Andy Fleming <[EMAIL PROTECTED]> Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- please consider for 2.6.22 This patch depends

Re: [ETHTOOL]: Add 2.5G bit definitions.

2007-05-03 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 07:11:31 -0400 > Michael Chan wrote: > > [ETHTOOL]: Add 2.5G bit definitions. > > > > Add 2.5G supported and advertising bit definitions. 2.5G is supported > > by the bnx2 driver. > > > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]

[PATCH] ehea: fix compilation

2007-05-03 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- Compile-tested only. drivers/net/ehea/ehea_main.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/drivers/net/ehea/ehea_main.c +++ b/drivers/net/ehea/ehea_main.c @@ -1799,14 +1799,15 @@ static void ehea_xmit3(struct s

Re: [PATCH] sky2: re-enable 88E8056 for most motherboards

2007-05-03 Thread Daniel Drake
Stephen Hemminger wrote: The PCI info is basically the same between working/non working Gigabyte boards. Is there any other difference? Kernel config? chip revision? I've never seen any reports of the corruption which you describe, so I can't make the comparison myself. Here's the chip info f

[PATCH] TCP: zero out rx_opt in tcp_disconnect()

2007-05-03 Thread Aji_Srinivas
When the server drops its connection, NFS client reconnects using the same socket after disconnecting. If the new connection's SYN,ACK doesn't contain the TCP timestamp option and the old connection's did, tp->tcp_header_len is recomputed assuming no timestamp header but tp->rx_opt.tstamp_ok remain

Re: [Bugme-new] [Bug 8405] New: pppd does stops compresion with "Lost compression sync"

2007-05-03 Thread Stefan Wenk
On Thursday 03 May 2007 02:23, Richard Purdie wrote: > On Wed, 2007-05-02 at 18:59 +0200, Stefan Wenk wrote: > > The situation now is similar as without any modifications. Instead of -5 > > (Z_BUF_ERROR) > > we get back -3 (Z_DATA_ERROR) from zlib_inflate. Here is the kernel log > > > > kernel: PPP

Re: [PATCH v2] gianfar: Add I/O barriers when touching buffer descriptor ownership.

2007-05-03 Thread Segher Boessenkool
So what about some thing like this where we do the read only once? - k diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index a06d8d1..9cd7d1e 100644 --- a/drivers/net/gianfar.c +++ b/drivers/net/gianfar.c @@ -1438,31 +1438,35 @@ int gfar_clean_rx_ring(struct net_device *dev, int rx_w

[PATCH] IPV6 : Some cleanups in include/net/ipv6.h

2007-05-03 Thread Eric Dumazet
1) struct ip6_flowlabel : moves 'users' field to avoid two 32bits holes for 64bit arches. Shrinks by 8 bytes sizeof(struct ip6_flowlabel) 2) ipv6_addr_cmp() and ipv6_addr_copy() dont need (void *) casts : Compiler might take into account natural alignement of in6_addr structs to emit better code

Re: [PATCH v2] gianfar: Add I/O barriers when touching buffer descriptor ownership.

2007-05-03 Thread Scott Wood
Kumar Gala wrote: So what about some thing like this where we do the read only once? - k diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index a06d8d1..9cd7d1e 100644 --- a/drivers/net/gianfar.c +++ b/drivers/net/gianfar.c @@ -1438,31 +1438,35 @@ int gfar_clean_rx_ring(struct net_dev

Re: netfront for review

2007-05-03 Thread Jeremy Fitzhardinge
Gerd Hoffmann wrote: > Drawback is that the guest kernel wouldn't work with older xen > versions (dom0 netback driver to be exact) any more. Probably > wouldn't be a showstopper though, given that xen 3.0.3 probably is > almost one year out by the time 2.6.22 will be released ... I don't think we

Re: netfront for review

2007-05-03 Thread Gerd Hoffmann
Christoph Hellwig wrote: On Thu, May 03, 2007 at 09:33:43AM +0200, Gerd Hoffmann wrote: Guess so. It defaults to flip. I simplified the rx_copy/flip module parameter to a simple rx_mode=0/1, but this is preserved from the original. My guess is that originally there was only flip, and copy was

[PATCH] Rework dev_base via list_head (v3)

2007-05-03 Thread Pavel Emelianov
Netdev tree was updated today soon after I sent a patch for it, so this version applies to it and the fs/afs/netdevices.c file is added. Hope I am not late yet again :) Cleanup of dev_base list use, with the aim to simplify making device list per-namespace. In almost every occasion, use of dev_bas

Re: netfront for review

2007-05-03 Thread Christoph Hellwig
On Thu, May 03, 2007 at 09:33:43AM +0200, Gerd Hoffmann wrote: > >Guess so. It defaults to flip. I simplified the rx_copy/flip module > >parameter to a simple rx_mode=0/1, but this is preserved from the > >original. My guess is that originally there was only flip, and copy was > >added later. >

Re: [PATCH] Rework dev_base via list_head (v2)

2007-05-03 Thread Patrick McHardy
Pavel Emelianov wrote: > Patrick McHardy wrote: > >>This seems to be missing fs/afs/netdevices.c. >> > > > Hm... I've cloned the git repo this morning but there's not such file... > > $ ls fs/afs/netdevices.c > /bin/ls: fs/afs/netdevices.c: No such file or directory > > Repo was cloned from >

RE: [SCTP] Initialization collision problem

2007-05-03 Thread Isaula Oscar-QOI000
Vlad, Will these changes make it into the next Kernel release? If so which one will it be? Thanks, Oscar -Original Message- From: Vlad Yasevich [mailto:[EMAIL PROTECTED] Sent: Tuesday, May 01, 2007 3:19 PM To: Isaula Oscar-QOI000 Cc: netdev@vger.kernel.org Subject: Re: [SCTP] Initializ

Re: [PATCH] Rework dev_base via list_head (v2)

2007-05-03 Thread Pavel Emelianov
Patrick McHardy wrote: > Pavel Emelianov wrote: >> Cleanup of dev_base list use, with the aim to simplify making >> device list per-namespace. In almost every occasion, use of >> dev_base variable and dev->next pointer could be easily replaced >> by for_each_netdev loop. A few most complicated pla

Re: netfront for review

2007-05-03 Thread Gerd Hoffmann
Jeremy Fitzhardinge wrote: Gerd Hoffmann wrote: Gerd, in change 11196:b85da7cd9ea5 "front: Fix rx buffer leak when tearing down an interface." you added a call to "add_id_to_freelist(np->rx_skbs, id);". However, rx_skbs doesn't have an extra entry for the list head, and there's never any corres

Re: netfront for review

2007-05-03 Thread Jeremy Fitzhardinge
Gerd Hoffmann wrote: >> Gerd, in change 11196:b85da7cd9ea5 "front: Fix rx buffer leak when >> tearing down an interface." you added a call to >> "add_id_to_freelist(np->rx_skbs, id);". However, rx_skbs doesn't have >> an extra entry for the list head, and there's never any corresponding >> get_id_

Re: kernel BUG at include/net/tcp.h:739

2007-05-03 Thread Michal Piotrowski
Ilpo Järvinen napisał(a): > On Wed, 2 May 2007, Michal Piotrowski wrote: > >> Please take a look at this bug >> >> [15236.638092] kernel BUG at /mnt/md0/devel/linux-git/include/net/tcp.h:739! >> [15236.644860] invalid opcode: [#1] >> [15236.648514] PREEMPT SMP >> [15236.651075] Modules linke

Re: [PATCH][XFRM] SAD info TLV aggregation

2007-05-03 Thread jamal
On Thu, 2007-03-05 at 15:15 +0200, Patrick McHardy wrote: > > > > I think it may be reasonable to group the Hash info in one TLV > > and the IPSEC specific info in a separate TLV - is this what you are > > saying? Be explicit so i dont have to redo the patch over and over. > > Yes, thats what I

Re: [PATCH][XFRM] SAD info TLV aggregation

2007-05-03 Thread Patrick McHardy
jamal wrote: > On Thu, 2007-03-05 at 02:15 +0200, Patrick McHardy wrote: > > >>I think using attributes here > > > "here" as in SAD or SPD as well? Both. >> wasn't a bad idea since this exports >>things that are implementation details and might need to be changed >>or extended at some point.

Re: [PATCH][XFRM] SAD info TLV aggregation

2007-05-03 Thread jamal
On Thu, 2007-03-05 at 02:15 +0200, Patrick McHardy wrote: > > I think using attributes here "here" as in SAD or SPD as well? > wasn't a bad idea since this exports > things that are implementation details and might need to be changed > or extended at some point. I think it may be reasonable t

Re: [PATCH 1/5] [NETLINK]: Fix use after free in netlink_recvmsg

2007-05-03 Thread Patrick McHardy
Marcel Holtmann wrote: > it seems this could be easily exploited and is at least a local DoS. It > should be a candidate for the -stable kernel. The bug got introduced in 2.6.21-git, so -stable is not affected. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a m

Re: [PATCH v2 16/16][BNX2]: Update version and reldate.

2007-05-03 Thread Jeff Garzik
Michael Chan wrote: [BNX2]: Update version and reldate. Update version to 1.5.10. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> ACK patches 1-16... including an ACK for the big firmware patch that did not make it to the mailing list (due to size). We cannot realistically review the firm

[PATCH] [TCP] Highspeed: Limited slow-start is nowadays in tcp_slow_start

2007-05-03 Thread Ilpo Järvinen
Reuse limited slow-start (RFC3742) included into tcp_cong instead of having another implementation in High Speed TCP. Compile tested only. Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- net/ipv4/tcp_highspeed.c | 24 +++- 1 files changed, 3 insertions(+), 21 deletions

Re: [PATCH 1/5] [NETLINK]: Fix use after free in netlink_recvmsg

2007-05-03 Thread Marcel Holtmann
Hi Dave, > > When the user passes in MSG_TRUNC the skb is used after getting freed. > > > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> > > Signed-off-by: David Howells <[EMAIL PROTECTED]> > > Ugh, good catch, applied :-) it seems this could be easily exploited and is at least a local Do

dead CONFIG_ variables: drivers/net/

2007-05-03 Thread Robert P. J. Day
as with the earlier post for net/, this is for drivers/net/. once again, there are clearly false positives but i'm sure there's *something* in there that might need fixing. == ARCH_INNOKOM == drivers/net/smc91x.h:145:#elif defined(CONFIG_ARCH_INNOKOM) || \ arch/arm/tools/mach-

Re: [PATCH] Rework dev_base via list_head (v2)

2007-05-03 Thread Patrick McHardy
Pavel Emelianov wrote: > Cleanup of dev_base list use, with the aim to simplify making > device list per-namespace. In almost every occasion, use of > dev_base variable and dev->next pointer could be easily replaced > by for_each_netdev loop. A few most complicated places were > converted to using

dead CONFIG_ variables: net/

2007-05-03 Thread Robert P. J. Day
based on a request from patrick mchardy, i'm posting the list of (ostensibly) "dead" CONFIG_ variables found under the entire net/ directory. admittedly, there are false positives in this list for a variety of reasons so don't take everything too seriously, but give it a perusal to identify act

[PATCH] Rework dev_base via list_head (v2)

2007-05-03 Thread Pavel Emelianov
Cleanup of dev_base list use, with the aim to simplify making device list per-namespace. In almost every occasion, use of dev_base variable and dev->next pointer could be easily replaced by for_each_netdev loop. A few most complicated places were converted to using first_netdev()/next_netdev(). C

Re: [ETHTOOL]: Add 2.5G bit definitions.

2007-05-03 Thread Jeff Garzik
Michael Chan wrote: [ETHTOOL]: Add 2.5G bit definitions. Add 2.5G supported and advertising bit definitions. 2.5G is supported by the bnx2 driver. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> ACK. If DaveM does not apply this (since it's required for bnx2), I will apply it. - To unsu

Re: [PATCH] ethtool: Add 2.5G support

2007-05-03 Thread Jeff Garzik
Michael Chan wrote: Add 2.5G Serdes support to ethtool user program and ethtool.8 man page. The missing pause bits are also added to keep ethtool-copy.h in sync with the kernel's version. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> looks good at first glance. will queue, and apply soon

Re: [PATCH] Rework dev_base via list_head

2007-05-03 Thread David Miller
From: Pavel Emelianov <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 14:42:12 +0400 > My fault :( I've found some places where this was missed. > I will make a new patch shortly. Ok, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECT

Re: [PATCH] Rework dev_base via list_head

2007-05-03 Thread Pavel Emelianov
David Miller wrote: > From: Pavel Emelianov <[EMAIL PROTECTED]> > Date: Wed, 02 May 2007 17:40:56 +0400 > >> Cleanup of dev_base list use, with the aim to simplify making >> device list per-namespace. In almost every occasion, use of >> dev_base variable and dev->next pointer could be easily repla

Re: [PATCH 5/5] AFS: Adjust the new netdevice scanning code

2007-05-03 Thread David Miller
From: David Howells <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 10:53:36 +0100 > Adjust the new netdevice scanning code provided by Patrick McHardy: > > (1) Restore the function banner comments that were dropped. > > (2) Rather than using an array size of 6 in some places and an array size of >

Re: kernel BUG at include/net/tcp.h:739

2007-05-03 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 3 May 2007 09:51:36 +0300 (EEST) > [PATCH] [TCP]: Use S+L catcher only with SACK for now > > TCP has a transitional state when SACK is not in use during > which this invariant is temporarily broken. Without SACK, > tcp_clean_rtx_queue does not

Re: [PATCH 4/5] [AFS]: Replace rtnetlink client by direct dev_base walking

2007-05-03 Thread David Miller
From: David Howells <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 10:53:31 +0100 > Replace the large and complicated rtnetlink client by two simple > functions for getting the MAC address for the first ethernet device > and building a list of IPv4 addresses. > > Signed-off-by: Patrick McHardy <[EMAI

Re: [PATCH 3/5] [NET]: Add __dev_getfirstbyhwtype

2007-05-03 Thread David Miller
From: David Howells <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 10:53:26 +0100 > Add __dev_getfirstbyhwtype for callers that don't want a reference but > some data from the device and thus need to take the rtnl anyway. > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> > Signed-off-by: David H

Re: [PATCH 2/5] [AFS]: Fix memory leak in SRXAFSCB_GetCapabilities

2007-05-03 Thread David Miller
From: David Howells <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 10:53:20 +0100 > The interface array is not freed on exit. > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> > Signed-off-by: David Howells <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "uns

Re: [PATCH 1/5] [NETLINK]: Fix use after free in netlink_recvmsg

2007-05-03 Thread David Miller
From: David Howells <[EMAIL PROTECTED]> Date: Thu, 03 May 2007 10:53:15 +0100 > When the user passes in MSG_TRUNC the skb is used after getting freed. > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> > Signed-off-by: David Howells <[EMAIL PROTECTED]> Ugh, good catch, applied :-) - To unsub

Re: [PATCH] Rework dev_base via list_head

2007-05-03 Thread David Miller
From: Pavel Emelianov <[EMAIL PROTECTED]> Date: Wed, 02 May 2007 17:40:56 +0400 > Cleanup of dev_base list use, with the aim to simplify making > device list per-namespace. In almost every occasion, use of > dev_base variable and dev->next pointer could be easily replaced > by for_each_netdev loo

Re: finding your own dead "CONFIG_" variables

2007-05-03 Thread Robert P. J. Day
On Thu, 3 May 2007, Arnd Bergmann wrote: > On Thursday 03 May 2007, Robert P. J. Day wrote: > > > Suggest: configfiles=$(find . -name 'Kconfig*' -or -name '*defconfig*') > > > > > > Some CONFIG_ options exist that are not declared anywhere in the > > > Kconfig files but defined directly in the arc

Re: [NETLINK] Don't attach callback to a going-away netlink socket

2007-05-03 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 2 May 2007 14:12:22 +1000 > Dave, thanks for reminding me. Here it is. > > [NETLINK]: Kill CB only when socket is unused > > Since we can still receive packets until all references to the > socket are gone, we don't need to kill the CB until that

Re: [PATCH] skbuff: fix kernel-doc

2007-05-03 Thread David Miller
From: Randy Dunlap <[EMAIL PROTECTED]> Date: Tue, 1 May 2007 18:21:56 -0700 > From: Randy Dunlap <[EMAIL PROTECTED]> > > Fix skbuff.h kernel-doc: > linux-2.6.21-git4//include/linux/skbuff.h:316): No description found for > parameter 'transport_header' > > Signed-off-by: Randy Dunlap <[EMAIL PRO

[PATCH] smc91x SuperH support

2007-05-03 Thread Nobuhiro Iwamatsu
Hi, all. This patch supports SuperH of smc91x. smc91x installed on the board of SuperH comes to work by applying this patch. Please apply this patch . regards, Nobuhiro -- Nobuhiro Iwamatsu E-Mail : [EMAIL PROTECTED] GPG ID : 3170EBE9 Signed-off-by: Nobuhiro Iwamatsu <[EMA

Re: [PATCH 6/6] [IPV4] SNMP: Display new statistics at /proc/net/snmp

2007-05-03 Thread David Miller
From: Mitsuru Chinen <[EMAIL PROTECTED]> Date: Wed, 2 May 2007 10:05:13 +0900 > [IPV4] SNMP: Display new statistics at /proc/net/netstat > > This displays the statistics specified in the updated IP-MIB RFC > (RFC4293) in /proc/net/netstat. The reason why these are not added > to /proc/net/snmp is

Re: [PATCH] AFS: Fix use of __exit functions from __init path

2007-05-03 Thread David Miller
From: David Howells <[EMAIL PROTECTED]> Date: Tue, 01 May 2007 19:17:06 +0100 > Fix use of __exit functions from __init path. > > Signed-off-by: David Howells <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTE

Re: [PATCH 2/2] AFS/AF_RXRPC: Miscellaneous fixes

2007-05-03 Thread David Miller
From: David Howells <[EMAIL PROTECTED]> Date: Tue, 01 May 2007 18:47:52 +0100 > Make miscellaneous fixes to AFS and AF_RXRPC: > > (*) Make AF_RXRPC select KEYS rather than RXKAD or AFS_FS in Kconfig. > > (*) Don't use FS_BINARY_MOUNTDATA. > > (*) Remove a done 'TODO' item in a comemnt on afs

Re: [PATCH 1/2] AFS: Make the match_*() functions take const options

2007-05-03 Thread David Miller
From: David Howells <[EMAIL PROTECTED]> Date: Tue, 01 May 2007 18:47:47 +0100 > Make the match_*() functions take a const pointer to the options table and > make strings pointers in the options table const too. > > Signed-off-by: David Howells <[EMAIL PROTECTED]> I'll take this, applied, thanks

Re: [PATCH] IPV6 : get rid of __HAVE_ARCH_ADDR_SET

2007-05-03 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Tue, 01 May 2007 06:00:09 +0200 > __HAVE_ARCH_ADDR_SET seems unused these days, just get rid of it. > > Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> Applied, thanks Eric. - To unsubscribe from this list: send the line "unsubscribe netdev" in the bo

  1   2   >