RE: d80211-drivers pull request (week-48)

2006-12-14 Thread Simon Barber
Devicescape does understant that the hardware can do retries - but it adds software retries on top. This allows higher reliability, as well as correct handling of the powersave state machine. (PS bit from a STA is supposed to stop APs transmission immediately). Simon -Original Message- Fr

RE: [PATCH 5/6] d80211: add IEEE 802.11e Direct Link Setup (DLS) support

2006-12-14 Thread Simon Barber
Again - this DLS management frame processing code should not be in the kernel - it should be in wpa_supplicant. Only the frame processing code should be in the kernel. Simon -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Zhu Yi Sent: Wednesday, Decemb

RE: [PATCH 6/6] d80211: add sysfs interface for QoS functions

2006-12-14 Thread Simon Barber
This is all part of the client MLME - it would be much better to add this functionality to wpa_supplicant, rather than adding it to the kernel. Nothing here needs to be in the kernel for any reason. The client MLME functions that are in the kernel were put in there for test and debugging convenien

RE: [PATCH 4/6] d80211: add IEEE802.11e/WMM Traffic Stream (TS) Management support

2006-12-14 Thread Simon Barber
This policing of media time must be done in the qdisc - and made to work per DA (Destination Address) - in order that AP mode will work as well as STA mode. In addition the count of used time should be updated AFTER the frame has been sent, not before, since the number of retries done cannot be tak

RE: [PATCH 1/6] d80211: add IEEE802.11e/WMM MLMEs, Status Code and Reason Code

2006-12-14 Thread Simon Barber
None of this should be in the kernel. See wpa_supplicant. Simon -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Zhu Yi Sent: Wednesday, December 13, 2006 8:02 PM To: netdev@vger.kernel.org Subject: [PATCH 1/6] d80211: add IEEE802.11e/WMM MLMEs, Status Co

Re: 2.6.20-rc1 sky2 problems (regression?)

2006-12-14 Thread Alex Romosan
Stephen Hemminger <[EMAIL PROTECTED]> writes: > I have a fixed up version of the vendor driver, I'll repackage it tomorrow. as per the include file, i ended up replacing all the CHECKSUM_HW with CHECkSUM_PARTIAL since the functions in questions had to do with transmit. seems to be working so far

Re: [PATCH 6/6] d80211: add sysfs interface for QoS functions

2006-12-14 Thread Zhu Yi
On Thu, 2006-12-14 at 12:23 +0100, Jiri Benc wrote: > So... what about implementing that into cfg80211? :-) > > I'm not inclined towards this patch (even if you address Stephen's > comment). OK. This is only for my testing (or maybe someone else wants to try the code). I'm not asking to merge it

Re: [PATCH 2/6] d80211: create "wifi.h" to define WIFI OUIs

2006-12-14 Thread Zhu Yi
On Thu, 2006-12-14 at 11:31 +0100, Jiri Benc wrote: > AFAIK "wifi" is a trademark and we want to avoid using it. "wlan" seems > to be a better alternative for the prefixes. Also, I don't see a reason > for a separate header file here. WI-FI(r) is a trademark, but wifi and WIFI_XXX are not. I'm OK

Re: 2.6.20-rc1 sky2 problems (regression?)

2006-12-14 Thread Stephen Hemminger
On Fri, 15 Dec 2006 13:24:32 +1100 Herbert Xu <[EMAIL PROTECTED]> wrote: > Alex Romosan <[EMAIL PROTECTED]> wrote: > /** does the HW need to evaluate checksum for TCP or UDP packets? > > if (pMessage->ip_summed == CHECKSUM_HW) > > > > maybe this needs to be replace with CHECKSUM_PARTIAL. the sec

Re: [PATCH 1/6] d80211: add IEEE802.11e/WMM MLMEs, Status Code and Reason Code

2006-12-14 Thread Zhu Yi
On Thu, 2006-12-14 at 11:27 +0100, Jiri Benc wrote: > On Thu, 14 Dec 2006 12:02:04 +0800, Zhu Yi wrote: > > Signed-off-by: Zhu Yi <[EMAIL PROTECTED]> > > Please Cc: me and John Linville on d80211 patches otherwise your > chances of review (and inclusion) are much lower. > > In addition to comment

Re: [PATCH 13/22] e1000: disable TSO when debugging slab

2006-12-14 Thread Herbert Xu
Jeff Garzik <[EMAIL PROTECTED]> wrote: >> >> +#ifdef CONFIG_DEBUG_SLAB >> + /* 82544's work arounds do not play nicely with DEBUG SLAB */ >> + if (adapter->hw.mac_type == e1000_82544) >> + netdev->features &= ~NETIF_F_TSO; >> +#endif > > ACK, provided that you greatly enhance

Re: 2.6.20-rc1 sky2 problems (regression?)

2006-12-14 Thread Herbert Xu
Alex Romosan <[EMAIL PROTECTED]> wrote: /** does the HW need to evaluate checksum for TCP or UDP packets? > if (pMessage->ip_summed == CHECKSUM_HW) > > maybe this needs to be replace with CHECKSUM_PARTIAL. the second one > > /** TCP checksum offload > if ((pSKPacket->pMbuf->ip_summed == CHECKSUM

Fw: 2.6.20-rc1 sky2 problems (regression?)

2006-12-14 Thread Andrew Morton
Begin forwarded message: Date: Thu, 14 Dec 2006 12:47:05 -0800 From: Alex Romosan <[EMAIL PROTECTED]> To: linux-kernel@vger.kernel.org Subject: 2.6.20-rc1 sky2 problems (regression?) under heavy network load the sky2 driver (compiled in the kernel) locks up and the only way i can get the netwo

Re: [PATCH 12/14] Spidernet Avoid possible RX chain corruption

2006-12-14 Thread Michael Ellerman
On Thu, 2006-12-14 at 11:15 -0600, Linas Vepstas wrote: > On Thu, Dec 14, 2006 at 11:22:43AM +1100, Michael Ellerman wrote: > > > spider_net_refill_rx_chain(card); > > > - spider_net_enable_rxchtails(card); > > > spider_net_enable_rxdmac(card); > > > return 0; > > > > Didn't you just add tha

Re: 2.6.20-rc1 sky2 problems (regression?)

2006-12-14 Thread Alex Romosan
Stephen Hemminger <[EMAIL PROTECTED]> writes: > If this is repeatable... and mac_pause is always one then the > problem is hardware flow control. I saw bugs before in the bus > interface where it would not resume on unaligned buffer, but > that was on receive. i tried to switch over to the lates

Re: [patch sungem] improved locking

2006-12-14 Thread Benjamin Herrenschmidt
On Tue, 2006-12-12 at 06:49 +0100, Eric Lemoine wrote: > On 12/12/06, Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > On Tue, 2006-12-12 at 06:33 +0100, Eric Lemoine wrote: > > > On 12/12/06, David Miller <[EMAIL PROTECTED]> wrote: > > > > [...] > > > > Anyways, Eric your changes look fine as

Re: [PATCH 2.6.19-git19] BUG due to bad argument to ieee80211softmac_assoc_work

2006-12-14 Thread Larry Finger
Michael Bommarito wrote: Hello Uli, Yes, apologies, I had been waiting for an abandoned bugzilla entry to get attention, and when I realized it was assigned to a dead-end, I had simply posted the patch without checking for prior messages. I was further confused by the fact that it hadn't made i

Re: dhcpclient netlink bugs (was Re: [NETLINK]: Schedule removal of old macros exported to userspace)

2006-12-14 Thread Herbert Xu
Stefan Rompf <[EMAIL PROTECTED]> wrote: > > Yes, the code has quite some trust into the kernel that if it answers the > asked question the answer is semantically correct. But to be fair, if you > issue a write(), you also expect the number of bytes written in return and > not the msec taken ;-)

Re: [PATCH 1/3][BNX2]: Fix panic in bnx2_tx_int().

2006-12-14 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 13 Dec 2006 18:30:33 -0800 > [BNX2]: Fix panic in bnx2_tx_int(). > > There was an off-by-one bug in bnx2_tx_avail(). If the tx ring is > completely full, the producer and consumer indices may be apart by > 256 even though the ring size is only

Re: [PATCH 2/3][BNX2]: Fix bug in bnx2_nvram_write().

2006-12-14 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 13 Dec 2006 18:30:39 -0800 > [BNX2]: Fix bug in bnx2_nvram_write(). > > Length was not calculated correctly if the NVRAM offset is on a non- > aligned offset. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied, thanks a lot. - To unsu

Re: [PATCH 3/3][BNX2]: Fix minor loopback problem.

2006-12-14 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 13 Dec 2006 18:31:19 -0800 > [BNX2]: Fix minor loopback problem. > > Use the configured MAC address instead of the permanent MAC address > for loopback frames. > > Update version to 1.5.2. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> A

Re: [AX.25 7/7] Fix unchecked rose_add_loopback_neigh uses

2006-12-14 Thread David Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Thu, 14 Dec 2006 23:42:13 +0100 > rose_add_loopback_neigh uses kmalloc and the callers were ignoring the > error value. Rewrite to let the caller deal with the allocation. This > allows the use of static allocation of kmalloc use entirely. > > Signed

Re: [AX.25 6/7] Fix unchecked rose_add_loopback_node uses

2006-12-14 Thread David Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Thu, 14 Dec 2006 23:42:12 +0100 > Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/

Re: [AX.25 1/7] Mark all kmalloc users __must_check

2006-12-14 Thread David Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Thu, 14 Dec 2006 23:42:07 +0100 > The recent fix 0506d4068bad834aab1141b5dc5e748eb175c6b3 made obvious that > error values were not being propagated through the AX.25 stack. To help > with that this patch marks all kmalloc users in the AX.25, NETROM an

Re: [AX.25 2/7] Fix unchecked ax25_protocol_register uses.

2006-12-14 Thread David Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Thu, 14 Dec 2006 23:42:08 +0100 > Replace ax25_protocol_register by ax25_register_pid which assumes the > caller has done the memory allocation. This allows replacing the > kmalloc allocations entirely by static allocations. > > Signed-off-by: Ralf Ba

Re: [AX.25 5/7] Fix unchecked ax25_linkfail_register uses

2006-12-14 Thread David Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Thu, 14 Dec 2006 23:42:11 +0100 > ax25_linkfail_register uses kmalloc and the callers were ignoring the > error value. Rewrite to let the caller deal with the allocation. This > allows the use of static allocation of kmalloc use entirely. > > Signed-

Re: [AX.25 4/7] Fix unchecked nr_add_node uses

2006-12-14 Thread David Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Thu, 14 Dec 2006 23:42:10 +0100 > Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/

Re: [AX.25 3/7] Fix unchecked ax25_listen_register uses

2006-12-14 Thread David Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Thu, 14 Dec 2006 23:42:09 +0100 > Fix ax25_listen_register to return something that's a sane error code, > then all callers to use it. > > Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubsc

[announce] iproute2 2.6.19-061214

2006-12-14 Thread Stephen Hemminger
This is an update to the iproute2 command set. It can be downloaded from: http://developer.osdl.org/dev/iproute2/download/iproute2-2.6.18-061214.tar.gz Repository: git://git.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git For more info on iproute2 see: http://linux-net.osdl.org/

Re: 2.6.20-rc1 sky2 problems (regression?)

2006-12-14 Thread Stephen Hemminger
On Thu, 14 Dec 2006 15:21:00 -0800 Alex Romosan <[EMAIL PROTECTED]> wrote: > Stephen Hemminger <[EMAIL PROTECTED]> writes: > > > Another useful bit of information is the statistics (ethtool -S eth0). > > When there were flow control bugs, they would show up as count of 1. > > the driver locked u

Re: 2.6.20-rc1 sky2 problems (regression?)

2006-12-14 Thread Alex Romosan
Stephen Hemminger <[EMAIL PROTECTED]> writes: > Another useful bit of information is the statistics (ethtool -S eth0). > When there were flow control bugs, they would show up as count of 1. the driver locked up again, even with msi interrupts disabled and idle_timeout=10. the console message was

[AX.25 5/7] Fix unchecked ax25_linkfail_register uses

2006-12-14 Thread Ralf Baechle
ax25_linkfail_register uses kmalloc and the callers were ignoring the error value. Rewrite to let the caller deal with the allocation. This allows the use of static allocation of kmalloc use entirely. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> include/net/ax25.h | 10 +++- net/a

[AX.25 3/7] Fix unchecked ax25_listen_register uses

2006-12-14 Thread Ralf Baechle
Fix ax25_listen_register to return something that's a sane error code, then all callers to use it. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> net/ax25/ax25_iface.c |7 --- net/netrom/nr_dev.c | 24 ++-- net/rose/af_rose.c|3 ++- 3 files changed, 24 in

[AX.25 6/7] Fix unchecked rose_add_loopback_node uses

2006-12-14 Thread Ralf Baechle
Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> net/rose/rose_dev.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) Index: linux-net/net/rose/rose_dev.c === --- linux-net.orig/net/rose/rose_dev.c +++

[AX.25 2/7] Fix unchecked ax25_protocol_register uses.

2006-12-14 Thread Ralf Baechle
Replace ax25_protocol_register by ax25_register_pid which assumes the caller has done the memory allocation. This allows replacing the kmalloc allocations entirely by static allocations. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> include/net/ax25.h |9 - net/ax25/ax25_iface

[AX.25 1/7] Mark all kmalloc users __must_check

2006-12-14 Thread Ralf Baechle
The recent fix 0506d4068bad834aab1141b5dc5e748eb175c6b3 made obvious that error values were not being propagated through the AX.25 stack. To help with that this patch marks all kmalloc users in the AX.25, NETROM and ROSE stacks as __must_check. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> in

[AX.25 7/7] Fix unchecked rose_add_loopback_neigh uses

2006-12-14 Thread Ralf Baechle
rose_add_loopback_neigh uses kmalloc and the callers were ignoring the error value. Rewrite to let the caller deal with the allocation. This allows the use of static allocation of kmalloc use entirely. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> include/net/rose.h |4 ++-- net/ro

[AX.25 4/7] Fix unchecked nr_add_node uses

2006-12-14 Thread Ralf Baechle
Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> net/netrom/nr_route.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) Index: linux-net/net/netrom/nr_route.c === --- linux-net.orig/net/netrom/nr_route.c +++ linux-

Re: 2.6.20-rc1 sky2 problems (regression?)

2006-12-14 Thread Alex Romosan
Stephen Hemminger <[EMAIL PROTECTED]> writes: > Another useful bit of information is the statistics (ethtool -S > eth0). When there were flow control bugs, they would show up as > count of 1. > > Are you doing jumbo frames (MTU > 1500)? i just did 'ethtool -S eth0' (the card is still working fine

Re: [PATCH 1/4] net: make dev_kfree_skb_irq not inline

2006-12-14 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Thu, 14 Dec 2006 22:30:09 + > Maybe you should only move the slowpath out of line ala: > > static inline void dev_kfree_skb_irq(struct sk_buff *skb) > { > if (atomic_dec_and_test(&skb->users)) > __dev_kfree_skb_irq(skb); >

Re: [PATCH 4/4][SCTP]: Change adaption -> adaptation as per the latest API draft.

2006-12-14 Thread David Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Thu, 14 Dec 2006 14:22:16 -0800 > On Wed, 2006-12-13 at 18:03 -0800, David Miller wrote: > > From: Sridhar Samudrala <[EMAIL PROTECTED]> > > Date: Wed, 13 Dec 2006 17:38:52 -0800 > > > > > These parameters are not used by user-space apps. They def

Re: 2.6.20-rc1 sky2 problems (regression?)

2006-12-14 Thread Alex Romosan
Stephen Hemminger <[EMAIL PROTECTED]> writes: > Another useful bit of information is the statistics (ethtool -S eth0). > When there were flow control bugs, they would show up as count of 1. we'll see if the machine locks up again. > Are you doing jumbo frames (MTU > 1500)? no (or at least i don

Re: NAPI wait before enabling irq's [was Re: [Cbe-oss-dev] Spider DMA wrongness]

2006-12-14 Thread Linas Vepstas
On Thu, Dec 14, 2006 at 12:51:14PM -0800, [EMAIL PROTECTED] wrote: > On Thu, 14 Dec 2006, Linas Vepstas wrote: > > >On Wed, Nov 08, 2006 at 07:38:12AM +1100, Benjamin Herrenschmidt wrote: > >> > >>What about Linas patches to do interrupt mitigation with NAPI polling ? > >>That didn't end up workin

Re: 2.6.20-rc1 sky2 problems (regression?)

2006-12-14 Thread Stephen Hemminger
On Thu, 14 Dec 2006 14:25:06 -0800 Alex Romosan <[EMAIL PROTECTED]> wrote: > Stephen Hemminger <[EMAIL PROTECTED]> writes: > > > 4) What is the IRQ routing? > >There are two issues here, first the driver will never work with edge > >trigger IRQ's, some motherboards also have busted BIOS a

Re: [PATCH 1/4] net: make dev_kfree_skb_irq not inline

2006-12-14 Thread Stephen Hemminger
On Thu, 14 Dec 2006 22:30:09 + Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Thu, Dec 14, 2006 at 12:48:15PM -0800, Stephen Hemminger wrote: > > Move the dev_kfree_skb_irq function from netdevice.h to dev.c > > for a couple of reasons. Primarily, I want to make softnet_data > > local to de

Re: [PATCH 1/4] net: make dev_kfree_skb_irq not inline

2006-12-14 Thread Christoph Hellwig
On Thu, Dec 14, 2006 at 12:48:15PM -0800, Stephen Hemminger wrote: > Move the dev_kfree_skb_irq function from netdevice.h to dev.c > for a couple of reasons. Primarily, I want to make softnet_data > local to dev.c; also this function is called 300+ places already. > > Signed-off-by: Stephen Hemmin

Re: 2.6.20-rc1 sky2 problems (regression?)

2006-12-14 Thread Alex Romosan
Stephen Hemminger <[EMAIL PROTECTED]> writes: > 4) What is the IRQ routing? >There are two issues here, first the driver will never work with edge >trigger IRQ's, some motherboards also have busted BIOS and chipsets >that don't do MSI properly. A couple of module parameters are availab

Re: [PATCH 4/4][SCTP]: Change adaption -> adaptation as per the latest API draft.

2006-12-14 Thread Sridhar Samudrala
On Wed, 2006-12-13 at 18:03 -0800, David Miller wrote: > From: Sridhar Samudrala <[EMAIL PROTECTED]> > Date: Wed, 13 Dec 2006 17:38:52 -0800 > > > These parameters are not used by user-space apps. They define the > > parameters used by the protocol in SCTP headers that go on wire. > > There is no

Re: 2.6.20-rc1 sky2 problems (regression?)

2006-12-14 Thread Alex Romosan
Stephen Hemminger <[EMAIL PROTECTED]> writes: > On Thu, 14 Dec 2006 12:47:05 -0800 > Alex Romosan <[EMAIL PROTECTED]> wrote: > >> under heavy network load the sky2 driver (compiled in the kernel) >> locks up and the only way i can get the network back is to reboot the >> machine (bringing the netw

Re: [PATCH 2.6.19-git19] BUG due to bad argument to ieee80211softmac_assoc_work

2006-12-14 Thread Michael Bommarito
Hello Uli, Yes, apologies, I had been waiting for an abandoned bugzilla entry to get attention, and when I realized it was assigned to a dead-end, I had simply posted the patch without checking for prior messages. I was further confused by the fact that it hadn't made its way into any of the 19-

Re: [PATCH 2.6.19-git19] BUG due to bad argument to ieee80211softmac_assoc_work

2006-12-14 Thread Uli Kunitz
Michael, I sent a patch to this list on Sunday, that patched the problem. It seems to be migrated into the wireless-2.6 git tree. Regards, Uli Am 13.12.2006 um 19:17 schrieb Michael Bommarito: This didn't get much attention on bugzilla and I figured it was important enough to forward along

Re: 2.6.20-rc1 sky2 problems (regression?)

2006-12-14 Thread Stephen Hemminger
On Thu, 14 Dec 2006 12:47:05 -0800 Alex Romosan <[EMAIL PROTECTED]> wrote: > under heavy network load the sky2 driver (compiled in the kernel) > locks up and the only way i can get the network back is to reboot the > machine (bringing the network down and back up again doesn't help). > this happen

Re: NAPI wait before enabling irq's [was Re: [Cbe-oss-dev] Spider DMA wrongness]

2006-12-14 Thread akepner
On Thu, 14 Dec 2006, Linas Vepstas wrote: On Wed, Nov 08, 2006 at 07:38:12AM +1100, Benjamin Herrenschmidt wrote: What about Linas patches to do interrupt mitigation with NAPI polling ? That didn't end up working ? It seems to be "working as designed", which is different than "working as nai

[PATCH 3/4] net: move softnet_data

2006-12-14 Thread Stephen Hemminger
Make softnet_data local to dev.c. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- linux-2.6.20-rc1.orig/include/linux/netdevice.h +++ linux-2.6.20-rc1/include/linux/netdevice.h @@ -600,6 +600,9 @@ extern int dev_restart(struct net_devic #ifdef CONFIG_NETPOLL_TRAP extern int

[PATCH 0/4] network device interface cleanups

2006-12-14 Thread Stephen Hemminger
This set of patches makes softnet_data local to dev.c and does some code cleanups, no API changes. -- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 4/4] net: rearrange functions in netdevice.h

2006-12-14 Thread Stephen Hemminger
Use existing inline functions rather than having multiple copies of same code. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- linux-2.6.20-rc1.orig/include/linux/netdevice.h +++ linux-2.6.20-rc1/include/linux/netdevice.h @@ -615,9 +615,14 @@ static inline int unregister_gifconf(uns

[PATCH 2/4] net: uninline netif_rx_reschedule

2006-12-14 Thread Stephen Hemminger
Move netif_rx_reschedule out of line, so that softnet_data can be made local. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- linux-2.6.20-rc1.orig/include/linux/netdevice.h +++ linux-2.6.20-rc1/include/linux/netdevice.h @@ -851,21 +851,7 @@ static inline void netif_rx_schedule(str /*

NAPI wait before enabling irq's [was Re: [Cbe-oss-dev] Spider DMA wrongness]

2006-12-14 Thread Linas Vepstas
On Wed, Nov 08, 2006 at 07:38:12AM +1100, Benjamin Herrenschmidt wrote: > > What about Linas patches to do interrupt mitigation with NAPI polling ? > That didn't end up working ? It seems to be "working as designed", which is different than "working as naively expected". For large packets: -- a

[PATCH 1/4] net: make dev_kfree_skb_irq not inline

2006-12-14 Thread Stephen Hemminger
Move the dev_kfree_skb_irq function from netdevice.h to dev.c for a couple of reasons. Primarily, I want to make softnet_data local to dev.c; also this function is called 300+ places already. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- linux-2.6.20-rc1.orig/include/linux/netdevice.h

Re: [RFC] split NAPI from network device.

2006-12-14 Thread Benjamin Herrenschmidt
On Wed, 2006-12-13 at 15:46 -0800, Stephen Hemminger wrote: > Split off NAPI part from network device, this patch is build tested > only! It breaks kernel API for network devices, and only three examples > are fixed (skge, sky2, and tg3). > > 1. Decomposition allows different NAPI <-> network devi

Revised: [PATCH 1/14] Spidernet DMA coalescing

2006-12-14 Thread Linas Vepstas
Andrew, I'm hoping its not irritatingly obthersome to ask you to rip out the first patch of this series, and replace it with the one below. On Thu, Dec 14, 2006 at 05:35:34PM +, Christoph Hellwig wrote: > On Thu, Dec 14, 2006 at 11:07:37AM -0600, Linas Vepstas wrote: > > Being unclear on

[PATCH 1/2] d80211: Turn PHYmode list from an array into a linked list

2006-12-14 Thread Michael Buesch
This turns the PHY-modes list into a linked list. The advantage is that drivers can add modes dynamically, as they probe them and don't have to settle to a given arraysize at the beginning of probing. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> -- Note that I will also send fixup patches f

[PATCH 2/2] bcm43xx-d80211: Fix for PHYmode API change.

2006-12-14 Thread Michael Buesch
This fixes the PHYmode list API breakage for the bcm43xx-d80211 driver. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: bu3sch-wireless-dev/drivers/net/wireless/d80211/bcm43xx/bcm43xx.h === --- bu3sch-wireless-dev.orig/drive

Re: [PATCH 12/14] Spidernet Avoid possible RX chain corruption

2006-12-14 Thread Christoph Hellwig
On Thu, Dec 14, 2006 at 11:15:11AM -0600, Linas Vepstas wrote: > On Thu, Dec 14, 2006 at 11:22:43AM +1100, Michael Ellerman wrote: > > > spider_net_refill_rx_chain(card); > > > - spider_net_enable_rxchtails(card); > > > spider_net_enable_rxdmac(card); > > > return 0; > > > > Didn't you just

Re: [PATCH 1/14] Spidernet DMA coalescing

2006-12-14 Thread Christoph Hellwig
On Thu, Dec 14, 2006 at 11:07:37AM -0600, Linas Vepstas wrote: > Being unclear on the concept, should a send a new version of this patch, > or should I send a new patch that removes this? For just the memset issue an incremental patch would be fine. But given the small mistake in the patch descri

Re: [PATCH 12/14] Spidernet Avoid possible RX chain corruption

2006-12-14 Thread Linas Vepstas
On Thu, Dec 14, 2006 at 11:22:43AM +1100, Michael Ellerman wrote: > > spider_net_refill_rx_chain(card); > > - spider_net_enable_rxchtails(card); > > spider_net_enable_rxdmac(card); > > return 0; > > Didn't you just add that line? Dagnabbit. The earlier pach was moving around existin

Re: [PATCH 1/14] Spidernet DMA coalescing

2006-12-14 Thread Linas Vepstas
On Thu, Dec 14, 2006 at 11:05:17AM +, Christoph Hellwig wrote: > On Wed, Dec 13, 2006 at 03:06:59PM -0600, Linas Vepstas wrote: > > > > The current driver code performs 512 DMA mappings of a bunch of > > 32-byte ring descriptor structures. This is silly, as they are > > all in contiguous mem

[PATCH 3/3] d80211: fix workqueue breakage (v2)

2006-12-14 Thread Michael Wu
d80211: fix workqueue breakage This patch updates d80211 to use the new workqueue API. Signed-off-by: Michael Wu <[EMAIL PROTECTED]> --- net/d80211/ieee80211.c |7 --- net/d80211/ieee80211_i.h |8 +--- net/d80211/ieee80211_iface.c |2 +- net/d80211/ieee80211_sta.c

Re: [PATCH 2.6.19-git19] BUG due to bad argument to ieee80211softmac_assoc_work

2006-12-14 Thread Johannes Berg
On Wed, 2006-12-13 at 13:17 -0500, Michael Bommarito wrote: > Attached is a patch that fixes this (the actual change is two lines > but context provided in patch for review). The dmesg containing call > trace is attached to the bugzilla entry above. You forgot to attach the patch but IIRC it's b

Re: [PATCH 6/6] d80211: add sysfs interface for QoS functions

2006-12-14 Thread Johannes Berg
On Thu, 2006-12-14 at 12:23 +0100, Jiri Benc wrote: > On Thu, 14 Dec 2006 12:03:02 +0800, Zhu Yi wrote: > > The sysfs interface here is only a proof of concept. It provides a way for > > the userspace applications to use the advanced QoS features supported by > > d80211 stack. The finial solution s

[PATCH][RFC] tcp: fix ambiguity in the `before' relation

2006-12-14 Thread Gerrit Renker
While looking at DCCP sequence numbers, I stumbled over a problem with the following definition of before in tcp.h: static inline int before(__u32 seq1, __u32 seq2) { return (__s32)(seq1-seq2) < 0; } Problem: This definition suffers from an an ambiguity, i.e. always

[PATCH v4 11/13] Core Resource Allocation

2006-12-14 Thread Steve Wise
Core functions to carve up adapter memory, stag, qp, and cq IDs. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/core/cxio_resource.c | 331 ++ drivers/infiniband/hw/cxgb3/core/cxio_resource.h | 70 + 2 files changed, 401 insertions(+), 0

[PATCH v4 12/13] Core Debug functions

2006-12-14 Thread Steve Wise
Debug code to dump various data structs, some of which are in adapter memory. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/core/cxio_dbg.c | 205 +++ 1 files changed, 205 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw

[PATCH v4 01/13] Linux RDMA Core Changes

2006-12-14 Thread Steve Wise
Support provider-specific data in ib_uverbs_cmd_req_notify_cq(). The Chelsio iwarp provider library needs to pass information to the kernel verb for re-arming the CQ. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/core/uverbs_cmd.c |9 +++-- drivers/infiniband

[PATCH v4 10/13] Core HAL

2006-12-14 Thread Steve Wise
The RDMA Core interfaces with the T3 HW and ULLD providing a low level RDMA interface. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/core/cxio_hal.c | 1302 +++ drivers/infiniband/hw/cxgb3/core/cxio_hal.h | 201 2 files changed, 1503

[PATCH v4 07/13] Async Event Handler

2006-12-14 Thread Steve Wise
Code to handle async events coming from the T3 RDMA Core. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_ev.c | 231 + 1 files changed, 231 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_ev.c b/d

[PATCH v4 05/13] Queue Pairs

2006-12-14 Thread Steve Wise
Code to manipulate the QP. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_qp.c | 1007 + 1 files changed, 1007 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_qp.c b/drivers/infiniband/hw/cxgb3/iwc

[PATCH v4 13/13] Kconfig/Makefile

2006-12-14 Thread Steve Wise
Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/Kconfig |1 + drivers/infiniband/Makefile |1 + drivers/infiniband/hw/cxgb3/Kconfig | 27 +++ drivers/infiniband/hw/cxgb3/Makefile | 12 4 files changed, 41 i

[PATCH v4 02/13] Device Discovery and ULLD Linkage

2006-12-14 Thread Steve Wise
Code to discover all the T3 devices and register them with the T3 RDMA Core and the Linux RDMA Core. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch.c | 189 drivers/infiniband/hw/cxgb3/iwch.h | 175 +

[PATCH v4 09/13] Core WQE/CQE Types

2006-12-14 Thread Steve Wise
T3 WQE and CQE structures, defines, etc... Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/core/cxio_wr.h | 685 1 files changed, 685 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/core/cxio_wr.h b/drivers/inf

[PATCH v4 03/13] Provider Methods and Data Structures

2006-12-14 Thread Steve Wise
Provider methods to support the Linux RDMA verbs. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_provider.c | 1171 +++ drivers/infiniband/hw/cxgb3/iwch_provider.h | 363 drivers/infiniband/hw/cxgb3/iwch_user.h | 68 ++

[PATCH v4 08/13] Memory Registration

2006-12-14 Thread Steve Wise
Functions to register memory regions. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_mem.c | 170 1 files changed, 170 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_mem.c b/drivers/infiniband/h

[PATCH v4 00/13] 2.6.20 Chelsio T3 RDMA Driver

2006-12-14 Thread Steve Wise
Roland, I think this is ready to go once the ethernet driver is pulled in. Version 4 changes: - Cleaned up spacing in the Kconfig file - Remove locking.txt file - its not needed - Remove -O1 from the debug config option - BugFix: support new LLD interface for dual-port adapters Version 3 chan

[PATCH v4 06/13] Completion Queues

2006-12-14 Thread Steve Wise
Functions to manipulate CQs. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_cq.c | 231 + 1 files changed, 231 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_cq.c b/drivers/infiniband/hw/cxgb3/iw

Re: [PATCH] drivers/net: spidernet driver on Celleb

2006-12-14 Thread Ishizaki Kou
Christoph-san, Thanks for your comments. >On Tue, Dec 12, 2006 at 02:25:50PM +0900, Ishizaki Kou wrote: >> >> Following are the changes. >> -This patch enables auto-negotiation. >> -Loading firmware is done when spidernet_open() is called. >> -And this patch adds other several small changes for

Re: [PATCH 1/14] Spidernet DMA coalescing

2006-12-14 Thread Christoph Hellwig
On Wed, Dec 13, 2006 at 03:06:59PM -0600, Linas Vepstas wrote: > > The current driver code performs 512 DMA mappings of a bunch of > 32-byte ring descriptor structures. This is silly, as they are > all in contiguous memory. This patch changes the code to > dma_map_coherent() each rx/tx ring as

Re: [PATCH 6/6] d80211: add sysfs interface for QoS functions

2006-12-14 Thread Jiri Benc
On Thu, 14 Dec 2006 12:03:02 +0800, Zhu Yi wrote: > The sysfs interface here is only a proof of concept. It provides a way for > the userspace applications to use the advanced QoS features supported by > d80211 stack. The finial solution should be switched to cfg80211. So... what about implementin

Re: [PATCH 3/6] d80211: fix classify_1d() priority selection

2006-12-14 Thread Jiri Benc
On Thu, 14 Dec 2006 12:02:27 +0800, Zhu Yi wrote: > I don't see any reason why packets with DSCP=0x40 should have lower IEEE > 802.1D priority than packets with DSCP=0x20. Spare > Background. No? Hm, seems so. Jouni, is there any reason for this? > > Signed-off-by: Zhu Yi <[EMAIL PROTECTED]> >

Re: [PATCH 2/6] d80211: create "wifi.h" to define WIFI OUIs

2006-12-14 Thread Jiri Benc
On Thu, 14 Dec 2006 12:02:16 +0800, Zhu Yi wrote: > --- /dev/null > +++ b/net/d80211/wifi.h > @@ -0,0 +1,28 @@ > +/* > + * This file defines Wi-Fi(r) OUIs for 80211.o > + * Copyright 2006, Zhu Yi <[EMAIL PROTECTED]> Intel Corp. > + * > + * This program is free software; you can redistribute it and

Re: [PATCH 1/6] d80211: add IEEE802.11e/WMM MLMEs, Status Code and Reason Code

2006-12-14 Thread Jiri Benc
On Thu, 14 Dec 2006 12:02:04 +0800, Zhu Yi wrote: > Signed-off-by: Zhu Yi <[EMAIL PROTECTED]> Please Cc: me and John Linville on d80211 patches otherwise your chances of review (and inclusion) are much lower. In addition to comments from Michael (which are all perfectly valid and you need to addr

[take28 3/8] kevent: poll/select() notifications.

2006-12-14 Thread Evgeniy Polyakov
poll/select() notifications. This patch includes generic poll/select notifications. kevent_poll works simialr to epoll and has the same issues (callback is invoked not from internal state machine of the caller, but through process awake, a lot of allocations and so on). Signed-off-by: Evgeniy Po

[take28 8/8] kevent: Kevent posix timer notifications.

2006-12-14 Thread Evgeniy Polyakov
Kevent posix timer notifications. Simple extensions to POSIX timers which allows to deliver notification of the timer expiration through kevent queue. Example application posix_timer.c can be found in archive on project homepage. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git

[take28 5/8] kevent: Timer notifications.

2006-12-14 Thread Evgeniy Polyakov
Timer notifications. Timer notifications can be used for fine grained per-process time management, since interval timers are very inconvenient to use, and they are limited. This subsystem uses high-resolution timers. id.raw[0] is used as number of seconds id.raw[1] is used as number of nanosec

[take28 1/8] kevent: Description.

2006-12-14 Thread Evgeniy Polyakov
Description. diff --git a/Documentation/kevent.txt b/Documentation/kevent.txt new file mode 100644 index 000..2e03a3f --- /dev/null +++ b/Documentation/kevent.txt @@ -0,0 +1,240 @@ +Description. + +int kevent_init(struct kevent_ring *ring, unsigned int ring_size, + unsigned int flags)

[take28 4/8] kevent: Socket notifications.

2006-12-14 Thread Evgeniy Polyakov
Socket notifications. This patch includes socket send/recv/accept notifications. Using trivial web server based on kevent and this features instead of epoll it's performance increased more than noticebly. More details about various benchmarks and server itself (evserver_kevent.c) can be found on

[take28 0/8] kevent: Generic event handling mechanism.

2006-12-14 Thread Evgeniy Polyakov
Generic event handling mechanism. Kevent is a generic subsytem which allows to handle event notifications. It supports both level and edge triggered events. It is similar to poll/epoll in some cases, but it is more scalable, it is faster and allows to work with essentially eny kind of events. Ev