[RTNETLINK]: Fix use of wrong skb in do_getlink()

2006-10-11 Thread Patrick McHardy
[RTNETLINK]: Fix use of wrong skb in do_getlink() skb is the netlink query, nskb is the reply message. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 7d6fc0796ea33cd86cf20ccd51c351538903dcd9 tree 15bd1793a030f471f4a70762b079cf187bca8207 parent 587b522ced8a8ca3bddc99b05ec5118f11cfe

Re: [RFC] Question about potential problem in net/ipv4/route.c

2006-10-11 Thread Eric Dumazet
David Miller a écrit : From: Eric Dumazet <[EMAIL PROTECTED]> Date: Thu, 12 Oct 2006 07:48:20 +0200 Not on my gcc here (gcc version 3.4.4) : It wont zeros out the padding bytes Patrick just proved this too :) Well, on this machine I have these oprofile numbers : : /* rt_intern_hash total:

Re: [RFC] Question about potential problem in net/ipv4/route.c

2006-10-11 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 12 Oct 2006 08:10:43 +0200 > David Miller wrote: > > Indeed, numbers talk bullshit walks :) > > :) > > > How about something like this as a start? > > > > diff --git a/net/ipv4/route.c b/net/ipv4/route.c > > The same problem is also present

Re: [RFC] Question about potential problem in net/ipv4/route.c

2006-10-11 Thread Patrick McHardy
David Miller wrote: > Indeed, numbers talk bullshit walks :) :) > How about something like this as a start? > > diff --git a/net/ipv4/route.c b/net/ipv4/route.c The same problem is also present in dn_route.c (3 uninitialized bytes in dn_u). - To unsubscribe from this list: send the line "unsub

Re: [RFC] Question about potential problem in net/ipv4/route.c

2006-10-11 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Thu, 12 Oct 2006 07:48:20 +0200 > Not on my gcc here (gcc version 3.4.4) : It wont zeros out the padding bytes Patrick just proved this too :) > Well, on this machine I have these oprofile numbers : > > : /* rt_intern_hash total: 993464 0.3619 */ >

Re: [RFC] Question about potential problem in net/ipv4/route.c

2006-10-11 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 12 Oct 2006 07:31:12 +0200 > This program demonstrates the effect, it doesn't output the expected > "1 2" but "1 4294967042" on my x86_64 (gcc-Version 4.1.2 20060901 > (prerelease) (Debian 4.1.1-13)). The initialization doesn't touch > the paddi

Re: [RFC] Question about potential problem in net/ipv4/route.c

2006-10-11 Thread Eric Dumazet
David Miller a écrit : From: Eric Dumazet <[EMAIL PROTECTED]> Date: Wed, 11 Oct 2006 15:11:18 +0200 Using memcmp(ptr1, ptr2, sizeof(SOMEFIELD)) is dangerous because sizeof(SOMEFIELD) can be larger than the underlying object, because of alignment constraints. In this case, sizeof(fl1->nl_u.ip

Re: [RFC] Question about potential problem in net/ipv4/route.c

2006-10-11 Thread Patrick McHardy
David Miller wrote: > We always explicitly initialize the flows, and even for local stack > assignment based initialization, gcc zeros out the padding bytes > always. I thought so too until I added the iptables compat functions recently and noticed uninitialized padding of on-stack structures, whi

Re: [RFC] Question about potential problem in net/ipv4/route.c

2006-10-11 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Wed, 11 Oct 2006 15:11:18 +0200 > Using memcmp(ptr1, ptr2, sizeof(SOMEFIELD)) is dangerous because > sizeof(SOMEFIELD) can be larger than the underlying object, because of > alignment constraints. > > In this case, sizeof(fl1->nl_u.ip4_u) is 16, whil

Re: What is current sundance.c status

2006-10-11 Thread Andrew Morton
On Thu, 12 Oct 2006 10:29:37 +0800 "Jesse Huang" <[EMAIL PROTECTED]> wrote: > Would you tell me what is the current IP100A status? Should I re-generate > patches again. Would it put into kernel or not? I'm sitting on a copy of them. I didn't send them to Jeff last time because: sundance-re

[PATCH] NET/atm: handle sysfs errors

2006-10-11 Thread Jeff Garzik
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- net/atm/atm_sysfs.c | 15 --- diff --git a/net/atm/atm_sysfs.c b/net/atm/atm_sysfs.c index c0a4ae2..62f6ed1 100644 --- a/net/atm/atm_sysfs.c +++ b/net/atm/atm_sysfs.c @@ -141,7 +141,7 @@ static struct class atm_class = {

[PATCH] NET/bluetooth: handle sysfs errors

2006-10-11 Thread Jeff Garzik
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- net/bluetooth/l2cap.c | 19 ++- net/bluetooth/rfcomm/core.c | 21 ++--- net/bluetooth/rfcomm/sock.c |7 ++- net/bluetooth/sco.c | 17 - 4 files changed, 50 insertions(

Re: [PATCH] Customizable TCP backoff patch

2006-10-11 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 11 Oct 2006 17:51:24 -0700), Ben Woodard <[EMAIL PROTECTED]> says: > diff -ru linux-2.6.18/net/ipv4/sysctl_net_ipv4.c > linux-2.6.18.new/net/ipv4/sysctl_net_ipv4.c > --- linux-2.6.18/net/ipv4/sysctl_net_ipv4.c 2006-09-19 20:42:06.0 > -0700 > +++

Re: [PATCH] Customizable TCP backoff patch

2006-10-11 Thread Ben Woodard
Here we go again. The changes are as follows: 1) the spaces are gone and now it is tabs. 2) used msecs_to_jiffies() and jiffies_to_msecs(). I'm much happier with that. I didn't know those functions existed. 3) changed over to proc_doulongvec_ms_jiffies_minmax(). Last night's test compile failed

Re: [PATCH] sotftmac: fix a slab corruption in WEP restricted key association

2006-10-11 Thread Daniel Drake
Laurent Riffard wrote: Fix a slab corruption in ieee80211softmac_auth(). The size of a buffer was miscomputed. see http://bugzilla.kernel.org/show_bug.cgi?id=7245 Acked-by: Daniel Drake <[EMAIL PROTECTED]>" Signed-off-by: Laurent Riffard <[EMAIL PROTECTED]> Apparently the CC list didn't work

[PATCH 1/3] NetLabel: only deref the CIPSOv4 standard map fields when using standard mapping

2006-10-11 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> Fix several places in the CIPSO code where it was dereferencing fields which did not have valid pointers by moving those pointer dereferences into code blocks where the pointers are valid. Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- net/ipv4/cipso_ipv4.

[PATCH 2/3] NetLabel: better error handling involving mls_export_cat()

2006-10-11 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> Upon inspection it looked like the error handling for mls_export_cat() was rather poor. This patch addresses this by NULL'ing out kfree()'d pointers before returning and checking the return value of the function everywhere it is called. Signed-off-by: Paul Mo

[PATCH 3/3] NetLabel: the CIPSOv4 passthrough mapping does not pass categories correctly

2006-10-11 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> The CIPSO passthrough mapping had a problem when sending categories which would cause no or incorrect categories to be sent on the wire with a packet. This patch fixes the problem which was a simple off-by-one bug. Signed-off-by: Paul Moore <[EMAIL PROTECTED]>

[PATCH 0/3] Collection of small NetLabel bugfixes

2006-10-11 Thread paul . moore
When doing some more testing today I ran into a few bugs, this patchset addresses those bugs. This patchset is backed against today's net-2.6 git tree. Please apply these patches for 2.6.19, thanks. -- paul moore linux security @ hp - To unsubscribe from this list: send the line "unsubscribe net

[PATCH 01/10] sky2: MSI test is only a warning

2006-10-11 Thread Stephen Hemminger
Some motherboards don't implement MSI correctly. The driver handles this but the warning is too verbose and overly cautious. Signed-off-by: Stephe Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-10-11 11:43:08.0 -0700 +++ sky2/drivers/net/sky2.c 2006-10-11

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-11 Thread Stephen Hemminger
O > > > > You might want to try ignoring the check in dev.c and testing > > to see if there is a performance gain. It wouldn't be hard to test > > a modified version and validate the performance change. > > Yes. With my patch, there is a huge performance gain by increasing MTU to 64K. > And it s

[PATCH 09/10] sky2: no message on rx fifo overflow

2006-10-11 Thread Stephen Hemminger
Under high load it is possible to make the receiver FIFO get overloaded. The driver/hardware recover properly, so there is no reason to fill the log with lots of extra messages, just update counter. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/sky2.c |6 -- 1 file

[PATCH 06/10] sky2: use duplex result bits

2006-10-11 Thread Stephen Hemminger
The result of duplex negotiation is avaliable in the phy status register, so use that to simplify code and avoid rereading the PHY. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/sky2.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) --- sky2.

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-11 Thread Michael S. Tsirkin
Quoting r. Stephen Hemminger <[EMAIL PROTECTED]>: > Subject: Re: Dropping NETIF_F_SG since no checksum feature. > > On Wed, 11 Oct 2006 21:11:38 +0100 > Steven Whitehouse <[EMAIL PROTECTED]> wrote: > > > Hi, > > > > On Wed, Oct 11, 2006 at 05:01:03PM +0200, Michael S. Tsirkin wrote: > > > Quotin

[PATCH 03/10] sky2: phy irq on shutdown

2006-10-11 Thread Stephen Hemminger
When PHY is turned off on shutdown, it causes the IRQ to get stuck on. Make sure and disable the IRQ first, and if IRQ occurs when device is not running, don't access PHY because that will hang. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-10-

[PATCH 08/10] sky2: flow control setting fixes

2006-10-11 Thread Stephen Hemminger
The result of flow control negotiation should not limit the next negotiatition. If board is plugged into an old half duplex 10Mbit port, without pause, then replugged into a gigabit port, it should negotiate what is desired, not inherit that last negotiation. P.s: many other drivers have this bug.

Re: [Bug 7296] New: Connected networks persist in routing table despite no IF_RUNNING

2006-10-11 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 11 Oct 2006 14:12:13 -0700 > I rejected this because I don't consider "sticky routes" when link is down > a bug. This definitely sounds like it is in the realm of userspace policy. The routing daemon should adjust the routes, as appropriate,

[PATCH 05/10] sky2: advertising register 16 bits

2006-10-11 Thread Stephen Hemminger
The advertising bits (from ethtool.h) fit in 16 bits. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.h2006-10-11 11:56:25.0 -0700 +++ sky2/drivers/net/sky2.h 2006-10-11 11:56:42.0 -0700 @@ -1860,7 +1860,7 @@ dma_addr_t

[PATCH 00/10] sky2: version 1.9 patches

2006-10-11 Thread Stephen Hemminger
Several little patches to sky2 driver. Mostly having to do with PHY handling and flow control. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 04/10] sky2: fiber pause bits

2006-10-11 Thread Stephen Hemminger
The advertisement bits for flow control are located in different location on fiber (1000baseX) Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-10-11 11:43:43.0 -0700 +++ sky2/drivers/net/sky2.c 2006-10-11 11:43:47.0 -0700 @@ -

[PATCH 10/10] sky2: version 1.9

2006-10-11 Thread Stephen Hemminger
Mark version, this has been a lot of patches. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-10-11 14:19:14.0 -0700 +++ sky2/drivers/net/sky2.c 2006-10-11 14:19:23.0 -0700 @@ -50,7 +50,7 @@ #include "sky2.h" #define DRV_NA

Fw: [Bug 7296] New: Connected networks persist in routing table despite no IF_RUNNING

2006-10-11 Thread Stephen Hemminger
I rejected this because I don't consider "sticky routes" when link is down a bug. Date: Tue, 10 Oct 2006 02:17:26 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bug 7296] New: Connected networks persist in routing table despite no IF_RUNNING http://bugzilla.kernel.org/show_bug.cg

[PATCH 07/10] sky2: dont reset PHY twice

2006-10-11 Thread Stephen Hemminger
Don't need to reset PHY twice on startup. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-10-11 11:59:45.0 -0700 +++ sky2/drivers/net/sky2.c 2006-10-11 14:21:36.0 -0700 @@ -356,16 +356,7 @@ gm_phy_write(hw, por

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-11 Thread Michael S. Tsirkin
Quoting r. David Miller <[EMAIL PROTECTED]>: > Subject: Re: Dropping NETIF_F_SG since no checksum feature. > > From: "Michael S. Tsirkin" <[EMAIL PROTECTED]> > Date: Wed, 11 Oct 2006 17:01:03 +0200 > > > Quoting Steven Whitehouse <[EMAIL PROTECTED]>: > > > > ssize_t tcp_sendpage(struct socket *so

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-11 Thread Michael S. Tsirkin
Quoting r. Stephen Hemminger <[EMAIL PROTECTED]>: > Subject: Re: Dropping NETIF_F_SG since no checksum feature. > > O > > > > > > You might want to try ignoring the check in dev.c and testing > > > to see if there is a performance gain. It wouldn't be hard to test > > > a modified version and va

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-11 Thread David Miller
From: "Michael S. Tsirkin" <[EMAIL PROTECTED]> Date: Wed, 11 Oct 2006 23:23:39 +0200 > With my patch, there is a huge performance gain by increasing MTU to 64K. > And it seems the only way to do this is by S/G. Numbers? - To unsubscribe from this list: send the line "unsubscribe netdev" in the bo

[PATCH 02/10] sky2: turn of workaround timer

2006-10-11 Thread Stephen Hemminger
The workaround timer is not needed in most systems with proper IRQ routing and by perodically waking up it adds to laptop power consumption. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/sky2.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- sky2.orig/dri

Re: [PATCH 21/21]: powerpc/cell spidernet DMA coalescing

2006-10-11 Thread Benjamin Herrenschmidt
> I started writingthe patch thinking it will have some huge effect on > performance, based on a false assumption on how i/o was done on this > machine > > *If* this were another pSeries system, then each call to > pci_map_single() chews up an actual hardware "translation > control entry" (TCE)

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-11 Thread Stephen Hemminger
On Wed, 11 Oct 2006 21:11:38 +0100 Steven Whitehouse <[EMAIL PROTECTED]> wrote: > Hi, > > On Wed, Oct 11, 2006 at 05:01:03PM +0200, Michael S. Tsirkin wrote: > > Quoting Steven Whitehouse <[EMAIL PROTECTED]>: > > > > ssize_t tcp_sendpage(struct socket *sock, struct page *page, int offset, > > > >

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-11 Thread Michael S. Tsirkin
Quoting r. Steven Whitehouse <[EMAIL PROTECTED]>: > Subject: Re: Dropping NETIF_F_SG since no checksum feature. > > Hi, > > On Wed, Oct 11, 2006 at 05:01:03PM +0200, Michael S. Tsirkin wrote: > > Quoting Steven Whitehouse <[EMAIL PROTECTED]>: > > > > ssize_t tcp_sendpage(struct socket *sock, stru

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-11 Thread David Miller
From: "Michael S. Tsirkin" <[EMAIL PROTECTED]> Date: Wed, 11 Oct 2006 17:01:03 +0200 > Quoting Steven Whitehouse <[EMAIL PROTECTED]>: > > > ssize_t tcp_sendpage(struct socket *sock, struct page *page, int offset, > > > size_t size, int flags) > > > { > > > ssize_t res;

Re: [PATCH] d80211: extend extra_hdr_room to be a bytecount

2006-10-11 Thread Michael Buesch
On Wednesday 11 October 2006 16:59, David Kimdon wrote: > Perhaps rename it to extra_tx_headroom? > - existing users would then need to take notice of the change > - the name 'extra_tx_headroom' is more descriptive of what it actually is Oh, yeah. This was lazyman's solution ;) I will send an up

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-11 Thread Steven Whitehouse
Hi, On Wed, Oct 11, 2006 at 05:01:03PM +0200, Michael S. Tsirkin wrote: > Quoting Steven Whitehouse <[EMAIL PROTECTED]>: > > > ssize_t tcp_sendpage(struct socket *sock, struct page *page, int offset, > > > size_t size, int flags) > > > { > > > ssize_t res; > > >

RE: [PATCH 00/11] The _entire_ secid reconciliation patchset (tada!)

2006-10-11 Thread Venkat Yekkirala
> From an initial review of this patchset, it doesn't look > quite ready to > queue for 2.6.20 (which I plan to to via git once it is). > > Outstanding items include resolving the igmp skb hook issue > generally, > testing to verify both the design and implementation, and > ensuring that > a

Re: [openib-general] Dropping NETIF_F_SG since no checksum feature.

2006-10-11 Thread Michael Krause
At 02:46 AM 10/11/2006, Michael S. Tsirkin wrote: Quoting r. David Miller <[EMAIL PROTECTED]>: > Subject: Re: Dropping NETIF_F_SG since no checksum feature. > > From: "Michael S. Tsirkin" <[EMAIL PROTECTED]> > Date: Wed, 11 Oct 2006 11:05:04 +0200 > > > So, it seems that if I set NETIF_F_SG but c

Re: [PATCH] e1000: Real time packets and bytes statistics

2006-10-11 Thread Jesse Brandeburg
On 10/11/06, Jean Delvare <[EMAIL PROTECTED]> wrote: Hi all, This patch is posted for review and comments. Let the e1000 driver report the most important statistics (rx/tx_bytes and rx/tx_packets) in real time, rather than every other second. This is similar to what the e100 driver is doing. T

Re: [PATCH 0/21]: powerpc/cell spidernet bugfixes, etc.

2006-10-11 Thread Arnd Bergmann
On Tuesday 10 October 2006 22:49, Linas Vepstas wrote: > Andrew, please apply/forward upstream. > > The following set of 21 patches (!) are all aimed at the the > spidernet ethernet device driver. The spidernet is an etherenet > controller built into the Toshiba southbridge for the PowerPC Cell >

Re: [PATCH 21/21]: powerpc/cell spidernet DMA coalescing

2006-10-11 Thread Geoff Levand
Linas Vepstas wrote: > On Tue, Oct 10, 2006 at 06:46:08PM -0700, Geoff Levand wrote: >> > Linas Vepstas wrote: >> >> The current driver code performs 512 DMA mappns of a bunch of >> >> 32-byte structures. This is silly, as they are all in contiguous >> >> memory. Ths patch changes the code to DMA

Re: [PATCH 21/21]: powerpc/cell spidernet DMA coalescing

2006-10-11 Thread Linas Vepstas
On Tue, Oct 10, 2006 at 06:46:08PM -0700, Geoff Levand wrote: > > Linas Vepstas wrote: > >> The current driver code performs 512 DMA mappns of a bunch of > >> 32-byte structures. This is silly, as they are all in contiguous > >> memory. Ths patch changes the code to DMA map the entie area > >> wi

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-11 Thread Michael S. Tsirkin
Quoting Steven Whitehouse <[EMAIL PROTECTED]>: > > ssize_t tcp_sendpage(struct socket *sock, struct page *page, int offset, > > size_t size, int flags) > > { > > ssize_t res; > > struct sock *sk = sock->sk; > > > > if (!(sk->sk_route_caps & NETIF_F_SG)

Re: [PATCH] d80211: extend extra_hdr_room to be a bytecount

2006-10-11 Thread David Kimdon
Perhaps rename it to extra_tx_headroom? - existing users would then need to take notice of the change - the name 'extra_tx_headroom' is more descriptive of what it actually is -David On Wed, Oct 11, 2006 at 11:58:28AM +0200, Michael Buesch wrote: > Extend ieee80211_hw's extra_hdr_room to be a b

Re: [PATCH] Customizable TCP backoff patch

2006-10-11 Thread Vlad Yasevich
Ben Woodard wrote: > diff -ru linux-2.6.18/include/net/tcp.h linux-2.6.18.new/include/net/tcp.h > --- linux-2.6.18/include/net/tcp.h2006-09-19 20:42:06.0 -0700 > +++ linux-2.6.18.new/include/net/tcp.h2006-

[RFC] Question about potential problem in net/ipv4/route.c

2006-10-11 Thread Eric Dumazet
Hi David While browsing net/ipv4/route.c I discovered compare_keys() function, and a potential bug in it. static inline int compare_keys(struct flowi *fl1, struct flowi *fl2) { return memcmp(&fl1->nl_u.ip4_u, &fl2->nl_u.ip4_u, sizeof(fl1->nl_u.ip4_u)) == 0 && fl1->oif

[PATCH 4/4] drivers/net/sis900.c: Replacing yield() with a better alternative

2006-10-11 Thread Amol Lad
*Please check if timeout should be increased* Signed-off-by: Amol Lad <[EMAIL PROTECTED]> --- diff -uprN -X linux-2.6.19-rc1-orig/Documentation/dontdiff linux-2.6.19-rc1-orig/drivers/net/wireless/hostap/hostap_hw.c linux-2.6.19-rc1/drivers/net/wireless/hostap/hostap_hw.c --- linux-2.6.19-rc1-ori

[PATCH 1/4] drivers/net/depca.c: Replacing yield() with a better alternative

2006-10-11 Thread Amol Lad
In 2.6, the semantics of calling yield() changed from "sleep for a bit" to "I really don't want to run for a while". This matches POSIX better, but there's a lot of drivers still using yield() when they mean cond_resched(), schedule() or even schedule_timeout(). For this driver schedule_timeout_i

[PATCH 2/4] drivers/net/sb1000.c: Replacing yield() with a better alternative

2006-10-11 Thread Amol Lad
cond_resched() seems to be a better alternative Signed-off-by: Amol Lad <[EMAIL PROTECTED]> --- diff -uprN -X linux-2.6.19-rc1-orig/Documentation/dontdiff linux-2.6.19-rc1-orig/drivers/net/sb1000.c linux-2.6.19-rc1/drivers/net/sb1000.c --- linux-2.6.19-rc1-orig/drivers/net/sb1000.c 2006-10-05 14

[PATCH 3/4] drivers/net/sis900.c: Replacing yield() with a better alternative

2006-10-11 Thread Amol Lad
*Please check if the timout value is ok or it should be increased* Signed-off-by: Amol Lad <[EMAIL PROTECTED]> --- diff -uprN -X linux-2.6.19-rc1-orig/Documentation/dontdiff linux-2.6.19-rc1-orig/drivers/net/sis900.c linux-2.6.19-rc1/drivers/net/sis900.c --- linux-2.6.19-rc1-orig/drivers/net/sis9

Re: [Bugme-new] [Bug 7278] New: forcedeth slowed down by traffic shaping

2006-10-11 Thread Patrick McHardy
Jarek Poplawski wrote: > On 07-10-2006 02:22, Andrew Morton wrote: > >>On Fri, 6 Oct 2006 17:18:13 -0700 >>[EMAIL PROTECTED] wrote: >> >> >>>http://bugzilla.kernel.org/show_bug.cgi?id=7278 >>> >>> Summary: forcedeth slowed down by traffic shaping >>>Kernel Version: 2.6.16 >>>

Re: [Bugme-new] [Bug 7278] New: forcedeth slowed down by traffic shaping

2006-10-11 Thread Jarek Poplawski
On 07-10-2006 02:22, Andrew Morton wrote: > On Fri, 6 Oct 2006 17:18:13 -0700 > [EMAIL PROTECTED] wrote: > >> http://bugzilla.kernel.org/show_bug.cgi?id=7278 >> >>Summary: forcedeth slowed down by traffic shaping >> Kernel Version: 2.6.16 >> Status: NEW >> Sev

[PATCH] e1000: Real time packets and bytes statistics

2006-10-11 Thread Jean Delvare
Hi all, This patch is posted for review and comments. Let the e1000 driver report the most important statistics (rx/tx_bytes and rx/tx_packets) in real time, rather than every other second. This is similar to what the e100 driver is doing. The current asynchronous statistics refresh model makes

Re: Bug ? IF_RUNNING/routing table updates

2006-10-11 Thread Jarek Poplawski
On 09-10-2006 12:55, Shaun Kemp wrote: ... > An interface (+ connected IP network) which loses its IF_RUNNING flag (ie > unusable for routing) persists in the routing table as a kernel route. > Thus rather than responding to a dynamically announced route to this > connected network (the connected b

Re: Pull request for 'jg-20061009-00' tag

2006-10-11 Thread Francois Romieu
(removed the forcedeth people from the Cc:) Jeff Garzik <[EMAIL PROTECTED]> : [...] > I merged the forcedeth change via another source. Could I pull from a > tag with just the r8169 change? Yes, you can pull from: git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git jg

[PATCH] d80211: extend extra_hdr_room to be a bytecount

2006-10-11 Thread Michael Buesch
Extend ieee80211_hw's extra_hdr_room to be a bytecount for a device specific TX header instead of being a hardcoded 0/2 byte choice. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> diff --git a/include/net/d80211.h b/include/net/d80211.h index a80f48b..9e9709f 100644 --- a/include/net/d80211.h

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-11 Thread Michael S. Tsirkin
Quoting r. David Miller <[EMAIL PROTECTED]>: > Subject: Re: Dropping NETIF_F_SG since no checksum feature. > > From: "Michael S. Tsirkin" <[EMAIL PROTECTED]> > Date: Wed, 11 Oct 2006 11:05:04 +0200 > > > So, it seems that if I set NETIF_F_SG but clear NETIF_F_ALL_CSUM, > > data will be copied ove

Re: [PATCH 21/21]: powerpc/cell spidernet DMA coalescing

2006-10-11 Thread Arnd Bergmann
On Wednesday 11 October 2006 03:46, Geoff Levand wrote: > > > > The others look good, but this one complicates the code and doesn't have > > any benefit.  20 > > for 21 isn't bad. > > Is the motivation for this change to improve performance by reducing the > overhead > of the mapping calls?  I

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-11 Thread David Miller
From: "Michael S. Tsirkin" <[EMAIL PROTECTED]> Date: Wed, 11 Oct 2006 11:05:04 +0200 > So, it seems that if I set NETIF_F_SG but clear NETIF_F_ALL_CSUM, > data will be copied over rather than sent directly. > So why does dev.c have to force set NETIF_F_SG to off then? Because it's more efficient

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-11 Thread Steven Whitehouse
Hi, On Wed, Oct 11, 2006 at 11:05:04AM +0200, Michael S. Tsirkin wrote: > Quoting r. David Miller <[EMAIL PROTECTED]>: > > Subject: Re: Dropping NETIF_F_SG since no checksum feature. > > > > From: "Michael S. Tsirkin" <[EMAIL PROTECTED]> > > Date: Wed, 11 Oct 2006 02:13:38 +0200 > > > > > Maybe

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-11 Thread Michael S. Tsirkin
Quoting r. David Miller <[EMAIL PROTECTED]>: > Subject: Re: Dropping NETIF_F_SG since no checksum feature. > > From: "Michael S. Tsirkin" <[EMAIL PROTECTED]> > Date: Wed, 11 Oct 2006 02:13:38 +0200 > > > Maybe I can patch linux to allow SG without checksum? > > Dave, maybe you could drop a hint o

Re: [PATCH 1/4] beginning of 8390 fixes - generic and arm/etherh

2006-10-11 Thread Jeff Garzik
applied 1-4 to #upstream (queued for 2.6.20). will let it simmer in -mm for a cycle, to make sure it gets some wide testing. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kern

Re: Pull request for 'jg-20061009-00' tag

2006-10-11 Thread Jeff Garzik
Francois Romieu wrote: Please pull from tag 'jg-20061009-00' in repository git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git jg-20061009-00 to get the changes below. Distance from 'upstream-fixes' - $ git rev-list 2f614fe04f4463ff22234133319067d7361f54e5

Re: [PATCH-update][RFC] net: consolidated UDP / UDP-Lite code

2006-10-11 Thread Gerrit Renker
| > csum_copy_err: | > - UDP_INC_STATS_BH(UDP_MIB_INERRORS); | > + UDP_INC_STATS_BH(UDP_MIB_INERRORS, is_udplite); | > + UDP_DEC_STATS_BH(UDP_MIB_INDATAGRAMS, is_udplite); | | I'm not a big fan at all of these "statistic corrections" | we're starting to place in various spots. I am not

Re: is each frag of a skb always less than 1 page?

2006-10-11 Thread Jarek Poplawski
On 11-10-2006 01:26, Ronghua Zhang wrote: ... > The reason I asked this is that I saw the following code in forthdeth > drvier: > > #define NV_TX2_TSO_MAX_SHIFT) 14 > /* add fragments to entries count */ > for (i = 0; i < fragments; i++) { >entries += (skb_shinfo(skb)->frags[i].size >> NV_TX2

Re: [PATCH 21/21]: powerpc/cell spidernet DMA coalescing

2006-10-11 Thread Benjamin Herrenschmidt
On Tue, 2006-10-10 at 18:20 -0500, jschopp wrote: > Linas Vepstas wrote: > > The current driver code performs 512 DMA mappns of a bunch of > > 32-byte structures. This is silly, as they are all in contiguous > > memory. Ths patch changes the code to DMA map the entie area > > with just one call.