Re: PATCH: fix cut/paste error in TCPPROBE

2006-09-25 Thread David Miller
From: Grant Grundler <[EMAIL PROTECTED]> Date: Fri, 22 Sep 2006 08:47:10 -0600 > Fix cut/paste error in TCPPROBE help text. > > Signed-off-by: Grant Grundler <[EMAIL PROTECTED]> Applied, thanks Grant. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH] Advertise PPPoE MTU / avoid memory leak.

2006-09-25 Thread Pekka Savola
Speaking of PPPoE and MTU, does Linux support recently-published RFC 4638: Accommodating a Maximum Transit Unit/Maximum Receive Unit (MTU/MRU) Greater Than 1492 in the Point-to-Point Protocol over Ethernet (PPPoE) On Sat, 23 Sep 2006, [EMAIL PROTECTED] wrot

Re: [PATCH] netdev config: revert part of previous patch

2006-09-25 Thread David Miller
From: "Randy.Dunlap" <[EMAIL PROTECTED]> Date: Fri, 22 Sep 2006 12:56:25 -0700 > From: Randy Dunlap <[EMAIL PROTECTED]> > > Net devices should depend on NETDEVICES, so revert part of > Paolo's previous patch. > > See http://marc.theaimsgroup.com/?l=linux-kernel&m=115566326218740&w=2 > for histor

Re: [patch 04/11] drivers/net/acenic.c Removal of old code

2006-09-25 Thread Jes Sorensen
> "akpm" == akpm <[EMAIL PROTECTED]> writes: akpm> From: Michal Piotrowski <[EMAIL PROTECTED]> akpm> Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> akpm> Cc: Jeff Garzik <[EMAIL PROTECTED]> akpm> Cc: Jes Sorensen <[EMAIL PROTECTED]> akpm> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>

Re: [patch] neighbour.c, pneigh_get_next() skips published entry

2006-09-25 Thread Philip Craig
David Miller wrote: >> I've been sitting on this patch because afaik the problem which it purports >> to fix remains unfixed. >> >> Should I drop it?? >> >> Thanks. > > Please drop it, the patch submitted didn't give us the feedback > and test results we asked for which is necessary to pinpoint th

Re: [patch 3/3] Add netpoll/netconsole support to vlan devices

2006-09-25 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 25 Sep 2006 16:43:10 -0700 > +#ifdef CONFIG_NET_POLL_CONTROLLER > + new_dev->poll_controller = real_dev->poll_controller; > +#endif > + I don't see how this part can be correct. If netpoll actually calls new_dev->poll_controller it will pass new_dev in (ie.

Re: [patch 2/3] via-ircc: fix memory leak

2006-09-25 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 25 Sep 2006 16:43:08 -0700 > From: Chuck Short <[EMAIL PROTECTED]> > > Fix memory leak. > > Coverity id# 653 > > patch location: > http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=a1f34cb68b16807ed9d5ebb0f6a6ec5ff8a5fc78

Re: [patch 1/3] net/ipv6: bh_lock_sock_nested on tcp_v6_rcv

2006-09-25 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 25 Sep 2006 16:43:07 -0700 > From: Fabio Olive Leite <[EMAIL PROTECTED]> > > A while ago Ingo patched tcp_v4_rcv on net/ipv4/tcp_ipv4.c to use > bh_lock_sock_nested and silence a lock validator warning. This fixed > it for IPv4, but recently I saw a report of th

Re: [patch 01/11] e1000: memory leak in e1000_set_ringparam()

2006-09-25 Thread Auke Kok
Jeff Garzik wrote: [EMAIL PROTECTED] wrote: From: Vasily Averin <[EMAIL PROTECTED]> Memory leak was found in 2.6.18-rc4 and e1000 7.2.7 from sourceforge: Memory allocated for new tx_ring and rx_ring leaks if e1000_setup_XX_resources() fails.c Also this patch reduces stack usage (removed tx_new

Re: [patch 07/11] drivers/net/typhoon.c Removal of old code

2006-09-25 Thread Dave Dillow
On Mon, 2006-09-25 at 16:39 -0700, [EMAIL PROTECTED] wrote: > From: Michal Piotrowski <[EMAIL PROTECTED]> > > Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> > Cc: Jeff Garzik <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Signed-off-by: Dave Dillow <[EMAIL PROTECTED]

[PATCH] zd1211rw: Add 3 more device IDs

2006-09-25 Thread Daniel Drake
iNexQ UR055g: Tested by Todor T Zviskov zd1211 chip 1435:0711 v4330 high 00-10-a7 AL2230_RF pa0 g-- ZyXEL AG-225, FCC ID SI5WUB410: Tested by Nathan zd1211 chip 0586:3409 v4810 full 00-13-49 AL7230B_RF pa0 g--- Yakumo QuickWLAN USB: Tested by EdB zd1211 chip 0b3b:1630 v4330 high 00-01-36 RF2959_R

Re: [PATCH 2.6.19-rc1] ehea firmware interface based on Anton Blanchard's new hvcall interface

2006-09-25 Thread Benjamin Herrenschmidt
On Mon, 2006-09-25 at 20:07 -0400, Jeff Garzik wrote: > patch does not apply. > > also, it would seem like varargs would be appropriate here. Not really... these are hypervisor calls, their calling convention is not varargs, thus we would need some conversion layer if using them, with possible pe

Re: [patch] neighbour.c, pneigh_get_next() skips published entry

2006-09-25 Thread Andrew Morton
On Mon, 25 Sep 2006 16:47:31 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Mon, 25 Sep 2006 16:45:35 -0700 > > > I've been sitting on this patch because afaik the problem which it purports > > to fix remains unfixed. > > > > Should I drop i

Re: Please pull 'upstream' branch of wireless-2.6.git

2006-09-25 Thread Jeff Garzik
pulled - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH REPOST 1/10] bonding: Allow bonding to enslave a 10 Gig adapter

2006-09-25 Thread Jeff Garzik
applied 1-10 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2.6.19-rc1] ehea firmware interface based on Anton Blanchard's new hvcall interface

2006-09-25 Thread Jeff Garzik
patch does not apply. also, it would seem like varargs would be appropriate here. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] skge: fiber support (rebased)

2006-09-25 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 11/11] forcedeth: hardirq lockdep warning

2006-09-25 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Peter Zijlstra <[EMAIL PROTECTED]> BUG: warning at kernel/lockdep.c:1816/trace_hardirqs_on() (Not tainted) Call Trace: show_trace dump_stack trace_hardirqs_on :forcedeth:nv_nic_irq_other handle_IRQ_event __do_IRQ do_IRQ ret_from_intr DWARF2 barf default_i

Re: [patch 02/11] 3x59x: fix PCI resource management

2006-09-25 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Jeff Garzik <[EMAIL PROTECTED]> The driver wrongly claimed I/O ports at an address returned by pci_iomap() -- even if it was passed an MMIO address. Fix this by claiming/releasing all PCI resources in the PCI driver probe/remove handlers instead and get rid of the

Re: [patch 01/11] e1000: memory leak in e1000_set_ringparam()

2006-09-25 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Vasily Averin <[EMAIL PROTECTED]> Memory leak was found in 2.6.18-rc4 and e1000 7.2.7 from sourceforge: Memory allocated for new tx_ring and rx_ring leaks if e1000_setup_XX_resources() fails.c Also this patch reduces stack usage (removed tx_new and rx_new) and uses

Re: [patch 03/11] Update smc91x driver with ARM Versatile board info

2006-09-25 Thread Jeff Garzik
applied patches 3-8, and patch 10 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 09/11] b44: fix eeprom endianess issue

2006-09-25 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Michael Buesch <[EMAIL PROTECTED]> This fixes eeprom read on big-endian architectures. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/b44.c |2 +- 1 file

Re: [RFC] genetlink custom attribute type

2006-09-25 Thread David Miller
From: Johannes Berg <[EMAIL PROTECTED]> Date: Mon, 25 Sep 2006 16:58:28 +0200 > On Wed, 2006-09-20 at 08:24 +0200, Thomas Graf wrote: > > > I think its best to use your patch for now and see where this leads to. > > Alright, should I repost with a proper [PATCH] subject or is it good to > take a

Re: [patch] neighbour.c, pneigh_get_next() skips published entry

2006-09-25 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Mon, 25 Sep 2006 16:45:35 -0700 > I've been sitting on this patch because afaik the problem which it purports > to fix remains unfixed. > > Should I drop it?? > > Thanks. Please drop it, the patch submitted didn't give us the feedback and test resul

[patch 1/3] tulip: fix shutdown DMA/irq race

2006-09-25 Thread akpm
From: Grant Grundler <[EMAIL PROTECTED]> IRQs are racing with tulip_down(). DMA can be restarted by the interrupt handler _after_ we call tulip_stop_rxtx() and the DMA buffers are unmapped. The result is an MCA (hard crash on ia64) because of an IO TLB miss. The long-term fix is to make the int

[patch] neighbour.c, pneigh_get_next() skips published entry

2006-09-25 Thread Andrew Morton
I've been sitting on this patch because afaik the problem which it purports to fix remains unfixed. Should I drop it?? Thanks. From: "Jari Takkala" <[EMAIL PROTECTED]> Fix a problem where output from /proc/net/arp skips a record when the full output does not fit into the users read() buffer.

[patch 3/3] tulip: NatSemi DP83840A PHY fix

2006-09-25 Thread akpm
From: Thibaut VARENE <[EMAIL PROTECTED]> Fix a problem with Tulip 21142 HP branded PCI cards (PN#: B5509-66001), which feature a NatSemi DP83840A PHY. Without that patch, it is impossible to properly initialize the card's PHY, and it's thus impossible to monitor/configure it. It's a timing/posti

[patch 3/3] Add netpoll/netconsole support to vlan devices

2006-09-25 Thread akpm
From: Jesper Juhl <[EMAIL PROTECTED]> I recently tried running netconsole via a vlan interface without luck, and decided to do something about it (see patch below). My interfaces look like this: eth0 Link encap:Ethernet HWaddr 00:14:5E:28:3C:2E UP BROADCAST RUNNING MULTICAST MTU

[patch 1/3] net/ipv6: bh_lock_sock_nested on tcp_v6_rcv

2006-09-25 Thread akpm
From: Fabio Olive Leite <[EMAIL PROTECTED]> A while ago Ingo patched tcp_v4_rcv on net/ipv4/tcp_ipv4.c to use bh_lock_sock_nested and silence a lock validator warning. This fixed it for IPv4, but recently I saw a report of the same warning on IPv6. Cc: Herbert Xu <[EMAIL PROTECTED]> Cc: "David S.

[patch 2/3] via-ircc: fix memory leak

2006-09-25 Thread akpm
From: Chuck Short <[EMAIL PROTECTED]> Fix memory leak. Coverity id# 653 patch location: http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=a1f34cb68b16807ed9d5ebb0f6a6ec5ff8a5fc78 Signed-off-by: Chuck Short <[EMAIL PROTECTED]> Signed-off-by: Ben Collins <[EM

[patch 2/3] tulip: fix for 64-bit mips

2006-09-25 Thread akpm
From: Jim Gifford <[EMAIL PROTECTED]>, Grant Grundler <[EMAIL PROTECTED]>, Peter Horton <[EMAIL PROTECTED]> With Grant's help I was able to get the tulip driver to work with 64 bit MIPS. Cc: Valerie Henson <[EMAIL PROTECTED]> [akpm: this is a previously-nacked patch, but the problem

[patch 01/11] e1000: memory leak in e1000_set_ringparam()

2006-09-25 Thread akpm
From: Vasily Averin <[EMAIL PROTECTED]> Memory leak was found in 2.6.18-rc4 and e1000 7.2.7 from sourceforge: Memory allocated for new tx_ring and rx_ring leaks if e1000_setup_XX_resources() fails.c Also this patch reduces stack usage (removed tx_new and rx_new) and uses kzalloc instead kmalloc+me

[patch 08/11] Signedness issue in drivers/net/phy/phy_device.c

2006-09-25 Thread akpm
From: Eric Sesterhenn <[EMAIL PROTECTED]> While checking gcc 4.1 -Wextra warnings, I stumbled across the following two warnings: drivers/net/phy/phy_device.c:528: warning: comparison of unsigned expression < 0 is always false drivers/net/phy/phy_device.c:546: warning: comparison of unsigned expr

[patch 04/11] drivers/net/acenic.c Removal of old code

2006-09-25 Thread akpm
From: Michal Piotrowski <[EMAIL PROTECTED]> Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Jes Sorensen <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/acenic.c |4 1 file changed, 4 deletions(-) diff -p

[patch 03/11] Update smc91x driver with ARM Versatile board info

2006-09-25 Thread akpm
From: Deepak Saxena <[EMAIL PROTECTED]> We need to specify a Versatile-specific SMC_IRQ_FLAGS value or the new generic IRQ layer will complain thusly: No IRQF_TRIGGER set_type function for IRQ 25 () Signed-off-by: Deepak Saxena <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Russell

[patch 09/11] b44: fix eeprom endianess issue

2006-09-25 Thread akpm
From: Michael Buesch <[EMAIL PROTECTED]> This fixes eeprom read on big-endian architectures. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/b44.c |2 +- 1 file changed, 1 insertion(+), 1

[patch 07/11] drivers/net/typhoon.c Removal of old code

2006-09-25 Thread akpm
From: Michal Piotrowski <[EMAIL PROTECTED]> Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/typhoon.c |4 1 file changed, 4 deletions(-) diff -puN drivers/net/typhoon.c~drivers-net

[patch 10/11] fix possible NULL ptr deref in forcedeth

2006-09-25 Thread akpm
From: Jesper Juhl <[EMAIL PROTECTED]> There seems to be a possible NULL pointer deref bug in drivers/net/forcedeth.c::nv_loopback_test(). If dev_alloc_skb() fails, the next line will call skb_put() with a NULL first argument which it'll then try to deref - kaboom: a NULL pointer deref. Found by

[patch 02/11] 3x59x: fix PCI resource management

2006-09-25 Thread akpm
From: Jeff Garzik <[EMAIL PROTECTED]> The driver wrongly claimed I/O ports at an address returned by pci_iomap() -- even if it was passed an MMIO address. Fix this by claiming/releasing all PCI resources in the PCI driver probe/remove handlers instead and get rid of the must_free_region flag weir

[patch 06/11] drivers/net/tokenring/lanstreamer.h Removal of old code

2006-09-25 Thread akpm
From: Michal Piotrowski <[EMAIL PROTECTED]> Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/tokenring/lanstreamer.h | 12 1 file changed, 12 deletions(-) diff -puN drivers/n

[patch 11/11] forcedeth: hardirq lockdep warning

2006-09-25 Thread akpm
From: Peter Zijlstra <[EMAIL PROTECTED]> BUG: warning at kernel/lockdep.c:1816/trace_hardirqs_on() (Not tainted) Call Trace: show_trace dump_stack trace_hardirqs_on :forcedeth:nv_nic_irq_other handle_IRQ_event __do_IRQ do_IRQ ret_from_intr DWARF2 barf default_idle cpu_idle rest_init s

[patch 05/11] drivers/net/tokenring/lanstreamer.c Removal of old code

2006-09-25 Thread akpm
From: Michal Piotrowski <[EMAIL PROTECTED]> Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/tokenring/lanstreamer.c | 59 -- 1 file changed, 59 deletions(-) diff -

Re: [PATCH]: e1000: Janitor: Use #defined values for literals

2006-09-25 Thread Auke Kok
Linas Vepstas wrote: Resending a minor janitorial patch from long ago that seems to have fallen through the cracks. Its not in 2.6.18-git4 nor in 2.6.18-mm1. Please apply and forward upstream. --linas [PATCH]: e1000: Janitor: Use #defined values for literals Minor janitorial patch: use #defi

Re: [PATCH v2 0/8] Updated patchset with Thomas' comments

2006-09-25 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 25 Sep 2006 14:04:12 -0400 > This is an updated patchset which takes into account Thomas' comments. This > includes the addition of two new patches in the patchset which add a new > Netlink interface as well as correct the list of interfaces in the large > comme

[PATCH]: e1000: Janitor: Use #defined values for literals

2006-09-25 Thread Linas Vepstas
Resending a minor janitorial patch from long ago that seems to have fallen through the cracks. Its not in 2.6.18-git4 nor in 2.6.18-mm1. Please apply and forward upstream. --linas [PATCH]: e1000: Janitor: Use #defined values for literals Minor janitorial patch: use #defines for literal values

wireless-2.6 now has a 'pending' branch (was Re: Please pull 'upstream' branch of wireless-2.6.git)

2006-09-25 Thread John W. Linville
On Mon, Sep 25, 2006 at 05:50:43PM -0400, John W. Linville wrote: > The following changes since commit 7c250413e5b7c3dfae89354725b70c76d7621395: > Al Viro: > pata_pdc2027x iomem annotations > > are found in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/linvi

Please pull 'upstream' branch of wireless-2.6.git

2006-09-25 Thread John W. Linville
The following changes since commit 7c250413e5b7c3dfae89354725b70c76d7621395: Al Viro: pata_pdc2027x iomem annotations are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream Daniel Drake: WE-21 for zd1211rw sof

Wireless router with 2 MACs: okay with mswin, not with Linux ?

2006-09-25 Thread Mark Lord
Hi all, I'm posting this from a hotel which has a wireless AP (B+G) for guests. It took me several hours to figure out how to get the connection working with my 2.6.18 notebook -- works just fine with other guests' mswin machines. WEP is used, and is set up and working just fine: I can access t

Re: [PATCH v2 0/8] Updated patchset with Thomas' comments

2006-09-25 Thread Thomas Graf
* [EMAIL PROTECTED] <[EMAIL PROTECTED]> 2006-09-25 14:04 > This is an updated patchset which takes into account Thomas' comments. This > includes the addition of two new patches in the patchset which add a new > Netlink interface as well as correct the list of interfaces in the large > comment blo

Re: [PATCH 00/03][RESUBMIT] net: EtherIP tunnel driver

2006-09-25 Thread Brian Haley
Joerg Roedel wrote: Is there something in the RFC that suggests that a byte order other than 'network order' is possible/acceptable there? No. The RFC states nothing at all about byte- or bitorder. That is why the RFC is ambigious at this point. RFC 791 (IPv4) Appendix B does give instruction

[PATCH] bcm43xx: output proper link quality with scans

2006-09-25 Thread Larry Finger
The bcm43xx-softmac driver fails to set two quantities needed for iwlist to compute wireless quality when scanning. As a result, userland programs using the quality to determine the best connection fail. Signed-off-by: Larry Finger <[EMAIL PROTECTED]> --- This patch is intended for wireless-2.6.

Re: [PATCH 2.6.17.13 2/2] LARTC: trace control for netem: kernelspace

2006-09-25 Thread Stephen Hemminger
Some changes: 1. need to select CONFIGFS into configuration 2. don't add declarations after code. 3. use unsigned not int for counters and mask. 4. don't return a structure (ie pkt_delay) 5. use enum for magic values 6. don't use GFP_ATOMIC unless you have to 7. check error values on configfs_init

Re: kernel: TKIP: replay detected:

2006-09-25 Thread Larry Finger
Matthieu CASTET wrote: Hi, On Mon, 25 Sep 2006 10:50:00 -0400, John W. Linville wrote: On Sun, Sep 24, 2006 at 12:40:53PM +0200, Elimar Riesebieter wrote: My sylog is filled up with thousands of: Sep 21 18:18:00 aragorn kernel: TKIP: replay detected: \ STA=XX:XX:BB:LL:KK:00 previous TSC

Re: softmac mtu

2006-09-25 Thread John W. Linville
On Mon, Sep 25, 2006 at 07:17:31PM +, Matthieu CASTET wrote: > So why a special mtu handler is not implemented in 802.11 stack : > - 802.11 stack doesn't support bigger packet > - 802.11 stack doesn't support very bigger packet (with > 802.11 fragmentation) > - 802.11 writers were lazy I suspe

Re: softmac mtu

2006-09-25 Thread Matthieu CASTET
So why a special mtu handler is not implemented in 802.11 stack : - 802.11 stack doesn't support bigger packet - 802.11 stack doesn't support very bigger packet (with 802.11 fragmentation) - 802.11 writers were lazy Matthieu - To unsubscribe from this list: send the line "unsubscribe netdev" in t

Re: kernel: TKIP: replay detected:

2006-09-25 Thread Matthieu CASTET
Hi, On Mon, 25 Sep 2006 10:50:00 -0400, John W. Linville wrote: > On Sun, Sep 24, 2006 at 12:40:53PM +0200, Elimar Riesebieter wrote: > >> My sylog is filled up with thousands of: >> Sep 21 18:18:00 aragorn kernel: TKIP: replay detected: \ >> STA=XX:XX:BB:LL:KK:00 previous TSC BLAa recei

Re: [PATCH v2 0/8] Updated patchset with Thomas' comments

2006-09-25 Thread James Morris
On Mon, 25 Sep 2006, [EMAIL PROTECTED] wrote: > This is an updated patchset which takes into account Thomas' comments. This > includes the addition of two new patches in the patchset which add a new > Netlink interface as well as correct the list of interfaces in the large > comment block at the

Re: [PATCH] Advertise PPPoE MTU / avoid memory leak.

2006-09-25 Thread Michal Ostrowski
On Sun, 2006-09-24 at 18:41 -0700, David Miller wrote: > From: Michal Ostrowski <[EMAIL PROTECTED]> > Date: Sun, 24 Sep 2006 07:29:25 -0500 > > > I think the call path via dev->hard_start_xmit, if it fails, may result > > in an skb not being freed. This appears to be the case with the e100.c > >

[PATCH v2 4/8] Netlink: add nla_for_each_nested() to the interface list

2006-09-25 Thread paul . moore
At the top of include/net/netlink.h is a list of Netlink interfaces, however, the nla_for_each_nested() macro was not listed. This patch adds this interface to the list at the top of the header file. Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- include/net/netlink.h |1 + 1 files change

[PATCH v2 3/8] NetLabel: change the SELinux permissions

2006-09-25 Thread paul . moore
Change NetLabel to use the 'recvfrom' socket permission and the SECINITSID_NETMSG SELinux SID as the NetLabel base SID for incoming packets. This patch effectively makes the old, and currently unused, SELinux NETMSG permissions NetLabel permissions. Signed-of-by: Paul Moore <[EMAIL PROTECTED]> ---

[PATCH v2 6/8] NetLabel: rework the Netlink attribute handling (part 1)

2006-09-25 Thread paul . moore
At the suggestion of Thomas Graf, rewrite NetLabel's use of Netlink attributes to better follow the common Netlink attribute usage. Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- include/net/cipso_ipv4.h | 16 +- include/net/netlabel.h | 49 net/ipv4/cipso_ip

[PATCH v2 8/8] NetLabel: update docs with website information

2006-09-25 Thread paul . moore
Now that all of the supporting pieces of NetLabel have a home at SourceForge update the Kconfig help text and add an entry to the MAINTAINERS file. Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- MAINTAINERS |7 +++ net/netlabel/Kconfig |5 - 2 files changed, 11 inserti

[PATCH v2 1/8] NetLabel: correct improper handling of non-NetLabel peer contexts

2006-09-25 Thread paul . moore
Fix a problem where NetLabel would always set the value of sk_security_struct->peer_sid in selinux_netlbl_sock_graft() to the context of the socket, causing problems when users would query the context of the connection. This patch fixes this so that the value in sk_security_struct->peer_sid is on

[PATCH v2 5/8] Netlink: add nla_validate_nested()

2006-09-25 Thread paul . moore
Add a new function, nla_validate_nested(), to validate nested Netlink attributes. Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- include/net/netlink.h | 19 +++ 1 files changed, 19 insertions(+) Index: net-2.6.19/include/net/netlink.h

[PATCH v2 0/8] Updated patchset with Thomas' comments

2006-09-25 Thread paul . moore
This is an updated patchset which takes into account Thomas' comments. This includes the addition of two new patches in the patchset which add a new Netlink interface as well as correct the list of interfaces in the large comment block at the top of include/net/netlink.h. Please consider these pa

[PATCH v2 2/8] NetLabel: make the CIPSOv4 cache spinlocks bottom half safe

2006-09-25 Thread paul . moore
The CIPSOv4 cache traversal routines are triggered both the userspace events (cache invalidation due to DOI removal or updated SELinux policy) and network packet processing events. As a result there is a problem with the existing CIPSOv4 cache spinlocks as they are not bottom-half/softirq safe. T

Re: [d80211 patch 1/1] setting bss freq and phymode using rx_status

2006-09-25 Thread mabbas
actaully we dont even need local->conf.channel. rx_status->channel holds the channel we physically received the frame on. channel hold the value from ds. if they are not equal then adjust freq. Attached is the modified patch Signed-off-by: Mohamed Abbas <[EMAIL PROTECTED]> diff --git a/net/d

Fw: [Bugme-new] [Bug 7202] New: sun happy meal ethernet driver problem

2006-09-25 Thread Andrew Morton
Begin forwarded message: Date: Mon, 25 Sep 2006 09:23:59 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 7202] New: sun happy meal ethernet driver problem http://bugzilla.kernel.org/show_bug.cgi?id=7202 Summary: sun happy meal ethernet driver problem

Re: [RFC] genetlink custom attribute type

2006-09-25 Thread Johannes Berg
On Wed, 2006-09-20 at 08:24 +0200, Thomas Graf wrote: > I think its best to use your patch for now and see where this leads to. Alright, should I repost with a proper [PATCH] subject or is it good to take as-is? :) johannes - To unsubscribe from this list: send the line "unsubscribe netdev" in t

Re: [d80211 patch 1/1] setting bss freq and phymode using rx_status

2006-09-25 Thread Jiri Benc
On Fri, 22 Sep 2006 15:29:42 -0700, mabbas wrote: > - bss->hw_mode = local->conf.phymode; > + bss->hw_mode = rx_status->phymode; > bss->channel = channel; > - bss->freq = local->conf.freq; > + bss->freq = rx_status->freq; > if (channel != local->conf.channel && >

Re: [PATCH] small fix for d80211:sta_info

2006-09-25 Thread Jiri Benc
On Mon, 25 Sep 2006 15:35:34 +0200, Savin Zlobec wrote: > while testing the rt2x00 driver I've found a > problem in d80211 stack which results in kernel panic. > I experienced kernel panic every time I unloaded the > rt2x00 driver module after associating with my AP. > > The problem traced down to

[PATCH] ieee80211: quiet TKIP and CCMP replay messages for identical TSCs

2006-09-25 Thread Larry Finger
When using TKIP and CCMP for wireless encryption with ieee80211, the logs get filled with useless replay messages where the previous and received TSC are identical. This change deletes the log message for this case, but still prints the message when there are major differences in the TSC's. Sig

Re: [PATCH 5/6] NetLabel: rework the Netlink attribute handling (part 2)

2006-09-25 Thread Paul Moore
Thomas Graf wrote: > * Paul Moore <[EMAIL PROTECTED]> 2006-09-25 10:13 > - ret_val = netlbl_netlink_snd(ans_skb, info->snd_pid); + switch (doi_def->type) { + case CIPSO_V4_MAP_STD: + nla_a = nla_nest_start(ans_skb, NLBL_CIPSOV4_A_MLSLVLLST); + if (nla_

Re: [PATCH 5/6] NetLabel: rework the Netlink attribute handling (part 2)

2006-09-25 Thread Thomas Graf
* Paul Moore <[EMAIL PROTECTED]> 2006-09-25 10:13 > >>- ret_val = netlbl_netlink_snd(ans_skb, info->snd_pid); > >>+ switch (doi_def->type) { > >>+ case CIPSO_V4_MAP_STD: > >>+ nla_a = nla_nest_start(ans_skb, NLBL_CIPSOV4_A_MLSLVLLST); > >>+ if (nla_a == NULL) { > >>+

Re: [PATCH 02/03] net/bridge: add support for EtherIP devices

2006-09-25 Thread Joerg Roedel
On Mon, Sep 25, 2006 at 07:40:09AM -0700, Stephen Hemminger wrote: > > To get a list of all EtherIP devices, just maintain a linked list > in the private device information. Use list macros, it isn't hard. I use lists in the driver to maintain the list. The problem is to get such a list in usersp

Re: kernel: TKIP: replay detected:

2006-09-25 Thread John W. Linville
On Sun, Sep 24, 2006 at 12:40:53PM +0200, Elimar Riesebieter wrote: > My sylog is filled up with thousands of: > Sep 21 18:18:00 aragorn kernel: TKIP: replay detected: \ > STA=XX:XX:BB:LL:KK:00 previous TSC BLAa received TSC BLAa > Sep 21 18:18:29 aragorn kernel: printk: 62 message

Re: [PATCH,RFT] ieee80211: Move IV/ICV stripping into ieee80211_rx

2006-09-25 Thread Michael Buesch
On Monday 25 September 2006 00:43, Daniel Drake wrote: > This patch adds a host_strip_iv_icv flag to ieee80211 which indicates that > ieee80211_rx should strip the IV/ICV/other security features from the payload. > This saves on some memmove() calls in the driver and seems like something that > bel

Re: [PATCH 02/03] net/bridge: add support for EtherIP devices

2006-09-25 Thread Stephen Hemminger
On Mon, 25 Sep 2006 10:24:45 +0200 Joerg Roedel <[EMAIL PROTECTED]> wrote: > On Sat, Sep 23, 2006 at 09:01:12PM -0700, Stephen Hemminger wrote: > > > If the device looks like a duck (Ethernet), then why does it need > > a separate ARP type. There are other tools that might work without > > modif

[PATCH 2.6.19-rc1] ehea firmware interface based on Anton Blanchard's new hvcall interface

2006-09-25 Thread Jan-Bernd Themann
Hello Jeff, this eHEA patch reflects changes according to Anton's new hvcall interface which has been commited in Paul's git tree: git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git Thanks to this change our pHYP interface needs less lines of code. In addition to the above changes

Re: [PATCH 5/6] NetLabel: rework the Netlink attribute handling (part 2)

2006-09-25 Thread Paul Moore
Thomas Graf wrote: > * [EMAIL PROTECTED] <[EMAIL PROTECTED]> 2006-09-21 12:57 > >>At the suggestion of Thomas Graf, rewrite NetLabel's use of Netlink attributes >>to better follow the common Netlink attribute usage. >> >>Signed-off-by: Paul Moore <[EMAIL PROTECTED]> >>--- >> net/netlabel/netlabel_

Re: tc related lockdep warning.

2006-09-25 Thread Patrick McHardy
jamal wrote: > On Mon, 2006-25-09 at 14:43 +0200, Jarek Poplawski wrote: > > >>It's probably 2.6.18 and should change a little now (git4) but >>IMHO main problem stays: it looks tcf_act_police_locate in >>act_police.c was preempted in read_lock (tcf_police_lookup) >>- now the same is possible in

Re: tc related lockdep warning.

2006-09-25 Thread Jarek Poplawski
On 25-09-2006 14:47, jamal wrote: > On Mon, 2006-25-09 at 14:43 +0200, Jarek Poplawski wrote: > >> It's probably 2.6.18 and should change a little now (git4) but >> IMHO main problem stays: it looks tcf_act_police_locate in >> act_police.c was preempted in read_lock (tcf_police_lookup) >> - now th

Re: Is TCP over IPsec broken in 2.6.18?

2006-09-25 Thread jamal
On Mon, 2006-25-09 at 16:05 +0400, Evgeniy Polyakov wrote: > On Mon, Sep 25, 2006 at 09:27:54PM +1000, Herbert Xu ([EMAIL PROTECTED]) > wrote: > > Please run ip x p once every second and the post what it shows > > before, during and after the period when unecrypted packets show > > up on the wire

Re: tc related lockdep warning.

2006-09-25 Thread jamal
On Mon, 2006-25-09 at 14:43 +0200, Jarek Poplawski wrote: > It's probably 2.6.18 and should change a little now (git4) but > IMHO main problem stays: it looks tcf_act_police_locate in > act_police.c was preempted in read_lock (tcf_police_lookup) > - now the same is possible in tcf_hash_lookup. So

Re: tc related lockdep warning.

2006-09-25 Thread Jarek Poplawski
On 24-09-2006 23:29, Dave Jones wrote: > = > [ INFO: inconsistent lock state ] > - > inconsistent {softirq-on-R} -> {in-softirq-W} usage. > swapper/0 [HC0[0]:SC1[2]:HE1:SE0] takes: > (police_lock){-+--}, at: [] tcf_police_destroy+0x24

Re: [PATCH 00/03][RESUBMIT] net: EtherIP tunnel driver

2006-09-25 Thread Joerg Roedel
On Mon, Sep 25, 2006 at 02:16:15PM +0200, Andi Kleen wrote: > On Monday 25 September 2006 13:57, Joerg Roedel wrote: > > On Mon, Sep 25, 2006 at 12:22:41PM +0200, Andi Kleen wrote: > > > > > How would you convince those old LAN games to use a MTU < 1500 which > > > is needed for the tunnel? I bet

Re: [PATCH 00/03][RESUBMIT] net: EtherIP tunnel driver

2006-09-25 Thread Andi Kleen
On Monday 25 September 2006 13:57, Joerg Roedel wrote: > On Mon, Sep 25, 2006 at 12:22:41PM +0200, Andi Kleen wrote: > > > How would you convince those old LAN games to use a MTU < 1500 which > > is needed for the tunnel? I bet they have the size hardcoded. > > The tunnel provides an MTU of 1500

Re: PROBLEM: kernel BUG at net/ipv6/ip6_output.c:718

2006-09-25 Thread Herbert Xu
On Fri, Sep 01, 2006 at 06:22:48PM +0200, cagri coltekin wrote: > > The second causes the system to give the bug a couple of seconds > after bind starts, and loads the zones, without any traffic going > on. BTW, patch applied with some offset difference (3 for the > first -48 for the other two chan

Re: Is TCP over IPsec broken in 2.6.18?

2006-09-25 Thread Evgeniy Polyakov
On Mon, Sep 25, 2006 at 09:27:54PM +1000, Herbert Xu ([EMAIL PROTECTED]) wrote: > On Mon, Sep 25, 2006 at 02:38:36PM +0400, Evgeniy Polyakov wrote: > > > > I ran two times the same 'telnet 192.168.4.79 22' and got unencrypted > > packets and very long timeout. After some magic initial process thin

Re: [PATCH 00/03][RESUBMIT] net: EtherIP tunnel driver

2006-09-25 Thread Joerg Roedel
On Mon, Sep 25, 2006 at 12:22:41PM +0200, Andi Kleen wrote: > How would you convince those old LAN games to use a MTU < 1500 which > is needed for the tunnel? I bet they have the size hardcoded. The tunnel provides an MTU of 1500. To guarantee this, it never sets the DF flag in outgoing packets.

Re: Is TCP over IPsec broken in 2.6.18?

2006-09-25 Thread Herbert Xu
On Mon, Sep 25, 2006 at 02:38:36PM +0400, Evgeniy Polyakov wrote: > > I ran two times the same 'telnet 192.168.4.79 22' and got unencrypted > packets and very long timeout. After some magic initial process things > started to work as expected - only ESP encrypted packets can be found in > tcpdump,

Re: [PATCH 00/03][RESUBMIT] net: EtherIP tunnel driver

2006-09-25 Thread Andi Kleen
David Miller <[EMAIL PROTECTED]> writes: > > First, the only mentioned real use of EtherIP I've seen anywhere is to > tunnel old LAN based games that used protocols other than IP :-) How would you convince those old LAN games to use a MTU < 1500 which is needed for the tunnel? I bet they have th

Re: bcm43xx driver unstable behaviour (and linux wireless is junk btw)

2006-09-25 Thread Johannes Berg
On Mon, 2006-09-25 at 19:58 +1000, Benjamin Herrenschmidt wrote: > Doh ! Scary... locking is hard ... if the stuff was written without > locking in mind in the first place, it might end up being a nightmare... Yeah, I've actually suggested "rewriting" it from its own pieces :) But Jiri says he un

Re: bcm43xx driver unstable behaviour (and linux wireless is junk btw)

2006-09-25 Thread Benjamin Herrenschmidt
> yes. Many locking issues in d80211 to still sort out. Basically, there > are next to no useful locks in it and most data structures are not > protected at all. Doh ! Scary... locking is hard ... if the stuff was written without locking in mind in the first place, it might end up being a nightma

Re: [PATCH] [ATM] he: Fix __init/__devinit conflict

2006-09-25 Thread chas williams - CONTRACTOR
In message <[EMAIL PROTECTED]>,David Miller writes: >Chas, as a subsystem maintainer, if you change a submitter's patch in >a significant and non-trivial way, you should at least mention a brief >reason why you did that. In this case, why did you delete all of >Roland's __init/__devinit transforma

Re: [PATCH 5/6] NetLabel: rework the Netlink attribute handling (part 2)

2006-09-25 Thread Thomas Graf
* [EMAIL PROTECTED] <[EMAIL PROTECTED]> 2006-09-21 12:57 > At the suggestion of Thomas Graf, rewrite NetLabel's use of Netlink attributes > to better follow the common Netlink attribute usage. > > Signed-off-by: Paul Moore <[EMAIL PROTECTED]> > --- > net/netlabel/netlabel_cipso_v4.c | 593 > ++

Re: [PATCH 4/6] NetLabel: rework the Netlink attribute handling (part 1)

2006-09-25 Thread Thomas Graf
* [EMAIL PROTECTED] <[EMAIL PROTECTED]> 2006-09-21 12:57 > -int netlbl_netlink_snd_multicast(struct sk_buff *skb, u32 pid, u32 group) > +int netlbl_netlink_snd_multicast(struct sk_buff *skb, > + void *buf, > + u32 pid, > +

Re: [RFC 1/3] cfg80211/nl80211 core

2006-09-25 Thread Johannes Berg
On Fri, 2006-09-22 at 17:48 +0200, Jiri Benc wrote: > On Thu, 14 Sep 2006 12:49:23 +0200, Johannes Berg wrote: > > There should be support for notifications, but we need to figure > > out if we remove the sysfs based add/remove virtual interface > > thing completely or allow the driver to create a

Re: bcm43xx driver unstable behaviour (and linux wireless is junk btw)

2006-09-25 Thread Johannes Berg
On Sun, 2006-09-24 at 16:18 +1000, Benjamin Herrenschmidt wrote: > So what are the chances of getting this dscape stack merged, let's > say... for 2.6.19 ? 0 > Or we'll get yet another full release with barely > working wireless ? yes. Many locking issues in d80211 to still sort out. Basically

Re: [PATCH,RFT] ieee80211: Move IV/ICV stripping into ieee80211_rx

2006-09-25 Thread Johannes Berg
On Sun, 2006-09-24 at 23:43 +0100, Daniel Drake wrote: > This patch adds a host_strip_iv_icv flag to ieee80211 which indicates that > ieee80211_rx should strip the IV/ICV/other security features from the payload. > This saves on some memmove() calls in the driver and seems like something that > bel

  1   2   >