Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread Hasso Tepper
Herbert Xu wrote: > Hasso Tepper <[EMAIL PROTECTED]> wrote: > >> You can disable it in /proc/sys/net/ipv6/conf/default/... and then > >> reenable it on the interfaces that you actually want. > > > > You can't do that either (ie. reenable) in initscripts before link is > > up. > > As soon as you do

RE: e1000 and 802.1ad/stacked vlan tagging

2006-08-29 Thread Brandeburg, Jesse
Stephan von Krawczynski wrote: > I can confirm that the setup seems to work if enlarging the hw if mtu > to 1508. This is good. Okay, good to hear. > Nevertheless I think that the receive buffer size of a > physical device should always be MAX(all virtual device mtu + > tags and the like), you kn

Re: [PATCH] Fix verify_iovec() to not allow overflow of iov_len values

2006-08-29 Thread David Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Tue, 29 Aug 2006 10:55:29 -0700 > verify_iovec() has the following piece of code that allows overflow > of iov_len values in an iovec. > > for (ct = 0; ct < m->msg_iovlen; ct++) { > err += iov[ct].iov_len; >

RE: [PATCH 08/26] e1000: Deprecate mii-tool SIOCMIIREG ioctl

2006-08-29 Thread Brandeburg, Jesse
Jeff Garzik wrote: > Kok, Auke wrote: >> Deprecate mii-tool SIOCMIIREG ioctl. This ioctl is broken in e1000 >> and ethtool has this functionality in working order. >> >> Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> >> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> > > This doesn't "deprecated" an

Re: [PATCH] strip: neighbour table refcount leak

2006-08-29 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 29 Aug 2006 14:59:36 -0700 > Found by inspection. The STRIP driver does neigh_lookup() but never releases. > This driver shouldn't being doing gratuitous arp anyway. > Untested, obviously, because of lack of hardware. > > Signed-off-by: Steph

net-2.6.19 rebased

2006-08-29 Thread David Miller
I've just rebased to net-2.6.19 tree to be against Linus's current GIT. Just FYI. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Fw: [Bugme-new] [Bug 7074] New: Kernel Panic on kernel 2.6.16.1

2006-08-29 Thread Andrew Morton
Obvious question: does it happen with 2.6.17.x or 2.6.18-rc5? Begin forwarded message: Date: Tue, 29 Aug 2006 19:49:11 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 7074] New: Kernel Panic on kernel 2.6.16.1 http://bugzilla.kernel.org/show_bug.cgi?id=7074

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 30 Aug 2006 10:12:10 +1000), Herbert Xu <[EMAIL PROTECTED]> says: > Hasso Tepper <[EMAIL PROTECTED]> wrote: > > > >> You can disable it in /proc/sys/net/ipv6/conf/default/... and then > >> reenable it on the interfaces that you actually want. > > > > You c

[PATCH] WE-21 for zd1211rw

2006-08-29 Thread Daniel Drake
Looks like zd1211rw was forgotten from the WE-21 migration. This patch should do it... Signed-off-by: Daniel Drake <[EMAIL PROTECTED]> --- zd_netdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Index: linux-2.6/drivers/net/wireless/zd1211rw/zd_netdev.c ==

[PATCH 2.6.18] Prism54 : add bitrates to scan result

2006-08-29 Thread Jean Tourrilhes
Hi John, This is unrelated to WE-21. It just adds bitrate information to the scan result in the Prism54 driver, like some/most other driver do. Rediffed and retested with 2.6.18-rc, apply with fuzz to wireless-2.6 (ask me for a clean wireless-2.6 patch). Have fun..

[PATCH 2.6.18] WE-21 for bcm43xx (wireless-2.6 git)

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for Broadcom driver and SoftMAC... This version is for wireless-2.6 git. Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/net/ieee80211/softmac/ieee80211softmac_wx.20.c

[PATCH 2.6.18] WE-21 for prism54usb

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for Prism54 SoftMAC driver... Patch for wireless-2.6 git. And most likely useless ;-) Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/prism54usb/is

[PATCH 2.6.18] WE-21 for bcm43xx (2.6.18-rc5)

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for Broadcom driver and SoftMac... This version is for 2.6.18-rc5. Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/net/ieee80211/softmac/ieee80211softmac_wx.20.c linu

[PATCH 2.6.18] WE-21 for tiacx

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for TI ACX driver... Patch for wireless-2.6 git. Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- --- linux/drivers/net/wireless/tiacx/ioctl.20.c 2006-08-29 15:38:59.0 -0700 ++

[PATCH 2.6.18] WE-21 for adm8211

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for ADMTek driver... Patch for wireless-2.6 git... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/adm8211/adm8211_ioctl.20.c linux/drivers/net/w

[PATCH 2.6.18] WE-21 for zd1201

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for ZyDAS driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/zd1201.20.c linux/drivers/net/wireless/zd1201.c --- linux/drivers/net/wireless/zd1201

[PATCH 2.6.18] WE-21 for ray_cs

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for Raylink driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/ray_cs.20.c linux/drivers/net/wireless/ray_cs.c --- linux/drivers/net/wireless/ray_

[PATCH 2.6.18] WE-21 for orinoco

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for Orinoco driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/orinoco.20.c linux/drivers/net/wireless/orinoco.c --- linux/drivers/net/wireless/or

[PATCH 2.6.18] WE-21 for wl3501

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for wl3501 driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- --- linux/drivers/net/wireless/wl3501_cs.20.c 2006-08-28 17:41:19.0 -0700 +++ linux/drivers/net/wireless/wl3501_

[PATCH 2.6.18] WE-21 support (core API)

2006-08-29 Thread Jean Tourrilhes
Hi John, This is version 21 of the Wireless Extensions. Changelog : o finishes migrating the ESSID API (remove the +1) o netdev->get_wireless_stats is no more o modulation o long/short retry o relative

[PATCH 2.6.18] WE-21 for Prism54

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for Prism54 driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/prism54/isl_ioctl.20.c linux/drivers/net/wireless/prism54/isl_ioctl.c --- linux/dri

[PATCH 2.6.18] WE-21 for ipw2100

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for IPW2100 driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/ipw2100.20.c linux/drivers/net/wireless/ipw2100.c --- linux/drivers/net/wireless/ip

[PATCH 2.6.18] WE-21 for ipw2200

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for IPW2200 driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/ipw2200.20.c linux/drivers/net/wireless/ipw2200.c --- linux/drivers/net/wireless/ip

[PATCH 2.6.18] WE-21 for hostap

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for HostAP driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/hostap/hostap_ioctl.20.c linux/drivers/net/wireless/hostap/hostap_ioctl.c --- linux

[PATCH 2.6.18] WE-21 for atmel

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for Atmel driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/atmel.19.c linux/drivers/net/wireless/atmel.c --- linux/drivers/net/wireless/atmel.1

[PATCH 2.6.18] WE-21 for airo

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for Aironet driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/airo.20.c linux/drivers/net/wireless/airo.c --- linux/drivers/net/wireless/airo.20.

Re: [PATCH 0/6] Various NetLabel fixes and cleanups

2006-08-29 Thread David Miller
From: [EMAIL PROTECTED] Date: Tue, 29 Aug 2006 10:42:51 -0400 > This patchset contains a series of small patches to fix a bug and some general > ugliness from the original author (that moron ...). All of the following > patches are against David's net-2.6.19 tree. > > Please consider these for 2

Re: [PATCH -net-2.6.19] net/*: don't panic

2006-08-29 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 29 Aug 2006 07:50:43 +0400 > IPv6 can be modular and panicking on module loading is the last thing > you want. > > Two SLAB_PANIC cases converted to error propagating as well as one > panic() call. > > Signed-off-by: Alexey Dobriyan <[EMAIL PR

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread Herbert Xu
Hasso Tepper <[EMAIL PROTECTED]> wrote: > >> You can disable it in /proc/sys/net/ipv6/conf/default/... and then >> reenable it on the interfaces that you actually want. > > You can't do that either (ie. reenable) in initscripts before link is up. As soon as you do ifconfig ethX up it'll appear in

Re: [PATCH 4/6] net neighbour: convert to RCU

2006-08-29 Thread Alexey Kuznetsov
Hello! > Race 1: w/o RCU > Cpu 0: is in neigh_lookup > gets read_lock() > finds entry > ++refcount to 2 >

Re: [PATCH 4/6] net neighbour: convert to RCU

2006-08-29 Thread Stephen Hemminger
On Wed, 30 Aug 2006 03:21:26 +0400 Alexey Kuznetsov <[EMAIL PROTECTED]> wrote: > Hello! > > > This should not be any more racy than the existing code. > > Existing code is not racy. Race 1: w/o RCU Cpu 0: is in neigh_lookup

Re: [PATCH 4/6] net neighbour: convert to RCU

2006-08-29 Thread Alexey Kuznetsov
Hello! Yes, I forgot to say I take back my suggestion about atomic_inc_test_zero(). It would not work. Seems, it is possible to add some barriers around setting n->dead and testing it in neigh_lookup_rcu(), but it would be scary and ugly. To be honest, I just do not know how to do this. :-) - To

Re: [PATCH 4/6] net neighbour: convert to RCU

2006-08-29 Thread Alexey Kuznetsov
Hello! > This should not be any more racy than the existing code. Existing code is not racy. Critical place is interpretation of refcnt==1. Current code assumes, that when refcnt=1 and entry is in hash table, nobody can take this entry (table is locked). So, it can be unlinked from the table. S

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-08-29 Thread Michael Wu
On Tuesday 29 August 2006 15:50, Michael Wu wrote: > On Tuesday 29 August 2006 15:28, Mohamed Abbas wrote: > > SIOCGIWAP will always report the bssid no > > matter what the status of our link. > > That is not the case at the moment. Were you planning to change that? > Opps, it looks like it is the

Re: [PATCH 4/6] net neighbour: convert to RCU

2006-08-29 Thread Stephen Hemminger
Here is the full version of neigh_lookup_rcu(). The race of interest is what happens when neigh_lookup_rcu() returns a table entry and it gets deleted at the same time. See Documentation/RCU/listRCU.txt for more info. There are a couple different scenario's. 1) update or reader looking at dead e

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-08-29 Thread Michael Wu
On Tuesday 29 August 2006 15:28, Mohamed Abbas wrote: > SIOCGIWAP will always report the bssid no > matter what the status of our link. That is not the case at the moment. Were you planning to change that? -Michael Wu pgp7bBAqpyAe6.pgp Description: PGP signature

[PATCH] zd1211rw: Removed unneeded packed attributes

2006-08-29 Thread Daniel Drake
From: Ulrich Kunitz <[EMAIL PROTECTED]> Inspired by an e-mail by Stephen Hemminger I decided to remove all unneeded packed attributes from the code where the member variables are already aligned. This avoids horrible code being generated on some architectures. Signed-off-by: Ulrich Kunitz <[EMAIL

[PATCH] zd1211rw: Fix of signal strength and quality measurement

2006-08-29 Thread Daniel Drake
From: Ulrich Kunitz <[EMAIL PROTECTED]> Caused by a documentation issue I mixed up fields of the zd_status structure. This patch fixes it and improves also the average computation, which is now using only measurements of packets sent by the access point. Signed-off-by: Ulrich Kunitz <[EMAIL PROTE

[PATCH] zd1211rw: Add ID for Asus WL-159g

2006-08-29 Thread Daniel Drake
Tested by Vincent TOUCHARD zd1211 chip 0b05:170c v4802 high 00-11-d8 AL2230_RF pa0 g--- Signed-off-by: Daniel Drake <[EMAIL PROTECTED]> --- zd_usb.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Index: linux-2.6/drivers/net/wireless/zd1211rw/zd_usb.c ===

[PATCH] zd1211rw: Add ID for Siemens Gigaset USB Stick 54

2006-08-29 Thread Daniel Drake
Tested by Martin Dummer. zd1211 chip 0b3b:5630 v4330 high 00-01-e3 RF2959_RF pa0 --- Signed-off-by: Daniel Drake <[EMAIL PROTECTED]> --- zd_usb.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Index: linux-2.6/drivers/net/wireless/zd1211rw/zd_usb.c ==

Re: [PATCH 22/26] ixgb: Cache-align all TX components of the adapter struct.

2006-08-29 Thread Auke Kok
Jeff Garzik wrote: Eric Dumazet wrote: On Tuesday 29 August 2006 18:45, Kok, Auke wrote: /* TX */ -struct ixgb_desc_ring tx_ring; +struct ixgb_desc_ring tx_ring cacheline_aligned; unsigned long timeo_start; On UP, this would only enlarge the size of structure and might c

Re: [PATCH 11/26] e1000: clean up skb allocation code, patch submitted by Christoph

2006-08-29 Thread Auke Kok
Jeff Garzik wrote: Kok, Auke wrote: Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Acked-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> ACK, but please don't include attribution in the subject line. Add a "From: ...author..." as the first line of yo

Re: [PATCH 15/26] e100: reduce time under spinlock

2006-08-29 Thread Auke Kok
Jeff Garzik wrote: Kok, Auke wrote: We're waiting for a write flush to finish before unlocking, which is not needed. Release the spinlock after the write command. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> This undoes the following change: ack, not good. Dropped it from the tree. Auke

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-08-29 Thread Mohamed Abbas
Jouni Malinen wrote: On Mon, Aug 28, 2006 at 02:17:34PM -0700, Michael Wu wrote: It would be helpful if you inlined your patches instead of attaching them next time. Agreed. I'm not comfortable with using the name for this purpose. And agreed. wireless.h has this to say a

Re: IPSec kernel oops on ppc64

2006-08-29 Thread Joy Latten
>> I can try patch-2.6.18-rc1, etc... to see which one it stops >> working on to narrow it down. > >If you could do this in the meanwhile, it would help us out >a lot. > It stops working in patch-2.6.18-rc1. Regards, Joy - To unsubscribe from this list: send the line "unsubscribe netdev" in the b

Re: [PATCH 4/7] d80211: add support for SIOCSIWNICKN SIOCGIWNICKN

2006-08-29 Thread Michael Wu
On Tuesday 29 August 2006 15:15, Ulrich Kunitz wrote: > The softmac-broadcom and the zd1211 driver are using it to give some > information about the driver bound to the interface. I found it > quite useful to know which driver is bound to which WLAN > interface. A readonly driver text info field wo

Re: [PATCH 09/26] e1000: unify WoL capability detection code

2006-08-29 Thread Auke Kok
Jeff Garzik wrote: Kok, Auke wrote: WoL is constantly giving problems and needed a rewrite. Consolidates all WoL capabilities into a single function, and disables WoL for all other ports on the device except for port A. Is this a behavior change that affects users in the field? i.e. if they a

Re: [PATCH 4/6] net neighbour: convert to RCU

2006-08-29 Thread Alexey Kuznetsov
Hello! > > Also, probably, it makes sense to add neigh_lookup_light(), which does > > not take refcnt, but required to call > > neigh_release_light() (which is just rcu_read_unlock_bh()). > > Which code paths would that make sense on? > fib_detect_death (ok) > infiniband (ok) >

Re: [PATCH 4/7] d80211: add support for SIOCSIWNICKN SIOCGIWNICKN

2006-08-29 Thread Ulrich Kunitz
On 06-08-29 10:45 Jouni Malinen wrote: > The only reason for adding nick command would be to maintain backwards > compatibility with some scripts. I do not use any distro configuration > mechanisms for setting up wireless, so I do not know what is currently > being used. I would not add these ioct

Re: [PATCH 0/1] [DCCP]: Tidy up code slightly

2006-08-29 Thread Ian McDonald
> I haven't seen this go into the 2.6.19 tree yet? Because I simply haven't applied it yet. OK. My apologies for hassling you. I'm being too hasty and Arnaldo has correctly chastised me. -- Ian McDonald Web: http://wand.net.nz/~iam4 Blog: http://imcdnzl.blogspot.com WAND Network Research Group

[PATCH] strip: neighbour table refcount leak

2006-08-29 Thread Stephen Hemminger
Found by inspection. The STRIP driver does neigh_lookup() but never releases. This driver shouldn't being doing gratuitous arp anyway. Untested, obviously, because of lack of hardware. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- linux-2.6.orig/drivers/net/wireless/strip.c +++ linux-2

Re: [PATCH 4/6] net neighbour: convert to RCU

2006-08-29 Thread Stephen Hemminger
On Wed, 30 Aug 2006 01:17:22 +0400 Alexey Kuznetsov <[EMAIL PROTECTED]> wrote: > Hello! > > > atomic_inc_and_test is true iff result is zero, so that won't work. > > I meant atomic_inc_not_zero(), as Martin noticed. > > > > But the following should work: > > > > hlist_for_each_entry_rcu(n

Re: Fw: 2.6.18-rc4-mm3: BUG: warning at include/net/dst.h:154/dst_release()

2006-08-29 Thread Valdis . Kletnieks
On Tue, 29 Aug 2006 20:24:33 +0200, Thomas Graf said: > > Seeing this a lot on 2.6.18-rc4-mm3 with 2 different stack tracebacks > > (one for received packets, other for sending). I already picked up the > > fix for the ^ / confusion in fib_rules.c and that didn't help matters. > > Should be fixe

Re: [PATCH 0/1] [DCCP]: Tidy up code slightly

2006-08-29 Thread David Miller
From: "Ian McDonald" <[EMAIL PROTECTED]> Date: Wed, 30 Aug 2006 07:05:47 +1200 > On 8/28/06, David Miller <[EMAIL PROTECTED]> wrote: > > From: Ian McDonald <[EMAIL PROTECTED]> > > Date: Mon, 28 Aug 2006 16:34:50 +1200 > > > > > Arnaldo has pointed this one out to me in latest series of > > > patch

Re: [PATCH 22/26] ixgb: Cache-align all TX components of the adapter struct.

2006-08-29 Thread Auke Kok
Jeff Garzik wrote: Eric Dumazet wrote: On Tuesday 29 August 2006 18:45, Kok, Auke wrote: /* TX */ -struct ixgb_desc_ring tx_ring; +struct ixgb_desc_ring tx_ring cacheline_aligned; unsigned long timeo_start; On UP, this would only enlarge the size of structure and might c

Re: [PATCH 1/9] sky2: remove cloned/pskb_expand_head check

2006-08-29 Thread Jeff Garzik
applied 1-9 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] skge: cleanup suspend/resume code

2006-08-29 Thread Jeff Garzik
applied 1-5 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/6] net neighbour: convert to RCU

2006-08-29 Thread Alexey Kuznetsov
Hello! > atomic_inc_and_test is true iff result is zero, so that won't work. I meant atomic_inc_not_zero(), as Martin noticed. > But the following should work: > > hlist_for_each_entry_rcu(n, tmp, &tbl->hash_buckets[hash_val], hlist) { > if (dev == n->dev && !memcmp(n->prim

Re: [PATCH] Fix verify_iovec() to not allow overflow of iov_len values

2006-08-29 Thread Sridhar Samudrala
On Tue, 2006-08-29 at 11:20 -0700, Chris Wright wrote: > * Sridhar Samudrala ([EMAIL PROTECTED]) wrote: > > -int verify_iovec(struct msghdr *m, struct iovec *iov, char *address, int > > mode) > > +ssize_t verify_iovec(struct msghdr *m, struct iovec *iov, char *address, > > int mode) > > { > >

Re: [PATCH 7/9] sky2: power down PHY when not up

2006-08-29 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: To save power, don't enable power to the PHY until device is brought up. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Strongly agree, and ACK, but note that users have complained in the past when they could not configure their MAC when the interface was down.

Re: [PATCH 26/26] ixgb: Increment version to 1.0.112-k2

2006-08-29 Thread Jeff Garzik
ACK patches 23-26 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 7/9] sky2: power down PHY when not up

2006-08-29 Thread Stephen Hemminger
On Tue, 29 Aug 2006 17:04:59 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote: > > To save power, don't enable power to the PHY until device is brought up. > > > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> > > Strongly agree, and ACK, but note that users have com

Re: [PATCH 21/26] ixgb: recalculate after how many descriptors to wake the queue

2006-08-29 Thread Jeff Garzik
ACK patches 16-21 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 22/26] ixgb: Cache-align all TX components of the adapter struct.

2006-08-29 Thread Jeff Garzik
Eric Dumazet wrote: On Tuesday 29 August 2006 18:45, Kok, Auke wrote: /* TX */ - struct ixgb_desc_ring tx_ring; + struct ixgb_desc_ring tx_ring cacheline_aligned; unsigned long timeo_start; On UP, this would only enlarge the size of structure and might consume m

Re: [patch 08/10] [TULIP] Handle pci_enable_device() errors in resume

2006-08-29 Thread Jeff Garzik
ditto Alan's comments, particularly exiting w/out unlocking - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 08/26] e1000: Deprecate mii-tool SIOCMIIREG ioctl

2006-08-29 Thread Jeff Garzik
Kok, Auke wrote: Deprecate mii-tool SIOCMIIREG ioctl. This ioctl is broken in e1000 and ethtool has this functionality in working order. Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> This doesn't "deprecated" anything, it changes the ABI on a user'

Re: [PATCH 15/26] e100: reduce time under spinlock

2006-08-29 Thread Jeff Garzik
Kok, Auke wrote: We're waiting for a write flush to finish before unlocking, which is not needed. Release the spinlock after the write command. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> This undoes the following change: commit ad8c48ad3bbef078616ed4d2652d362dfd962f09 Author: Catalin(ux aka

Re: [PATCH 09/26] e1000: unify WoL capability detection code

2006-08-29 Thread Jeff Garzik
Kok, Auke wrote: WoL is constantly giving problems and needed a rewrite. Consolidates all WoL capabilities into a single function, and disables WoL for all other ports on the device except for port A. Is this a behavior change that affects users in the field? i.e. if they are using WoL via por

Re: [patch 10/10] [TULIP] Update winbond840.c version

2006-08-29 Thread Jeff Garzik
ACK patches 9-10 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 07/10] [TULIP] Use tulip.h in winbond-840.c

2006-08-29 Thread Jeff Garzik
ACK patches 1-7 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 14/26] e100: fix error recovery

2006-08-29 Thread Jeff Garzik
ACK patches 12-14 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 07/26] e1000: Use module param array code

2006-08-29 Thread Jeff Garzik
ACK patches 1-7 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 11/26] e1000: clean up skb allocation code, patch submitted by Christoph

2006-08-29 Thread Jeff Garzik
Kok, Auke wrote: Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Acked-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> ACK, but please don't include attribution in the subject line. Add a "From: ...author..." as the first line of your patch description

Re: [PATCH 3/5] skge: use dev_alloc_skb

2006-08-29 Thread Stephen Hemminger
On Tue, 29 Aug 2006 12:23:36 +0100 Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Mon, Aug 28, 2006 at 04:19:37PM -0700, Stephen Hemminger wrote: > > To avoid problems with buggy protocols that assume extra header space, > > use dev_alloc_skb() when allocating receive buffers. > > > > Signed-o

Re: [PATCH 1/6] NetLabel: correctly initialize the NetLabel fields

2006-08-29 Thread Paul Moore
James Morris wrote: > On Tue, 29 Aug 2006, Paul Moore wrote: >>James Morris wrote: >>>On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: >>> +void selinux_netlbl_sk_security_init(struct sk_security_struct *ssec, +int family) +{ +if (family == PF_IN

Re: [PATCH 4/6] net neighbour: convert to RCU

2006-08-29 Thread Stephen Hemminger
On Tue, 29 Aug 2006 20:34:01 +0200 Martin Josefsson <[EMAIL PROTECTED]> wrote: > On Tue, 2006-08-29 at 11:22 -0700, Stephen Hemminger wrote: > > > > Probably, you should do atomic_inc_and_test() here and restart lookup, > > > if it fails. > > > > > > Alexey > > > > atomic_inc_and_test is true i

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread Olaf Kirch
On Tue, Aug 29, 2006 at 08:10:21PM +0200, Thomas Graf wrote: > > When the Xen people looked for a way to disable IPv6 autoconf of the > > bridge, they didn't find any way to do it without bringing up the > > device first (and thereby triggering DAD). > > They didn't find any because there is no ne

Re: [PATCH 1/4] net: VM deadlock avoidance framework

2006-08-29 Thread Indan Zupancic
On Tue, August 29, 2006 11:49, Peter Zijlstra said: > On Tue, 2006-08-29 at 02:01 +0200, Indan Zupancic wrote: >> Good that you're aware of it. Thing is, how much sense does the split-up into >> adjust_memalloc_reserve() and sk_adjust_memalloc() make at this point? Why >> not >> merge the code of

Re: [PATCH 1/6] NetLabel: correctly initialize the NetLabel fields

2006-08-29 Thread James Morris
On Tue, 29 Aug 2006, Paul Moore wrote: > James Morris wrote: > > On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: > >>+void selinux_netlbl_sk_security_init(struct sk_security_struct *ssec, > >>+int family) > >>+{ > >>+if (family == PF_INET) > > > > No tab. >

Re: [PATCH 0/1] [DCCP]: Tidy up code slightly

2006-08-29 Thread Arnaldo Carvalho de Melo
On 8/29/06, Ian McDonald <[EMAIL PROTECTED]> wrote: On 8/28/06, David Miller <[EMAIL PROTECTED]> wrote: > From: Ian McDonald <[EMAIL PROTECTED]> > Date: Mon, 28 Aug 2006 16:34:50 +1200 > > > Arnaldo has pointed this one out to me in latest series of > > patches. Can this go into 2.6.18 please? >

Re: [PATCH 0/1] [DCCP]: Tidy up code slightly

2006-08-29 Thread Ian McDonald
On 8/28/06, David Miller <[EMAIL PROTECTED]> wrote: From: Ian McDonald <[EMAIL PROTECTED]> Date: Mon, 28 Aug 2006 16:34:50 +1200 > Arnaldo has pointed this one out to me in latest series of > patches. Can this go into 2.6.18 please? It's not a bug fix, so we'll defer it to 2.6.19 I haven't se

Re: [patch 5/5] d80211: add ioctl to stop data frame tx

2006-08-29 Thread Jouni Malinen
On Tue, Aug 29, 2006 at 07:45:23AM -0400, John W. Linville wrote: > On Tue, Aug 29, 2006 at 09:30:57AM +0200, Johannes Berg wrote: > > I think that would warrant a new netlink multicast group and doing over > > nl80211 to start with ;) Inserting fake management frames into the mgt > > interface so

Re: [PATCH 4/6] net neighbour: convert to RCU

2006-08-29 Thread Stephen Hemminger
On Tue, 29 Aug 2006 19:28:16 +0400 Alexey Kuznetsov <[EMAIL PROTECTED]> wrote: > Hello! > > > @@ -346,8 +354,8 @@ struct neighbour *neigh_lookup(struct ne > > > > NEIGH_CACHE_STAT_INC(tbl, lookups); > > > > - read_lock_bh(&tbl->lock); > > - hlist_for_each_entry(n, tmp, &tbl->hash_b

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread Thomas Graf
* Olaf Kirch <[EMAIL PROTECTED]> 2006-08-29 10:24 > we had bug reports from people seeing lots of spurious messages > like the following: > > kernel: peth0: received packet with own address as source address. > > and > > xenbr0: duplicate address detected! > > This is on a Xen enabled machine,

Re: Fw: 2.6.18-rc4-mm3: BUG: warning at include/net/dst.h:154/dst_release()

2006-08-29 Thread Thomas Graf
* Andrew Morton <[EMAIL PROTECTED]> 2006-08-29 09:16 > > > Begin forwarded message: > > Date: Tue, 29 Aug 2006 10:25:07 -0400 > From: [EMAIL PROTECTED] > To: Andrew Morton <[EMAIL PROTECTED]> > Cc: linux-kernel@vger.kernel.org > Subject: 2.6.18-rc4-mm3: BUG: warning at include/net/dst.h:154/dst_

Re: [PATCH] Fix verify_iovec() to not allow overflow of iov_len values

2006-08-29 Thread Chris Wright
* Sridhar Samudrala ([EMAIL PROTECTED]) wrote: > -int verify_iovec(struct msghdr *m, struct iovec *iov, char *address, int > mode) > +ssize_t verify_iovec(struct msghdr *m, struct iovec *iov, char *address, int > mode) > { > int size, err, ct; > + ssize_t tot_len = 0; > >

Re: [PATCH 4/6] net neighbour: convert to RCU

2006-08-29 Thread Martin Josefsson
On Tue, 2006-08-29 at 11:22 -0700, Stephen Hemminger wrote: > > Probably, you should do atomic_inc_and_test() here and restart lookup, > > if it fails. > > > > Alexey > > atomic_inc_and_test is true iff result is zero, so that won't work. Wouldn't atomic_inc_not_zero() do what you want? -- /M

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-08-29 Thread Jouni Malinen
On Mon, Aug 28, 2006 at 02:17:34PM -0700, Michael Wu wrote: > It would be helpful if you inlined your patches instead of attaching them > next > time. Agreed. > I'm not comfortable with using the name for this purpose. And agreed. wireless.h has this to say about SIOCGIWNAME: #define SIOCGIW

[PATCH] Fix verify_iovec() to not allow overflow of iov_len values

2006-08-29 Thread Sridhar Samudrala
verify_iovec() has the following piece of code that allows overflow of iov_len values in an iovec. for (ct = 0; ct < m->msg_iovlen; ct++) { err += iov[ct].iov_len; /* * Goal is not to verify user data, but to prevent returning

Re: [PATCH 1/6] NetLabel: correctly initialize the NetLabel fields

2006-08-29 Thread Paul Moore
James Morris wrote: > On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: >>+void selinux_netlbl_sk_security_init(struct sk_security_struct *ssec, >>+ int family) >>+{ >>+if (family == PF_INET) > > No tab. I see you already ack'd this patch, should I resubmit w

Re: [PATCH 4/7] d80211: add support for SIOCSIWNICKN SIOCGIWNICKN

2006-08-29 Thread Jouni Malinen
On Tue, Aug 29, 2006 at 07:49:22AM -0400, John W. Linville wrote: > On Tue, Aug 29, 2006 at 09:49:17AM +0200, Johannes Berg wrote: > > I intend to kill the nick command with nl80211 since it seems to be > > useless. Any objections? > > I can't defend it myself, but I have heard of people using it.

Re: [PATCH 22/26] ixgb: Cache-align all TX components of the adapter struct.

2006-08-29 Thread Eric Dumazet
On Tuesday 29 August 2006 18:45, Kok, Auke wrote: > > /* TX */ > - struct ixgb_desc_ring tx_ring; > + struct ixgb_desc_ring tx_ring cacheline_aligned; > unsigned long timeo_start; On UP, this would only enlarge the size of structure and might consume more cache lines...

Re: [PATCH 6/6] NetLabel: add some missing #includes to various header files

2006-08-29 Thread James Morris
On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: > Add some missing include files to the NetLabel related header files. > > Signed-off-by: Paul Moore <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line

Re: [PATCH 3/6] NetLabel: comment corrections

2006-08-29 Thread James Morris
On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: > Fix some incorrect comments. > > Signed-off-by: Paul Moore <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a me

Re: [PATCH 5/6] NetLabel: uninline selinux_netlbl_inode_permission()

2006-08-29 Thread James Morris
On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: > Uninline the selinux_netlbl_inode_permission() at the request of Andrew > Morton. > > Signed-off-by: Paul Moore <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> These patches should likely go in via Dave's tree. -- James Morris

Re: [PATCH 01/26] e1000: Whitespace cleanup, cosmetic changes

2006-08-29 Thread Auke Kok
Patch 1/26 was truncated by vger, so I've posted them here in 4 separate parts: http://foo-projects.org/~sofar/e1000_00_whitespace.patch http://foo-projects.org/~sofar/e1000_01_whitespace.patch http://foo-projects.org/~sofar/e1000_02_whitespace.patch http://foo-projects.org/~sofar/e1000_03_white

Re: [PATCH 4/6] NetLabel: cleanup ebitmap_import()

2006-08-29 Thread James Morris
On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: > Rewrite ebitmap_import() so it is a bit cleaner and easier to read. > > Signed-off-by: Paul Moore <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "

Re: [PATCH 2/6] NetLabel: remove unused function prototypes

2006-08-29 Thread James Morris
On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: > Removed some older function prototypes for functions that no longer exist. > > Signed-off-by: Paul Moore <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the

Re: [PATCH 1/6] NetLabel: correctly initialize the NetLabel fields

2006-08-29 Thread James Morris
On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: > +void selinux_netlbl_sk_security_init(struct sk_security_struct *ssec, > + int family) > +{ > +if (family == PF_INET) No tab. > + ssec->nlbl_state = NLBL_REQUIRE; > + else > + sse

Re: [PATCH 1/6] NetLabel: correctly initialize the NetLabel fields

2006-08-29 Thread James Morris
On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: > Fix a problem where the NetLabel specific fields of the sk_security_struct > structure were not being initialized early enough in some cases. > > Signed-off-by: Paul Moore <[EMAIL PROTECTED]> Regardless of the mapped ipv6 socket issue, I think thes

  1   2   >