On Tue, 29 Aug 2006, Paul Moore wrote: > James Morris wrote: > > On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: > >>+void selinux_netlbl_sk_security_init(struct sk_security_struct *ssec, > >>+ int family) > >>+{ > >>+ if (family == PF_INET) > > > > No tab. > > I see you already ack'd this patch, should I resubmit with the tab > correction or just leave it alone?
Probably easiest to fix it as it's applied. > Example case: > > 1. Configure NetLabel so that packets are labeled with CIPSO > 2. Ensure SSH is listening for both IPv4 and IPv6 connections and > restart the daemon > 3. Connect to the SSH daemon using IPv4 > > I haven't looked at the sshd code enough in detail to see what it is > doing exactly but simply running 'netstat -nl' shows that sshd is > listening for connections with an IPv6 socket (at least it is listening > on port ':::22'). Once the connection is established the daemon > continues to use an IPv6 socket, '::ffff:127.0.0.1:22', whereas the > client uses a traditional IPv4 socket. Sniffing the connection > indicates that both directions of network traffic are labeled with the > correct CIPSO tags. IIRC, the way I originally tested this was to write a simple app. I wonder if something has changed in the networking code which means we don't need to test for this now. > On the outbound side, yes, we only NetLabel sockets which are PF_INET > but I didn't think I could set an IPv4 option on a PF_INET6 socket can > I? It just sounds wrong ... If it's carrying IPv4 traffic, it may make sense in some cases. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html