Re: [PATCH] Make struct in_addr::s_addr __be32

2006-08-28 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Mon, 21 Aug 2006 03:20:51 +0400 > There will be relatively small increase in sparse endian warnings, but > this (and sin_port) patch is a first step to make networking code endian > clean. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Appl

Re: [PATCH] Make struct sockaddr_in::sin_port __be16

2006-08-28 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Mon, 21 Aug 2006 03:21:24 +0400 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Also applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [2.6 patch] net/atm/: proper prototypes

2006-08-28 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Mon, 21 Aug 2006 01:00:06 +0200 > This patch adds proper prototypes in net/atm/mpc.h for two global > functions in net/atm/mpoa_proc.c > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Applied to net-2.6.19, thanks Adrian. - To unsubscribe from this

Re: divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3]

2006-08-28 Thread Mattia Dongili
On Mon, August 28, 2006 11:30 pm, Andrew Morton said: > On Mon, 28 Aug 2006 22:07:16 +0200 > Mattia Dongili <[EMAIL PROTECTED]> wrote: [...] >> it's at fib6_rules.c:132 but since I can't tell why r->fwmask is 0 I'll >> avoid proposing a wrong patch :) > > Oh. It looks like this has already been fi

Re: myri10ge conversion to non-contiguous skb

2006-08-28 Thread Brice Goglin
Jesse Brandeburg wrote: > On 8/24/06, Brice Goglin <[EMAIL PROTECTED]> wrote: >> During the submission of the myri10ge driver, some people raised the >> question of using pages (or any kind of non-contiguous skb) instead of >> our current 16kB contiguous skb. We are looking at this right now and it

[PATCH -net-2.6.19] net/*: don't panic

2006-08-28 Thread Alexey Dobriyan
IPv6 can be modular and panicking on module loading is the last thing you want. Two SLAB_PANIC cases converted to error propagating as well as one panic() call. Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- I recall release is near, so error handling continues to suck. It needs big re

[PATCH]ethtool.c:fix buffer overflow when devname it too long

2006-08-28 Thread Zhao Yu Wang
As the length of field ifr_name of struct ifreq is IFNAMSIZ(16) in header file /usr/include/net/if.h. It will result in buffer overflow when devname is too long. I modified strcpy to strncpy for only copying IFNAMSIZ bytes into struct ifreq. Also, by adding a section into parse_cmdline to detect

Re: [PATCH] net/*: use SLAB_PANIC

2006-08-28 Thread Alexey Dobriyan
On Mon, Aug 28, 2006 at 01:36:37PM -0700, David Miller wrote: > > ipv6 can be modular, so panicing on a initialization failure is wrong. > > That may be the case, but he merely translated the code > as it existed, he didn't change it to start panic()'ing > it already did. > > It would be a seperate

Re: IPSec kernel oops on ppc64

2006-08-28 Thread Herbert Xu
On Mon, Aug 28, 2006 at 05:25:15PM -0500, Joy Latten wrote: > > A straight 2.6.17 kernel does not crash and my pings work. > A 2.6.17 + patch-2.6.18-rc4 does crash and my pings do not work. > The above tests were done on a ppc64. Thanks for that info. This does sound like a bug. Could you plea

Re: [PATCH v4 7/7] AMSO1100 Makefiles and Kconfig changes.

2006-08-28 Thread Steve Wise
Sounds good to me. - Original Message - From: "Roland Dreier" <[EMAIL PROTECTED]> To: "Steve Wise" <[EMAIL PROTECTED]> Cc: ; Sent: Monday, August 28, 2006 6:07 PM Subject: Re: [PATCH v4 7/7] AMSO1100 Makefiles and Kconfig changes. I'm finally getting around to merging this up, and:

Re: [PATCH 1/4] net: VM deadlock avoidance framework

2006-08-28 Thread Indan Zupancic
On Mon, August 28, 2006 19:32, Peter Zijlstra said: > Also, I'm really past caring what the thing > is called ;-) But if ppl object I guess its easy enough to run yet > another sed command over the patches. True, same here. >> >> You can get rid of the memalloc_reserve and vmio_request_queues var

Re: [PATCH] pcnet32: fix user visible typo

2006-08-28 Thread Don Fry
The cause of #6428 has already been fixed in v1.32 of the pcnet32 driver. To be correct, the printk should be: printk(KERN_INFO PFX "%d card%s found\n", cards_found, cards_found != 1 ? "s" : ""); So that zero cards also says 'pcnet32: 0 cards found.' Why d

Re: IPSec kernel oops on ppc64

2006-08-28 Thread David Miller
From: Joy Latten <[EMAIL PROTECTED]> Date: Mon, 28 Aug 2006 17:25:15 -0500 > I can try patch-2.6.18-rc1, etc... to see which one it stops > working on to narrow it down. If you could do this in the meanwhile, it would help us out a lot. Thanks. - To unsubscribe from this list: send the line "uns

[PATCH 1/5] skge: cleanup suspend/resume code

2006-08-28 Thread Stephen Hemminger
The code for suspend/resume needs several fixes. The hardware lock should be setup in probe only, not in resume. Interrupts should be disabled during suspend, etc. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -3106,7

[PATCH] pcnet32: fix user visible typo

2006-08-28 Thread Alexey Dobriyan
Also, final dot removed and single form fixed. The cause of #6428 is still to be found. Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- drivers/net/pcnet32.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/pcnet32.c +++ b/drivers/net/pcnet32.c @@ -2986,7 +298

[PATCH 5/5] skge: version 1.7

2006-08-28 Thread Stephen Hemminger
Increase version. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -43,7 +43,7 @@ #include "skge.h" #define DRV_NAME "skge" -#define DRV_VERSION"1.6" +#define DRV_VERSION"1.7" #d

[PATCH 2/5] skge: pci bus post fixes

2006-08-28 Thread Stephen Hemminger
At the end of a critical section, we need to force the PCI write to complete by doing a read. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -2747,7 +2747,7 @@ static int skge_poll(struct net_device * spin_lock_

[PATCH 4/5] skge: use ethX for irq assigments

2006-08-28 Thread Stephen Hemminger
The user level irq balance daemon uses "eth" as a way to distinquish ethernet devices. Also, by using device name it is possible to distinquish different boards. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -3343,23 +

[PATCH 3/5] skge: use dev_alloc_skb

2006-08-28 Thread Stephen Hemminger
To avoid problems with buggy protocols that assume extra header space, use dev_alloc_skb() when allocating receive buffers. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -827,7 +827,8 @@ static int skge_rx_fill(struct

[PATCH 0/5] skge update

2006-08-28 Thread Stephen Hemminger
Several non-critical bug fixes for skge driver. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/6] net neighbor: convert top level list to RCU

2006-08-28 Thread Stephen Hemminger
Change the top level list of neighbor tables to use RCU. Minor change to BUG() if a neighbor table is registered twice. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- include/net/neighbour.h |2 - net/core/neighbour.c| 89 ++-- 2 fi

[PATCH 0/6] Lockless neighbour table

2006-08-28 Thread Stephen Hemminger
This is an updated version of the changes to make the neighbour (ARP) table lockless for normal accesses. It uses RCU and seqlock in several places. I separated the hlist conversions from RCU changes (in case we need to bisect for some reason). -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsu

[PATCH 3/6] neighbour: convert pneigh hash table to hlist

2006-08-28 Thread Stephen Hemminger
Change the pneigh_entry table to hlist from list.h to allow for easier later conversion to RCU. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- include/net/neighbour.h |6 ++-- net/core/neighbour.c| 58 2 files changed, 33 inser

[PATCH 4/6] net neighbour: convert to RCU

2006-08-28 Thread Stephen Hemminger
Use RCU to allow for lock less access to the neighbour table. This should speedup the send path because no atomic operations will be needed to lookup ARP entries, etc. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- include/net/neighbour.h |4 - net/core/neighbour.c| 158 +

[PATCH 2/6] neighbour: convert neighbour hash table to hlist

2006-08-28 Thread Stephen Hemminger
Change the neighbour table hash list to hlist from list.h to allow for easier later conversion to RCU. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- include/net/neighbour.h |6 - net/core/neighbour.c| 160 +--- 2 files changed, 88 i

[PATCH 6/6] neighbour: convert hard header cache to sequence number

2006-08-28 Thread Stephen Hemminger
The reading of the hard header cache in the output path can be made lockless using seqlock. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- include/linux/netdevice.h |3 ++- include/net/neighbour.h |2 ++ net/core/neighbour.c | 40 +++

[PATCH 5/6] neighbour: convert lookup to sequence lock

2006-08-28 Thread Stephen Hemminger
The reading of neighbour table entries can be converted from a slow reader/writer lock to a fast lockless sequence number check. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- include/net/neighbour.h |2 net/core/neighbour.c| 117 +

Re: [PATCH v4 7/7] AMSO1100 Makefiles and Kconfig changes.

2006-08-28 Thread Roland Dreier
I'm finally getting around to merging this up, and: > --- /dev/null > +++ b/drivers/infiniband/hw/amso1100/README > @@ -0,0 +1,11 @@ > +This is the OpenFabrics provider driver for the > +AMSO1100 1Gb RNIC adapter. > + > +This adapter is available in limited quantities > +for development

Re: IPSec kernel oops on ppc64

2006-08-28 Thread Joy Latten
>Joy Latten <[EMAIL PROTECTED]> wrote: >> I installed 2.6.17 + patch-2.6.18-rc4 + 2.6.18-rc4-mm2 >> onto two pSeries power 5 (ppc64 lpars) machines. I configured >> IPSec using the configuration listed below. > >Could you try straight 2.6.17? If that crashes too, then at least we >can be sure that

Re: e1000 and 802.1ad/stacked vlan tagging

2006-08-28 Thread Ben Greear
Stephan von Krawczynski wrote: Hello Jesse, thank you for answering anyway. Though I think your answer covers only the obvious half of the problem. Indeed one might think that this solves the issue - as long as there are only linux kernels involved. Unfortunately my setup is a bit more complicat

Re: divide error: 0000 in fib6_rule_match

2006-08-28 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Mon, 28 Aug 2006 14:30:03 -0700 > Oh. It looks like this has already been fixed: > > #ifdef CONFIG_IPV6_ROUTE_FWMARK > if ((r->fwmark ^ fl->fl6_fwmark) & r->fwmask) > return 0; > #endif > > there's no divide in there now. Th

Re: divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3]

2006-08-28 Thread Andrew Morton
On Mon, 28 Aug 2006 22:07:16 +0200 Mattia Dongili <[EMAIL PROTECTED]> wrote: > [ 44.412000] === > [ 44.412000] Code: 00 00 00 89 d8 83 e0 1f 0f 85 9a 00 00 00 8b 5d 08 0f b6 > 53 68 84 d2 75 78 8b 55 08 8b 5d 0c 8b 4a 60 8b 43 28 31 c8 89 d1 31 d2 > 71 64 85 c0 0f 94 c0

Re: divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3]

2006-08-28 Thread Andi Kleen
> I cannot work out how the heck you got a divide instruction in > fib6_rule_match(). This might be another symptom of the broken smp-alternatives patch. It tended to randomly corrupt some instructions by inserting different bytes which then crash in interesting ways. I already sent a fix for th

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-08-28 Thread Michael Wu
It would be helpful if you inlined your patches instead of attaching them next time. I'm not comfortable with using the name for this purpose. Don't we just report 00:00:00:00:00:00 when not associated? Also, for radio off, wasn't that being covered by the rfkill patches? -Michael Wu pgpSscK

[PATCH 7/7] d80211: getting wrong freq value if we did hardware scan

2006-08-28 Thread mabbas
In this patch we search all A-BAND available channels to get the right frequency value. this might not be the right thing to do in beacon parsing. Another approach is to have a static array of the maximum A-BAND channel number then we can map from channel to frequency fast. we can set the va

Re: [PATCH 1/1][SCTP]: Fix sctp_primitive_ABORT() call in sctp_close()

2006-08-28 Thread David Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Mon, 28 Aug 2006 12:11:36 -0700 > The recent SCTP CVE fix that went into 2.6.18 changed > sctp_primitive_ABORT() callers to create an ABORT chunk > and pass it as an arg instead of struct msghdr. > While submitting this fix, i missed the other loc

[PATCH 4/7] d80211: add support for SIOCSIWNICKN SIOCGIWNICKN

2006-08-28 Thread mabbas
This patch modify d80211 to add nick wireless command Signed-off-by: Mohamed Abbas <[EMAIL PROTECTED]> diff --git a/net/d80211/ieee80211_i.h b/net/d80211/ieee80211_i.h index 0d2d79d..02242c6 100644 --- a/net/d80211/ieee80211_i.h +++ b/net/d80211/ieee80211_i.h @@ -241,6 +241,7 @@ struct ieee80

RE: e1000 and 802.1ad/stacked vlan tagging

2006-08-28 Thread Brandeburg, Jesse
Stephan von Krawczynski wrote: > thank you for answering anyway. Though I think your answer covers > only the obvious half of the problem. > Indeed one might think that this solves the issue - as long as there > are only linux kernels involved. Unfortunately my setup is a bit more > complicated in

[PATCH 6/7] d80211: diplay supported rates in readable format

2006-08-28 Thread mabbas
This patch modify d80211 to report supported rates in readable format in iwlist scan command. Signed-off-by: Mohamed Abbas <[EMAIL PROTECTED]> diff --git a/net/d80211/ieee80211_sta.c b/net/d80211/ieee80211_sta.c index a933d92..b2e45a4 100644 --- a/net/d80211/ieee80211_sta.c +++ b/net/d80211/iee

[PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-08-28 Thread mabbas
This patch indicate unassociated and radio off status in name field Signed-off-by: Mohamed Abbas <[EMAIL PROTECTED]> diff --git a/net/d80211/ieee80211_ioctl.c b/net/d80211/ieee80211_ioctl.c index 89a58e3..44b2698 100644 --- a/net/d80211/ieee80211_ioctl.c +++ b/net/d80211/ieee80211_ioctl.c @@ -

[PATCH 1/7] d80211: add SIOCSIWTXPOW, SIOCGIWTXPOW, SIOCSIWPOWER and SIOCGIWPOWER

2006-08-28 Thread mabbas
This patch modify d80211 to add SIOCSIWTXPOW, SIOCGIWTXPOW, SIOCSIWPOWER and SIOCGIWPOWER. This is not a complete soluation but add the hook for them. Signed-off-by: Mohamed Abbas <[EMAIL PROTECTED]> diff --git a/include/net/d80211.h b/include/net/d80211.h index 42fdbf7..bc5eb87 100644 --- a/i

[PATCH 2/7] d80211: add support for SIOCSIWRATE and SIOCGIWRATE

2006-08-28 Thread mabbas
This patch modify d80211 to add SIOCSIWRATE and SIOCGIWRATE commands. this patch almost does the same thing as in PRISM2_HOSTAPD_SET_RATE_SETS. Signed-off-by: Mohamed Abbas <[EMAIL PROTECTED]> diff --git a/net/d80211/ieee80211.c b/net/d80211/ieee80211.c index e72721f..26ed68c 100644 --- a/ne

[PATCH 3/7] d80211: report supported rates and channels in SIOCGIWRANGE

2006-08-28 Thread mabbas
This patch modify d80211 to report more information like supported rate and channel in SIOCGIWRANGE command. Signed-off-by: Mohamed Abbas <[EMAIL PROTECTED]> diff --git a/net/d80211/ieee80211_ioctl.c b/net/d80211/ieee80211_ioctl.c index 89a58e3..3d8156c 100644 --- a/net/d80211/ieee80211_ioctl

[PATCH 0/7] d80211: support more wireless command

2006-08-28 Thread mabbas
the following patches are based on earlier patched. I did separate each set of command into its own patch with enhanced based on you comments. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kern

Re: [PATCH] net/*: use SLAB_PANIC

2006-08-28 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Mon, 28 Aug 2006 10:36:51 +0100 > ipv6 can be modular, so panicing on a initialization failure is wrong. That may be the case, but he merely translated the code as it existed, he didn't change it to start panic()'ing it already did. It would be a

Re: 2.6.18-rc4-mm[1,2,3] -- Network card not getting assigned an "eth" device name

2006-08-28 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Mon, 28 Aug 2006 12:03:28 -0700 > grepping for `ioctl' gives: > > ioctl(9, SIOCGIWNAME, 0xbfe38d8c) = -1 EINVAL (Invalid > argument) > ioctl(9, SIOCETHTOOL, 0xbfe38d2c) = 0 > ioctl(11, SIOCGIFHWADDR, {ifr_name="eth0",

Re: divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3]

2006-08-28 Thread Andrew Morton
On Mon, 28 Aug 2006 22:07:16 +0200 Mattia Dongili <[EMAIL PROTECTED]> wrote: > On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote: > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc4/2.6.18-rc4-mm3/ > [...] > > git-net.patch > > got this one when starting

Re: [PATCH] [IPV6] ROUTE: Fix dst refcounting.

2006-08-28 Thread David Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Tue, 29 Aug 2006 01:46:49 +0900 (JST) > [IPV6] ROUTE: Fix dst reference counting in ip6_pol_route_lookup(). > > In ip6_pol_route_lookup(), when we finish backtracking at the > top-level root entry, we need to hold it. > > Bug noticed by Mitsuru C

Re: [PATCH 5/10] rt2x00: Register initialization fixes

2006-08-28 Thread Ivo van Doorn
On Monday 28 August 2006 18:08, John W. Linville wrote: > On Sun, Aug 27, 2006 at 05:39:14PM +0200, Ivo van Doorn wrote: > > Various register initialization fixes to make the device work properly. > > This will fix the RX/TX issue for rt61pci. > > > > Signed-off-by Ivo van Doorn <[EMAIL PROTECTED]

divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3]

2006-08-28 Thread Mattia Dongili
On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc4/2.6.18-rc4-mm3/ [...] > git-net.patch got this one when starting sshd: [ 44.412000] divide error: [#1] [ 44.412000] 4K_STACKS PREEMPT [ 44.4120

[PATCH 1/1][SCTP]: Fix sctp_primitive_ABORT() call in sctp_close()

2006-08-28 Thread Sridhar Samudrala
Dave, The recent SCTP CVE fix that went into 2.6.18 changed sctp_primitive_ABORT() callers to create an ABORT chunk and pass it as an arg instead of struct msghdr. While submitting this fix, i missed the other location in sctp_close() where this is called. Please apply this patch to 2.6.18 and i

Re: 2.6.18-rc4-mm[1,2,3] -- Network card not getting assigned an "eth" device name

2006-08-28 Thread Andrew Morton
On Mon, 28 Aug 2006 08:52:02 -0700 "Miles Lane" <[EMAIL PROTECTED]> wrote: > On 8/27/06, David Miller <[EMAIL PROTECTED]> wrote: > > From: Andrew Morton <[EMAIL PROTECTED]> > > Date: Sun, 27 Aug 2006 00:19:43 -0700 > > > > > Jeremy reported that a while back too. I do not know what is causing it

Re: [patch 5/5] d80211: add ioctl to stop data frame tx

2006-08-28 Thread Elliot Schwartz
Hi Johannes, Johannes Berg <[EMAIL PROTECTED]> writes: > On Tue, 2006-08-22 at 10:34 -0700, David Kimdon wrote: > > This ioctl is used when radar is delected on a channel. Data > > frames must stop but management frames must be allowed to continue > > for some time to communicate the channel swi

Re: [patch 5/5] d80211: add ioctl to stop data frame tx

2006-08-28 Thread Elliot Schwartz
Hi Jiri (and Johannes), Jiri Benc <[EMAIL PROTECTED]> writes: > On Wed, 23 Aug 2006 09:25:06 +0200, Johannes Berg wrote: > > Should that really drop dataframes dead on the floor? And wouldn't it > > make sense stop the networking layer from injecting more data into the > > stack when stop_data_fr

Re: [RFC][PATCHv2 2.6.18-rc4-mm3 3/3] net/ipv4: misc. support files

2006-08-28 Thread Patrick McHardy
[EMAIL PROTECTED] wrote: > [Net/IPv4]: REVISED Miscellaneous changes which complete the > v4 support for UDP-Lite. > > --- a/include/net/xfrm.h > +++ b/include/net/xfrm.h > @@ -467,6 +467,7 @@ u16 xfrm_flowi_sport(struct flowi *fl) > switch(fl->proto) { > case IPPROTO_TCP

[PATCH 5/9] sky2: TSO mss optimization

2006-08-28 Thread shemminger
The MSS in the transmit engine only has to change if TSO mtu changes. This means less commands to the chip when mixing TSO and regular data. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-08-28 10:00:07.0 -0700 +++ sky2/drivers/net/sky2.c

[PATCH 7/9] sky2: power down PHY when not up

2006-08-28 Thread shemminger
To save power, don't enable power to the PHY until device is brought up. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-08-28 10:00:13.0 -0700 +++ sky2/drivers/net/sky2.c 2006-08-28 10:00:17.0 -0700 @@ -195,7 +195,6 @@ static

[PATCH 2/9] sky2: use netdev_alloc_skb

2006-08-28 Thread shemminger
Use netdev_alloc_skb for buffer allocation to allow for headroom. This prevents bugs in code paths that assume extra space at the front and makes sky2 behave like other drivers. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-08-25 16:01:33.00

[RFC][PATCHv2 2.6.18-rc4-mm3 3/3] net/ipv4: misc. support files

2006-08-28 Thread gerrit
[Net/IPv4]: REVISED Miscellaneous changes which complete the v4 support for UDP-Lite. Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]> --- include/linux/in.h |1 + include/linux/socket.h |1 + include/net/snmp.h |2 ++ include/net/xfrm.h |2 ++ net/ipv4/

[PATCH 0/9] sky2 1.7 non-critical bug fixes

2006-08-28 Thread shemminger
These are a set of non-critical fixes to the sky2 driver. 1. cloned skb tso bug fix 2. netdev_alloc_skb 3. don't use force status on transmit 4. MSI pci posting bug 5. TSO segment size optimization 6. checksum offload optimization 7. power up PHY only on network open 8. pci post bug

[PATCH 4/9] sky2: MSI test timing

2006-08-28 Thread shemminger
The test for MSI IRQ could have timing issues. The PCI write needs to be pushed out before waiting, and the wait queue should be initialized before the IRQ. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-08-25 16:05:10.0 -0700 +++ sky2/d

[PATCH 6/9] sky2: optimize checksum offload information

2006-08-28 Thread shemminger
Since many packets have the same checksum starting offset and insertion location; the driver can save the last information and only tell hardware when it changes. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-08-28 10:00:08.0 -0700 +++ s

[PATCH 3/9] sky2: dont use force status bit

2006-08-28 Thread shemminger
Don't use force status bit. It was never implemented on all chips, or has no impact. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-08-25 16:02:27.0 -0700 +++ sky2/drivers/net/sky2.c 2006-08-25 16:05:10.0 -0700 @@ -1192,7 +119

[PATCH]: Add to MAINTAINERS file

2006-08-28 Thread Jim Lewis
This patch adds Jim Lewis to the MAINTAINERS file for the Spidernet network driver. Signed-off-by: James K Lewis <[EMAIL PROTECTED]> --- MAINTAINERS |6 ++ 1 file changed, 6 insertions(+) Index: linux-2.6.18-rc2/MAINTAINERS =

[PATCH 1/9] sky2: remove cloned/pskb_expand_head check

2006-08-28 Thread shemminger
The code to handle cloned skb overwriting is unnecessary in the sky2 driver and is buggy. The bug is that pskb_expand_head can change the skb but the driver has already mapped in the header. Since the sky2 hardware doesn't need to overwrite memory, the buggy code can just be removed; it was mistak

[PATCH 9/9] sky2: version 1.7

2006-08-28 Thread shemminger
Change version number for this bundle. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-08-22 14:55:42.0 -0700 +++ sky2/drivers/net/sky2.c 2006-08-22 14:55:46.0 -0700 @@ -50,7 +50,7 @@ #include "sky2.h" #define DRV_NAME

[PATCH 8/9] sky2: pci post bug

2006-08-28 Thread shemminger
Make sure that PCI write occurs before the delay. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-08-28 10:00:17.0 -0700 +++ sky2/drivers/net/sky2.c 2006-08-28 10:00:20.0 -0700 @@ -531,6 +531,7 @@ reg1 |= phy_p

[RFC][PATCHv2 2.6.18-rc4-mm3 1/3] net/ipv4: UDP-Lite extensions

2006-08-28 Thread gerrit
[Net/IPv4]: REVISED UDP-Lite standalone support and shared UDP/-Lite socket structure. This is in principle the same patch as posted earlier, with the difference that all whitespace changes have been removed; in addition, statements have been re-ordered so as to give a better-readable patch. S

[RFC][PATCHv2 2.6.18-rc4-mm3 2/3] net/ipv4: UDP and generic UDP(-Lite) processing

2006-08-28 Thread gerrit
[Net/IPv4]: REVISED Modifications to the UDP module and generic UDP/-Lite processing. Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]> --- include/net/udp.h | 68 ++- net/ipv4/udp.c| 489 -- 2 files changed, 395 insertions(+), 162 d

Re: e1000 and 802.1ad/stacked vlan tagging

2006-08-28 Thread Stephan von Krawczynski
Hello Jesse, thank you for answering anyway. Though I think your answer covers only the obvious half of the problem. Indeed one might think that this solves the issue - as long as there are only linux kernels involved. Unfortunately my setup is a bit more complicated in terms of hardware. So I sho

Re: [PATCH 1/4] net: VM deadlock avoidance framework

2006-08-28 Thread Peter Zijlstra
On Mon, 2006-08-28 at 18:03 +0200, Indan Zupancic wrote: > On Mon, August 28, 2006 12:22, Peter Zijlstra said: > >> > @@ -391,6 +391,7 @@ enum sock_flags { > >> > SOCK_RCVTSTAMP, /* %SO_TIMESTAMP setting */ > >> > SOCK_LOCALROUTE, /* route locally only, %SO_DONTROUTE setting */ >

[PATCH] [IPV6] ROUTE: Fix dst refcounting.

2006-08-28 Thread YOSHIFUJI Hideaki / 吉藤英明
[IPV6] ROUTE: Fix dst reference counting in ip6_pol_route_lookup(). In ip6_pol_route_lookup(), when we finish backtracking at the top-level root entry, we need to hold it. Bug noticed by Mitsuru Chinen <[EMAIL PROTECTED]>. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- diff --git a/n

Re: [PATCH 5/10] rt2x00: Register initialization fixes

2006-08-28 Thread John W. Linville
On Sun, Aug 27, 2006 at 05:39:14PM +0200, Ivo van Doorn wrote: > Various register initialization fixes to make the device work properly. > This will fix the RX/TX issue for rt61pci. > > Signed-off-by Ivo van Doorn <[EMAIL PROTECTED]> > > --- > > diff -rU3 > wireless-dev-rt2x00-interface/drivers

Re: [PATCH 1/4] net: VM deadlock avoidance framework

2006-08-28 Thread Indan Zupancic
On Mon, August 28, 2006 12:22, Peter Zijlstra said: > On Sat, 2006-08-26 at 04:37 +0200, Indan Zupancic wrote: >> Why not 'emergency'? Looks like 'emerge' with a typo now. ;-) > > hehe, me lazy, you gentoo ;-) > sed -i -e 's/emerg/emregency/g' -e 's/EMERG/EMERGENCY/g' *.patch I used it for a while

Re: 2.6.18-rc4-mm[1,2,3] -- Network card not getting assigned an "eth" device name

2006-08-28 Thread Miles Lane
On 8/27/06, David Miller <[EMAIL PROTECTED]> wrote: From: Andrew Morton <[EMAIL PROTECTED]> Date: Sun, 27 Aug 2006 00:19:43 -0700 > Jeremy reported that a while back too. I do not know what is causing it > and as far as I know no net developers have yet looked into it. A debugging patch like t

Re: 2.6.18-rc4-mm[1,2,3] -- Network card not getting assigned an "eth" device name

2006-08-28 Thread Benoit Boissinot
On 8/27/06, Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: Andrew Morton wrote: > Jeremy reported that a while back too. I do not know what is causing it > and as far as I know no net developers have yet looked into it. > It went away with -rc4-mm[23] for me... I just reproduced it with rc4-m

Re: [RFC][PATCH 0/3] net: a lighter UDP-Lite (RFC 3828)

2006-08-28 Thread Arnaldo Carvalho de Melo
On 8/28/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Quoting Arnaldo Carvalho de Melo: | Avoid these changes to reduce patch file size, please I apologize for the bad patch format - I am revising the entire patch to improve readability and will resend. No need for apologies and thanks for

Re: e1000: operation without eeprom?

2006-08-28 Thread Brent Cook
On Sunday 27 August 2006 19:50, Lennert Buytenhek wrote: > Hi, > > There are a couple of ARM boards out there with on-board e1000s but > without any kind of eeprom. The boot loader and kernel board support > code have all the info necessary to configure the e1000, but the e1000 > driver bombs out

Re: [RFC][PATCH 0/3] net: a lighter UDP-Lite (RFC 3828)

2006-08-28 Thread gerrit
Quoting Arnaldo Carvalho de Melo: | Avoid these changes to reduce patch file size, please I apologize for the bad patch format - I am revising the entire patch to improve readability and will resend. - Gerrit - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a me

Re: [RFC][PATCH 0/3] net: a lighter UDP-Lite (RFC 3828)

2006-08-28 Thread Arnaldo Carvalho de Melo
On 8/28/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: [NET/IPv4]: update for udp.c only, to match 2.6.18-rc4-mm3 This is an update only, as the previous patch can not cope with recent changes to udp.c (all other files remain the same). Up-to-date, complete patches can always be taken from ht

Re: [take14 0/3] kevent: Generic event handling mechanism.

2006-08-28 Thread Jari Sundell
On 8/28/06, Nicholas Miell <[EMAIL PROTECTED]> wrote: Also complicated is the case where waiting threads have different priorities, different timeouts, and different minimum event counts -- how do you decide which thread gets events first? What if the decisions are different depending on whether

Re: [RFC][PATCH 0/3] net: a lighter UDP-Lite (RFC 3828)

2006-08-28 Thread gerrit
[NET/IPv4]: update for udp.c only, to match 2.6.18-rc4-mm3 This is an update only, as the previous patch can not cope with recent changes to udp.c (all other files remain the same). Up-to-date, complete patches can always be taken from http://www.erg.abdn.ac.uk/users/gerrit/udp-lite/files/udplit

Re: [PATCH 1/4] net: VM deadlock avoidance framework

2006-08-28 Thread Peter Zijlstra
On Sat, 2006-08-26 at 04:37 +0200, Indan Zupancic wrote: > On Fri, August 25, 2006 17:39, Peter Zijlstra said: > > @@ -282,7 +282,8 @@ struct sk_buff { > > nfctinfo:3; > > __u8pkt_type:3, > > fclone:2, > > -

Re: [PATCH 2.6.17 2/9] NetXen: Hardware access routines

2006-08-28 Thread Amit S. Kale
On Monday 21 August 2006 19:33, Stephen Hemminger wrote: > On Mon, 21 Aug 2006 13:57:23 +0530 > > "Amit S. Kale" <[EMAIL PROTECTED]> wrote: > > We can certainly create a table for all error messages. It'll hurt > > readability of code in many of the other places where printks are used to > > indica

Re: [PATCH] net/*: use SLAB_PANIC

2006-08-28 Thread Christoph Hellwig
On Sun, Aug 27, 2006 at 03:08:41AM +0400, Alexey Dobriyan wrote: > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> > --- > > Forgive me reformatting, in some cases making it fit in 80 columns was hard. > > net/core/flow.c|6 +- > net/core/neighbour.c | 12 >

[PATCH]d80211: fix "iwconfig key [x]" behavior

2006-08-28 Thread Hong Liu
"iwconfig key [x]" behavior is not correctly handled in the stack, also modify the giwencode method to show the key info. Thanks, Hong [PATCH]d80211: fix "iwconfig key [x]" behavior Signed-off-by: Hong Liu <[EMAIL PROTECTED]> diff --git a/net/d80211/ieee80211_ioctl.c b/net/d80211/ieee80211_ioctl