[patch 1/2] e100 disable device on PCI error

2006-08-14 Thread akpm
From: Linas Vepstas <[EMAIL PROTECTED]> A recent patch in -mm3 titled "gregkh-pci-pci-don-t-enable-device-if-already-enabled.patch" causes pci_enable_device() to be a no-op if the kernel thinks that the device is already enabled. This change breaks the PCI error recovery mechanism in the e100 dev

[patch 2/2] e1000 disable device on PCI error

2006-08-14 Thread akpm
From: Linas Vepstas <[EMAIL PROTECTED]> A recent patch in -mm3 titled "gregkh-pci-pci-don-t-enable-device-if-already-enabled.patch" causes pci_enable_device() to be a no-op if the kernel thinks that the device is already enabled. This change breaks the PCI error recovery mechanism in the e1000 de

[patch 40/41] FS_ENET: use PAL for mii management

2006-08-14 Thread akpm
From: Vitaly Bordug <[EMAIL PROTECTED]> This patch should update the fs_enet infrastructure to utilize Phy Abstraction Layer subsystem. Along with the above, there are apparent bugfixes, overhaul and improvements. Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EM

[patch 30/41] via-rhine: NAPI support

2006-08-14 Thread akpm
From: Roger Luethi <[EMAIL PROTECTED]> Add NAPI support to the via-rhine driver so that it can handle higher speeds and doesn't get overloaded by interrupts as easily. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Roger Luethi <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton

[patch 38/41] xircom_cb: wire up errors from pci_register_driver()

2006-08-14 Thread akpm
From: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Dominik Brodowski <[EMAIL PROTECTED]> Cc: Valerie Henson <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/tulip/xircom_cb.c |

[patch 35/41] Add ethtool -g support to Spidernet network driver

2006-08-14 Thread akpm
From: Jim Lewis <[EMAIL PROTECTED]> Add ethtool -g (show ring sizes) support to the Spidernet network driver. Signed-off-by: James K Lewis <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/spider_net.c | 12 +++- drivers/net/spider_net.h

[patch 32/41] lockdep: fix smc91x

2006-08-14 Thread akpm
From: Russell King <[EMAIL PROTECTED]> When booting using root-nfs, I'm seeing (independently) two lockdep dumps in the smc91x driver. The patch below fixes both. Both dumps look like real locking issues. Nico - please review and ack if you think the patch is correct. Dump 1: Sending DHCP req

[patch 13/13] net/ipv6/ip6_fib.c: make code static

2006-08-14 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> Make the following needlessly global code static: - fib6_walker_lock - struct fib6_walker_list - fib6_walk_continue() - fib6_walk() Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- include/net/ip6_fib.h |

[patch 12/13] net/decnet/: cleanups

2006-08-14 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> - make the following needlessly global functions static: - dn_fib.c: dn_fib_sync_down() - dn_fib.c: dn_fib_sync_up() - dn_rules.c: dn_fib_rule_action() - remove the following unneeded prototype: - dn_fib.c: dn_cache_dump() Signed-off-by: Adrian Bunk <

[patch 07/13] security/selinux/hooks.c: make 4 functions static

2006-08-14 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> This patch makes four needlessly global functions static. (akpm: applicable to the selinux updates in net-2.6.19.git) Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> Cc: "David S. Miller" <[EMAIL PROTECTED]> Signed-o

[patch 11/13] constify Tigon3 ether firmware structs

2006-08-14 Thread akpm
From: Andreas Mohr <[EMAIL PROTECTED]> Constify largish areas of firmware data in Tigon3 ethernet driver. non-const: lsmod: tg3 101404 0 objdump -x: .rodata 03e8 .data 4a0c ls -l: -rw-r--r-- 1 root root 114404 2006-08-19 21:36 drivers/net/tg3.ko const: lsmod: tg3

[patch 04/13] IRDA: Replace hard-coded dev_self[] array sizes with ARRAY_SIZE()

2006-08-14 Thread akpm
From: Bjorn Helgaas <[EMAIL PROTECTED]> Several IR drivers used "for (i = 0; i < 4; i++)" to walk their dev_self[] table. Better to use ARRAY_SIZE(). And fix ali-ircc so it won't run off the end if we find too many adapters. Signed-off-by: Bjorn Helgaas <[EMAIL PROTECTED]> Signed-off-by: Andrew

[patch 24/41] drivers/net/e1000/: possible cleanups

2006-08-14 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> - make needlessly global functions static - #if 0 the following unused global functions: - e1000_hw.c: e1000_mc_addr_list_update() - e1000_hw.c: e1000_read_reg_io() - e1000_hw.c: e1000_enable_pciex_master() - e1000_hw.c: e1000_ife_disable_dynamic_power

[patch 02/13] lockdep: annotate __icmpv6_socket

2006-08-14 Thread akpm
From: Ingo Molnar <[EMAIL PROTECTED]> Split off __icmpv6_socket's sk->sk_dst_lock class, because it gets used from softirqs, which is safe for __icmpv6_sockets (because they never get directly used via userspace syscalls), but unsafe for normal sockets. Has no effect on non-lockdep kernels. Sign

[patch 05/13] arcnet: SoHard PCI support

2006-08-14 Thread akpm
From: Stphane Witzmann <[EMAIL PROTECTED]> Add support for a SoHard PCI ARCnet card. Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/arcnet/com20020-pci.c |1 + 1 file changed, 1 insertion(+) diff -puN drivers/net/arcnet/com20020-pci.c~acrnet-sohard-pci-support drivers/n

[patch 10/13] fix potential stack overflow in net/core/utils.c

2006-08-14 Thread akpm
From: "Siddha, Suresh B" <[EMAIL PROTECTED]> On High end systems (1024 or so cpus) this can potentially cause stack overflow. Fix the stack usage. Signed-off-by: Suresh Siddha <[EMAIL PROTECTED]> Cc: "David S. Miller" <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- net

[patch 06/13] xt_physdev build fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> It needs netfilter_bridge.h for brnf_deferred_hooks Cc: Bart De Schuymer <[EMAIL PROTECTED]> Cc: "David S. Miller" <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- net/netfilter/xt_physdev.c |1 + 1 file changed, 1 insertion(+)

[patch 01/13] via-ircc: fix memory leak

2006-08-14 Thread akpm
From: Chuck Short <[EMAIL PROTECTED]> Fix memory leak. Coverity id# 653 patch location: http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=a1f34cb68b16807ed9d5ebb0f6a6ec5ff8a5fc78 Signed-off-by: Chuck Short <[EMAIL PROTECTED]> Signed-off-by: Ben Collins <[EM

[patch 03/13] ppp: handle kmalloc() failures

2006-08-14 Thread akpm
From: Panagiotis Issaris <[EMAIL PROTECTED]> The PPP code contains two kmalloc()s followed by memset()s without handling a possible memory allocation failure. (Suggested by Joe Perches). And furthermore, conversions from kmalloc+memset to kzalloc. [EMAIL PROTECTED]: fix error-path leak] [EMAIL

[patch 09/13] net: add the UdpSndbufErrors and UdpRcvbufErrors MIBs

2006-08-14 Thread akpm
From: Martin Bligh <[EMAIL PROTECTED]> Signed-off-by: Martin Bligh <[EMAIL PROTECTED]> Cc: "David S. Miller" <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- include/linux/snmp.h |2 ++ net/ipv4/proc.c |2 ++ net/ipv4/udp.c | 16 +++- 3 fi

[patch 08/13] netfilter: make unused signal code go away so nobody copies its brokenness

2006-08-14 Thread akpm
From: Alan Cox <[EMAIL PROTECTED]> This code is wrong on so many levels, please lose it so it isn't replicated anywhere else. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> Cc: Patrick McHardy <[EMAIL PROTECTED]> Cc: "David S. Miller" <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTE

[patch 16/41] ibmtr section fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> WARNING: drivers/net/tokenring/ibmtr.o - Section mismatch: reference to .init.data:ibmtr_mem_base from .text between 'ibmtr_probe1' (at offset 0x6e6) and 'ibmtr_probe_card' WARNING: drivers/net/tokenring/ibmtr.o - Section mismatch: reference to .init.data

[patch 05/41] cops section fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> WARNING: drivers/net/appletalk/cops.o - Section mismatch: reference to .init.text:cops_probe from .text between 'init_module' (at offset 0xae) and 'cops_rx' Cc: "David S. Miller" <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- d

[patch 41/41] ppc32: board-specific part of fs_enet update

2006-08-14 Thread akpm
From: Vitaly Bordug <[EMAIL PROTECTED]> This contains board-specific portion to respect driver changes (for 8272ads , 885ads and 866ads). Altered platform_data structures as well as initial setup routines relevant to fs_enet. Changes to the mpc8560ads ppc/ code are also introduced, but mainly as

[patch 26/41] Update smc91x driver with ARM Versatile board info

2006-08-14 Thread akpm
From: Deepak Saxena <[EMAIL PROTECTED]> We need to specify a Versatile-specific SMC_IRQ_FLAGS value or the new generic IRQ layer will complain thusly: No IRQF_TRIGGER set_type function for IRQ 25 () Signed-off-by: Deepak Saxena <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Russell

[patch 17/41] smctr section fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> WARNING: drivers/net/tokenring/smctr.o - Section mismatch: reference to .init.text: from .text between 'init_module' (at offset 0x2ba0) and 'smctr_reset_adapter' WARNING: drivers/net/tokenring/smctr.o - Section mismatch: reference to .init.text:smctr_prob

[patch 02/41] ixgb: add PCI Error recovery callbacks

2006-08-14 Thread akpm
From: [EMAIL PROTECTED] (Linas Vepstas) Adds PCI Error recovery callbacks to the Intel 10-gigabit ethernet ixgb device driver. Lightly tested, works. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: Jesse Brandeburg <[EMAIL PROTECTED]> Cc: Auke Kok <[EMAIL PROTECTED]> Cc: John Ronciak <[EMAI

[patch 33/41] via-rhine: add option avoid_D3 (work around broken BIOSes)

2006-08-14 Thread akpm
From: Roger Luethi <[EMAIL PROTECTED]> It looks like broken BIOSes controlling Rhine chips will remain in use in significant numbers; such systems fail to come up via PXE after they have been put into D3 (power-saving) mode. This patch adds a module option for disabling the call that puts the chi

[patch 23/41] sundance section fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> drivers/net/sundance.c:110: error: version causes a section type conflict I don't understand this error. It's referred to from both __init and __devinit code. With CONFIG_HOTPLUG=n, version[] is placed in .init.data and is referred to from .init.text. Cc

[patch 27/41] s2io build fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> sparc32: drivers/net/s2io.c:2636: warning: implicit declaration of function 'disable_irq' drivers/net/s2io.c:2656: warning: implicit declaration of function 'enable_irq' Cc: Ananda Raju <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by:

[patch 10/41] eexpress section fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> WARNING: drivers/net/eexpress.o - Section mismatch: reference to .init.text: from .text between 'init_module' (at offset 0x6c3) and 'eexp_hw_lasttxstat' WARNING: drivers/net/eexpress.o - Section mismatch: reference to .init.text: from .text between 'init_m

[patch 21/41] winbond-840 section fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> With CONFIG_HOTPLUG=n it won't compile: drivers/net/tulip/winbond-840.c:141: error: version causes a section type conflict (For some reason it gets the same error if marked __initdata. Give up.) Cc: Valerie Henson <[EMAIL PROTECTED]> Cc: Jeff Garzik <[E

[patch 28/41] net: Add netconsole support to dm9000 driver

2006-08-14 Thread akpm
From: "Kevin Hao" <[EMAIL PROTECTED]> Add netconsole support to dm9000 driver. Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Sascha Hauer <[EMAIL PROTECTED]> Cc: Ben Dooks <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/dm9000.c | 14 ++ 1 file chang

[patch 18/41] wd section fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> WARNING: drivers/net/wd.o - Section mismatch: reference to .init.text: from .text between 'init_module' (at offset 0xfd) and 'wd_open' WARNING: drivers/net/wd.o - Section mismatch: reference to .init.text: from .text between 'init_module' (at offset 0x14b)

[patch 20/41] seeq8005 section fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> WARNING: drivers/net/seeq8005.o - Section mismatch: reference to .init.text:seeq8005_probe from .text between 'init_module' (at offset 0x106) and 'seeq8005_open' Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- dr

[patch 37/41] s390: fix arp_tbl lock usage in qeth

2006-08-14 Thread akpm
From: Heiko Carstens <[EMAIL PROTECTED]> qeth: bhs must be disabled when accessing neighbour tables. = [ INFO: inconsistent lock state ] - inconsistent {in-softirq-W} -> {softirq-on-W} usage. modprobe/529 [HC0[0]:SC0[0]:HE1:SE1] take

[patch 36/41] skge: remember to run netif_poll_disable()

2006-08-14 Thread akpm
From: "Edgar E. Iglesias" <[EMAIL PROTECTED]> Signed-off-by: Edgar E. Iglesias <[EMAIL PROTECTED]> Cc: Stephen Hemminger <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/skge.c |2 ++ 1 file changed, 2 insertions(+) dif

[patch 08/41] e2100 section fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> WARNING: drivers/net/e2100.o - Section mismatch: reference to .init.text: from .text between 'init_module' (at offset 0xd9) and 'e21_reset_8390' Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/e2100.c

[patch 07/41] at1700 section fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> WARNING: drivers/net/at1700.o - Section mismatch: reference to .init.text:at1700_probe from .text between 'init_module' (at offset 0x75) and 'net_get_stats' Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers

[patch 39/41] PAL: Support of the fixed PHY

2006-08-14 Thread akpm
From: Vitaly Bordug <[EMAIL PROTECTED]> This makes it possible for HW PHY-less boards to utilize PAL goodies. Generic routines to connect to fixed PHY are provided, as well as ability to specify software callback that fills up link, speed, etc. information into PHY descriptor (the latter feature

[patch 29/41] smc911x: Re-release spinlock on spurious interrupt

2006-08-14 Thread akpm
From: Peter Korsgaard <[EMAIL PROTECTED]> The smc911x driver forgets to release the spinlock on spurious interrupts. This little patch fixes it. Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/n

[patch 34/41] build fixes: smc91x

2006-08-14 Thread akpm
From: David Brownell <[EMAIL PROTECTED]> Unclear how these bugs arrived, presumably from incorrect cleanup of the 16-bit-only paths, but smc91x wouldn't build for OMAP. Signed-off-by: David Brownell <[EMAIL PROTECTED]> Cc: Nicolas Pitre <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Sign

[patch 14/41] lne390 section fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> WARNING: drivers/net/lne390.o - Section mismatch: reference to .init.text: from .text between 'init_module' (at offset 0x100) and 'lne390_close' Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/lne390.c

[patch 19/41] ni65 section fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> WARNING: drivers/net/ni65.o - Section mismatch: reference to .init.text:ni65_probe from .text between 'init_module' (at offset 0x54a) and 'ni65_stop_start' Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/

[patch 04/41] ac3200 section fixes

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> WARNING: drivers/net/ac3200.o - Section mismatch: reference to .init.text: from .text between 'init_module' (at offset 0xf9) and 'ac_close_card' Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/ac3200.c

[patch 15/41] ni52 section fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> WARNING: drivers/net/ni52.o - Section mismatch: reference to .init.text:ni52_probe from .text between 'init_module' (at offset 0x997) and 'ni52_close' WARNING: drivers/net/ni65.o - Section mismatch: reference to .init.text:ni65_probe from .text between 'i

[patch 31/41] via-rhine: NAPI poll enable

2006-08-14 Thread akpm
From: Stephen Hemminger <[EMAIL PROTECTED]> The poll_enable should be in init_registers before enabling interrupts, not in tx_timeout. Thanks for spotting it Roger. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Cc: Roger Luethi <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROT

[patch 01/41] e100: disable interrupts at boot

2006-08-14 Thread akpm
From: Bjorn Helgaas <[EMAIL PROTECTED]> Apparently the Intel PRO/100 device enables interrupts on reset. Unless firmware explicitly disables PRO/100 interrupts, we can get a flood of interrupts when a driver attaches to an unrelated device that happens to share the PRO/100 IRQ. This should resol

[patch 11/41] es3210 section fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> WARNING: drivers/net/es3210.o - Section mismatch: reference to .init.text: from .text between 'init_module' (at offset 0xdf) and 'es_close' WARNING: drivers/net/es3210.o - Section mismatch: reference to .init.text: from .text between 'init_module' (at offs

[patch 09/41] eepro section fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> WARNING: drivers/net/eepro.o - Section mismatch: reference to .init.text: from .text between 'init_module' (at offset 0x284) and 'eepro_ethtool_get_drvinfo' WARNING: drivers/net/eepro.o - Section mismatch: reference to .init.text: from .text between 'init_

[patch 13/41] lance section fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> WARNING: drivers/net/lance.o - Section mismatch: reference to .init.data:lance_portlist from .text between 'init_module' (at offset 0x8d3) and 'lance_purge_ring' Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- dri

[patch 22/41] fealnx section fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> With CONFIG_HOTPLUG=n it won't compile: distcc[25607] ERROR: compile drivers/net/fealnx.c on g5/64 failed version[] is referred to from both __init code and from __devinit code, so move it out of __init altogether. Cc: Jeff Garzik <[EMAIL PROTECTED]> Sign

[patch 06/41] cs89x0 section fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> WARNING: drivers/net/cs89x0.o - Section mismatch: reference to .init.data:version from .text between 'init_module' (at offset 0x13d8) and 'net_get_stats' WARNING: drivers/net/cs89x0.o - Section mismatch: reference to .init.text: from .text between 'init_m

[patch 03/41] 82596 section fixes

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> WARNING: drivers/net/82596.o - Section mismatch: reference to .init.text:i82596_probe from .text between 'init_module' (at offset 0x141) and 'i596_add_cmd' Also nail a couple of crazy inlines. Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Mor

[patch 12/41] eth16i section fix

2006-08-14 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> WARNING: drivers/net/eth16i.o - Section mismatch: reference to .init.data:cardname from .text between 'init_module' (at offset 0x6d2) and 'eth16i_multicast' WARNING: drivers/net/eth16i.o - Section mismatch: reference to .init.text: from .text between 'ini

Re: ehea debug output discussion

2006-08-14 Thread Paul Mackerras
Jan-Bernd Themann writes: > The outcome of some internal discussions was that it is not acceptable for > our enterprise users of this type of driver on this target system to need a > recompile / reload of the driver for error analysis, so we need a mechanism > that allows us to switch on / off deb

Re: [PATCH 09/16] [IPv6] address: Convert address notification to use rtnl_notify()

2006-08-14 Thread jamal
On Mon, 2006-14-08 at 22:46 -0400, jamal wrote: > On Tue, 2006-15-08 at 10:56 +1000, Herbert Xu wrote: > Thats all the quagga > and other folks were looking for in cases where it was ambigous. > Just to be clear, when Alexey says "that past discussion essentially closed the question." he is corr

Re: [PATCH 09/16] [IPv6] address: Convert address notification to use rtnl_notify()

2006-08-14 Thread jamal
On Tue, 2006-15-08 at 10:56 +1000, Herbert Xu wrote: > Agreed. The pid field in the netlink header should be treated as an > opaque value. Any attempt to interpret it as the process ID is doomed > to failure. Not necessarily as a processid ("PID" is a really bad noun in that sense); but rather

Re: Kernel patches enabling better POSIX AIO (Was Re: [3/4] kevent: AIO, aio_sendfile)

2006-08-14 Thread Nicholas Miell
On Mon, 2006-08-14 at 09:38 -0700, Ulrich Drepper wrote: > Suparna Bhattacharya wrote: > > Is there a (remote) possibility that the thread could have died and its > > pid got reused by a new thread in another process ? Or is there a mechanism > > that prevents such a possibility from arising (not j

Re: [PATCH] move skb->dev assignment into netdev_alloc_skb

2006-08-14 Thread Brandeburg, Jesse
On Sat, 12 Aug 2006, Christoph Hellwig wrote: > > >> Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> > > > > > >Since the e1000 change is non-trivial I'm not going to bypass > > >the driver author on it, sorry. > > > > > >What I did do was put the netdev_alloc_skb() change into my > > >tree, a

Re: [PATCH 09/16] [IPv6] address: Convert address notification to use rtnl_notify()

2006-08-14 Thread Herbert Xu
Alexey Kuznetsov <[EMAIL PROTECTED]> wrote: > >> IMO, I believe there is a strong case that can be made for events that >> were caused by non-netlink users such as ioctls that could at least be >> multicast with current->pid. > > Highly not desired. Agreed. The pid field in the netlink header s

BUG at kernel/workqueue.c:149 using linux-2.6.18-rc4 with zd1211rw

2006-08-14 Thread Max
Hit this when connecting a computer to an access point with a zydas usb dongle using the zd1211rw driver. This seems entirely reproducible (2/2). The system hit the BUG over night. I already sent this to zd1211-devs and Ulrich Kunitz suggested that it might be a bug in softmac, so resending to a

Re: [RFC 5/7] neighbour: convert lookup to sequence lock

2006-08-14 Thread Alexey Kuznetsov
Hello! > That wouldn't work if hard_header() ever expands the head. Fortunately > hard_header() returns the length added even in case of an error so we > can undo the absolute value returned. Yes. Or probably it is safer to undo to skb->nh. Even if hard_header expands skb, skb->nh still remains

[2.6 patch] orinoco.h: "extern inline" -> "static __always_inline"

2006-08-14 Thread Adrian Bunk
"extern inline" generates a warning with -Wmissing-prototypes and I'm currently working on getting the kernel cleaned up for adding this to the CFLAGS since it will help us to avoid a nasty class of runtime errors. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/wireless/orino

Re: [PATCH 09/16] [IPv6] address: Convert address notification to use rtnl_notify()

2006-08-14 Thread Alexey Kuznetsov
Hello! > Some of these removals of current->pid will affect users such as quagga, > zebra, vrrpd etc. If they survived cleanup in IPv4, they definitely will not feel cleanup in IPv6. Thomas does great work, Jamal, do not worry. :-) > IMO, I believe there is a strong case that can be made for e

Re: [PATCH 09/16] [IPv6] address: Convert address notification to use rtnl_notify()

2006-08-14 Thread jamal
On Tue, 2006-15-08 at 02:07 +0200, Thomas Graf wrote: > * jamal <[EMAIL PROTECTED]> 2006-08-14 19:43 > > If i am not mistaken: > > Some of these removals of current->pid will affect users such as quagga, > > zebra, vrrpd etc. If those specific users are not affected, please > > ignore the rest of

Re: [PATCH 0/3] myri10ge update

2006-08-14 Thread Brice Goglin
Jeff Garzik wrote: > Brice Goglin wrote: >> Hi, >> >> Here's 3 new minor updates for the myri10ge driver: >> >> 1) define some previously hardwired firmware constants >> 2) allow to disable link status change reporting >> 3) convert to netdev_alloc_skb > > Patches 1 and 3 look OK. They are cleanup

Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-08-14 Thread David Miller
From: Jay Vosburgh <[EMAIL PROTECTED]> Date: Thu, 03 Aug 2006 18:01:35 -0700 > In this case (bond0.555 above bond0 above eth0,eth1,etc), > skb_bond doesn't suppress duplicates because skb_bond is called with the > skb->dev set to the bond0.555 dev, not the ethX dev. Non-accelerated > VLAN d

Re: [PATCH 4/6] ehea: header files

2006-08-14 Thread Michael Ellerman
On Mon, 2006-08-14 at 14:53 +0200, Jan-Bernd Themann wrote: > Michael Ellerman wrote: > >> --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea.h 1969-12-31 > >> 16:00:00.0 -0800 > >> +++ kernel/drivers/net/ehea/ehea.h 2006-08-08 23:59:39.927452928 -0700 > >> + > >> +#define EHEA_PAGESHIFT 12

Re: sysfs vs. d80211 configuration

2006-08-14 Thread Mike Kershaw
On Mon, Aug 14, 2006 at 11:05:15PM +, Alexey Toptygin wrote: > On Mon, 14 Aug 2006, Johannes Berg wrote: > > >In my seemingly never-ending quest to actually use the d80211 stack for > >something useful I just wanted to write a small setuid tool that: > >* creates and opens a new monitor inter

Re: [PATCH 09/16] [IPv6] address: Convert address notification to use rtnl_notify()

2006-08-14 Thread Thomas Graf
* jamal <[EMAIL PROTECTED]> 2006-08-14 19:43 > On Mon, 2006-14-08 at 00:00 +0200, Thomas Graf wrote: > > plain text document attachment (rtnl_convert_ip6_addr) > > Fixes a wrong use of current->pid as netlink pid. > > If i am not mistaken: > Some of these removals of current->pid will affect users

Re: ehea debug output discussion

2006-08-14 Thread Michael Ellerman
On Mon, 2006-08-14 at 14:38 +0200, Jan-Bernd Themann wrote: > Hi > > Anton Blanchard wrote: > > What is going to be done about the debug infrastructure in the ehea > > driver? The entry and exit traces really need to go, and any other debug > > you think is important to users needs to go into debu

Re: [PATCH 09/16] [IPv6] address: Convert address notification to use rtnl_notify()

2006-08-14 Thread jamal
CCing Hasso Tepper <[EMAIL PROTECTED]> Hasso, please comment on this thread (apologies, I forgot the other guy's name; so if you can CC all the necessary suspects to comment, it would help). cheers, jamal On Mon, 2006-14-08 at 19:43 -0400, jamal wrote: > On Mon, 2006-14-08 at 00:00 +0200, Thoma

Re: [PATCH 09/16] [IPv6] address: Convert address notification to use rtnl_notify()

2006-08-14 Thread jamal
On Mon, 2006-14-08 at 00:00 +0200, Thomas Graf wrote: > plain text document attachment (rtnl_convert_ip6_addr) > Fixes a wrong use of current->pid as netlink pid. If i am not mistaken: Some of these removals of current->pid will affect users such as quagga, zebra, vrrpd etc. If those specific user

Re: [RFC 5/7] neighbour: convert lookup to sequence lock

2006-08-14 Thread Thomas Graf
* Stephen Hemminger <[EMAIL PROTECTED]> 2006-08-14 15:37 > On Tue, 15 Aug 2006 00:22:20 +0200 > Thomas Graf <[EMAIL PROTECTED]> wrote: > > Don't you need to pull in order to undo the push that probably > > happened in dev->hard_header()? > > Probably just record the headroom() and undo that? That

Re: sysfs vs. d80211 configuration

2006-08-14 Thread Alexey Toptygin
On Mon, 14 Aug 2006, Johannes Berg wrote: In my seemingly never-ending quest to actually use the d80211 stack for something useful I just wanted to write a small setuid tool that: * creates and opens a new monitor interface * drops priviledges * ... does things with received frames ... (not int

Re: [RFC][NET::SCHED]: cleanup qdisc_restart

2006-08-14 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Mon, 14 Aug 2006 18:57:27 -0400 > The question to ask though is: shouldnt we be having drivers use the > mnemonics instead of values like 1? Absolutely, but while such conversions still remain undone we shouldn't knowingly break stuff :) - To unsubscribe fro

Re: 2.6.18-rc4-mm1: eth0: trigger_send() called with the transmitter busy

2006-08-14 Thread Laurent Riffard
Le 14.08.2006 23:25, Rafael J. Wysocki a écrit : > On Monday 14 August 2006 22:06, Laurent Riffard wrote: >> Le 14.08.2006 19:47, Laurent Riffard a écrit : >>> Le 14.08.2006 18:50, Andrew Morton a écrit : On Mon, 14 Aug 2006 16:38:47 +0200 Laurent Riffard <[EMAIL PROTECTED]> wrote: >

Re: [RFC][NET::SCHED]: cleanup qdisc_restart

2006-08-14 Thread jamal
On Mon, 2006-14-08 at 14:01 -0700, David Miller wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Tue, 15 Aug 2006 07:42:39 -0700 > > > Please don't change the values because some older drvers still return 1 > > rather > > than NETDEV_TX_BUSY > > Unfortunately, this is probably very t

Re: [RFC 5/7] neighbour: convert lookup to sequence lock

2006-08-14 Thread Stephen Hemminger
On Tue, 15 Aug 2006 00:22:20 +0200 Thomas Graf <[EMAIL PROTECTED]> wrote: > * Stephen Hemminger <[EMAIL PROTECTED]> 2006-08-14 14:20 > > --- net-2.6.19.orig/net/core/neighbour.c > > +++ net-2.6.19/net/core/neighbour.c > > @@ -1160,19 +1164,24 @@ int neigh_resolve_output(struct sk_buff > > if

[patch RFC 3/3] b44: convert to ssb module

2006-08-14 Thread Michael Buesch
This is not runtime tested. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/Kconfig === --- wireless-dev.orig/drivers/net/Kconfig 2006-08-09 16:52:40.0 +0200 +++ wireless-dev/drivers/n

[patch RFC 2/3] bcm43xx-d80211: convert to ssb module

2006-08-14 Thread Michael Buesch
More #defines in bcm43xx.h can be deleted and the corresponding #defines in ssh.h can be used instead. But I leave this alone for now... Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/wireless/d80211/bcm43xx/bcm43xx.h

[patch RFC 0/3] Sonics Silicon Backplane module

2006-08-14 Thread Michael Buesch
Hi. This patch series creates a new Sonics Silicon Backplane driver and converts the bcm43xx and b44 drivers to use it. The bcm43xx patch is tested and it works. But the b44 patch is only compile tested, as I don't have the hardware (yet?). These patches apply against wireless-dev. -- Greetings

[patch RFC 1/3] add Sonics Silicon Backplane module

2006-08-14 Thread Michael Buesch
Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: wireless-dev/drivers/misc/Kconfig === --- wireless-dev.orig/drivers/misc/Kconfig 2006-08-14 15:31:50.0 +0200 +++ wireless-dev/drivers/misc/Kconfig 2006-08-14 22:

Re: [RFC 5/7] neighbour: convert lookup to sequence lock

2006-08-14 Thread Thomas Graf
* Stephen Hemminger <[EMAIL PROTECTED]> 2006-08-14 14:20 > --- net-2.6.19.orig/net/core/neighbour.c > +++ net-2.6.19/net/core/neighbour.c > @@ -1160,19 +1164,24 @@ int neigh_resolve_output(struct sk_buff > if (!neigh_event_send(neigh, skb)) { > int err; > struct n

Re: Possible leak of multicast source filter sctructure

2006-08-14 Thread David Stevens
[EMAIL PROTECTED] wrote on 08/13/2006 08:44:05 PM: > From: "Michal Ruzicka" <[EMAIL PROTECTED]> > Date: Fri, 11 Aug 2006 12:04:53 +0100 > > > You are absolutely right, I just failed to notice that -ENODEV return value > > from ip_mc_del_src()/ip_mc_leave_src() is ignored. > > Here comes the patc

Re: [PATCH 0/3] myri10ge update

2006-08-14 Thread Jeff Garzik
Brice Goglin wrote: Hi, Here's 3 new minor updates for the myri10ge driver: 1) define some previously hardwired firmware constants 2) allow to disable link status change reporting 3) convert to netdev_alloc_skb Patches 1 and 3 look OK. They are cleanups, and will need to go into #upstream (

Re: [PATCH 2/3] myri10ge: allow to disable link status change reporting

2006-08-14 Thread Jeff Garzik
Brice Goglin wrote: Add myri10ge_verbose module parameter to disable reporting of link status change since some Ethernet switches seem to generate a lot of status changes under some circumstances and some people want to avoid useless flooding in the logs. Also add a counter for link status chang

[PATCH 1/3] myri10ge: define some previously hardwired firmware constants

2006-08-14 Thread Brice Goglin
Define some previously hardwired firmware constants. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c | 17 ++--- drivers/net/myri10ge/myri10ge_mcp.h | 14 +- 2 files changed, 23 insertions(+), 8 deletions(-) Index: linux-mm/driv

[PATCH 3/3] myri10ge: convert to netdev_alloc_skb

2006-08-14 Thread Brice Goglin
Convert the myri10ge driver to use netdev_alloc_skb instead of dev_alloc_skb, which requires to propagate the net_device across several functions. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c | 37 - 1 file changed, 20 i

[PATCH 0/3] myri10ge update

2006-08-14 Thread Brice Goglin
Hi, Here's 3 new minor updates for the myri10ge driver: 1) define some previously hardwired firmware constants 2) allow to disable link status change reporting 3) convert to netdev_alloc_skb Please apply. Thank you Brice Goglin - To unsubscribe from this list: send the line "unsubscribe netdev

[PATCH 2/3] myri10ge: allow to disable link status change reporting

2006-08-14 Thread Brice Goglin
Add myri10ge_verbose module parameter to disable reporting of link status change since some Ethernet switches seem to generate a lot of status changes under some circumstances and some people want to avoid useless flooding in the logs. Also add a counter for link status changes to statistics. Sig

Re: Patches queued in wireless-2.6 for 2.6.19

2006-08-14 Thread Daniel Drake
John W. Linville wrote: Daniel Drake: zd1211rw: ZD1211B ASIC/FWT, not jointly decoder Any chance this one can go into 2.6.18? Otherwise, one of my devices (which is otherwise supported by the driver in the 2.6.18 tree) cannot transmit any frames. Thanks, Daniel - To unsubscribe from

[PATCH 11/16] [IPv6] link: Convert link notifications to use rtnl_notify()

2006-08-14 Thread Thomas Graf
Fixes a wrong use of current->pid as netlink pid. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.19.git/net/ipv6/addrconf.c === --- net-2.6.19.git.orig/net/ipv6/addrconf.c +++ net-2.6.19.git/net/ipv6/addrconf.c @@ -343

[PATCH 07/16] [IPv4] address: Convert address notification to use rtnl_notify()

2006-08-14 Thread Thomas Graf
Adds support for NLM_F_ECHO allowing applications to easly see which address have been deleted, added, or promoted. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.19.git/net/ipv4/devinet.c === --- net-2.6.19.git.orig/n

[PATCH 04/16] [NET] fib_rules: Convert fib rule notification to use rtnl_notify()

2006-08-14 Thread Thomas Graf
Adds support for NLM_F_ECHO to simplify the process of identifying inserted rules with an auto generated priority. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.19.git/net/core/fib_rules.c === --- net-2.6.19.git.orig/

[PATCH 06/16] [DECNET]: Convert DECnet notifications to use rtnl_notify()

2006-08-14 Thread Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.19.git/net/decnet/dn_dev.c === --- net-2.6.19.git.orig/net/decnet/dn_dev.c +++ net-2.6.19.git/net/decnet/dn_dev.c @@ -746,20 +746,23 @@ rtattr_failure: static void rtmsg_i

[PATCH 10/16] [IPv6] route: Convert route notifications to use rtnl_notify()

2006-08-14 Thread Thomas Graf
Fixes a wrong use of current->pid as netlink pid. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.19.git/net/ipv6/route.c === --- net-2.6.19.git.orig/net/ipv6/route.c +++ net-2.6.19.git/net/ipv6/route.c @@ -35,7 +35,6 @

[PATCH 02/16] [NETLINK]: Add notification message sending interface

2006-08-14 Thread Thomas Graf
Adds nlmsg_notify() implementing proper notification logic. The message is multicasted to all listeners in the group. The applications the requests orignates from can request a unicast back report in which case said socket will be excluded from the multicast to avoid duplicated notifications. nlms

[PATCH 13/16] [BRIDGE]: Convert notifications to use rtnl_notify()

2006-08-14 Thread Thomas Graf
Fixes a wrong use of current->pid as netlink pid. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.19.git/net/bridge/br_netlink.c === --- net-2.6.19.git.orig/net/bridge/br_netlink.c +++ net-2.6.19.git/net/bridge/br_netli

  1   2   3   >