Re: Question on manual bridging.

2005-11-22 Thread Michael Renzmann
Hi. On Tue, 2005-11-22 at 15:26 -0800, Ben Greear wrote: > Connected to eth0 is a PC with MAC address AA, which is exactly the > same MAC address as ms1 has (this is to work around the fact that > a wifi interface can't really go into promisc mode or send frames with > a different source MAC addre

Re: [NETLINK]: Use tgid instead of pid for nlmsg_pid

2005-11-22 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 23 Nov 2005 11:03:37 +1100 > On Tue, Nov 22, 2005 at 02:43:34PM -0800, David S. Miller wrote: > > It is possible we accidently reintroduced current->pid when > > we redid all of the netlink hashing. :-) > > I just checked using git-whatchanged and t

Re: [2.6 patch] do not select NET_CLS

2005-11-22 Thread Sam Ravnborg
On Tue, Nov 22, 2005 at 03:00:41PM -0800, David S. Miller wrote: > From: Sam Ravnborg <[EMAIL PROTECTED]> > Date: Tue, 22 Nov 2005 23:49:14 +0100 > > > On Tue, Nov 22, 2005 at 02:37:13PM -0800, David S. Miller wrote: > > > > > > One thing we can do to prevent human > > > mistakes, is to make the

Re: [PATCH 00/13]: Netfilter IPsec support

2005-11-22 Thread Yasuyuki KOZAKAI
From: "David S. Miller" <[EMAIL PROTECTED]> Date: Tue, 22 Nov 2005 19:36:31 -0800 (PST) > From: Herbert Xu <[EMAIL PROTECTED]> > Date: Wed, 23 Nov 2005 12:35:53 +1100 > > > How about merging the patches that everybody has agreed on first? > > > > So far, I haven't see any objections to patches 1

Re: [PATCH 00/13]: Netfilter IPsec support

2005-11-22 Thread Herbert Xu
On Tue, Nov 22, 2005 at 07:36:31PM -0800, David S. Miller wrote: > > View the net-2.6.16 GIT tree as a sort of playpen, much like > -mm, until we get close to the real 2.6.16 upstream development > openning up. > > I rebase all the time, and I can pluck out and change patches > at will. Sure, I

Re: [PATCH 00/13]: Netfilter IPsec support

2005-11-22 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 23 Nov 2005 12:35:53 +1100 > How about merging the patches that everybody has agreed on first? > > So far, I haven't see any objections to patches 1 and 2 so they > can go in straight away. They don't even touch IPv6. > > Patches 3-6 could become

Re: [PATCH 00/13]: Netfilter IPsec support

2005-11-22 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 23 Nov 2005 02:17:14 +0100 > I would appreciate that, but I want to have a look closer look > at Herbert's patches first. Unfortunately its late and I have > to get up early, so its going to take me a day. Take your time :) - To unsubscribe fro

Re: [ANNOUNCE] iproute2 2.6.14-051107

2005-11-22 Thread Antonio Dias
Stephen Hemminger <[EMAIL PROTECTED]> wrote: > I would rather reduce the surprise factor to new users, than worry > about keeping total compatibility with lazy typists. Not everyone reads > the source to know what the order is. > > Maybe just a nattering warning as a compromise. One question tha

Re: [ANNOUNCE] iproute2 2.6.14-051107

2005-11-22 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 23 Nov 2005 02:00:37 +0100 > So everytime I use "ip r" it will give me a warning? I hope > not, since I am used to using it this way. Ambiguousy is not > a problem IMO, I didn't discover this behaviour by reading > the source, but still never wo

Re: [PATCH 00/13]: Netfilter IPsec support

2005-11-22 Thread Herbert Xu
Patrick McHardy <[EMAIL PROTECTED]> wrote: > > I would appreciate that, but I want to have a look closer look > at Herbert's patches first. Unfortunately its late and I have > to get up early, so its going to take me a day. How about merging the patches that everybody has agreed on first? So far

[2.6 patch] net/sunrpc/xdr.c: remove xdr_decode_string()

2005-11-22 Thread Adrian Bunk
On Thu, Oct 06, 2005 at 07:13:14AM -0700, Lever, Charles wrote: > actually, can we hold off on this change? the RPC transport switch will > eventually need most of those EXPORT_SYMBOLs. Am I right to assume this will happen in the foreseeable future? > the only harmless change i see below is re

Re: [ANNOUNCE] iproute2 2.6.14-051107

2005-11-22 Thread Herbert Xu
On Wed, Nov 23, 2005 at 02:00:37AM +0100, Patrick McHardy wrote: > > So everytime I use "ip r" it will give me a warning? I hope > not, since I am used to using it this way. Ambiguousy is not > a problem IMO, I didn't discover this behaviour by reading > the source, but still never wondered why "i

[2.6 patch] net/ipv6/: make two functions static

2005-11-22 Thread Adrian Bunk
This patch makes two needlessly global functions static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- net/ipv6/ip6_output.c|3 ++- net/ipv6/ipv6_sockglue.c |4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) --- linux-2.6.15-rc1-mm2-full/net/ipv6/ip6_output.c.old 2005-

Re: [PATCH 00/13]: Netfilter IPsec support

2005-11-22 Thread Patrick McHardy
David S. Miller wrote: From: Patrick McHardy <[EMAIL PROTECTED]> Date: Sun, 20 Nov 2005 17:31:28 +0100 This is the latest netfilter/IPsec patchset. Its purpose is to make IPsec look as much as a normal tunnel device to netfilter as possible and to enable NAT support. I think there are some

Re: [ANNOUNCE] iproute2 2.6.14-051107

2005-11-22 Thread Patrick McHardy
Herbert Xu wrote: On Tue, Nov 22, 2005 at 03:36:22PM -0800, Stephen Hemminger wrote: I would rather reduce the surprise factor to new users, than worry about keeping total compatibility with lazy typists. Not everyone reads the source to know what the order is. Maybe just a nattering warning

Re: [ANNOUNCE] iproute2 2.6.14-051107

2005-11-22 Thread Herbert Xu
On Tue, Nov 22, 2005 at 03:36:22PM -0800, Stephen Hemminger wrote: > > I would rather reduce the surprise factor to new users, than worry > about keeping total compatibility with lazy typists. Not everyone reads > the source to know what the order is. > > Maybe just a nattering warning as a comp

[2.6 patch] net/ipv4/netfilter/: small cleanups

2005-11-22 Thread Adrian Bunk
This patch contains the following cleanups: - make needlessly global code static - ip_conntrack_core.c: ip_conntrack_flush() -> ip_conntrack_flush(void) Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- net/ipv4/netfilter/ip_conntrack_core.c |4 ++-- net/ipv4/netfilter/ip_nat_core.c

[2.6 patch] net/ipv4/: make two functions static

2005-11-22 Thread Adrian Bunk
This patch makes two needlessly global functions static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- net/ipv4/ip_gre.c|2 +- net/ipv4/ip_output.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.15-rc1-mm2-full/net/ipv4/ip_output.c.old 2005-11-22 22:5

Re: [NETLINK]: Use tgid instead of pid for nlmsg_pid

2005-11-22 Thread Herbert Xu
On Tue, Nov 22, 2005 at 02:43:34PM -0800, David S. Miller wrote: > > Applied, of course. Thanks Dave. > It is possible we accidently reintroduced current->pid when > we redid all of the netlink hashing. :-) I just checked using git-whatchanged and that line goes back to 2002 :) Cheers, -- Vi

Re: e1000 82571 Packet Splitting

2005-11-22 Thread Jeff V. Merkey
Jesse Brandeburg wrote: this should be on netdev. On 11/22/05, Jeff V. Merkey <[EMAIL PROTECTED]> wrote: I have noted that the e1000 driver is now supporting DMA splitting of the packet header and payload into separate pages. I also noticed that none of the config options enable it. Is an

Re: e1000 82571 Packet Splitting

2005-11-22 Thread Jesse Brandeburg
this should be on netdev. On 11/22/05, Jeff V. Merkey <[EMAIL PROTECTED]> wrote: > > I have noted that the e1000 driver is now supporting DMA splitting of > the packet header and payload into separate pages. I also noticed > that none of the config options enable it. Is anyone using this feature

Re: [PATCH 00/13]: Netfilter IPsec support

2005-11-22 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 22 Nov 2005 14:34:38 -0800 (PST)), "David S. Miller" <[EMAIL PROTECTED]> says: > I want to do this so that Patrick doesn't have to repost > 13 or so patches every time one of the parts still under > discussion gets changed. > > Actually, it seems the only

Re: [ANNOUNCE] iproute2 2.6.14-051107

2005-11-22 Thread Stephen Hemminger
On Wed, 23 Nov 2005 08:10:55 +1100 Herbert Xu <[EMAIL PROTECTED]> wrote: > On Wed, Nov 23, 2005 at 07:30:40AM +1100, Herbert Xu wrote: > > > > What about 'ip r'? I've seen quite a few uses of that since it > > always referred to 'ip route'. > > > > I'd prefer if we can just keep the existing beh

Question on manual bridging.

2005-11-22 Thread Ben Greear
Suppose I have a wifi interface 'ms1' and an ethernet interface eth0. Connected to eth0 is a PC with MAC address AA, which is exactly the same MAC address as ms1 has (this is to work around the fact that a wifi interface can't really go into promisc mode or send frames with a different source MA

Re: Network lockup under load

2005-11-22 Thread Herbert Xu
On Tue, Nov 22, 2005 at 06:09:30PM -0500, Joe Korty wrote: > > [pid 2479] read(4, "\0", 16384)= 1 > [pid 2479] write(3, > ",}\2169\1777\202T3\326\3572\2037\372\257\37\\\257\235R"..., 6192) = 6192 > [pid 2479] select(7, [3 4], [3], NULL, NULL) = 1 (out [3]) > [pid 2479] write(3, > "R\3

Re: Network lockup under load

2005-11-22 Thread Joe Korty
On Tue, Nov 22, 2005 at 06:09:30PM -0500, Joe Korty wrote: > On Wed, Nov 23, 2005 at 09:07:04AM +1100, Herbert Xu wrote: > > Joe Korty <[EMAIL PROTECTED]> wrote: > >> > >> ssh S 0010 0 2512 2511 (NOTLB) > >> f6d37ea0 0086 f6d37e90 0010 0002 0

Re: [2.6 patch] do not select NET_CLS

2005-11-22 Thread Adrian Bunk
On Tue, Nov 22, 2005 at 02:37:13PM -0800, David S. Miller wrote: >... > Changing config options of any kind can result in the main kernel > image needing to be rebuilt. One thing we can do to prevent human > mistakes, is to make the "make modules" pass do a quick "is vmlinux > uptodate?" check, an

Re: Network lockup under load

2005-11-22 Thread Joe Korty
On Wed, Nov 23, 2005 at 09:07:04AM +1100, Herbert Xu wrote: > Joe Korty <[EMAIL PROTECTED]> wrote: >> >> ssh S 0010 0 2512 2511 (NOTLB) >> f6d37ea0 0086 f6d37e90 0010 0002 00d0 0010 >> c218ea40 0001 f6c88530 00

Re: [2.6 patch] do not select NET_CLS

2005-11-22 Thread David S. Miller
From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Tue, 22 Nov 2005 23:49:14 +0100 > On Tue, Nov 22, 2005 at 02:37:13PM -0800, David S. Miller wrote: > > > > One thing we can do to prevent human > > mistakes, is to make the "make modules" pass do a quick "is vmlinux > > uptodate?" check, and if not pri

Re: [PATCH 1/1] [NETFILTER] ctnetlink: Fix refcount leak ip_conntrack/nat_proto

2005-11-22 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Tue, 22 Nov 2005 23:01:30 +0100 > [NETFILTER] ctnetlink: Fix refcount leak ip_conntrack/nat_proto > > Remove proto == NULL checking since ip_conntrack_[nat_]proto_find_get > always returns a valid pointer. > > Fix missing ip_conntrack_proto_put in som

Re: [2.6 patch] do not select NET_CLS

2005-11-22 Thread Sam Ravnborg
On Tue, Nov 22, 2005 at 02:37:13PM -0800, David S. Miller wrote: > > One thing we can do to prevent human > mistakes, is to make the "make modules" pass do a quick "is vmlinux > uptodate?" check, and if not print out an error message explaining the > situation and aborting the "make modules" attem

Re: [PATCH 2.6.16] safer ipv4 reassembly

2005-11-22 Thread David S. Miller
From: Arthur Kepner <[EMAIL PROTECTED]> Date: Tue, 22 Nov 2005 08:40:27 -0800 (PST) > Another spin of Herbert Xu's "safer ip reassembly" patch > for 2.6.16. I'm very sorry for not getting this into 2.6.15 in time, it definitely should have gone into 2.6.15 I will make sure this gets into 2.6.16

Re: [PATCH] [IPV4] Fix secondary IP addresses after promotion

2005-11-22 Thread David S. Miller
From: jamal <[EMAIL PROTECTED]> Date: Tue, 22 Nov 2005 08:01:07 -0500 > Dave, if (ACK from Brian && no further comments) please apply > Also, same comment applies as before; this is a bug fix and you may > wanna consider it as 2.6.15 material. Applied, thanks everyone. - To unsubscribe from this

Re: [NETLINK]: Use tgid instead of pid for nlmsg_pid

2005-11-22 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 22 Nov 2005 09:16:27 +1100 > Alexey Kuznetsov <[EMAIL PROTECTED]> wrote: > > > > I agree, apparently netlink_autobind was missed when sed'ing pid->tgid. > > Of course, it does not matter, but tgid is nicer choice from user's > > viewpoint. > > Gre

Re: [2.6 patch] do not select NET_CLS

2005-11-22 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 21 Nov 2005 17:16:18 +0100 > Adrian Bunk wrote: > > This patch therefore changes NET_CLS back to the 2.6.14 status quo of > > being an user-visible option. > > I disagree with this patch. NET_CLS enables the infrastructure support > for classi

Re: Netconsole Patches

2005-11-22 Thread Matt Mackall
On Tue, Nov 22, 2005 at 09:53:08PM +0100, Michael Frank wrote: > Hi Matt, > > I sent 3 patches to you and cc to netdev@vger.kernel.org but > the patches did not show up on netdev. > > Have you received them? No, but I got two copies of this email. -- Mathematics is the supreme nostalgia of ou

Re: [PATCH 00/13]: Netfilter IPsec support

2005-11-22 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Sun, 20 Nov 2005 17:31:28 +0100 > This is the latest netfilter/IPsec patchset. Its purpose is to make > IPsec look as much as a normal tunnel device to netfilter as possible > and to enable NAT support. I think there are some of these patches that w

Re: [PATCH] NETFILTER arp_tables: Fix NUMA optimization

2005-11-22 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Sat, 19 Nov 2005 11:31:31 +0100 > There's another one that I detected while merging those changes with > x_tables (painful). Please merge: > > [NETFILTER] arp_tables: Fix bug introduced with NUMA aware allocation > > This fix shows how bad I am with

Re: VLAN and bridging with xen

2005-11-22 Thread Stephen Hemminger
On Sat, 19 Nov 2005 19:22:17 +1300 "Greg Brackley" <[EMAIL PROTECTED]> wrote: > I'm trying to get a bridging and VLAN working together with an unexpected > lack of success. ICMP pings are working well, but UDP traffic isn't > working. Without the VLAN interface I can get my XEN/bridging networkin

Re: [PATCH] ebtables: port ebt*[u]log.c to nf[netlink]_log

2005-11-22 Thread David S. Miller
From: Bart De Schuymer <[EMAIL PROTECTED]> Date: Tue, 15 Nov 2005 18:21:21 + > [NETFILTER] ebtables: Support nf_log API from ebt_log and ebt_ulog > > This makes ebt_log and ebt_ulog use the new nf_log api. This enables > the bridging packet filter to log packets e.g. via nfnetlink_log. > >

Re: Network lockup under load

2005-11-22 Thread Herbert Xu
Joe Korty <[EMAIL PROTECTED]> wrote: > > ssh S 0010 0 2512 2511 (NOTLB) > f6d37ea0 0086 f6d37e90 0010 0002 00d0 0010 > c218ea40 0001 f6c88530 0010 c064c400 c202b560 0003 > 0120 dd997fff 0d

[PATCH 1/1] [NETFILTER] ctnetlink: Fix refcount leak ip_conntrack/nat_proto

2005-11-22 Thread Harald Welte
[NETFILTER] ctnetlink: Fix refcount leak ip_conntrack/nat_proto Remove proto == NULL checking since ip_conntrack_[nat_]proto_find_get always returns a valid pointer. Fix missing ip_conntrack_proto_put in some paths. Signed-off-by: Pablo Neira Ayuso <[EMAIL PROTECTED]> Signed-off-by: Harald Welte

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-22 Thread Krzysztof Halasa
Stefan Rompf <[EMAIL PROTECTED]> writes: > Sorry, I don't get that and want to avoid further misunderstandings. So can > you use _ONE_ netdev_set_operstate() function to switch between OPER_DOWN > (!carrier), OPER_DORMANT (!protocol) and OPER_UP (both fine) or not? I can use whatever is availab

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-22 Thread Stefan Rompf
Hi Krzysztof, > No big deal with my generic HDLC (I may leave it one-layer though it's > quite dirty, and would be even less logical with the new > dormant/whatever). Sorry, I don't get that and want to avoid further misunderstandings. So can you use _ONE_ netdev_set_operstate() function to swit

Re: [ANNOUNCE] iproute2 2.6.14-051107

2005-11-22 Thread Herbert Xu
On Wed, Nov 23, 2005 at 07:30:40AM +1100, Herbert Xu wrote: > > What about 'ip r'? I've seen quite a few uses of that since it > always referred to 'ip route'. > > I'd prefer if we can just keep the existing behaviour rather than > making it an error. Another reason to keep things like 'ip m' an

Re: Network lockup under load

2005-11-22 Thread Joe Korty
[ lkml trimmed from the CC: list ] On Wed, Nov 23, 2005 at 07:40:08AM +1100, Herbert Xu wrote: > On Tue, Nov 22, 2005 at 04:45:02PM +, Joe Korty wrote: >> >> To trigger the lockup, I do a 'scp -rp' of the kernel >> tree from a machine with a defective kernel to any other >> machine. It trigg

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-22 Thread Krzysztof Halasa
Stefan Rompf <[EMAIL PROTECTED]> writes: > clear that his drivers have several independant layers, one responsible for > carrier, mapped to netdev_carrier*(), another one responsible for the > protocol, mapped to netdev_dormant*(). No big deal with my generic HDLC (I may leave it one-layer thou

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-22 Thread Stefan Rompf
Hi Jamal, > be transitioned to up/dormant etc. So an ethernet driver doesnt know it > needs to go from detecting peer link is up to next being authenticated > in the case of 802.1x. It just calls netif_carrier_on which checks > link_mode to decide on transition. we could protect operstate with a

Re: Network lockup under load

2005-11-22 Thread Herbert Xu
On Tue, Nov 22, 2005 at 04:45:02PM +, Joe Korty wrote: > > To trigger the lockup, I do a 'scp -rp' of the kernel > tree from a machine with a defective kernel to any other > machine. It triggers anywhere after the first file > transfered, to perhaps 30 files transfered. Please generate a sta

Re: [ANNOUNCE] iproute2 2.6.14-051107

2005-11-22 Thread Herbert Xu
Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > I added them back as well as better ambiguous command matching. > i.e. ip m > is now an error. What about 'ip r'? I've seen quite a few uses of that since it always referred to 'ip route'. I'd prefer if we can just keep the existing behaviour rathe

Re: [PATCH] [IPV4] Fix secondary IP addresses after promotion

2005-11-22 Thread jamal
On Tue, 2005-22-11 at 11:06 -0800, Brian Pomerantz wrote: > Hmm...I think I must have copied that up to my pirahaven account after > making that change but I tested without it. I had originally read > that macro as the same as the IN_DEV_PROMOTE_SECONDARIES but realized > it wasn't the same prior

Re: [PATCH] [IPV4] Fix secondary IP addresses after promotion

2005-11-22 Thread Brian Pomerantz
On Tue, Nov 22, 2005 at 08:01:07AM -0500, jamal wrote: > > Ok, here it is with the change to check the sysctl once. > > Brian, can you retest on your side - my basic tests pass. > If it passes, just respond with an acked-by comment. > > Dave, if (ACK from Brian && no further comments) please ap

Re: [PATCH] [IPV4] Fix secondary IP addresses after promotion

2005-11-22 Thread Brian Pomerantz
On Tue, Nov 22, 2005 at 01:46:26PM -0500, jamal wrote: > > Hrm - this was not in the patch i posted. Are you sure this passed the > test? > What the above does is say we are going to record the last primary only > if we are _not_ doing promotion. The reverse of what i would expect. > Hmm...I thi

Re: [PATCH] [IPV4] Fix secondary IP addresses after promotion

2005-11-22 Thread jamal
On Tue, 2005-22-11 at 10:29 -0800, Brian Pomerantz wrote: > On Tue, Nov 22, 2005 at 08:01:07AM -0500, jamal wrote: > > > > Ok, here it is with the change to check the sysctl once. > > > > Brian, can you retest on your side - my basic tests pass. > > If it passes, just respond with an acked-by co

Re: [PATCH] [IPV4] Fix secondary IP addresses after promotion

2005-11-22 Thread Brian Pomerantz
On Tue, Nov 22, 2005 at 08:01:07AM -0500, jamal wrote: > > Ok, here it is with the change to check the sysctl once. > > Brian, can you retest on your side - my basic tests pass. > If it passes, just respond with an acked-by comment. > > Dave, if (ACK from Brian && no further comments) please ap

Re: [ANNOUNCE] iproute2 2.6.14-051107

2005-11-22 Thread Stephen Hemminger
On Tue, 22 Nov 2005 04:50:45 +0100 Patrick McHardy <[EMAIL PROTECTED]> wrote: > Antonio Dias wrote: > > Patrick McHardy <[EMAIL PROTECTED]> wrote: > > > >>It was broken in a CVS version, not sure if it ever was released. No one > >>wants to remove it. > > > > > > Alright but... it was removed!

[PATCH 2.6.16] safer ipv4 reassembly

2005-11-22 Thread Arthur Kepner
Another spin of Herbert Xu's "safer ip reassembly" patch for 2.6.16. (The original patch is here: http://marc.theaimsgroup.com/?l=linux-netdev&m=112281936522415&w=2 and my only contribution is to have tested it.) This patch (optionally) does additional checks before accepting IP fragments, which

Re: [PATCH 02/10]: [NETFILTER]: Defer fragmentation in ip_output when connection tracking is used

2005-11-22 Thread Harald Welte
On Tue, Nov 22, 2005 at 09:17:29AM +0100, Patrick McHardy wrote: > >>I've CCed Harald for his opinion in case I missed something. > >I don't think you've missed something. I agree that the features you > >pointed out seem to be useful and/or important. > > I hope you meant to write "don't seem t

Re: UNM NIC driver

2005-11-22 Thread Jeff Garzik
On Tue, Nov 22, 2005 at 05:29:58PM +0530, Amit Kale wrote: > It's a 10G NIC. There are Tx / Rx descriptor rings (sizes etc. are described > in the header files). It supports MSI interrupts; can do hardware checksums > and LSO. Was looking in terms of hardware doc availability... Jeff

[PATCH] [IPV4] Fix secondary IP addresses after promotion

2005-11-22 Thread jamal
Ok, here it is with the change to check the sysctl once. Brian, can you retest on your side - my basic tests pass. If it passes, just respond with an acked-by comment. Dave, if (ACK from Brian && no further comments) please apply Also, same comment applies as before; this is a bug fix and you m

Re: [Bonding-devel] Re: [PATCH] fix ifenslave to not fail on lack of IP information

2005-11-22 Thread Neil Horman
On Tue, Nov 22, 2005 at 07:19:19PM +0900, Sugihara Tomoe wrote: > > Hi, > > I have the same problem as Mr. Horman mentioned, using > latest /Documentation/networking/ifenslave.c. > I think the patch: > > http://galileo.gamepoint.com.au/pub/linux/kernel/people/akpm/patches/2.6/2.6.3-rc1/2.6.3-

Re: [PATCH 05/13]: [IPV4/6]: Netfilter IPsec output hooks

2005-11-22 Thread Herbert Xu
On Tue, Nov 22, 2005 at 09:31:39PM +1100, herbert wrote: > > Unfortunately it looks like gcc 3.3.5 at least is too dumb to optimise > it away. I think we'll need a better strategy. OK, the idea is still the same: Move the loop from dst_output into xfrm4_output/xfrm6_output since they're the only

Re: UNM NIC driver

2005-11-22 Thread Amit Kale
Hi Jeff, It's a 10G NIC. There are Tx / Rx descriptor rings (sizes etc. are described in the header files). It supports MSI interrupts; can do hardware checksums and LSO. -Amit On Monday 21 Nov 2005 9:43 pm, Jeff Garzik wrote: > On Mon, Nov 21, 2005 at 08:08:32AM -0800, Amit S. Kale wrote: >

Re: [PATCH 05/13]: [IPV4/6]: Netfilter IPsec output hooks

2005-11-22 Thread Herbert Xu
On Tue, Nov 22, 2005 at 09:30:38PM +1100, herbert wrote: > > the need to return control to dst_output. The only reason for > dst_output to exist is to handle compilers that can't optimise away > tail calls. So if we are going to rely on the compiler to do away > with tail calls (ip_dst_output <->

Re: [PATCH 05/13]: [IPV4/6]: Netfilter IPsec output hooks

2005-11-22 Thread Herbert Xu
On Tue, Nov 22, 2005 at 05:53:35AM +0100, Patrick McHardy wrote: > > This looks nice, but placing the hooks at the end of the xfrm[46] > functions doesn't work with queueing without recursively calling > dst_output (as okfn) since we have to provide an okfn but also > have to return ownership of t

Re: [Bonding-devel] Re: [PATCH] fix ifenslave to not fail on lack of IP information

2005-11-22 Thread Sugihara Tomoe
Hi, I have the same problem as Mr. Horman mentioned, using latest /Documentation/networking/ifenslave.c. I think the patch: http://galileo.gamepoint.com.au/pub/linux/kernel/people/akpm/patches/2.6/2.6.3-rc1/2.6.3-rc1-mm1/broken-out/linus.patch caused this problem. Could you spend a short tim

Re: [PATCH 02/10]: [NETFILTER]: Defer fragmentation in ip_output when connection tracking is used

2005-11-22 Thread Patrick McHardy
Harald Welte wrote: On Thu, Nov 17, 2005 at 03:28:24AM +0100, Patrick McHardy wrote: - CLASSIFY fragments differently - MARK fragments differently - DSCP/ECN/TOS mark fragments differently - Change TTLs of fragments to differently values [...] I've CCed Harald for his opinion in case I mis