Re: [DEBUG INFO]IPv6: sleeping function called from invalid context.

2005-11-19 Thread Herbert Xu
On Sat, Nov 19, 2005 at 10:04:11PM +0100, Thomas Graf wrote: > > The continued dumps wouldn't be the problem, the walker is allocated > on the initial dump call. It was a mistake though, nlk->cb_lock spin > lock is always held for cb->dump() even though it should only be > required during the nlk-

Re: build bug: ipt_CONNMARK.c: undefined reference to `need_ip_conntrack'

2005-11-19 Thread Harald Welte
On Sun, Nov 20, 2005 at 04:30:18AM +0900, Yasuyuki KOZAKAI wrote: > Thanks for report. Could you check this patch ? thanks, applied and forwarded. -- - Harald Welte <[EMAIL PROTECTED]> http://netfilter.org/ =

[PATCH 1/1] [NETFILTER] fixed dependencies between modules related with ip_conntrack

2005-11-19 Thread Harald Welte
[NETFILTER] fixed dependencies between modules related with ip_conntrack - IP_NF_CONNTRACK_MARK is bool and depends on only IP_NF_CONNTRACK which is tristate. If a variable depends on IP_NF_CONNTRACK_MARK and doesn't care about IP_NF_CONNTRACK, it can be y. This must be avoided. - IP_NF_CT_ACC

Re: build bug: ipt_CONNMARK.c: undefined reference to `need_ip_conntrack'

2005-11-19 Thread Krzysztof Halasa
Yasuyuki KOZAKAI <[EMAIL PROTECTED]> writes: >> LD init/built-in.o >> LD .tmp_vmlinux1 >> net/built-in.o(.init.text+0x1adb): In function `init': >> ipt_CONNMARK.c: undefined reference to `need_ip_conntrack' >> make[2]: *** [.tmp_vmlinux1] Error 1 >> >> Last merged Linus' git: b286e3

Re: [DEBUG INFO]IPv6: sleeping function called from invalid context.

2005-11-19 Thread Thomas Graf
* Herbert Xu <[EMAIL PROTECTED]> 2005-11-19 22:48 > Thomas Graf <[EMAIL PROTECTED]> wrote: > > > > I did. I think it was right, why would an allocation be necessary on > > the second call to inet6_dump_fib()? The walker allocated in process > > context on the first call should be reused from cb->a

Re: [RFC: 2.6 patch] remove drivers/net/tulip/xircom_tulip_cb.c

2005-11-19 Thread Adrian Bunk
On Fri, Nov 18, 2005 at 05:34:18PM -0500, Mark Lord wrote: > Adrian Bunk wrote: > >This patch removes the obsolete drivers/net/tulip/xircom_tulip_cb.c > >driver. > > > >Is there any reason why it should be kept? > > Yes. It is the only driver that works > without lockups on Xircom Cardbus cards.

Re: [RFC: 2.6 patch] remove drivers/net/eepro100.c

2005-11-19 Thread Adrian Bunk
On Fri, Nov 18, 2005 at 11:12:28AM -0500, Jeff Garzik wrote: > Russell King wrote: > >On Fri, Nov 18, 2005 at 04:33:02AM +0100, Adrian Bunk wrote: > > > >>This patch removes the obsolete drivers/net/eepro100.c driver. > >> > >>Is there any reason why it should be kept? > > > > > >Tt's the only driv

[2.6 patch] drivers/net/Kconfig: indentation fix

2005-11-19 Thread Adrian Bunk
This patch fixes a wrong indentation. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.15-rc1-mm2-full/drivers/net/Kconfig.old 2005-11-19 04:03:27.0 +0100 +++ linux-2.6.15-rc1-mm2-full/drivers/net/Kconfig 2005-11-19 04:03:38.0 +0100 @@ -129,7 +129,7 @@

[FIB_TRIE]: Don't show local table in /proc/net/route output

2005-11-19 Thread Patrick McHardy
[FIB_TRIE]: Don't show local table in /proc/net/route output Don't show local table to behave similar to fib_hash. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 6efbda1db6604dfa69d0626b841a97d394d9db80 tree 9f9e4c5c45a4eeb3e37bc4135e50e2f735b57d56 parent 811803c5572b296e0031e009

Re: build bug: ipt_CONNMARK.c: undefined reference to `need_ip_conntrack'

2005-11-19 Thread Yasuyuki KOZAKAI
From: Krzysztof Halasa <[EMAIL PROTECTED]> Date: Sat, 19 Nov 2005 18:14:32 +0100 > LD init/built-in.o > LD .tmp_vmlinux1 > net/built-in.o(.init.text+0x1adb): In function `init': > ipt_CONNMARK.c: undefined reference to `need_ip_conntrack' > make[2]: *** [.tmp_vmlinux1] Error 1 > > L

Re: [patch 0/3] Minor atmel driver changes

2005-11-19 Thread John W. Linville
On Sat, Nov 19, 2005 at 01:16:53AM -0500, Dmitry Torokhov wrote: > Have a couple of minor changes for atmel wireless driver, please > consider applying. Is there a 3/3? I only got 1 & 2... -- John W. Linville [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev"

build bug: ipt_CONNMARK.c: undefined reference to `need_ip_conntrack'

2005-11-19 Thread Krzysztof Halasa
Hi, FYI: ... LD init/built-in.o LD .tmp_vmlinux1 net/built-in.o(.init.text+0x1adb): In function `init': ipt_CONNMARK.c: undefined reference to `need_ip_conntrack' make[2]: *** [.tmp_vmlinux1] Error 1 Last merged Linus' git: b286e39207237e2f6929959372bf66d9a8d05a82 (i.e., current 2.

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-19 Thread jamal
Hi Stefan, I looked at the patch and while there are some stylistic/implementation differences between us, I think generally all the concepts seem to be in place. So we are almost there. More comments below: On Fri, 2005-18-11 at 21:52 +0100, Stefan Rompf wrote: > This is the data flow: > > -D

Re: [git patches] 2.6.x net driver fixes

2005-11-19 Thread Francois Romieu
Jeff Garzik <[EMAIL PROTECTED]> : [...] > Andrew Morton: > git-netdev-all-ieee80211_get_payload-warning-fix > > Francois Romieu: > r8169: fix printk_ratelimit in the interrupt handler Actually Andrew Morton should be credited for this one as the Signed-of-by lines suggests it. I messe

Re: [DEBUG INFO]IPv6: sleeping function called from invalid context.

2005-11-19 Thread Herbert Xu
Thomas Graf <[EMAIL PROTECTED]> wrote: > > I did. I think it was right, why would an allocation be necessary on > the second call to inet6_dump_fib()? The walker allocated in process > context on the first call should be reused from cb->args[0]. Continued dumps are always called under spin lock (

VLAN and bridging with xen

2005-11-19 Thread Lee Causier
-- Forwarded message -- From: Lee Causier <[EMAIL PROTECTED]> Date: Nov 19, 2005 11:36 AM Subject: Re: VLAN and bridging with xen To: Greg Brackley <[EMAIL PROTECTED]> Sorry to top post, but I've found that my network cards don't like frames > 1500, and so I've had to set the MTU

[PATCH 2.6.16 1/2] [NETFILTER] Remove ARRAY_SIZE duplicate

2005-11-19 Thread Harald Welte
[NETFILTER] Remove ARRAY_SIZE duplicate Signed-off-by: Nicolas Kaiser <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PROTECTED]> --- commit 51adb61d04319997b7d29a61efc47865ceb2a8bd tree 9daf8ac5bd2b81e0ae47e8493e6b77dbe795dcb6 parent 35e5f6a3bc5d11c5b93c89ecd10c1fca40c8bdfb author Nicola

[PATCH 2.6.16 2/2] [NETFILTER] nf_conntrack: replace handmade list with hlist in IPv6 reassembly

2005-11-19 Thread Harald Welte
[NETFILTER] nf_conntrack: replace handmade list with hlist in IPv6 reassembly nf_ct_frag6_queue has *next and **prev, so they can be replaced with hlist. Thanks Arnaldo Carvalho de Melo for the suggestion. Signed-off-by: Yasuyuki Kozakai <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PRO

[PATCH] NETFILTER arp_tables: Fix NUMA optimization

2005-11-19 Thread Harald Welte
Hi Dave! On Fri, Nov 18, 2005 at 04:00:43PM -0800, David S. Miller wrote: > I've put the patch into the net-2.6.16 tree with the obvious > fix Eric points out. There's another one that I detected while merging those changes with x_tables (painful). Please merge: [NETFILTER] arp_tables: Fix bu

Re: [PATCH] [RFT] ip_tables NUMA optimization

2005-11-19 Thread Harald Welte
On Fri, Nov 18, 2005 at 04:00:43PM -0800, David S. Miller wrote: > > It should probably use vfree() like : > > > > > +for_each_cpu(cpu) { > > > +if (info->size <= PAGE_SIZE) > > > +kfree(info->entries[cpu]); > > > +else > > > +