Re: [RFC: 2.6 patch] remove ISA legacy functions

2005-11-15 Thread Al Viro
On Sat, Nov 12, 2005 at 01:48:20PM +, Al Viro wrote: > On Fri, Nov 11, 2005 at 10:29:18PM -0700, Matthew Wilcox wrote: > > I think they work fine everywhere. Adrian wants to remove the API they > > use. > > > > I think this is a bad idea. The drivers should be converted. > > They are - I'll

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-15 Thread jamal
On Tue, 2005-15-11 at 21:18 +0100, Stefan Rompf wrote: > Am Dienstag 15 November 2005 04:19 schrieb jamal: > > > 1) I think we need to separate the oper state from the rest; so > > no need to add dormant to be in netdev_state_t. > > ok, it seems that everybody else wants to go with state flags.

Re: [Bug 5610] New: IP MTU Path Discovery now working properly

2005-11-15 Thread Andi Kleen
On Wednesday 16 November 2005 01:45, David S. Miller wrote: > > Alternatively, we're ignoring the PMTU message for one reason or > another. Perhaps the quoted TCP packet in the ICMP pmtu message > has an incorrect sequence number or is truncated for some reason. There are counters for all of th

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-15 Thread jamal
On Tue, 2005-15-11 at 20:36 -0500, jamal wrote: > > * The first thing you do is configure the netdevice to the admin mode of > operation. This is very close to what BSD (and some vendors) allow for > sync PPP (I will try to find a url or look up ifconfig man pages on > BSD). IOW, you do this when

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-15 Thread jamal
On Tue, 2005-15-11 at 21:22 +0100, Krzysztof Halasa wrote: > Stefan Rompf <[EMAIL PROTECTED]> writes: > > > This is because you don't give a damn about anything that goes beyond > > your WAN > > drivers. > > False statement. I am afraid I would have to agree with Stefan on this Krzysztof. You a

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-15 Thread jamal
On Tue, 2005-15-11 at 20:28 +0100, Stefan Rompf wrote: > Am Dienstag 15 November 2005 15:16 schrieb jamal: > > > Having said that, perhaps thats where the concept of useroverride you > > have or IFF_WAIT needs to go. What should be done though is to select an > > "operational" mode via admin flags

Re: [Bug 5610] New: IP MTU Path Discovery now working properly

2005-11-15 Thread Herbert Xu
David S. Miller <[EMAIL PROTECTED]> wrote: > > Alternatively, we're ignoring the PMTU message for one reason or > another. Perhaps the quoted TCP packet in the ICMP pmtu message > has an incorrect sequence number or is truncated for some reason. That's what I think too. Can we please get the sa

Re: [PATCH]small fix for __ipv6_addr_type(...)

2005-11-15 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 15 Nov 2005 17:20:50 -0500), Vlad Yasevich <[EMAIL PROTECTED]> says: > No, according to RFC 4007, loopback is considered a link-local > address. Agreed. RFC3484 also explicitly says that loopback is treated as link-local. --yoshfuji - To unsubscribe from

Re: [PATCH 2/2] [NETFILTER] Free layer-3 specific protocol tables at cleanup

2005-11-15 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Tue, 15 Nov 2005 17:16:09 +0100 > [NETFILTER] Free layer-3 specific protocol tables at cleanup > > Although the comment around the allocation code tells us that > the layer-3 specific protocol tables will be freed when cleaning up, > they aren't. And t

Re: [PATCH 1/2] [NETFILTER] Remove nf_conntrack stat proc file when cleaning up

2005-11-15 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Tue, 15 Nov 2005 17:16:09 +0100 > [NETFILTER] Remove nf_conntrack stat proc file when cleaning up > > Fix nf_conntrack statistics proc file removal. Looks like the old bug > was forward-ported from ip_conntrack. :-] > > Signed-off-by: KOVACS Krisztian

Re: [Bug 5610] New: IP MTU Path Discovery now working properly

2005-11-15 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 15 Nov 2005 16:29:40 -0800 > 161.30.105.72.ftp-data > 192.168.128.101.32792: . ack 1 win 64000 > 192.168.128.101.32792 > 161.30.105.72.ftp-data: . 1:1381(1380) ack 1 win 5840 > 192.168.128.101.32792 > 161.30.105.72.ftp-data: . 1381:2761(1380)

Fw: [Bug 5610] New: IP MTU Path Discovery now working properly

2005-11-15 Thread Stephen Hemminger
Begin forwarded message: > Date: Tue, 15 Nov 2005 03:01:49 -0800 > From: [EMAIL PROTECTED] > To: [EMAIL PROTECTED] > Subject: [Bug 5610] New: IP MTU Path Discovery now working properly > > > http://bugzilla.kernel.org/show_bug.cgi?id=5610 > >Summary: IP MTU Path Discovery now work

Re: [PATCH 7/8] tcp: spelling fixes

2005-11-15 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 15 Nov 2005 15:09:52 -0800 > More spelling fixes. From Joe Perches > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTE

Fw: [PATCH 7/8] tcp: spelling fixes

2005-11-15 Thread Stephen Hemminger
More spelling fixes. From Joe Perches Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> diff --git a/include/net/tcp.h b/include/net/tcp.h index 0f98480..d78025f 100644 --- a/include/net/tcp.h +++ b/include/net/tcp.h @@ -552,8 +552,8 @@ extern u32 __tcp_select_window(struct so /* TCP times

Re: [PATCH 2.6.14] bonding: fix feature consolidation

2005-11-15 Thread Krzysztof Oledzki
On Fri, 4 Nov 2005, Jay Vosburgh wrote: This should resolve http://bugzilla.kernel.org/show_bug.cgi?id=5519 The current feature computation loses bits that it doesn't know about, resulting in an inability to add VLANs and possibly other havoc. Rewrote function to preserve bit

Re: [PATCH]small fix for __ipv6_addr_type(...)

2005-11-15 Thread Vlad Yasevich
No, according to RFC 4007, loopback is considered a link-local address. -vlad Yan Zheng wrote: > Hi. > > I think the scope for loopback address should be node local. > > Regards > > Signed-off-by: Yan Zheng <[EMAIL PROTECTED]> > > ==

Re: [BRIDGE]: recompute features after adding new device

2005-11-15 Thread Olaf Rempel
On Tue, 15 Nov 2005 22:53:19 +0100 Olaf Rempel <[EMAIL PROTECTED]> wrote: gnaa, typo. should be "br" not "br0" Olaf > [BRIDGE]: recompute features after adding a new device > > We must recompute bridge features everytime the list of underlying > devices changes, or we might end up with featur

[BRIDGE]: recompute features after adding new device

2005-11-15 Thread Olaf Rempel
[BRIDGE]: recompute features after adding a new device We must recompute bridge features everytime the list of underlying devices changes, or we might end up with features that are not supported by all devices. This adds the missing recompute when adding a device to the bridge. Sign-off-by: Olaf

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-15 Thread Krzysztof Halasa
Stefan Rompf <[EMAIL PROTECTED]> writes: >> I even responded to it. Show me where he requests anything similar to >> operstate_useroverride or IFF_WAIT? > > operstate_useroverride or IFF_WAIT are possible solutions to [Jouni's mail] For now they are just broken and that haven't changed since the

Re: Fw: [BUG] kernel 2.6.14.2 breaks IPSEC

2005-11-15 Thread Charles-Edouard Ruault
Herbert Xu wrote: On Tue, Nov 15, 2005 at 08:12:15AM +, Charles-Edouard Ruault wrote: i've just tried and i'm still getting the two MSB bytes ( in storage order , i.e the two LSB bytes in network byte order) of the SPI being corrupted. Let me know if you need any other info from me.

Re: Fw: [BUG] kernel 2.6.14.2 breaks IPSEC

2005-11-15 Thread Charles-Edouard Ruault
Herbert Xu wrote: On Wed, Nov 16, 2005 at 07:37:29AM +1100, herbert wrote: Could you please try turning of hardware TX checksum using ethtool? Please also give me a strace of your ping command. Thanks, here you go: execve("/bin/ping", ["ping", "10.0.0.10"], [/* 43 vars */]) = 0 br

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-15 Thread Stefan Rompf
Am Dienstag 15 November 2005 21:22 schrieb Krzysztof Halasa: > I even responded to it. Show me where he requests anything similar to > operstate_useroverride or IFF_WAIT? operstate_useroverride or IFF_WAIT are possible solutions to -handle this part of Jouni's mail: > [...] > however, this woul

Re: Fw: [BUG] kernel 2.6.14.2 breaks IPSEC

2005-11-15 Thread Herbert Xu
On Wed, Nov 16, 2005 at 07:37:29AM +1100, herbert wrote: > > Could you please try turning of hardware TX checksum using ethtool? Please also give me a strace of your ping command. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: h

Re: Fw: [BUG] kernel 2.6.14.2 breaks IPSEC

2005-11-15 Thread Herbert Xu
On Tue, Nov 15, 2005 at 08:12:15AM +, Charles-Edouard Ruault wrote: > > i've just tried and i'm still getting the two MSB bytes ( in storage > order , i.e the two LSB bytes in network byte order) of the SPI being > corrupted. > Let me know if you need any other info from me. Could you please

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-15 Thread Krzysztof Halasa
Stefan Rompf <[EMAIL PROTECTED]> writes: > This is because you don't give a damn about anything that goes beyond > your WAN > drivers. False statement. > Look at <[EMAIL PROTECTED]> from Jouni Malinen, posted > to the list. I even responded to it. Show me where he requests anything similar to

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-15 Thread Stefan Rompf
Am Dienstag 15 November 2005 04:19 schrieb jamal: > 1) I think we need to separate the oper state from the rest; so > no need to add dormant to be in netdev_state_t. ok, it seems that everybody else wants to go with state flags. Even though I'm not convinced, I should accept this and therefore T

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-15 Thread Krzysztof Halasa
Stefan Rompf <[EMAIL PROTECTED]> writes: > Please reread what is written about locking in net/core/dev.c. It has > looked a > bit strange to me, too, when I needed to use it for the first time, but my > code does the right thing here. Remember, linkwatch_fire_event() is _NOT_ a > pure reader.

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-15 Thread Stefan Rompf
Am Dienstag 15 November 2005 15:16 schrieb jamal: > Having said that, perhaps thats where the concept of useroverride you > have or IFF_WAIT needs to go. What should be done though is to select an > "operational" mode via admin flags - example "the device is set by the > admin to dormant state" or

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-15 Thread Stefan Rompf
Am Dienstag 15 November 2005 18:54 schrieb Krzysztof Halasa: > > You said the same to Thomas on IFF_WAIT. Both operstate_useroverride and > > IFF_WAIT exist to allow userspace 802.1X/wpa supplicant interaction. > > Are we sure about this? It might be the case but I don't think I've seen > such req

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-15 Thread Stefan Rompf
Am Dienstag 15 November 2005 17:41 schrieb Krzysztof Halasa: > > * The @dev_base list is protected by @dev_base_lock and the rtln > > * semaphore. > > * > > * Pure readers hold dev_base_lock for reading. > > * > > * Writers must hold the rtnl semaphore while they loop through the > > * dev_

[PATCH] ebtables: port ebt*[u]log.c to nf[netlink]_log

2005-11-15 Thread Bart De Schuymer
Hi Dave, Below is a patch from Harald, slightly altered by me to merge some printk's. Please apply, Bart [NETFILTER] ebtables: Support nf_log API from ebt_log and ebt_ulog This makes ebt_log and ebt_ulog use the new nf_log api. This enables the bridging packet filter to log packets e.g. via n

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-15 Thread Krzysztof Halasa
jamal <[EMAIL PROTECTED]> writes: > 1) I dont think operstare_useroverride is needed. I don't either. We should ask potential users, though - doing things we think are best but nobody is going to use is nonsense. > a) We need new flags which get reflected to user space; i.e new IFF_XXX > flags.

Re: TCPXM

2005-11-15 Thread Stephen Hemminger
On Tue, 15 Nov 2005 06:29:01 -0200 Alan Menegotto <[EMAIL PROTECTED]> wrote: > Hi. > > I'm doing a graduation research where the goal is create a new protocol > in the linux kernel. The protocol choosen was TCPXM, an hybrid reliable > sender-initiated multicast/unicast aimed for small environment

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-15 Thread Krzysztof Halasa
Stefan Rompf <[EMAIL PROTECTED]> writes: > You said the same to Thomas on IFF_WAIT. Both operstate_useroverride and > IFF_WAIT exist to allow userspace 802.1X/wpa supplicant interaction. Are we sure about this? It might be the case but I don't think I've seen such request. -- Krzysztof Halasa -

Re: [PATCH 8/8] tcp: sack fastpath

2005-11-15 Thread Stephen Hemminger
On Mon, 14 Nov 2005 17:46:24 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] a écrit : > > Use hits to speed up the SACK processing. Various forms > > of this have been used by TCP developers (Web100, STCP, BIC) > > to avoid the 2x linear search of outstanding segments. > > > >

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-15 Thread Krzysztof Halasa
Stefan Rompf <[EMAIL PROTECTED]> writes: > as described in net/core/dev.c: > > * The @dev_base list is protected by @dev_base_lock and the rtln > * semaphore. > * > * Pure readers hold dev_base_lock for reading. > * > * Writers must hold the rtnl semaphore while they loop through the > * de

Re: [PATCH netdev-2.6 1/3] ixgb: TSO fixes

2005-11-15 Thread Jesse Brandeburg
On Tue, 15 Nov 2005, Anton Blanchard wrote: > TSO fixes > - fix rare early completion when using TSO > - extra descriptor for the sentinel descriptor Is this the same bug as e1000? The extra DMA descriptor is going to be costly, especially on 10Gb. Would the e1000_unmap_and_free_tx_resource tric

[PATCH 1/2] [NETFILTER] Remove nf_conntrack stat proc file when cleaning up

2005-11-15 Thread Harald Welte
[NETFILTER] Remove nf_conntrack stat proc file when cleaning up Fix nf_conntrack statistics proc file removal. Looks like the old bug was forward-ported from ip_conntrack. :-] Signed-off-by: KOVACS Krisztian <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PROTECTED]> --- commit e37f2398f

[PATCH 2/2] [NETFILTER] Free layer-3 specific protocol tables at cleanup

2005-11-15 Thread Harald Welte
[NETFILTER] Free layer-3 specific protocol tables at cleanup Although the comment around the allocation code tells us that the layer-3 specific protocol tables will be freed when cleaning up, they aren't. And this makes nfsim complain loudly... Signed-off-by: KOVACS Krisztian <[EMAIL PROTECTED]>

Re: [PATCH 00/10]: Netfilter IPsec support

2005-11-15 Thread Marco Berizzi
How are handled NAT-T packets (udp/4500) with these patches? Patrick McHardy wrote: On Fri, 11 Nov 2005, Gerd v. Egidy wrote: Hi, This is the latest set patches for netfilter IPsec support. The use of netif_rx for the innermost SA if it used transport mode has been replaced by explicit NF_

Re: [PATCH netdev-2.6 1/3] ixgb: TSO fixes

2005-11-15 Thread Anton Blanchard
Hi, > TSO fixes > - fix rare early completion when using TSO > - extra descriptor for the sentinel descriptor Is this the same bug as e1000? The extra DMA descriptor is going to be costly, especially on 10Gb. Would the e1000_unmap_and_free_tx_resource trick used in e1000 work instead? (Actually

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-15 Thread jamal
On Tue, 2005-15-11 at 08:02 -0500, jamal wrote: > I didnt see this issue as any different than setting any other current > netdevice flags which goes via dev_change_flags; i gave the example of > IFF_UP in my email because it sets the dev->state (invoked via > dev->open/close). In the case of user

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-15 Thread jamal
On Tue, 2005-15-11 at 08:17 +0100, Stefan Rompf wrote: > Am Dienstag 15 November 2005 03:43 schrieb jamal: > > I'll have more time for a comment this evening, but let me ask one question > until then: > > > 1) I dont think operstare_useroverride is needed. > > You said the same to Thomas on IFF

Re: [PATCH 02/10]: [NETFILTER]: Defer fragmentation in ip_output when connection tracking is used

2005-11-15 Thread Herbert Xu
On Fri, Nov 11, 2005 at 03:19:17AM +, Patrick McHardy wrote: > [NETFILTER]: Defer fragmentation in ip_output when connection tracking is used > > This allows to get rid of the okfn use in ip_refrag and save the useless > fragmentation/defragmentation step when NAT is used. I'm slightly uneas

[PATCH 1/1] [NETFILTER] ip_conntrack: fix ftp/irc/tftp helpers on ports >= 32768

2005-11-15 Thread Harald Welte
[NETFILTER] ip_conntrack: fix ftp/irc/tftp helpers on ports >= 32768 Since we've converted the ftp/irc/tftp helpers to use the new module_parm_array() some time ago, we ware accidentially using signed data types - thus preventing those modules from being used on ports >= 32768. This patch fixes i

Re: Pull request for bonding-sysfs branch of netdev-jwl

2005-11-15 Thread Jeff Garzik
John W. Linville wrote: Jeff, These are the sysfs changes for the bonding driver. I put them in a separate branch for a couple of reasons. For one, I had to massage a few of the patches, and some of them had fuzz. So, it would be good for Mitch and/or Jay to double-check the merge. Also, I t

Re: Fw: [BUG] kernel 2.6.14.2 breaks IPSEC

2005-11-15 Thread Charles-Edouard Ruault
Herbert Xu wrote: >Andrew Morton <[EMAIL PROTECTED]> wrote: > > >>So far, i've looked into net/ipv4/esp4.c and i can confirm that the >>correct spi has been selected and inserted into the packet in function >>esp_output >>esph->spi = x->id.spi; ( line 97 ). >>It looks as if the corruption happ