On Tue, 2005-15-11 at 21:18 +0100, Stefan Rompf wrote: > Am Dienstag 15 November 2005 04:19 schrieb jamal: > > > 1) I think we need to separate the oper state from the rest; so > > no need to add dormant to be in netdev_state_t. > > ok, it seems that everybody else wants to go with state flags.
I am not sure i followed your comment above. I was referring to the fact that we need dev->operstate_kernel; the comment to Thomas above was on the fact he added the dormant state to dev->state. Are we still talking about the same thing? > Even though I'm > not convinced, I should accept this and therefore Thomas' patch should be the > base for continued work. I can concentrate on userspace dormant interaction > as I use WPA everyday and know people that can test 802.1X. > Please dont rush judgement - we still need you ;-> Like i said so far: I see a hybrid patch - yours and Thomas. We need your approach for internal kernel state. You say there is a race; i didnt see it if you go with the admin configuration of modes. It is possible still that we are saying the same thing. I will not respond to the rest of your email - I wanna make sure we are in sync first on the above. So let me summarize: 1) There are read_only oper state IFF_XXX flags which are sent via netlink to user space. These are set by the kernel (and not by user space); they reflect the state of "link". * We already have IFF_RUNNING which represents UP or DOWN * we need to add the rest which make sense example: Linklayerdown, dormant etc. 2) There are read/write admin IFF_XXX flags which are used to select the link-oper mode. I made some suggestions in the earlier email and referenced the BSD man pages. By default the state transition is from Down<->UP. A mode could be selected to set a device so it goes from Down<->Dormant. The meaning/semantics of "dormant" is netdevice specific. It could be dial-on-demand for applicable devices, auth-in-progress for 802.1x etc. I think this is what you mean by useroverride you had. IF you have these and you follow the change_flags path, I dont see the races; but dont wanna discount them. Lets prove that they will happen. Now, on the other hand perhaps we do need to have a separate dev->adminstate since 2863 infact does add some new states like testing. 3) There is a kernel dev->operstate_kernel which is accessible via user space in the same manner IFF_UP flags are set etc. Lets get in sync with the above first. cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
