Re: [patch 0/3] bnx2: minor fixes (take #2)

2005-11-09 Thread Jeff Garzik
John W. Linville wrote: Still just a trio of minor fixes for bnx2. The third patch in this series is based on a suggested fix from Michael Chan. Individual patches to follow. If more convenient, you can pull from the linville-bnx2 branch of netdev-jwl as described below. Thanks, John --- T

Re: Consensus? WAS(RFC 2863)

2005-11-09 Thread Stefan Rompf
Am Donnerstag 10 November 2005 01:10 schrieb Thomas Graf: just one short comment, I'll have more time this evening: > > But if you made the driver the proxy for making the state transitions we > > should be fine, no? > > I would absolutely appreciate a solution where no driver has to be > changed

Re: [patch 3/3] bnx2: avoid possible overflows in bnx2_get_eeprom

2005-11-09 Thread John W. Linville
On Wed, Nov 09, 2005 at 12:13:10PM -0800, Michael Chan wrote: > On Wed, 2005-11-09 at 16:39 -0500, John W. Linville wrote: > > Avoid possible overflows when validating eeprom->offset and eeprom->len > > against bp->flash_info->total_size in bnx2_get_eeprom. > > > It looks like net/core/ethtool.c a

[patch 1/3] bnx2: output driver name as prefix in error message

2005-11-09 Thread John W. Linville
Output driver name as prefix to "Unknown flash/EEPROM type." message. Signed-off-by: John W. Linville <[EMAIL PROTECTED]> --- drivers/net/bnx2.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) applies-to: 841d5e5eeda46fd95ac03c36964919818a9bc3a6 b03c1f78b764a13a291c26f50f98125cbb7c

[patch 0/3] bnx2: minor fixes (take #2)

2005-11-09 Thread John W. Linville
Still just a trio of minor fixes for bnx2. The third patch in this series is based on a suggested fix from Michael Chan. Individual patches to follow. If more convenient, you can pull from the linville-bnx2 branch of netdev-jwl as described below. Thanks, John --- The following changes since

[patch 2/3] bnx2: check return of dev_alloc_skb in bnx2_test_loopback

2005-11-09 Thread John W. Linville
Check return of dev_alloc_skb in bnx2_test_loopback, and handle appropriately. Signed-off-by: John W. Linville <[EMAIL PROTECTED]> --- drivers/net/bnx2.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) applies-to: 465a9eb5187941d84c8eede71d8cdd41cfce0a97 5d5bd2c199f11d3359d29cd689a

[patch 3/3] bnx2: simplify parameter checks in bnx2_{get,set}_eeprom

2005-11-09 Thread John W. Linville
Remove the superfluous parameter checking in bnx2_{get,set}_eeprom. The parameters are already validated in ethtool_{get,set}_eeprom. Signed-off-by: John W. Linville <[EMAIL PROTECTED]> --- drivers/net/bnx2.c | 12 ++-- 1 files changed, 2 insertions(+), 10 deletions(-) applies-to: 03

[PATCH 2/2] [DCCP]: Alter website for DCCP in MAINTAINERS

2005-11-09 Thread Ian McDonald
Website for DCCP is now hosted at OSDL Signed-off-by: Ian McDonald <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS --- a/MAINTAINERS +++ b/MAINTAINERS @@ -707,7 +707,7 @@ DCCP PROTOCOL P: Arnaldo Carvalho de Melo M: [EMAIL PROTECTED] L: dccp@vger.kernel.org -W: http:

[PATCH 1/2] [DCCP] Create Documentation/dccp.txt

2005-11-09 Thread Ian McDonald
This patch is a first go at some documentation. Please advise if gmail has mangled patch and I will revert to an attachment: Signed-off-by: Ian McDonald <[EMAIL PROTECTED]> diff --git a/Documentation/networking/dccp.txt b/Documentation/networking/dccp.txt new file mode 100644 --- /dev/null +++ b/

[PATCH 6/6] [NETLINK]: Generic netlink family

2005-11-09 Thread Thomas Graf
The generic netlink family builds on top of netlink and provides simplifies access for the less demanding netlink users. It solves the problem of protocol numbers running out by introducing a so called controller taking care of id management and name resolving. Generic netlink modules register the

[PATCHSET] Type-safe netlink interface, generic netlink family

2005-11-09 Thread Thomas Graf
Dave, This patchset adds a type-safe netlink interface and the generic netlink family for simplified netlink usage. I did not include any transformations patch as some of them showed issues. The code posted here is tested and already in use by external users (TIPC). - To unsubscribe from this li

[PATCH 2/6] [NETLINK]: Make netlink_callback->done() optional

2005-11-09 Thread Thomas Graf
Most netlink families make no use of the done() callback, making it optional gets rid of all unnecessary dummy implementations. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6/net/netlink/af_netlink.c === --- net-2.6.or

[PATCH 1/6] [NETLINK]: Type-safe netlink messages/attributes interface

2005-11-09 Thread Thomas Graf
Introduces a new type-safe interface for netlink message and attributes handling. The interface is fully binary compatible with the old interface towards userspace. Besides type safety, this interface features attribute validation capabilities, simplified message contstruction, and documentation.

[PATCH 5/6] [RTNETLINK]: Use generic netlink receive queue processor

2005-11-09 Thread Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6/net/core/rtnetlink.c === --- net-2.6.orig/net/core/rtnetlink.c +++ net-2.6/net/core/rtnetlink.c @@ -49,6 +49,7 @@ #include #include #include +#include DECLARE_MUT

[PATCH 4/6] [XFRM]: Use generic netlink receive queue processor

2005-11-09 Thread Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6/net/xfrm/xfrm_user.c === --- net-2.6.orig/net/xfrm/xfrm_user.c +++ net-2.6/net/xfrm/xfrm_user.c @@ -18,7 +18,6 @@ #include #include #include -#include #include #i

[PATCH 3/6] [NETLINK]: Generic netlink receive queue processor

2005-11-09 Thread Thomas Graf
Introduces netlink_run_queue() to handle the receive queue of a netlink socket in a generic way. Processes as much as there was in the queue upon entry and invokes a callback function for each netlink message found. The callback function may refuse a message by returning a negative error code but s

Re: [Fwd: TSO and 2.6.13.2]

2005-11-09 Thread Ben Greear
Jesse Brandeburg wrote: On 11/9/05, Ben Greear <[EMAIL PROTECTED]> wrote: I am frusterated that the linux kernel seems to be unstable for high levels of TCP traffic for very common hardware (e1000). Is anyone doing tests that involve high levels of bi-directional TCP traffic using TSO? If so,

Re: [PATCH 2/2][MCAST] Fix for add_grec(...)

2005-11-09 Thread Yan Zheng
David Stevens wrote: Yan, I think your patch has some problems. Yan Zheng <[EMAIL PROTECTED]> wrote on 11/09/2005 03:58:20 AM: +#if 0 if (!*psf_list) { if (type == MLD2_ALLOW_NEW_SOURCES || type == MLD2_BLOCK_OLD_SOURCES) @@ -1474,12 +1477,15 @@ static struct sk_buf

Re: [Fwd: TSO and 2.6.13.2]

2005-11-09 Thread Jesse Brandeburg
On 11/9/05, Ben Greear <[EMAIL PROTECTED]> wrote: > I am frusterated that the linux kernel seems to be > unstable for high levels of TCP traffic for very common > hardware (e1000). > > Is anyone doing tests that involve high levels of bi-directional > TCP traffic using TSO? If so, please let me kn

Re: Consensus? WAS(RFC 2863)

2005-11-09 Thread Krzysztof Halasa
Thomas Graf <[EMAIL PROTECTED]> writes: > Right, this means we cannot check the carrier state while the interface > is administratively down. Hope the device can set their carrier state while being down and it will be honoured after dev->open()? Otherwise -> trouble. > Maybe we should postpone t

Resend [PATCH] ethtool: Remove Duplex info from CTRL register dump

2005-11-09 Thread Jeff Kirsher
Removes duplex information from the control register dump when ethtool -d is called. The duplex control register is used for setting the driver and is not necessary for debug purposes. The value of the duplex control register is what the register's current value is and may not reflect the correct

Re: [PATCH 1/7] tcp: fix cwnd update when using TSO

2005-11-09 Thread Ian McDonald
> +/* RFC2861 Check whether we are limited by application or congestion window > + * This is the inverse of cwnd check in tcp_tso_should_defer > + */ > +static inline int tcp_may_update_cwnd(const struct sock *sk, u32 in_flight) > + if (sysctl_tcp_tso_win_divisor) > + retur

Re: Consensus? WAS(RFC 2863)

2005-11-09 Thread Krzysztof Halasa
Jamal Hadi Salim <[EMAIL PROTECTED]> writes: > I think if we use the concept of the driver being the proxy then all > requests for state transition go through the driver, no? Why? Would mean spinlocks anyway. I whink we should rather aim for simple things. Especially when they are interrupt-drive

Re: Consensus? WAS(RFC 2863)

2005-11-09 Thread Thomas Graf
* Jamal Hadi Salim <[EMAIL PROTECTED]> 2005-11-09 18:49 > Historically we point such routes to the dummy device. Remember diald > and good ole SLIP dial on demand? I would suspect it should still work > the same way. > Actually, probably use a blackhole route which will swallow such packets > alive

Re: Consensus? WAS(RFC 2863)

2005-11-09 Thread Thomas Graf
> > Index: linux-2.6/net/ipv4/fib_frontend.c > > === > > --- linux-2.6.orig/net/ipv4/fib_frontend.c > > +++ linux-2.6/net/ipv4/fib_frontend.c > > @@ -630,8 +630,13 @@ static int fib_netdev_event(struct notif > > case NETDEV_DOW

Re: Consensus? WAS(RFC 2863)

2005-11-09 Thread Thomas Graf
* Stefan Rompf <[EMAIL PROTECTED]> 2005-11-10 00:09 > + OPER_UNKNOWN = 0, > + OPER_NOTPRESENT, /* unused, placeholder */ > + OPER_DOWN = 16, > + OPER_LOWERLAYERDOWN, > + OPER_TESTING = 32, > + OPER_DORMANTL3DOWN = 48, /* OS queue start from here */ > + OPER

Re: Consensus? WAS(RFC 2863)

2005-11-09 Thread Jamal Hadi Salim
On Thu, 2005-10-11 at 00:38 +0100, Krzysztof Halasa wrote: > Stefan Rompf <[EMAIL PROTECTED]> writes: > > > I think it is valid to define the operational state as one field simply > > due to > > the fact that the driver is solely responsible for it. > > That would be nice but isn't the case. Wit

Re: Consensus? WAS(RFC 2863)

2005-11-09 Thread Jamal Hadi Salim
On Wed, 2005-09-11 at 22:12 +0100, Thomas Graf wrote: > * Jamal Hadi Salim <[EMAIL PROTECTED]> 2005-11-09 15:13 > > The link change notification should be handled by the fib code as if it > > was an admin notification. > > Something like this should do the job, although it doesn't take care > of t

Re: Consensus? WAS(RFC 2863)

2005-11-09 Thread Jamal Hadi Salim
On Wed, 2005-09-11 at 22:02 +0100, Stefan Rompf wrote: > Am Mittwoch 09 November 2005 21:13 schrieb Jamal Hadi Salim: > > 1) In regards to the connected routes: > > - I would agree that there is need to do something about them - but i > > dont think those extra L3* states are the answer. So Stefa

Re: [PATCH 1/7] tcp: fix cwnd update when using TSO

2005-11-09 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 09 Nov 2005 15:06:57 -0800 > TCP peformance with TSO over networks with delay is awful. > On a 100Mbit link with 150ms delay, we get 4Mbits/sec with TSO and > 50Mbits/sec without TSO. > > The problem is with TSO, we intentionally do not keep

Re: [Fwd: TSO and 2.6.13.2]

2005-11-09 Thread David S. Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Wed, 09 Nov 2005 15:39:38 -0800 > I will give it a try..as soon as the next stable point release comes > out..seems there are some networking bug fixes coming soon if I recall > correctly. Just a UDP zero-length transfer bug fix from Herbert, nothing TCP

Re: [Fwd: TSO and 2.6.13.2]

2005-11-09 Thread Ben Greear
David S. Miller wrote: From: Ben Greear <[EMAIL PROTECTED]> Date: Wed, 09 Nov 2005 13:41:02 -0800 So, I am asking the TSO folks: Will you pay any attention to a bug report against 2.6.13.2, or would I just be wasting my time? If the answer is yes, then I'll get on it..otherwise, I'll wait un

Re: Consensus? WAS(RFC 2863)

2005-11-09 Thread Krzysztof Halasa
Stefan Rompf <[EMAIL PROTECTED]> writes: > I think it is valid to define the operational state as one field simply > due to > the fact that the driver is solely responsible for it. That would be nice but isn't the case. With my WAN driver for sure, but I think there are other cases as well. And

Re: [Fwd: TSO and 2.6.13.2]

2005-11-09 Thread David S. Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Wed, 09 Nov 2005 13:41:02 -0800 > So, I am asking the TSO folks: Will you pay any attention to > a bug report against 2.6.13.2, or would I just be wasting my > time? > > If the answer is yes, then I'll get on it..otherwise, I'll wait untill > I move to

[PATCH 6/7] tcp: receive buffer moderation ssthresh

2005-11-09 Thread Stephen Hemminger
This is a patch for discussion addressing some receive buffer growing issues. This is partially related to the thread "Possible BUG in IPv4 TCP window handling..." last week. Specifically it addresses the problem of an interaction between rcvbuf moderation (receiver autotuning) and rcv_ssthresh.

[PATCH 7/7] tcp: SACK fastpath hinting

2005-11-09 Thread Stephen Hemminger
Use hits to speed up the SACK processing. Various forms of this have been used by TCP developers (Web100, STCP, BIC) to avoid the 2x linear search of outstanding segments. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.orig/include/linux/tcp.h +++ net-2.6/include/linux/tcp.h @@

[PATCH 3/7] tcp: rearrange microsecond rtt sampling used by vegas

2005-11-09 Thread Stephen Hemminger
Simplify the code that comuputes microsecond rtt estimate used by TCP Vegas. Move the callback out of the RTT sampler and into the end of the ack cleanup. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.orig/net/ipv4/tcp_input.c +++ net-2.6/net/ipv4/tcp_input.c @@ -548,10 +548,9

[PATCH 0/7] tcp:

2005-11-09 Thread Stephen Hemminger
Set of patches relating to TCP congestion control. * Fixes issues with TSO and not updating cwnd * Simplifies infrastruture callbacks * Add support for Appropriate Byte Counting (RFC3465) * Optimize SACK processing -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemmi

[PATCH 2/7] tcp: make tcp_slow_start function

2005-11-09 Thread Stephen Hemminger
Move all the code that does linear TCP slowstart to one inline function to ease later patch to add ABC support. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.orig/include/net/tcp.h +++ net-2.6/include/net/tcp.h @@ -762,6 +762,16 @@ static inline __u32 tcp_current_ssthresh

[PATCH 1/7] tcp: fix cwnd update when using TSO

2005-11-09 Thread Stephen Hemminger
TCP peformance with TSO over networks with delay is awful. On a 100Mbit link with 150ms delay, we get 4Mbits/sec with TSO and 50Mbits/sec without TSO. The problem is with TSO, we intentionally do not keep the maximum number of packets in flight to fill the window, we hold out to until we can send

Re: Consensus? WAS(RFC 2863)

2005-11-09 Thread Stefan Rompf
Am Mittwoch 09 November 2005 22:25 schrieb Thomas Graf: > > However, L3 > > would lose the possibility to differenciate between a dialer that can > > dial and one that can't. I don't consider this limitation too bad, but it > > would be there and stay for a while. > > Could you elaborate on this,

[PATCH 5/7] tcp: RFC3465 Appropriate Byte Count

2005-11-09 Thread Stephen Hemminger
This is an updated version of the RFC3465 ABC patch originally for Linux 2.6.11-rc4 by Yee-Ting Li. ABC is a way of counting bytes ack'd rather than packets when updating congestion control. The orignal ABC described in the RFC applied to a Reno style algorithm. For advanced congestion control the

Re: [Fwd: TSO and 2.6.13.2]

2005-11-09 Thread Ben Greear
Rick Jones wrote: It appears that I can (almost?) completedly deadlock a TCP connection when using TSO on 2.6.13.2. My test involves trying to send 200Mbps between two interfaces. With TSO enabled (ie, the default for e1000 NICs), in less than 1 minute, there are no more packets transmitted,

Re: Consensus? WAS(RFC 2863)

2005-11-09 Thread Krzysztof Halasa
Stefan Rompf <[EMAIL PROTECTED]> writes: > Currently, IFF_RUNNING is created out of dev->state that is *not* > protected by > any lock as the driver can change it from interrupts. Instead, atomic bit > operations are used. If we allow userspace to write into operstate - either > into independan

Re: [Fwd: TSO and 2.6.13.2]

2005-11-09 Thread Rick Jones
It appears that I can (almost?) completedly deadlock a TCP connection when using TSO on 2.6.13.2. My test involves trying to send 200Mbps between two interfaces. With TSO enabled (ie, the default for e1000 NICs), in less than 1 minute, there are no more packets transmitted, though it does run ni

Re: [PATCH 2/2][MCAST] Fix for add_grec(...)

2005-11-09 Thread David Stevens
Yan, I think your patch has some problems. Yan Zheng <[EMAIL PROTECTED]> wrote on 11/09/2005 03:58:20 AM: > +#if 0 > if (!*psf_list) { >if (type == MLD2_ALLOW_NEW_SOURCES || >type == MLD2_BLOCK_OLD_SOURCES) > @@ -1474,12 +1477,15 @@ static struct sk_buff *add_grec(

Re: [patch 2.6.14 (take #2)] fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx

2005-11-09 Thread John W. Linville
On Mon, Nov 07, 2005 at 01:24:59PM -0500, John W. Linville wrote: > Change CONFIG_FEC_8XX to depend on CONFIG_8xx instead of CONFIG_FEC. > CONFIG_FEC depends on ColdFire CPUs, which does not apply for the > PPC 8xx processors. FWIW, I have this patch available on the linville-fec_8xx branch of net

Re: [patch 3/3] bnx2: avoid possible overflows in bnx2_get_eeprom

2005-11-09 Thread Michael Chan
On Wed, 2005-11-09 at 16:39 -0500, John W. Linville wrote: > Avoid possible overflows when validating eeprom->offset and eeprom->len > against bp->flash_info->total_size in bnx2_get_eeprom. > It looks like net/core/ethtool.c already has sufficient checking of the offset and length parameters so I

Re: [patch 0/3] e1000: minor fixes

2005-11-09 Thread John W. Linville
On Wed, Nov 09, 2005 at 04:44:21PM -0500, John W. Linville wrote: > On Wed, Nov 09, 2005 at 04:41:05PM -0500, John W. Linville wrote: > > Just a couple of minor fixes for e1000. Individual patches to follow. > > Ooops, this is 0/2 not 0/3... Hopefully it will be less confusing > if I just repost

Re: [patch 0/3] e1000: minor fixes

2005-11-09 Thread John W. Linville
On Wed, Nov 09, 2005 at 04:41:05PM -0500, John W. Linville wrote: > Just a couple of minor fixes for e1000. Individual patches to follow. Ooops, this is 0/2 not 0/3... Hopefully it will be less confusing if I just repost... John -- John W. Linville [EMAIL PROTECTED] - To unsubscribe from this

[patch 0/2] e1000: minor fixes

2005-11-09 Thread John W. Linville
Just a couple of minor fixes for e1000. Individual patches to follow. If more convenient, you can pull from the linville-e1000 branch of netdev-jwl as described below. Thanks, John --- The following changes since commit 330d57fb98a916fa8e1363846540dd420e99499a: Al Viro: Fix sysctl u

[patch 1/2] e1000: avoid leak when e1000_setup_loopback_test fails

2005-11-09 Thread John W. Linville
In e1000_loopback_test, make sure to call e1000_free_desc_rings if e1000_setup_loopback_test fails. Currently in that case it will not get called, causing a leak. Signed-off-by: John W. Linville <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_ethtool.c |4 +++- 1 files changed, 3 insertion

[patch 2/2] e1000: zero-out pointers in e1000_free_desc_rings

2005-11-09 Thread John W. Linville
In e1000_free_desc_rings, zero-out pointers after the memory they point to is freed. The test rings are static and get re-used, and failures during subsequent test setups can cause e1000_free_desc_rings to get called with dirty pointers. Dirty pointers can cause oopses or crashes... Signed-off-b

[patch 0/3] bnx2: minor fixes

2005-11-09 Thread John W. Linville
Just a trio of minor fixes for bnx2. Individual patches to follow. If more convenient, you can pull from the linville-bnx2 branch of netdev-jwl as described below. Thanks, John --- The following changes since commit 330d57fb98a916fa8e1363846540dd420e99499a: Al Viro: Fix sysctl unreg

[patch 3/3] bnx2: avoid possible overflows in bnx2_get_eeprom

2005-11-09 Thread John W. Linville
Avoid possible overflows when validating eeprom->offset and eeprom->len against bp->flash_info->total_size in bnx2_get_eeprom. Signed-off-by: John W. Linville <[EMAIL PROTECTED]> --- drivers/net/bnx2.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) applies-to: 03593ee43957bc3b3b

Re: [Fwd: TSO and 2.6.13.2]

2005-11-09 Thread Ben Greear
Ian McDonald wrote: What about latest netdev tree rather than 2.6.13.2? There have been changes going on... Yep..but the answer is always to try one later build..and it takes time (I reported similar problems in 2.6.11 and was told that 2.6.12 (or maybe .13) was going to fix it...) I am afraid

Re: Consensus? WAS(RFC 2863)

2005-11-09 Thread Krzysztof Halasa
Jamal Hadi Salim <[EMAIL PROTECTED]> writes: > 1) In regards to the connected routes: > - I would agree that there is need to do something about them Right. Anyway, it's not directly relevant and less important so I'd fix it with another patch when the primary objective is done. -- Krzysztof Hal

[patch 1/3] bnx2: output driver name as prefix in error message

2005-11-09 Thread John W. Linville
Output driver name as prefix to "Unknown flash/EEPROM type." message. Signed-off-by: John W. Linville <[EMAIL PROTECTED]> --- drivers/net/bnx2.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) applies-to: 841d5e5eeda46fd95ac03c36964919818a9bc3a6 b03c1f78b764a13a291c26f50f98125cbb7c

[patch 2/3] bnx2: check return of dev_alloc_skb in bnx2_test_loopback

2005-11-09 Thread John W. Linville
Check return of dev_alloc_skb in bnx2_test_loopback, and handle appropriately. Signed-off-by: John W. Linville <[EMAIL PROTECTED]> --- drivers/net/bnx2.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) applies-to: 465a9eb5187941d84c8eede71d8cdd41cfce0a97 5d5bd2c199f11d3359d29cd689a

Re: [Fwd: TSO and 2.6.13.2]

2005-11-09 Thread Lennert Buytenhek
On Thu, Nov 10, 2005 at 10:22:59AM +1300, Ian McDonald wrote: > > > What about latest netdev tree rather than 2.6.13.2? > > > > > > There have been changes going on... > > > > Yep..but the answer is always to try one later build..and > > it takes time (I reported similar problems in 2.6.11 and was

Re: Consensus? WAS(RFC 2863)

2005-11-09 Thread Thomas Graf
* Stefan Rompf <[EMAIL PROTECTED]> 2005-11-09 22:02 > My main concern here are dial on demand interfaces. Routes pointing to them > must be considered even if the interface is !OPER_UP. Routes pointing to > "permanent" interfaces in !OPER_UP should not. Right, we do need a dormant state with all

Re: [Fwd: TSO and 2.6.13.2]

2005-11-09 Thread Ian McDonald
> > > > What about latest netdev tree rather than 2.6.13.2? > > > > There have been changes going on... > > Yep..but the answer is always to try one later build..and > it takes time (I reported similar problems in 2.6.11 and was > told that 2.6.12 (or maybe .13) was going to fix it...) > I am afrai

Re: Consensus? WAS(RFC 2863)

2005-11-09 Thread Thomas Graf
* Jamal Hadi Salim <[EMAIL PROTECTED]> 2005-11-09 15:13 > The link change notification should be handled by the fib code as if it > was an admin notification. Something like this should do the job, although it doesn't take care of taking things up again for now. Now all supporters of this should t

Re: [PATCH] fix unbalanced lock

2005-11-09 Thread David S. Miller
From: Ken-ichirou MATSUZAWA <[EMAIL PROTECTED]> Date: Wed, 09 Nov 2005 22:58:42 +0900 (JST) > ip6ip6_lock is not unlocked in error path. Patch applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] Fix fallout from CONFIG_IPV6_PRIVACY

2005-11-09 Thread David S. Miller
From: Peter Chubb <[EMAIL PROTECTED]> Date: Wed, 9 Nov 2005 11:16:58 +1100 > Trying to build today's 2.6.14+git snapshot gives undefined references > to use_tempaddr > > Looks like an ifdef got left out. > > Signed-off-by: Peter Chubb <[EMAIL PROTECTED]> Applied, thanks Peter. - To unsubscribe

Re: [PATCH 16/15] [NETFILTER] ctnetlink: ICMP_ID is u_int16_t not u_int8_t.

2005-11-09 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Wed, 9 Nov 2005 01:24:19 +0100 > (seems like i can't even count, thus 16/15) hehe... all 16 patches applied, and yes I did use the updated version of patch 8/15 :-) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a me

Re: Consensus? WAS(RFC 2863)

2005-11-09 Thread Stefan Rompf
Am Mittwoch 09 November 2005 21:13 schrieb Jamal Hadi Salim: > I will try and list the contended issues and my comments below. Again, I > may have missed something since it was a quick scan. Ok, time to get on topic again ;-) > 1) In regards to the connected routes: > - I would agree that there

Consensus? WAS(RFC 2863)

2005-11-09 Thread Jamal Hadi Salim
Folks, I just scanned really quickly so maybe missing things .. I will try and list the contended issues and my comments below. Again, I may have missed something since it was a quick scan. 1) In regards to the connected routes: - I would agree that there is need to do something about them - b

Re: [Fwd: TSO and 2.6.13.2]

2005-11-09 Thread Ben Greear
Ian McDonald wrote: It appears that I can (almost?) completedly deadlock a TCP connection when using TSO on 2.6.13.2. My test involves trying to send 200Mbps between two interfaces. With TSO enabled (ie, the default for e1000 NICs), in less than 1 minute, there are no more packets transmitted,

Re: [Fwd: TSO and 2.6.13.2]

2005-11-09 Thread Ian McDonald
> It appears that I can (almost?) completedly deadlock a > TCP connection when using TSO on 2.6.13.2. My test involves > trying to send 200Mbps between two interfaces. With TSO enabled (ie, the > default > for e1000 NICs), in less than 1 minute, there are no more packets transmitted, > though it

[Fwd: TSO and 2.6.13.2]

2005-11-09 Thread Ben Greear
Sent to wrong list first time... Original Message Subject: TSO and 2.6.13.2 Date: Tue, 08 Nov 2005 16:44:05 -0800 From: Ben Greear <[EMAIL PROTECTED]> Organization: Candela Technologies To: '[EMAIL PROTECTED]' <[EMAIL PROTECTED]> It appears that I can (almost?) completedly dea

Re: Patch: RFC2863 #1 (incomplete)

2005-11-09 Thread Thomas Graf
* Stefan Rompf <[EMAIL PROTECTED]> 2005-11-09 17:13 > Am Mittwoch 09 November 2005 15:25 schrieb Thomas Graf: > > > It's still behind eth3 but not reachable at the moment. If you know > > that the network can be reached via other interfaces then just don't > > statically assign a route for it and

[patch 07/11] NET: Fix zero-size datagram reception

2005-11-09 Thread Greg KH
From: Herbert Xu <[EMAIL PROTECTED]> The recent rewrite of skb_copy_datagram_iovec broke the reception of zero-size datagrams. This patch fixes it. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> --- net/core/datagram.c |4 1 file ch

[patch 06/11] airo.c/airo_cs.c: correct prototypes

2005-11-09 Thread Greg KH
From: Adrian Bunk <[EMAIL PROTECTED]> This patch creates a file airo.h containing prototypes of the global functions in airo.c used by airo_cs.c . If you got strange problems with either airo_cs devices or in any other completely unrelated part of the kernel shortly or long after a airo_cs device

Re: Patch: RFC2863 #1 (incomplete)

2005-11-09 Thread Krzysztof Halasa
Thomas Graf <[EMAIL PROTECTED]> writes: > Sorry but OPER_DORMANT_L3DOWN is what this discussion was all about, > if you're talking of something else you should say so. OPER_DORMANT_L3DOWN, yes. So we now have about 1 day if we want (do we still?) to have something in 2.6.15 if I calculate correct

[PATCH 2.6.14 11/18] move bond creation into separate function

2005-11-09 Thread Mitch Williams
The sysfs interface can create bonds at runtime, so we need a separate function to do this, instead of just doing it in the module init code. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bonding.h linux-2.6.14/drivers/net/bon

[PATCH 2.6.14 10/18] make functions not static

2005-11-09 Thread Mitch Williams
The sysfs code needs access these functions, so make them not static, and move the protos to the header file. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bonding.h linux-2.6.14/drivers/net/bonding/bonding.h --- linux-2.6.14-

[PATCH 2.6.14 16/18] version update

2005-11-09 Thread Mitch Williams
Update the version number for the bonding module. Since we've just added a significant new feature (sysfs support), bump the major number. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bonding.h linux-2.6.14/drivers/net/bondi

[PATCH 2.6.14 8/18] explicitly clear RLB flag during ALB init

2005-11-09 Thread Mitch Williams
Explicitly clear RLB flag during ALB init. This is needed for sysfs support, since the bond mode can be changed at runtime via sysfs. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X linux-2.6.13/Documentation/dontdiff linux-2.6.14-rc2-clean/drivers/net/bonding/bond_alb.c linux

[PATCH 2.6.14 14/18] add ARP entries to /proc

2005-11-09 Thread Mitch Williams
Make the /proc files show which ARP targets are in use by each bond. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bond_main.c linux-2.6.14/drivers/net/bonding/bond_main.c --- linux-2.6.14-release/drivers/net/bonding/bond_main

[PATCH 2.6.14 9/18] expose some structs

2005-11-09 Thread Mitch Williams
The sysfs code needs to know what these structs look like, so make them not static, and move the definition to the header. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X linux-2.6.13/Documentation/dontdiff linux-2.6.14-rc2-clean/drivers/net/bonding/bonding.h linux-2.6.14-rc2/

[PATCH 2.6.14 15/18] add sysfs functionality to bonding (large)

2005-11-09 Thread Mitch Williams
This large patch adds sysfs functionality to the channel bonding module. Bonds can be added, removed, and reconfigured at runtime without having to reload the module. Multiple bonds with different configurations are easily configured, and ifenslave is no longer required to configure bonds. Signed

[PATCH 2.6.14 17/18] spelling and whitespace corrections

2005-11-09 Thread Mitch Williams
Minor spelling and whitespace corrections. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bond_alb.c linux-2.6.14/drivers/net/bonding/bond_alb.c --- linux-2.6.14-release/drivers/net/bonding/bond_alb.c 2005-11-08 11:17:47.00

[PATCH 2.6.14 12/18] make bond_init not __init

2005-11-09 Thread Mitch Williams
The sysfs interface can create bonds at runtime, and __init code goes away after module init. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bond_main.c linux-2.6.14/drivers/net/bonding/bond_main.c --- linux-2.6.14-release/driv

[patch 05/11] tcp: BIC max increment too large

2005-11-09 Thread Greg KH
From: Stephen Hemminger <[EMAIL PROTECTED]> The max growth of BIC TCP is too large. Original code was based on BIC 1.0 and the default there was 32. Later code (2.6.13) included compensation for delayed acks, and should have reduced the default value to 16; since normally TCP gets one ack for ever

[PATCH 2.6.14 7/18] move kmalloc out of spinlock in ALB init

2005-11-09 Thread Mitch Williams
Move memory allocations out of the spinlock during ALB init. This gets rid of a sleeping-inside-spinlock warning and accompanying stack dump. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X linux-2.6.13/Documentation/dontdiff linux-2.6.14-rc2-clean/drivers/net/bonding/bond_alb.

[PATCH 2.6.14 18/18] comments and changelog

2005-11-09 Thread Mitch Williams
Bonding source files still have changelogs in the comments. This, then, is an update to that changelog. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bonding.h linux-2.6.14/drivers/net/bonding/bonding.h --- linux-2.6.14-relea

[PATCH 2.6.14 13/18] Allow ARP target table to have empty entries

2005-11-09 Thread Mitch Williams
With the sysfs interface, the user can remove entries from the ARP table at runtime. The ARP monitor code now allows for empty entries in the table. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bond_main.c linux-2.6.14/drive

[PATCH 2.6.14 4/18] expand module param descriptions

2005-11-09 Thread Mitch Williams
Expand and correct the parameter descriptions shown by modinfo. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bond_main.c linux-2.6.14/drivers/net/bonding/bond_main.c --- linux-2.6.14-release/drivers/net/bonding/bond_main.c

[PATCH 2.6.14 5/18] Add transmit policy to /proc

2005-11-09 Thread Mitch Williams
Adds information about the recently-added transmit policy setting to each bond's /proc file. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bond_main.c linux-2.6.14/drivers/net/bonding/bond_main.c --- linux-2.6.14-release/driver

[PATCH 2.6.14 3/18] add bond name to all error messages

2005-11-09 Thread Mitch Williams
Add the bond name to all error messages so we can tell which one is complaining. Also reformats some error messages to be more consistent. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X linux-2.6.13/Documentation/dontdiff linux-2.6.14-rc2-clean/drivers/net/bonding/bond_3ad.c

[PATCH 2.6.14 2/18] make dev_valid_name public

2005-11-09 Thread Mitch Williams
dev_valid_name() is a useful function. Make it public. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-clean/include/linux/netdevice.h linux-2.6.14/include/linux/netdevice.h --- linux-2.6.14-clean/include/linux/netdevice.h2005-10-27 17:02:08.0

[PATCH 2.6.14 6/18] get slave name from actual slave instead of param list

2005-11-09 Thread Mitch Williams
Take the primary slave name shown in /proc from the actual slave dev instead of from the command-line parameter, which won't be present if the bond is created via sysfs. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bond_main.c

[PATCH 2.6.14 0/18] Yet Another Bonding Sysfs patchset

2005-11-09 Thread Mitch Williams
Jay says he's finally ready to take this patch. So here we go again. Rebased against 2.6.14 final. Which turned out to be way more work than I expected. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messa

Re: Patch: RFC2863 #1 (incomplete)

2005-11-09 Thread Krzysztof Halasa
Thomas Graf <[EMAIL PROTECTED]> writes: > OK, I'm gonna explain how I see it a bit more detailed to hopefully > make things clearer. Somehow it seems to be assumed that addresses have > to be configured as prefixes, already including the netmask of the > subnet it is on. This feature added recentl

[PATCH 2.6.14 1/18] allow newline terminated IP addresses in in_aton

2005-11-09 Thread Mitch Williams
in_aton() gives weird results if it sees a newline at the end of the input. This patch makes it able to handle such input correctly. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-clean/net/core/utils.c linux-2.6.14/net/core/utils.c --- linux-2.6.14-clean/

Re: Patch: RFC2863 #1 (incomplete)

2005-11-09 Thread Krzysztof Halasa
Hasso Tepper <[EMAIL PROTECTED]> writes: > No. This mandates usage of routing daemon even in my laptop which is > nonsense. Precisely. If the routes are dropped on !IFF_RUNNING, one could ifconfig 10.0.0.1 peer 10.0.0.2 dev eth0 ifconfig 10.0.0.1 peer 10.0.0.2 dev irdanet0 ifconfig 10.0.0.1 peer

[PATCH] gianfar mii needs to zero out the mii_bus structure

2005-11-09 Thread Kumar Gala
To ensure that phy_mask and any future elements of the mii_bus structure are initialized use kzalloc() instead of kmalloc(). This fixes an issue in which phy_mask was not being initialized and we would skip random phy addresses when scanning. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- com

Re: Patch: RFC2863 #1 (incomplete)

2005-11-09 Thread Stefan Rompf
Am Mittwoch 09 November 2005 15:25 schrieb Thomas Graf: > It's still behind eth3 but not reachable at the moment. If you know > that the network can be reached via other interfaces then just don't > statically assign a route for it and have the routing daemon take care > of it, where's the problem

Re: sendfile system call and UDP sockets

2005-11-09 Thread Tom Marshall
> Here is the program I use and the error I get after > I send one UDP packet to this machine on the port it listens on ,9000. > > [...] > > The error get is: > > errno = ESPIPE > sendfile: Destination address required You might want to try connect()ing the socket... -- Coincid

  1   2   >