Re: [PATCH] Fix netpoll bug in Sun GEM Ether driver

2005-08-26 Thread David S. Miller
You're taking my suggestion way too far. Just replicate gem_interrupt() inline into gem_poll_controller(), removing the irrelevant bits by hand. You shouldn't need to modify gem_poll() at all, just as in your original patch. - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH] Fix netpoll bug in Sun GEM Ether driver

2005-08-26 Thread Geoff Levand
David S. Miller wrote: > From: Geoff Levand <[EMAIL PROTECTED]> > Date: Thu, 25 Aug 2005 22:13:57 -0700 > > >>@@ -970,7 +970,8 @@ >> /* gem_interrupt is safe to reentrance so no need >> * to disable_irq here. >> */ >>- gem_interrupt(dev->irq, dev, NULL); >>+ if(gem_interr

Re: ieee80211 patches

2005-08-26 Thread Michael Wu
On Friday 26 August 2005 12:13, Jiri Benc wrote: > You mentioned problem with hooks in scanning/association/etc. Probably > everybody involved in this discussion knows it but I think it is worth > saying it: This is one of the most important things in a new ieee80211 > layer. Unfortunately, it seem

Re: Question on debugging reference counts on Net devices.

2005-08-26 Thread Ben Greear
David S. Miller wrote: From: Ben Greear <[EMAIL PROTECTED]> Date: Fri, 26 Aug 2005 16:34:49 -0700 And for the record, I grepped a great deal of dev_holds, but associating a particular get with a put is making my head hurt :) How about the one, and only one, in that file that adds the SKBs t

Re: Question on debugging reference counts on Net devices.

2005-08-26 Thread David S. Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Fri, 26 Aug 2005 16:34:49 -0700 > And for the record, I grepped a great deal of dev_holds, but > associating a particular get with a put is making my head hurt :) How about the one, and only one, in that file that adds the SKBs to the input_pkt_queue lis

Re: Question on debugging reference counts on Net devices.

2005-08-26 Thread Ben Greear
David S. Miller wrote: netif_rx() grabs the device reference, this wasn't hard to figure out, I just grep'd and you could have done so as well :-) Ahh, ok. And it's safe to not hold it before then because the net-device can't go away before or during it's call netif_rx... And for the record,

Re: Question on debugging reference counts on Net devices.

2005-08-26 Thread David S. Miller
netif_rx() grabs the device reference, this wasn't hard to figure out, I just grep'd and you could have done so as well :-) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-inf

Re: Question on debugging reference counts on Net devices.

2005-08-26 Thread Ben Greear
In dev.c's process_backlog, there is code like this: dev = skb->dev netif_receive_skb(skb); dev_put(dev); Do you happen to know what piece of code takes this reference to the device in the first place? Also, why not make the co

Re: 2.6.12 Performance problems

2005-08-26 Thread Danial Thom
--- Danial Thom <[EMAIL PROTECTED]> wrote: > > > --- Ben Greear <[EMAIL PROTECTED]> wrote: > > > Danial Thom wrote: > > > > > > --- Ben Greear <[EMAIL PROTECTED]> > > wrote: > > > > > > > > >>Danial Thom wrote: > > >> > > >> > > >>>I think the concensus is that 2.6 has made > > >> > > >>tr

Re: 2.6.12 Performance problems

2005-08-26 Thread Benjamin LaHaise
On Thu, Aug 25, 2005 at 09:55:27AM -0700, Ben Greear wrote: > Of course. Never found a motherboard yet with decent built-in > NICs. The built-ins on this board are tg3 and they must be on > a slow bus, because they cannot go faster than about 700Mbps > (using big pkts). There should be a number

Re: [PATCH] [NET] use __read_mostly on kmem_cache_t , DEFINE_SNMP_STAT pointers

2005-08-26 Thread David S. Miller
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Date: Fri, 26 Aug 2005 05:49:12 -0300 > Eric, without questioning the merit of the changes David oposed to, his > request for splitting the patch is reasonable, could you please do that? Now that he's explained the SNMP case, it really isn't nece

Re: [PATCH] [NET] use __read_mostly on kmem_cache_t , DEFINE_SNMP_STAT pointers

2005-08-26 Thread David S. Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 26 Aug 2005 09:11:14 +0200 > The patch I suggested only changed the root pointer, moving to read_mostly > section because it is really write once at boot, then read only. I totally missed that, thanks for clarifying. I'll apply your patch, thank

Re: [Bugme-new] [Bug 5131] New: Computer hangs when default-gw becomes unreachable

2005-08-26 Thread Sebastian Hyrwall
Andrew Morton wrote: [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=5131 Summary: Computer hangs when default-gw becomes unreachable Kernel Version: 2.6.13-rc3-mm1 ... Right now I'm going to try 2.6.13-rc7 to see if the problem occurs there too. T

Re: ieee80211 patches

2005-08-26 Thread Jiri Benc
On Fri, 26 Aug 2005 09:10:45 -0400, Mike Kershaw wrote: > It's archived off the sourceforge page (http://ipw2200.sourceforge.net > or http://sourceforge.net/mailarchive/forum.php?forum_id=38938) I've found two threads regarding this; if anybody else is interested and doesn't want to spend ages sea

Re: ieee80211 patches

2005-08-26 Thread Jiri Benc
On Fri, 26 Aug 2005 11:07:07 -0400, Michael Wu wrote: > http://aluminum.sourmilk.net/adm8211/index.php?path=netdev/ Looks good for the first view. Unfortunately I won't have enough time to look closely until next week. > - adm8211 supports shared key authentication, rtl8180-sa2400 only supports

RE: PATCH net-drivers-2.6 1/8] e1000: Support for 82571 and 82572 controllers

2005-08-26 Thread Venkatesan, Ganesh
Jeff: I still do not see your point. Calls to msec_delay() that you pointed us to resolve to msleep() and NOT mdelay(). In addition we have the advantage of msec_delay() checking the context (in the case the human verification was incorrect). Ganesh. >-Original Message- >From: Jeff Garz

Re: ieee80211 patches

2005-08-26 Thread Michael Wu
On Friday 26 August 2005 08:08, Jiri Benc wrote: > On Thu, 25 Aug 2005 20:49:52 -0400, Michael Wu wrote: > > I hope to submit the adm8211 driver for review soon, but there's a bunch > > of code in the driver which probably belong in the ieee80211 code: > > > > - Duplicate frame removal > > - Defini

Re: PATCH net-drivers-2.6 4/8] e1000: Backout watchdog task patch from John Linville

2005-08-26 Thread John W. Linville
On Thu, Aug 25, 2005 at 01:24:14PM -0700, Malli Chilakala wrote: > Backout watchdog task patch from John Linville > > Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> > Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> > Signed-off-by: John Ronciak <[EMAIL PROTECTED]> BTW, I think t

Re: PATCH net-drivers-2.6 4/8] e1000: Backout watchdog task patch from John Linville

2005-08-26 Thread John W. Linville
Note to all: please use this address when copying me regarding upstream matters. It keeps my mailboxes better sorted...thanks! Since I'm being called-out by name, I suppose I should add my $0.02... :-) On Thu, Aug 25, 2005 at 04:38:35PM -0400, Jeff Garzik wrote: > Malli Chilakala wrote: > >Backo

Re: ieee80211 patches

2005-08-26 Thread Michael Wu
On Friday 26 August 2005 05:04, Stefan Rompf wrote: > > - AVS capture header in monitor mode > > there has been a discussion about AVS or radiotap header on the ipw list > that resulted in the inclusion of radiotap definitions in James' latest > patches for ieee80211. Radiotap requires a libpcap up

Re: [PATCH] [NET] use __read_mostly on kmem_cache_t , DEFINE_SNMP_STAT pointers

2005-08-26 Thread Eric Dumazet
Benjamin LaHaise a écrit : On Fri, Aug 26, 2005 at 09:11:14AM +0200, Eric Dumazet wrote: The patch I suggested only changed the root pointer, moving to read_mostly section because it is really write once at boot, then read only. This is the same with slab pointers : they are hot objects (read/

Re: [PATCH] [NET] use __read_mostly on kmem_cache_t , DEFINE_SNMP_STAT pointers

2005-08-26 Thread Benjamin LaHaise
On Fri, Aug 26, 2005 at 09:11:14AM +0200, Eric Dumazet wrote: > The patch I suggested only changed the root pointer, moving to read_mostly > section because it is really write once at boot, then read only. This is > the same with slab pointers : they are hot objects (read/written all the > time)

Re: ieee80211 patches

2005-08-26 Thread Mike Kershaw
On Fri, Aug 26, 2005 at 02:11:07PM +0200, Jiri Benc wrote: > On Fri, 26 Aug 2005 11:04:15 +0200, Stefan Rompf wrote: > > there has been a discussion about AVS or radiotap header on the ipw list > > Does it have an archive on web? If so, could you post an address of that > thread? It's archived of

Re: ieee80211 patches

2005-08-26 Thread Jiri Benc
On Fri, 26 Aug 2005 11:04:15 +0200, Stefan Rompf wrote: > there has been a discussion about AVS or radiotap header on the ipw list Does it have an archive on web? If so, could you post an address of that thread? Thanks, -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the line "unsu

Re: ieee80211 patches

2005-08-26 Thread Jiri Benc
On Thu, 25 Aug 2005 20:49:52 -0400, Michael Wu wrote: > I hope to submit the adm8211 driver for review soon, but there's a bunch of > code in the driver which probably belong in the ieee80211 code: > > - Duplicate frame removal > - Definitions for all management payloads > - SIOCSIWENCODEEXT and

Re: [PATCH]: PHY Layer fixup

2005-08-26 Thread David Hollis
On Thu, 2005-08-25 at 15:51 -0500, Andy Fleming wrote: > On Aug 25, 2005, at 15:04, David Hollis wrote: > > > > > > Question for you, I'm trying to setup my mdio_bus driver and I don't > > know how I can get it registered at the appropriate time. I can't > > read > > the PHY IDs until after I'

Re: ieee80211 patches

2005-08-26 Thread Jiri Benc
On Thu, 25 Aug 2005 20:30:26 -0400, Jeff Garzik wrote: > > add-seq-number.patch > > Adds sequence numbers to transmitted frames. > > any security implications here, as with TCP sequence numbers? 802.11 sequence numbers are intended solely for duplicate frame filtering (chapter 9.2.9 in IEEE 8

Re: [Bugme-new] [Bug 5131] New: Computer hangs when default-gw becomes unreachable

2005-08-26 Thread Andrew Morton
[EMAIL PROTECTED] wrote: > > http://bugzilla.kernel.org/show_bug.cgi?id=5131 > >Summary: Computer hangs when default-gw becomes unreachable > Kernel Version: 2.6.13-rc3-mm1 > > ... > > Right now I'm going to try 2.6.13-rc7 to see if the problem occurs there too. > Thanks. It wo

Re: ieee80211 patches

2005-08-26 Thread Jiri Benc
On Fri, 26 Aug 2005 00:31:06 +0200, Pavel Machek wrote: > > ieee-dev-alignment.patch > > +static inline void *ieee80211_dev_to_priv(struct net_device *dev) > +{ > + return (char *)dev + > + ((sizeof(struct net_device) + NETDEV_ALIGN_CONST) > + & ~NETDEV_AL

Netlink connector. Revisited.

2005-08-26 Thread Evgeniy Polyakov
Kernel connector - new userspace <-> kernel space easy to use communication module which implements easy to use bidirectional message bus using netlink as it's backend. Connector was created to eliminate complex skb handling both in send and receive message bus direction. Connector driver adds pos

Re: ieee80211 patches

2005-08-26 Thread Stefan Rompf
Hi, Am Freitag 26 August 2005 02:49 schrieb Michael Wu: > I hope to submit the adm8211 driver for review soon, but there's a bunch of > code in the driver which probably belong in the ieee80211 code: [...] > - AVS capture header in monitor mode there has been a discussion about AVS or radiotap h

Re: [PATCH] [NET] use __read_mostly on kmem_cache_t , DEFINE_SNMP_STAT pointers

2005-08-26 Thread Arnaldo Carvalho de Melo
On 8/26/05, Eric Dumazet <[EMAIL PROTECTED]> wrote: > David S. Miller a écrit : > > From: Eric Dumazet <[EMAIL PROTECTED]> > > Date: Fri, 26 Aug 2005 03:07:06 +0200 > > > > > >>On one of my production machine, tcp_statistics was sitting in a heavily > >>modified cache line, so *every* SNMP update h

Re: [PATCH] [NET] use __read_mostly on kmem_cache_t , DEFINE_SNMP_STAT pointers

2005-08-26 Thread Eric Dumazet
David S. Miller a écrit : From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 26 Aug 2005 03:07:06 +0200 On one of my production machine, tcp_statistics was sitting in a heavily modified cache line, so *every* SNMP update had to force a reload. But I disagree that statistics belong in the __r